Commit Graph

8976 Commits

Author SHA1 Message Date
anthony bills
f573ba06f6 Add missing null checks to PluginDescriptor.cs
- Previously this would have been handled by WriteArray, now Plugins and Modules are a List and ToArray is called, the check needs to be moved up.

#rb rob.cannaday
[FYI] ben.marsh
#jira none

#ROBOMERGE-SOURCE: CL 11723339 in //UE4/Release-4.25/... via CL 11723340
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11723343 by anthony bills in Main branch]
2020-02-27 22:21:28 -05:00
graeme thornton
6d558efbd1 UAT: Fixed alternate cook source pak file ignoring
#ROBOMERGE-SOURCE: CL 11596079 via CL 11596080 via CL 11596081
#ROBOMERGE-BOT: (v656-11643781)

[CL 11719001 by graeme thornton in Main branch]
2020-02-27 20:59:51 -05:00
ben marsh
e03ee48fbd Fix exception due to directory not existing when creating VSCode project.
#rb none
#jira UE-89684
#rnx

#ROBOMERGE-SOURCE: CL 11661535 in //UE4/Release-4.25/... via CL 11661587
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11661659 by ben marsh in Main branch]
2020-02-27 11:44:52 -05:00
ben marsh
ffd2f1ede7 Fix detection of engine modules being out of date.
#rb none
#jira UE-88824, UE-89676

#ROBOMERGE-SOURCE: CL 11658206 in //UE4/Release-4.25/... via CL 11658244
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11658322 by ben marsh in Main branch]
2020-02-27 11:10:22 -05:00
anthony bills
1ef400627b Add support for whitelisting additional plugins and adding additional modules to plugin extensions.
Additionally allow monolithic programs inside platform extensions to ouput to the Binaries directory in the extension.

[at]brian.white, [at]josh.adams, [at]ben.marsh
#jira UE-81798
#rb ben.marsh

#ROBOMERGE-SOURCE: CL 11655119 in //UE4/Release-4.25/... via CL 11655234
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11655284 by anthony bills in Main branch]
2020-02-27 10:47:20 -05:00
emil kirichev
d9a9d5421f Some entities in Revit exporter Datasmith scenes have an offset on their meshes
#jira UE-88545
#rb JeanLuc.Corenthin

#ROBOMERGE-SOURCE: CL 11647759 in //UE4/Release-4.25/... via CL 11647760
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11647762 by emil kirichev in Main branch]
2020-02-27 07:31:28 -05:00
chris babcock
c3e14aa762 Add option to force use of legacy ld instead of lld for Android
#jira UE-89634
#ue4
#android
#rb Jack.Porter


#ROBOMERGE-SOURCE: CL 11646388 in //UE4/Release-4.25/... via CL 11646389
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11646391 by chris babcock in Main branch]
2020-02-26 22:08:53 -05:00
Ben Marsh
a7ebd68aed Fix exception running IncludeTool due to include path modules no longer being included in JSON export.
#rb none
#jira UE-89475
#robomerge[RELEASE] 4.25

[CL 11645998 by Ben Marsh in Main branch]
2020-02-26 21:06:57 -05:00
chris babcock
acfe9391e3 Fix NDK20 fallback tool paths for some architectures and disable ld.gold for ARM64
#jira UE-89658
#ue4
#android
#rb trivial

#ROBOMERGE-SOURCE: CL 11645559 in //UE4/Release-4.25/... via CL 11645563
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11645565 by chris babcock in Main branch]
2020-02-26 20:48:49 -05:00
ben marsh
b628ea923c Fix missing properties on command line to MSBuild when compiling automation projects.
#rb none
#jira

#ROBOMERGE-SOURCE: CL 11645538 in //UE4/Release-4.25/... via CL 11645541
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11645543 by ben marsh in Main branch]
2020-02-26 20:44:30 -05:00
ben marsh
7b125a79c6 Fix manifest error linking UnrealVersionSelector.
#rb none
#jira

#ROBOMERGE-SOURCE: CL 11640359 in //UE4/Release-4.25/... via CL 11640368
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11640414 by ben marsh in Main branch]
2020-02-26 14:21:05 -05:00
ben marsh
a26431c2ab UBT: Produce an error if any output path is longer than MAX_PATH on Windows.
#rb none
#jira UE-75445

#ROBOMERGE-SOURCE: CL 11638471 in //UE4/Release-4.25/... via CL 11638491
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11638504 by ben marsh in Main branch]
2020-02-26 13:44:50 -05:00
brice criswell
d18511700e HeadlessChaos :
-Comment out clustering tests until the api is working again.

#rb none
#jira nojira

#ROBOMERGE-SOURCE: CL 11637934 in //UE4/Release-4.25/... via CL 11637944
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11637999 by brice criswell in Main branch]
2020-02-26 13:34:30 -05:00
ben marsh
628a79285c Don't allow UBT to try and compile engine modules when the engine is already running.
#rb none
#jira UE-88824

#ROBOMERGE-SOURCE: CL 11637884 in //UE4/Release-4.25/... via CL 11637925
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11637942 by ben marsh in Main branch]
2020-02-26 13:33:44 -05:00
patrick laflamme
58925c4e1d #jira UE-87927 - Disaster Recovery doesn't restore a crash from a restored session
- Added the ability to copy and restore a live session, preventing the need to archive it in first place, making the server exist fast (releasing the session lock very quickly) before showing the crash UI and before the next Editor instance could starts.

Details:

This bug could manifest if various ways. An issue causing this bug was fixed in 11252374. This bug can also be observed if the crash reporting process doesn't release its lock on the crashed session quickly. Archiving a session may takes several minutes (depending on the session size) and while a session is archiving, its database is locked and cannot be restored until the archiving process complets. When the Editor reboots after a crash, it searches for a session to recover, but skip over any session that is mounted/locked assuming the session is concurrently used by a concurrent Editor process, potentially preventing it from restoring. The optimal way to work around this problem  is to skip the archiving step. Instead, the live session is never archived (saving a copy), which allows the recovery service to shutdown and release the session lock very quickly ensuring that the session will be unlocked when the Editor restarts. On Editor start, it a crashed session is found and the user decides to restore it, the live session is copied into a new live session.

This changelist also affect those other jira in the following ways:

#jira UE-87899 - Disaster recovery prevents showing the crash reporting UI in a timely manner if the session is large
  - This CL changes execution order to shut down the recovery service ASAP to release the lock, but the optimization above make it super fast, so the UI should always be shown in a timely manner.

#jira UE-87927 - Disaster Recovery doesn't restore a crash from a restored session
  - This CL ensures the recovery service release the session lock faster than the next instance of the Editor can start.

#jira UE-87900 - Disaster Recovery stops recording transactions if the UDP transport layer restarts or auto-repair
#jira UE-88517 - Concert Log Spam - (ConcertKeepAlive) discarded
  - This CL fixes an issues with endpoints timeout logic.

#jira UE-81049 - Clean up the DisasterRecovery Intermediate directory
  - This CL added code to clean up the intermediate directory left over by crashed client.

#rb Francis.Hurteau

#ROBOMERGE-SOURCE: CL 11632069 in //UE4/Release-4.25/... via CL 11632084
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11632094 by patrick laflamme in Main branch]
2020-02-26 11:18:30 -05:00
ben marsh
458b71b27f Fix error attempting to embed manifest into executable.
#rb none
#jira UE-89552

#ROBOMERGE-SOURCE: CL 11632049 in //UE4/Release-4.25/... via CL 11632050
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11632058 by ben marsh in Main branch]
2020-02-26 11:17:09 -05:00
ben marsh
2868a46d82 Remove debug code.
#rb none
#rnx
#jira

#ROBOMERGE-SOURCE: CL 11631935 in //UE4/Release-4.25/... via CL 11631941
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11631949 by ben marsh in Main branch]
2020-02-26 11:06:01 -05:00
ben marsh
a3cada401a Fix incorrect force included files in intellisense data.
#rb none
#jira UE-89364

#ROBOMERGE-SOURCE: CL 11631903 in //UE4/Release-4.25/... via CL 11631909
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11631916 by ben marsh in Main branch]
2020-02-26 11:03:42 -05:00
ben marsh
8031d00cef UBT: Remove read-only files when cleaning a target.
#rb none
#jira UE-89548

#ROBOMERGE-SOURCE: CL 11631033 in //UE4/Release-4.25/... via CL 11631036
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11631049 by ben marsh in Main branch]
2020-02-26 09:56:11 -05:00
ben marsh
1402b8eb9b Ignore check for active Live Coding session if the -NoHotReloadFromIDE argument is present. Allows creating a new C++ project while Live Coding is active.
#rb none
#jira UE-82398

#ROBOMERGE-SOURCE: CL 11630897 in //UE4/Release-4.25/... via CL 11630908
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11630926 by ben marsh in Main branch]
2020-02-26 09:50:01 -05:00
ben marsh
39179672d2 Output a warning if the root path is longer than 50 characters.
#rb none
#jira UE-88446
[FYI] Martin.Sevigny

#ROBOMERGE-SOURCE: CL 11625250 in //UE4/Release-4.25/... via CL 11625255
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11625268 by ben marsh in Main branch]
2020-02-25 21:06:22 -05:00
ben marsh
661248e268 UBT: Output a warning if any intermediate path is > 200 characters under the UE root directory.
#rb none
#jira UE-88446

#ROBOMERGE-SOURCE: CL 11624846 in //UE4/Release-4.25/... via CL 11624849
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11624868 by ben marsh in Main branch]
2020-02-25 20:49:06 -05:00
ben marsh
5688548c44 Fix UBT always writing logs to user folder, rather than just in installed builds.
#rb none
#rnx
#jira

#ROBOMERGE-SOURCE: CL 11624709 in //UE4/Release-4.25/... via CL 11624720
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11624754 by ben marsh in Main branch]
2020-02-25 20:44:14 -05:00
ben marsh
592183f442 Prevent writing compiled assemblies to installed engine directory. Write them to the AppData folder instead.
#jira
#rb none

#ROBOMERGE-SOURCE: CL 11619452 in //UE4/Release-4.25/... via CL 11619471
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11619492 by ben marsh in Main branch]
2020-02-25 16:49:43 -05:00
ben marsh
d1eb7b7007 UBT: Always embed an application manifest during linking, rather than relying on the resource file to include one. This ensures that projects that have a custom resource file for icons, versioning metadata, etc... still operate correctly with manifested OS versions.
To embed a custom manifest, set the WindowsPlatform.ManifestFile to a vaild path in a *.Target.cs file. To disable the embedding of the default manifest, set it to null.

#rb none
#jira UE-88825, UE-87398

#ROBOMERGE-SOURCE: CL 11619014 in //UE4/Release-4.25/... via CL 11619045
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11619057 by ben marsh in Main branch]
2020-02-25 16:33:18 -05:00