- Remove redundant static calls on AudioDevice in favor of AudioDeviceManager for finding Main/Active Devices (state managed by the manager, not individual devices)
#rb ethan.geller ryan.mangin
#ROBOMERGE-SOURCE: CL 11119764 via CL 11119771
#ROBOMERGE-BOT: (v640-11091645)
[CL 11119776 by rob gay in Main branch]
#rnx
#rb none
#ROBOMERGE-OWNER: ryan.durand
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869210 via CL 10869511 via CL 10869900
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870549 by ryan durand in Main branch]
Get GIsRequestingExit now by IsEngineRequestingExit()
Set GIsRequestingExit now by RequestEngineExit(const TCHAR* Reason) or RequestEngineExit(const FString& Reason)
NOTE If Reason is 4 or less chars it will generate an ensure to force a reason to exit
The reason behind this change is right now setting GIsRequestingExit to true can cause many things to break mainly early on and with out any sort of log warning we have entered this state. We should wrap this behind a function to allow for proper handling
#rb Chris.Babcock, Michael.Trepka, Michael.Noland
#jira UE-79933
[FYI] Michael.Noland
#ROBOMERGE-SOURCE: CL 8649683 via CL 8653683
#ROBOMERGE-BOT: (v417-8656536)
[CL 8658680 by brandon schaefer in Main branch]
Fixes an instance of GC timeout which is waiting for USoundWave objects.
#rb Ethan.Geller
[FYI] Ethan.Geller
#ROBOMERGE-SOURCE: CL 7450092 via CL 7461928 via CL 7467255
#ROBOMERGE-BOT: (v371-7306989)
[CL 7467324 by allan bentham in Main branch]
Solve issues during start-up where the HW window can be created/lost before the game can use it or OS displaying android ANR message if GT is too busy to respond to system events.
Window access is guarded with mutex that guarantees a valid window HW exists when locked.
Rendering thread is blocked when the window is lost (to prevent RHIs accessing surfaces belonging to the lost window)
Window dimensions are cached so that most window dimension queries just read from the cache.
[FYI] chris.babcock, Ryan.Vance
#rb jack.porter, chris.babcock,Dmitriy.Dyomin
#ROBOMERGE-OWNER: allan.bentham
#ROBOMERGE-AUTHOR: allan.bentham
#ROBOMERGE-SOURCE: CL 7062033 via CL 7062034 via CL 7062345
#ROBOMERGE-BOT: (v367-6836689)
[CL 7062346 by allan bentham in Main branch]
#android
[REVIEW]
[FYI] Allan.Bentham,Jack.Porter
#rb Allan.Bentham
#ROBOMERGE-SOURCE: CL 6870937 via CL 6870938 via CL 6870939 via CL 6872367
#ROBOMERGE-BOT: (v366-6836689)
[CL 6872381 by chris babcock in Main branch]
-If we skip a window create because a window destroy event came in before we could process it we now destroy the window and pause rendering so that when a window is created it builds up all state fresh. Previously we sometimes ended up with the frame buffer oriented incorrectly or some undiagnosed problem which resulted in an all black screen.
#jira UE-65414
#rb Ryan.Vance
#ROBOMERGE-SOURCE: CL 5371838 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)
[CL 5371841 by jeff fisher in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3873313 by Nick.Atamas
Merging CL 3834212 using //UE4/Dev-VR=>//Tasks/UE4/Dev-VR-4.19a
Merging CL 3805354, CL 3822769, CL 3827454, CL 3831789
//UE4/Partner-Google-VR/Engine/...
to //Tasks/UE4/Dev-VR-4.19a/Engine/...
Change 3873330 by Nick.Atamas
Merging CL 3835373 using //UE4/Dev-VR=>//Tasks/UE4/Dev-VR-4.19a
Merging CL 3777058
//UE4/Partner-Google-VR/Engine/...
to //Tasks/UE4/Dev-VR-4.19a/Engine/...
and fixing up QAARApp to work with latest ARCore changes.
Change 3873791 by Nick.Atamas
Merging //UE4/Dev-Main@3866324 to Dev-VR (//UE4/Dev-VR) to get missing files and fixing CIS.
Change 3933769 by Keli.Hlodversson
Remove unused IStereoRendering::GetCustomPresent
#jira UEVR-1083
Change 3935219 by Nick.Atamas
QAARApp re-write.
Change 3935664 by Mike.Beach
Oculus SI 1.23 changes
Change 3941505 by Joe.Graf
Made the send & recv buffer sizes for the BackChannel plugin configurable
Added send & recv counters for tracking the amount of transmission data
Change 3944003 by Joe.Graf
Added -buildscw to the CMake build command lines for editors to match what XCode is doing on Mac
Change 3945189 by Douglas.Copeland
Saving Material with Use w/ Static Lighting Flag set to resolve Engine warnings
Change 3945245 by Douglas.Copeland
Resaving QA_MeshTypes asset to resolve warnings produced by missing info
Change 3945266 by Douglas.Copeland
Updating TM-HMDNodes LevelBP WallofGets to use PxielDensity instead of ScreenPercentage. Resolving Engine warnings
Change 3947785 by Mike.Beach
Oculus changes to Android core count - only count usable cores not deadicated to the OS, etc.
Change 3951763 by Joe.Graf
Fixed thread ordering bug with remote session frame compression
Change 3952242 by Joe.Graf
Saved about 20-25% of the cpu time for compressing jpeg when performing the cpu swizzle
Change 3954571 by Keli.Hlodversson
* Add FXRRenderBridge base class containing common code from different CustomPresent implementations.
* Create a default implementation of UpdateViewportRHIBridge in FXRRenderTargetManager by adding GetActiveRenderBridge_GameThread.
** The default implementation now handles calling View->SetCustomPresent instead of making it up to the custom present (now XRRenderBridge) implementation (it already had to handle when the custom present was null.)
* Remove unused member variable ViewportRHI from RHICustomPresent.
#jira UEVR-1081
Change 3954572 by Keli.Hlodversson
* Apply XRRenderBridge and XRRenderTargetManager changes to the SteamVR plugin
* Move duplicated methods into an already existing BridgeBaseImpl class
#jira UEVR-592
Change 3954573 by Keli.Hlodversson
* Apply XRRenderBridge refactor to Oculus plugin
#jira UEVR-590
Change 3954575 by Keli.Hlodversson
* Apply XRRenderBridge refactor to OSVR
#jira UEVR-595
Change 3954578 by Keli.Hlodversson
* Apply XRRenderBridge refactor to GoogleVR
#jira UEVR-594
Change 3954596 by Keli.Hlodversson
Add file missing from cl#3954572
Change 3957882 by Jeff.Fisher
UEVR-1100 bLockToHmd false doesn't work correctly
-CameraComponent can now tell the LateUpdateManager to store, correctly buffered, the fact that we don't want to do late update this frame. DefaultXRCamera checks that flag before applying the late upate to the camera.
#jira UEVR-1100
#review-3956168
Change 3957945 by Jeff.Fisher
Fix for Oculus begin/end frame problem after XRRenderBridge refactor.
-The 'Frame' lifetime in the frame was not long enough, so it was null by the time GetActiveRenderBridge_GameThread was called. NextFrameToRender is the same value, but has a long enough lifetime.
#review-3957897
Change 3958760 by Dongsik.Seo
Adding UseCameraRotation feature to StereoPanorama plug-in.
To enable this feature, use console command
SP.UseCameraRotation 7
Simply add numbers to mark axis to use. 1 = Pitch, 2 = Yaw, 4 = Roll
7 means all axis (1+2+4)
#review-3958756 @Joe.Conley
Change 3959347 by Douglas.Copeland
Fixing spelling errors in test displays
Change 3964331 by Jason.Bestimt
Merging CL 3959979 from 4.19 to Dev-VR + uplugin change from CL 3954046
GoogleARCore Plugin fixes for Unreal 4.19.1 hotfix:
Fixed the crash in Acquire/Release UGoogleARCorePointCloud.
Fixed the issue that multiple line trace channel doesn't work correctly.
Fixed the issue the passthrough camera texture has blue and red channel swapped when building against gles 3.1
Fixed the issue that UGoogleARCorePointCloud::GetPoint doesn't return position in world space.
Change 3967485 by Ryan.Vance
Removed the exlude rect, we want to clear stencil on the entire surface.
Change 3968028 by Zak.Parrish
Nuking contents of existing FaceARSample, to be replaced by the one from Release-4.19.
Change 3968114 by Zak.Parrish
Adding in the new version of FaceARSample from Release-4.19 #rb none
Change 3978381 by Mike.Beach
Mirroring CL 3969503 from 4.19
Only triggering new Blueprint event, OnMotionControllerUpdated, from the game thread (causing a assert/crash when triggered from the render thread and the component has been destroyed on the main thread).
#jira UE-55445
Change 3981160 by Joe.Graf
Merged the BackChannel unit test fix over from Owl
Change 3981705 by Mike.Beach
[WIP] MR Calibration - Expose a config setting that will alter the tracking origin type used to calibrate (eye vs. floor).
#jira UE-55220
Change 3981898 by Joe.Graf
Added support for Apple hardware accelerated image conversion to JPEG, TIFF, PNG, and HEIF
Added a Blueprint latent action to perform the conversion in the background
Change 3981910 by Joe.Graf
WIP AR texture support so that other systems can interact with the camera data
Change 3982102 by Joe.Graf
Pull request: Update CMakefileGenerator.cs for CLion
Fixed an issue in the PR and added cleanup for the macro errors that result in FOO()= definitions
#jira: UE-57103
GitHub #4619
Change 3982883 by Joe.Graf
Added a CLionGenerator for consistency
Fixed editor preferred source code accessor parsing in the project file generator
Added code to detect the bad assumption of the project name always being UE4 and stripped that off in the CLionSourceCodeAccessor
#jira UE-54801
Change 3983687 by Joe.Graf
Fixed the lack of platform checks for adding a framework in the Apple image utils plugin causing a Switch compile error
Change 3984325 by Jeff.Fisher
UEVR-1141 PSVR - fix morpheus on pc render target scaling
-Hard coding the target size. Perhaps the old method broke with the pixel density change.
#review-3983261
Change 3984563 by Joe.Graf
Temporarily disabled ConvertToHEIF on Mac until the build machines are updated to XCode 9.3
Change 3985213 by Zak.Parrish
Removing a ton of excess art assets that were taking up lots of space and possibly throwing warnings. We weren't going to use them anyway. #rb none
Change 3985577 by Joe.Graf
WIP support for the Apple Vision API to perform computer vision tasks on images
Change 3985654 by Joe.Graf
Fixed missing forward declaration hidden by unity files
Change 3990596 by Mike.Beach
Adding a delegate for handling when the active XR system modifies the tracking space origin, and a API function for getting a transform between floor and eye space.
#jira UE-55220
Change 3990788 by Mike.Beach
Attempted CIS fix (fallout from CL 3990596)
Change 3990824 by Ryan.Vance
Re-submitting 4.19.1 hotfox 3968537
Change 3995804 by Jeff.Fisher
Merging cl 3995785
//UE4/Dev-VR-Seal/Engine/Source/...
to //UE4/Dev-VR/Engine/Source/...
UEVR-1148 bLockToHmd change breaking qagame entry level xr camera behavior
-Fixing late update when no camera component is in use.
-The camera component's bLockToHMD==false behavior is supposed to be that hmd motion is ignored, meaning we should not do a late update. This behavior is being applied TO the XRCamera system FROM the camera component, but the camera component can go away or be switched at any time. We want the default to be do apply hmd motion and late update, so disabling late update needs to be a positive setting applied each frame.
#review-3995764
Change 3999842 by Nick.Whiting
Exposing Apple ARKit function library as public for our buddies down under.
Change 4005541 by Joe.Graf
UE-57541 Blacklisted TVOS since it also defines PLATFORM_IOS as 1
#jira UE-57541
Change 4006308 by Jason.Bestimt
#DEV_VR - Hopeful fix for possible unity issue
Change 4006543 by Joe.Graf
Added code to be more correct on setting face blendshapes
Change 4007508 by Jason.Bestimt
#LUMIN - Adjusting automation tests.
- Moved QA specific content test into QA Game
- Wrapped controller not found to only happen on device
Change 4007515 by Jason.Bestimt
#LUMIN - Disabling privilege warning except on device
Change 4007552 by Jason.Bestimt
#LUMIN - Wrapping LuminTargetPlatform internals that require WITH_ENGINE
Change 4008585 by Joe.Graf
Added virtual curves for the head rotation information from the FaceAR's face tracking for streaming via LiveLink
#jira: UE-57830
Change 4008604 by Mike.Beach
MR - Making the chroma key material easier to customize & switch out. Updating the calibration to let you set whatever params you've exposed in the video processing material (removing hardcoded params for old chroma keying material).
#jira UEVR-1153
Change 4009396 by Jason.Bestimt
#DEV-VR - Removing warning about stat on different threads (CL 4009124)
Change 4009514 by Joe.Graf
Added a weighted moving average method to the modify curve anim node
Change 4010125 by Jason.Bestimt
#DEV-VR - Integrating 0.12 changes from Dev-VR-Seal to Dev-VR
Change 4010434 by Jason.Bestimt
#DEV-VR - Fix for Lumin Haptic Test include
Change 4010945 by Jeff.Fisher
QAHapticTests build fix
-removed unused bad include
Change 4011002 by Nick.Atamas
Fixed Android compilation.
Change 4011220 by Nick.Atamas
- Adding visualization for boundary polygons.
- Adding support for vertical planes.
Change 4011298 by Mike.Beach
MR - Revamping the VideoProcessing/ChromaKeying material so that it:
1) Better extracts luminance from the image
2) Utilizes despill to remove chroma bleed from the scene
3) Leverages the generated despill mask to add back in a faux bounce
#jira UEVR-1153
Change 4011858 by Keli.Hlodversson
Move ExecuteOn(RHI|Render)Thread from Oculus plugin into XRThreadUtils.{h|cpp} inside the HMD module
Use TFunction and TFunctionRef instead of std::function as arguments. (Depends on the changes in CL#3987166: Allow overloading of functions which take TFunctions or TFunctionRefs with mutually exclusive signatures.)
-- Ref for methods that guarantee the function has been invoked before returning, TFunction for *_NoWait, as the function may not get execured until later when RHI is in a separate thtread and not bypassed.
#jira UE-57380
Change 4011956 by Keli.Hlodversson
Fix missing includes after CL#4011858
Change 4012096 by Joe.Graf
Disabled building AppleVision on Mac until there's a good solution for older Mac OSes
Change 4012294 by Jason.Bestimt
#DEV-VR - Adding dependency on LuminRuntimeSettings to MagicLeap module. Hopefully, this will fix the generated files not being found
Change 4012390 by Jason.Bestimt
#DEV-VR - Misc fixes for static code analysis issues
- Guards around GEngine usage
- Fix from Rolando for uint32 -> uint64 + shifting warning
- Redundant if checks
Change 4013426 by Jason.Bestimt
#DEV-VR - Guarding RestoreBaseProfile so we don't crash on exit
#JIRA: UE-57960
Change 4014661 by Ryan.Vance
Initial support for omni-directional stereo captures.
https://developers.google.com/vr/jump/rendering-ods-content.pdf
Change 4015561 by Jason.Bestimt
#DEV-VR - Moving MLSDK out of thirdparty directory to fix static code analysis issue
Change 4016202 by Jason.Bestimt
#DEV-VR - Integrated CL 2685 from Seal depot
#JIRA: UEVR-1157
Change 4016448 by Jason.Bestimt
#DEV-VR - Adding LuminRuntimeSettings as dependent modules for anything that references the MLSDK
Change 4016457 by Ryan.Vance
#jira UE-58018
Cleaning up compiler errors/warnings.
Change 4017246 by Jason.Bestimt
#DEV-VR - Potential fix for UE-58043 where metal asserts that it should be in the render thread rather than either the render thread OR RHI Thread
#JIRA: UE-58043
Change 4018571 by Joe.Graf
Added a remapping of curve values in a range to the modify curve anim node
Change 4018991 by Joe.Graf
Wrapped vertical plane detection in a if iOS 11.3 check since ARKit 1.5 is only availabe from 11.3 on
#jira: UE-57999
Change 4019068 by Joe.Graf
Changed how Apple Vision support is enabled in code
#jira: UE-57552
Change 4019194 by Joe.Graf
Added a console command to change where Face AR is publishing LiveLink curve data "LiveLinkFaceAR SendTo=192.168.1.1"
Change 4019648 by Keli.Hlodversson
Work around build failures caused by missing virtual destructor warnings.
Reverting back to Oculus' original method of implementing own RHICommand wrapper around TFunctions and TFunctionRefs (using overloaded inline functions and templates to reduce code duplication.)
Change 4019871 by Joe.Graf
Changed the __IPHONE_11_3 to the raw numeric value
Change 4020121 by Keli.Hlodversson
Fix parameter types to match header declarations.
Change 4020127 by Keli.Hlodversson
Remove dllimport/export macros from cpp file.
Change 4020621 by Joe.Graf
Wrapped the Apple ARKit plane geometry building in a #if IOS_11_3 check
Change 4020910 by Joe.Graf
Refactored how ARKit support #define to make it easy to wrap individual features by ARKit version
Change 4020952 by Joe.Graf
Added checks to make sure PLATFORM_IOS and PLATFORM_TVOS are defined to 0 on non-Apple platforms when checking for ARKit
Change 4021116 by Jason.Bestimt
#DEV-VR - Integrating CL 4005915 from Dev-Core to remove plugin modules that aren't supported on target platform
Change 4021320 by Joe.Graf
Fixed warnings resulting from unity builds hiding them
Change 4021738 by Chad.Garyet
- adding lumin filters
- changing defaults for platforms back to true, this was brought over erroneously.
#jira none
#ROBOMERGE: Dogma, Nightlies
Change 4021898 by Chad.Garyet
added missing bits from the ue4main script
#jira none
#ROBOMERGE: Dogma, Nightlies
Change 4022583 by Joe.Graf
Added functions for checking ARKit version availability at runtime
Change 4022610 by Joe.Graf
Added checks for ARKit 1.0 availability when creating the AR session to prevent calling invalid selectors on older iOSes
Change 4022616 by Joe.Graf
Added support for enabling the ARKit 1.5 autofocus setting
Change 4022650 by Joe.Graf
Defaulted autofocus for AR to on
Change 4023026 by Joe.Graf
Changed the ARKit video overlay to use the new availability api
Change 4023124 by Joe.Graf
Switched another version check in the ARKit overlay code to use the faster version
Change 4023489 by Ethan.Geller
[Dev-VR] #jira none fix AudioMixerModuleName for Lumin. #fyi nick.whiting, jason.bestimt
Change 4023995 by Nick.Atamas
Properly deprecated the bitfield for plane detection mode.
#jira UE-57842
Change 4024992 by Jason.Bestimt
#DEV-VR - Adding SupportPlatforms to MagicLeapAnalytics plugin
Change 4025702 by Jason.Bestimt
#DEV-VR - Fix for loading ML libraries even when the MLSDK is not present
#JIRA: UE-58033
Change 4026639 by Mike.Beach
Removing innocuous Oculus error that did not match up with the rest of the code - it is handled/acceptable when Frame_RenderThread has been reset.
#jira UE-58001
Change 4026949 by Mike.Beach
MR - Making a few fixes to the lens undistortion and how it interacts with the MRC component...
- Switching to a 16bit displacement map instead of a 32bit UV map (updating the materials accordingly)
- Using the OpenCV focal ratio to scale the aspect ratio to avoid stretching from the undistortion
- Adding CVar commands to enable/disable pieces of the undistortion
- Changing the default undistortion cropping to be uncropped
- Removing the need for the 'EnableMapping' material parameter
#jira UE-55195
Change 4027147 by Jason.Bestimt
#DEV-VR - Fix for UE-58043 (more call sites where it should be Render OR RHI thread)
#JIRA: UE-58043
Change 4027301 by Mike.Beach
Updating the MRCalibration project's ini so it doesn't error on packaging.
Change 4027469 by Mike.Beach
MR Calibration - Setting StartInVR to true, so when we package the app, we don't have to manually enable it.
Change 4027957 by Mike.Beach
As part of renaming the MR plugin, first renaming the root folder to be MixedRealityCaptureFramework.
#jira UE-57782
Change 4029182 by Keli.Hlodversson
Revert back to not enqueuing RHI tasks when RHI is not on a separate thread. Oculus code depends on being able to call ExecuteOnRHIThread from code potentially called from within other calls to ExecuteOnRHIThread.
#jira UE-58079
Change 4029687 by Dragan.Jerosimovic
Boy rig and pose asset mb files, maps and masks
Change 4030059 by Mike.Beach
As part of renaming the MR plugin, renaming the inner module to be MixedRealityCaptureFramework.
#jira UE-57782
Change 4030296 by Charles.Egenbacher
#LUMIN Copying from Dev-Incoming-Staging to Dev-VR
Change 4030593 by Jason.Bestimt
#DEV-VR - Merging olaf test maps to Dev-VR
Change 4031042 by Keli.Hlodversson
Allow executing ExecuteOnRHIThread* on the RHI thread. Enables simplifying destructors that can either be invoked on the RHI or Render thread.
#jira UE-58239
Change 4031046 by Keli.Hlodversson
Use the new XRThreadUtils functions in the HMD module for executing tasks on the RHI thread
#jira UE-58238
Change 4032593 by Mike.Beach
As part of renaming the MR plugin, renaming the inner module to be MixedRealityCaptureCalibration.
#jira UE-57782
Change 4033911 by Jason.Bestimt
#DEV-VR - Fix to LuminToolChain to allow it use a custom strip executable (android instead of gcc)
Change 4034087 by Mike.Beach
Renaming the MR plugin to be the 'MixedRealityCaptureFramework' plugin.
#jira UE-57782
Change 4034253 by Joe.Graf
Made the Apple Vision plugin use version checking consistent with ARKit
Change 4034543 by Joe.Graf
Added availability checks for the Apple Image Utils plugin similar to ARKit
#jira: UE-57541
Change 4034548 by Joe.Graf
Fixed the implicit conversion in the head rotation curves from the face ar feed causing the values to be 0
Change 4034577 by Jason.Bestimt
#DEV-VR - Removing MAC Custom Metal present (fixes Mac with -game rendering all black)
Change 4034605 by zak.parrish
Checking in test case for head rotation tracking - minor temporary change to AnimBP #rb none
Change 4034686 by Jason.Bestimt
#DEV-VR - Integrating (most of) CL 3980919 to disable instances of deprecation warnings caused by building for ios11
#JIRA: UE-58046
Change 4034799 by Joe.Graf
Added base types for detecting images in a AR session
Change 4034820 by Joe.Graf
Added a friendly name to UARCandidateImage objects
Change 4035010 by Joe.Graf
Added support for handling ARImageAnchor notifications from ARKit
Change 4035355 by Mike.Beach
[WIP] MR - Renaming some classes to reflect the plugin's new name.
#jira UE-57782
Change 4035464 by Joe.Graf
Added orientation to the ARCandidateImage object to pass to the detection system
Change 4035524 by Mike.Beach
[WIP] MR - More renaming of some classes to better match the plugin's new name.
#jira UE-57782
Change 4035606 by Mike.Beach
[WIP] MR - More renaming of some classes to better match the plugin's new name.
#jira UE-57782
Change 4035918 by Mike.Beach
[WIP] MR - Renaming the MrcFramework module's source files to better match the plugin's new name.
#jira UE-57782
Change 4035976 by Mike.Beach
[WIP] MR - Renaming some more files and classes to better match the MRC framework's new name.
#jira UE-57782
Change 4036044 by Ryan.Vance
#jira UEVR-377
Adding support for ISR Translucency.
Change 4036069 by Ryan.Vance
We can remove the last word PrimitiveVisibilityMap masking for ISR since the maps are always the same size between views.
Change 4036073 by Chance.Ivey
Fixed select blocks on LuminSamplePawn and GesturesAndTotem map to reflect recent changes. Fixes #JIRA UE-58328 #rb none
Change 4036307 by Mike.Beach
[WIP] MR - Renaming the MRC calibration files to better match the MRC framework's new name.
#jira UE-57782
Change 4036314 by Mike.Beach
[WIP] MR - Renaming some more calibration classes to better match the MRC framework's new name.
#jira UE-57782
Change 4036319 by Charles.Egenbacher
#LUMIN this is an out-of-date version of the lumin sample. Nuking.
Change 4036396 by Charles.Egenbacher
#LUMIN Adding the up to date version of the LuminSample.
Change 4036485 by Sorin.Gradinaru
UE-57773 Disable Thermals Message
#4.20
#iOS
Add in the Remote Session App BP an Execute Console Command node immediately after Event Begin Play, disabling all on-screen messages, for all builds.
Change 4036695 by Jason.Bestimt
#DEV-VR - Adding Lumin case to PrecompileTargetType check
Change 4037110 by Jason.Bestimt
#DEV-VR - Extra deprecated macro guards around HarfBuzz includes
#JIRA: UE-58046
Change 4037443 by Jason.Bestimt
#DEV-VR - Merging CL 4028003 from Partners-Google
Change 4037490 by Jason.Bestimt
#DEV-VR - Integrating CL 4028922 from Partners-Google (+ assignment guarding)
Change 4037691 by Jason.Bestimt
#DEV-VR - Swapping order of comparrison operator to deal with const error
Change 4037892 by Joe.Graf
Added UTexture2D to CGImage conversion in Apple Image Utils plugin
Change 4037894 by Joe.Graf
Changed the name of a property to make it clearer as to what it is and to have fewer things named similar in the same system
Change 4037901 by Joe.Graf
Added support for configuring which images you'd like detected during a AR session
Change 4037906 by Jason.Bestimt
#DEV-VR - Fixing buckled logic for =operator (derp)
Change 4038293 by Mike.Beach
[WIP] MR - Moving the calibration setup/level/content into its own project, and out of the MR plugin.
#jira UE-57782
Change 4038403 by Joe.Graf
Added the name from the candidate image when creating the Apple side representation
Change 4038488 by Mike.Beach
[WIP] MR Calibration - Moving calibration specific files to the MRCalibration project, out of the plugin (followup to CL 4038293). This makes the MRCalibration project a code project now.
#jira UE-57782
Change 4038776 by Chance.Ivey
Updates to Fix for Gestures change. Affects #JIRA UE-58328, though other non-content issues may cause packaging to fail #rb none #fyi Nick.Whiting
Change 4038877 by Mike.Beach
[WIP] MR - Renaming assets to better match the new plugin name.
#jira UE-57782
Change 4039097 by Joe.Graf
Fixed the public include path warnings in the Apple* plugins I added
Change 4039106 by Joe.Graf
Worked around a bad compile time assert that blocked valid FString::Printf debug code
Change 4039209 by Jeff.Fisher
Fixing one build script paths
Change 4039275 by Jeff.Fisher
More include path fixes.
Change 4039415 by Joe.Graf
Added support for remote session sending AR camera image data to be rendered on the host like we do for AR on device
Change 4039471 by Joe.Graf
Added a file I missed when adding to the remote session plugin
Change 4039473 by Joe.Graf
#ifdef-ed some code out until the linkage can be fixed
Change 4040249 by Mike.Beach
[WIP] MR - Moving some more asset files that aren't needed for the MRC plugin
#jira UE-57782
Change 4040365 by Mike.Beach
Fixing a compiler issue in the MRCalibration project, since moving MRC files there (WITH_OPENCV is not defined for the project).
#jira UE-57782
Change 4040455 by Mike.Beach
Moving the few remaining methods that were calibration specific, sprinkled through the MRC plugin.
#jira UE-57782
Change 4041404 by Mike.Beach
Fixing an issue with BP async nodes - making it so their wrapped function can be renamed and redirected.
Change 4041406 by Mike.Beach
MR - Splitting the Mrc video util library so that the BP functions needed for calibration aren't exposed to users.
#jira UE-57782
Change 4042110 by Jason.Bestimt
#DEV-VR - Stopping spew for ML eye tracking when not on platform
#JIRA: UE-58365
Change 4042407 by Joe.Graf
Disabled HEIF compression on Mac
#jira: UE-58479
Change 4042727 by Jason.Bestimt
#DEV-VR - Fix for Android compiling without version 24
Change 4042861 by Olaf.Piesche
#jira UE-57784
Change 4043105 by Mike.Beach
Exposing a way for programmers to strip save game headers from save data, and get to the tagged object serialization portion.
#jira UE-58389
Change 4043120 by Mike.Beach
MR - Loading the base save data, even if we're unable to fully construct the original save object class.
#jira UE-58389
Change 4043401 by Mike.Beach
New Oculus poke-a-hole material, in support on SI 1.25. Checking in to alleviate QA contention for testing the rest of SI 1.25.
#jira UEVR-1143
Change 4043424 by Mike.Beach
Oculus SI 1.24/1.25 - Engine rendering changes
#jira UEVR-1143
Change 4043495 by Mike.Beach
CIS fix - Missing files needed for the Oculus SI 1.24/25 Vulkan changes.
#jira UEVR-1143
Change 4043642 by Zak.Parrish
Changes to FaceARSample: added in support for JoeG's smoothing algorithm, also refactored calibration to use the new Modify Curves node. Added some more comments to the AnimBp to make it easier to read. #rb none
Change 4045638 by Zak.Parrish
Some minor updates to FaceARSample content. Mostly refactoring for new ModifyCurve stuff.
Change 4046003 by Jason.Bestimt
#DEV-VR - Fix for bEnableAlphaChannelInPostProcessing reading in as false for LuminSample
bEnableAlphaChannelInPostProcessing translates to r.PostProcessing.PropagateAlpha in ini files
#JIRA: UE-58523
Change 4046548 by Jules.Blok
Fix SetInstancedEyeIndex() ignoring the left eye.
#jira UE-54044
Change 4046859 by zak.parrish
Checking in the new rig from 3Lateral - this prevents the eyelashes from separating
Change 4047060 by Nick.Whiting
Wrapping -norhithread in PLATFORM_LUMIN to prevent the ML plugin from always disabling RHI threading.
#jira UEVR-1192
Change 4047667 by Mike.Beach
CIS fix - removing uneeded line from bad merge.
Change 4047673 by Mike.Beach
More CIS fixes for fallout from recent rendering merge.
Change 4048227 by Rolando.Caloca
VR - vk - Some Vulkan merge conflicts resolved
Change 4048421 by Jason.Bestimt
#DEV-VR - Converting OwnerName to EventName in UpdateSceneCaptureContent_RenderThread call
Change 4048423 by Jason.Bestimt
#DEV-VR - Fixing mediandk version check
Change 4048452 by Rolando.Caloca
VR - Merge fix
Change 4048530 by Rolando.Caloca
VR - Merge fix
Change 4048607 by Jason.Bestimt
#DEV-VR - Probable repair of Mr Mesh post merge
Change 4048794 by Rolando.Caloca
VK - Fix mobile from merge
Change 4048972 by Jeff.Fisher
Fixing MeshReconstructor merge problems.
Change 4049969 by Ryan.Vance
Fixing missing shader assert.
Change 4050831 by Ryan.Vance
Merge clean up. This is still needed to build w/ vulkan on Lumin.
Change 4050854 by Ryan.Vance
Merge clean up.
We need GetAllocationHandle for the ML Vulkan custom present sRGB workaround.
Change 4051495 by Jason.Bestimt
#DEV-VR - Adding Android, Quail, Linux vulkan include clauses
Change 4052528 by Zak.Parrish
Changing defaultEngine.ini for the higher res version of Gremlin
Change 4052880 by Ryan.Vance
Merge clean up.
Now with more Lumin
#jira UE-58645
Change 4052991 by zak.parrish
Update to FaceTrackingMap2 for proper camera positioning
Change 4053139 by Nick.Whiting
Fixing Lumin Vulkan platform header
Change 4053352 by Mike.Beach
On PC (in editor), not enabling ML stereo by default. Waiting for it to be enable by the EnableStereo() call (like we do for Oculus/SteamVR).
#jira UE-57991
Change 4053644 by Nick.Whiting
Fix for build break by wrapping bStereoDesired in !PLATFORM_LUMIN
Change 4054329 by Jason.Bestimt
#DEV-VR - Resave of GoogleARCorePassthroughCameraMaterial.uasset
#JIRA: UE-58689
Change 4054785 by Mike.Beach
Fixing a MRCalibration BP compilation error from the latest merge - was using a deprecated variable which was no longer exposed to BPs.
Change 4055466 by Jules.Blok
Suppress SteamVR submission errors after they've been logged once.
Change 4055500 by Jason.Bestimt
#DEV-VR - MrMeshComponent fix for unsupported pixel format
#JIRA: UE-58759
Change 4055761 by Ryan.Vance
#jira UE-58729
There's a single frame where the TLV textures are not initialized when using FCanvasTileRendererItem on startup.
Change 4056008 by Mike.Beach
Fixing bad merge from Main.
Change 4056616 by Nick.Whiting
Changing UBT configs to use Lumin-specific config files
#jira UE-58760
Change 4056969 by Keli.Hlodversson
MRCalibration: Set r.SceneRenderTargetResizeMethod to "Grow" to avoid cycling the scene render target size on every frame causing a flicker
#jira UE-58191
Change 4057356 by Jason.Bestimt
#DEV-VR - Guard around JNI function for Lumin
Change 4059353 by Nick.Whiting
Fix for shadow variable warnings on Linux
#jira UE-58843
Change 4060158 by Rolando.Caloca
DVR - vk - Temporarily add backbuffer delay/extra copy blit on android
#jira UE-58859
Change 4060432 by Mike.Beach
Fix for shadow variable warnings on Linux
#jira UE-58843
Change 4060520 by Rolando.Caloca
VR - Proper fix for r.Vulkan.DelayAcquireBackBuffer=0
- Restore Android to not delay
#jira UE-58859
Change 4060587 by Nick.Whiting
Fix for minimum iOS version being set to iOS 8 on MRCalibration, which was causing CIS warnings
#jira UE-58762
Change 4061277 by Jeff.Fisher
UE-58861 //UE4/Dev-VR - Compile UE4Game Lumin - ERROR: MLSDK is not specified; cannot use Lumin toolchain.
-Overriding HasAnySDK to setup the MLSDK.
Change 4061308 by Jason.Bestimt
#DEV-VR - Work around of UE-58864 crashing when mousing over project launcher with only a Lumin device plugged in
#JIRA: UE-58864
Change 4062111 by Ryan.Vance
#jira UE-58875
Fixing audio compilation failure.
Change 4064091 by Jason.Bestimt
#DEV-VR - Disabling ML Plugin with the editor when bIsVDZIEnabled is off
#JIRA: UE-58954
Change 4064554 by Jason.Bestimt
#DEV-VR - Removing ML haptic tests when not on the platform
#JIRA: UE-58966
Change 4064755 by Jeff.Fisher
UE-58970 Dev-VR - Incremental UE4Editor Linux - Referenced directory 'D:\Build\AutoSDK\HostWin64\Lumin\0.12\lib\linux64' does not exist.
-Removed linux from magicleap plugin whitelists, we have no sdk for linux.
#review-4064614
#jira UE-58970
[CL 4064889 by Mike Beach in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3795481 by Nick.Shin
HTML5 - disable SupportsScreenPercentage() - render the full screen
otherwise, this is causing HTML5 screen to only render a portion of the screen and in black...
- there may be another function is that not getting fired off "to render the screen" properly
- this may be due to IsMobileHDR checks that are not fully accounted for the HTML5 platform
#jira UE-52640 HTML5 only renders a black rectangle in the browser when launched
Change 3807007 by Nick.Shin
HTML5 - remove webgl1 only precompile guards (UE4_HTML5_TARGET_WEBGL2)
toolchain can "fallback" to webgl1 -- webgl2 functions in UE4 code are "if checked"/configured/setup at start up
#jira UE-51267 WebGL1 fails to compile
Change 3822593 by Nick.Shin
#jira UE-27141 Remove all #if PLATFORM_HTML5 from high level code
Change 3823512 by Nick.Shin
#jira UE-27141 Remove all #if PLATFORM_HTML5 from high level code
Change 3824639 by Nick.Shin
HTML5 - OSX - RunMacHTML5LaunchHelper.command
- more helpful warning messages
#jira UE-49861 A copied RunMacHTML5LaunchHelper.command gives unspecific Mono error
Change 3829092 by Josh.Adams
- Updated UnrealRemote to 1.4.1
Change 3832708 by Chris.Babcock
Allow UE4Commandline.txt in APK
#jira
#ue4
#android
Change 3835867 by Nick.Shin
HTML5 - code cleanup
origial work was for: UE-27141 (Remove all #if PLATFORM_HTML5 from high level code)
this exposed an issue that i totally forgot about (.../Engine/Source/Developer/... only does builds tools -- which does not make use of PLATFORM_XXX preprocessor)
tested with HTML5 builds with QAGame project :: TM-ShaderModels map
#jira UE-53524 UE4Editor Static Analysis Win64 (MSVC) - 1 repeat warning
Change 3839967 by Mi.Wang
Override MaxObjectInGame on Android to save ~30M with the ObjectArray size.
#Android
Change 3842022 by Mi.Wang
Fix an AssetRegistry size calculation bug.
Change 3843552 by Sorin.Gradinaru
UE-54139 Possible crash with new virtual keyboard on Android if suggestions not disabled
#4.19
#Android
#jira UE-54139
S8 on 7.0 is not hiding suggestions and disabling predictive input. There are cases with this that can cause a crash.
Fix: On text change, downgrade to simple suggestions all the easy correction spans that are not a spell check span (remove android.text.style.SuggestionSpan.FLAG_EASY_CORRECT flags)
Change 3844210 by Nick.Shin
HTML5 - filter out "windows/super" keys - these are not used in UE4
- but, keycode are not the expected "91 or 92" values, SDL keys are "227 & 231" instead...
#jira UE-54056 HTML5 crashes inside browser upon pressing windows key
Change 3844874 by Nick.Shin
HTML5 - detect "SyntaxError: " and do a forced reload
- an actual syntax error would be caught during compile time
- this is usually error condition is usually seen when browser is running "old/partial" cached data and it's fairly safe to just reload the page
#jira UE-54017 QAGame fails to launch properly on HTML5 Firefox 64 bit
Change 3846695 by Nick.Shin
#jira UE-53524 UE4Editor Static Analysis Win64 (MSVC) - 1 repeat warning
Change 3847309 by Nick.Shin
HTML5 - (not to) show virtual joystick
- virtual joysticks are not shown by default-- and the mouse not captured
- this now behaves like the win64 client version
#jira UE-33854 Virtual Joysticks In HTML5 if Mobile/Tablet Project is chosen
Change 3847310 by Nick.Shin
HTML5 - set controller axis and button max value in code instead of relying on emscripten_get_gamepad_status()
- seems emscripten might be uninitialized by the time controlers are used...
#jira UE-28513 - Using a controller in HTML5 causes error
Change 3850606 by Nick.Shin
HTML5 - more static warning fix ups
#jira UE-53524 UE4Editor Static Analysis Win64 (MSVC) - 1 repeat warning
Change 3850624 by Nick.Shin
HTML5 - tell user/developer to show unsupported WebGL browsers on old hardware -- will need to try another browser
note: using following jira to track progress:
#jira UE-47066 Packaged HTML 5 Map Prompts for Firefox Update in Chrome
Change 3855610 by Sorin.Gradinaru
UE-49173 Progress bar causes black screen on iOS
#iOS
#4.20
#jira UE-49173
The bug occurs on iOS with Metal, when the last Slate element to be draw in the scene is a ScrollBar with progress between 0 and 1.
As a workaround, adding another widget (eg. button, image) in the Blueprint solves the problem.
The bug can be reproduced by adding OutDrawElements.PushClip & OutDrawElements.PopClip in any SWidget::OnPaint.
The solution is to disable the scissor
RHICmdList.SetScissorRect(false, 0, 0, 0, 0);
in FSlateRHIRenderingPolicy::DrawElements after the batch rendering
Change 3855652 by Sorin.Gradinaru
iOS 3D browser
UE-53248 Web Browser on a Widget Component is 2D when launching on to iOS
#jira UE-53248
#iOS
#4.20
Uses the same WebTexture from the WebBrowser plugin as the Android version.
+ Code contributed by Juan.Belon from Alea S.r.l at https://udn.unrealengine.com/questions/390166/3d-world-space-widget-is-being-rendered-in-screen.html
Change 3856174 by Nick.Shin
HTML5 - python forking will still error while trying to terminate already terminated processes
- added same "WindowsError code 5" handler found in subprocess.py
#jira UE-51618 HTML5 fails to build, [Error 5] Access is denied
Change 3863322 by Sorin.Gradinaru
UE-54317 DXT apps fail on first launch when 'For Distribution' enabled, Unsupported Texture Format
#jira UE-54317
#Android
#4.19
Change 3878088 by Nick.Shin
UEMOB-425 superceeds this jira
#jira UE-25257 Mac HTML5 project crashes upon downloading expression HasFoundDataDirectory failed
Change 3884560 by Jack.Porter
Fix logspam in FAVMoviePlayer
#jira UE-54760
Change 3886533 by Mi.Wang
Fix a potential crash that the VirtualKeyboardWidget has been hide while trying to use in gamethread.
Change 3889081 by Sorin.Gradinaru
UE-54490 Android Startup Movie audio still playing when app paused, and after app resumed the movie is blackscreen until engine ticked.
#Android
#4.20
#jira UE-54490
Call ForceCompletion for the intial movie player on onPause.
Call App Restart on Resume.
Programmatically restarting an Android application basically consists in killing the current app, then using the launch intent as parameter for startActivity.
This can be done only in onResume , which means that the movie player still has to be manually paused/stopped in onPause.
I╞ve tried to kill the activity on onPause, tested on several devices, with various problems: the app doesn╞t restart anymore (onResume is not called) or the app is automatically sent to background (seems to be crashing when using the multitasking soft key).
Change 3890320 by Chris.Babcock
Fix initializer ordering
#jira UE-55189
#ue4
Change 3958226 by Nick.Shin
HTML5 disable memory poison tests
and fix a bug during Realloc() // for Linux... and in turn for HTML5
#jria none
Change 3958250 by Nick.Shin
HTML5 - FText::FormatStr - skip if multi-threading not supported
#jira none
Change 3968328 by Nick.Shin
HTML5 CORS fixes
still need datarouter.ol.epicgames.com fixes to completely solve these issues. (API server own estimates no later than mid-April)
note: the following are all related:
+ answerhub 756723 - HTML5 CORS / Access-Control-Allow-Headers
+ answerhub 756942 - HTML5 CORS Issue to my Hosts API / Hosted Server
+ UE-22285 - Session events are not generated for HTML5
+ UE-19330 - HTML5 Analytics cross-origin request blocked header Access-Control-Allow-Origin missing
#jira UE-19330
Change 3971405 by Nick.Shin
HTML5 suppress double printing to console.log
#jira none
Change 3978767 by Nick.Shin
HTML5 CORS fixes
note: the following are all related:
+ answerhub 756723 - HTML5 CORS / Access-Control-Allow-Headers
+ answerhub 756942 - HTML5 CORS Issue to my Hosts API / Hosted Server
+ UE-22285 - Session events are not generated for HTML5
+ UE-19330 - HTML5 Analytics cross-origin request blocked header Access-Control-Allow-Origin missing
tested (against datarouter.ol.epicgames.com fixes) and found to be functional
#jira UE-22285
Change 3981103 by Nick.Shin
HTML5 - num pad keys crashes project
match latest Engine/Source/Runtime/InputCore/Private/Linux/LinuxPlatformInput.cpp to HTML5PlatformInput.cpp
also fix a HUD crash...
#jira UE-54056 HTML5 crashes inside browser upon pressing windows key
Change 3983424 by Sorin.Gradinaru
UE-57107 Attempting to load a streamed media source causes the app to become unresponsive when device is not connected to internet
#jira UE-57107
#Android
#4.20
The ANR is because the android.media.MediaExtractor.setDataSource(UrlPath) calls an underlying api which retries the download (10-30 times).
Additional issue (all platforms): the MediaFrameworkTest/StreamSource_Infiltrator souce seems to have been removed (no longer at https://docs.unrealengine.com/latest/attachments/Engine/MediaFramework/HowTo/StreamMediaSource/Infiltrator%20Demo.mp4). According to the docs (https://docs.unrealengine.com/en-US/Engine/MediaFramework/HowTo/StreamMediaSource) the new location of the Sample Video is at https://dnnrz1gqa.blob.core.windows.net/portals/attachments/Engine/MediaFramework/HowTo/StreamMediaSource/Infiltrator%20Demo.mp4?sr=b&si=DNNFileManagerPolicy&sig=F%2BBpnYueeQTUTSW0nCRSrXEfr35LIawe7C3MQoe2%2FPI%3D
Change 3985248 by Nick.Shin
HTML5 game window size
add project setting drop down box to select canvas scaling mode
#jira UE-46555 HTML5 game window does not scale with browser size
Change 3986190 by Sorin.Gradinaru
UE-56076 Android Launch On "Running..." toast intermittently doesn't appear
#jira UE-56076
#Android
#4.10
When cancelling Launch on Device, always call CancelContinuations for the current task
Change 3986412 by Nick.Shin
CIS error fix
#jira none
Change 3987007 by Nick.Shin
HTML5 fullscreen size fix
- when using FIXED scale mode initially, there's some strange padding margins
- but, setting UE4_fullscreenScaleMode to anything "but FIXED scale mode" will work...
#jira UE-46555 HTML5 game window does not scale with browser size
Change 3988408 by Nick.Shin
HTML5 call EndSession() onbeforeunload()
? should PreExit() be called instead?
#jira UE-57207 Session End event is not generated for HTML5
Change 3991828 by Nick.Shin
HTML5 shipping build crash
some FVector2D needs ContainsNaN() checks
#jira UE-57401 Projects packaged for Shipping HTML5 do not launch the engine in the browser
Change 3992884 by Nick.Shin
HTML5 call EndSession() onbeforeunload() code cleanup
#jira UE-57207 Session End event is not generated for HTML5
Change 3992887 by Nick.Shin
datarouter: Session events code cleanup
#jira UE-22285 - Session events are not generated for HTML5
Change 4002603 by Sorin.Gradinaru
UE-56177 Unplugging a device while launching onto it from a source build will result in the "Running..." toast staying open
#jira UE-56177
#Android
#iOS
#4.10
Using the device discovery to signal when the running device gets disconnected
Change 4007162 by Dmitriy.Dyomin
Merging using Dev-Mobile->FortMain
Added ObjectOrientation material node for decals, returns decal projection direction ( X-axis)
#jira none
Change 4012196 by Sorin.Gradinaru
UE-57120 Lighting needs to be rebuilt error appears on Camera test app on Nexus 9 and Note 4.
#jira UE-57120
#Android
#4.20
Level lightings rebuilt and QA-Media_Camera_BuiltData.uasset added.
The message appeared (rarely and only on certain devices) because the engine tries to load the pre-computed lightmap data on the render thread, then to add it to the scene on the game thread (in FPrecomputedVolumetricLightmap::AddToScene).
Most of the times there is a desync and the data is not yet loaded when the lightmap is validated (in FScene::AddPrecomputedVolumetricLightmap).
Change 4013034 by Sorin.Gradinaru
UE-55427 iOS application crashes when suspending and resuming the startup movie in rapid succession
#jira UE-55427
#iOS
#4.20
Caused by ToggleSuspend waiting for FDefaultGameMoviePlayer::WaitForMovieToFinish()
Renamed InitialMovie to StartupMovie, including the methods related to the Android platform.
Change 4015449 by Sorin.Gradinaru
UE-38306 "Running xxx on yyy" panel Cancel button should terminate app
#jira UE-38306
#Android
#4.10
Run on device: Pressing Cancel on the "Running..." message should stop the application, if running
Cancel Android builds using "adb shell am force-stop <bundle_id> <device_id>"
Note: Using a new AutomationTool command (re-starting the Automation tool after canceling the BuildCookRun task chain) is too slow - takes 3-10 sec depending on the PC configuration.
AutomationTool is used now only to correctly retrieve the bundle id for each Android device. This is done inside the BuildCookRun command when the application is deployed on the device(s). Cannot simply use the current project's properties to retrieve the bundle id, because when using Launch-> Device Launcher, the user can choose to cook&deploy a different project/texture format, also the user can create & use a profile with multiple devices / with different texture formats.
Change 4016057 by Sorin.Gradinaru
UE-57845 GitHub 4666 : Pull request clipboard on android
#jira UE-57845
#4.20
#Android
#4666https://github.com/EpicGames/UnrealEngine/pull/4666
Implemented Clipboard function on Android.
Change 4020229 by Sorin.Gradinaru
UE-57845 GitHub 4666 : Pull request clipboard on android
#jira UE-57845
#Android
#4.20
GameActivity.java: moving the methods related to clipboard above the native public declarations
Change 4021188 by Sorin.Gradinaru
UE-57876 Location accuracy is ignored by ULocationServicesIOSImpl
#jira UE-57876
#iOS
#4.30
In ULocationServicesIOSImpl::InitLocationServices(ELocationAccuracy Accuracy, float UpdateFrequency, float MinDistance) the first param must be converted to CLLocationAccuracy and used as the first param of LocationDelegateinitLocationServices, rather than using the hardcoded kCLLocationAccuracyHundredMeters.
Also fixed a compilation error (!) when enabling The Location Services plugin on iOS
Change 4024839 by Sorin.Gradinaru
UE-38306 "Running xxx on yyy" panel Cancel button should terminate app
#jira UE-38306
#Android
#4.10
Removed unnecessary #include "AndroidTargetDevice.h", causing circular reference => nightly build errors
Change 4024962 by Cosmin.Sulea
UE-56294 - Packaging step fails when packaging project for distribution
#jira UE-56294
Change 4026122 by Sorin.Gradinaru
UE-57149 Razer Phone: Crash after Switching Camera Format 22-26 times
#jira UE-57149
#Android
#4.20
jobject obj = env->GetObjectArrayElement must be followed by env->DeleteLocalRef(obj)
The bug can probably be reproduced by using a MediaPlayer.
Change 4038185 by Nick.Shin
HTML5 - merge error fix
MallocAnsi.cpp was stomped on
#jira UE-58367 //UE4/Dev-Mobile - Compile UE4Game HTML5 - use of undeclared identifier 'malloc_usable_size'
Change 4039521 by Dmitriy.Dyomin
Export WorldBrowser API so plugin makers can use it
#jira UE-57323
Change 4039523 by Dmitriy.Dyomin
Exposed MobilePatchingLibrary API
#jira UE-55941
Change 4039526 by Dmitriy.Dyomin
Fixed: Hierarchy filtering does not work in world composition
#jira UE-57900
Change 4039529 by Dmitriy.Dyomin
Fixed: 'Apply Fogging' in Material does not work on Mobile (GitHub 4357)
#jira UE-53618
#4357
Change 4039874 by Sorin.Gradinaru
UEMOB-436 Support "All Android" Launch On and Project Launcher options
The main change is in the DeviceProxy class.
A new type ("All devices" proxy) was added, and the proxy now holds a list of physical device IDs for every variant (texture format), instead of a single device ID.
The "All devices" proxy is updated automatically by the device discovery thread.
The change was necessary because the list in the Project Launcher is using the device proxy list.
#jira UEMOB-436
#Android
#UE4
#4.19
Change 4041446 by John.Mauney
Fix that Chris B made locally on my machine
#jira UE-58420
Change 4041791 by Jack.Porter
Fix CIS incremental UE4Editor Win64
#jira 0
[CL 4047603 by Jack Porter in Main branch]
============================
MAJOR FEATURES & CHANGES
============================
Change 3873906 by Dan.Oconnor
Revised fix for preventing delegate functions from appearing in context menu when using the compilation manager - needed to run after CallDelegateHandler changed statement type
#jira UE-51726
Change 3873614 by Dan.Oconnor
Prevent delegate functions from appearing in context menu when using the compilation manager and prevent crash if such a function is somehow compiled
#jira UE-51726
Change 3873428 by Ben.Zeigler
#jira UE-54753 Fix class pin on SpawnActorFromClass to correctly support browse. It was inherting from the wrong pin widget
Copy of 3873408
Change 3873083 by Ethan.Geller
[4.19]#jira UE-54865 fix seconds -> milliseconds conversion issue. #rb aaron.mcleran #lockdown cristina.riveron
Change 3872714 by Dan.Oconnor
Further revise fix for UE-53840, mistakenly reverted to old behavior when compiling synchronously
#jira UE-53840
Change 3872648 by Ben.Zeigler
#jira UE-54845 Fix crash in NextDebugTarget when there are no valid debug targets
Copy of CL #3872636
Change 3872500 by Arne.Schober
Back out changelist 3870283
#jira UE-54838
Change 3872412 by Mark.Satterthwaite
Remove now unnecessary r.Metal.ManualVertexFetch from the device profiles.
#jira UE-54853
Change 3872313 by Martin.Wilson
Add UI to Live Link Client to warn live link users about background performance throttling
#jira none
Change 3872272 by Martin.Wilson
Fix crash when clearing a skeletal mesh on a skeletal mesh component with an active Post Process Anim Instance
#jira none
Change 3872238 by Mark.Satterthwaite
Duplicate CL #3871025
Make Manual Vertex Fetch a property of the shader platform for Metal - only the desktop platforms (METAL SM5/SM5_NoTess/MRT) will use manual vertex fetch. The mobile platforms use vertex descriptors. Prevents problems with cooked versions of games not working properly on Metal due to a mismatch between the runtime's Manual-Vertex-Fetch state versus the state used by the cooker when compiling shaders.
#jira UE-54843
Change 3872087 by Yasiman.Ahsani
Adding Python, libdisasm, musl, and LSS licenses.
#JIRA n/a - adding licenses for new TPS
Change 3872037 by Ben.Marsh
BuildGraph: Add a task for compiling MSBuild projects.
#jira
Change 3871934 by Lina.Halper
#jira: UE-54703
Change 3871595 by Michael.Trepka
Fixed a problem with Mac editor not exiting with error code returned from GuardedMain function
#jira UE-54830
Change 3870829 by Joe.Barnes
Fix unintentional change to PhysX libs used in Debug builds.
#jira ue-54817
Change 3870820 by Nick.Atamas
Copying //Tasks/UE4/Dev-VR-4.19a@3870772 to Release-4.19 (//UE4/Release-4.19)
#jira UE-54816
Change 3870755 by Chance.Ivey
Min Android version set - should fix camera permissions issue found in #JIRA UE-54024 #rb none #fyi nick.atamas
Change 3870547 by Krzysztof.Narkowicz
Fixed FreezeRendering on non editor builds: ComputeAndMarkRelevanceForViewParallel was calling FrozenMatricesGuard on multiple threads, reading and writing view matrices state in parallel.
#jira UE-53640
Change 3870546 by Krzysztof.Narkowicz
Fixed tesselation shader tex/uniform initialization in OpenGL3/4 path
#jira UE-54471
Change 3870284 by Ben.Zeigler
#jira UE-54583 Fix issue where loading multiple already loaded assets via Async Load Asset node could return the wrong asset on the loaded pin. The assign variable node was happening at a slightly wrong time
Copy of CL #3870279
Change 3870283 by Arne.Schober
SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources)
Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary
#jira none
Change 3870098 by Ben.Marsh
Fix OptimizeCode = CodeOptimization.Always causing compile errors in Linux debug builds. bUseInlining was not set correctly on the global compile environment used to build shared PCHs. Also fixed other settings not being propogated down from the target correctly.
#jira UE-53855
Change 3870013 by Ben.Marsh
UBT: Add an error if a user attempts to clean a target through hot-reload, rather than just failing to delete DLLs because they are locked.
#jira UE-54179
Change 3870010 by Ben.Marsh
UBT: Add an option to format output messages in a form that can be parsed by MSBuild. Prevents errors showing as "EXEC: Error:", and displays them correctly in the error list window.
#jira
Change 3869814 by Ben.Marsh
UBT: Unify command line arguments to use -Name=Value syntax. -Module <Name>, -ModuleWithSuffix <Name> <Suffix>, -Plugin <Path> and -Receipt <Path> are no longer supported.
Also remove the RemoteRoot option, which was not used anywhere.
#jira
Change 3869786 by Martin.Wilson
Fix Live Link Remove Source button not working
#Jira UE-54652
Change 3869660 by Martin.Wilson
Fix missing message bus sources in the live link client (not repolling for new sources)
#Jira UE-54712
Change 3869659 by Guillaume.Abadie
Fixes SimpleComposure's BP_AdvancedCompositing keep allocating memory every frame.
Credits for fixing the issue to Ron Radeztsk.
#jira UE-54780
Change 3869401 by Lauren.Ridge
Adding to the conditional in FindAllAncestorNamedSlotHostWidgetsForContent
#jira UE-51470
Change 3869384 by Brandon.Schaefer
Open the project in the explorer when NullSourceCodeAccess is done creating the project
#jira UE-54630
Change 3869308 by Ben.Marsh
PR #4452: Fixed FindFilesRecursively in IPlatformFilePak (Contributed by user37337)
#jira UE-54568
Change 3869265 by Martin.Wilson
Fix crash and subsequently found issues with unloading/reloading Maya Live Link plugin
-Crash on reload due to core code getting reinitialize, made this a one time only thing (as Maya never gets rid of the module from memory)
-Added manual ticking of FTicker, allows message bus objects to be cleaned up properly (cannot do this as part of normal flow as it is in engine code which we dont have)
-rebuild binaries for Engine/Extras
#Jira UE-54643
Change 3869206 by Benn.Gallagher
Fixed crash updating clothing paint mode after tab spawners have been destroyed by the hosting application.
#jira UE-54116
Change 3869064 by Benn.Gallagher
Resolved skeletal mesh data changes and clothing section disable changes after collision. Re-added ability to disable sections at the mesh level and removed the ability to strip editor sections as these are required for a number of other features to correctly function.
#jira UE-52557
Change 3869062 by Guillaume.Abadie
Fixes "dynamic resolution is not supported on this platform" warning message being always visible.
#jira UE-54655
Change 3868202 by Lauren.Ridge
Fix for assert on expanding vector param in layered material
#jira UE-54737
Change 3868161 by zak.parrish
Replacing FaceARDebugUI with a blank UI until a new one can be created, due to a crash bug. #rb none #JIRA UE-54639
Change 3867750 by Ethan.Geller
[4.19] #jira UE-54725 Fix for Envelope attack and release values not being properly set on Synth Components #rb aaron.mcleran #lockdown cristina.riveron
Change 3867657 by Lauren.Ridge
Adding if with editor wrapper to new function
#jira cis fix
Change 3867646 by Aaron.McLeran
#jira UE-53867 Access violation on Switch when playing sound with specified time out of range
Change 3867340 by Lauren.Ridge
Fixes to Material Layers from 4.19 preview feedback
-Need to pass through base attributes better/have better default nodes in layer (optional Example Layers and Blends checkbox now enables this in Experimental Settings)
-Parent in function should be editable
-Enforce only two layers in a blend
-Mat layer should warn if it has incorrect output in the layer itself
-Enforce not being able to delete outputs
-Warn about creating a MAL node inside a function
#jira UETOOL-1312
Change 3867317 by Aaron.McLeran
#jira UE-53867 Access violation on Switch when playing sound with specified time out of range
Change 3867000 by Lauren.Ridge
Fix for folder favorites possibly becoming very large
#jira UE-54704
Change 3866892 by Martin.Wilson
Fix crash if clicking ok on message bus add source without having a source selected
#jira UE-54572
Change 3866391 by Matt.Kuhlenschmidt
Fix static analysis
#jira UE-53379
Change 3866241 by Ryan.Vance
#jira UE-54681
Fixed missing Vulkan texture GetNativeResource implementation that was lost in a bad merge.
Change 3866071 by Nick.Shin
UDN 412414
update HTMl5 readme file
#jira none
Change 3866005 by Max.Preussner
Messaging: Preventing dangling references when removing message subscribers
#jira UE-54680
Change 3865988 by Simon.Tourangeau
Fix static analysis warnings
#jira none
Change 3865895 by zachary.wilson
Renaming QA-PhysicalLightUnits to TM-PhysicalLightUnits in QAGame.
#JIRA UE-29618
Change 3865469 by Simon.Tourangeau
Support for DX11 quad buffer stereo rendering
#jira UEENT-704
Change 3865461 by Chris.Babcock
Add a wait for audio thread to pause audio on going to background
#jira UE-54301
#ue4
#android
Change 3865350 by Matt.Kuhlenschmidt
Fix issue where cascade emitter UI would disapper
#jira UE-53379
Change 3865336 by Arne.Schober
REL - Fix UE-52356 Bone Weight
#jira UE-52356
Change 3865257 by Ben.Marsh
Fix editor failing to load content-only projects when compiled in DebugGame.
#jira UE-54661
Change 3865238 by Simon.Tovey
Pulling Olaf's fix from 3832595 over to release
#tests EngineTests boots in vulkan
#JIRA UE-54394
Change 3865191 by Sorin.Gradinaru
UE-54317 DXT apps fail on first launch when 'For Distribution' enabled, Unsupported Texture Format
#jira UE-54317
#Android
#4.19
From //Dev-Mobile/3863322
Change 3865190 by Sorin.Gradinaru
UE-54175 Selecting For Distribution no longer sets configuration to Shipping
#UE4
#4.19
#jira UE-54175
From //Dev-Mobile/3863371
"For Distribution" enable-> reset "Build COnfiguration" to Shipping and force serialization to DefaultGame.ini (see UE-52845)
Change 3865056 by Jamie.Dale
Fixed culture being incorrect when added via the Localization Dashboard
#jira none
Change 3864826 by Max.Preussner
WmfMedia: Added missing scope lock
#jira UE-54365
Change 3864055 by Aaron.McLeran
#jira UE-54213
Crash fix for GC'd plugin settings objects. Adding to AddReferencedObjects.
Change 3863775 by Andrew.Porter
MediaFrameworkTest: Removing Platform Media Source TVOS test content
#jira UE-29618
Change 3863714 by Dan.Oconnor
Make array, set, and map nodes no longer switch object type when a pin is disconnected. Also, you can no longer attach unrelated map types to the MakeMap node if only the value pin has been inferred
#jira UE-54634
Change 3863696 by Max.Chen
Sequencer: Fix crash open a new sequence while another is still active.
#jira UE-54620
#jira UE-54624
Change 3863638 by Dan.Oconnor
Make sure all blueprints that are skeleton compiled get a BroadcastChanged notification, also run BroadcastChanged after reinstancing, matching pre compilation manager behavior
#jira UE-54193
Change 3863494 by Jamie.Dale
Ensure Py_SetPythonHome is set correctly before the embedded Python interpreter is initialized
#jira UE-54345
Change 3863433 by Max.Preussner
MediaPlayerEditor: Removed tvOS from list of available platforms in Platform Media Source assets
tvOS currently reports itself as iOS, so it cannot have its own setting.
#jira UE-54559
Change 3863406 by Lauren.Ridge
Fix for a crash when filtering a dropdown with no set value
#jira UE-54631
Change 3863238 by Michael.Kirzinger
#jira UE-52730: Fix mac voip crash
Change 3862586 by Marc.Audy
Clean up rendering thread heartbeat checks that got mangled in various integrations
#jira
Change 3862247 by Guillaume.Abadie
Fixes editor lines that were using a simple element blending mode that was generating an incorrect alpha channel.
#jira UE-53830
Change 3862120 by Guillaume.Abadie
Fixes USceneCaptureComponent::HiddenActors always staying gray out in world editor.
#jira UE-51458
Change 3861363 by Jamie.Dale
Static analysis fixes
#jira none
Change 3861150 by Matt.Kuhlenschmidt
Fix static mesh editor displaying 0 for all stats on LODs > 0
#jira UE-53776
Change 3860990 by Dan.Oconnor
Clear subobjects not recreated on load, e.g. because we're running with -game and the subobject was created using CreateEditorOnlySubobject
#jira UE-54551
Change 3860972 by Nick.Shin
HTML5 - detect "SyntaxError: " and do a forced reload
- an actual syntax error would be caught during compile time
- this is usually error condition is usually seen when browser is running "old/partial" cached data and it's fairly safe to just reload the page
#jira UE-54017 QAGame fails to launch properly on HTML5 Firefox 64 bit
Change 3860951 by Arne.Schober
Fix not releaseing SRV on render thread for FPositionVertexBuffer, FStaticMeshVertexBuffer, FColorVertexBuffer, FStaticMeshInstanceBuffer.
#jira UE-54587
Change 3860950 by tim.gautier
QAGame: Updating ML_Stone to include Texture Coordinate and Panner functions
#jira UE-29618
Change 3860833 by Michael.Dupuis
#jira UE-54181: Repopulate the foliage list when existing simulate mode
Let the GC know that internal struct hold UObject ptr
Change 3860762 by Jamie.Dale
Ensure we invoke the correct version of Python from UBT
#jira UE-54345
Change 3860676 by Simon.Tourangeau
Remove DirectoryWatcher warning in output log
#jira UEENT-846
Change 3860598 by Lauren.Ridge
Fix for crash on opening new material instance
#jira UE-54589
Change 3860338 by Michael.Lentine
Integrate changes for fixing MorphTargets.
#jira 54398
Change 3860215 by Ben.Marsh
UAT: Fix exception consturcting target rules assembly inside UAT, now that there's an abstract TargetRules class.
#jira UE-54578
Change 3860186 by Matt.Kuhlenschmidt
Fix crash top 10 with the font editor shutting down and then a dpi event occuring
#jira UE-54543
Change 3859854 by Graeme.Thornton
PR #4124: VSCode: Changed VisualStudioCodeSourceCodeAccessor to work with non-default VSCode install paths on Linux (Contributed by christopherreed)
#jira UE-51289
Change 3859848 by Graeme.Thornton
Fix crypto.cs reading the wrong ini setting names for uasset encryption settings
#jira UE-54566
Change 3859684 by Ben.Marsh
PR #4436: Fix compile error when building BlankProgram because incorrect directory path (Contributed by windkey)
#jira UE-54392
Change 3859657 by Ben.Marsh
Fix FTransform being passed by value, causing alignment error when compiling for Win32.
#jira
Change 3859312 by nick.bullard
Updating AEOverviewMan to remove reference to sub-level AEOverviewSWP which was deleted in 3859278
Still need to update menu to remove selection
#jira UE-50784
Change 3859278 by Nick.Bullard
Deleteing AEOverviewSWP.umap per request of Developer. Also updated TM-AnimPhys which refereneced this map as well.
"This test map is a custom C++ implementation of a "procedural sound wave". This code is super janky and not worth fixing up. I'm sure there's a legit thread safety problem in there but the code is in QAGame only.
We've since implemented "synth components" which do what this test does in a much safer/better way and maintaining/testing this old thing is *not* worth the time."
#jira UE-50784
Change 3859124 by Dan.Oconnor
Fix long standing crash when duplicating a blueprint that is missing its parent class. Entries in CrashReport go back to 4.16
#jira UE-54468
Change 3859086 by Ryan.Vance
#jira UE-54470
We need to set the viewport in both cases.
Change 3859006 by Dan.Oconnor
Revise fix for archetype lookup when reinstancing. During compilation we do not want to force use of the up to date class
#jira UE-54541
Change 3858990 by mason.seay
Cleaned up blueprints to remove compile errors
#jira UE-29618
Change 3858945 by Aaron.McLeran
#jira UE-54265
PR #4428: Fixing Envelope Bug in AudioMixer (Contributed by Chrispykins)
Change 3858719 by Aaron.McLeran
#jira UE-54552 Fix for sample buffer reader
Change 3858647 by Ethan.Geller
PR #4439: Removes ambiX -> FuMa conversion (Contributed by mgorzel)
#jira UE-54407
Change 3858364 by Michael.Dupuis
#jira UE-52049: There was a case where adding and removing multiple time would lead to reordering the instances and this would cause the regeneration of the random stream for all the reorded instances.
Change 3858268 by Dan.Oconnor
Prevent postload logic running on REINST and SKEL classes
#jira UE-54531
Change 3858205 by Mitchell.Wilson
Removed particle looping from some emitters to resolve anim notify warnings.
#jira UE-53823
Change 3858148 by Lauren.Ridge
Changes based on Material Layer Feedback from previews
- (Temporary) Disabled being able to create a layer or blend in the asset dropdown
- Sections of the stack that have been disabled now inactivate that part of the UI
- Create Function Instance now indicates if you are making a layer or a blend
- Parent dropdown has been removed from layers and blends. Where relevant, a filter button has been added instead.
#jira UETOOL-1328
Change 3857933 by Michael.Dupuis
#jira UE-45854: Properly unregister callback when replacing foliage type with another one
Change 3857898 by Michael.Dupuis
#jira UE-54396: Remove the Ensure as it could be possible that the Landscape Info is invalid during an undo operation
Change 3857878 by Max.Chen
Sequencer: Assign the sequence id after the template is compiled.
Copy from Dev-Sequencer
#jira UE-54462
Change 3857808 by Michael.Dupuis
#jira UE-54421: Prevent edition during Simulate when clicking on actor
Change 3857786 by Rolando.Caloca
UE4.19 - Fix recompute tangents and skin cache for OpenGL
#jira UE-42108
PR #3271
Change 3857549 by Lina.Halper
another jittering issue due to revision number change
clear the motion vector after compile
#jira: UE-53930
Change 3857439 by Lina.Halper
Clear motion vector when end of sequencer when in editor world
#jira:UE-54057
Change 3857384 by Graeme.Thornton
Restore fix for visual studio source code accessor not correctly determining that a content project has no solution and opening a fresh instance of visual studio
#jira UE-50020
Change 3856596 by Chris.Babcock
Fix ResonanceAudioApi Android library architecture filtering
#jira UE-54478
#ue4
#android
Change 3856449 by Michael.Dupuis
#jira UE-35097: Various cosmetic changes that were done in phase 2 that help improve clarity of the design.
Change 3856415 by Dan.Oconnor
Fix regression when loading instances that have had their class deleted. Issue detected by static analysis
#jira UE-54467
Change 3856332 by Ben.Marsh
Resaving TP_HandheldARBP assets to fix version again.
#jira
Change 3856319 by Ben.Marsh
Back out changelist 3855588
Causes build failure in UFE because it introduces a dependency on the Engine module. UFE compiles with WITH_ENGINE = 0.
#jira UE-54472
Change 3856292 by Ben.Marsh
Fix app-local dependencies not being included in binary builds, and only working for code projects in source builds.
#jira UE-54448
Change 3856190 by Martin.Wilson
Fix bone access mismatch between raw mesh bones and final bones (that include virtual bones too)
#jira UE-54266
Change 3856169 by Ben.Marsh
Tag XGEControlWorker.exe as a build product, so it's included in the binary distro.
#jira UE-54283
Change 3856123 by Chris.Babcock
Fix missing ARCore file
#jira UE-54453
#ue4
#android
Change 3856005 by Richard.Wallis
Clone of Dev-Rendering CL 3855993 - turn off FShaderCache.
#jira UE-52928
Change 3855961 by Jian.Ru
Copy 3855047 - fix DFAO Nan problem
#jira UE-54403
Change 3855811 by Martin.Wilson
Add build process for Maya Live Link plugin (standalone, manually triggered) + add built binaries to Engine/Extras (Maya 2016, Maya 2017, Maya 2018)
#jira none
Change 3855758 by Cosmin.Sulea
UE-53569 - tvOS does not package or launch-on
#jira UE-53569
Change 3855727 by Ben.Marsh
Resaving assets with a versioned build in the editor, to fix warnings building DDC.
#jira
Change 3855626 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-50979 (MP4 doesn't resume playback when iOS 11 device wakes from sleep)
#jira UE-50979
Change 3855588 by Graeme.Thornton
Fix visual studio solution path being incorrect for content projects
#jira UE-50020
Change 3855283 by Ben.Marsh
Fix race condition where stdout/stderr write handles could be inherited by multiple processes, resulting in them not being closed (and the process exit being detected) until all processes that inherited them had been closed. Improves performance of ParallelExecutor.
#jira
Change 3855009 by Chance.Ivey
Resaving with version number. #JIRA-54330 #rb none
Change 3854943 by Dan.Oconnor
Fix archetype lookup when searching hierarchy that has been partially reinstanced
#jira UE-53840
Change 3854882 by Ryan.Vance
#jira UE-54438
Removing vr related references to screen percentage.
Removing previously removed gvr screen percentage code that came back in an integration from google.
Change 3854806 by Mike.Beach
Mirroring part of CL 3802176 to fix a crash that can occur when users try to use the default 'DisplayModel' on MotionController components. Also provided users a better error message to explain why a model might not be showing up.
#jira UE-54214
Change 3854680 by Chance.Ivey
Saving assets with version number#JIRA UE-54330 #rb none
Change 3854652 by Uriel.Doyon
Added a tooltip to the EV100 slider in the exposure menu.
Using game settings now disables the slider.
#jira UE-53945
Change 3854605 by Dan.Oconnor
Make sure we don't create objects outered to a placeholder object, also make sure that archetypes that are reinstanced on load are relinked in to the linker table so that they are postload'd (and the old instance isn't)
#jira UE-53954
Change 3854274 by Brandon.Schaefer
Changes in CL 3842286 changed the function glslang::GlslangToSpv and requires a rebuild on Linux
#jira UE-54302
#codeview Arciel.Rekman
Change 3854255 by Phillip.Kavan
Fix a scoping issue for local instanced subobject references in nativized Blueprint C++ code. Also, don't emit redundant assignment statements for instanced subobject reference properties.
- Mirrored from //UE4/Dev-Framework (3853349).
#jira UE-53960
Change 3854177 by Ethan.Geller
#jira UE-54415 set EnabledByDefault to false for Resonance Audio
Change 3854123 by Ethan.Geller
#jira UE-54410 set AudioComponentID
Change 3853775 by Lauren.Ridge
Minor cleanup
#jira UE-54054
Change 3853772 by Lauren.Ridge
Don't create widgets when just testing if the selected widget is a replacement candidate
#jira UE-54054
Change 3853715 by Rolando.Caloca
UE4.19 - Fix for OpenGL overwriting texture units
#jira UE-54401
Change 3853655 by Ben.Marsh
Add a retry loop on creating the first directory before copying files. Attempt to work around problems copying to shared folders.
#jira
Change 3853535 by Ben.Marsh
Expose the engine compatible changelist to Perforce. If EnginePatchVersion > 0, this will be the changelist of the original .0 release.
#jira
Change 3852583 by Nick.Atamas
Resaved assets so they don't produce DDC warnings.
#jira none
Change 3852552 by Uriel.Doyon
Fixed Pre-Exposure shader compilation and Temporal AA issue.
#jira UE-54276
Change 3852354 by Nick.Atamas
Hopefully fixes the static analysis warning from jira issue.
#jira UE-54332
Change 3852281 by Nick.Atamas
Merging CL 3851690 from //Tasks/UE4/Dev-VR-4.19a/... to //UE4/Telease-4.19/...
#jira UE-54331
Change 3852274 by Simon.Tourangeau
Back out changelist 3851041 until Win7 issue is resolved.
#jira UE-54354
Change 3852208 by Jamie.Dale
Merging CL# 3821754 from //UE4/Dev-Enterprise
Class property conversion now goes through NativizeClass/PythonizeClass
This allows it to coerce from Python wrapped object types
#jira none
Change 3852202 by Jamie.Dale
More explicit handling of EngineDir for Python SDK
#jira UE-54345
Change 3851982 by Brandon.Schaefer
Workaround using a hardcoded path
#jira UE-54136
Change 3851748 by Michael.Dupuis
#jira UE-53904: Put the code back to what it was before, as we really only want to perform this code if bIsLayerThumbnail is true, it was changed to fix another issue complaining about a missing shader, that end up being added to the existing functions
Change 3851545 by Marc.Audy
Remove debugging code that slipped in
#jira none
Change 3851461 by Ben.Marsh
Fix #includes with backslashes from crashing UBT.
#jira UE-53996
Change 3851391 by Jamie.Dale
Updated Python to prefer our TPS SDK
#jira UE-54345
Change 3851372 by Jamie.Dale
Added bat file to copy the Python SDK into TPS
#jira UE-54345
Change 3851218 by Ben.Marsh
Add missing template to installed engine build.
#jira UE-54339
Change 3851117 by andrew.porter
QAGame: Removing duplicate map
#jira UE-29618
Change 3851041 by Simon.Tourangeau
Support for DX11 quad buffer stereo rendering
#jira UEENT-704
Change 3850548 by Ben.Marsh
Add TP_HandheldARBP to installed engine build.
#jira
Change 3850424 by Ben.Zeigler
Fix reported memory for asset registry to be correct, extracted from a larger change
#jira none
Change 3850324 by Ryan.Vance
#jira UEVR-1050
Hook up the Rift dynamic res to the new IDynamicResolutionState framework
Change 3849819 by JeanLuc.Corenthin
Unhide Datasmith plugins in "regular" projects to allow easy project conversion
#jira UEENT-795
Change 3849302 by Martin.Wilson
Live Link is no longer experimental in 4.19 (moved from experimental folder to Animation)
#jira none
Change 3849238 by Max.Chen
Sequencer: Remove bKeepStaleTracks so that stale tracks are now always purged.
#jira UE-54248
Change 3849211 by Michael.Dupuis
#jira UE-54181: Prevent foliage edition during PIE or simulate mode
#coderevire jack.porter
Change 3849123 by Benn.Gallagher
Fixed crash in clothing actor creation when the clothing simulation mesh has no simulated vertices
#jira UE-53741
Change 3849120 by Benn.Gallagher
Fixed crash adding empty materials to destructible meshes in the destructible mesh editor
#jira UE-53938
Change 3849047 by Jurre.deBaare
Move material baking out of experimental
#fix follow-up also remove the entry from experimental settings
#jira UE-52685
Change 3848808 by Michael.Dupuis
#jira UE-35097: Remove IncludeTessellationInShadowLOD & RestrictTessellationToShadowCascade from 4.19 as there is currently a bug regarding this in the dynamic rendering code path and would be too risky to fix for now.
Fixed dynamic shadow code path issue vs static code path
Change 3848659 by Lina.Halper
Fix issue with animation resetting in the sequencer
#jira: UE-54047
Change 3848635 by Rolando.Caloca
UE4.19 - Fix static analysis
#jira UE-50449
Change 3848515 by Sorin.Gradinaru
Unshelved from pending changelist '3843541':
WebBrowser Android crash on 4.4.3
#jira UE-53247
#Android
#4.19
Crash on Android 4.x.x caused by a call to a Api Level 21 method
Change 3848514 by Jurre.deBaare
Moving over:
CL 3832173
"Failed to import Alembic files
#jira UE-53941
#fix Change Alembic thirdparty library setup
- Removed old unused library files
- Updated batch files for building HDF5 ILMBase and Alembic libraries to use new AlembicDeploy path
- HDF5 is now build as a Dynamic library (which also enableds multi-threading)
- Added DLLs for HDF5 to build.cs file
CL 3838053
"Adding missing hdf5 dynamic libraries
Change 3848245 by Ben.Marsh
Downgrade warning about not using XGE shader compilation to a log message. Build machines do not have XGE.
#jira UE-54237
Change 3847300 by Phillip.Kavan
Fix shadowed local variable.
#jira UE-54141
Change 3846922 by Max.Preussner
ImgMedia: Fixed image media player never finished initialization if loading failed
Copied from Dev-Sequencer CL# 3846902
#jira UE-54247
Change 3846831 by Arciel.Rekman
Linux: only use lld for x86_64 (UE-54144).
- lld support for other architectures seems to not ready for prime time.
#jira UE-54144
Change 3846771 by Lauren.Ridge
Material window now uses the background color set in preview scene.
#jira UE-52215
Change 3846705 by Ben.Marsh
Fix batch file paths not being quoted correctly when run through XGE.
#jira
Change 3846550 by Lauren.Ridge
Toggling Show Background now updates the background as well
#jira UE-52250
Change 3846417 by Matt.Kuhlenschmidt
Fix crash resizing shootergame window
#jira UE-53137
Change 3846295 by Rolando.Caloca
UE4.19 - New Vulkan descriptor pooling mechanism (enabled on non-android)
#jira UE-50449
Change 3846273 by tim.gautier
QAGame: Updating Material Layer test assets to include more Params
- Added temp assets, quicker repros for bugs
#jira UE-54176, UE-54165
Change 3846255 by Lauren.Ridge
Parameter tab is the primary tab for material instances
#jira UE-54092
Change 3846086 by Chris.Babcock
Add missing SecureHash.h include
#jira UE-54026
#PR #4417
#ue4
#android
Change 3846049 by Martin.Wilson
Fix Set Root Motion Enabled Anim Data Modifier node (previously didn't set the enabled flag)
#jira UE-54220
Change 3846033 by Martin.Wilson
Fix root motion being repeatedly applied ( Clear() call only clears bHasRootMotion flag, not the transform itself )
#Jira UE-54219
Change 3845991 by andrew.porter
QAGame: Updating bindings on activechannels sequencer test content
#jira UE-29618
Change 3845933 by Lauren.Ridge
Check for original material being valid
#jira UE-54166
Change 3845920 by Martin.Wilson
Optimized redundant key removal
#jira UE-51303
Change 3845812 by Matt.Kuhlenschmidt
Fix not being able to change BSP brush shape
#jira UE-53738
Change 3845790 by Martin.Wilson
Fix for assert failure when accumulating root motion in debug.
#jira UE-53955
Change 3845730 by JeanLuc.Corenthin
Fix build breakage
warning: resaved disc.uasset with 4.19.0 preview #1
failure: set the correct default mesh for AreaLightStruct.uasset
#jira none
Change 3845693 by Lina.Halper
Fix issue with previewing pose asset with curve data
#jira: UE-53967
Change 3845533 by Andrew.Rodham
Sequencer: Fixed sub sequences potentially being loaded during AddReferencedObjects
#jira UE-54173
Change 3845472 by Thomas.Sarkanen
Prevented debug object selection dropdown from displaying objects with pending kill outers
#jira UE-54045 - Animation Blueprint Editor Crashes on Compile if the Debug Instance Selection is Other Than No Object or Preview Instance
Change 3845401 by Yannick.Lange
Reverting thumbnail capture from viewport.
#jira UE-53775
#jira UE-53701
Change 3844693 by JeanMichel.Dignard
Changed IES texture brightness to be the max candela value and set the texture multiplier to be 1. This fixes the IES lights intensity being too high.
#jira UEENT-632
Change 3844689 by JeanLuc.Corenthin
Update Datasmith content assets to latest
Copying fix from Dev-Enterprise by Jean-Luc Corenthin CL 3809803
Updated assets with correct release version
Cleanup some paths on static meshes and texture
#jira UEENT-759
#jira UEENT-657
Change 3844571 by Martin.Wilson
Fix motion controller motion source pin still showing when pin is connected to something
#Jira UE-53236
Change 3844564 by Martin.Wilson
Due to previously fixed bug some anim blueprint nodes could have duplicated guids, this fixes them
#Jira UE-54174
Change 3844545 by Jamie.Dale
No longer attempt to parse group separators for numeric inputs
This avoids some ambiguity when parsing numbers for languages such as German
#jira UE-54170
Change 3844221 by Nick.Shin
HTML5 - filter out "windows/super" keys - these are not used in UE4
- but, keycode are not the expected "91 or 92" values, SDL keys are "227 & 231" instead...
#jira UE-54056 HTML5 crashes inside browser upon pressing windows key
Change 3843937 by JeanMichel.Dignard
Fixed a crash when right clicking on a static mesh for which its AssetImportData class is currently unavailable (ie: in an unloaded plugin).
#jira UEENT-764
Change 3843929 by Peter.Sauerbrei
pull over fix for bad directory when copying launch images
#jira UE-53177
Change 3843658 by Thomas.Sarkanen
Text is red again in anim viewports
#jira UE-53224 - Colouring removed from "Animation is being edited" warning messages
Change 3843657 by Thomas.Sarkanen
Enable picking via Enter for details panel asset pickers
The previous (4.18) behavior was to only allow selection of the previous/next item in the list with arrow keys. A fix (CL 3783114) for pickers with many assets broke this. This change now allows for selection of any item by navigating with arrow keys and pressing Enter, as suggested in the Jira.
#jira UE-53440 - Unable to select assets within modal Asset Selection dropdowns after navigating with keyboard entry
Change 3843120 by Dan.Oconnor
Avoid fixing component template games outside the editor, this logic does not work for games that have been nativized
#jira UE-54009
Change 3842841 by Ben.Zeigler
#jira UE-50020
Switch visual studio module back to using absolute paths so go to definition works, broken in CL #3796157
Change 3842582 by Lauren.Ridge
Guards against the widget passed to scrollwidgetintoview being null
#jira UE-54037
Change 3842575 by Max.Chen
Sequence Recorder: Stop recording if the preview window is destroyed.
#jira UE-49778
Change 3842551 by Michael.Dupuis
#jira UE-35097: Minor bug fix, documentation, etc. to the landscape optim that was done in the phase 2 that have 0 risk.
Change 3842371 by Max.Preussner
Media: Merged 4.19 fixes from Dev-Sequencer
CL 3807293 WmfMedia: Fixed YUY2 video format strides
CL 3827988 MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together
CL 3805414 MediaAssets: Setting valid GUID when initializing media texture resource
CL 3804183 MediaAssets: Added missing lock in media sound component
CL 3831580 MfMedia: Media open events generated in same order as on other platforms
CL 3807193 WmfMedia: Fixed incorrect buffer stride for RGB32 video tracks
#jira UE-53532
#jira UE-53328
Change 3842356 by Max.Preussner
ImgMedia: Fixed ensure when cooking project that uses ImgMediaSource
#jira UE-51631
Change 3842335 by Aaron.McLeran
#jira UE-54087
PR #4419: Fixes a crash due to nullptr dereference (Contributed by mgorzel)
Change 3842286 by Rolando.Caloca
UE4.19 - Fix for static analysis
- Glslang 1.0.65.1
#jira UE-54128
Change 3842222 by andrew.porter
QAGame: Updating framerate of EXR_Sequence
#jira UE-29618
Change 3842211 by Ben.Marsh
Fix determination of Windows version string. The manifest for UE4 applications declares compatibility with Windows 10 nowadays, so we get accurate version numbers returned from GetOSVersionInfo().
#jira UE-54035
Change 3842163 by Cosmin.Sulea
UE-53303 - We do not check for remote connection before attempting remote shader compile, causing crashes when misconfigured
#jira UE-53303
Change 3841770 by Max.Chen
Sequencer: Fix to allow keying of an arbitrarily deep property path.
#jira UE-54095
Change 3841758 by Max.Chen
Sequencer: Fix unbound possessable components when pasting spawnables.
#jira UE-54104
Change 3841415 by Lauren.Ridge
Renaming a material layer or material layer blend will no longer cause the asset to appear removed from the stack
#jira UE-53942
Change 3841327 by Arciel.Rekman
Linux: fix Debug build (UE-53855)
- A workaround. UBT should be using proper PCH files instead.
#jira UE-53855
Change 3840975 by Rolando.Caloca
UE4.19 - Updated VulkanRHI
- Fixes for GPU frame time
- Fixes for CPU performance
#jira UE-50449
Change 3840838 by Michael.Dupuis
#jira UE-53944: Make sure the LOD generated is in the valid range to prevent the crash
Change 3840693 by Ben.Zeigler
#jira UE-53923 Fix regression in 4.19 where PrintScriptCallstack is not always safe to call from the immediate window. I narrowed down the issue to some confusing optimized code so I turned off optimization
Copy of CL #3840692
Change 3840680 by Aaron.McLeran
Bringing fixes from Dev-AnimPhys to 4.19.
#jira UE-53903 crash on load with oculus audio and old audio engine
#jira UE-52786, UE-53910 Fix for broken spatialization on xaudio2, old audio engine.
Change 3840663 by Rolando.Caloca
UE4.19 - Fix for layout ensure on HMD projects on Vulkan
#jira UE-50265
Change 3840577 by Rolando.Caloca
UE4.19 - Fix for CPUs with more than 16 cores
#jira UE-53434
Change 3840551 by andrew.porter
QAGame: Setting Allow Bindings from Asset to false
#jira UE-29618
Change 3840491 by Ben.Zeigler
#jira UE-31662 Fix regression with renaming parent inherited function. It was not correctly searching the parent's skeleton class during the child's recompile so it was erroneously detecting the parent function as missing
Copy of CL #3840489
Change 3840297 by Max.Chen
Sequencer: Fix copy/paste crash for lights
#jira UE-54084
Change 3840284 by Michael.Dupuis
#jira UE-53053: Was having a mismatch between the remove reorder and the actual remove
Change 3840215 by Sorin.Gradinaru
Unshelved from pending changelist '3812852':
UE-53550 Level doesn't render on Lenovo 939
UE-53592 Assertion right after rendering scene on Lenovo S939
#jira UE-53550
#jira UE-53592
#4.19
#Android
UE-53550
Removed force disabling texture2DLodEXT and textureCubeLodEXT on Mali-400 devices
The problem was that the shader compiler complains about code lines before the #extension directives.
Placeholder // end extensions in the original shader code - to be replaced with round() functions
UE-53592
Always use a new task for devices that have GIsThreadedRendering=false, even when the call is from the rendering thread
Change 3840048 by Michael.Dupuis
#jira UE-52975: Was always performing the equivalent of an Add, so now we use the Transform during the duplicate
Change 3840005 by Richard.Wallis
Clone of CL 3835252
Fix for shader library not working with iterative cooking, also fixes native Metal library not working with iterative cook. This works by saving a "backup" of the shader library file - this is reloaded only during iterative cook and adds back in shaders that are missing from the current cook.
Fix for extracting/searching .metal files in different directories so debug tgz archiving wasn't working correctly and also support iterative cook.
Includes first pass code review suggestions by Mark Sat and Dmitriy Dyomin.
#jira UE-53815
Change 3839968 by Michael.Dupuis
#jira UE-52289: When OnRegister is called on the component make sure our PerInstanceRenderData is up to date
Prevent a possible crash if ClearInstanceSelection was called on a component with no PerInstanceRenderData existing
##codereview jack.porter
Change 3839924 by Richard.Wallis
Clone of CL 3838093
Fix for rewind / seek bugs in AvfMediaPlayer.
- Don't initialise and send audio buffers that have a duration of Zero from the audio tap. This chokes the audio sink and adds overhead we don't need.
- Don't faff around with current play rates during loop operation - normal seek doesn't do this so loop seek shouldn't either.
- SetRate() should not required to be passed to media tracks - should be enough to do this on audio track select only.
#jira UE-54019, UE-53027
Change 3839321 by andrew.porter
QAGame: Adding missing bookmark to QA-Sequencer_Blending
#jira UE-29618
Change 3839286 by Marcus.Wassmer
Duplicate CL: 3823296
#jira UE-52784
Change 3839229 by Brandon.Schaefer
Fix audio clean up crash when exiting PIE
#jira UE-54050
#review-3839109 @Arciel.Rekman, @Aaron.McLeran
Change 3839223 by andrew.porter
QAGame: Rebinding pointlight actor to sequences
#jira UE-29618
Change 3839098 by andrew.porter
QAGame: Fixing missing sequencer blending test content
#jira UE-29618
Change 3838919 by Mike.Erwin
glTF: binary format's BIN chunk is not necessarily right after the JSON chunk.
Discussed this with glTF spec authors. See https://github.com/KhronosGroup/glTF/issues/1177
Rearranged how we read "chunks" from the file since they are not fixed in number or order, besides JSON always being first.
#jira UE-50695
Change 3838909 by Mike.Erwin
glTF: base64 decoding of data buffers and images
Data can be encoded inside the glTF JSON as a Base64 data URI. This CL addresses a known limitation of initial commit CL 3793018. I added this after because base64 is expected to be uncommon in the wild. Authoring software will typically use external BIN files (.gltf) or a BIN chunk (.glb) to store data.
#jira UE-50695
Change 3838812 by Uriel.Doyon
Integrated CL 3838576, 3838581 and 3831760 from DevRendering, fixing issues with texture streaming.
#jira none
Change 3838773 by Lauren.Ridge
Fixing material layer filters
#jira UE-54064
Change 3838748 by Michael.Trepka
Fixed EngineTest runtime warning caused by CL 3838626
#jira UE-53893
Change 3838730 by Max.Chen
Sequencer: Add notification when the blend type is changed.
#jira UE-54046
Change 3838626 by Michael.Trepka
Changed FMacMenu to store MultiBox and MenuEntryBox as weak pointers instead of shared pointers. This way we avoid a situation where FMacMenu would try to release them on the main Cocoa thread or where we'd try to execute a menu action for menu items that Slate considers released.
#jira UE-53893
Change 3838392 by Arciel.Rekman
Fix assert on a policy removal (UE-54042).
- Applying Gil's safe fix which just sweeps the problem under the rug.
#jira UE-54042
Change 3838162 by Arciel.Rekman
Linux: fix crash due to lambda lifetime issues (UE-54040).
- The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+).
#jira UE-54040
(Edigrating 3819174 to Release-4.19)
Change 3838156 by Rolando.Caloca
UE4.19 - Support for Vulkan devices that have no cached memory type
#jira UE-54039
Change 3838096 by Brandon.Schaefer
Set sound to unfocused volume multiplier if not focused
#jira UE-51327
#review-3835736 arciel.rekman
Change 3838087 by Brandon.Schaefer
Fix arm server building. A fix from CL 3617084 remove inheriting from IHeadMountedDisplayVulkanExtensions. Remove overrides
#jira UE-53901
#review-3838088 arciel.rekman
Change 3837072 by Phillip.Kavan
Fix for a build failure that could occur with Blueprint nativization enabled and EDL disabled. This was a regression introduced in 4.18.
- Mirrored from //UE4/Dev-Framework (3836768).
#jira UE-53908
Change 3837071 by Phillip.Kavan
Emit proper syntax for set/map fields containing converted assets to generated C++ Blueprint class headers when Blueprint nativization is enabled.
- Mirrored from //UE4/Dev-Framework (3835944, 3835965).
#jira UE-42614
Change 3837070 by Phillip.Kavan
#4202 - Blueprint nativization bug fixes (PR).
- Mirrored from //UE4/Dev-Framework (3830562, 3832292).
#jira UE-52188
Change 3836507 by Ryan.Vance
#jira UE-53992
Due to hijacking the depth target directly from the scene context, we can't support depth compositing if it's being scaled by screen percentage since it wont match our color render target dimensions.
Change 3836390 by Dan.Oconnor
Fix failure to resolve archetype when using the compilation manager
#jira UE-53840
Change 3836251 by Ryan.Vance
#jira UE-53992
Change 3835852 by Mark.Satterthwaite
Fix tessellation shaders in Metal with Manual Vertex Fetch enabled:
- The control points idnex buffer shouldn't collide with anything else.
- We can't use the optimisation of loading texture width & height from the buffer meta-table in tessellation shaders as the combined stages don't guarantee not to clobber unused buffer slots and screw it up when we use linear textures.
#jira UE-53851
Change 3835802 by JeanMichel.Dignard
UBT changes for Enterprise deployment
- Allow building enterprise against an installed engine version
- Added enterprise to the cleanup process if its not installed
#jira UEENT-748
Change 3835625 by Bogdan.Vasilache
UE-50257 --> (Skeletal meshes silently fail to render if they have more than 75 bones) --> changed logged error with a warning
#jira UE-50257
Change 3833649 by Mike.Beach
Enabling debug layer when multiview is enabled.
#jira UE-49954
Change 3833525 by Ethan.Geller
Fix copyright in ActiveSound.cpp #jira none #rb none
Change 3642649 by Stewart.Lynch
Renamed loctext key to stop it clashing with an existing entry
#jira UE-49432
Change 3644762 by Stewart.Lynch
LLM update: Added Total, Untracked and FMalloc Unused to LLMFULL stat page. Fixed occasionally missing allocs/frees. Removed platform csv.
* removed CheckSize arg from OnLowLevelFree
* show a warning in LLM Map when replacing existing value. This means that there has been an alloc/free mismatch.
* minor optimization in LLMMap::GetMaxIndex - cache Mask value
* added Total and Untracked stats to LLMFULL. LLMFULL now tracks almost all of the memory that LLMPlatform does, so there is no real need to use LLMPlatform. Removed the LLMPlatform csv.
* added FMalloc Unused stat to LLMFULL to account for memory Binned2 has allocated internally. This can be used to track Binned2 fragmentation over time.
* renamed Binned stats to FMemory to make it more general
* added Default tracking to CustomVirtualAlloc and disable it where necessary. This catches the few VirtualAlloc calls that were missed.
* added AllocType arg to all allocation tracking. This was needed in order to track the FMalloc total, and also to fix the pausing
* fixed a bug in pausing where alloc/frees were being missed. Now only pauses a specific allocation type.
* Trackers now maintain totals for each enum tag
* tracking of Texture and mesh allocation on Windows D3D11 & D3D12
Change 3651334 by Joe.Barnes
Fix misspelled function name.
#jira 39441
#3016
Change 3653857 by Ben.Woodhouse
Integrate from //UE4/Main/...@3653675 to //UE4/Dev-Console/...
Change 3656553 by Joe.Barnes
Add path for SCS_DeviceDepth.
Change 3662703 by Ben.Woodhouse
Merging CL 3659069 from //Fortnite/Main/... to to //ue4/dev-console/...:
[FORTNITE] [CONSOLE] [+] Improved frame syncing mechanism
- Improves input latency by allowing the game thread to sync to the swap chain flip of the previous frame.
- Added "r.GTSyncType" CVar to control how the game thread syncs with the rest of the pipe.
- r.GTSyncType 2 will sync the game thread with the flip of the swap chain, preventing the pipe from getting too long and causing excess input latency.
Platforms are required to implement RHIWaitForFlip and RHISignalFlipEvent, and call RHIInitializeFlipTracking on RHI startup.
A separate thread monitors the progress of frame flips and signals task graph events as they pass their corresponding frame index.
In r.GTSyncType 2 mode, the game thread is signaled by this flip tracking thread.
[~] Unified platform specific sync interval CVars into one: rhi.SyncInterval
- 1 == 60Hz
- 2 == 30Hz
- 3 == 20Hz
Change 3675239 by Keith.Judge
Fixed thread priorities for Windows so that BelowNormal and SlightlyBelowNormal are the same. Bumped Lowest down a notch so they all fit.
#jira UE-50626
Change 3676709 by Ben.Woodhouse
Integrate from //UE4/Main/...@3675008 to //UE4/Dev-Console/...
Change 3689712 by Ben.Woodhouse
Integrate from //UE4/Main/...@3687781 to //UE4/Dev-Console/...
Change 3701778 by Ben.Woodhouse
Integrate from //UE4/Main/...@3699491 to //UE4/Dev-Console/...
Change 3677043 by Ben.Woodhouse
From StewartL:
I also found that on Windows Fortnite is overflowing int32 values due to the number of allocations. I changed LLMArray and LLMMap to use uint32 and it seems to be Ok now. I didn't want to check this in at the last minute, so here's the shelf: 3645336
Change 3726532 by Luke.Thatcher
[CONSOLE] [~] Enable XGE shader compilation by default.
- Also set XGE mode to "force interception". With XGE on by default, we don't want people with an old Incredibuild version using the old system inadvertently.
Change 3726554 by Luke.Thatcher
[CONSOLE] [+] Improved Scoped Named Events
- Added SCOPED_NAMED_EVENT(_FSTRING/_TEXT/_F) macros to allow use of string literals, FString and printf in scoped named event strings.
- Replaced explicit use of FPlatformMisc::Begin/EndNamedEvent throughout the engine with macros, so the events can be compiled out.
- Fixed performance issues on various platforms with named events. SCOPED_NAMED_EVENT macros were not considering whether the platform uses wide or ansi char strings.
Change 3751378 by Ben.Woodhouse
Integrate from //UE4/Main/...@3748735 to //UE4/Dev-Console/...
Change 3751812 by Ben.Woodhouse
Integrate from //UE4/Main/...@3750870 to //UE4/Dev-Console/...
Change 3728571 by Luke.Thatcher
[CONSOLE] [!] Drop another XGE controller warning to log.
Change 3747150 by Joe.Barnes
Add AuthoringToolHelper.bat file to installed build copy list.
Change 3768585 by Ben.Woodhouse
Integrate from //UE4/Main/...@3767531 to //UE4/Dev-Console/...
Change 3772333 by Ben.Woodhouse
Integrate from //UE4/Main/...@3771573 to //UE4/Dev-Console/...
Change 3786872 by Ben.Woodhouse
Integrate from //UE4/Main/...@3786785 to //UE4/Dev-Console/...
Change 3787279 by Luke.Thatcher
[CONSOLE] [~] Unified present threshold CVars.
- CVars are now in RHIUtilities.cpp, and are renamed to rhi.PresentThreshold.Top and rhi.PresentThreshold.Bottom.
- Platform implementations will be checked in shortly.
Change 3787445 by Luke.Thatcher
[CONSOLE] [^] Merging (as edit) improvements to low-latency frame syncing from //Fortnite/Main to //UE4/Dev-Console
Original CLs
- 3708949 - Added rhi.SyncSlackMS cvar to allow an offset of the game thread sync time by a number of milliseconds.
- 3712693 - Fix for crash on startup in new frame syncing.
- 3735765 - Fix r.GTSyncType logic when vsync is disabled (falls back to old behaviour when vsync is off).
Change 3788417 by Ben.Woodhouse
Duplicate from FN CL 3712515
CSV profiler GPU and pre-declared stat support
- refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds
- add support for pre-declared CSV stats, using FNames (these are required for GPU stats)
- add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations
Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats
Change 3807818 by Ben.Woodhouse
Integrate from //UE4/Main/...@3803271 to //UE4/Dev-Console/...
Change 3818577 by Ben.Woodhouse
Integrate from //UE4/Main/...@3812936 to //UE4/Dev-Console/...
Change 3821198 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3820127 to //UE4/Dev-Console/...
Change 3821519 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3820753 to //UE4/Dev-Console/...
#robomerge none
Change 3813513 by Ben.Woodhouse
CSV profiler refactor+ bug fix
- Move the CSV profiler to core, so we can use it in modules other than engine
- Profiler no longer enqueues RT commands - this is handled by a new core delegate type
- Make begin/end requests more robust, enqueued via a command queue and processed in order
- Defer end capture requests by a frame. This ensures stats on threads other than the gamethread (e.g. renderthread etc) are complete, so the last frame is not truncated
- Fix long-standing bug with multiple captures where old/stale frames would appear in the first <128 frames of captures
- Move unit stats and dynamic resolution out of the profiler itself and into the engine. Only frametime is recorded in the profiler now
- Fix longstanding bug in first frame renderthread time in the engine
Change 3814039 by Ben.Woodhouse
More Csvprofiler improvements
- Event support (via CSV_EVENT macros). These appear in the "EVENTS" column of the CSV and can be used to add context to the stat data
- Reduced memory overhead for timestamps through bit-packing (now 16 bytes per marker instead of 24), and splitting stats into different types
Change 3814041 by Ben.Woodhouse
Integrate as edit CL 3796390 from Fortnite/Main:
Fix CsvProfiler not compiling in shipping for now
Change 3814229 by Ben.Woodhouse
Integrate + refactor of CL 3792591 to reduce complexity and fix bugs
Original changelist description:
CSV profiler improvements:
- The CSV profiler is now always compiled in on the server
- The CSV profiler can now handle both int32 and float stats
- In BeginCapture, the function can take additional arguments for some customization of filenames
Fixes to the above:
- Remove FCustomValue class
- Fixes bug where all timestamp values from CSV_SCOPED_STATs were garbage (due to issues resulting from FCustomValue type ambiguity when adding values together)
- FCsvCustomStat now just uses simple union + bitfield flag to reduce size and complexity (4 bytes instead of 8 per value)
- FCsvColumn class modified to use doubles, which can represent both ints and floats without loss of precision - this class is not memory or time critical
- Replace multiple overrides used by the server for filenameprefix/folder/postfix etc with a single FilenameOverride
Change 3814242 by Ben.Woodhouse
Disable CSV unit stats on the dedicated server
Change 3817339 by Ben.Woodhouse
Duplicate from 3816641: CSV profiler improvements
- Added a low-pri processing thread to compress raw timing data into a much more efficient format
- Reduces memory usage for 15 minute 30k frame capture with GPU stats enabled from 110MB to 3.4MB
- Processing time : 0.1ms per frame
- Improved name handling for char literal stats. We now use the string as the ID rather than the pointer so multiple stat uses of the same name string apply only to a single stat
- Reworked thread data access to eliminate locking for anything time-critical. Frame boundaries now handled via a lock-free helper class
- Fixed bug with queue implementation where 1 in 128 reads would duplicate the last block of stat data
- Reduced #include dependencies for CSVProfiler.h
- Removed AccumulateMax because it doesn't work, and implementing properly would add a lot of complexity
- Added a simple test harness
Change 3817582 by Ben.Woodhouse
Fix android compile warning
Change 3823242 by Ben.Woodhouse
Integrate as edit from Fortnite/Main 3820067:
Fix threading issue with D3D12 pipeline state caches for windows. This was caused by the usage of FRwScopeLock::RaiseLockToWrite. A pointer read before RaiseLockToWrite was called was invalidated because RaiseLockToWrite has to release the read lock before acquiring the write lock.
Rename FRwScopeLock::RaiseLockToWrite to ReleaseReadOnlyLockAndAcquireWriteLock_USE_WITH_CAUTION to make it more explicit what's happening. As the comment says:
// This function should be used with caution.
// It releases the read lock _before_ acquiring a new write lock. This is not an atomic operation and the caller should
// not treat it as such.
// E.g. Pointers read from protected data structures prior to this call may be invalid after the function is called.
Change 3823840 by Ben.Woodhouse
Edigrate from 3823816
Fix an issue where the csvprofile console commands would sometimes result in an empty CSV. The root cause was GFrameNumber incrementing between the console command being read and FCSVProfiler::EndFrame(). We now use our own frame counter which is updated in EndFrame, so this can't happen
Also fix an issue where calling csvprofile stop twice would cause all further commands to be ignored.
Change 3827787 by Ben.Woodhouse
Integrate-as-edit CL 3820678 from Fortnite/Main
Allow the CSV Profiler to be compiled in to shipping dedicated server builds
Change 3827842 by Ben.Woodhouse
Integrate-as-edit CL 3827079 from Fortnite/Main
CSV profiler category support
Change 3827918 by Luke.Thatcher
[CONSOLE] [!] Fix compile error in CSV custom stats.
Change 3827964 by Luke.Thatcher
[CONSOLE] [!] Fix inverted logic and spelling of boolean.
- Functionally, the boolean did the correct thing, but the logic was backwards inside the build tool.
Change 3831661 by Ben.Woodhouse
Integrate-as-edit CL 3830630 from Fortnite/Main
Fix CSVProfiler assert in dev builds on XB1
Change 3860300 by Joe.Barnes
Use same method for src and dest rect calculation as other post processing passes so rects match between passes. Prevents read of unprocessed pixels.
Change 3860347 by Joe.Barnes
Delete existing SourceConfigFile before allocating a new one to prevent them leaking.
Change 3860348 by Joe.Barnes
Completely encapsulate GetLLMAlloc() in #ifdef.
Change 3861772 by Ben.Woodhouse
Integrate-as-edit CL 3861688 from Fortnite/Main: Forward lighting GPU crash fixes
Change 3861774 by Ben.Woodhouse
Integrate as edit CL 3833918 from dev-rendering (courtesy of DanielW):
D3D12 RHI: only refcount uniform buffers if GRHINeedsExtraDeletionLatency is false, which is no longer the case for PC. The refcounting was heavy on performance as reported by a licensee because FRHIResource uses atomics for refcounting, which is only necessary when GRHINeedsExtraDeletionLatency is disabled.
Change 3862214 by Ben.Woodhouse
Integrate-as-edit CL 3859637 from Fortnite/Main
Dynamic resolution console tweaks
- Dynamic resolution high level switch driven by a cvar instead of code
- Disable user settings dynamic resolution handling on non-desktop platforms. DynamicRes as a user setting does not make sense on consoles/mobile - we'll drive it from device profiles/scalability
- Modify naming of GPUHeadRoom to make it clear that it's a percentage, not millseconds
Change 3863919 by Ben.Woodhouse
[Copy] Integrate console dynamic resolution interface changes from CL 3863354, 3862754, 3862639
Change 3864347 by Ben.Woodhouse
Fix the editor build. This will need a proper fix before 4.19 ships.
#lockdown Nick.Penwarden
#rb none
[CL 3913399 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3805828 by Gil.Gribb
UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works.
Change 3806784 by Ben.Marsh
UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT.
Change 3807549 by Graeme.Thornton
Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it.
Change 3807727 by Graeme.Thornton
Unhide the text asset format experimental editor option
Change 3807746 by Josh.Engebretson
Remove WER from iOS platform
Change 3807928 by Robert.Manuszewski
When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet
Change 3808221 by Steve.Robb
GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule()
^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway.
Change 3809233 by Graeme.Thornton
TBA: Misc changes to text asset commandlet
- Rename mode to "loadsave"
- Add -outputFormat option which can be assigned "text" or "binary"
- When saving binary, use a differentiated filename so that source assets aren't overwritten
Change 3809518 by Ben.Marsh
Remove the outdated UnrealSync automation script.
Change 3809643 by Steve.Robb
GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value
#jira UE-53037
Change 3809862 by Steve.Robb
GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately
#jira UE-42593
Change 3811190 by Graeme.Thornton
Add support for writing specific log channels to their own files
Change 3811197 by Graeme.Thornton
Minor updates to output formatting and timing for the text asset commandlet
Change 3811257 by Robert.Manuszewski
Cluster creation will now be time-sliced
Change 3811565 by Steve.Robb
Define out non-monolithic module functions.
Change 3812561 by Steve.Robb
GitHub #3886 : Enable Brace-Initialization for Declaring Variables
Incorrect semi-colon search removed after discussion with author.
Test added.
#jira UE-48242
Change 3812864 by Steve.Robb
Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins.
See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html
#jira UE-53089
Change 3820358 by Ben.Marsh
PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist)
Change 3822594 by Ben.Marsh
UAT: Improvements to log file handling.
- Always create log files in the final location, rather than writing to a temp directory and copying in later.
- Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX.
- Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is.
- Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location.
Change 3823695 by Ben.Marsh
UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk).
Now always queries changes up to the last change for which zipped binaries are available.
Change 3823845 by Ben.Marsh
UBT: Exclude C# projects for unsupported platforms when generating project files.
Change 3824180 by Ben.Marsh
UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes).
#jira
Change 3825777 by Steve.Robb
Fix to return value of StringToBytes.
Change 3825810 by Ben.Marsh
UBT: Reduce length of include paths for MSVC toolchain.
Change 3825822 by Robert.Manuszewski
Optimized PIE lazy pointer fixup. Should be up to 8x faster now.
Change 3826734 by Ben.Marsh
Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency.
Change 3827730 by Steve.Robb
Try to avoid decltype(auto) if it's not supported.
See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html
Change 3827745 by Steve.Robb
Initializer list support for TMap.
Change 3827770 by Steve.Robb
GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType()
#jira UE-53813
Change 3829189 by Ben.Marsh
UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off.
Change 3830444 by Steve.Robb
BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library.
This should be revisited when Core has its own JSON library.
Change 3830718 by Ben.Marsh
Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups.
The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip.
For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it.
When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk.
#jira UE-53845
Change 3831064 by Ben.Marsh
Fix log file contention when spawning UBT recursively.
Change 3832654 by Ben.Marsh
UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it.
Change 3832680 by Ben.Marsh
UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade.
Change 3832695 by Ben.Marsh
UGS: Invert the options in the 'Show Changes' submenu for simplicity.
Change 3833528 by Ben.Marsh
UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write].
Change 3833543 by Ben.Marsh
UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules.
Change 3834354 by Robert.Manuszewski
Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks.
#jira UE-52035
Change 3834400 by Robert.Manuszewski
Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup.
#jira UE-52035
Change 3834947 by Steve.Robb
USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal.
Change 3835004 by Ben.Marsh
Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL.
Change 3835340 by Ben.Marsh
Fix errors making installed build from directories with spaces in the name.
Change 3835972 by Ben.Marsh
UBT: Improved diagnostic message for targets which don't need a version file.
Change 3836019 by Ben.Marsh
UBT: Fix warnings caused by defining linkage macros for third party libraries.
Change 3836269 by Ben.Marsh
Fix message box larger than the screen height being created when a large number of modules are incompatible on startup.
Change 3836543 by Ben.Marsh
Enable SoundMod plugin on Linux, since it's already supported through the editor.
Change 3836546 by Ben.Marsh
PR #4412: fix type mismatch (Contributed by nakapon)
Change 3836805 by Ben.Marsh
Fix commandlet to compile marketplace plugins.
Change 3836829 by Ben.Marsh
UBT: Fix ability to precompile plugins from installed engine builds.
Change 3837036 by Ben.Marsh
UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds.
Change 3837037 by Ben.Marsh
UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro).
Change 3837040 by Ben.Marsh
UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed.
Change 3837247 by Ben.Marsh
UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files).
Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor.
Change 3837262 by Ben.Marsh
UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module.
Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets.
Change 3837343 by Ben.Marsh
UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead.
Change 3837356 by Ben.Marsh
Fix invalid character encodings.
Change 3837727 by Graeme.Thornton
UnrealPak: KeyGenerator: Only generate prime table when required, not all the time
Change 3837823 by Ben.Marsh
UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window.
Change 3837831 by Graeme.Thornton
UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives
Change 3837857 by Robert.Manuszewski
PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch)
Change 3837943 by Robert.Manuszewski
PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch)
Change 3838451 by Ben.Marsh
UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread.
#jira UE-53996
Change 3839519 by Ben.Marsh
UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data.
Change 3843790 by Graeme.Thornton
UnrealPak: Log the size of all encrypted data
Change 3844258 by Ben.Marsh
Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace.
Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure.
#jira UE-54157
Change 3845796 by Ben.Marsh
Workaround for slow performance of String.EndsWith() on Mono.
Change 3845823 by Ben.Marsh
Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun.
#jira UE-54123
Change 3845901 by Arciel.Rekman
Linux: fix crash due to lambda lifetime issues (UE-54040).
- The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+).
(Edigrating 3819174 to Dev-Core)
Change 3846439 by Ben.Marsh
Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates.
Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main.
Change 3816608 by Ben.Marsh
UBT: Use DirectoryReference objects for all include paths.
Change 3816954 by Ben.Marsh
UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere.
Change 3816986 by Ben.Marsh
UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly.
Change 3816991 by Ben.Marsh
UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules.
Change 3823090 by Ben.Marsh
UAT: Improve logging for child UAT instances.
- Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder.
- Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway.
- Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read.
- Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output.
Change 3826082 by Ben.Marsh
UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target.
Change 3827025 by Ben.Marsh
UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling.
Change 3829927 by James.Hopkin
Made HTTP interface const correct
Change 3833533 by Ben.Marsh
Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules.
Change 3835826 by Ben.Marsh
UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced.
Change 3835969 by Ben.Marsh
UBT: Fix cases where text is being written directly to the console rather than via logging functions.
Change 3837777 by Steve.Robb
Format string type checking added to FOutputDevice::Logf.
Fixes for those.
Change 3838569 by Steve.Robb
Algo moved up a folder.
[CL 3847482 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb no.one
============================
MAJOR FEATURES & CHANGES
============================
Change 3543285 by Nick.Atamas
Merging using //UE4/Release-4.17/... -> //UE4/Dev-VR/... :
Fixed UEVR-852:
Adjusted Google Tango Plugins copyright to Copyright Google 2017.
Removed Apache 2.0 license.
Change 3767306 by Mike.Beach
Adopting a set of video capture fixes from Darren Pegg:
"Windows 7 : fix capture problems by reinitializing tracks, only active on windows < 8.0."
+ mirroring CL 3741444 ("Add windows 10 support to the application manifest"), which was needed for this
#jira UE-49870, UE-50217, UE-50227, UE-50224
Change 3767317 by Mike.Beach
[MR] Fixing up the mixed reality framework's async BP nodes (handling MediaPlayer assets set to not play-on-open - preventing a crash and keeping the stream playing), so they work with the changes to the WMF media player introduced in CL 3767306.
#jira UEVR-910
Change 3767484 by Mike.Beach
Correcting user facing messages/tooltips to use the proper trademarked "Gear VR" name (not "GearVR" without a space).
Change 3767489 by Mike.Beach
Correcting source comment to use the proper trademarked "Gear VR" name (not "GearVR" without a space).
Change 3768155 by Ryan.Vance
#jira UE-52089
Fixing cardboard only rendering in one eye.
Change 3769011 by Douglas.Copeland
Removing Clipping Planes from TM-HMDNodes (Level and LevelBP. Feature removed). Rebuilding Map.
Change 3769195 by Douglas.Copeland
Removing AA PostProcessing Volumes in TM-VRSmoke. AA does not change via PP Volumes since 4.14
Change 3769256 by Douglas.Copeland
Removing TM-VRLandscapeFoliage Map. Never used in suite/bloat.
Change 3769453 by Douglas.Copeland
Resaving content to resolve engine content warning
Change 3771076 by Keli.Hlodversson
Add missing const to a ref parameter.
Change 3771141 by Keli.Hlodversson
Fix world locked stereo layer positions on SteamVR when there is a camera component representing the HMD.
#jira UE-52353
Change 3771602 by Mike.Beach
Replacing temp Rift controller models with official ones from Oculus.
#jira UEVR-830
Change 3774877 by Mike.Beach
Refining MR calibration (WIP)...
- New alignment process [WIP]
- More modular calibration steps (for easier refactoring)
- Stubbed in phase for lens calibration
- Centralized interface for debug (dev) settings
Change 3774880 by Mike.Beach
Adopted changes from Oculus (SI1.21); stubbing in functionality for:
- Lens matched shading
- Dynamic screen refresh rate switching
- Added BP API calls: GetGPUUtilization, GetTiledMultiresLevel , SetTiledMultiresLevel, GetDeviceName, GetAvailableDisplayFrequencies, GetCurrentDisplayFrequency, SetDisplayFrequency
Change 3774922 by Mike.Beach
Attempting CIS fix.
Change 3774972 by Mike.Beach
Making it so you can override the material on model components from the various XR systems (via MotionController component).
Change 3774974 by Mike.Beach
Missing assets from CL 3774877.
Change 3775128 by Nick.Atamas
Merging //UE4/Partner-Google-VR @ CL 3770408 to Dev-VR (//UE4/Dev-VR)
Change 3776135 by Mike.Beach
MR [WIP] - Updating the calibration save process .
- Now save after each calibration step
- Stubbed in save data for lens distortion
- Track progress and load you to the first incomplete calibration step
Change 3777110 by Mike.Beach
[WIP] MR - Adding ability to easily mirror monitor screen.
Change 3777146 by Mike.Beach
Removing superflous ensure that some of us were hitting.
Change 3777417 by Mike.Beach
[WIP] MR - Fixing alignment adjustment controls to match mirrored monitor.
Change 3777436 by Nick.Atamas
Initial check in of AugmentedReality module and ARKit support for it.
Also adding QAARApp to test the use of these systems.
Change 3778009 by Nick.Atamas
Missing file
Change 3778067 by Nick.Atamas
Fixing CIS
Change 3778155 by Nick.Atamas
Spot merging CL 3777463 //UE4/Partner-Google-VR to //UE4/Dev-VR
Change 3778209 by Nick.Atamas
More CIS fixing.
Change 3778821 by Mike.Beach
[WIP] MR - Moving the alignment point system to pull from an easily modifiable DataTable (so we can change easily).
Change 3779431 by Joe.Graf
Merging using //UE4/Dev-Editor/_to_//UE4/Dev-VR/
Change 3780822 by Keli.Hlodversson
Adding OpenCV binaries plus build script to automatically fetch and rebuild it
#jira UE-52725
Change 3781037 by Joe.Graf
Merging hlslcc changes using //UE4/Dev-Rendering/__to__//UE4/Dev-VR/
Change 3781046 by Joe.Graf
Merging hlslcc changes using //UE4/Dev-Rendering/__to__//UE4/Dev-VR/
Change 3781049 by Joe.Graf
Merging hlslcc changes using //UE4/Dev-Rendering/__to__//UE4/Dev-VR/
Change 3781129 by Joe.Graf
Fixed the warning generated by OpenCV.Build.cs
Change 3783476 by Mike.Beach
Attempt at fixing Win32 CIS errors.
Change 3783845 by Martin.Wilson
Allow deprecated properties to still be accessed in blueprints so long as they have Blueprint Getters and Setters. Allows us to have a clean deprecation path for blueprint accessed properties
Change 3784397 by Jeff.Fisher
UE-51390 GitHub 4141 : Allow VR plugins to have multiple viewports and rotated eye orientations
PR #4141: Allow VR plugins to have multiple viewports and rotated eye orientations (Contributed by AustinPuk-Conffx)
-This loosens some assumptions in the api about how many stereo render passes there are to allow plugins to implement more than we currently use for any of our plugins.
-It also starts to replace some comparison test logic with the stereo pass enum values with IStereoRendering helper functions, do avoid duplicating the expressions all over.
#jira UE-51390
#review-3779148
Change 3784545 by Jeff.Fisher
Build fix for cl 3784397, made a local variable name unique.
Change 3784553 by Chance.Ivey
Stubbing Mobile AR Template files. Needs logic, icons and copy.
Change 3784570 by Jeff.Fisher
fix for cl 3784397
-Reverted monoscopicfarfield default change, accidentaly submit
Change 3785134 by Mike.Beach
[WIP] MR - Correcting some of the alignment algorithms & adding a preview key for the new alignment.
Change 3787180 by Mike.Beach
Fixing up CIS
#jira UE-52998, UE-52996
Change 3787272 by Mike.Beach
Adopted changes from the anim team - Followup to CL 3787240.
The LiveLink framework is now implementing the new IMotionController interface, and supplying tracking+ data through the engine's MotionController components.
#jira UE-52783
Change 3787454 by Jeff.Fisher
Adding brackets after if as specific in code review.
Change 3787591 by Keli.Hlodversson
Add tps files for OpenCV
Change 3788478 by Mike.Beach
Switching over the MR calibration process to use the new MotionController source ID (rather than the deprecated Hand enum). Also, adding device attachment selection to the first calibration step and switching it to use the new modular interface system.
#jira UEVR-1042, UEVR-1045, UEVR-1046
Change 3789836 by Jeff.Fisher
UE-53069 Editor crashes on open without SteamVR attached
-needed to check we are in stereo and device exists.
-Note just having the morpheus plugin enabled creates a device, so you need to have that disabled to reproduce this bug
#jira UE-53069
Change 3789841 by Mike.Beach
CIS fix - fallout from CL 3787272.
Change 3790102 by Jeff.Fisher
UE-53079 Packaging for android results in a critical error referencing global shader FHdrCustomResolveFMask4xPS
-Android shader compiler is a bit pickier on parameter matching, fixed the parameter.
#jira UE-53079
Change 3790174 by Jeff.Fisher
UE-53084 Mac editor crashes on open, Failed to compile global shader FWideCustomResolve8_2x_truePS
-Another shader parameter match.
#jira UE-53084
Change 3791727 by Mike.Beach
Fallout from CL 3787272 - missed use of now deprecated Hand property on MotionController components.
#jira UE-53080
Change 3766717 by Mike.Beach
Adding a TrackingToWorld transform to IXRTrackingSystem - default impl updates the cached transform once per frame (at the begining) and determines it from the project's camera setup (making the assumption the camera's root is the XR origin).
Change 3771327 by Ryan.Vance
#jira UE-52513
Fixing console rendering. The ortho projections were taking screen percentage of the panel into account for size instead of pixeldensity * ideal size.
Change 3773348 by Mike.Beach
Merging //UE4/Dev-Main to Dev-VR (//UE4/Dev-VR)
Change 3787240 by Mike.Beach
Adopting IMotionController changes from anim team (in support of LiveLink)...
- MotionControllerComponent EControllerHand Hand is deprecated, replaced by FName MotionSource
- Blueprint get set nodes for the Hand property will still function but will warn as deprecated, this is achieved via using deprecated BlueprintGetter and BlueprintSetter on the property (plus a change to UHT to allow that to compile)
- MotionSource Setter node has pin customization to show choice box instead of standard FName text box.
- New base class for motion controllers XRMotionControllerBase.h/cpp
- Provides default implementations for new functions (Enumerate Source, Custom Parameter etc)
- Provides wrapper functions that take EControllerHand so that the controllers themselves dont have to change.
- Motion Source custom choice box. Polls MotionControllers for sources via EnumerateSources interface. Also allows custom text type in. Is Exposed to details panel and setter pin (as above).
- Added a Dev-VR custom version for reading the Hand property and moving it to MotionSource
#jira UE-52783
Change 3787975 by Ryan.Vance
Merging //UE4/Dev-Main to Dev-VR (//UE4/Dev-VR)
[CL 3794679 by Mike Beach in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 2932765 by Nick.Whiting
Merging updated license files for Oculus libraries
Change 3480552 by Dustin.Holmes
Added map and gamemode for calibration
#jira UEVR-808
Change 3502253 by Nick.Whiting
Trying to fix up p4's botch of the merge
Change 3513736 by Keli.Hlodversson
Move duplicated late update code into a common FLateUpdateManager
#jira UEVR-893
Change 3514798 by Mike.Beach
#4.17
Exposing a way for Blueprint users to remap the SteamVR controller's d-pad buttons (clashes with the Oculus mappings).
#jira UE-42634
Change 3516042 by Dustin.Holmes
Runtime handedness changes in Vive controllers are now reflected when a new device is connected. Device mappings are also reset when a device disconnects, so that if it connects again it fully reregisters instead of just assuming the role it previously had.
Change 3517781 by Keli.Hlodversson
Remove unused local variable bUseCustomPresentTexture
Change 3517951 by Mike.Beach
#4.17
Guarding against dereferencing a null pointer. Defaulting to the identity when we don't (yet) have a valid head pose to use.
#jira UE-43685
Change 3518142 by Mike.Beach
#4.17
Resolving fallout from bad merge (CL 3514868) - checking for teminating null in array (which was added to keep ARRAY_COUNT from acting on an empty array).
Change 3523183 by Ryan.Vance
#jira UE-46493, UEVR-661
Fixes GearVR only displaying a black screen on startup
Fixes GearVR rendering incorrectly with mobile multi-view w/o direct mode enabled
Adding mobile multi-view direct support to Daydream
Change 3523718 by Nick.Whiting
Adding core controller recentering delegate, and moving Google over to that system.
Change 3527263 by Dan.Oconnor
Mirror 3526925 for Nick Donaldson
Change 3533596 by Dustin.Holmes
Add garbage matte map, gamemode, and blueprints.
Change 3533598 by Dustin.Holmes
Expose the Set Tint Color and Opacity function for Widget Components as a Blueprint node.
Change 3538139 by Mike.Beach
Moving Oculus debug shader directly into Oculus plugin.
#jira UE-47134
Change 3543185 by Nick.Atamas
Address UEVR-891 : Merge in changes to Google Tango plugin.
#jira UEVR-891
Change 3543285 by Nick.Atamas
Merging using //UE4/Release-4.17/... -> //UE4/Dev-VR/... :
Fixed UEVR-852:
Adjusted Google Tango Plugins copyright to Copyright Google 2017.
Removed Apache 2.0 license.
Change 3545505 by Nick.Atamas
Fix UEVR-851 : some fix-ups to MeshReconHUD and overlay material now has a material parameter for tinting the reconstructed mesh to help debug visualization.
Change 3547549 by Jeff.Fisher
Fixing DefaultSpectatorScreenController comment.
Change 3551339 by Ryan.Vance
#jira UE-44947
Editor primitives we not being handled correctly with ISR.
Change 3554169 by Dustin.Holmes
Reconcile missed Mixed Reality blueprint
Change 3566825 by Mike.Beach
Fixing some bad merges from Main (fallout from CL 3566309)
Change 3567143 by Mike.Beach
Copying //Tasks/UE4/Dev-MixedReality to Dev-VR-Minimal (//UE4/Dev-VR-Minimal)
Change 3567572 by Mike.Beach
[WIP] Adding some MR plugin dependencies to keep CIS quiet (SteamVR is just temporary, and will be removed).
Change 3569116 by Jeff.Fisher
Mixed reality build breaks for PS4
-Module is dependent on steamvr, so don't build it for PS4.
-Removed unused class that doesn't compile with clang.
Change 3569362 by Mike.Beach
Organizing MR plugin content, to make way for new calibration modes.
Change 3572802 by Jeff.Fisher
UEVR-832 Add save/load system for calibrated camera settings
-Moved MixedRealityConfigurationSaveGame to c++.
#review-3571779
#jira UEVR-832
Change 3573864 by Mike.Beach
[WIP] Initial work on MR cam alignment controller - records point/frustum data from user input.
Change 3575900 by Jeff.Fisher
Vive spectator flat rect expanded to match other platforms.
-The vive 'full flat eye' rect was narrower than other platforms. Expanded it to be closer to the other platforms.
Change 3578684 by Mike.Beach
Static analysis fixes for CIS.
#jira UE-48204, UE-48203, UE-48206
Change 3579460 by Mike.Beach
[WIP] New calibration mode for camera alignment.
#jira UEVR-785
Change 3581232 by Mike.Beach
[WIP] Saving off alignment calibration data, and loading it on initialization. We skip alignment calibration if it has been configured.
#jira UEVR-832
Change 3588411 by Mike.Beach
[WIP] Adding calibration for compositing (chroma color, etc.).
#jira UEVR-785
Change 3588541 by Mike.Beach
[WIP] Cleaning up some display issues with the MR calibration.
#jira UEVR-785
Change 3588680 by Mike.Beach
Re-organizing the MR content, now that the alignment controller calibrates more than just alignment (renaming, etc.).
Change 3588694 by Mike.Beach
Renaming the MR calibration pawn (since it doesn't do any calibrating itself).
Change 3591518 by Mike.Beach
Copying //Tasks/UE4/Dev-MixedReality to Dev-VR-Minimal (//UE4/Dev-VR-Minimal)
Change 3591671 by Ryan.Vance
Debug stereo layer support
This adds an option to render the debug canvas to a stereo layer which greatly improves console and stat readability in an hmd.
Change 3591812 by Ryan.Vance
Don't snap motion controllers to the origin when tracking is lost.
Change 3594681 by Mike.Beach
[WIP] Copying //Tasks/UE4/Dev-MixedReality to Dev-VR-Minimal (//UE4/Dev-VR-Minimal)
Change 3596679 by Mike.Beach
CIS fix (likely fallout from CL 3591671) - changing the order of initialization to better match the order of declaration.
Change 3598191 by Jeff.Fisher
UEVR-807 Setup M_MRVidProcessing to use 3D garbage matte data.
-Created MixedRealityGarbageMatteCaptureComponent. An instance of this is spawned by and attached to MixedRealityCaptureComponent. Saved config data is loaded into it. It spawns a garbage matte actor. It then captures the garbage matte actor into a render target (which is set on MixedRealityCaptureComponent).
#jira UEVR-807
#review-3598179
Change 3598276 by Mike.Beach
Copying //Tasks/UE4/Dev-MixedReality to Dev-VR-Minimal (//UE4/Dev-VR-Minimal)
Change 3598332 by Mike.Beach
Guarding against a blind cast in the SteamVRChaperone component, which can be used cross platform (can't assume SteamVR).
Change 3605271 by Mike.Beach
Copying //Tasks/UE4/Dev-MixedReality to Dev-VR-Minimal (//UE4/Dev-VR-Minimal)
Change 3608490 by Jeff.Fisher
UEVR-987 Social Screen PS4 need to go to 'mirroring' for hmd setup dialog because system dialogs are not visible in separate mode.
UEVR-988 SpectatorScreen Flickering
UE-47234 Spectator screen: need frame delay before assigning dynamically created rendertarget to spectator texture
UE-47310 Spectator Screen: crash if you release a render target which is assigned as the spectator texture
-Test level content for all of these bugs.
Change 3608883 by Jeff.Fisher
UEVR-807 Setup M_MRVidProcessing to use 3D garbage matte data.
-Set material to use the garbage matte render target.
Change 3613292 by Mike.Beach
Moving header fcn decl up, under the proper interface section (for organization's sake).
Change 3616943 by Nick.Whiting
Updating SteamVR libraries to 1.0.9, so we can bring back macOS support
Change 3616970 by Nick.Whiting
Adding in steamvr visible area mesh support. Can be toggled with vr.SteamVR.UseVisibleAreaMesh
Change 3617866 by Mike.Beach
Updating the VR template to reflect Oculus HMD device naming that we've keyed off of in these Blueprints (when determining which VR system we're running on).
Change 3620108 by Mike.Beach
[WIP] Adding an intermediate calibration step to tweak the MR virtual cam's alignment.
Change 3620982 by Mike.Beach
Tying off some loose ends with the MR calibration map:
* Saving after each calibration phase
* Fixing blocked input from garbage matte creation
* Blocking input handling while exiting/previewing
* Adding minimum radius for random screen pt
Change 3621551 by Mike.Beach
[MR] Leveraging camera support in the new media framework - working for limited cameras in calibration.
Change 3621552 by Mike.Beach
[MR calibration] - fixing it so when you first switch into compoisiting calibration it updates the property readout.
Change 3621660 by Mike.Beach
[MR calibration] Cleaning up how we display text (adding a struct to wrap the coresponding properties).
Change 3623323 by Dustin.Holmes
Fix buffer overflow when using 5+ Vive generic trackers and add more Special hand designations to cover the maximum 11 trackers Vive supports
Change 3625900 by Keli.Hlodversson
Remove fixed 16:9 aspect ratio for SteamVR and Oculus splash screens.
Oculus was already fixed in CL#3413801, but regressed with plugin renaming and unificiation with GearVR in CL#3502152.
#jira UE-40220 StereoLayer splash layers are hardcoded to 8 by 4.5 meters (16:9 aspect ratio)
Change 3628409 by Mike.Beach
Speculative CIS fix.
#jira UE-49339
Change 3628440 by Nick.Whiting
Fix for SteamVR OSX build issues
Change 3628489 by Nick.Whiting
Fix for win32 build break
Change 3629045 by Mike.Beach
Shadowed variable name fix (CIS).
Change 3629202 by Arciel.Rekman
Copying //UE4/Partner-Valve@3629179 to Dev-VR (//UE4/Dev-VR)
Change 3629340 by Nick.Atamas
Unshelved and resolved changes from Oculus.
Change 3629772 by Ryan.Vance
Fixing Oculus Vulkan related compile issues. This will break Oculus Vulkan support, but the code needs to be refactored anyway.
Change 3629833 by Mike.Beach
Fixing up CIS warning introduced by Oculus 1.17 changes - "unsafe conversion" warning
#jira UE-49376
Change 3630696 by Jeff.Fisher
UE-49415 //UE4/Dev-VR: Incremental UE4Editor Win64 completed with errors - 5 Errors
Switching an include to a forward declaration
-Not sure why the previous version didn't compile on the build machine, but fewer dependencies is good.
Change 3630783 by Mike.Beach
Fixing CIS compiler failures for our vehicle templates.
#jira UE-49417
Change 3630802 by Mike.Beach
Better fix than 3630783 - updating the vehicle template's stereoscopic check (fixing the VehicleHud.cpp logic as well)
#jira UE-49417
Change 3630870 by Mike.Beach
Pragma'ing out a function pointer cast warning. Good warning, but I figure we know what we're doing here and there's no other way around it.
#jira UE-49376
Change 3630993 by Ryan.Vance
Check to ensure we have a valid third camera before trying to use it.
We could check >= 3 or if the left and right cameras are left/right stereo etc. decided to go with the simple test for now.
Change 3631322 by Jeff.Fisher
UEVR-909 PIP in Garbage Matte
-Added ExternalGarbageMatteActor to MixedRealityGarbageMatteCaptureComponent and exposed it to blueprint though MixedRealityCaptureComponent. This lets us switch from using the normal mixed reality component save/load garbage matte data and instead use an external actor, in this case the actor we use to setup the garbage matte. Then the mask is able to capture that actor live as it is edited.
-Also implemented GetViewOwner() so that we can use SetOwnerOnlySee to prevent other cameras and captures from seeing the garbage matte actor.
-Calibration level now uses the external garbage matte actor to let the garbate matte mask live update. It also does a picture-in-picture preview of the mixed reality scene. 'P' can show/hide the garbage matte actor on that PIP preview.
-Added SetUnmaskedPixelHighlightColor to MixedRealityCaptureComponent and the material. With this one can make unmasked video pixels more obvious in the output. The calibration level has this mapped to shift-P and makes pixels bright yellow to white.
-Added blueprint to calibration level to make the garbage matte actor visible in the mixed reality capture. That is bound to ctrl-g.
-GarbageMatteActors spawned by the mixed reality capture component are now attached to the vr origin. The calibration level now saves garbage matte mesh transforms relative to the vr origin.
-The garbage matte mesh is now plugin content, and is referenced in the mixedrealitycomponent default object, so it is cooked in any project that includes the plugin.
-Fog and AtmosphericFog no longer affect the garbage matte mask capture... there may be other things we need to turn off there.
#review-3618345
#jira UEVR-909
Change 3631362 by Keli.Hlodversson
#jira UE-49418 Exiting Google Instant Preview displays half of the editor viewport as black.
Note convoluted fix: passing bIsStereoScopic3D to IsActiveThisFrame. ISceneViewExtension code cannot rely on StereoRenderingDevice->IsStereoEnabled to know whether to render in stereo, as the current viewport widget may disable it. This was not a problem before the refactoring, as HMD-related viewextensions were only added to the active list after establishing that stereo indeed was enabled and allowed by the current view port widget.
Change 3631887 by Jeff.Fisher
Fixing IsActiveThisFrame build break.
Change 3632206 by Nick.Atamas
Fix for UE-49413.
Registering FOculusHMD as an extensions the same way as others: now creates an XRCamera that passes all the calls back to the HMD.
Change 3632264 by Nick.Whiting
Fix for Vive rendering getting cropped off due to invalid subrect values being submitted to the compositor.
Change 3632340 by Nick.Atamas
Merged in change from Loren; opted for our solution to ViewExtensions instead of the one in the changelist.
Original description below.
Change 3632214 by Loren.McQuade@Loren.McQuade_Dev-VR on 2017/09/07 19:51:29 *pending*
[Dev-VR] Added OculusHMD_SceneViewExtension, PlayerPosition/PlayerOrientation values, FOculusHMD::GetRelativeEyePose cross-eyed madness (CL 3631541, 3631687)
Change 3632353 by Ryan.Vance
#jira UE-49468
Don't apply xr camera rotation on the player controller when not using xr tracking.
Change 3632735 by Keli.Hlodversson
Better fix for #jira UE-49413.
Revert oculus xr camera code and use that one can have more than one view extension registered instead.
Use GetPriority to have the OculusHMD view extension code execute after the default xr camera.
The xr camera subclass did not forward the calls to ISceneViewExtension to the parent, breaking various functionality such as late update.
Fixes a crash when entering VR pie twice, back to back.
Change 3632752 by Keli.Hlodversson
Applying change 3632592 by Loren.McQuade@Loren.McQuade_Dev-VR_Branch on 2017/09/08 02:08:22
[Dev-VR] Push //UE4/Partner-Oculus@3632591 #rb merge
//UE4/Partner-Oculus to //UE4/Dev-VR/...
Reverted OculusHMD_XRCamera changes, as that clas has been removed in the interim.
Change 3633211 by Mike.Beach
Backing out Oculus MotionController hiding that accidently got submitted - we decided not to adopt this change originally.
Change 3633315 by Jeff.Fisher
merge from main with dev-platform problem children
-expecting SDRBackBuffer stuff to be wrong.
Change 3634006 by Mike.Beach
Resurecting Oculus clip plane settings which got dropped in the IXR refactor.
#jira UE-49520
Change 3634639 by Keli.Hlodversson
Avoid include cycle
https://ec-01.epicgames.net/commander/link/jobStepDetails/jobSteps/68863219?stepName=UE4Editor%20Static%20Analysis%20Win64%20%28IncludeTool%29&jobId=7995809&jobName=UE4%20Dev-VR%20-%20CL%203632752%20-%20Nightly%20Build&tabGroup=diagnosticHeader&firstPage=1
Change 3634641 by Jeff.Fisher
UE-49535 Lighting is blown out when playing in VR Preview on Vive
-Need pixel format to be PF_B8G8R8A8 for vr, now the plugins all build their render target and use that format.
#review-3634623
Change 3634682 by Jeff.Fisher
IHeadMountedDisplay forward declarations needed.
Change 3634690 by Ryan.Vance
We can't override the screen percentage when rendering for stereo
#jira UE-49287
Change 3635970 by Keli.Hlodversson
#jira UE-49563 Crash while opening QA-Game Referencing SharedPointer.h
Verify that StereoRendering is valid before calling IsStereoEnabled()
Change 3635979 by Mike.Beach
CIS static analysis fix - checking a ptr for null before we use it.
#jira UE-49531
Change 3636059 by Mike.Beach
Fixing XR system name aliasing for the -hmd command.
[CL 3638830 by Ryan Vance in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3536809 by Ben.Marsh
Fixing case of files in "iOS" directory, pt 1.
Change 3536814 by Ben.Marsh
Fixing case of files in "iOS" directory, pt 2.
Change 3596207 by Thomas.Sarkanen
Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250
PhAT Upgrade
#jira UEAP-29 - New PhysicsAsset editor
Changelists from task stream:
Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working.
This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added.
Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Renaming PhAT files to PhysicsAssetEditor
Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Rename PhAT -> PhysicsAssetEditor
Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed up PhAT to Physics Asset Editor
Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Reverted some over-zealous renaming
Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it
Added the ability to hide filter menus to skeleton tree
Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added new physics asset skeleton tree builder
Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Skeleton tree extensions to support physics assets
Only started this work - still much to do
Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Rearranged persona viewport menus
Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed body/constraint modes.
Added graph editor
Added edit mode - moved viewport client code over
Got PhAT skel mesh rendering in viewport
Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Increased hit proxy priority to improve selection
Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Skeleton tree gets bodies & shapes back.
Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport.
Added multi-select to bone proxy customization
Re-tweaked editor layout
Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Selection sync work.
Customization of anim viewport menus.
Context menus for physics asset items, as well as masking of various context menu items via settings.
Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next!
Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
More viewport menu fixups (plus deleting duplicate functionality).
Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early).
Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion.
Cleaned up unused files & code
Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Allow extensibility of viewport menu bars
Slate changes:
Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points.
Allow menu bars to optionally invert-on-hover.
Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used.
Adjusted core styling of menu bar elements.
Other changes:
Adjusted padding for various UI elements to preserve previoud behavior.
Adjusted SAnimViewportToolbar to use the new menu bar builder.
Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar.
Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added extension point to viewport menu bar
Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Getting sim working again
Moved over to using preview instance so we share functionality with Persona editors.
Added time dilation options to persona preview scene.
Removed PhAT specific recording functionality (it is in the viewport now).
Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Recreate physics state on edit, not sim start
This allows velocity to be inherited when simulation is started
Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moving viewport to continually-invalidated one like animation editors
Fixed crash in non-extended viewport toolbars
Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Bodies start off non-expanded
Selection now synced between viewport and graph
Constraint selection in graph not works on the first try
Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added missing icon
Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed shape listing from graph nodes
Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Double click on body node recenters graph
Fixed graph disappearing on right-click
Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Prevented cursor getting swallowed in sim mode
Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed overlapping text
Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Node layout now takes dimensions into account
Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed crash opening Persona editors
Renamed file
Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Tweaks to profiles menu
Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Profiles can now be edited in their own details panel
Existing customizations folded into the new panel
Tweaks to toolbar
Added the ability for the persona details panel to have extra top/bottom content added
Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Add profile control to context menus
Also delete old unused code
Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Toolbar trimmed down & re-ordered
Body/constraint ops moved to context menus
Apply physmat now a context-menu option with an asset picker
Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed extra warning dialog when auto-creating bodies
Changed title of new asset dialog to "auto-create bodies"
Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix "simulate selected"
As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor.
Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type
Fixed up selection so body selection works & tree seleciton is properly synced with viewport
Added recursion guard to selection delegate handlers.
Removed vestigial instance property editing support (no longer needed).
Removed unused old tree support code
Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added constraints to tree
Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix bone proxiies stopping updating after initial viewport selection
Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed up selection issues when creating new bodies
Added constraint context menu
Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moved icons to central location
Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Customized filtering of the skeleton tree
Hide constraints by defualt
Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved).
BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool.
Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen
Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303
Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moved physics sim options to viewport menu (so seleciton changing is not required to change them)
Moved physics-related rendering options to show menu
We no longer switch to sim options when nothing is selected.
During simulation we now disable the details panel
Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered)
Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Small fixes based on feedback:
Exposed Mirror tool to menus
Exposed constraint quick actions to menus
Added edit condition to Position & Velocity strength for physical animation
Fixed up some tooltips & display names
Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Defaulted to constraints as points
Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Request from Nick D:
Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes.
Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets.
Slightly increased point-constraint rendering size and added crosshair cursor to constraints
Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead)
Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed duplicate time dilation (can just use viewport menu!)
Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixup post-merge
Prevent crash by attaching to root component in the correct place
Add IWYU include for TArrayView
Remove more unused code
Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix constraint/body selection one final time
Move constraint drawing to SDPG_World (apart from point mode)
Remove depth offset in material
Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Enabling/disabling collision between bodies is now clearer
Menu items are now enabled and disabled correctly depending on collision state
Tooltip reflects what actually gets done when the operation is enacted
Also corrected a few functions that still reference constraint & body mode
Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added enable/disable collision with all
Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Color code graph items based on current profile
Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Color code tree items too
Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Bone selection & manipulation now possible - allows for pose setup before simulation
Item expansion now expands leaf nodes when selecting - helps with constraint selection etc.
Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix compile error
Color code according to simulated/kinematic status
Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
File i missed
Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added physics asset factory so physics assets can be created form the "new asset" menu.
Skeletal mesh is picked then a defualt asset is generated
Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Improve interactions with bones & bodies
Clear bone selection when selecting bodies/constraints
Always hide gizmo in simulate
Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed unused selection lock feature
Fixed selection working incorrectly with details panel closed
Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Selection improvements
Multiselect in tree now only selects non-collapsed tree elements
Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent).
Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen
Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994
Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixup post-merge issues
Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Simulation now works in a simlar way to the level editor
Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown.
Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed selection color of wireframe drawing (this broke ages ago!)
Fixed initialized environment color/intensity
Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently)
Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix crash when simulating selected new bodies
Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time)
Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Select all is now a menu option
Context menu pops when right-clicking nothing now too
Menu no longer grows enormous when multiple types of objects are selected
Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Enlarged constraint rendering size
Show constraints (rather than points) by default
Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Physics Assets now appear in the asset family shortcut bar
Physics Assets now render thumbnails
Skeleton tree can now work in 'picker' mode
Constraints can now be created manually in the graph, tree and viewport
Fixed double-click and mousewheel not working right sometimes
Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed clicks incorrectly selecting bones in simulate mode
Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Physics Asset config is now loaded/saved
Fixed antoher corner case with viewport clicks in sim
Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moved body creation params over to a details panel & settings object
Moved initial creation dialog over to use the new system too
Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Renamed shapes and constraints in the tree view
Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Constraints are now not filtered by default
Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Selecting constraints now shows them (and the bodies involved) in the graph
Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed "Show Kinematic Bodies"
We now always show kinematic status in simulate mode
Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
PhAT rendering settings are now persisted across sessions.
Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available.
Added editable opacity to collision rendering.
Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
New materials with opacity parameter
Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Re-saved materials
Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added ability to only show selected bodies as solid
Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix focus 'F' shortcut sometimes not working
Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix a bunch of selection issues with the graph not keeping in sync
Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen
Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853
Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed disappearing convex meshes on simulate
Also fixes crash in thumbnail rendering
Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Disabled selection on mesh. Fixes selection issues.
Also made the hit proxy use a crosshair when over bodies, for easier selection
Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added body/body collision buttons back to the main toolbar
Fixed solid body drawing using the wrong material when no bodies are selected
Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix delete shortcut not working when tree is focused
Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Integrated per-bone primitive generation with the new tab method
Removed context menu item for bones (fixes duplicate popup)
Fixed undo/redo not working for regenerating all bodies
Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Disabled body regeneration when simulation is running
Fixed up tab icons
Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings)
Animation picker removed from toolbar (we use the preview scene settings for this now)
Fixed profiles tab icon
Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Show attached assets in tree
Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix broken multi-selection of bone proxies
Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed code that prevented parts of the UI (like simulation) from working in PIE
Removed graph overlays & added "PHYSICS" label
Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed arrows from graph
Fixed dragging off constraints/input pins/bodies in constraint-created graphs
Constraint names now include both bodies
Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Switched from colors to icons in the skeleton tree
Removed bold fonts
Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Layout fixes
Added border around generate button in tools panel
Removed skeleton tree header in contexts where it is not needed
Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added slow task dialog for body generation
Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Rearranged context menus to be not so huge
Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Rearranged menus some more
Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Colorized details customization of swing/twist items
Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Auto-open assets when creating from skeletal mesh
Tweaked tooltip on suggestion from Nick D
Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed mirroring changes not showing up straight away
Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moved over to Persona-style floor adjustment
Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Tweaked tooltips for filtering items
Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added "deselect all" option (Esc)
Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Graph selection tweaks
Selected bodies in the viewport/tree are now also selected in the graph.
Selection outline is now matched to the graph outline instead of using default outline.
Pin allocation no longer happens twice
Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Switched simulate shortcut to Alt+Enter
Avoids conflict with clobal PIS/SIE shortcuts
Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Minor body regeneration refactor
Label for tools tab button is dynamic depending on selection context
Generation setttings are now re-used by creation dialog too
Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting
Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Resetting animation to default now correctly applies the animation
Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed up physics asset editor's use of debug skel mesh component
This broke post-merge from Dev-AnimPhys.
Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics).
This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor).
Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moved code to add/remove/assign/unassign profiles to details customization
Also allowed dupication again (via the menu)
Allows correct naming of new profiles as before (as this is handled in PostEdit)
#jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile
#jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor
#jira UE-47384 - New profiles in Physics Asset Editor are all named the same
#jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available
#jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long
#jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save
Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Prevented ctrl+selection of constraints from re-selecting
Avoided defered broadcast of seleciton event from the graph
#jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor
Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed bodies incorrectly simulating outside of 'simulate' mode
Forced all bodies to be non-simulated when simulation is disabled.
Also removed non-functioning motor menu options & disabled more menu options when simulating
#jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor
Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed crash when failing to create a physics asset with multi convex hull
#jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created
Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed typo that disabled editability of profile names incorrectly
#jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save
Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed crash when opening a physics asset with a deleted preview skeletal mesh
Now assigns default mesh as before
If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it.
#jira UE-47918 - Crash when opening certain Physics Assets
Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Prevent "set bodies below" from improperly enabling simulation on bodies
#jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor
Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Physics assets with simulated bodies no longer simulate when first opened
#jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened
Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix excessive gravity crash when actors pop out of the world
Also restrict gravity to non NaN-causing levels.
#jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor
Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen
Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581
Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix merge issues
Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed delegate for skeleton tree context menu extension, now uses an empty section
Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added comments to bone proxy & physics asset editor shared data
Removed unused variables
Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed constraint 'all positions' rendering
Removed empty override of unregister tab spawners
Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix crash when setting skeletal mesh
Toast is not displayed when the skeleton is changed as well as the skeletal mesh.
Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor
#jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying
Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Physics asset selection color now uses editor settings
Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed unused functions
Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Commented SetBodiesBelowPhysicsType as per code review
Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Disabled physical material menu in simulate
Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed unused code
Commented a few functions
Re-instated preview mesh selection
Removed delegate allowing viewport client class creation
Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Remove unused code
Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen
Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965
Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixup merge errors
Change 3596227 by Jonathan.Poncelet
Fixed physics substepping interpolation using the wrong starting value.
#jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16
Change 3596241 by Jonathan.Poncelet
Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately.
#jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin
Change 3596247 by Thomas.Sarkanen
Fixup CIS errors post PhAT Upgrade merge
Change 3596250 by Thomas.Sarkanen
More CIS fixes
Change 3596255 by Benn.Gallagher
Fixed compilation errors when nativizing animation blueprints that use subinstances
#jira UE-46522
Change 3596256 by Benn.Gallagher
Fixed orphaned sub anim instance pins hanging around
#jira UE-46545
Change 3596257 by Benn.Gallagher
Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections.
#jira UE-48045
Change 3596258 by Benn.Gallagher
Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible
#jira UE-47755
Change 3596259 by Benn.Gallagher
Fixed mismatch between paint values and view values for clothing tools
#jira UE-48110
Change 3596260 by Benn.Gallagher
Stopped property context menus killing the whole window stack when an item is clicked
#jira UE-48158
Change 3596261 by Thomas.Sarkanen
One last Mac CIS fix (hopefully)
Change 3596308 by Benn.Gallagher
Removed outdated references to APEX in clothing example map.
Change 3596360 by Martin.Wilson
Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded
#jira UE-48452
Change 3596459 by Benn.Gallagher
Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances.
#jira UE-47567
Change 3596967 by Aaron.McLeran
Adding setting default reverb send level in audio settings.
Change 3596974 by Ethan.Geller
Merge in fix from Christopher Oliver
Change 3597243 by Aaron.McLeran
Checking in missing files.
Change 3597686 by Ethan.Geller
Fix warnings/errors from CL 3597452
Change 3597846 by Ethan.Geller
Fix errors, take 2
Change 3598290 by Ethan.Geller
Panning Angle Issue
Change 3598412 by Ethan.Geller
Change Core.h header to CoreMinimal.h, fix warnings
Change 3599797 by Jurre.deBaare
LODs from Merge Actor tool have bad normals
#jira UE-47129
#fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to:
1) Summing all lightmap pixel counts for each mesh component being merged
2) Calculating fitting texture dimension by taking square root of the total pixels
Change 3599863 by Lina.Halper
PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot)
Change 3599883 by Jurre.deBaare
HLOD: update outliner tooltip when UE docs arrive
#jira UE-20352
Change 3599944 by Martin.Wilson
Smart name refactor
- Remove guids entirely
- Remove automatic fix up
- Simplify smart name mapping container
- Make animations deterministic for cooking
#jira UEAP-264
Change 3600133 by Benn.Gallagher
Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely.
#jira UE-48612
Change 3600166 by Benn.Gallagher
Fixed cloth paint gradient allowing invalid values
#jira UE-48114
Change 3600719 by Lina.Halper
PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus)
Change 3601668 by Jurre.deBaare
Improve BlendSpace preview pin dragging controls
#fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable
#misc Also added tooltips on the grid to make the functionality more discoverable
#jira UE-43011
Change 3601669 by Jurre.deBaare
No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel
#fix I've added the SampleIndex to the names to make it easier recognizing which one is which
#jira UE-46892
Change 3601731 by Benn.Gallagher
Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account.
#jira UE-48329
Change 3601897 by Lina.Halper
fixing issue with sequencer reinitialization
#jira: UE-48556
Change 3602339 by Benn.Gallagher
Fixed comment/tooltip typo
Change 3602502 by Benn.Gallagher
Fixed clothing gradient tool renderer not showing selected points when camera was moving
#jira UE-48331
Change 3602664 by Ethan.Geller
Unshelved fixes from Dev-VR
Change 3602726 by Lina.Halper
Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject
#jira: UE-48700
Change 3603011 by Lina.Halper
Fix build error
Change 3604139 by Benn.Gallagher
Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode.
#jira UE-47960
Change 3604284 by Benn.Gallagher
Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running
#jira UE-48687
Change 3604612 by Lina.Halper
Fix curve issue from automation test
- It was actual bug.
Change 3604614 by Lina.Halper
- Fix crash with macro anim notify
- Make sure macro anim notify doesn't show up in the menu
#jira: UE-45036
Change 3604725 by Lina.Halper
fixed issue with opening state machine from anim graph
#jira: UE-48726
Change 3604971 by Aaron.McLeran
#jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift.
Bringing fix from 4.17 to Dev-AnimPhys
Change 3605787 by Aaron.McLeran
Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls
- This is necessary in order to use the sound concurrency "limit by owner" feature
Change 3606851 by Jurre.deBaare
UE4Editor Static Analysis Win64 - Warning fix
Change 3607022 by Lina.Halper
Fix static analysis warning
Change 3607229 by Jurre.deBaare
RemoveAllCurveData should not allow removing data from the Skeleton
#jira UE-48107
Change 3607660 by Martin.Wilson
Live link client can run in cooked builds too
#jira UEAP-306
Change 3607668 by Ethan.Geller
#jira UE-48792 fix null dereference case in audiodevice.cpp
Change 3607734 by Lina.Halper
LOD linking to curve
- consolidated to one param - curve eval option
- for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :(
- fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap
- flipped meaning to align with bAllowCurveEvaluation
- also fixed issue with orion cooking - where transform curves are added as normal curves
#jira: UE-37996, UE-48782
Change 3607859 by Martin.Wilson
Missed files from live link editor checkin
Change 3607958 by Martin.Wilson
Redo Jurre's changes from CL 3607229 (were removed by CL 3607734)
Change 3608566 by Ethan.Geller
change include to avoid header conflicts on Linux
Change 3609074 by Ethan.Geller
Take 2: Fix capitalization on include, fix Linux build.
Change 3610024 by Lina.Halper
Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene
- we used to load advanced preview setting by persona module
- this has been moved to persona tool kit, and now all other modules are crashing
- If we want to do it for tool kit, we have to make sure all other editor's loading should change also.
#jira: UE-48809
Change 3610081 by Jurre.deBaare
Animations can't be set on blend samples from the dropdown
#fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains
#jira UE-48746
Change 3610088 by Jurre.deBaare
Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace
#fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead
#misc found out of sync widget values due to incorrect encapsulation inside of lambdas
#jira UE-48741
Change 3610862 by Ethan.Geller
Fix submix effects for situations where number of input channels does not equal output channels
Change 3611346 by Aaron.McLeran
Using audio thread platform affinity mask for audio render thread.
Change 3613297 by Ethan.Geller
Simple delay submix
Change 3614435 by Martin.Wilson
CIS fix
Change 3614482 by Martin.Wilson
Store root motion on anim instance instead of proxy to avoid thread safety stalls
#jira UE-46896
Change 3614483 by Martin.Wilson
Evaluate curves in anim offsets
#jira UE-47119
Change 3614495 by Jurre.deBaare
Reimport alembic file with new source option does not automatically tick any tracks
#fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either)
#jira UE-46141
Change 3614645 by Thomas.Sarkanen
Fixed physics assets not simulating when BlockAll was globally overridden
Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT
#jira UE-48591 - Physics assets not simulating correctly in Orion
Change 3614683 by Lina.Halper
Fixed crash when modifying default physicsasset
#jira: UE-48844
Change 3614721 by Jurre.deBaare
Vertex painting on skeletal meshes bound by physics asset
#fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies
#jira UE-48004
Change 3614730 by Thomas.Sarkanen
Fixed crash when regenerating multi convex hulls from zero-vert bones
We handled this in the single convex hull case, but multi did not.
#jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body
Change 3614763 by Jurre.deBaare
Moving over:
HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor
#jira UE-48249
#fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh
Change 3615029 by Lina.Halper
Fix issue with highlight
#jira: UE-48855
Change 3617593 by Thomas.Sarkanen
Fixed crash when regenerating large amounts of bodies
We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems
#jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies
Change 3617609 by Jonathan.Poncelet
Fixed crash that could occur when opening a physics asset and deleting bones.
#jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it
Change 3617723 by Thomas.Sarkanen
Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down
Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting.
Moved AddToRoot pattern used for anim preview scene to FGCObject
#jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794]
#jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed
Change 3617818 by Benn.Gallagher
Final v1 UX changes for clothing tool, and removed experimental flag
Change 3617937 by Jurre.deBaare
Default bounds for Alembic skel-mesh are too large
#fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds
#jira UE-47139
Change 3618187 by Ethan.Geller
Implement Audiomixer in HTML5
Change 3618188 by Lina.Halper
Fix issue with highlight in persona
#jira: UE-49020
Change 3618229 by Lina.Halper
Fix crash on exit when modify is causing it to serialize again in the middle of tear down
#jira: UE-48025
Change 3618248 by Lina.Halper
fix issue by workaround where clamp is not happening with allowspin is false
#jira: UE-47001
Change 3618289 by Aaron.McLeran
Removing audio format types we're not using for simplicity
Change 3618291 by Martin.Wilson
Fix duplicate of curve name appearing in list when renaming
#jira UE-49041
Change 3618390 by Aaron.McLeran
Removing a case for DTYPE_Xenon since this is never used.
Change 3618425 by Martin.Wilson
Keep notify UI up to data across multiple editors when adding notifies to an animation
#jira UE-48104
Change 3619023 by Aaron.McLeran
Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used
Change 3619129 by Aaron.McLeran
Source bus feature.
- New architectural feature for audio mixer that allows audio sources to route to other audio sources.
- Buses can be routed to each other
- Buses have a duration which can be set in bus asset
- Buses can choose between mono and stereo channels
- Sources can send to buses and also toggle to *only* output to buses (and bypass submixing)
- Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc.
- Some engine changes and optimizations:
- Format conversion to float is done in async workers for decode vs the render callback
- Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer)
- Apply master attenuation at the final output vs per-source
- Fixed code that performs fade in/fade out for smooth startup and shutdown.
- Moved FSourceParam to FParam into DSP utility so others can use it.
- Some engine fixes:
- Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc.
- Fixed an issue with pause
- Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties
- Fixed an issue with WorldID not getting set for listeners
TODO:
- fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses
Change 3619159 by Ethan.Geller
#jira UE-48950 fix steam audio crash on editor exit
Change 3619555 by Jonathan.Poncelet
Fixed constraint debug drawing arrows in the physics asset editor being too large.
#jira UE-48863 Limited constraints and free constraints are much larger on screen
Change 3619574 by Thomas.Sarkanen
Fixed debug link for animation blueprints not persisting when changing preview mesh
Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes.
#jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session
Change 3619586 by Thomas.Sarkanen
Fixed physics asset shortcut not working correctly in certain circumstances
FBox was using uninitialized memory
#jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body
Change 3619640 by Thomas.Sarkanen
Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars
Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically).
#jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar
Change 3619644 by James.Golding
Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances)
#jira UE-47652
Change 3619654 by Martin.Wilson
Fix removing a curve when it isn't used on any animations
#jira UE-49048
Change 3619771 by Thomas.Sarkanen
Make sure the physics asset editor floor has collision, regardless of what BlockAll does
#jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config
Change 3619803 by Jonathan.Poncelet
Fixed localization warnings caused by duplicate keys.
#jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings
Change 3619813 by Jurre.deBaare
Baked bones using a pose animation are rotated in the wrong direction
#fix root bone transform wasn't being taken into account while generating final bone transforms
#misc added debug logging for future work
#jira UE-47362
Change 3619830 by Jurre.deBaare
Biased Texture Size option is not functioning when Merging Actors
#fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow
#misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake
#jira UE-48108
Change 3619859 by Thomas.Sarkanen
Fixed HLOD selection sphere persisting on undo/redo
Removed HLOD selection actors when the outliner is refreshed
#jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement.
Change 3619871 by Martin.Wilson
Calculate root motion over the correct segment times, not the track times
#jira UE-43719
Change 3619898 by Thomas.Sarkanen
Improve UI feedback around bounds/in-game bounds in animation editor viewports
Tooltip for in-game bounds is now more detailed
In-game bounds cannot be selected if bounds is not also selected
#jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing
Change 3619908 by Thomas.Sarkanen
Fixed tooltip for PhysicsType
#jira UE-48421 - Incorrect tooltip for Physics Type
Change 3620014 by Jurre.deBaare
Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements
#fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<>
#misc Also added more delegates to ensure the restriction is up to date
#jira UE-46980
Change 3620104 by Jurre.deBaare
HLOD doesn't support renaming in levels
#fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer
#jira UE-48072
Change 3620151 by Thomas.Sarkanen
Undo/redo now correctly affects animation preview scene settings
Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc
#jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI
Change 3620152 by Thomas.Sarkanen
Exposed LOD menu in PhAT
This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior.
#jira UE-47970 - LODs not working in Physics Asset Editor
Change 3620177 by Benn.Gallagher
PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz)
Change 3620250 by Jurre.deBaare
HLOD assets left in HLOD folder when clusters are deleted
#fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed
#jira UE-47450
Change 3620273 by James.Golding
PR #3908: Removing duplicated forward declation (Contributed by celsodantas)
#jira UE-48530
Change 3620274 by James.Golding
PR #3909: Removing unnecessary conditional (Contributed by celsodantas)
#jira UE-48531
Change 3620275 by James.Golding
Add icon for destruction plugin
Change 3620401 by Ethan.Geller
#jira UE-47684 Remove SDL dependencies from Win64
Change 3620586 by Jurre.deBaare
Linux CIS fix
Change 3620660 by Martin.Wilson
Fixes for state machines getting reinitialized in situations that users don't want them to.
-Added option to state machine to allow it to skip reinitialization when it becomes relevant
-Added option to slot nodes to keep source pose relevant while montage slot is playing.
#jira UE-43578
Change 3620665 by Aaron.McLeran
Making source buses only show relevant source bus data.
- hiding sound wave categories that aren't relevant to source buses
Change 3621087 by Ethan.Geller
#jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled.
Change 3621144 by Aaron.McLeran
#jira UE-49147
#jira UE-49145
Fixing concurrency and volume stats
Change 3621148 by Aaron.McLeran
Fixing typo
Change 3621180 by Ethan.Geller
#jira UE-49151 Fix for browser preview on bus only sounds
Change 3621421 by Ethan.Geller
#jira UE-49165 Fix real time audio slider.
Change 3621604 by Ethan.Geller
#jira UE-44847 fix iOS panning algorithm on non-audio mixer
Change 3621626 by Lina.Halper
Fix issue with anim montage displaying when selecting animation
#jira: UE-48749
Change 3621813 by Thomas.Sarkanen
Fixing undo/redo of bone modifications in Physics Asset Editor (and others)
Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique.
Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again)
We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway).
#jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work
Change 3621831 by Jurre.deBaare
Crash fix for Material baking when trying to analyse a MP_MAX material property
#jira UE-49172
Change 3621936 by Thomas.Sarkanen
Fixed CIS error from merge
Change 3621937 by Thomas.Sarkanen
Fix merge issue with API change in USynthComponent
Change 3622173 by Thomas.Sarkanen
Fixed ortho viewports being bright white in sub-editors
Preview scenes in general are responsible by default for the background color.
Advanced preview scenes now use background color from settings. Previously only te animation editors did this.
#jira UE-48841 - The background of the orthographic viewports is bright white
Change 3622730 by Ethan.Geller
#jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran
Change 3622759 by Ethan.Geller
#jira 49170 reduce static analysis warnings for audiodevice.cpp
Change 3622901 by Benn.Gallagher
Bumped PhysX DDC key after change in Orion caused verify failures
Change 3623458 by Aaron.McLeran
#jira UE-49204 Delores monologue cut short in Odin elevator
Change 3623667 by Aaron.McLeran
#jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator
Change 3623752 by Aaron.McLeran
#jira UE-49247 Sound Source Bus Properties Are Inappropriate
Fixing issues with new source bus uobject so properties show up appropriately.
Change 3624058 by Ben.Marsh
Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests.
Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path.
Change 3624193 by Ethan.Geller
#jira UE-49170 Static analysis fix, take 2
Change 3354003 by Thomas.Sarkanen
Back out changelist 3353914
Change 3355932 by Thomas.Sarkanen
Back out changelist 3354003
Reinstating merge from Main:
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839
Change 3477632 by Jurre.deBaare
Automated test content and ground truths for Actor Merging and Material baking functionality
Change 3491464 by Jurre.deBaare
Updated automation content for MergeActor behaviour
Change 3587878 by Thomas.Sarkanen
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489
Change 3597452 by Ethan.Geller
#jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin.
Change 3602935 by Lina.Halper
Allow curve evaluation to be controlled by users
#jira: UE-46446
Change 3606120 by Ethan.Geller
Move Tap Delay Submix to Synthesis library, modify tap delay API
Change 3621830 by Thomas.Sarkanen
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691
Change 3622807 by Ethan.Geller
#jira UE-49201 Fixing volume issues
Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains.
[CL 3624383 by Thomas Sarkanen in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3550452 by Ben.Marsh
UAT: Improve readability of error message when an editor commandlet fails with an error code.
Change 3551179 by Ben.Marsh
Add methods for reading text files into an array of strings.
Change 3551260 by Ben.Marsh
Core: Change FFileHelper routines to use enum classes for flags.
Change 3555697 by Gil.Gribb
Fixed a rare crash when the asset registry scanner found old cooked files with package level compression.
#jira UE-47668
Change 3556464 by Ben.Marsh
UGS: If working in a virtual stream, use the name of the first non-virtual ancestor for writing version files.
Change 3557630 by Ben.Marsh
Allow the network version to be set via Build.version if it's not overriden from Version.h.
Change 3561357 by Gil.Gribb
Fixed crashes related to loading old unversioned files in the editor.
#jira UE-47806
Change 3565711 by Graeme.Thornton
PR #3839: Make non-encoding specific Base64 functions accessible (Contributed by stfx)
Change 3565864 by Robert.Manuszewski
Temp fix for a race condition with the async loading thread enabled - caching the linker in case it gets removed (but not deleted) from super class object.
Change 3569022 by Ben.Marsh
PR #3849: Update gitignore (Contributed by mhutch)
Change 3569113 by Ben.Marsh
Fix Japanese errors not displaying correctly in the cook output log.
#jira UE-47746
Change 3569486 by Ben.Marsh
UGS: Always sync the Enterprise folder if the selected .uproject file has the "Enterprise" flag set.
Change 3570483 by Graeme.Thornton
Minor C# cleanups. Removing some redundant "using" calls which also cause dotnetcore compile errors
Change 3570513 by Robert.Manuszewski
Fix for a race condition with async loading thread enabled.
Change 3570664 by Ben.Marsh
UBT: Use P/Invoke to determine number of physical processors on Windows rather than using WMI. Starting up WMIC adds 2.5 seconds to build times, and is not compatible with .NET core.
Change 3570708 by Robert.Manuszewski
Added ENABLE_GC_OBJECT_CHECKS macro to be able to quickly toggle UObject pointer checks in shipping builds when the garbage collector is running.
Change 3571592 by Ben.Marsh
UBT: Allow running with -installed without creating [InstalledPlatforms] entries in BaseEngine.ini. If there is no HasInstalledPlatformInfo=true setting, assume that all platforms are still available.
Change 3572215 by Graeme.Thornton
UBT
- Remove some unnecessary using directives
- Point SN-DBS code at the new Utils.GetPhysicalProcessorCount call, rather than trying to calculate it itself
Change 3572437 by Robert.Manuszewski
Game-specific fix for lazy object pointer issues in one of the test levels. The previous fix had to be partially reverted due to side-effects.
#jira UE-44996
Change 3572480 by Robert.Manuszewski
MaterialInstanceCollections will no longer be added to GC clusters to prevent materials staying around in memory for too long
Change 3573547 by Ben.Marsh
Add support for displaying log timestamps in local time. Set LogTimes=Local in *Engine.ini, or pass -LocalLogTimes on the command line.
Change 3574562 by Robert.Manuszewski
PR #3847: Add GC callbacks for script integrations (Contributed by mhutch)
Change 3575017 by Ben.Marsh
Move some functions related to generating window resolutions out of Core (FParse::Resolution, GenerateConvenientWindowedResolutions). Also remove a few headers from shared PCHs prior to splitting application functionality out of Core.
Change 3575689 by Ben.Marsh
Add a fixed URL for opening the API documentation, so it works correctly in "internal" and "perforce" builds.
Change 3575934 by Steve.Robb
Fix for nested preprocessor definitions.
Change 3575961 by Steve.Robb
Fix for nested zeros.
Change 3576297 by Robert.Manuszewski
Material resources will now be discarded in PostLoad (Game Thread) instead of in Serialize (potentially Async Loading Thread) so that shader deregistration doesn't assert when done from a different thread than the game thread.
#jira FORT-38977
Change 3576366 by Ben.Marsh
Add shim functions to allow redirecting FPlatformMisc::ClipboardCopy()/ClipboardPaste() to FPlatformApplicationMisc::ClipboardCopy()/ClipboardPaste() while they are deprecated.
Change 3578290 by Graeme.Thornton
Changes to Ionic zip library to allow building on dot net core
Change 3578291 by Graeme.Thornton
Ionic zip library binaries built for .NET Core
Change 3578354 by Graeme.Thornton
Added FBase64::GetDecodedDataSize() to determine the size of bytes of a decoded base64 string
Change 3578674 by Robert.Manuszewski
After loading packages flush linker cache on uncooked platforms to free precache memory
Change 3579068 by Steve.Robb
Fix for CLASS_Intrinsic getting stomped.
Fix to EClassFlags so that they are visible in the debugger.
Re-added mysteriously-removed comments.
Change 3579228 by Steve.Robb
BOM removed.
Change 3579297 by Ben.Marsh
Fix exception if a plugin lists the same module twice.
#jira UE-48232
Change 3579898 by Robert.Manuszewski
When creating GC clusters and asserting due to objects still being pending load, the object name and cluster name will now be logged with the assert.
Change 3579983 by Robert.Manuszewski
More fixes for freeing linker cache memory in the editor.
Change 3580012 by Graeme.Thornton
Remove redundant copy of FileReference.cs
Change 3580408 by Ben.Marsh
Validate that arguments passed to the checkf macro are valid sprintf types, and fix up a few places which are currently incorrect.
Change 3582104 by Graeme.Thornton
Added a dynamic compilation path that uses the latest roslyn apis. Currently only used by the .NET Core path.
Change 3582131 by Graeme.Thornton
#define out some PerformanceCounter calls that don't exist in .NET Core. They're only used by mono-specific calls anyway.
Change 3582645 by Ben.Marsh
PR #3879: fix bug when creating a new VS2017 C++ project (Contributed by mnannola)
#jira UE-48192
Change 3583955 by Robert.Manuszewski
Support for EDL cooked packages in the editor
Change 3584035 by Graeme.Thornton
Split RunExternalExecutable into RunExternaNativelExecutable and RunExternalDotNETExecutable. When running under .NET Core, externally launched DotNET utilities must be launched via the 'dotnet' proxy to work correctly.
Change 3584177 by Robert.Manuszewski
Removed unused member variable (FArchiveAsync2::bKeepRestOfFilePrecached)
Change 3584315 by Ben.Marsh
Move Android JNI accessor functions into separate header, to decouple it from the FAndroidApplication class.
Change 3584370 by Ben.Marsh
Move hooks which allow platforms to load any modules into the FPlatformApplicationMisc classes.
Change 3584498 by Ben.Marsh
Move functions for getting and setting the hardware window pointer onto the appropriate platform window classes.
Change 3585003 by Steve.Robb
Fix for TChunkedArray ranged-for iteration.
#jira UE-48297
Change 3585235 by Ben.Marsh
Remove LogEngine extern from Core; use the platform log channels instead.
Change 3585942 by Ben.Marsh
Move MessageBoxExt() implementation into application layer for platforms that require it.
Change 3587071 by Ben.Marsh
Move Linux's UngrabAllInput() function into a callback, so DebugBreak still works without SDL.
Change 3587161 by Ben.Marsh
Remove headers which will be stripped out of the Core module from Core.h and PlatformIncludes.h.
Change 3587579 by Steve.Robb
Fix for Children list not being rebuilt after hot reload.
Change 3587584 by Graeme.Thornton
Logging improvements for pak signature check failures
- Added "PakCorrupt" console command which corrupts the master signature table
- Added some extra log information about which block failed
- Re-hash the master signature table and to make sure that it hasn't changed since startup
- Moved the ensure around so that some extra logging messages can make it out before the ensure is hit
- Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again
Change 3587586 by Graeme.Thornton
Changes to make UBT build and run on .NET Core
- Added *_DNC csproj files for DotNETUtilities and UnrealBuildTool projects which contain the .NET Core build setups
- VCSharpProjectFile can no be asked for the CsProjectInfo for a particular configuration, which is cached for future use
- After loading VCSharpProjectFiles, .NET Core based projects will be excluded unless generating VSCode projects
Change 3587953 by Steve.Robb
Allow arbitrary UENUM initializers for enumerators.
Editor-only data UENUM support.
Enumerators named MAX are now treated as the UENUM's maximum, and will not cause a MAX+1 value to be generated.
#jira UE-46274
Change 3589827 by Graeme.Thornton
More fixes for VSCode project generation and for UBT running on .NET Core
- Use a different file extension for rules assemblies when build on .NET Core, so they never get used by their counterparts
- UEConsoleTraceListener supports stdout/stderror constructor parameter and outputs to the appropriate channel
- Added documentation for UEConsoleTraceListener
- All platforms .NET project compilation tasks/launch configs now use "dotnet" and not the normal batch files
- Restored the default UBT log verbosity to "Log" rather than "VeryVeryVerbose"
- Renamed assemblies for .NETCore versions of DotNETUtilities and UnrealBuildTool so they don't conflict with the output of the existing .NET Desktop Framework stuff
Change 3589868 by Graeme.Thornton
Separate .NET Core projects for UBT and DotNETCommon out into their own directories so that their intermediates don't overlap with the standard .NET builds, causing failures.
UBT registers ONLY .NET Core C# projects when generating VSCode solutions, and ONLY standard C# projects in all other cases
Change 3589919 by Robert.Manuszewski
Fixing crash when cooking textures that have already been cooked for EDL (support for cooked content in the editor)
Change 3589940 by Graeme.Thornton
Force UBT to think it's running on mono when actually running on .NET Core. Disables a lot of windows specific code paths.
Change 3590078 by Graeme.Thornton
Fully disable automatic assembly info generation in .NET Core projects
Change 3590534 by Robert.Manuszewski
Marking UObject as intrinsic clas to fix a crash on UFE startup.
Change 3591498 by Gil.Gribb
UE4 - Fixed several edge cases in the low level async loading code, especially around cancellation. Also PakFileTest is a console command which can be used to stress test pak file loading.
Change 3591605 by Gil.Gribb
UE4 - Follow up to fixing several edge cases in the low level async loading code.
Change 3592577 by Graeme.Thornton
.NET Core C# projects now reference source files explicitly, to stop it accidentally compiling various intermediates
Change 3592684 by Steve.Robb
Fix for EObjectFlags being passed as the wrong argument to csgCopyBrush.
Change 3592710 by Steve.Robb
Fix for invalid casts in ListProps command.
Some name changes in command output.
Change 3592715 by Ben.Marsh
Move Windows event log code into cpp file, and expose it to other modules even if it's not enabled by default.
Change 3592767 by Gil.Gribb
UE4 - Changed the logic so that engine UObjects boot before anything else. The engine classes are known to be cycle-free, so we will get them done before moving onto game modules.
Change 3592770 by Gil.Gribb
UE4 - Fixed a race condition with async read completion in the prescence of cancels.
Change 3593090 by Steve.Robb
Better error message when there two clashing type names are found.
Change 3593697 by Steve.Robb
VisitTupleElements function, which calls a functor for each element in the tuple.
Change 3595206 by Ben.Marsh
Include additional diagnostics for missing imports when a module load fails.
Change 3596140 by Graeme.Thornton
Batch file for running MSBuild
Change 3596267 by Steve.Robb
Thread safety fix to FPaths::GetProjectFilePath().
Change 3596271 by Robert.Manuszewski
Added code to verify compression flags in package file summary to avoid cases where corrupt packages are crashing the editor
#jira UE-47535
Change 3596283 by Steve.Robb
Redundant casts removed from UHT.
Change 3596303 by Ben.Marsh
EC: Improve parsing of Android Clang errors and warnings, which are formatted as MSVC diagnostics to allow go-to-line clicking in the Output Window.
Change 3596337 by Ben.Marsh
UBT: Format messages about incorrect headers in a way that makes them clickable from Visual Studio.
Change 3596367 by Steve.Robb
Iterator checks in ranged-for on TMap, TSet and TSparseArray.
Change 3596410 by Gil.Gribb
UE4 - Improved some error messages on runtime failures in the EDL.
Change 3596532 by Ben.Marsh
UnrealVS: Fix setting command line to empty not affecting property sheet. Also remove support for VS2013.
#jira UE-48119
Change 3596631 by Steve.Robb
Tool which takes a .map file and a .objmap file (from UBT) and creates a report which shows the size of all the symbols contributed by the source code per-folder.
Change 3596807 by Ben.Marsh
Improve Intellisense when generated headers are missing or out of date (eg. line numbers changed, etc...). These errors seem to be masked by VAX, but are present when using the default Visual Studio Intellisense.
* UCLASS macro is defined to empty when __INTELLISENSE__ is defined. Previous macro was preventing any following class declaration being parsed correctly if generated code was out of date, causing squiggles over all class methods/variables.
* Insert a semicolon after each expanded GENERATED_BODY macro, so that if it parses incorrectly, the compiler can still continue parsing the next declaration.
Change 3596957 by Steve.Robb
UBT can be used to write out an .objsrcmap file for use with the MapFileParser.
Renaming of ObjMap to ObjSrcMap in MapFileParser.
Change 3597213 by Ben.Marsh
Remove AutoReporter. We don't support this any more.
Change 3597558 by Ben.Marsh
UGS: Allow adding custom actions to the context menu for right clicking on a changelist. Actions are specified in the project's UnrealEngine.ini file, with the following syntax:
+ContextMenu=(Label="This is the menu item", Execute="foo.exe", Arguments="bar")
The standard set of variables for custom tools is expanded in each parameter (eg. $(ProjectDir), $(EditorConfig), etc...), plus the $(Change) variable.
Change 3597982 by Ben.Marsh
Add an option to allow overriding the local DDC path from the editor (under Editor Preferences > Global > Local Derived Data Cache).
#jira UE-47173
Change 3598045 by Ben.Marsh
UGS: Add variables for stream and client name, and the ability to escape any variables for URIs using the syntax $(VariableName:URI).
Change 3599214 by Ben.Marsh
Avoid string duplication when comparing extensions.
Change 3600038 by Steve.Robb
Fix for maps being modified during iteration in cache compaction.
Change 3600136 by Steve.Robb
GitHub #3538 : Fixed a bug with the handling of 'TMap' key/value types in the UnrealHeaderTool
Change 3600214 by Steve.Robb
More accurate error message when unsupported template parameters are provided in a TSet property.
Change 3600232 by Ben.Marsh
UBT: Force UHT to run again if the .build.cs file for a module has changed.
#jira UE-46119
Change 3600246 by Steve.Robb
GitHub #3045 : allow multiple interface definition in a file
Change 3600645 by Ben.Marsh
Convert QAGame to Include-What-You-Use.
Change 3600897 by Ben.Marsh
Fix invalid path (multiple slashes) in LibCurl.build.cs. Causes exception when scanning for includes.
Change 3601558 by Graeme.Thornton
Simple first pass VSCode editor integration plugin
Change 3601658 by Graeme.Thornton
Enable intellisense generation for VS Code project files and setup include paths properly
Change 3601762 by Ben.Marsh
UBT: Add support for adaptive non-unity builds when working from a Git repository.
The ISourceFileWorkingSet interface is now used to query files belonging to the working set, and has separate implementations for Perforce (PerforceSourceFileWorkingSet) and Git (GitSourceFileWorkingSet). The Git implementation is used if a .git directory is found in the directory containing the Engine folder, the directory containing the project file, or the parent directory of the project file, and spawns a "git status" process in the background to determine which files are untracked or staged.
Several new settings are supported in BuildConfiguration.xml to allow modifying default behavior:
<SourceFileWorkingSet>
<Provider>Default</Provider> <!-- May be None, Default, Git or Perforce -->
<RepositoryPath></RepositoryPath> <!-- Specifies the path to the repository, relative to the directory containing the Engine folder. If not set, tries to find a .git directory in the locations listed above. -->
<GitPath>git</GitPath> <!-- Specifies the path to the Git executable. Defaults to "git", which assumes that it will be on the PATH -->
</SourceFileWorkingSet>
Change 3604032 by Graeme.Thornton
First attempt at automatically detecting the existance and location of visual studio code in the source code accessor module. Only works for windows.
Change 3604038 by Graeme.Thornton
Added FSourceCodeNavigation::GetSelectedSourceCodeIDE() which returns the name of the selected source code accessor.
Replaced all usages of FSourceCodeNavigation::GetSuggestedSourceCodeIDE() with GetSelectedSourceCodeIDE(), where the message is referring to the opening or editing of code.
Change 3604106 by Steve.Robb
GitHub #3561 : UE-44950: Don't see all caps struct constructor as macro
Change 3604192 by Steve.Robb
GitHub #3911 : Improving ToUpper/ToLower efficiency
Change 3604273 by Graeme.Thornton
IWYU build fixes when malloc profiler is enabled
Change 3605457 by Ben.Marsh
Fix race for intiialization of ThreadID variable on FRunnableThreadWin, and restore a previous check that was working around it.
Change 3606720 by James.Hopkin
Dave Ratti's fix to character base recursion protection code - was missing a GetOwner call, instead attempting to cast a component to a pawn.
Change 3606807 by Graeme.Thornton
Disabled optimizations around FShooterStyle::Create(), which was crashing in Win64 shipping game builds due to some known compiler issue. Same variety of fix as BenZ did in CL 3567741.
Change 3607026 by James.Hopkin
Fixed incorrect ABrush cast - was attempting to cast a UModel to ABrush, which can never succeed
Change 3607142 by Graeme.Thornton
UBT - Minor refactor of BackgroundProcess shutdown in SourceFileWorkingSet. Check whether the process has already exited before trying to kill it during Dispose.
Change 3607146 by Ben.Marsh
UGS: Fix exception due to formatting string when Perforce throws an error.
Change 3607147 by Steve.Robb
Efficiency fix for integer properties, which were causing a property mismatch and thus a tag lookup every time.
Float and double conversion support added to int properties.
NAME_DoubleProperty added.
Fix for converting enum class enumerators > 255 to int properties.
Change 3607516 by Ben.Marsh
PR #3935: Fix DECLARE_DELEGATE_NineParams, DECLARE_MULTICAST_DELEGATE_NineParams. (Contributed by enginevividgames)
Change 3610421 by Ben.Marsh
UAT: Move help for RebuildLightMapsCommand into attributes, so they display when running with -help.
Change 3610657 by Ben.Marsh
UAT: Unify initialization of command environment for build machines and local execution. Always derive parameters which aren't manually set via environment variables.
Change 3611000 by Ben.Marsh
UAT: Remove the -ForceLocal command line option. Settings are now determined automatically, independently of the -Buildmachine argument.
Change 3612471 by Ben.Marsh
UBT: Move FastJSON into DotNETUtilities.
Change 3613479 by Ben.Marsh
UBT: Remove the bIsCodeProject flag from UProjectInfo. This was only really being used to determine which projects to generate an IDE project for, so it is now checked in the project file generator.
Change 3613910 by Ben.Marsh
UBT: Remove unnecessary code to guess a project from the target name; doesn't work due to init order, actual project is determined later.
Change 3614075 by Ben.Marsh
UBT: Remove hacks for testing project file attributes by name.
Change 3614090 by Ben.Marsh
UBT: Remove global lookup of project by name. Projects should be explicitly specified by path when necessary.
Change 3614488 by Ben.Marsh
UBT: Prevent annoying (but handled) exception when constructing SQLiteModuleSupport objects with -precompile enabled.
Change 3614490 by Ben.Marsh
UBT: Simplify generation of arguments for building intellisense; determine the platform/configuration to build from the project file generation code, rather than inside the target itself.
Change 3614962 by Ben.Marsh
UBT: Move the VS2017 strict conformance mode (/permissive-) behind a command line option (-Strict), and disable it by default. Building with this mode is not guaranteed to work correctly without updated Windows headers.
Change 3615416 by Ben.Marsh
EC: Include an icon showing the overall status of a build in the grid view.
Change 3615713 by Ben.Marsh
UBT: Delete any files in output directories which match output files in other directories. Allows automatically deleting build products which are moved into another folder.
#jira UE-48987
Change 3616652 by Ben.Marsh
Plugins: Fix incorrect dialog when binaries for a plugin are missing. Should only prompt to disable if starting a content-only project.
#jira UE-49007
Change 3616680 by Ben.Marsh
Add the CodeAPI-HTML.tgz file into the installed engine build.
Change 3616767 by Ben.Marsh
Plugins: Tweak error message if the FModuleManager::IsUpToDate() function returns false for a plugin module; the module may be missing, not just incompatible.
Change 3616864 by Ben.Marsh
Cap the length of the temporary package name during save, to prevent excessively long filenames going over the limit once a GUID is appended.
#jira UE-48711
Change 3619964 by Ben.Marsh
UnrealVS: Fix single file compile for foreign projects, where the command line contains $(SolutionDir) and $(ProjectName) variables.
Change 3548930 by Ben.Marsh
UBT: Remove UEBuildModuleCSDLL; there is no codepath that still supports creating them. Remove the remaining UEBuildModule/UEBuildModuleCPP abstraction.
Change 3558056 by Ben.Marsh
Deprecate FString::Trim() and FString::TrimTrailing(), and replace them with separate versions to mutate (TrimStartInline(), TrimEndInline()) or return by copy (TrimStart(), TrimEnd()). Also add a functions to trim whitespace from both ends of a string (TrimStartAndEnd(), TrimStartAndEndInline()).
Change 3563309 by Graeme.Thornton
Moved some common C# classes into the DotNETCommon assembly
Change 3570283 by Graeme.Thornton
Move some code out of RPCUtility and into DotNETCommon, removing the dependency between the two projects
Added UEConsoleTraceListener to replace ConsoleTraceListener, which doesn't exist in DotNetCore
Change 3572811 by Ben.Marsh
UBT: Add -enableasan / -enabletsan command line options and bEnableAddressSanitizer / bEnableThreadSanitizer settings in BuildConfiguration.xml (and remove environment variables).
Change 3573397 by Ben.Marsh
UBT: Create a <ExeName>.version file for every target built by UBT, in the same JSON format as Engine/Build/Build.version. This allows monolithic targets to read a version number at runtime, unlike when it's embedded in a modules file, and allows creating versioned client executables that will work with versioned servers when syncing through UGS.
Change 3575659 by Ben.Marsh
Remove CHM API documentation.
Change 3582103 by Graeme.Thornton
Simple ResX writer implemetation that the xbox deloyment code can use instead of the one from the windows forms assembly, which isn't supported on .NET Core
Removed reference to System.Windows.Form from UBT.
Change 3584113 by Ben.Marsh
Move key-mapping functionality into the InputCore module.
Change 3584278 by Ben.Marsh
Move FPlatformMisc::RequestMinimize() into FPlatformApplicationMisc.
Change 3584453 by Ben.Marsh
Move functionality for querying device display density to FApplicationMisc, due to dependence on application-level functionality on mobile platforms.
Change 3585301 by Ben.Marsh
Move PlatformPostInit() into an FPlatformApplicationMisc function.
Change 3587050 by Ben.Marsh
Move IsThisApplicationForeground() into FPlatformApplicationMisc.
Change 3587059 by Ben.Marsh
Move RequiresVirtualKeyboard() into FPlatformApplicationMisc.
Change 3587119 by Ben.Marsh
Move GetAbsoluteLogFilename() into FPlatformMisc.
Change 3587800 by Steve.Robb
Fixes to container visualizers for types whose pointer type isn't simply Type*.
Change 3588393 by Ben.Marsh
Move platform output devices into their own headers.
Change 3588868 by Ben.Marsh
Move creation of console, error and warning output devices int PlatformApplicationMisc.
Change 3589879 by Graeme.Thornton
All automation projects now have a reference to DotNETUtilities
Fixed a build error in the WEX automation library
Change 3590034 by Ben.Marsh
Move functionality related to windowing and input out of the Core module and into an ApplicationCore module, so it is possible to build utilities with Core without adding dependencies on XInput (Windows), SDL (Linux), and OpenGL (Mac).
Change 3593754 by Steve.Robb
Fix for tuple debugger visualization.
Change 3597208 by Ben.Marsh
Move CrashReporter out of a public folder; it's not in a form that is usable by subscribers and licensees.
Change 3600163 by Ben.Marsh
UBT: Simplify how targets are cleaned. Delete all intermediate folders for a platform/configuration, and delete any build products matching the UE4 naming convention for that target, rather than relying on the current build configuration or list of previous build products. This will ensure that build products which are no longer being generated will also be cleaned.
#jira UE-46725
Change 3604279 by Graeme.Thornton
Move pre/post garbage collection delegates into accessor functions so they can be used by globally constructed objects
Change 3606685 by James.Hopkin
Removed redundant 'Cast's (casting to either the same type or a base).
In SClassViewer, replaced cast with TAssetPtr::operator* call to get the wrapped UClass.
Also removed redundant 'IsA's from AnimationRetargetContent::AddRemappedAsset in EditorAnimUtils.cpp.
Change 3610950 by Ben.Marsh
UAT: Simplify logic for detecting Perforce settings, using environment variables if they are set, otherwise falling back to detecting them. Removes special cases for build machines, and makes it simpler to set up UAT commands on builders outside Epic.
Change 3610991 by Ben.Marsh
UAT: Use the correct P4 settings to detect settings if only some parameters are specified on the command line.
Change 3612342 by Ben.Marsh
UBT: Change JsonObject.Read() to take a FileReference parameter.
Change 3612362 by Ben.Marsh
UBT: Remove some more cases of paths being passed as strings rather than using FileReference objects.
Change 3619128 by Ben.Marsh
Include builder warnings and errors in the notification emails for automated tests, otherwise it's difficult to track down non-test failures.
[CL 3620189 by Ben Marsh in Main branch]