When restorin expansion for property customizations, we need to do 2 passes.
Sometimes the first pass can removed the expansion states needed for the second pass.
Collect the saved expansion state once, and use the same data on both expansion passes so that the first pass cannot mess things up.
#rb logan.buchy
[CL 34089316 by mikko mononen in ue5-main branch]
Several updates to Conversation Graph System.
* Add function for getting a corresponding GraphNode from a ConversationNode
* Add CVar for selecting the whole node when a subnode is dropped on it
* Add function to retrieve the Add Requirement menu for a custom menu
* Remove redundant IsUnique check when resetting detail?s panel
[REVIEW] [at]Adam.Rudow, [at]Lane.Engelberg, [at]Bread.Tung, [at]Mark.Pope
[CL 32578501 by tyler hundt in ue5-main branch]
#rnx
[FYI] Tyler.Hundt
Original CL Desc
-----------------------------------------------------------------
Several updates to Conversation Graph System.
* Add function for getting a corresponding GraphNode from a ConversationNode
* Add CVar for selecting the whole node when a subnode is dropped on it
* Add function to retrieve the Add Requirement menu for a custom menu
* Remove redundant IsUnique check when resetting detail?s panel
[REVIEW] [at]Adam.Rudow, [at]Lane.Engelberg, [at]Bread.Tung, [at]Mark.Pope
#rb Jamie.Dale
[CL 32532290 by alex kahn in ue5-main branch]
* Add function for getting a corresponding GraphNode from a ConversationNode
* Add CVar for selecting the whole node when a subnode is dropped on it
* Add function to retrieve the Add Requirement menu for a custom menu
* Remove redundant IsUnique check when resetting detail?s panel
[REVIEW] [at]Adam.Rudow, [at]Lane.Engelberg, [at]Bread.Tung, [at]Mark.Pope
#rb Jamie.Dale
[CL 32530243 by tyler hundt in ue5-main branch]
Also fix an issue where widgets from previously set objects in a details panel were never destructed if details panel was set to have no objects later
#Jira UE-209277
#rb aditya.ravichandran
[CL 32327562 by brooke hubert in ue5-main branch]
This was available within SDetailsViewBase, but the only publicly available function was ForceRefresh which isn't deferred
Using RequestForceRefresh is preferable when the refresh can be deferred, as it can prevent performance problems from refreshing the view multiple times within a single frame
#rb Rex.Hill
[CL 31275746 by jamie dale in ue5-main branch]
~added isEmpty property to details categories for showing stub categories
~styling support to show them properly
#jira UE-195683
#rb ronald.koppers
[CL 28073151 by karen jirak in ue5-main branch]
~ finish up clean up and refactor of details view style. Make sure that all of the numbers are moved to the style file and anything state related stays in the display manager.
#jira UE-194125
#rb brooke.hubert
[CL 27899004 by karen jirak in ue5-main branch]
Problem: With recent changes to the details panel some styling updates caused the scrollbar section to overlap with the reset button when the scrollbar is not showing.
Solution: In SDetailsViewBase.cpp, in the GetScrollbarVisibility method call into DisplayManager.GetIsScrollbarShowing, to tell whether or not we need to show the section which has the scrollbar
#jira UE-195050
#rb brooke.hubert
[CL 27809503 by karen jirak in ue5-main branch]
The categories on the components for core entities now have an action menu. It has many things in it that will log.
#jira UE-194008
#rb Brooke.Hubert
[CL 27717413 by karen jirak in ue5-main branch]
- Fixed padding of default buttons contaier (or else the widget created with CreateDefaultPropertyButtonWidgets() will unintentionally make a row taller)
- Added IDetailsView.ScrollPropertyIntoView(), similar to HighlightProperty() sans does not set highlight
[CL 27407050 by mikko mononen in ue5-main branch]
[FYI] mikko.mononen
Original CL Desc
-----------------------------------------------------------------
Prevent accessing of invalid property nodes after undo and redo.
There's a window after undo (between undo and next property view tick) where property nodes point to the previous data.
If e.g. a property customization needs to refresh cached data after undo, they will try to access the data via old pointers.
Similar issue happens when removing item from array, the tick of IDetailCustomNodeBuilder gets called before we have updates the property nodes.
All these issues happen because when we update the child nodes, there are some parts of code that still hold hard refereces to them, and they are not
actually cleared on FPropertyNode::DestroyTree(). That in turn will cause IPropertyHandle to be in valid state, but pointing to data that has been freed.
- Detach property nodes recursively on FPropertyNode::DestroyTree(), also clearing parent pointers to that the invlidate property path cannot be followed.
- Call update view (same as tick) after undo to invalidate property nodes which do not point to correct memory anymore
- Use FEditorDelegates::PostUndoRedo instead of undo client, as in some rare cases with consequtive undo/redo the undo client callbacks get called on a stale pointer
- Postpone gameplay tag caching to next tick, since the delegates are called in reverse and SDetailsView gets OnUndoRedo gets called after out customization
#jira UE-190882
[CL 27169489 by mikko mononen in ue5-main branch]
There's a window after undo (between undo and next property view tick) where property nodes point to the previous data.
If e.g. a property customization needs to refresh cached data after undo, they will try to access the data via old pointers.
Similar issue happens when removing item from array, the tick of IDetailCustomNodeBuilder gets called before we have updates the property nodes.
All these issues happen because when we update the child nodes, there are some parts of code that still hold hard refereces to them, and they are not
actually cleared on FPropertyNode::DestroyTree(). That in turn will cause IPropertyHandle to be in valid state, but pointing to data that has been freed.
- Detach property nodes recursively on FPropertyNode::DestroyTree(), also clearing parent pointers to that the invlidate property path cannot be followed.
- Call update view (same as tick) after undo to invalidate property nodes which do not point to correct memory anymore
- Use FEditorDelegates::PostUndoRedo instead of undo client, as in some rare cases with consequtive undo/redo the undo client callbacks get called on a stale pointer
- Postpone gameplay tag caching to next tick, since the delegates are called in reverse and SDetailsView gets OnUndoRedo gets called after out customization
#jira UE-190882
[CL 27098189 by mikko mononen in ue5-main branch]
This is a splitter that can dynamically connect matching properties as well as provide buttons for copying values between the two details panels.
#rb ben.hoffmann, dave.jones, karen.jirak
#jira UE-181566
#preflight 64386ecf930b3b84925271d9
[CL 25050248 by jordan hoffmann in ue5-main branch]
This is an improvement on how we diff object details so we can diff in real time and unify several algorithms into one
AsyncTreeDifferences is a generic structure that can diff any tree while AsyncDetailViewDiff is a specialization of that for details panels
Docs: https://docs.google.com/document/d/1rwY-FtTxq2BVptLaMdpKNpzb4hOSn8efm-Z-cF0fBhE/edit?usp=sharing
#rb ben.hoffmann, ben.zeigler, dave.jones
#preflight 6437336e0c4277fc0bdc4d8a
[CL 25027228 by jordan hoffmann in ue5-main branch]
