Commit Graph

1688 Commits

Author SHA1 Message Date
david bromberg
7734765860 Sequencer: Fix Mac/Linux build.
#rb [at]max.chen

[CL 36757229 by david bromberg in 5.5 branch]
2024-10-01 19:27:48 -04:00
david bromberg
1d2787a1e8 Detail Panels- Change FDetailLayoutMap::ShouldShowGroup to respect ShowOnlyInnerProperties meta on structs.
#rb logan.buchy
[FYI] greg.richardson

[CL 36757202 by david bromberg in 5.5 branch]
2024-10-01 19:27:35 -04:00
logan buchy
481f65f87d [Backout] - CL36411617
[FYI] logan.buchy
Original CL Desc
-----------------------------------------------------------------
Make EditConditions work for customized properties

* This change systemically allows customized properties to use the EditConditions UPROPERTY meta specifier.
* This was specifically requested for FGuid as it's details panel representation is implemented as a customization at the engine level

#rb aditya.ravichandran

[CL 36753080 by logan buchy in 5.5 branch]
2024-10-01 18:47:32 -04:00
AdricEpic
5a64c73627 Sequencer: Fix issue caused by my earlier change 36002464 where payload properties on director blueprint conditions would appear twice in the details panel. What was happening was:
1) There is a director blueprint condition property that is part of a condition container struct. The condition container is added as an external structure. Its director blueprint condition property has a customization that adds its payload variable properties.
2) The code in DetailLayoutBuilderImpl copies the properties from the external structure to the parent category. This includes both a) the director blueprint condition property, and b) the payload variables.
3) The newly added director blueprint condition property from #2 that got put in the parent category has its customization run again, and that customization again adds payload variables, meaning we have 2 copies of the payload variables added.

To fix this, in step 2, I check to see if the child nodes have an external root property node. If they do, I do not copy them to the parent category.

[REVIEW] [at]ue-sequencer, [at]juan.portillo
#jira UE-225007
#rb Juan.Portillo

[CL 36750381 by AdricEpic in 5.5 branch]
2024-10-01 18:13:33 -04:00
phillip kavan
fbdd545cfd Fix to ensure that new container items created in the Property Editor get scoped to the correct instance when IDO features are enabled.
#jira UE-224598
#rb Francis.Hurteau

[CL 36748130 by phillip kavan in 5.5 branch]
2024-10-01 17:51:18 -04:00
steve robb
9566ac5def Trivial changes to force an integration to Release-32.00.
#rnx

[CL 36748103 by steve robb in 5.5 branch]
2024-10-01 17:51:05 -04:00
steve robb
28bf104b6a Added cvar to control if non-nullable properties produce an error, a warning or a default object when failing to resolve an object reference.
Default objects will not be created if the class is abstract.

#rb Francis.Hurteau
#jira UE-224118

#tests Ran editor, new unit tests

[CL 36747664 by steve robb in 5.5 branch]
2024-10-01 17:46:30 -04:00
dan oconnor
596ccf43a8 Functions that do not take parameters defined in editor function libraries can once again be invoked from the defaults panel. Clean up short lived TFunction
#rb Dan.Oconnor
#rnx
[FYI] George.Rolfe

[CL 36459984 by dan oconnor in 5.5 branch]
2024-09-19 19:42:05 -04:00
logan buchy
8e912454bd Make EditConditions work for customized properties
* This change systemically allows customized properties to use the EditConditions UPROPERTY meta specifier.
* This was specifically requested for FGuid as it's details panel representation is implemented as a customization at the engine level

#rb aditya.ravichandran

[CL 36455794 by logan buchy in 5.5 branch]
2024-09-19 18:18:01 -04:00
dan oconnor
77ff5f66be The Details Panel's "Create New Blueprint" button now works correctly with Soft Class Properties
#rb ben.zeigler
#jira UE-224929
[RN] The Details Panel's Create New Blueprint button now works correctly with Soft Class Properties

[CL 36450509 by dan oconnor in 5.5 branch]
2024-09-19 16:36:13 -04:00
leon huang
00b26f19da Localization:
Fixed a bug with the property matrix and how it handled pasting text into a textbox for text properties. The text correctly gets pasted and imported now.

#rb: Jamie.Dale
#jira: FORT-736831
#test Got the help of UE QA to verify that the problem was no longer occuring in the paste case for text. THe localization caches are now being correctly populated.

[CL 36165775 by leon huang in 5.5 branch]
2024-09-10 19:15:03 -04:00
Ryan Hummer
4af2fd066d Updating Dev-Release-5.5 from Main at CL #36144969
#okforversepublic

[CL 36146571 by Ryan Hummer in Dev-5.5 branch]
2024-09-10 10:26:02 -04:00
ben hoffman
508bf3f35a Unify Struct Detail View header style with Object Detail View's.
#rb logan.buchy

#ushell-cherrypick of 35820357 by kristof.morva1
#jira none

[CL 36038311 by ben hoffman in ue5-main branch]
2024-09-05 09:58:38 -04:00
miro salminen
e5bd3eded3 [SWIN] [MetaSounds] [Editor] Add ability to Audition SoundWaves From Input Literal/Array Literal
A way to add Optional Custom Widget at SPropertyEditorAsset depending on the selected AssetDefinition. Retrieves the Custom widget through GetCustomAssetPickerWidget function that can be overriden in AssetDefinitions.
#rb logan.buchy
#jira UE-200655
#rnx

[CL 36032666 by miro salminen in ue5-main branch]
2024-09-05 03:45:28 -04:00
jordan hoffmann
8e72d4ee7f [Backout] - CL35978510
[FYI] jordan.hoffmann
Original CL Desc
-----------------------------------------------------------------
[BugFix] FPropertyNode::NotifyPostChange wasn't constructing array indices lookup table for chain events

#rb Matt.Kuhlenschmidt
#jira UE-217965

[CL 36019493 by jordan hoffmann in ue5-main branch]
2024-09-04 14:54:40 -04:00
david bromberg
09bb64d0d6 Slate- When using IDetailCategoryBuilder::AddExternalObjects, if sub-categories are disabled (via CollapseCategories meta for example), and if no property row is specifically added for a property, but instead a property customization for that property adds custom rows instead, then these rows do not show up.
This is because when subcategories aren't supported, the code in FDetailLayoutBuilderImpl::GenerateDetailLayout() generates a detail layout and manually tries to copy the property nodes from generated child nodes to the parent category. However, custom rows will not have property nodes, and in this case the parent property that has been customized may not itself add a detail node.

The solution I have here which I'd like reviewed is in the case no PropertyNode is found for a child node, to look to the parent node and if the parent node has a valid property node, then add that instead to the parent category. This will force the same customization to run for the parent category. I considered trying to copy over the widgets from the custom property rows added, but this resulted in disconnected widgets.

I'm pretty sure the case I'm trying to solve for here is rare, and so far I haven't encountered any other property panes that even fall inside the if (!PropertyNode.IsValid()) case, but if there are ways to make this more robust, or if I need to take a different approach, please let me know.

Relevant slack thread: https://epicgames.slack.com/archives/C045H4DFN5P/p1724841764932099

[REVIEW] [at]editor-ui-systems

#rb Juan.Portillo, logan.buchy

[CL 36002471 by david bromberg in ue5-main branch]
2024-09-04 05:43:09 -04:00
jordan hoffmann
e972238922 [BugFix] FPropertyNode::NotifyPostChange wasn't constructing array indices lookup table for chain events
#rb Matt.Kuhlenschmidt
#jira UE-217965

[CL 35978571 by jordan hoffmann in ue5-main branch]
2024-09-03 15:52:12 -04:00
thomas sarkanen
957cd6635b Property Editor: Added support custom reset to default to IDetailPropertyRow/FDetailWidgetRow
Allows details customizations to override the widget on a per-property basis

#rb logan.buchy
[RN] Added support custom reset to default to IDetailPropertyRow/FDetailWidgetRow

[CL 35891405 by thomas sarkanen in ue5-main branch]
2024-08-29 04:23:46 -04:00
kristoffer jonsson
f2bc9ef63d This solves an issue that occurs when a verse object is referenced via an optional property where all the properties of the referenced object would appear in the object property panel twice.
#tests Editor details panel with locally built binaries for UEFN, UEFN PIE and VersePrototypes using a combination of optional creative_devices (code as suggested in FORT-77563) as well as verse objects not based on creative devices, arrays of optionals and single optionals tested. "PreSubmitTest.py --linuxmode skip" run.
#rb jared.cotton

[CL 35857311 by kristoffer jonsson in ue5-main branch]
2024-08-28 04:03:57 -04:00
vritvij kadam
6d041e4408 Added AllowedClasses/DisallowedClasses support for the Instanced Struct Viewer
#rnx
#rb dan.oconnor, kevin.hamilton

[CL 35799711 by vritvij kadam in ue5-main branch]
2024-08-26 11:17:45 -04:00
patrick boutot
eb00555601 Add Expand to IPropertyHandle
#jira UE-221075
#rb logan.buchy
#rnx

[CL 35780588 by patrick boutot in ue5-main branch]
2024-08-23 15:34:45 -04:00
ben hoffman
77e74622ff Property Editor: Add support for StructProvider-driven Detail Views
#rb Jamie.Dale

#ushell-cherrypick of 35770768 by kristof.morva1
#jira none

#rnx

[CL 35771947 by ben hoffman in ue5-main branch]
2024-08-23 11:29:40 -04:00
michael galetzka
68a08c035f Added rich tooltip support for segmented control widget
#rb Stu.McKenna
#rnx

[CL 35755133 by michael galetzka in ue5-main branch]
2024-08-22 16:58:51 -04:00
charles lefebvre
acdd976f5e Fix categories not working with Verse Devices
#rnx
#rb Tom.Noonan

[CL 35741376 by charles lefebvre in ue5-main branch]
2024-08-22 11:11:18 -04:00
david bromberg
1b22221697 SPropertyEditorInline: Fix refresh issue with editing inline/instanced properties.
#rb max.chen
[FYI] jeremie.roy

[CL 35650296 by david bromberg in ue5-main branch]
2024-08-20 04:27:51 -04:00