Commit Graph

162 Commits

Author SHA1 Message Date
andrea botti
6fe358e664 [ContentBrowser] Missing keybind for edit asset in the content browser
#rb brooke.hubert
#jira UE-180883

[CL 34979012 by andrea botti in ue5-main branch]
2024-07-22 07:10:24 -04:00
george rolfe
d7d41b26cd [Content Browser] Style refresh preparation - local CB StyleSet and CVar toggle.
#rb aditya.ravichandran

[CL 34393816 by george rolfe in ue5-main branch]
2024-06-15 01:56:24 -04:00
andrea botti
9c1aa7d20b [ContentBrowser] When CTRL+C on an asset can we copy the Package Path instead of the Class Path
Added 2 new commmands to copy the ObjectPath and the PackageName.
Leaved the CTRL+C keybind mapped to the same behavior as before.
Added new commands to the keybind system so that users can re-bind them.
Cleaned up some hardcoded checks for keys in the OnKeyDown.

#rb aditya.ravichandran, sebastian.arleryd
#jira UE-155995

[CL 33684273 by andrea botti in ue5-main branch]
2024-05-16 08:31:50 -04:00
dave belanger
d5bc7391ec Automatically make an asset public when moving it in another plugin if it's going to be referenced from another plugin after the move (including redirectors)
Don't move an asset if it cannot be made public or if it ends up referencing a private asset that's not being moved or if a dependent asset cannot be moved to a different plugin
Only enabled if AssetTools.EnablePublicAssetFeature cvar is set (which replaces ContentBrowser.PublicAsset.EnablePublicAssetFeature)
#rb Rex.Hill
#rnx

[CL 30595439 by dave belanger in ue5-main branch]
2024-01-12 11:54:15 -05:00
dave belanger
5fb2a47448 Replace IContentBrowserSingleton::CanChangeAssetPublicState by IAssetTools::CanAssetBePublic
#rb scott.nelson
#rnx

[CL 30090129 by dave belanger in ue5-main branch]
2023-12-04 14:13:00 -05:00
julien stjean
a1ca900079 Changed the save asset behavior in the content browser. It will now only save the modified assets and ignore the others.
Added an resave command and menu entry that save all the assets.

#jira UE-198829, UE-160867
#rb Aditya.RaviChandran

[CL 29060875 by julien stjean in ue5-main branch]
2023-10-24 23:32:07 -04:00
julien stjean
c4d862068a Removed an uneeded ensure as it was triggered in an expected scenario.
#jira UE-192941
#rb JeanLuc.Corenthin
#rnx

[CL 27345264 by julien stjean in ue5-main branch]
2023-08-24 12:19:52 -04:00
logan buchy
b8684dd011 Collection workflow telemetry use TelemetryRouter infrastructure
* Use FTelemetryRouter framework to track collection workflow telemetry instead of bespoke delegates on ContentBrowserModule

#jira UE-192081
#rb Robert.Millar

[CL 26892299 by logan buchy in ue5-main branch]
2023-08-07 14:09:50 -04:00
logan buchy
8cb8cff1ba Feedback changes to Collections telemetry
* Moved workflow tracking of collection manipulations up one level to target user interaction only
* Added create/destroy collection workflows
* Remove hand-holding utilities aimed to ease verbosity of telemetry event generation

#rb wes.hunt
#jira UE-155132
#preflight 6463b34f063e77985c259c71

[CL 25492328 by logan buchy in ue5-main branch]
2023-05-16 13:02:13 -04:00
dave belanger
4a1cc43e05 [UEFN] Fix asset right-click loading the asset because of FAssetContextMenu::IsSelectedAssetPublic check
#rb Rex.Hill
[FYI] Scott.Nelson
#preflight skip

[CL 25413519 by dave belanger in ue5-main branch]
2023-05-10 15:14:39 -04:00
jamie dale
d20a9f1159 Hide "Find in Explorer" menu option for cooked content, as there is never a source file available
#rb Rex.Hill
#rnx

[CL 25225496 by jamie dale in ue5-main branch]
2023-04-27 18:49:41 -04:00
stanley hayes
202bb84b0f Stopping an ensure when selecting something in the content browser that no longer exists
#preflight 63f2ee07500c05a624e3d6f2
#rb YiLiang.Siew
#rb Jared.Cotton
#rb Dave.Belanger
#rnx

[CL 24326725 by stanley hayes in ue5-main branch]
2023-02-20 16:45:26 -05:00
aditya ravichandran
db59eb4a2c Content Browser: Improve UX around unsupported assets
#preflight 63e15a201020773a3f0f987e
#rb Lauren.Barnes, Julien.StJean

[CL 24040935 by aditya ravichandran in ue5-main branch]
2023-02-06 18:22:57 -05:00
julien stjean
55a1b3af29 Introducing the unsupported asset item for the content browser.
These are currently used to display the asset that are hidden by a backend class permission system.
They can also be restricted to some path only if desired.
Note: We will do a UX pass for the unsupported items after this is submitted and later we will also add some support for the unsupported asset to the alias data source.

#preflight 63dc23a7175a9839ac4cf474
#rb Jason.Stasik

[CL 24007061 by julien stjean in ue5-main branch]
2023-02-03 22:39:50 -05:00
nick darnell
e85b0cd48c AssetDefinition - This is the seed of a long term replacement of IAssetTypeActions. IAssetTypeActions is woefully inadiquit now. It puts a lot of functionality in one place, which wouldn't be a terrible thing, except for the GetActions, and some of the menu stuff being built into this class. We need to make an effort to not have to load every single asset just to open the context menu you have selected, to-wit, a previous CL made it so that summoning the menu no longer *Had* to load the assets, however several remaining issues remained with the Blueprint Utility Actions, and the fact that we don't "KNOW" if we need to call GetActions for an asset. We could introduce a replacement in the class, but that would just get inherited, causing other issues. So instead the parallel UObject based AssetDefinition now exists. In large part it will probably be very similar to the other one, but several things in it probably need to chnage. For now there is a bridging concept in the form of the AssetDefinitionAssetTypeProxy.
Several amounts of effort went into the newer design of UAssetDefinition to make it easier to change over time, more things are structs now for input and output so additional parameters can be added.

AssetDefinition module is an editor module instead of being a developer module.
AssetDefinition does not include a myraid of things it shouldn't such as the blueprint module and UnrealEd.

#jira UE-165574
#preflight 636c0ec4d0174259cca85e37

[CL 23083536 by nick darnell in ue5-main branch]
2022-11-10 13:13:41 -05:00
bob tellez
635e0d776e [Backout] - CL23068129 and 23069638
[FYI] Nick.Darnell
Original CL Desc
-----------------------------------------------------------------
AssetDefinition - This is the seed of a long term replacement of IAssetTypeActions.  IAssetTypeActions is woefully inadiquit now.  It puts a lot of functionality in one place, which wouldn't be a terrible thing, except for the GetActions, and some of the menu stuff being built into this class.  We need to make an effort to not have to load every single asset just to open the context menu you have selected, to-wit, a previous CL made it so that summoning the menu no longer *Had* to load the assets, however several remaining issues remained with the Blueprint Utility Actions, and the fact that we don't "KNOW" if we need to call GetActions for an asset.  We could introduce a replacement in the class, but that would just get inherited, causing other issues.  So instead the parallel UObject based AssetDefinition now exists.  In large part it will probably be very similar to the other one, but several things in it probably need to chnage.  For now there is a bridging concept in the form of the AssetDefinitionAssetTypeProxy.

Several amounts of effort went into the newer design of UAssetDefinition to make it easier to change over time, more things are structs now for input and output so additional parameters can be added.

AssetDefinition module is an editor module instead of being a developer module.
AssetDefinition does not include a myraid of things it shouldn't such as the blueprint module and UnrealEd.

#jira UE-165574
#preflight 636c0ec4d0174259cca85e37

[CL 23072024 by bob tellez in ue5-main branch]
2022-11-10 01:18:44 -05:00
nick darnell
fd6f4a29b1 AssetDefinition - This is the seed of a long term replacement of IAssetTypeActions. IAssetTypeActions is woefully inadiquit now. It puts a lot of functionality in one place, which wouldn't be a terrible thing, except for the GetActions, and some of the menu stuff being built into this class. We need to make an effort to not have to load every single asset just to open the context menu you have selected, to-wit, a previous CL made it so that summoning the menu no longer *Had* to load the assets, however several remaining issues remained with the Blueprint Utility Actions, and the fact that we don't "KNOW" if we need to call GetActions for an asset. We could introduce a replacement in the class, but that would just get inherited, causing other issues. So instead the parallel UObject based AssetDefinition now exists. In large part it will probably be very similar to the other one, but several things in it probably need to chnage. For now there is a bridging concept in the form of the AssetDefinitionAssetTypeProxy.
Several amounts of effort went into the newer design of UAssetDefinition to make it easier to change over time, more things are structs now for input and output so additional parameters can be added.

AssetDefinition module is an editor module instead of being a developer module.
AssetDefinition does not include a myraid of things it shouldn't such as the blueprint module and UnrealEd.

#jira UE-165574
#preflight 636c0ec4d0174259cca85e37
[REVIEW]

[CL 23072002 by nick darnell in ue5-main branch]
2022-11-10 01:17:07 -05:00
nick darnell
e90951a442 Editor - Blutility - AssetActionUtilities and ActorActionUtilties no longer load on right click in the Content Browser. Their information is now cached in tag data and we don't load them for real until we actually run the menu options. The GetSupportedClass() has been deprecated, there is now an array of classes you can provide in the Class Defaults. We will now exclude blutilities in developer folders that are not yours.
This is part 1 of a larger refactor to try and stop loading content on right click in the content browser.


#jira UE-165574

[CL 22865625 by nick darnell in ue5-main branch]
2022-10-31 12:40:48 -04:00
nick darnell
8b48634e45 Editor - Fixing a Context Menu regression. The old code did not in fact load everything always, there was a carveout for WP levels, to prevent them from loading by using AssetViewUtils::LoadAssetsIfNeeded, which prevented loading those assets in particular. So I've corrected the fallback code to no longer load everything before returning the selected assets they now return the results of AssetViewUtils::LoadAssetsIfNeeded as was previously the case. There are also now overloads for loading assets that take load tags on the context menu context.
[REVIEW] [at]Patrick.Enfedaque

[CL 22810706 by nick darnell in ue5-main branch]
2022-10-27 11:20:49 -04:00
dave belanger
e11f56ceb2 IContentBrowserSingleton delegate to control whether the public/private state can be changed on a given asset
#rb Scott.Nelson
#preflight 635899e4555771b141aab074

[CL 22803463 by dave belanger in ue5-main branch]
2022-10-26 23:17:13 -04:00
nick darnell
954d29b9f5 Editor - Beginning the process to no longer make loading all assets you right click in the content browser. The first step, is setting up the code to have a deprecation flag DEPRECATE_ASSET_TYPE_ACTIONS_NEEDING_LOADED_OBJECTS, this will make it illegal to implement GetActions on all AssetTypeAction implementations. Checked in disabled, enable it locally to begin trying to implement the recommended method detailed in the IAssetTypeActions header. WIP. One of the things this change does is outlaw (regardless of deprecation) the HasActions() function, this function is no longer used at all, and so we may as well remove its implementation, it also works well as a canary in finding other samples and things that need to be upgraded.
#jira UE-165574
[REVIEW] [at]Rex.Hill, [at]Lauren.Barnes
#preflight 63483c43ad0f7e2f20e44910

[CL 22534452 by nick darnell in ue5-main branch]
2022-10-14 16:59:41 -04:00
robert millar
e6857190f2 Updating collection manager interface to use FSoftObjectPath for the paths of assets and objects rather than FName.
#jira UE-161932
#rb julien.stjean
#preflight https://horde.devtools.epicgames.com/job/6324e773f258fccf98de78cf

[CL 22064625 by robert millar in ue5-main branch]
2022-09-16 20:57:34 -04:00
robert millar
5516f8d0d4 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for editor support classes for content browser code.

#jira UE-161932
#rb jason.stasik,jamie.dale
#preflight 631bd2a0d31788ea3ac03570

[CL 21935588 by robert millar in ue5-main branch]
2022-09-10 00:02:37 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
scott nelson
e8f45f5813 AssetPrivatizeModel and Dialogue
#rb Lauren.Barnes, Brooke.Hubert, Julien.StJean
#preflight 6303b55ca45b007ea246007d

[CL 21511558 by scott nelson in ue5-main branch]
2022-08-23 12:52:04 -04:00