Commit Graph

33963 Commits

Author SHA1 Message Date
charles derousiers
9e90b4f326 Fix Substrate versioning issue.
* Register added nodes into EditorOnly expression collection to be saved/displayed correctly
* Fix conversion invalidation when a node is deleted
* Change Substrate version meaning:
  * -1 no conversion has run
  *   0 the conversion fonction has run and no conversion was done. Or the material has been changed/touched since its conversion
  * >=0 the conversion function has run

#rb sebastien.hillaire

[CL 36760583 by charles derousiers in 5.5 branch]
2024-10-01 19:58:10 -04:00
kiaran ritchie
b61026fdf3 Hiding preview scene profiles from viewport menu until custom one is added
#JIRA UE-225561

[CL 36760007 by kiaran ritchie in 5.5 branch]
2024-10-01 19:53:20 -04:00
keith yerex
9958ba49b6 add world filter to rewind debugger
#rb samuele.rigamonti
#jira UE-221830

[CL 36759718 by keith yerex in 5.5 branch]
2024-10-01 19:51:10 -04:00
jonathan bard
48c6d40cac Added the rendered object's name as metadata to the RenderThumbnail CPU trace, in order to quickly diagnose the costliest thumbnail renders
#jira UE-224581

[CL 36759287 by jonathan bard in 5.5 branch]
2024-10-01 19:47:06 -04:00
matt peters
979f9e8100 IncrementalCook: Add ReferencedSet.txt for use when staging from a zen oplog that could include previous-cook entries than were no longer referenced from the most recent cook.
Refactor CookByTheBookFinishedInternal to move all optional writes into the per-platform forloop so we can share data calculated for each platform between ReferencedSet.txt and the AssetRegistry.
Remove the no-longer-used SCOPED_BOOT_TIMING macros; we profile cook times using UE_SCOPED_HIERARCHICAL_COOKTIMER now.
#rnx
#rb Zousar.Shaker

[CL 36759205 by matt peters in 5.5 branch]
2024-10-01 19:46:19 -04:00
jamie dale
bf2592e212 Replaced usage of FInternationalization::ForUseOnlyByLocMacroAndGraphNodeTextLiterals_CreateText with FText::AsLocalizable_Advanced
[FYI] Leon.Huang
#rnx

[CL 36759164 by jamie dale in 5.5 branch]
2024-10-01 19:45:55 -04:00
trystan binkley-jone
8d8aabf113 Added Overscan subcategory in the Camera details customizer where all camera overscan properties are displayed for Camera and Cine Camera.
#jira UE-225193
#rb Alejandro.Arango

[CL 36758983 by trystan binkley-jone in 5.5 branch]
2024-10-01 19:44:18 -04:00
roey borsteinas
366d9e5e15 [Landscape]
Fix lingering hard reference to deleted landscapes being held by landscape info objects.

#rb jonathan.bard

[CL 36758879 by roey borsteinas in 5.5 branch]
2024-10-01 19:43:14 -04:00
florin pascu
241d2d8693 Re-enable VK SM5 preview for D3D
Force SM6 for preview VK SM5, Mac SM5
Enable Lumen Support for Preview VK SM5, Mac SM5
Modifying FeatureLevelSwitch to respect the parent ShaderPlatform FeatureLevel and not the one set by preview in order to have consistent material logic with the Shader Platform we are trying to preview

#rb Jack.Porter, jeannoe.morissette

[CL 36758806 by florin pascu in 5.5 branch]
2024-10-01 19:42:38 -04:00
logan buchy
a1849b2b32 Make EditConditions work for FGuid
#rnx

[CL 36758485 by logan buchy in 5.5 branch]
2024-10-01 19:39:28 -04:00
luke thatcher
bdf2d7d6c7 Improved game thread frame sync to resolve crashes introduced in 36468180 and worked around in 36479070
- Various legacy game thread code assumes the render thread will never be more than one frame behind. The original change in 36468180 switched from syncing the GT with the RT, to syncing the GT with the RHIT. That left the render thread "floating" in the center of the pipeline, and led to cases where resources are deleted too soon.
 - New approach is to always sync with the GT with the N-1 RT frame, so the GT is never too far ahead of the RT. This maintains compatibility with the legacy GT code paths. In addition to the GT->RT sync, we also sync with the RHIT to prevent the engine running ahead, which was the original bug that 36468180 was fixing.
 - "r.GTSyncType" mode 0 now allows for 1 frame of GT->RT overlap, and 2 frames of GT->RHIT overlap.
 - For debugging purposes, "r.GTSyncType" can also be made negative, which increases the number of GT->RHIT overlap frames, e.g. "r.GTSyncType -3" gives 5 frames of GT->RHIT overlap. While this is not overly useful in a shipped title, it can be used to prove the correctness of the rendering pipeline.
 - Merged the FDeferredCleanupInterface / FPendingCleanupObjects processing into the FFrameEndSync code path, plus made FFrameEndSync a static singleton. This allows us to manage the N frames of overlap between the GT and RHIT in a central place, and correctly cleanup deferred resources when the RT fences have passed.

In future, we will need to revisit this as part of the frame pacing initiative. Game thread code should be written to not require render thread fences for correctness / threadsafety.

#jira UE-223692
#rb zach.bethel

[CL 36758377 by luke thatcher in 5.5 branch]
2024-10-01 19:38:37 -04:00
jonathan bard
e2aca77f42 Added perf tags to a couple of functions that get called on tick
#rb roey.borsteinas
#rnx

[CL 36758356 by jonathan bard in 5.5 branch]
2024-10-01 19:38:21 -04:00
sebastien hillaire
3a025c3cbf Substrate - fixed lightmass material generation that got broken recently due to the way we access shading models from materials in legacy shading model node.
#rnx
[FYI] Charles.deRousiers
#tests Add a test for CPU lightmass with Substrate (opaque, unlit, translucent, emissive, legacy and slabs with colored transmittance)

[CL 36758335 by sebastien hillaire in 5.5 branch]
2024-10-01 19:38:08 -04:00
viktor chlumsky
6734964ba7 Slate SDF fonts - Font Face editor preview
[REVIEW] [at]Yohann.DosSantos, [at]Peter.Rockwell, [at]JC.Authier, [at]editor-ui-systems
#tests Tested in editor
#rnx <Release Notes exclude>
#rb Peter.Rockwell, yohann.dossantos

[CL 36757715 by viktor chlumsky in 5.5 branch]
2024-10-01 19:32:15 -04:00
sebastien lussier
19646414e6 OFPA - When performing the "Copy Selected Actor(s) File Path" action, avoid appending a newline at the end of the string
* Allows paths copied like this to be pasted into Perforce directly, in order to expand the Depot or Workspace trees
#rb Dominic.Couture, JeanFrancois.Dube

[CL 36757611 by sebastien lussier in 5.5 branch]
2024-10-01 19:31:26 -04:00
lucas dower
2f2425138e Fix crash with setting bone name in skeletal mesh region bone filter
* Also switch to SComboBox<FName> instead of SComboBox<TSharedPtr<FName>>

#jira UE-217994
#rb Thomas.Sarkanen

[CL 36757409 by lucas dower in 5.5 branch]
2024-10-01 19:29:28 -04:00
lucas dower
d5942c2169 Remove "selected" from bone context menu
#jira UE-168701

[CL 36757391 by lucas dower in 5.5 branch]
2024-10-01 19:29:17 -04:00
sebastien hillaire
204ff7660e Substrate - now marked as beta.
[RN] Substrate is now BETA!
[FYI] Charles.deRousiers, Kevin.Ortegren
#tests none
#rb Charles.deRousiers, Kevin.Ortegren

[CL 36757331 by sebastien hillaire in 5.5 branch]
2024-10-01 19:28:46 -04:00
thomas sarkanen
aac5cc6685 Fix crash in 'call function from anim graph' node BP menu population
Also fix double-entry in the context menu coming from parent/child classes

#jira UE-219402
#rb Jurre.deBaare
[RN] Fix crash in 'call function from anim graph' node BP menu population

[CL 36757252 by thomas sarkanen in 5.5 branch]
2024-10-01 19:28:10 -04:00
dario mazzanti
d225080478 [Reference Viewer] Static Mesh, Material and possibly other assets referencing properties not listed when referenced by Mesh Component in a Blueprint
Adds support for "indirect" references, addressing the missing referencing properties.

There are still cases in which we cannot access properties, or their details. In that case, this CL adds a simple node stating that currently that info cannot be retrieved.

Note: there are plans to address some limitations in 5.6, also targeting the support for specific types, e.g. showing Material Parameters, Functions and Texture Samplers name instead of their "raw" C++ property name.


#jira UE-222011
#rb aditya.ravichandran

[CL 36757234 by dario mazzanti in 5.5 branch]
2024-10-01 19:27:53 -04:00
david bromberg
7734765860 Sequencer: Fix Mac/Linux build.
#rb [at]max.chen

[CL 36757229 by david bromberg in 5.5 branch]
2024-10-01 19:27:48 -04:00
lucas dower
802d981977 Fix copy-pasting shared transition rules not behaving correctly
* This fixes an issue where copy-pasting a shared transition rule will not display the graph in the 'My Blueprint' tab and will result in operations such as Find References not taking into account all graphs.

#jira UE-215302
#rb Thomas.Sarkanen

[CL 36757223 by lucas dower in 5.5 branch]
2024-10-01 19:27:42 -04:00
david bromberg
1d2787a1e8 Detail Panels- Change FDetailLayoutMap::ShouldShowGroup to respect ShowOnlyInnerProperties meta on structs.
#rb logan.buchy
[FYI] greg.richardson

[CL 36757202 by david bromberg in 5.5 branch]
2024-10-01 19:27:35 -04:00
TheLumbee
14bbafdd7f Deprecated USkeletalMeshComponent::SetAnimClass function
Replaced with SetAnimInstanceClass. Fixed up deprecation warnings and places thast were callling both (!)

PR #11100: Deprecatead the 'SetAnimClass' function. Redundant call to 'SetAnimIn?
#jira UE-200548
#rb Nicholas.Frechette
[RN] Deprecated USkeletalMeshComponent::SetAnimClass function

[CL 36757163 by TheLumbee in 5.5 branch]
2024-10-01 19:27:17 -04:00
paul chipchase
53f3128789 Fix a potential shutdown crash in the bulkdata registry.
#rb Matt.Peters
#jira UE-208080
#rnx

- When FBulkDataRegistryImpl::Teardown is run we were cancelling FUpdatePayloadWorker by signalling to them that they should abandon their work, but we did not make sure that all of the jobs completed.
- In most cases this was fine but FUpdatePayloadWorker::DoWork will attempt to load editor bulkdata payloads first, before checking for cancellation and even if we did check first, it would be possible for currently running jobs to be mid loading of the payload when Teardown is run. In either of these scenarios we could potentially end up attempting to access the asset registry which would be cleaned up shortly after Teardown is called and end up asserting.
- To fix this we now check if the work should be abandoned before we start trying to read the bulkdata payload, then record how many jobs are currently reading payloads.
- In ::Teardown we can then check how many jobs are currently reading payloads and wait until that value reaches zero before returning.
- Note that this issue will only really show up on machines with very low worker core limits, when the editor is closed very shortly after loading and the project being loaded has manypackages in older pre 5.0 formats.

[CL 36757097 by paul chipchase in 5.5 branch]
2024-10-01 19:26:46 -04:00