Commit Graph

505 Commits

Author SHA1 Message Date
mattias hornlund
93d29af692 Iris/Networking
- Enabled use of NetTokens/NetTokenStore and NetTokenDataStores outside of Iris to facilitate exporting data from shared serialization paths
- NetTokenStore and NetTokenDataStores are now owned by NetDriver.
- Added support for CustomExport bunches to carry data assoiciated with NetTokenExports

GameplayTags
- GameplayTagNetSerializer now respects settings from GameplayTags.ini
- Implemented placeholder GameplayTagNetTokenDataStore.

GameplayTags are now using NetTokens to export data if running in the new dynamic mode.

#rb jodon.karlik, Ryan.Gerleve

[CL 36380672 by mattias hornlund in 5.5 branch]
2024-09-18 04:10:29 -04:00
ionut matasaru
96a680bbb5 [Insights]
- Changed the log message at end of analysis that displayes number of warnings to be a warning (instead of an error).
  - Replaced usage of uint64_t with uint64.

#jira UE-223953
#rb Sebastian.Thomeczek
#rnx

[CL 36329861 by ionut matasaru in 5.5 branch]
2024-09-17 06:14:40 -04:00
catalin dragoiu
8036a1663e Added the TraceControl window in Insights Session Browser.
Refactored TraceControl widgets to enable them to connect to a specific InstanceId.
Added auto detect selected session functionality to STraceControl.
Removed responsability from TraceController to handle selected session management.
Added InstanceId to the Diagnostics.SessionInfo2 event.

#rb Johan.Berg, ionut.matasaru
#jira UE-222645

[CL 35964645 by catalin dragoiu in ue5-main branch]
2024-09-03 08:23:12 -04:00
ionut matasaru
a5dddc1e4f [Insights] Fixed "pointer was utilized before it was verified against nullptr" warning.
#rnx
#rb Ionut.Matasaru

[CL 35699824 by ionut matasaru in ue5-main branch]
2024-08-21 09:53:45 -04:00
ionut matasaru
4726352360 [Insights] Memory Insights: Automatically removed the "CustomName" parent tag (in order to make the list of tags consistent with one from "LLM Tags" panel).
#rb Catalin.Dragoiu

[CL 35652582 by ionut matasaru in ue5-main branch]
2024-08-20 08:38:51 -04:00
ionut matasaru
fd9aa9579f [Insights] Fixed crash in Memory Insights analysis when analyzing a corrupted trace ("check" detection for an address allocated multiple times).
#rb Ionut.Matasaru

[CL 35652129 by ionut matasaru in ue5-main branch]
2024-08-20 07:47:51 -04:00
martin ridgers
513bd086bf Keep Unreal Insights' swimlane time bounds updated if a trace only has counters.
#ushell-cherrypick of 35588822 by Martin.Ridgers
#rb ionut.matasaru
#rnx

[CL 35622248 by martin ridgers in ue5-main branch]
2024-08-19 06:49:52 -04:00
ionut matasaru
a965841452 [Insights]
- CpuProfilerTraceAnalysis: Improved analysis performance for traces with huge number of timers.
  - CpuProfilerTraceAnalysis: Added "[CpuProfiler] Analysis completed" log message (with analysis stats) when the analysis is completed.
  - CpuProfilerTraceAnalysis: Added warnings when analysis detects timers defined multiple times and for possible incorrect use of FCpuProfilerTrace::OutputEventType().
  - CpuProfilerTraceAnalysis: Clean-up memory when analysis completes.

#rb Catalin.Dragoiu

[CL 35392281 by ionut matasaru in ue5-main branch]
2024-08-08 06:41:50 -04:00
ionut matasaru
bff487ef4d [Insights] TraceServices: Fixed session's main string store to not duplicate strings with same hash. This fixes issue with some of the duplicated CPU timers (CpuProfilerTraceAnalysis).
#rb Catalin.Dragoiu

[CL 35392274 by ionut matasaru in ue5-main branch]
2024-08-08 06:41:45 -04:00
sebastian thomeczek
d09c1bc308 [Insights] Extend Timing Regions API to allow closing regions by ID....
#rb ionut.matasaru

[CL 35249037 by sebastian thomeczek in ue5-main branch]
2024-08-01 12:50:46 -04:00
jack porter
e6b7bafb45 Unreal Insights psym symbol resolver, for iOS
#rb Florin.Pascu, ionut.matasaru

[CL 35210298 by jack porter in ue5-main branch]
2024-07-31 08:11:38 -04:00
steve robb
f40be2d759 Fixed some 'deprecated' FString usage.
#rb james.hopkin

[CL 34603027 by steve robb in ue5-main branch]
2024-06-24 09:25:50 -04:00
steve robb
113b9f7214 Replaced EAutomationTestFlags::ApplicationContextMask with EAutomationTestFlags_ApplicationContextMask.
[CL 34335267 by steve robb in ue5-main branch]
2024-06-13 06:50:46 -04:00
ionut matasaru
a2ab4c7819 [Insights] Changed also IgnoreSymbolsByFunctionName to use FStringView.
#rnx
#rb Ionut.Matasaru

[CL 34031876 by ionut matasaru in ue5-main branch]
2024-05-31 10:11:52 -04:00
sebastian schoner
960ddbb9ea Speed up symbol filtering in Insights
When loading a large symbol file into insights, the time spent filtering becomes very noticable. In total, it takes about 90 to load the symbols for a large binary. Of these 90s, about 72.5s are spent in the regex matcher in FResolvedSymbolFilter::Update. The regexes we are checking for could also be checked for by just scanning for a substring. With this change, the 73s shrink to < 300ms.
#rb ionut.matasaru

[CL 34028729 by sebastian schoner in ue5-main branch]
2024-05-31 05:29:29 -04:00
Sluggernot
abf0d06b7f [Insights] Removed unused variables in NetTraceAnalyzer.cpp (PR #11921).
#jira UE-215700
#rb Ionut.Matasaru
[FYI] Mattias.Hornlund

[CL 34013433 by Sluggernot in ue5-main branch]
2024-05-30 17:09:02 -04:00
ionut matasaru
afa802685f [Insights]
- Timing View / Markers track: Made few FString/FStringView optimizations for handling name of log categories.
  - Timing View / Markers track: Optimized FLogProvider::EnumerateMessages to only iterate the log messages in the specified time interval (uses binary search to find start index and stops iteration at first log with time > EndTime). This significantly improves performance of Markers track (Bookmarks / Logs) when there are high number of log messages.

#rb Catalin.Dragoiu

[CL 33859147 by ionut matasaru in ue5-main branch]
2024-05-23 08:44:55 -04:00
ionut matasaru
3e958e3667 [Insights]
- LogView: Added LowerBoundByTime, UpperBoundByTime and BinarySearchClosestByTime in ILogProvider. Added comments to all API in ILogProvider. Also, fixed the API comments in IEditableLogProvider.
  - LogView: Added code to allow search of a log message by time.
  - LogView: Fixed issue where log messages are added in non monotonic increasing order by timestamp.

#jira UE-215367
#rb Catalin.Dragoiu

[CL 33855838 by ionut matasaru in ue5-main branch]
2024-05-23 03:23:32 -04:00
ionut matasaru
03432739ea [Insights]
- TraceServices: Added LowerBoundBy and UpperBoundBy algorithms in TPagedArray (in TraceServices::PagedArrayAlgo:: namespace).
  - TraceServices: Added BinarySearchClosestBy algorithm in TPagedArray. Performs binary search, resulting in position of the first element with projected value closest to Value.

#rb Catalin.Dragoiu
[FYI] Johan.Berg

[CL 33801412 by ionut matasaru in ue5-main branch]
2024-05-21 13:37:45 -04:00
ionut matasaru
ac9731a611 [Insights] Memory Insights:
- Fixed crash when first encountered callstack is an empty callstack with a non-zero id.
  - Added distinction between the default empty callstack (i.e. callstack with id 0; "no recorded callstack") and other empty callstacks (with a valid id > 0, but with zero number of frames). Also changed the display names for empty callstacks to be localizable texts (ex: "No Callstack Recorded", "Empty Callstack").
  - Fixed wrong truncation in case the traced callstack has a larger number of stack frames than supported (max 255 stack frames are supported by analysis).

#rb Catalin.Dragoiu
[FYI] Johan.Berg

[CL 33541336 by ionut matasaru in ue5-main branch]
2024-05-09 05:55:19 -04:00
ionut matasaru
8dcec44678 [Insights] Memory Insights / Symbols Resolver: Updated code for DbgHelp resolver (several issues + updated code to use wchar API).
#rb Johan.Berg

[CL 33482079 by ionut matasaru in ue5-main branch]
2024-05-07 08:55:45 -04:00
ionut matasaru
dce03242b1 [Insights] Memory Insights / Symbols Resolver:
- Fixed concurency issues.
  - Updated log messages re "binary files" and "debug symbol files".
  - Fixed path order for searching symbol files(1. Any new path entered by the user this session; 2. Path of the executable (if available); 3. Paths from UE_INSIGHTS_SYMBOL_PATH; 4. Paths from _NT_SYMBOL_PATH; 5. Paths from the user configuration file).
  - Fixed re-load of a module when user specifies a pdb file. Now it will automatically detect and load the corresponding exe/dll binary file.
  - Fixed the succesfull re-load of a module not triggering the re-load of other modules.

#jira UE-195999, UE-196002
#rb Johan.Berg

[CL 33482057 by ionut matasaru in ue5-main branch]
2024-05-07 08:54:50 -04:00
ionut matasaru
b99ae4fccc [Insights] MemoryInsights: Increased the allowed limit for advancing the marker/timestamp for memory events from 1 minute to 5 minutes. This allows correct processing of memory trace events in cases where app is very slow to start or in cases when app is suspended at a breakpoint.
#jira none
#rb Johan.Berg

[CL 33033357 by ionut matasaru in ue5-main branch]
2024-04-17 08:11:24 -04:00
ionut matasaru
84c5dbe976 [Insights] Memory Insights: Changed error handling for cases where trace contains duplicated LLM memory tag declarations. If declarations are identical, a warning message is emitted. If declarations are different (either different parent tag id or different display name) an error is emitted.
#jira UE-211636
#rb Johan.Berg

[CL 32996136 by ionut matasaru in ue5-main branch]
2024-04-16 06:12:30 -04:00
catalin dragoiu
98d372cb8f [Insights] Fix task table display bugs. Missing values will now be shown with N/A instead of 0.
#jira UE-211854,UE-211852
#rb ionut.matasaru

[CL 32882201 by catalin dragoiu in ue5-main branch]
2024-04-11 06:35:37 -04:00