Commit Graph

24 Commits

Author SHA1 Message Date
geoffrey douglas
c09783b4db CameraCalibration: Add marquee select support to the lens distortion tool to send subregions of the media image to opencv for checkerboard detection
#rb jason.walter, jeremie.roy
#jira UE-225311

[CL 36754591 by geoffrey douglas in 5.5 branch]
2024-10-01 19:00:50 -04:00
geoffrey douglas
c00749b72c CameraCalibration: Add Target Offset parameters to the lens solver to account for errors in tracking props with calibration patterns.
#jira UE-211036
#rb jeremie.roy

[CL 34016712 by geoffrey douglas in ue5-main branch]
2024-05-30 18:42:59 -04:00
geoffrey douglas
4b3eb188a0 OpenCVHelper: Add variants to ProjectPoints() and DrawChessboardCorners() that operate on FVector2D points (in addition to the existing methods that operate on FVector2f).
This is primarily useful in camera calibration to avoid unneccessary copies from double to float.
However, the float variants may still be useful in other contexts, so there is no need to deprecate the other versions at this time.
#rb jason.walter
#rnx

[CL 32855903 by geoffrey douglas in ue5-main branch]
2024-04-10 10:11:37 -04:00
geoffrey douglas
f1ef0a86fb OpenCV: Add check before calling solvePnP that enough points were provided to prevent a crash inside the opencv library.
#jira UE-199421
#rb jeremie.roy

[CL 29289561 by geoffrey douglas in ue5-main branch]
2023-10-31 16:35:14 -04:00
geoffrey douglas
af71f2698b CameraCalibration: Add automated tests for distortion and nodal offset calibration
#jira UE-181335
#rb simon.therriault
#rnx

[CL 27682572 by geoffrey douglas in ue5-main branch]
2023-09-07 14:56:07 -04:00
geoffrey douglas
3a05804496 CameraCalibration: Refactor opencv implementation details out of the camera calibration plugins and into the OpenCV Helper module
#jira UE-193458
#rb jeremie.roy

[CL 27451791 by geoffrey douglas in ue5-main branch]
2023-08-29 12:27:12 -04:00
geoffrey douglas
5c3498167a CameraCalibration: Fix distortion calibration solver to properly output final camera poses
#jira UE-191573
#rb simon.therriault, jeremie.roy

[CL 26887714 by geoffrey douglas in ue5-main branch]
2023-08-07 12:39:37 -04:00
Geoffrey Douglas
7534676ad4 CameraCalibration: Fix the way the calibration tools calculate the clicked mouse position in the simulcam viewport when the camera feed resolution and media resolution are different
#jira UE-171509
#rb simon.therriault, jeremie.roy
#preflight 63ceaabb3a03cb0bbff540cd

[CL 23812793 by Geoffrey Douglas in ue5-main branch]
2023-01-23 10:55:03 -05:00
henrik karlsson
bbc37aa2f5 [Engine/Plugins]
* Another batch iwyu updates to reduce number of includes used in files

#preflight 63c58d742e714f64ade93797
#rb none

[CL 23732856 by henrik karlsson in ue5-main branch]
2023-01-16 17:04:48 -05:00
henrik karlsson
ce587eb612 Added markups for headers that can't be compiled standalone.. this is needed for both Header units and IWYU
#preflight 63789b0c170bc34a93a869e5
#rb none

[CL 23552160 by henrik karlsson in ue5-main branch]
2022-12-21 02:46:50 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
henrik karlsson
5298cc8120 Non-unity/pch compile fixes when building UnrealEditor linux
#rb none
#preflight skipped

[CL 22794114 by henrik karlsson in ue5-main branch]
2022-10-26 17:49:37 -04:00
Geoffrey Douglas
1853c78760 Fix PVS static analysis warnings
#jira UE-144643
#preflight 62278a4f695c94f981a96abb?step=29eb
#rb simon.therriault

[CL 19309303 by Geoffrey Douglas in ue5-main branch]
2022-03-08 15:13:02 -05:00
simon therriault
f8b8399d69 - Adding linux platform for opencv library
#jira UETOOL-4743
#rb geoffrey.douglas, alejandro.arango, brandon.schaefer
#preflight 61f04feafd5285142b203c77

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18726707 in //UE5/Release-5.0/... via CL 18726720 via CL 18726894
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18726910 by simon therriault in ue5-main branch]
2022-01-25 14:54:09 -05:00
simon therriault
0ea46cf1e2 - Updating opencv to 4.5 version
- still Windows platform only

#jira UETOOL-4742
#rb geoffrey.douglas, alejandro.arango, chris.norden
#preflight 61e817fd614a721b0c41c7d0

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18657870 in //UE5/Release-5.0/... via CL 18657890 via CL 18657913
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18657937 by simon therriault in ue5-main branch]
2022-01-19 09:46:08 -05:00
chris norden
75b5374e84 Fixed default initializer for FOpenCVArucoDetectedMarker
#rb none
#jira UE-137630
#preflight 61ba1b266b4beca2cc8b97d0

#ROBOMERGE-AUTHOR: chris.norden
#ROBOMERGE-SOURCE: CL 18467779 in //UE5/Release-5.0/... via CL 18467790
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18467795 by chris norden in ue5-release-engine-test branch]
2021-12-15 11:50:29 -05:00
chris norden
6f7dace8fc Fixed build error that preflight minimal did not catch :(
#rb none

#ROBOMERGE-AUTHOR: chris.norden
#ROBOMERGE-SOURCE: CL 18463245 in //UE5/Release-5.0/... via CL 18463279
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18463310 by chris norden in ue5-release-engine-test branch]
2021-12-14 19:07:48 -05:00
chris norden
1ffda5b1e1 Fixed OpenCVHelper Linux errors
#rb none

#ROBOMERGE-AUTHOR: chris.norden
#ROBOMERGE-SOURCE: CL 18462664 in //UE5/Release-5.0/... via CL 18462693
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18462754 by chris norden in ue5-release-engine-test branch]
2021-12-14 18:52:23 -05:00
chris norden
6e80669a57 OpenCV helper Blueprint Function Library which adds convenience nodes for ArUco marker tracking and chessboard detection
#rb geoffrey.douglas

#ROBOMERGE-AUTHOR: chris.norden
#ROBOMERGE-SOURCE: CL 18461345 in //UE5/Release-5.0/... via CL 18461354
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v898-18417669)

[CL 18461355 by chris norden in ue5-release-engine-test branch]
2021-12-14 18:17:28 -05:00
chris norden
d278e0906a Moved more OpenCV convenience functions into OpenCVHelper
#rb geoffrey.douglas

#ROBOMERGE-AUTHOR: chris.norden
#ROBOMERGE-SOURCE: CL 18460069 in //UE5/Release-5.0/... via CL 18460078
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v898-18417669)

[CL 18460112 by chris norden in ue5-release-engine-test branch]
2021-12-14 16:27:10 -05:00
chris norden
f0b8424cba Moved common parameters from FOpenCVLensDistortionParameters out of the Lens Distortion plugin to the OpenCV plugin so that any other plugin can easily use it
#rb geoffrey.douglas

#ROBOMERGE-AUTHOR: chris.norden
#ROBOMERGE-SOURCE: CL 18457178 in //UE5/Release-5.0/... via CL 18457252
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v898-18417669)

[CL 18457289 by chris norden in ue5-release-engine-test branch]
2021-12-14 14:22:02 -05:00
simon therriault
794aa860ce - Fix static analysis warning about index out of bounds
#rb simon.therriault
#author geoffrey.douglas
#jira none

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18285731 in //UE5/Release-5.0/... via CL 18285778
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18285843 by simon therriault in ue5-release-engine-test branch]
2021-11-24 12:59:36 -05:00
geoffrey douglas
745578cc7b [CameraCalibration] Improve accuracy of nodal offset calibration using an opencv downhill solver to minimize reprojection error for multiple camera views
#jira UE-135752
#preflight 61966f394f23c8713541e7fc
#rb alejandro.arango, simon.therriault

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18269974 in //UE5/Release-5.0/... via CL 18270001
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18270029 by geoffrey douglas in ue5-release-engine-test branch]
2021-11-23 10:10:51 -05:00
simon therriault
258066ca40 - Moving opencv library and helper module into its own plugin. We will be able to add utils in there not necessarily tied to camera calibration
- Updated plugin dependencies
Support is still windows only but intention is to compile the lib for linux and mac before 5.0 release.

#rb alejandro.arango, geoffrey.douglas
#jira UETOOL-4137
#preflight 619ba0c13a721992672abdf9

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18258747 in //UE5/Release-5.0/... via CL 18258759
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18258779 by simon therriault in ue5-release-engine-test branch]
2021-11-22 10:29:15 -05:00