Commit Graph

635 Commits

Author SHA1 Message Date
rob gay
e43f356049 - Add more logging to MetaSound cook indicating page removal
- Fix off-by-one when removing default graph via builder API
- Add missing Super::PostLoad that may be causing config values from getting loaded in MetaSoundSettings

#jira UE-225009
#rb phil.popp
#rnx
#tests local cook
[FYI] sondra.moyls, jon.huller, phil.popp

[CL 36747695 by rob gay in 5.5 branch]
2024-10-01 17:46:57 -04:00
rob gay
78b9dd546c Fix bad merge (Feedback from prior submission)
#rb helen.yang
#rnx

[CL 36410349 by rob gay in 5.5 branch]
2024-09-18 17:05:53 -04:00
rob gay
217f498861 Version document to accommodate potential multiple page input default values being added. This could happen before a bug was fixed in the MetaSoundSettings conform step ensuring no duplicate default page setting existed in the project page settings array (default was moved to a separate member).
#rnx
[FYI] sondra.moyls, jon.huller
#rb phil.popp

[CL 36364994 by rob gay in 5.5 branch]
2024-09-17 19:53:26 -04:00
rob gay
20217cc638 Fix renaming MetaSound inputs/outputs not applying to non-focused graph pages
#rb phil.popp, helen.yang
#jira UE-223839
#rnx
[FYI] jon.huller, sondra.moyls
#p4v-cherrypick 36348041

[CL 36348116 by rob gay in 5.5 branch]
2024-09-17 15:37:28 -04:00
rob gay
c390362d67 Fixes for pin inspector not showing input template node analyzer data
- Move edge style calls to builder from controllers
- Fix leaks where removing an edge did not remove  editor-only edge style
- Conform EditorOnly Data markup in BuilderAPI
- Make FindBuildGraphChecked private now that page work is complete (was public during transition between 5.4 & 5.5)

#jira UE-224299
#rb rob.gay
#rnx
[FYI] sondra.moyls, jon.huller

#p4v-cherrypick 36309245

[CL 36313950 by rob gay in 5.5 branch]
2024-09-16 15:56:55 -04:00
rob gay
e204f6bec0 Trivial: Add display names for subsystems/MetaSound asset types ("Meta Sound" to "MetaSound"). Remove invalid comment about AssetSubsystem being deprecated in entirety (still used for loading/unloading MetaSounds by directory)
#rnx
[FYI] jon.huller, sondra.moyls, helen.yang
#rb rob.gay
#p4v-cherrypick 36200858

[CL 36217146 by rob gay in 5.5 branch]
2024-09-11 20:41:41 -04:00
Ryan Hummer
4af2fd066d Updating Dev-Release-5.5 from Main at CL #36144969
#okforversepublic

[CL 36146571 by Ryan Hummer in Dev-5.5 branch]
2024-09-10 10:26:02 -04:00
helen yang
91c4370a7c Fix issues with MetaSound member metadata (ex. float input range) (changes not being serialized + values not inherited on preset creation)
#jira UE-222950
#jira UE-164990
#rb Rob.Gay

[CL 36024546 by helen yang in ue5-main branch]
2024-09-04 17:35:04 -04:00
mark meijer
71e02fdfc4 Gather text from source, remove LOC_DEFINE_REGION regions which were used to exclude LOCTEXT's from gather.
Resolve duplicate keys(identifiers)

#jira UE-176755
#rb eric.boucher, Leon.Huang, Jamie.Dale

[CL 35995403 by mark meijer in ue5-main branch]
2024-09-03 21:59:17 -04:00
rob gay
47e4e35c82 - Enable default page to not be targetable, allowing for removal at cook
- Add faux platform "editor" (ignores cook settings) and "default" (all platforms without specific target settings) as auditionable for faster workflow/more intuitive behavior
- Implement feedback to distinguish "audition page" (editor only concept) vs "target page" (runtime concept)
- Warn when auditioning  graphs that are not cooked/targeted for an assigned audition platform (as default input values cannot be resolved accordingly) in MetaSound Asset editor
- Add more editor/UX protections around having invalid settings where a platform has no target set

#jira UE-193186, UE-219821
#rb helen.yang
[FYI] sondra.moyls, jon.huller, Seth.Weedin, carlos.egas
#rnx

[CL 35930645 by rob gay in ue5-main branch]
2024-08-30 12:53:13 -04:00
mark meijer
df1cc5402b Gather text from source, resolve macro has an empty source text (.cpp files)
#jira UE-176755
#rb eric.boucher, Leon.Huang, Jamie.Dale

[CL 35914164 by mark meijer in ue5-main branch]
2024-08-30 01:19:51 -04:00
rob gay
97b2aa8d74 Editor support for MetaSound Paged Input Defaults
#jira UE-193186, UE-219821
#rb helen.yang
#rnx
[FYI] Seth.Weedin, sondra.moyls, jon.huller

[CL 35844323 by rob gay in ue5-main branch]
2024-08-27 19:05:41 -04:00
rob gay
f2b5b9810f - Rename feedback from prior MetaSound page cook submission
- Fix for runtime-generated MetaSounds asserting when registering from minor oversight in earlier CL
- Exposition of page editor enablement for subsequent page default CL in review

#rb helen.yang, rob.gay
#tests automated PIE and unit
#jira UE-219821, UE-193186

[CL 35788266 by rob gay in ue5-main branch]
2024-08-23 23:03:23 -04:00
rob gay
845f2318dc Round 2 post backouts w/fix (always provide at least default target page when cooking if no project page settings are supplied):
Update MetaSound cook to strip unsupported MetaSound platform page data
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp, helen.yang
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35787942 by rob gay in ue5-main branch]
2024-08-23 21:59:54 -04:00
rob gay
92cfab856b [Backout] - CL35783574
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Update MetaSound cook to strip unsupported MetaSound platform page data

#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35785849 by rob gay in ue5-main branch]
2024-08-23 19:07:53 -04:00
rob gay
c2412e52b1 [Backout] - CL35784129
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35785813 by rob gay in ue5-main branch]
2024-08-23 19:05:52 -04:00
rob gay
a942539d62 Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35784150 by rob gay in ue5-main branch]
2024-08-23 17:52:57 -04:00
rob gay
4f7ee4c0bb Update MetaSound cook to strip unsupported MetaSound platform page data
#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35783577 by rob gay in ue5-main branch]
2024-08-23 17:27:50 -04:00
rob gay
80923ea941 Trivial - Deprecate and swap class default builder API that returns multiple class defaults (and conform node input API for visibility)
#jira UE-219821
#rb rob.gay
[FYI] sondra.moyls, jon.huller
#rnx

[CL 35731265 by rob gay in ue5-main branch]
2024-08-22 00:18:47 -04:00
rob gay
ffac5746ad - Fix up missing/newly added calls not respecting page IDs in document builder API (input/output vertex swapping, comment nodes, etc.)
#jira UE-193186, UE-219821
#rb helen.yang
#rnx

[CL 35725512 by rob gay in ue5-main branch]
2024-08-21 18:37:59 -04:00
miro salminen
3e99ab1a88 [MetaSound] [Editor] Add 'IsAdvanced' Field to Graph Vertices
#rb helen.yang
#jira UE-187752
#rnx

[CL 35649435 by miro salminen in ue5-main branch]
2024-08-20 03:27:21 -04:00
rob gay
9378559f6b Remove redundant call from bad local merge
#rb rob.gay
#rnx

[CL 35646313 by rob gay in ue5-main branch]
2024-08-19 20:38:03 -04:00
rob gay
890bbdb99e Fix shadow variable compilation errors
#rb rob.gay
#rnx

[CL 35640618 by rob gay in ue5-main branch]
2024-08-19 17:53:38 -04:00
rob gay
c53434a951 - Change "RemoveAll<GraphPages/PageDefaultValues>Pages" to be "Reset", as the default value should always exist and be valid
- Add utility functions to EdGraphBuilder & FrontendDocBuilder to be used for editor updates to accomidate paged input defaults
- General minor controller to docbuilder API clean-up spots
- Misc comment clean-up

#jira UE-219821
#rb helen.yang
#rnx
[FYI] sondra.moyls

[CL 35638678 by rob gay in ue5-main branch]
2024-08-19 17:06:23 -04:00
rob gay
701aa024c3 - Only enable interact input widgets on graph pages that implement the given input's default
- Support breadcrumbing all class input default values
- Reimplement input breadcrumb caching using MetaSoundFrontendDocumentBuilder API

#jira UE-219821
#rnx
#rb helen.yang

[CL 35539861 by rob gay in ue5-main branch]
2024-08-14 13:33:46 -04:00