Commit Graph

77 Commits

Author SHA1 Message Date
rob gay
2660985605 [MetaSounds] Automated test & fix-up for getting class, node, access type, and ctor state of node inputs/outputs
#rb helen.yang
#rnx
#jira UE-194159

[CL 27772157 by rob gay in ue5-main branch]
2023-09-11 17:33:43 -04:00
helen yang
939f35db64 Various minor MetaSound Builder BP function fixups
- Default MajorVersion to 1 for AddNodeByClassName w/ better log
- Set some lesser used pins to AdvancedDisplay
- Clarify Node Handle display name

#rb maxwell.hayes
#jira UE-192617
#jira UE-192628

[CL 27559967 by helen yang in ue5-main branch]
2023-09-01 13:19:23 -04:00
charlie huguenard
5cc793ef53 [Metasound] NodeTestGraphBuilder: Add method for adding a constructor input which has a type that is not directly supported by FLiteral
[CL 27282297 by charlie huguenard in ue5-main branch]
2023-08-22 15:19:25 -04:00
Rob Gay
947c8ae10a Fix comment with unacceptable word
#rb trivial
#jira
#rnx

[CL 26974838 by Rob Gay in ue5-main branch]
2023-08-09 17:40:47 -04:00
rob gay
61cb3544cf - Fix for auditioning the same sound multiple times not respecting live updates on additional calls
- Upgrade Live Node Update automation tests to LiveUpdateMultipleMetaSoundSources for more comprehensive coverage
#rb helen.yang
#jira UE-192099
#rnx
#lockdown julien.marchand

[CL 26971688 by rob gay in ue5-main branch]
2023-08-09 16:45:21 -04:00
rob gay
3568cc0034 - Remove --> RemoveSwap delegates to allow for handlers to not duplicate forwarded messages where applicable
- Refactor remove node handler for transactor to not do swap piecemeal, which was resulting in dropped connections
- Add test for adding/removing nodes while auditioning (excercises add/remove edges by extension)
#rb phil.popp
#rnx
#jira UE-191865

[CL 26890183 by rob gay in ue5-main branch]
2023-08-07 13:38:36 -04:00
rob gay
48e0c4350d - Make Connect... MetaSoundBuilderSubsystem API calls replace edges as needed to parallel editor behavior more
- Update MetaSoundFrontendDocumentBuilder AddEdge... API calls to support both replacement and ignoring invalid requests where applicable
#rb phil.popp
#jira UE-190989

[CL 26661505 by rob gay in ue5-main branch]
2023-07-27 19:43:47 -04:00
rob gay
6f37b5d549 Conform test component initialization in MetaSound Engine Tests & fix false negative error in case where component is built with invalid initial state of built sound.
#rb trivial
#jira UE-190758
#rnx

[CL 26578447 by rob gay in ue5-main branch]
2023-07-25 12:40:57 -04:00
rob gay
0e643ad6e0 Fix-up false negative in MetaSound engine test(s)
#rb trivial
#jira UE-190758 UE-190759
#rnx

[CL 26560113 by rob gay in ue5-main branch]
2023-07-24 20:10:12 -04:00
Rob Gay
267e801aa9 Fix for nametable/MetaSound Search Engine entry leaks due to new class name being generated on every builder build/audition call associated with a given target object
#rb todo
#jira UE-190590
#rnx

[CL 26471782 by Rob Gay in ue5-main branch]
2023-07-19 17:25:21 -04:00
phil popp
c382cf4cfb Fix for disconnecting MetaSound node using builder API does not update output
#jira UE-189292
#rb Rob.Gay

[CL 26446133 by phil popp in ue5-main branch]
2023-07-18 16:24:42 -04:00
Rob Gay
3b5f9c1e39 Add missing forward of early return value causing false negative when attempting to add MetaSound Interface via Builder API
#rb trivial
#jira UE-190478
#fyi sondra.moyls

[CL 26443241 by Rob Gay in ue5-main branch]
2023-07-18 15:24:34 -04:00
charlie huguenard
a2d0fbf215 [Metasound] Set graph inputs to node defaults when using single-node helper.
Also add node tests which were not marked for add.

#rnx

[CL 26410139 by charlie huguenard in ue5-main branch]
2023-07-17 12:45:54 -04:00
rob gay
a0f0ea02ea - Fix for inconsistent delegate implementation for MetaSound input/output removal
- Add tests for matching node/graph inputs & outputs
#rb trivial
#jira UE-189613
#rnx

[CL 26274854 by rob gay in ue5-main branch]
2023-06-27 19:07:35 -04:00
rob gay
4858ab4ec4 Fix ConnectNode<In/Out>sToMatchingGraphInterface<In/Out>puts
- Add tests for connecting & disconnecting nodes that match graph interfaces
- Rename test accordingly
#rnx
#jira UE-186188
#rb helen.yang

[CL 26242483 by rob gay in ue5-main branch]
2023-06-26 15:42:30 -04:00
rob gay
586618a007 - Added test for binding interfaces & fixed following fallout
Major:
- Added missing input MetaSound audio interfaces
- Fixed interface bindings not working with referenced transient, non-asset MetaSounds

Minor:
- Fix builder name not being propagated to transient builders
- Fix not defaulting to success enum when creating patch builder
- Generalized pool of named/registered builders on Builder Subsystem instead of having them per type (to support future types without having to update the subystem for each additional future type.)
#rb helen.yang

[CL 26189673 by rob gay in ue5-main branch]
2023-06-22 14:51:42 -04:00
rob gay
19c88744d9 - Fix-up MetaSound dynamic builder engine tests
- Add missing move of transactor to generator init params

#rb Phil.Popp
#jira UE-181889
#rnx

[CL 26128742 by rob gay in ue5-main branch]
2023-06-20 14:03:55 -04:00
Rob Gay
df490de7a8 Initial work to pipe builder updates to dynamic graph
- Add delegates to respond to builder changes to document
- Add delegate handlers to source builder to forward requests to audition sound if live update enabled
- Misc piping for live updating
#jira UE-186952
#ok forgithub public
#rb phil.popp

[CL 26072389 by Rob Gay in ue5-main branch]
2023-06-16 17:48:20 -04:00
jake burga
7791a8f04a Add ability to define a custom name for connected input/output nodes
cleanup some java-docs

#rb charlie.huguenard
[REVIEW] [at]charlie.huguenard [at]phil.popp [at]buzz.burrowes

[CL 25797498 by jake burga in ue5-main branch]
2023-06-05 13:42:51 -04:00
phil popp
f044d2accf CIS Fix for IsAudioMixerEnabled in metasound engine test
#rb trivial
#preflight skip

[CL 25690543 by phil popp in ue5-main branch]
2023-05-30 17:37:33 -04:00
phil popp
4aeebe19ee Automated MetaSound node tests for rebind.
#jira UE-186627
#rb Maxwell.Hayes
#preflight 64763f004b1ead7c7f2a2ee9

[CL 25688935 by phil popp in ue5-main branch]
2023-05-30 17:07:23 -04:00
jake burga
70f0eedf71 Move Graph builder helper functions to NodeTestGraphBuilder
Fix up some test checks in MetronomeNodeTests
- more comprehensive tests in MetronomedNodeTests
- Test a range of Tempos and Time Signatures

[REVIEW] [at]charlie.huguenard [at]buzz.burrowes [at]phil.popp
#preflight 647619f4d8097b4382d66eba
#rb charlie.huguenard

[CL 25682772 by jake burga in ue5-main branch]
2023-05-30 14:25:18 -04:00
phil popp
dd8874c739 Metasound Rebindable Graph Operator
- Added Metasound::FRebindableGraphOperator
- Modified FOperatorBuilder to build either FGraphOperator or FRebindableGraphOperator
- Various API updates and fix-ups to support aforementioned changes.
#jira UE-184987
#rb Maxwell.Hayes
#preflight 6463ab60317ee2d9d1b37655

[CL 25496057 by phil popp in ue5-main branch]
2023-05-16 16:02:58 -04:00
jason weiler
ad3b95a556 [Metasound] Build fix - missing variable capture in a lambda definition
[FYI] [at]charlie.huguenard
#preflight 64527354d863ba262120c4e0

[CL 25323472 by jason weiler in ue5-main branch]
2023-05-03 15:37:25 -04:00
charlie huguenard
7b12ccaeae [Metasound] Get history of output changes instead of last value
#preflight 64513fbb4d593c0b42b03cc8
#rb phil.popp

[CL 25320519 by charlie huguenard in ue5-main branch]
2023-05-03 13:43:51 -04:00