Commit Graph

579 Commits

Author SHA1 Message Date
rob gay
a2af7ba4af [Backout] - CL33560215
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
Round 2 w/registry validity check
[Backout] - CL33559423
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33551869
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls

[CL 33563652 by rob gay in ue5-main branch]
2024-05-09 19:02:03 -04:00
rob gay
2f7f2bbc77 Round 2 w/registry validity check
[Backout] - CL33559423
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33551869
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls

[CL 33560224 by rob gay in ue5-main branch]
2024-05-09 17:24:19 -04:00
rob gay
1cd6fad836 [Backout] - CL33551869
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls

[CL 33559463 by rob gay in ue5-main branch]
2024-05-09 16:58:48 -04:00
charlie huguenard
628c226a65 [Metasound] Remove tick from UMetaSoundOutputSubsystem, only drain queues when there is new data.
#jira UE-214437
#rb ryan.mangin
#tests automated tests

#virtualized

[CL 33556994 by charlie huguenard in ue5-main branch]
2024-05-09 15:58:51 -04:00
rob gay
6e8102f0f6 Add missing logging spot from prior CL (And fix for last-minute tweak that added missing ref)
#rb rob.gay
#jira UE-212969
#rnx

[CL 33553016 by rob gay in ue5-main branch]
2024-05-09 14:13:09 -04:00
rob gay
fbad3b4fa2 - Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls

[CL 33551886 by rob gay in ue5-main branch]
2024-05-09 13:47:58 -04:00
rob gay
39f8da36df Missing boilerplate
#rnx
#rb rob.gay

[CL 33523934 by rob gay in ue5-main branch]
2024-05-08 15:29:40 -04:00
rob gay
c5b7fe17a3 Implicit constructor issue: round 2
#rb rob.gay
#rnx

[CL 33523610 by rob gay in ue5-main branch]
2024-05-08 15:19:15 -04:00
rob gay
9322393da9 Fix for build error due to implicit key cast
#rb rob.gay
#rnx

[CL 33522609 by rob gay in ue5-main branch]
2024-05-08 14:58:22 -04:00
rob gay
711a973c73 - Move MetaSoundAssetSubsystem& BuilderSubsystem implementations to monolithics that are initialized at MetaSoundEngine module load for safety
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang

#tests EngineTest & AudioQA Automation PIE Packaged Build -game

[CL 33522338 by rob gay in ue5-main branch]
2024-05-08 14:53:53 -04:00
helen yang
e88cefd8c5 Refactor MetaSound Array Random Get Node shared state
- Add input for Shared State Behavior to share state between other array random nodes that are the same node, same node in composition, or same data
- Simplify behavior for reinitializing and updating state
- Add hidden friend GetHashType hash functions to MetaSound types
- Add output for chosen index
- Tooltip updates and debug logging

#jira UE-211778
#jira UE-172282
#rb phil.popp, aaron.mcleran

[CL 33495083 by helen yang in ue5-main branch]
2024-05-07 16:54:01 -04:00
helen yang
0650063b74 Add hidden friend GetHashType hash functions for MetaSound types for Array Random Get node refactor
#jira UE-211778

#rb phil.popp

[CL 33492636 by helen yang in ue5-main branch]
2024-05-07 15:58:09 -04:00
jack porter
3ee785bcce Emit warning for code using the old #include "PerPlatformProperties.h" instead of #include "UObject/PerPlatformProperties.h"
Update all existing references
#jira UE-212076
#rb David.Harvey

[CL 33424549 by jack porter in ue5-main branch]
2024-05-03 09:13:43 -04:00
matthew booth
2133e33fe0 [MetasoundEngine] TAudioBusReaderOperator crash fix - BusProxy.Object was nullptr
[REVIEW] [at]maxwell.hayes
[FYI] phil.popp
#rb phil.popp

[CL 33341104 by matthew booth in ue5-main branch]
2024-04-30 12:12:19 -04:00
maxwell hayes
266cdaa324 [MetaSounds] Fix for AudioBusReaderNode resizing an array to a large value (unsigned overflow)
#rb jimmy.smith
#rnx

[CL 33311643 by maxwell hayes in ue5-main branch]
2024-04-29 15:51:34 -04:00
rob gay
39d0de55b1 Fix for AudioUnitTest build break caused by added Engine & AudioMixer dependencies in MetaSound Frontend
#rb rob.gay
#rnx
[FYI] pete.bliss, phil.popp
#jira UE-213147

[CL 33282525 by rob gay in ue5-main branch]
2024-04-26 18:28:12 -04:00
aaron mcleran
25e7e03cdf Adding StartTime interface as an optional MetaSound Source interface.
StartTime used in BP API and Sequencer will now be forwarded to the MetaSound through this interface. The MetaSound can decide what to do with that information -- i.e. sound design what 'Start Time' means.

#rb Phil.Popp, Rob.Gay, Brian.Chrisman
#jira UE-211683

[CL 33272664 by aaron mcleran in ue5-main branch]
2024-04-26 14:51:16 -04:00
rob gay
e8e0c199a2 Remove dependency on MetaSound engine subsystems of any kind being required to register MetaSounds with frontend
#rb rob.gay
#rnx
[FYI] sondra.moyls, phil.popp, helen.yang

[CL 33199328 by rob gay in ue5-main branch]
2024-04-24 10:36:28 -04:00
steve robb
20e93ad90b Fixed potentially uninitialized variables.
#jira UE-87511

[CL 33146357 by steve robb in ue5-main branch]
2024-04-22 14:54:14 -04:00
pete bliss
bc4a3bdfc5 Fix for pin audio inspector oscilloscope data dropouts.
#jira UE-196333
#rb Rob.Gay

[CL 33136245 by pete bliss in ue5-main branch]
2024-04-22 08:43:37 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
steve robb
2981e439fb Fixed unused and potentially uninitialized FQuats and FVector2Ds.
#jira UE-87511

[CL 33099248 by steve robb in ue5-main branch]
2024-04-19 07:10:09 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
50a661b140 Reverting early return speculative fix for warnings and removing warning for now when attempting to cache MetaSound runtime data to fix sequencer warnings.
#rb rob.gay
[FYI] phil.popp, helen.yang
#jira UE-194159
#rnx

[CL 33089038 by rob gay in ue5-main branch]
2024-04-18 18:24:11 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00