Commit Graph

51 Commits

Author SHA1 Message Date
rob gay
e577c32b05 Fix for BuildToAsset fix-up collision with BuildAndOverwriteMetaSound
#jira UE-224638
#rb helen.yang
#rnx
[FYI] sondra.moyls, jon.huller, Brian.Chrisman

[CL 36759780 by rob gay in 5.5 branch]
2024-10-01 19:51:34 -04:00
rob gay
88bcb4e9c1 Fix MetaSound Build BP call to not take parent object as parameter (Transient asset MetaSounds are now required to be TopLevel in the temp package)
#rb helen.yang
#jira UE-224638
#tests local BP
#rnx
[FYI] Dan.Reynolds, sondra.moyls, jon.huller

[CL 36754855 by rob gay in 5.5 branch]
2024-10-01 19:02:59 -04:00
rob gay
e204f6bec0 Trivial: Add display names for subsystems/MetaSound asset types ("Meta Sound" to "MetaSound"). Remove invalid comment about AssetSubsystem being deprecated in entirety (still used for loading/unloading MetaSounds by directory)
#rnx
[FYI] jon.huller, sondra.moyls, helen.yang
#rb rob.gay
#p4v-cherrypick 36200858

[CL 36217146 by rob gay in 5.5 branch]
2024-09-11 20:41:41 -04:00
rob gay
845f2318dc Round 2 post backouts w/fix (always provide at least default target page when cooking if no project page settings are supplied):
Update MetaSound cook to strip unsupported MetaSound platform page data
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp, helen.yang
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35787942 by rob gay in ue5-main branch]
2024-08-23 21:59:54 -04:00
rob gay
92cfab856b [Backout] - CL35783574
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Update MetaSound cook to strip unsupported MetaSound platform page data

#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35785849 by rob gay in ue5-main branch]
2024-08-23 19:07:53 -04:00
rob gay
4f7ee4c0bb Update MetaSound cook to strip unsupported MetaSound platform page data
#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35783577 by rob gay in ue5-main branch]
2024-08-23 17:27:50 -04:00
rob gay
1878db9c63 Initial checkpoint for runtime graph to support Metasound document pages
- Adds ability for graph generation via target page ID
- Deprecates the requirement of a GraphController to build graph to IGraph

#rb phil.popp
#tests MetaSound automated tests & UnitTests
#rnx
#jira UE-194160

[CL 34731539 by rob gay in ue5-main branch]
2024-06-27 23:26:57 -04:00
AdricEpic
0976464d97 #1 Pages Checkpoint: Update BuilderAPI, associated delegates to support providing Pages
#rb helen.yang, phil.popp
#rnx
#jira UE-194160

[CL 34477958 by AdricEpic in ue5-main branch]
2024-06-18 16:47:21 -04:00
rob gay
69725d945e - Checkpoint for Initial MetaSound Pages document model support
- Fix-ups for MS AssetManager leaking asset names if not registered by moving to MultiMap
- Fix-up for ResetBuilder call passing off initial delegates properly
- Make builders map mutation thread safe when loading assets async
#rnx
#tests -game, AudioQA, Unit Tests, Automated Tests
#rb phil.popp
#jira UE-194160

[CL 33983705 by rob gay in ue5-main branch]
2024-05-29 15:33:29 -04:00
rob gay
711a973c73 - Move MetaSoundAssetSubsystem& BuilderSubsystem implementations to monolithics that are initialized at MetaSoundEngine module load for safety
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang

#tests EngineTest & AudioQA Automation PIE Packaged Build -game

[CL 33522338 by rob gay in ue5-main branch]
2024-05-08 14:53:53 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00
rob gay
524d0f85fe Refactor reroute templating in preparation of new templates coming in subsequent changes (i.e. inputs, maybe more node config templates, etc.)
#rb phil.popp
#jira UE-194159
#tests AudioUnitTests, engine tests, tested adding, removing, and auditioning reroutes

[CL 32104370 by rob gay in ue5-main branch]
2024-03-07 17:53:25 -05:00
rob gay
7dead04def Scaffolding for custom MetaSound comment nodes that serialize to Frontend Document as initial part of making ed graph data transient
#jira UE-194160
#rb helen.yang
#rnx

[CL 31060334 by rob gay in ue5-main branch]
2024-01-31 15:02:39 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
39b3a6f74c [MetaSounds] Report changes to transmitter and runtime input map when live edits are enabled during Builder audition
#rb charlie.huguenard
#rnx
#tests Audio Engine Tests including ConnectInputAfterAuditionAndThenSetParameter, Audio Unit Tests
#jira UE-201185
[FYI] sondra.moyls

[CL 30045928 by rob gay in ue5-main branch]
2023-12-01 12:57:59 -05:00
rob gay
10d3a99970 Add quality, sample rate & block rate override setters to MS builder API
#jira UE-200031
#rnx
#rb jimmy.smith
[FYI] charlie.huguenard, sondra.moyls, buzz.burrowes, matthew.booth

[CL 29574690 by rob gay in ue5-main branch]
2023-11-08 16:53:27 -05:00
rob gay
9ec52c5d42 Only register assets requested from builder if never built or if builder has transactions logged requiring re-registration (CVar disabled, will enable in subsequent change)
#rb phil.popp
#jira UE-198400
[FYI] helen.yang, Maxwell.Hayes, sondra.moyls, charlie.huguenard

[CL 29291747 by rob gay in ue5-main branch]
2023-10-31 17:16:11 -04:00
rob gay
94048f43ca - Make FNodeRegistryKey an actual struct as opposed to a string alias
- Avoids string format/copies/conversions in most cases where its just used as a key
- Deprecate NodeRegistryKey namespace calls
#rb phil.popp
#rb helen.yang

[CL 28727626 by rob gay in ue5-main branch]
2023-10-12 16:37:45 -04:00
phil popp
e631780063 Register metasound graphs asynchronously
#jira UE-185834, FORT-658630
#rb Rob.Gay, Helen.Yang

[CL 28149471 by phil popp in ue5-main branch]
2023-09-22 15:01:07 -04:00
phil popp
b478631318 [Backout] - CL28104009
[FYI] phil.popp
Original CL Desc
-----------------------------------------------------------------
Register metasound graphs asynchronously
#jira UE-185834
#rb Rob.Gay, Helen.Yang

[CL 28111209 by phil popp in ue5-main branch]
2023-09-21 18:24:25 -04:00
phil popp
adbad7a65f Register metasound graphs asynchronously
#jira UE-185834
#rb Rob.Gay, Helen.Yang

[CL 28104164 by phil popp in ue5-main branch]
2023-09-21 16:35:40 -04:00
rob gay
e2a68f998b Fix for crash in tests when MetaSoundBuilderSubsystem is not yet loaded
#rb trivial
#rnx

[CL 27968125 by rob gay in ue5-main branch]
2023-09-18 14:32:59 -04:00
rob gay
008b0741b2 Move MetasoundDocumentBuilders to cache-on-demand
- Invalidate subsystem registerd asset builder cache upon soft deprecated document access id creation
#rb phil.popp
#jira UE-194159
#rnx

[CL 27894768 by rob gay in ue5-main branch]
2023-09-14 16:54:36 -04:00