Commit Graph

525 Commits

Author SHA1 Message Date
rob gay
e577c32b05 Fix for BuildToAsset fix-up collision with BuildAndOverwriteMetaSound
#jira UE-224638
#rb helen.yang
#rnx
[FYI] sondra.moyls, jon.huller, Brian.Chrisman

[CL 36759780 by rob gay in 5.5 branch]
2024-10-01 19:51:34 -04:00
helen yang
552b614cf2 Fix invalid MetaSound validation error after diffing assets
#jira UE-221833
#rb Brian.Chrisman
#rnx

[CL 36759614 by helen yang in 5.5 branch]
2024-10-01 19:50:09 -04:00
rob gay
2d1e039509 Fix inverted logic when building & overriding MetaSound via builder API
#rb rob.gay
#jira UE-224638
#rnx

#p4v-cherrypick 36559207

[CL 36756718 by rob gay in 5.5 branch]
2024-10-01 19:23:42 -04:00
rob gay
9583f012e8 Remove checks for CanTarget in calls leveraged in non-editor builds. (PerPlatform settings are not available at runtime when initialized in an .ini and deserialized as CDOs)
#jira UE-225009
#rb helen.yang, eric.buchholz
[FYI] jon.huller, sondra.moyls, Randolph.Kestner
#rnx
#p4v-cherrypick 36557318

[CL 36756588 by rob gay in 5.5 branch]
2024-10-01 19:22:54 -04:00
rob gay
73be44d870 Fix warning in MetaSound tests
#rb rob.gay
#rnx

#p4v-cherrypick 36547161

[CL 36755433 by rob gay in 5.5 branch]
2024-10-01 19:07:55 -04:00
rob gay
88bcb4e9c1 Fix MetaSound Build BP call to not take parent object as parameter (Transient asset MetaSounds are now required to be TopLevel in the temp package)
#rb helen.yang
#jira UE-224638
#tests local BP
#rnx
[FYI] Dan.Reynolds, sondra.moyls, jon.huller

[CL 36754855 by rob gay in 5.5 branch]
2024-10-01 19:02:59 -04:00
rob gay
e43f356049 - Add more logging to MetaSound cook indicating page removal
- Fix off-by-one when removing default graph via builder API
- Add missing Super::PostLoad that may be causing config values from getting loaded in MetaSoundSettings

#jira UE-225009
#rb phil.popp
#rnx
#tests local cook
[FYI] sondra.moyls, jon.huller, phil.popp

[CL 36747695 by rob gay in 5.5 branch]
2024-10-01 17:46:57 -04:00
Rob Gay
6d8ed49d54 Renaming a MetaSound patch results in duplicates/crashes if MetaSound Editor is Open
#jira UE-225326, UE-225441
#rnx
#rb helen.yang
#fyi sondra.moyls, jon.huller, julien.marchand
#p4v-cherrypick 36654551

[CL 36655590 by Rob Gay in 5.5 branch]
2024-09-26 19:52:04 -04:00
rob gay
bfcdeda6ac Part 1: Fix for default config having two default page values
#rb helen.yang
#rnx

[CL 36314356 by rob gay in 5.5 branch]
2024-09-16 16:06:49 -04:00
Ryan Hummer
4af2fd066d Updating Dev-Release-5.5 from Main at CL #36144969
#okforversepublic

[CL 36146571 by Ryan Hummer in Dev-5.5 branch]
2024-09-10 10:26:02 -04:00
rob gay
47e4e35c82 - Enable default page to not be targetable, allowing for removal at cook
- Add faux platform "editor" (ignores cook settings) and "default" (all platforms without specific target settings) as auditionable for faster workflow/more intuitive behavior
- Implement feedback to distinguish "audition page" (editor only concept) vs "target page" (runtime concept)
- Warn when auditioning  graphs that are not cooked/targeted for an assigned audition platform (as default input values cannot be resolved accordingly) in MetaSound Asset editor
- Add more editor/UX protections around having invalid settings where a platform has no target set

#jira UE-193186, UE-219821
#rb helen.yang
[FYI] sondra.moyls, jon.huller, Seth.Weedin, carlos.egas
#rnx

[CL 35930645 by rob gay in ue5-main branch]
2024-08-30 12:53:13 -04:00
mark meijer
fa81eaa7da Gather text from source, resolve warnings for mismatching LOCTEXT_NAMESPACE; string literals not correctly terminated; and duplicate keys(identifiers)
Resolving conflict on Dev-FN-31 (one file)

#jira UE-176755
#rb eric.boucher, Leon.Huang, Jamie.Dale

[CL 35913609 by mark meijer in ue5-main branch]
2024-08-30 00:39:28 -04:00
rob gay
d43c1fecde - Rename 'Target' to 'Can'Target' for clarity in Page Settings
- Return copy instead of reference of platform target ids to avoid shared access violation when cooking pages
- Add trace info to monitor cook times of page data

#jira UE-193186
#rb rob.gay
#rnx
[FYI] jon.huller, sondra.moyls, helen.yang

[CL 35867678 by rob gay in ue5-main branch]
2024-08-28 10:50:41 -04:00
rob gay
ec1c156c46 - Don't bind MetaSound editor-only module delegates (including audition selector) when running cook commandlet
- Add lock around page resolve scratch array when resolving page IDs to protect against async registration resource contention
- Remove cruft set construction

#jira UE-194160, UE-219821, UE-193186
#rb rob.gay
[FYI] helen.yang, phil.popp
#rnx

[CL 35789564 by rob gay in ue5-main branch]
2024-08-24 11:36:20 -04:00
rob gay
a4bfa40fcb Giving a local variable a new name, allowing it to live its best life and removing it from the shadowy darkness
#rb rob.gay
#rnx

[CL 35788342 by rob gay in ue5-main branch]
2024-08-23 23:18:23 -04:00
rob gay
f2b5b9810f - Rename feedback from prior MetaSound page cook submission
- Fix for runtime-generated MetaSounds asserting when registering from minor oversight in earlier CL
- Exposition of page editor enablement for subsequent page default CL in review

#rb helen.yang, rob.gay
#tests automated PIE and unit
#jira UE-219821, UE-193186

[CL 35788266 by rob gay in ue5-main branch]
2024-08-23 23:03:23 -04:00
rob gay
14ca434d3c Re-backout macro comment fix
#rb rob.gay
#rnx

[CL 35788017 by rob gay in ue5-main branch]
2024-08-23 22:12:23 -04:00
rob gay
845f2318dc Round 2 post backouts w/fix (always provide at least default target page when cooking if no project page settings are supplied):
Update MetaSound cook to strip unsupported MetaSound platform page data
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp, helen.yang
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35787942 by rob gay in ue5-main branch]
2024-08-23 21:59:54 -04:00
rob gay
92cfab856b [Backout] - CL35783574
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Update MetaSound cook to strip unsupported MetaSound platform page data

#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35785849 by rob gay in ue5-main branch]
2024-08-23 19:07:53 -04:00
rob gay
c2a97f5df1 [Backout] - CL35783705
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Fix for shadow var

#jira UE-219821
#rb rob.gay
#rnx

[CL 35785830 by rob gay in ue5-main branch]
2024-08-23 19:06:22 -04:00
rob gay
c2412e52b1 [Backout] - CL35784129
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35785813 by rob gay in ue5-main branch]
2024-08-23 19:05:52 -04:00
rob gay
a942539d62 Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35784150 by rob gay in ue5-main branch]
2024-08-23 17:52:57 -04:00
rob gay
1605c8854e Fix for shadow var
#jira UE-219821
#rb rob.gay
#rnx

[CL 35783707 by rob gay in ue5-main branch]
2024-08-23 17:37:49 -04:00
rob gay
4f7ee4c0bb Update MetaSound cook to strip unsupported MetaSound platform page data
#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35783577 by rob gay in ue5-main branch]
2024-08-23 17:27:50 -04:00
rob gay
64374a703c Restrict target page to existing page names and reset if page provided is removed from the array of valid pages (trivial)
#rb rob.gay
#rnx

[CL 35720061 by rob gay in ue5-main branch]
2024-08-21 16:54:41 -04:00