Commit Graph

588 Commits

Author SHA1 Message Date
helen yang
8799954d5c Fix MetaSound editor graph comment issues
- Fix comment box display issues when duplicating MetaSound assets
- Fix node comments not saving when set via right click menu

#jira UE-223837
#jira UE-220612
#rb Rob.Gay
#rnx

[CL 36760345 by helen yang in 5.5 branch]
2024-10-01 19:56:09 -04:00
helen yang
58e8f91c76 Make MetaSound float input default automatic range settings consistent
#jira UE-213337
#rb Rob.Gay
#rnx

[CL 36760044 by helen yang in 5.5 branch]
2024-10-01 19:53:39 -04:00
rob gay
e577c32b05 Fix for BuildToAsset fix-up collision with BuildAndOverwriteMetaSound
#jira UE-224638
#rb helen.yang
#rnx
[FYI] sondra.moyls, jon.huller, Brian.Chrisman

[CL 36759780 by rob gay in 5.5 branch]
2024-10-01 19:51:34 -04:00
helen yang
b55a4379fd Fix crash and errors when building MetaSound presets and renaming referenced MetaSounds
#jira UE-225355
#jira UE-225326
#rb Rob.Gay
#rnx

[CL 36755792 by helen yang in 5.5 branch]
2024-10-01 19:10:44 -04:00
helen yang
52f3b9f966 Fix various intergraph MetaSound member copy paste issues
- Fix not all fields being copied
- Add output node copying between graphs

#jira UE-219694, UE-219585
#rb rob.gay
#rnx

[CL 36755266 by helen yang in 5.5 branch]
2024-10-01 19:06:30 -04:00
rob gay
0d3da9c016 - Fix for ensure when copying and pasting a variable from a different page on the same asset
- Fix for variable names not updating when swapping pages in the members detail panel
- Hide audition options if project has no page settings

#jira UE-223836
#rb brian.chrisman
#rnx
[FYI] jon.huller, sondra.moyls
#p4v-cherrypick 36541088

[CL 36755028 by rob gay in 5.5 branch]
2024-10-01 19:04:38 -04:00
miro salminen
e594839457 [MetaSounds] - Duplicated Inputs have errors on nodes when used in composition
&&
[MetaSounds] - Inputs made using Promote All Inputs have errors on nodes when used in composition

#rb helen.yang
#jira UE-224640, UE-224938
#rnx

[CL 36753927 by miro salminen in 5.5 branch]
2024-10-01 18:55:03 -04:00
rob gay
0432142912 Remove cvar requirement to see MetaSound asset page editor bits
#jira UE-225116
#rb helen.yang
#rnx
[FYI] sondra.moyls, jon.huller, Aaron.McLeran
#p4v-cherrypick 36510642

[CL 36752425 by rob gay in 5.5 branch]
2024-10-01 18:42:32 -04:00
Rob Gay
6d8ed49d54 Renaming a MetaSound patch results in duplicates/crashes if MetaSound Editor is Open
#jira UE-225326, UE-225441
#rnx
#rb helen.yang
#fyi sondra.moyls, jon.huller, julien.marchand
#p4v-cherrypick 36654551

[CL 36655590 by Rob Gay in 5.5 branch]
2024-09-26 19:52:04 -04:00
Rob Gay
6baaeb01da Partial edigrate of:
Fix crash and errors when building MetaSound presets and renaming referenced MetaSounds

#jira UE-225355
#jira UE-225326
#rb Rob.Gay
#rnx

#p4v-cherrypick 36551289

[CL 36589464 by Rob Gay in Dev-5.5 branch]
2024-09-25 16:55:51 -04:00
rob gay
d4a40a92af Trivial: Fix ensure when promoting In value to input from Trigger on Threshold
- Move ensure to warning as implicit cast won't necessarily induce a bug

#jira UE-224637
#rnx
#rb rob.gay
[FYI] sondra.moyls, helen.yang, jon.huller
#p4v-cherrypick 36460708

[CL 36460726 by rob gay in 5.5 branch]
2024-09-19 19:56:05 -04:00
jimmy smith
4a3e162eb3 Fix for crash deleting metasound node
#jira UE-223828
#rb rob.gay
#tests Tested on Mac with repro steps from JIRA and Windows.
[RN] Bug fix for crash in Metasounds from deleteing a node

[CL 36457117 by jimmy smith in 5.5 branch]
2024-09-19 18:41:31 -04:00
rob gay
01bcc9e365 Round 2: Backout of backout(s?):
- Uniform color fix-ups for MetaSound analyzers
- Move live MetaSound stats/audition settings to top left of graph
- Fix ordering of playback widget in input details panel to follow same order as page details panel

#rnx
[FYI] helen.yang, jon.huller, sondra.moyls, aaron.mcleran
#rb Brian.Chrisman
#jira UE-224143

[CL 36453576 by rob gay in 5.5 branch]
2024-09-19 17:46:22 -04:00
rob gay
56c2da2798 Fix for wrong node registry key ctor used when migrating package
#rnx
[FYI] jon.huller, helen.yang
#jira UE-224935
#rb rob.gay
#p4v-cherrypick 36453129

[CL 36453262 by rob gay in 5.5 branch]
2024-09-19 17:42:16 -04:00
helen yang
505c55ce5e Fix details panel issues with MetaSound member metadata (ex. float range/clamp) in outputs/variables + presets
- Don't show or apply range on outputs/variables unless Clamp Default is selected
- Fix inconsistencies with Clamp Default and Range displays in presets

#jira UE-164990
#rb Rob.Gay
#rnx

[CL 36450233 by helen yang in 5.5 branch]
2024-09-19 16:31:42 -04:00
bob tellez
7087aff68b [Backout] - CL36443855
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
- Uniform color fix-ups for MetaSound analyzers
- Move live MetaSound stats/audition settings to top left of graph
- Fix ordering of playback widget in input details panel to follow same order as page details panel

#rnx
[FYI] helen.yang, jon.huller, sondra.moyls, aaron.mcleran
#rb Brian.Chrisman
#jira UE-224143
#p4v-cherrypick 36442802

[CL 36445599 by bob tellez in 5.5 branch]
2024-09-19 14:50:15 -04:00
rob gay
5b50aefb01 Fix state change issue causing audition stats to not show (missed in last submitted shelved CL)
#rb rob.gay
#rnx

#p4v-cherrypick 36443320

[CL 36444019 by rob gay in 5.5 branch]
2024-09-19 14:15:05 -04:00
rob gay
8bbff501e1 - Uniform color fix-ups for MetaSound analyzers
- Move live MetaSound stats/audition settings to top left of graph
- Fix ordering of playback widget in input details panel to follow same order as page details panel

#rnx
[FYI] helen.yang, jon.huller, sondra.moyls, aaron.mcleran
#rb Brian.Chrisman
#jira UE-224143
#p4v-cherrypick 36442802

[CL 36443893 by rob gay in 5.5 branch]
2024-09-19 14:13:05 -04:00
helen yang
1154f26ef5 Fix MetaSound presets not copying sound wave properties on creation
#jira UE-224893
#rb Rob.Gay
#rnx

[CL 36440483 by helen yang in 5.5 branch]
2024-09-19 13:19:42 -04:00
miro salminen
c1484134dd [MetaSounds] - Editor crashes when promoting all to input on some nodes
#rb helen.yang
#jira UE-224639
#rnx

[CL 36421968 by miro salminen in 5.5 branch]
2024-09-19 01:24:01 -04:00
rob gay
5821dc52aa Remove private dependency from MetaSoundEditor module
#jira UE-193843
#rb rob.gay
#rnx

[CL 36414573 by rob gay in 5.5 branch]
2024-09-18 18:45:41 -04:00
rob gay
a9f5a9f762 Trivial fix to regression where widget options are now visible for MetaSound triggers
#jira UE-224296
#rb rob.gay
#rnx
[FYI] sondra.moyls, jon.huller
#p4v-cherrypick 36355449

[CL 36355900 by rob gay in 5.5 branch]
2024-09-17 17:44:21 -04:00
rob gay
20217cc638 Fix renaming MetaSound inputs/outputs not applying to non-focused graph pages
#rb phil.popp, helen.yang
#jira UE-223839
#rnx
[FYI] jon.huller, sondra.moyls
#p4v-cherrypick 36348041

[CL 36348116 by rob gay in 5.5 branch]
2024-09-17 15:37:28 -04:00
rob gay
c390362d67 Fixes for pin inspector not showing input template node analyzer data
- Move edge style calls to builder from controllers
- Fix leaks where removing an edge did not remove  editor-only edge style
- Conform EditorOnly Data markup in BuilderAPI
- Make FindBuildGraphChecked private now that page work is complete (was public during transition between 5.4 & 5.5)

#jira UE-224299
#rb rob.gay
#rnx
[FYI] sondra.moyls, jon.huller

#p4v-cherrypick 36309245

[CL 36313950 by rob gay in 5.5 branch]
2024-09-16 15:56:55 -04:00
rob gay
f479e3f402 Safeguard against referenced weak member becoming stale when node customization is being rebuilt and attribute lambdas are still being evaluated
#rb rob.gay
#rnx
#tests MetaSoundEditor adding & removing interfaces & members
[FYI] sondra.moyls, jon.huller, helen.yang, Seth.Weedin

#p4v-cherrypick 36284278

[CL 36287296 by rob gay in 5.5 branch]
2024-09-13 19:05:03 -04:00