Commit Graph

1686 Commits

Author SHA1 Message Date
helen yang
8799954d5c Fix MetaSound editor graph comment issues
- Fix comment box display issues when duplicating MetaSound assets
- Fix node comments not saving when set via right click menu

#jira UE-223837
#jira UE-220612
#rb Rob.Gay
#rnx

[CL 36760345 by helen yang in 5.5 branch]
2024-10-01 19:56:09 -04:00
helen yang
58e8f91c76 Make MetaSound float input default automatic range settings consistent
#jira UE-213337
#rb Rob.Gay
#rnx

[CL 36760044 by helen yang in 5.5 branch]
2024-10-01 19:53:39 -04:00
rob gay
e577c32b05 Fix for BuildToAsset fix-up collision with BuildAndOverwriteMetaSound
#jira UE-224638
#rb helen.yang
#rnx
[FYI] sondra.moyls, jon.huller, Brian.Chrisman

[CL 36759780 by rob gay in 5.5 branch]
2024-10-01 19:51:34 -04:00
helen yang
552b614cf2 Fix invalid MetaSound validation error after diffing assets
#jira UE-221833
#rb Brian.Chrisman
#rnx

[CL 36759614 by helen yang in 5.5 branch]
2024-10-01 19:50:09 -04:00
rob gay
2d1e039509 Fix inverted logic when building & overriding MetaSound via builder API
#rb rob.gay
#jira UE-224638
#rnx

#p4v-cherrypick 36559207

[CL 36756718 by rob gay in 5.5 branch]
2024-10-01 19:23:42 -04:00
rob gay
9583f012e8 Remove checks for CanTarget in calls leveraged in non-editor builds. (PerPlatform settings are not available at runtime when initialized in an .ini and deserialized as CDOs)
#jira UE-225009
#rb helen.yang, eric.buchholz
[FYI] jon.huller, sondra.moyls, Randolph.Kestner
#rnx
#p4v-cherrypick 36557318

[CL 36756588 by rob gay in 5.5 branch]
2024-10-01 19:22:54 -04:00
helen yang
b55a4379fd Fix crash and errors when building MetaSound presets and renaming referenced MetaSounds
#jira UE-225355
#jira UE-225326
#rb Rob.Gay
#rnx

[CL 36755792 by helen yang in 5.5 branch]
2024-10-01 19:10:44 -04:00
rob gay
3d239917dd Backout deprecation portion of prior CL until content can be fixed up
#rb rob.gay
#rnx

[CL 36755620 by rob gay in 5.5 branch]
2024-10-01 19:09:19 -04:00
rob gay
73be44d870 Fix warning in MetaSound tests
#rb rob.gay
#rnx

#p4v-cherrypick 36547161

[CL 36755433 by rob gay in 5.5 branch]
2024-10-01 19:07:55 -04:00
helen yang
52f3b9f966 Fix various intergraph MetaSound member copy paste issues
- Fix not all fields being copied
- Add output node copying between graphs

#jira UE-219694, UE-219585
#rb rob.gay
#rnx

[CL 36755266 by helen yang in 5.5 branch]
2024-10-01 19:06:30 -04:00
rob gay
0d3da9c016 - Fix for ensure when copying and pasting a variable from a different page on the same asset
- Fix for variable names not updating when swapping pages in the members detail panel
- Hide audition options if project has no page settings

#jira UE-223836
#rb brian.chrisman
#rnx
[FYI] jon.huller, sondra.moyls
#p4v-cherrypick 36541088

[CL 36755028 by rob gay in 5.5 branch]
2024-10-01 19:04:38 -04:00
rob gay
88bcb4e9c1 Fix MetaSound Build BP call to not take parent object as parameter (Transient asset MetaSounds are now required to be TopLevel in the temp package)
#rb helen.yang
#jira UE-224638
#tests local BP
#rnx
[FYI] Dan.Reynolds, sondra.moyls, jon.huller

[CL 36754855 by rob gay in 5.5 branch]
2024-10-01 19:02:59 -04:00
miro salminen
e594839457 [MetaSounds] - Duplicated Inputs have errors on nodes when used in composition
&&
[MetaSounds] - Inputs made using Promote All Inputs have errors on nodes when used in composition

#rb helen.yang
#jira UE-224640, UE-224938
#rnx

[CL 36753927 by miro salminen in 5.5 branch]
2024-10-01 18:55:03 -04:00
rob gay
0432142912 Remove cvar requirement to see MetaSound asset page editor bits
#jira UE-225116
#rb helen.yang
#rnx
[FYI] sondra.moyls, jon.huller, Aaron.McLeran
#p4v-cherrypick 36510642

[CL 36752425 by rob gay in 5.5 branch]
2024-10-01 18:42:32 -04:00
rob gay
e43f356049 - Add more logging to MetaSound cook indicating page removal
- Fix off-by-one when removing default graph via builder API
- Add missing Super::PostLoad that may be causing config values from getting loaded in MetaSoundSettings

#jira UE-225009
#rb phil.popp
#rnx
#tests local cook
[FYI] sondra.moyls, jon.huller, phil.popp

[CL 36747695 by rob gay in 5.5 branch]
2024-10-01 17:46:57 -04:00
Rob Gay
6d8ed49d54 Renaming a MetaSound patch results in duplicates/crashes if MetaSound Editor is Open
#jira UE-225326, UE-225441
#rnx
#rb helen.yang
#fyi sondra.moyls, jon.huller, julien.marchand
#p4v-cherrypick 36654551

[CL 36655590 by Rob Gay in 5.5 branch]
2024-09-26 19:52:04 -04:00
rob gay
5ec150b388 Fix bad merge from last week causing false ensure on changing a MetaSound output's data type
#rb phil.popp
#jira UE-225221
#rnx



#p4v-cherrypick 36520081

[CL 36635850 by rob gay in 5.5 branch]
2024-09-26 13:18:57 -04:00
rob gay
7fef3345f8 Partial edigrate of:
Fix crash and errors when building MetaSound presets and renaming referenced MetaSounds

#jira UE-225355
#jira UE-225326
#rb Rob.Gay
#rnx

#p4v-cherrypick 36551289

[CL 36593743 by rob gay in 5.5 branch]
2024-09-25 18:04:36 -04:00
Rob Gay
6baaeb01da Partial edigrate of:
Fix crash and errors when building MetaSound presets and renaming referenced MetaSounds

#jira UE-225355
#jira UE-225326
#rb Rob.Gay
#rnx

#p4v-cherrypick 36551289

[CL 36589464 by Rob Gay in Dev-5.5 branch]
2024-09-25 16:55:51 -04:00
Rob Gay
d8d0723aee Fix bad merge from last week causing false ensure on changing a MetaSound output's data type
#rb phil.popp
#jira UE-225221
#rnx



#p4v-cherrypick 36520081

[CL 36539370 by Rob Gay in Dev-5.5 branch]
2024-09-24 12:11:34 -04:00
rob gay
d4a40a92af Trivial: Fix ensure when promoting In value to input from Trigger on Threshold
- Move ensure to warning as implicit cast won't necessarily induce a bug

#jira UE-224637
#rnx
#rb rob.gay
[FYI] sondra.moyls, helen.yang, jon.huller
#p4v-cherrypick 36460708

[CL 36460726 by rob gay in 5.5 branch]
2024-09-19 19:56:05 -04:00
jimmy smith
4a3e162eb3 Fix for crash deleting metasound node
#jira UE-223828
#rb rob.gay
#tests Tested on Mac with repro steps from JIRA and Windows.
[RN] Bug fix for crash in Metasounds from deleteing a node

[CL 36457117 by jimmy smith in 5.5 branch]
2024-09-19 18:41:31 -04:00
rob gay
01bcc9e365 Round 2: Backout of backout(s?):
- Uniform color fix-ups for MetaSound analyzers
- Move live MetaSound stats/audition settings to top left of graph
- Fix ordering of playback widget in input details panel to follow same order as page details panel

#rnx
[FYI] helen.yang, jon.huller, sondra.moyls, aaron.mcleran
#rb Brian.Chrisman
#jira UE-224143

[CL 36453576 by rob gay in 5.5 branch]
2024-09-19 17:46:22 -04:00
rob gay
56c2da2798 Fix for wrong node registry key ctor used when migrating package
#rnx
[FYI] jon.huller, helen.yang
#jira UE-224935
#rb rob.gay
#p4v-cherrypick 36453129

[CL 36453262 by rob gay in 5.5 branch]
2024-09-19 17:42:16 -04:00
helen yang
505c55ce5e Fix details panel issues with MetaSound member metadata (ex. float range/clamp) in outputs/variables + presets
- Don't show or apply range on outputs/variables unless Clamp Default is selected
- Fix inconsistencies with Clamp Default and Range displays in presets

#jira UE-164990
#rb Rob.Gay
#rnx

[CL 36450233 by helen yang in 5.5 branch]
2024-09-19 16:31:42 -04:00