Commit Graph

87 Commits

Author SHA1 Message Date
helge mathee
6bb12ce1e1 Control Rig: Separate storage for pose, dirty state and curve from hierarchy
#rb benoit.gadreau
#rnx

[CL 35858419 by helge mathee in ue5-main branch]
2024-08-28 04:56:05 -04:00
jurre debaare
99e6cf12a0 Trivial log formatting fix
#rb jurre.debaare

[CL 35488571 by jurre debaare in ue5-main branch]
2024-08-13 05:52:14 -04:00
jurre debaare
a6471dffd0 Changed "New play length is same as existing one" warning to Display verbosity
#rb Thomas.Sarkanen
[FYI] Randall.Hess

[CL 33231986 by jurre debaare in ue5-main branch]
2024-04-25 11:04:29 -04:00
steve robb
bd31b2021c Fixed miscelleneous potentially uninitialized FVectors.
#jira UE-87511

[CL 32980682 by steve robb in ue5-main branch]
2024-04-15 20:17:01 -04:00
jurre debaare
4dbc27de1b [Backout] - CL31800709
[FYI] Jurre.deBaare
Original CL Desc
-----------------------------------------------------------------
Resubmitting:
Reduce cook-time memory usage for AnimSequencerDataModel
    - Lazy initialize RigHierarchy
    - Reset RigHierarchy on WillNeverCacheCookedPlatformDataAgain
#rb Thomas.Sarkanen
[FYI] Zousar.Shaker

[CL 31920313 by jurre debaare in ue5-main branch]
2024-02-29 15:14:45 -05:00
jurre debaare
f8a16631ed Resubmitting:
Reduce cook-time memory usage for AnimSequencerDataModel
    - Lazy initialize RigHierarchy
    - Reset RigHierarchy on WillNeverCacheCookedPlatformDataAgain
#rb Thomas.Sarkanen
[FYI] Zousar.Shaker

[CL 31800721 by jurre debaare in ue5-main branch]
2024-02-26 07:36:46 -05:00
thomas sarkanen
147666490c Fix edge cases around re-importing meshes with bones inserted into the hierarchy
This adds a CVar (a.Skeleton.AllowIncompatibleSkeletalMeshMerge) to enable the addition of bones into the middle of skeleton hierarchies via import. In general this is not safe to do and will likely result in deformed meshes and corrupt animations. In the case this is being built for, the affected bones are not skinned to any existing meshes, and the number of animations that will also need re-importing is limited.

This splits USkeleton::MergeBonesToBoneTree into two modification passes:
- First, any mesh bones that already dont exist in the skeleton are added
- Second, any bones with differing parents are fixed up

Fixed precision issues with FReferenceSkeleton::SetParent where non-normalized rotations could be generated in the reference pose.
Fixed skeleton replacement not causing a recompression when skeleton bone indices could change (added new model notification).

Also fixed up incorrect error message on reimport of differing hierarchies

#rb benoit.gadreau, Nicholas.Frechette

[CL 30964134 by thomas sarkanen in ue5-main branch]
2024-01-29 05:21:52 -05:00
thomas sarkanen
266d9b077d Added the ability to add comments to curves on animations
Comments are added from the curve's outliner menu. Editing can just be done by clicking the comment after it has been created
Also exposed the setting to view curves in a tree view in the timeline itself

NOTE: this removes a 4.5 core redirect from CurveName to LastObservedName as CurveName was reinstated as the canonical name for the curve, and having the redirect in place causes issues with tagged property serialization when new properties are added.

#jira UE-203593
#rb Nicholas.Frechette

[CL 30769970 by thomas sarkanen in ue5-main branch]
2024-01-22 09:01:15 -05:00
steve robb
6d5b974842 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30735396 by steve robb in ue5-main branch]
2024-01-19 19:41:56 -05:00
marc audy
b5ea09d23b Remove unused code
[CODEREVIEW] jurre.debaare

[CL 30519814 by marc audy in ue5-main branch]
2024-01-09 18:38:50 -05:00
jurre debaare
221e2821d0 Clear default value when calling UpdateBoneTrackKeys in MovieSceneChannel
#jira UE-196743
#rb Thomas.Sarkanen

[CL 29984265 by jurre debaare in ue5-main branch]
2023-11-29 06:57:17 -05:00
jurre debaare
0047b90a39 Animation sequence stops and warning showing after undoing adding or deleting frames
#jira UE-197953
#fix ensure that the MovieScene is not transacted in addition to the Controller Actions when changing the playback range
#rb Thomas.Sarkanen

[CL 29959433 by jurre debaare in ue5-main branch]
2023-11-28 09:55:31 -05:00
sara schvartzman
a4ea5127cb Control Rig: Rename BaseControlRig files to ControlRig files
#rnx

[CL 29230233 by sara schvartzman in ue5-main branch]
2023-10-30 08:25:55 -04:00
sara schvartzman
0bcc4b46eb Control Rig: Rename BaseControlRig to ControlRig
#rb helge.mathee
#rnx
#p4v-cherrypick 29228200

[CL 29229266 by sara schvartzman in ue5-main branch]
2023-10-30 07:01:53 -04:00
sara schvartzman
4e28ae6a65 Control Rig: Rename ControlRig to BaseControlRig and created a specialized ControlRig
#jira UE-197304
#rb helge.mathee

[CL 28802754 by sara schvartzman in ue5-main branch]
2023-10-16 12:39:18 -04:00
sara schvartzman
9b14019f8f Control Rig: Rename ControlRig files to BaseControlRig
#jira UE-197304
#rb helge.mathee

[CL 28661531 by sara schvartzman in ue5-main branch]
2023-10-11 09:26:32 -04:00
zousar shaker
7a05cedba5 [Backout] - CL28312511
[FYI] Jurre.deBaare
Original CL Desc
-----------------------------------------------------------------
Reduce cook-time memory usage for AnimSequencerDataModel
    - Lazy initialize RigHierarchy
    - Reset RigHierarchy on WillNeverCacheCookedPlatformDataAgain
#rb Thomas.Sarkanen

[CL 28331238 by zousar shaker in ue5-main branch]
2023-09-28 18:19:35 -04:00
jurre debaare
86dc985fe2 Reduce cook-time memory usage for AnimSequencerDataModel
- Lazy initialize RigHierarchy
    - Reset RigHierarchy on WillNeverCacheCookedPlatformDataAgain
#rb Thomas.Sarkanen

[CL 28312520 by jurre debaare in ue5-main branch]
2023-09-28 06:10:25 -04:00
jurre debaare
5ab3574dcc Ensure that type hash for non-memory-trivial animation attributes is set-able/used
#rb Thomas.Sarkanen

[CL 27915053 by jurre debaare in ue5-main branch]
2023-09-15 10:34:01 -04:00
robert millar
49bbf540a7 Add path name to assertions
#rb none

[CL 27861752 by robert millar in ue5-main branch]
2023-09-13 20:28:09 -04:00
jurre debaare
0309af427d Always force-set float/transform controls during AnimSequencerData evaluation
#rb Thomas.Sarkanen

[CL 27335950 by jurre debaare in ue5-main branch]
2023-08-24 05:02:39 -04:00
max chen
ae5943a9c3 Sequencer Scripting: Change to get/set view and working ranges to double
#jira UE-192832
#rb david.bromberg

[CL 27240177 by max chen in ue5-main branch]
2023-08-21 11:27:20 -04:00
jurre debaare
8dc2c722e9 Fixup incorrect by-value to by-const-ref
#rb Thomas.Sarkanen

[CL 27200995 by jurre debaare in ue5-main branch]
2023-08-18 09:45:36 -04:00
helge mathee
58cd171e37 Control Rig: Improve FName FString conversion
#rb sara.schvartzman

[CL 27197375 by helge mathee in ue5-main branch]
2023-08-18 04:03:07 -04:00
kiaran ritchie
615b185110 Fixes IK Retarget editor bug, undo queue broken after exporting animation
#rb trivial

[CL 26662082 by kiaran ritchie in ue5-main branch]
2023-07-27 20:00:12 -04:00