Commit Graph

315 Commits

Author SHA1 Message Date
jamie dale
4ee53b9314 Potential fix for NiagaraValidationRuleSet having missing rules in a cooked editor
[FYI] Stu.McKenna
#rnx

[CL 35610772 by jamie dale in ue5-main branch]
2024-08-16 18:46:53 -04:00
matt peters
ee9ba73297 IncrementalCook: IterativeValidate: Add a PackageIgnoreList so we can collect diagnostics on packages that are known to have falsepositives, but still mark the job as succeeded. Add a cookforcediff parameter for testing.
#rnx

[CL 34740932 by matt peters in ue5-main branch]
2024-06-28 11:51:49 -04:00
luke thatcher
6cb87653e2 Re-enable GPU profiler stats in the editor, by backing out the workaround from CL 31055877 (UE-205211)
Remove "r.GPUStatsMaxQueriesPerFrame" cvar and associated logic in GPU profiler
 - The "overflow" event logic is broken since the latest RHI refactor as the location the EndFrame / Clear happens has changed.
 - Since the underlying bugs / memory inefficiencies that prompted the addition of this cvar have been solved, we don't need to keep any of this now. See below for details.

Query workarounds:

    Remove workaround for memory leak in blueprint debugger
     - Workaround was added in UE 4.26 CL 14541591, but has been superceeded by another workaround added in UE 5.0 CL 20674492.
     - It is no longer necessary to change GPU profiler cvar values before/after blueprint debugging to prevent a memory leak.

    Remove D3D12 excessive memory usage workaround in D3D12RHI.cpp
     - r.GPUStatsMaxQueriesPerFrame was set to 8192 at RHI startup. Previous implementation of queries in D3D12 was very wasteful on memory.
     - The modern implementation packs individual queries into heaps, which greatly reduces the overhead. It is no longer necessary to limit the number of queries in a frame.

Misc changes:

    Remove FDynamicRHI::RHICreateRenderQueryPool function
     - None of the platform RHIs provided an implementation that didn't just return a new FDefaultRHIRenderQueryPool.

    Remove NumQueries from FDefaultRHIRenderQueryPool
     - The value is never used by platform RHIs, and it only causes ensures in cases where the num is too small for what is actually used.

#jira UE-205211, UE-218537
#rb ben.woodhouse

[CL 34607450 by luke thatcher in ue5-main branch]
2024-06-24 12:38:27 -04:00
ross smith2
df0897c2e5 In UEditorProjectAppearanceSettings::PostInitProperties initialize missing display units.
In BaseEditor.ini set the default value for ImpulseUnits and PositionalImpulseUnits.

#jira UE-217687
#rb brooke.hubert

[CL 34284795 by ross smith2 in ue5-main branch]
2024-06-11 14:36:28 -04:00
matt peters
ba118ffde2 IterativeCook: Remove NiagaraSystem and SoundWave from the iterativeclassdenylist now that they have been fixed.
#rnx

[CL 33799703 by matt peters in ue5-main branch]
2024-05-21 12:51:08 -04:00
matt peters
a8848e2538 IterativeCook: Add NiagaraSystem and SoundWave to the iterativeclassdenylist.
#rnx

[CL 33672157 by matt peters in ue5-main branch]
2024-05-15 17:43:37 -04:00
matt peters
2251f91d07 MPCook: Enable retraction of generated packages; generated packages (most notably worldpartition) can now be pulled off of the CookWorker that saved their generator package and assigned to other CookWorkers that are idle.
#rnx
#rb matt.peters
#rbself Trivial enablement change

[CL 33455986 by matt peters in ue5-main branch]
2024-05-06 10:21:39 -04:00
robert millar
62756fcf81 Re-enable async content browser text search.
[CL 33438614 by robert millar in ue5-main branch]
2024-05-03 17:36:07 -04:00
robert millar
d1fd6872cf Disable async/parallel text search in content browser.
[CL 33400032 by robert millar in ue5-main branch]
2024-05-02 12:37:38 -04:00
matt peters
937becd812 Incremental cook: Remove Material and MaterialFunction from the deny list since their iterative false skip jiras have been fixed. There is still a known issue with MaterialInstanceConstant; ETA for that fix is in a few days.
#rnx
#rb Zousar.Shaker

[CL 33034119 by matt peters in ue5-main branch]
2024-04-17 09:23:15 -04:00
matt peters
41e0c440de [Backout] - CL32636511
It is causing "LogCook: Error: PackageSplitter found an existing copy of a package it was trying to populate;this is unexpected since garbage has been collected and the package should have been unreferenced so it should have been collected."
[FYI] matt.peters
Original CL Desc
-----------------------------------------------------------------
[Resubmit] MPCook: CookPackageSplitter: Toggle enable retraction of generated packages.
#jira UE-188805
#jira UE-177380
#rnx

[CL 32639018 by matt peters in ue5-main branch]
2024-04-01 10:23:25 -04:00
matt peters
8a62fc1ddf [Resubmit] MPCook: CookPackageSplitter: Toggle enable retraction of generated packages.
#jira UE-188805
#jira UE-177380
#rnx

[CL 32636518 by matt peters in ue5-main branch]
2024-04-01 08:14:58 -04:00
matt peters
4a92cc1457 [Backout] - CL32546429, it is likely the cause of hanging autocooks.
Original CL Desc
-----------------------------------------------------------------
MPCook: CookPackageSplitter: Toggle enable retraction of generated packages.

[CL 32563076 by matt peters in ue5-main branch]
2024-03-27 18:51:53 -04:00
matt peters
419ce55147 MPCook: CookPackageSplitter: Toggle enable retraction of generated packages.
#jira UE-188805
#jira UE-177380
#rnx

[CL 32546716 by matt peters in ue5-main branch]
2024-03-27 12:24:13 -04:00
matt peters
94a4e7e0b1 [Resubmit - error in previous submission was fixed in CL 32449966]
MPCook And CookPackageSplitter: Implement on demand creation and splitting of generator packages rather than only creating them during save.
#jira UE-188805
#jira UE-177380
#rnx
#rb Zousar.Shaker

[CL 32468020 by matt peters in ue5-main branch]
2024-03-25 08:47:10 -04:00
bob tellez
19639b72ec [Backout] - CL32436615
[FYI] Matt.Peters
Original CL Desc
-----------------------------------------------------------------
MPCook And CookPackageSplitter: Implement on demand creation and splitting of generator packages rather than only creating them during save.
#jira UE-188805
#jira UE-177380
#rnx
#rb Zousar.Shaker

[CL 32446435 by bob tellez in ue5-main branch]
2024-03-22 15:28:23 -04:00
matt peters
032a8d39ae MPCook And CookPackageSplitter: Implement on demand creation and splitting of generator packages rather than only creating them during save.
#jira UE-188805
#jira UE-177380
#rnx
#rb Zousar.Shaker

[CL 32436670 by matt peters in ue5-main branch]
2024-03-22 12:14:01 -04:00
matt peters
e2f980a1ca Cooker: Incremental: Update IterativeClassDenyList for indeterminism: remove types with fixes and add on types with new issues.
#rnx
#rb Zousar.Shaker

[CL 32158808 by matt peters in ue5-main branch]
2024-03-11 13:21:02 -04:00
charles derousiers
bd150007de Add Depth of Field Use hair depth property on PostProcessVolume and expose it for UEFN.
#rb charles.derousiers

[CL 32105636 by charles derousiers in ue5-main branch]
2024-03-07 18:28:37 -05:00
lorry li
3019b9090b Adjust the max concurrent http requests, make it hotfixable.
[REVIEW] [at]michael.atchison [at]michael.kirzinger [at]ryan.hairyes [at]chris.varnsverry [at]laura.hermanns [at]alejandro.aguilar
#rb Chris.Varnsverry, Laura.Hermanns, michael.atchison

[CL 31817974 by lorry li in ue5-main branch]
2024-02-26 16:50:00 -05:00
ben zeigler
38d0d0d9c3 Move the GameFeatures and ModularGameplay plugins out of Experimental and put them in Runtime. The plugins have been considered as Beta since 5.2 but they were not moved at the time
The default templates for new game feature plugins were moved as part of this and you may need to update your game's defaulteditor.ini file if it overrides the defaults
#rb Eric.Knapik

[CL 31065946 by ben zeigler in ue5-main branch]
2024-01-31 16:54:18 -05:00
charles lefebvre
19316f65ff UE Units: Add acceleration (cm/s2 and m/s2)
#rb Yoan.StAmant
#rnx
#tests Tested in editor, preflight

[CL 31057164 by charles lefebvre in ue5-main branch]
2024-01-31 13:59:44 -05:00
ben woodhouse
7fd6828752 Re-enable the realtime GPU profiler by default, but disable in editor. This is a more targeted workaround for UE-205211
#jira UE-205211
[FYI] luke.thatcher
#tests tested in editor and with a replayrun preflight with the cvar disabled

[CL 31055966 by ben woodhouse in ue5-main branch]
2024-01-31 13:28:32 -05:00
laura hermanns
3f46a33ceb Add editor version of "[HTTP.HttpThread]:RunningThreadedRequestLimit" configuration and increase value for editor to fix limit warning for UBA shader compilation.
#jira UE-204173
#rnx
#rb lorry.li
[FYI] josh.adams, henrik.karlsson

[CL 30842742 by laura hermanns in ue5-main branch]
2024-01-24 10:01:18 -05:00
matt peters
557cfe0225 IterativeCooker: Add initial set of allowed and blocked classes for incremental cooking, and some utility functions that we needed to implement it.
ModuleManager: Add version of ModuleExists that also returns the discovered filename of the .dll.
PackageName: Add TryConvertScriptPackageNameToModuleName.
#rb Zousar.Shaker
#rnx

[CL 30600379 by matt peters in ue5-main branch]
2024-01-12 14:28:27 -05:00