Commit Graph

755 Commits

Author SHA1 Message Date
serge bernier
f2d41b7ae7 Fix warning in cook by initializing the DeviceProfileManger. Calling the UDeviceProfileManager::Get().InitializeCVarsForActiveDeviceProfile() does intialize sampler states (Wrap_WorldGroupSettings and Clamp_WorldGroupSettings) that can be refresh by RefreshSamplerStatesCallback during the engine init phase. We need to check if the DynamicRHI was created before refreshing samplerstates.
#rb [at]josh.Adams

[CL 21725991 by serge bernier in ue5-main branch]
2022-08-31 15:12:03 -04:00
Florin Pascu
6b3c1469ba Preview Shader Platform using different ShaderMaps and the DDPI/Cvar values of the Previewable Actual Platform
NumPlatforms limit changed from 64 to 65536, limited by NumBits
#jira UE-120561
#rb Chris.Waters, Jack.Porter, Mihnea.Balta
#preflight 630f1604f92416fb92b373ab

[CL 21718179 by Florin Pascu in ue5-main branch]
2022-08-31 04:38:34 -04:00
serge bernier
948ea474f6 [Backout] - CL21701595
[FYI] Serge.Bernier
Original CL Desc
-----------------------------------------------------------------
Initialize device profile manager earlier in the pre init phase to properly set the FCoreDelegates::GatherDeviceProfileCVars.


#rb josh.adam

[CL 21707544 by serge bernier in ue5-main branch]
2022-08-30 15:31:54 -04:00
chris constantinescu
1fab9f1540 If project path is set from uecommandline.txt the engine doesn't pick up the game name correctly.
Check first max 10 arguments instead of just the first.
#rb Jerome.Delattre
#preflight 630e0f50e1124837754e3bde,630e0f57e352708d4416fb1e

[CL 21706201 by chris constantinescu in ue5-main branch]
2022-08-30 14:27:03 -04:00
serge bernier
8a4eb59aa1 Initialize device profile manager earlier in the pre init phase to properly set the FCoreDelegates::GatherDeviceProfileCVars.
#rb josh.adam

[CL 21705476 by serge bernier in ue5-main branch]
2022-08-30 13:48:32 -04:00
henrik karlsson
8a61828dab [Runtime.Launch]
* LaunchEngineLoop - Added activity scopes and moved console to show earlier

#rb Devin.Doucette
#preflight 6303fac6a45b007ea255fdea

[CL 21511745 by henrik karlsson in ue5-main branch]
2022-08-23 12:58:13 -04:00
paul chipchase
fc827406e2 Add a number of ways for the VA system to be changed to lazy initialize on first use.
#rb Per.Larsson
#jira UE-161296
#rnx
#preflight 62fe3ce73d3fb466b229bcc0

- There are some usecases that require the VA system to initialize the first time it is accessed (usually the first time we attempt to pull a virtualized payload) rather than be initialized in the program start up. This change provides three different methods to achieve this:
-- Setting the define 'UE_VIRTUALIZATION_SYSTEM_LAZY_INIT' to 1 in a programs .target.cs
-- Setting [Core.ContentVirtualization]LazyInit=true in the Engine ini file
-- Running with the commandline option -VA-LazyInit

- If we detect that the source control backend is being initialized on a background thread we do not try to run the FConnect operation. The backend will still work but this does reduce the potential error checking on initialization. This is done because the FConnect operation currently only works on the main thread and to change this would be a bigger work item than we can schedule at the moment.
- UE::Virtualization::Initialize functions now take a EInitializationFlags enum as a parameter. This enum allows the call to ignore all lazy init settings and force the initialization immediately. This is useful for programs like the Virtualization standalone tool which just needs to start the system when needed.
-- The call to ::Initialize in LaunchEngineLoop passes in None and does not ignore lazy initialization.
-- Calls to ::Initialize in the UnrealVirtualizationTool however all use EInitializationFlags::ForceInitialize and ignore lazy initialization settings.
- Fixed an odd bug in UE::Virtualization::Initialize where the error path (if the config file cannot be found) was using a different start up code path.
- Add asserts when assigning to GVirtualizationSystem to make sure that it is null. This is not 100% safe but should catch some potential threading issues, if any.
- Add an assert after lazy initialization (IVirtualizationSystem::Get) to make sure that GVirtualizationSystem was assigned a valid object.
- Improve how we check for legacy values in [Core.ContentVirtualization]. We now support multiple allowed values.
- Added a way to poll if a VA system has been initialize yet or not, this allows us to avoid initializing a VA system if one has not yet been created and we try to:
-- Dump VA profiling stats after cooking
-- Send VA stats to studio analytics
- Note that currently using lazy init loading will probably cause the VA statistics panel not to work, this will be fixed in future work where we will allow the panel to register for a callback when the system is initialized.

[CL 21467510 by paul chipchase in ue5-main branch]
2022-08-19 19:15:42 -04:00
james hopkin
6e2d376cbd [engine] Fixed saved directory paths being cached before -saveddir etc are processed
[REVIEW] [at]Josh.Adams
#rnx

#ROBOMERGE-AUTHOR: james.hopkin
#ROBOMERGE-SOURCE: CL 21439789 via CL 21439798 via CL 21439816
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v981-21435820)

[CL 21440291 by james hopkin in ue5-main branch]
2022-08-18 08:05:38 -04:00
Thomas Sarkanen
ac5eaf1318 Preload animation compression settings before we load any game content in editor builds
Fixes warnings about calling LoadObject in PostLoad of anim sequences

#jira UE-145778
#rb Jurre.deBaare
#preflight 62fdf8540601ad050473206d

[CL 21439526 by Thomas Sarkanen in ue5-main branch]
2022-08-18 05:50:06 -04:00
ben woodhouse
f01fc33a83 Make a new RenderthreadCriticalPath stat which includes dependent waits. The new stat still excludes GPU occlusion query waits, the present wait and non-critical path waits (waiting for the game thread or RHI thread). Waits for tasks kicked on the GT are included though (unlike the existing stat).
The implementation extends the existing FThreadIdleStats to track critical path vs non-critical path waits for a thread.

The cvar r.RenderThreadTimeIncludesDependentWaits forces the main renderthread stat to use the new behavior, but this is disabled by default for historical tracking reasons.

#rb Nuno Leiria

#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 21386702 via CL 21387159 via CL 21387356 via CL 21391039 via CL 21391830
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v975-21357124)

[CL 21394348 by ben woodhouse in ue5-main branch]
2022-08-15 17:15:00 -04:00
ben woodhouse
d841f35bd7 Reinstate 21355934 with assert fix
#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 21359298 via CL 21359569 via CL 21359589 via CL 21359605
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21362808 by ben woodhouse in ue5-main branch]
2022-08-12 16:15:05 -04:00
ben woodhouse
c7d95d47b7 Partial backout to workaround assert
#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 21357137 via CL 21357285 via CL 21357293 via CL 21357304
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21358768 by ben woodhouse in ue5-main branch]
2022-08-12 13:50:56 -04:00
ben woodhouse
7db1565880 If the CSV Profiler is running, output the CSV GT/RT frame in the GT and RT frame named events rather than the engine frame numbers, and prefix with Csv.
#rb serge.bernier

#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 21355012 via CL 21355934 via CL 21355993 via CL 21356002
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21358177 by ben woodhouse in ue5-main branch]
2022-08-12 13:23:10 -04:00
rex hill
593988be39 Deprecate GIsFirstInstance for FPlatformProcess::IsFirstInstance() and make it work in shipping editor
#rb josh.adams
#preflight 62f3ccd1bc175ec68c439d8e

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21319766 via CL 21323340 via CL 21323407 via CL 21323452
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21325866 by rex hill in ue5-main branch]
2022-08-10 17:01:37 -04:00
mark lintott
e2d74ce99d Fixed unacceptable words in Stats and Profiling system
#jira UE-158612, UE-158573, UE-158613
#rb pj.kack
#preflight 62f3b39cf75a2a539c84166f

[CL 21317572 by mark lintott in ue5-main branch]
2022-08-10 09:49:10 -04:00
rex hill
0f01e554a4 [Backout] - CL21299688
[FYI] Rex.Hill
Original CL Desc
-----------------------------------------------------------------
Allow GIsFirstInstance in shipping editor
#preflight 62f2bc6523003b62a3039e8d
#rb josh.adams

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21310168 via CL 21312295 via CL 21312341 via CL 21312351
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21314406 by rex hill in ue5-main branch]
2022-08-10 02:17:06 -04:00
rex hill
7ec0f0d3fb Allow GIsFirstInstance in shipping editor
#preflight 62f2bc6523003b62a3039e8d
#rb josh.adams

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21299688 via CL 21304677 via CL 21304703 via CL 21304719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21308838 by rex hill in ue5-main branch]
2022-08-09 22:04:01 -04:00
Rob Gay
7a86153445 Submitting on behalf of Anna.Lantz: Inclusive language push, removing master language from Runtime Audio component
#rb rob.gay
#jira UE-159115
#rnx
#preflight 62d5decc2e3e5993c3d43021

[CL 21154661 by Rob Gay in ue5-main branch]
2022-07-18 19:19:36 -04:00
danny couture
c69fd9b5c8 Load TimeManagement module on editor startup so as it is required by some serialization functions (i.e. AnimSequence)
#rb Francis.Hurteau
#preflight 62cf64325c36489ec9b3df09

[CL 21086070 by danny couture in ue5-main branch]
2022-07-13 21:01:40 -04:00
Devin Doucette
2961cd5dca Logging: Restored and deprecated a deleted function and tweaked the affected names
#preflight 62c84b80b3789302b1ebd675
#rb Zousar.Shaker
#rnx
#fyi Jack.Porter

[CL 21009006 by Devin Doucette in ue5-main branch]
2022-07-08 12:23:44 -04:00
Ben Marsh
06c12ca8e6 Fix PVS Studio warning (resource leak).
#preflight none
#fyi Steve.Robb

[CL 21006145 by Ben Marsh in ue5-main branch]
2022-07-08 09:28:44 -04:00
chris constantinescu
e90997b34e Catch2 - mini module cleanup
#preflight 62c793827e606620fd304713
#rb Jerome.Delattre

[CL 21004901 by chris constantinescu in ue5-main branch]
2022-07-08 06:55:54 -04:00
Jack Porter
e5cba9bf11 Replace uses of master in OutputDeviceRedirector
#jira UE-158659
#rb Florin.Pascu
#preflight 62c7e8666003a9b045822d62

[CL 21004289 by Jack Porter in ue5-main branch]
2022-07-08 04:33:35 -04:00
steve robb
73660ee955 Fix for LaunchFixProjectPathCase() assuming that TCHARs are WIDECHARs and doing in-string replacement with them.
Fix for FOutputDeviceStdOutput::Seralize() of TCHARs as UTF-8.

#rb devin.doucette
#jira UE-132142
#preflight 62c561d82f2d046918df0672

#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20965286 via CL 20965301 via CL 20965311
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 20966411 by steve robb in ue5-main branch]
2022-07-06 10:10:56 -04:00
paul chipchase
e091159583 Add a core delegate which is broadcasts once GWarn and GError are first set up
#rb Devin.Doucette
#rnx
#preflight 62bc2d99ee7cb716b4335e70

- This allows programs to override GWarn and GError before any messages are passed through them by FEngineLoop::PreInit.

#ROBOMERGE-AUTHOR: paul.chipchase
#ROBOMERGE-SOURCE: CL 20872257 via CL 20872260 via CL 20872263
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20876922 by paul chipchase in ue5-main branch]
2022-06-29 12:29:08 -04:00