#rb dan.oconnor
#preflight 63d83f963656ea96dc2a0a4c
#jira UE-173747
"Crash occurs when scrolling down through files in Review Changelist window upon loading of asset"
- certain widget blueprints were crashing the review tool because we were working around the inability to diff against nullptr by constructing temprorary empty objects. This approach circumvents that problem entirely
#jira UE-173231
"Changelist Review tool allows diffing against previous revision for Deletion changes"
- while this jira suggests that the ability to diff deletion changes is a bug, it was actually an intended feature. The real bug was that it would crash or fail to work in many cases. This has been fixed by either asset diffing against nullptr or text diffing against an empty file (depending on circumstance)
#jira UE-174610
"Reviewing Changelist with Deletion Changes results in LogLinker warnings & LoadErrors"
- deletion changes were trying to load the new revision of files but obviously it doesn't exist because it's a deletion. Fixed by only loading the previous revision
note: since the review tool is going to be "Production Ready" in 5.2, these changes are neccesary for stability
[CL 23924072 by jordan hoffmann in ue5-main branch]
* Updated private files with IWYU for all plugins which had 3 or less changes made in ue5 main since last integration to fn
#preflight 63bf8d8b577437afe607dc72
#rb none
[CL 23659643 by henrik karlsson in ue5-main branch]
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds
After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds
#jira
#preflight 63336159b20e73a098b7f24f
[CL 22218213 by bryan sefcik in ue5-main branch]