Commit Graph

141 Commits

Author SHA1 Message Date
stan hormell
37bad2d07b [Backout] - CL27731288 - CIS / Build Errors
[FYI] Josh.Adams
Original CL Desc
-----------------------------------------------------------------
- Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27745141 by stan hormell in ue5-main branch]
2023-09-10 22:58:21 -04:00
josh adams
a8a9a0b759 - Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27731364 by josh adams in ue5-main branch]
2023-09-08 17:58:55 -04:00
zousar shaker
ca374bd482 Add a setting that controls whether the modal acknowledgement dialog is shown before a browser is launched for OIDC authentication in editor. This setting is editor-wide (not per project), but:
1. A project can override the default value in that project's DefaultEditorSettings.ini
2. A user can indicate they don't want to see the dialog in the future, and thata setting is persisted to the user's editor settings file

If the setting indicates (either through defaults or user choice) that the acknowledgement dialog can be skipped, then unattended operations (eg: commandlets like cook etc..) are permitted to attempt interactive login by launching the browser.  If the browser login succeeds within a fixed timespan (30 seconds), then the unattended operation can proceed having successfully obtained an oidc token.  If the browser login hasn't succeeded in the fixed timespan, then the unanttended operation will proceed but will have failed to obtain an oidc token.  In neither case do we block indefinitely on completion of browser login to obtain an oidc token.

#rb joakim.lindqvist
[FYI] stefan.boberg
#jira UE-191803

[CL 27177449 by zousar shaker in ue5-main branch]
2023-08-17 13:13:20 -04:00
david harvey
bdb4199eeb Remove unnecessary WindowsHWrapper.h & MinWindows.h include - both files will be automatically included by AllowWindowsPlatformTypes.h
#jira UE-152863
#rnx
#rb Josh.Adams

[CL 26912096 by david harvey in ue5-main branch]
2023-08-08 05:50:53 -04:00
Ryan Hummer
3ebc0e1bcf Removing mono/xbuild part 1
* Updating references to use dotnet
* Add new RunDotnet scripts
* Removing Mono sh scripts and references to them

#rnx
#jira UE-153293
#rb josh.adams, zack.neyland, brandon.schaefer

[CL 26737744 by Ryan Hummer in ue5-main branch]
2023-08-01 10:02:58 -04:00
Joakim Lindqvist
3924fcb886 DDC is Derived Data Cache - update the message to reflect that.
#preflight none
#rb none

[CL 25674030 by Joakim Lindqvist in ue5-main branch]
2023-05-30 05:49:24 -04:00
devin doucette
90200ff6d0 DDC: Fixes related to the use of OIDC functionality from DesktopPlatform
- Fixed a crash when HttpCacheStore is used without DesktopPlatform.
- Fixed GetOidcAccessToken and GetOidcTokenStatus failing for targets with no Intermediate directory.
- Added DesktopPlatform to DerivedDataTool to allow it to use HttpCacheStore with OIDC.

#rb Zousar.Shaker
[FYI] Dan.Engelbrecht

[CL 25072527 by devin doucette in ue5-main branch]
2023-04-17 15:23:51 -04:00
matt peters
c6a6899e09 OidcToken: Delete temporary files from Intermediate directory after we no longer need them.
#rb Devin.Doucette
#rnx
[FYI] Joakim.Lindqvist
#preflight 6427238550546ea336c81554

[CL 24878299 by matt peters in ue5-main branch]
2023-03-31 16:51:28 -04:00
Ben Marsh
0e5d960c8a Use relative paths in TargetInfo.json to make them portable between machines (eg. when including in a zip of PCBs).
#preflight 640804f02559570cc71dba41

[CL 24554724 by Ben Marsh in ue5-main branch]
2023-03-07 23:01:27 -05:00
joakim lindqvist
40c47276bd Error -> Warning when we are unable to resolve a token for Cloud DDC. This will not cause the build to fail, but it will typically be slower for it so error is harsh (as that in itself causes the build to fail)
[FYI] zousar.shaker
#preflight 63ef6b8b90198dffbae12467

[CL 24281972 by joakim lindqvist in ue5-main branch]
2023-02-17 10:25:12 -05:00
joakim lindqvist
ff73a7f021 OidcToken - Improved error message when running unattended to clarify that you can login using the editor.
#preflight 63ee14787e76998e9a9f5547
[FYI] zousar.shaker

[CL 24256982 by joakim lindqvist in ue5-main branch]
2023-02-16 09:11:24 -05:00
Joakim Lindqvist
9d1e86e2c3 OidcToken Fixes
Support multiple redirect uris (so that we can attempt to use multiple ports)
Handle invalid json in state file, ignoring the state file in those cases
Also made sure to delete oidc token result file after consuming it from the editor

#preflight 63d27dd26730a500ffafd80d
#fyi zousar.shaker

[CL 23882301 by Joakim Lindqvist in ue5-main branch]
2023-01-27 08:12:35 -05:00
rex hill
eab6f67207 Fix unicode character being used instead of ' in team's
#jira UE-174908
#rb brandon.schaefer
#preflight skip
[FYI] joakim.lindqvist

[CL 23834204 by rex hill in ue5-main branch]
2023-01-24 13:20:50 -05:00
Joakim Lindqvist
611799154b Wait up to 30 seconds before prompting users to finish the login - it can take a while if users need to enter their password and such, it is still quite short but on the other hand we do not want the editor to just sit around waiting for ever in case something has gone wrong.
#preflight 63bff0f2bf54fa7b3657f9c6

[CL 23660685 by Joakim Lindqvist in ue5-main branch]
2023-01-12 06:44:58 -05:00
MalikuMane
98b4ee0ea8 PR #9906: Fix Linux duplicate engine association entries in Install.ini. (Contributed by MalikuMane)
#jira UE-172625
#rb Robert.Seiver
#preflight 639b653d43330e63e573c069

[CL 23531567 by MalikuMane in ue5-main branch]
2022-12-15 16:02:48 -05:00
Joakim Lindqvist
3fc55bdb05 OidcToken - If users answer no to waiting for interactive login, but the login has actually completed we now continue with the valid token we have.
#preflight 6391bb87c415e8dc78252ab9
#rb devin.doucette

[CL 23446527 by Joakim Lindqvist in ue5-main branch]
2022-12-08 10:22:21 -05:00
Joakim Lindqvist
9f8a7dfb32 OidcToken - Added error page when there is a problem logging in, polished the look of the success page. Also updated the text in the popup prompt for login to read a bit better.
#preflight none

[CL 23174150 by Joakim Lindqvist in ue5-main branch]
2022-11-17 06:39:30 -05:00
bryan sefcik
ca0d5de18d Fixed a few issues where IsTargetInfoValid would return that all targets weren't found. This would result in a call to UBT to get the TargetInfo and sometimes took up to 22+secs to call.
#jira
[FYI] ben.marsh
#preflight 63641b64882365b859628e9a

[CL 22977347 by bryan sefcik in ue5-main branch]
2022-11-03 23:47:12 -04:00
devin doucette
41c5373ebd DDC: Fixed parameter names related to OIDC to be compliant with the coding standard and simplified analytics formatting
#preflight 636403b3de2c4dbb5d3a5b11
#rb Zousar.Shaker
#rnx

[CL 22968397 by devin doucette in ue5-main branch]
2022-11-03 18:00:06 -04:00
mark lintott
5ae432fc55 Addeed specific Unreal Cloud DDC analytics for core.cooking and core.loading events ( Domain, Effective Domain, Cache Hit/MIss for Cache Puts & Gets, FailedOIDC login attempts )
#rb joakim.lindqvist
#jira none
#preflight 6363c123d308b70e66f4cf33

[CL 22951911 by mark lintott in ue5-main branch]
2022-11-03 09:39:24 -04:00
Joakim Lindqvist
efcac1bd0d OidcToken - Changed exit code when determining if a token exists to a positive small number (10) which will avoid inconsistencies between desktop platform in how to handle a negative number.
#preflight 631600b3da1671f9972825c3

[CL 21794535 by Joakim Lindqvist in ue5-main branch]
2022-09-05 10:52:09 -04:00
Joakim Lindqvist
a1b55397d8 OidcToken - Fixed issue on linux were exit code was not correctly detected and thus the initial verification if a token exists fails.
#jira UE-162770
#preflight 6315d7c9da63cdf170d77a64

[CL 21790780 by Joakim Lindqvist in ue5-main branch]
2022-09-05 07:20:04 -04:00
Joakim Lindqvist
4e69a62587 OidcToken - Allow users to abort the oidc login in the prompt that warns we are about to spawn a browser
#jira UE-161365
#preflight https://horde.devtools.epicgames.com/job/630f1f60501b64ba33604fd2

[CL 21718887 by Joakim Lindqvist in ue5-main branch]
2022-08-31 07:22:25 -04:00
Joakim Lindqvist
11ea6a68fc OidcToken - Fixed issues specific to handle tokens on Mac, which handles cases where the token does not exist better.
Also improved logging when a unknown issue happens.
Lastly the error code returned from the mac process seems to be converted to a unsigned 32 bit so checking for that value as well when checking the exit code that means we should upgrade the process to a interactive login.

#preflight https://horde.devtools.epicgames.com/job/6308e65e2a02fecb6f3cadc5

[CL 21665549 by Joakim Lindqvist in ue5-main branch]
2022-08-29 04:05:26 -04:00
Joakim Lindqvist
767e76dbb0 OidcToken - Fixed issue running interactive login on mac and linux. Also fixed issue were asking to wait for login caused a crash as well as tweaking the error message when a user decided to not finish the interactive login.
#jira UE-161335, UE-161369
#preflight https://horde.devtools.epicgames.com/job/62ff679e3c4417dcec499e53

[CL 21455420 by Joakim Lindqvist in ue5-main branch]
2022-08-19 06:53:53 -04:00