Commit Graph

746 Commits

Author SHA1 Message Date
ben woodhouse
f01fc33a83 Make a new RenderthreadCriticalPath stat which includes dependent waits. The new stat still excludes GPU occlusion query waits, the present wait and non-critical path waits (waiting for the game thread or RHI thread). Waits for tasks kicked on the GT are included though (unlike the existing stat).
The implementation extends the existing FThreadIdleStats to track critical path vs non-critical path waits for a thread.

The cvar r.RenderThreadTimeIncludesDependentWaits forces the main renderthread stat to use the new behavior, but this is disabled by default for historical tracking reasons.

#rb Nuno Leiria

#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 21386702 via CL 21387159 via CL 21387356 via CL 21391039 via CL 21391830
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v975-21357124)

[CL 21394348 by ben woodhouse in ue5-main branch]
2022-08-15 17:15:00 -04:00
ben woodhouse
d841f35bd7 Reinstate 21355934 with assert fix
#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 21359298 via CL 21359569 via CL 21359589 via CL 21359605
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21362808 by ben woodhouse in ue5-main branch]
2022-08-12 16:15:05 -04:00
ben woodhouse
c7d95d47b7 Partial backout to workaround assert
#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 21357137 via CL 21357285 via CL 21357293 via CL 21357304
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21358768 by ben woodhouse in ue5-main branch]
2022-08-12 13:50:56 -04:00
ben woodhouse
7db1565880 If the CSV Profiler is running, output the CSV GT/RT frame in the GT and RT frame named events rather than the engine frame numbers, and prefix with Csv.
#rb serge.bernier

#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 21355012 via CL 21355934 via CL 21355993 via CL 21356002
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21358177 by ben woodhouse in ue5-main branch]
2022-08-12 13:23:10 -04:00
rex hill
593988be39 Deprecate GIsFirstInstance for FPlatformProcess::IsFirstInstance() and make it work in shipping editor
#rb josh.adams
#preflight 62f3ccd1bc175ec68c439d8e

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21319766 via CL 21323340 via CL 21323407 via CL 21323452
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21325866 by rex hill in ue5-main branch]
2022-08-10 17:01:37 -04:00
mark lintott
e2d74ce99d Fixed unacceptable words in Stats and Profiling system
#jira UE-158612, UE-158573, UE-158613
#rb pj.kack
#preflight 62f3b39cf75a2a539c84166f

[CL 21317572 by mark lintott in ue5-main branch]
2022-08-10 09:49:10 -04:00
rex hill
0f01e554a4 [Backout] - CL21299688
[FYI] Rex.Hill
Original CL Desc
-----------------------------------------------------------------
Allow GIsFirstInstance in shipping editor
#preflight 62f2bc6523003b62a3039e8d
#rb josh.adams

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21310168 via CL 21312295 via CL 21312341 via CL 21312351
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21314406 by rex hill in ue5-main branch]
2022-08-10 02:17:06 -04:00
rex hill
7ec0f0d3fb Allow GIsFirstInstance in shipping editor
#preflight 62f2bc6523003b62a3039e8d
#rb josh.adams

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21299688 via CL 21304677 via CL 21304703 via CL 21304719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21308838 by rex hill in ue5-main branch]
2022-08-09 22:04:01 -04:00
Rob Gay
7a86153445 Submitting on behalf of Anna.Lantz: Inclusive language push, removing master language from Runtime Audio component
#rb rob.gay
#jira UE-159115
#rnx
#preflight 62d5decc2e3e5993c3d43021

[CL 21154661 by Rob Gay in ue5-main branch]
2022-07-18 19:19:36 -04:00
danny couture
c69fd9b5c8 Load TimeManagement module on editor startup so as it is required by some serialization functions (i.e. AnimSequence)
#rb Francis.Hurteau
#preflight 62cf64325c36489ec9b3df09

[CL 21086070 by danny couture in ue5-main branch]
2022-07-13 21:01:40 -04:00
Devin Doucette
2961cd5dca Logging: Restored and deprecated a deleted function and tweaked the affected names
#preflight 62c84b80b3789302b1ebd675
#rb Zousar.Shaker
#rnx
#fyi Jack.Porter

[CL 21009006 by Devin Doucette in ue5-main branch]
2022-07-08 12:23:44 -04:00
Ben Marsh
06c12ca8e6 Fix PVS Studio warning (resource leak).
#preflight none
#fyi Steve.Robb

[CL 21006145 by Ben Marsh in ue5-main branch]
2022-07-08 09:28:44 -04:00
chris constantinescu
e90997b34e Catch2 - mini module cleanup
#preflight 62c793827e606620fd304713
#rb Jerome.Delattre

[CL 21004901 by chris constantinescu in ue5-main branch]
2022-07-08 06:55:54 -04:00
Jack Porter
e5cba9bf11 Replace uses of master in OutputDeviceRedirector
#jira UE-158659
#rb Florin.Pascu
#preflight 62c7e8666003a9b045822d62

[CL 21004289 by Jack Porter in ue5-main branch]
2022-07-08 04:33:35 -04:00
steve robb
73660ee955 Fix for LaunchFixProjectPathCase() assuming that TCHARs are WIDECHARs and doing in-string replacement with them.
Fix for FOutputDeviceStdOutput::Seralize() of TCHARs as UTF-8.

#rb devin.doucette
#jira UE-132142
#preflight 62c561d82f2d046918df0672

#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20965286 via CL 20965301 via CL 20965311
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 20966411 by steve robb in ue5-main branch]
2022-07-06 10:10:56 -04:00
paul chipchase
e091159583 Add a core delegate which is broadcasts once GWarn and GError are first set up
#rb Devin.Doucette
#rnx
#preflight 62bc2d99ee7cb716b4335e70

- This allows programs to override GWarn and GError before any messages are passed through them by FEngineLoop::PreInit.

#ROBOMERGE-AUTHOR: paul.chipchase
#ROBOMERGE-SOURCE: CL 20872257 via CL 20872260 via CL 20872263
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20876922 by paul chipchase in ue5-main branch]
2022-06-29 12:29:08 -04:00
Andriy Tylychko
b679977006 moved destruction of GThreadPool to happen later as there're late ThreadPool tasks still not finished
#jira UE-157069
#preflight 62b97a210b28aa423f45ae93
#rb francis.hurteau

[CL 20828745 by Andriy Tylychko in ue5-main branch]
2022-06-27 06:13:34 -04:00
Andriy Tylychko
a118cdcf89 moved GThreadPool creation earlier to be right after TaskGraph initialization and before FDelayedAutoRegisterHelper::RunAndClearDelayedAutoRegisterDelegates call as it can launch a task that expects GThreadPool already availalble. the problem was caught by TSAN
#preflight 62b1f5b1da272a658f565e4e
#rb danny.couture

[CL 20774388 by Andriy Tylychko in ue5-main branch]
2022-06-22 10:35:29 -04:00
maxwell hayes
33c137c1c9 Fix for sounds not being previewable in shipping editor configurations. (Audio editor asset actions not getting registered)
#rb
#preflight 62b0b4832405b4ac9e6d38cb

#ROBOMERGE-OWNER: maxwell.hayes
#ROBOMERGE-AUTHOR: maxwell.hayes
#ROBOMERGE-SOURCE: CL 20742355 via CL 20742504 via CL 20742654 via CL 20745895 via CL 20745907
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v970-20704180)

[CL 20751406 by maxwell hayes in ue5-main branch]
2022-06-20 23:41:03 -04:00
steve robb
fd2a0b1e20 Removal of TEXT literal concatenations, which doesn't work in UTF-8 mode.
#rb devin.doucette
#jira UE-132142
#preflight 62a8748fa76c84377748036b

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20647443 via CL 20648283 via CL 20648315
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20651786 by steve robb in ue5-main branch]
2022-06-14 12:46:34 -04:00
jordan cristiano
be7e5f467c Auto enable "stat namedevents" when a razor or trace capture is in progress.
Functionality is controlled by stats.AutoEnableNamedEventsWhenProfiling, default disabled in engine. Enabled in fort.

#rb evgenii.babinets, andrew.ladenberger
[FYI] will.fissler, ethan.edwards, ben.woodhouse

#ROBOMERGE-OWNER: jordan.cristiano
#ROBOMERGE-AUTHOR: jordan.cristiano
#ROBOMERGE-SOURCE: CL 20460932 via CL 20460963 via CL 20461526 via CL 20461540
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v952-20449836)

[CL 20463233 by jordan cristiano in ue5-main branch]
2022-06-01 20:37:17 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
ben woodhouse
4e7b5d80ff Use the local player to exec csvexeccmds if available, falling back to GEngine->Exec if we don't have one. This allows us to execute commands which require a player, such as HideHUDElement
#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 20429825 via CL 20429839 via CL 20429846
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20430257 by ben woodhouse in ue5-main branch]
2022-05-30 08:36:08 -04:00
devin doucette
b2a07ea03e DDC: Merge from UE5/Main
#preflight 6288ff678828ea88c8af7034
#preflight 628ab5d93246d5019db76ed2
#rb none
#rnx

#ROBOMERGE-OWNER: devin.doucette
#ROBOMERGE-AUTHOR: Devin.Doucette
#ROBOMERGE-SOURCE: CL 20353148 via CL 20353832 via CL 20353839
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20355348 by devin doucette in ue5-main branch]
2022-05-24 16:40:25 -04:00
ionut matasaru
7a9c217ab6 Improved scoped cpu timers for FEngineLoop (add cpu timers for FEngineLoop::Tick, HeartBeat, TickHotfixables and TickRenderingTickables). Also added a scoped cpu timer for FStats::AdvanceFrame.
#rb Johan.Berg
#preflight 62874a80c057ee6e23f18437

[CL 20292398 by ionut matasaru in ue5-main branch]
2022-05-20 06:11:55 -04:00