Commit Graph

91 Commits

Author SHA1 Message Date
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
henrik karlsson
8f895fef35 Added includes needed after removing includes in headers
#preflight 6360b63e41625be270a6e464
#rb none

[CL 22888775 by henrik karlsson in ue5-main branch]
2022-11-01 15:14:15 -04:00
Alexis Matte
194cafbd1b Interchange: New created package now have the "PKG_NewlyCreated" flag set.
#jira none
#rb jeanmichel.dignard
#rnx
#preflight 635c04510e7b78e504b364ae

[CL 22830591 by Alexis Matte in ue5-main branch]
2022-10-28 12:38:22 -04:00
jeanluc corenthin
8c0b302870 Interchange:
- Fixed crash when trying to load an asset outside the grame thread.
- Fixed textures being listed in Import into level

#jira UE-167999
#rb jeanmichel.dignard
#preflight 635310f1e6096564af92b2d2
#lockdown jeanmichel.dignard

[CL 22712187 by jeanluc corenthin in ue5-main branch]
2022-10-22 15:35:59 -04:00
charles bloom
197ee6e3fc fix UInterchangeManager::GetInterchangeManager crashing in app exit
#fyi alexis.matte
#preflight 635437eb7261e565c4ca1a31
#rb none

[CL 22711634 by charles bloom in ue5-main branch]
2022-10-22 14:47:14 -04:00
alexis matte
54bfe8a208 Interchange: Fix analytic event name to not be dynamic
#jira UE-167779
#rb jeanmichel.dignard
#lockdown jeanmichel.dignard
#preflight 6351a3d4777a77c440f91401
#rnx

[CL 22710506 by alexis matte in ue5-main branch]
2022-10-22 07:14:36 -04:00
alexis matte
84f56f9db8 Interchange: fix editor reimport callback not called.
#jira UE-167872
#rb julien.stjean
#preflight 6352d2e27261e565c4816c4b
#lockdown jeanmichel.dignard
#rnx

[CL 22710505 by alexis matte in ue5-main branch]
2022-10-22 07:14:31 -04:00
julien stjean
2199f04bd1 Fixed the invalid reimport behavior for the textures when using interchange.
#jira UE-167872
#rb Alexis.Matte
#rnx
#preflight 6351c2083a547c3da32f74a7
#lockdown jeanmichel.dignard

[CL 22683413 by julien stjean in ue5-main branch]
2022-10-21 01:04:58 -04:00
alexis matte
2b6c3c91e9 Fix PVS static analysis
#jira UE-166986
#rb jeanmichel.dignard
#rnx
#lockdown jeanmichel.dignard
#preflight 6350387e2a190921f8c911d9

[CL 22635730 by alexis matte in ue5-main branch]
2022-10-19 15:34:49 -04:00
alexis matte
fe35eb697a Interchange:
- Skeletal mesh is now import using the skeletalmesh compile system to make sure all properties are locked and will stall another thread trying to access them.
---- This fix multiple crash if a viewer display the skeletal mesh and use some properties.
- Remove animation pipeline ensure(no skeleton) if we import with force static mesh and there is some translated animation node
- Fix crash when importing static mesh and the get mesh payload return an empty mesh description
- Reimport of skeletalmesh is not calling anymore postedit change if we reimport with interchange, interchange will call it in a post edit step.
---- This fix multiple crash if a viewer display the bones of the re-import skeletal mesh.
General:
- Reimport handler now have a reimport async version so the caller can control if a reimport is done asynchronously or synchronously

#jira UE-166986
#rb danny.couture , jeanluc.corenthin
#rnx
#lockdown jeanmichel.dignard
#preflight 634f61fdec03b54e9cdfe0bf

[CL 22634973 by alexis matte in ue5-main branch]
2022-10-19 15:15:54 -04:00
jeanluc corenthin
9fa33f222c Fixed warning when deleting assets imported with interchange
#jira UE-163623
#rb alexis.matte
#preflight 6347231eb757820b7afc93d9
#lockdown jeanmichel.dignard

[CL 22512900 by jeanluc corenthin in ue5-main branch]
2022-10-13 17:37:47 -04:00
alexis matte
aae298f7de Interchange: Reimport with new file need to use the interchange picker if the file was imported with interchange.
#jira UE-166911
#rb jeanluc.corethin
#rnx
#preflight 6346ed7dfa31324bb146302c
#lockdown jeanmichel.dignard

[CL 22508984 by alexis matte in ue5-main branch]
2022-10-13 14:29:07 -04:00
alexis matte
355584f02a Add a warning in the log if the user try to re-import a texture that change the uasset type. And do not allow the reimport to be done.
We cannot delete the asset since it is reference by the import module and the texture factory.

#jira UE-165887
#rb julien.stjean
#rnx
#preflight 63408e73174b13865737aad6
#lockdown jeanmichel.dignard

[CL 22412805 by alexis matte in ue5-main branch]
2022-10-07 19:45:32 -04:00
alexis matte
57a700a1bd The attribute storage serialize FName with FString and must change the data only if we are loading. The reference archive do not have any flag for loading or saving, so pattern like if(IsSaving)... else ... is dangerous if the data is change in the else part.
#jira UE-165226
#rb jeanluc.corenthin
#rnx
#preflight 63373e90c37844870a26ce5f

[CL 22284194 by alexis matte in ue5-main branch]
2022-09-30 19:23:46 -04:00
andrew davidson
970f8f6a18 Non-Engine module public header truncation fixes to reduce noise when compiling with truncation warnings
#jira UE-160823
#rb dave.jones2, zak.middleton
#preflight 6336a3ecc37844870af8b119

[CL 22271698 by andrew davidson in ue5-main branch]
2022-09-30 11:36:06 -04:00
alexis matte
37bc86a319 Make sure auto save is disabled when interchange is working
#jira UE-165321
#rb danny.couture
#preflight 6334551fb20e73a098fc803a
#rnx

[CL 22261395 by alexis matte in ue5-main branch]
2022-09-29 20:57:51 -04:00
marc audy
311f7464bf Updated ../Engine/Source/Runtime/... to inline gen.cpp files
Before:
3648 unity files
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds

After:
3548 unity files
Total CPU Time: 46643.828125 s
Total time in Parallel executor: 486.06 seconds

#jira
#preflight

[CL 22173263 by marc audy in ue5-main branch]
2022-09-24 13:57:58 -04:00
alexis matte
227227d8d7 Make Interchange always on by default
#jira none
#rnx
#rb jeanmichel.dignard
#preflight 632ca990e23e50651b4caa08

[CL 22148323 by alexis matte in ue5-main branch]
2022-09-22 18:58:24 -04:00
alexis matte
d988d56da0 Interchange: Refactor how reimport find the matching data when there is multiple asset in a source file.
#jira none
#rnx
#rb jeanmichel.dignard
#preflight 632a7fee9840225da2a96466

[CL 22113958 by alexis matte in ue5-main branch]
2022-09-21 11:36:02 -04:00
jeanmichel dignard
fd77a35bf8 Interchange: When canceling a multi file import, canceling at any point will cancel all queued imports.
#jira UE-159458
#rb alexis.matte
#preflight 6328e323f87253e021dd6d9e

[CL 22088596 by jeanmichel dignard in ue5-main branch]
2022-09-20 00:46:55 -04:00
alexis matte
5f64efbfed Fix re-import with new file if there is other texture assets next to the assets we re-import that already use the same sourcefile.
#jira none
#rnx
#rb jeanmichel.dignard
#preflight 6328bdb29840225da2242a67

[CL 22087355 by alexis matte in ue5-main branch]
2022-09-19 22:28:43 -04:00
jeanmichel dignard
45cd0e3c93 Interchange
- Ported the new DDS import code from UTextureFactory to Interchange.
- Added the option to only parse the header in FDDSFile.
- Added support for texture cube arrays and volume textures.
- Dump warnings and errors in the log at the end of the import.

#jira UE-152766
#rb alexis.matte, charles.bloom
#preflight 6320c54f506f1a33e061e164

[CL 21991495 by jeanmichel dignard in ue5-main branch]
2022-09-13 16:24:03 -04:00
jeanmichel dignard
5f28e2a19e Interchange error handling
- Added a generic error message when we fail to retrieve a texture payload.
- Added error messages in the GLTF, OBJ and IES translators.
- Skip over invalid imported objects in the completion task so that we don't try to posteditchange them and we don't log a success.
- Display the correct icon for the "import done" notification based on if we have a success message or not.

#jira UE-152395
#rb alexis.matte
#preflight 631b88ca354826f8b3b5014a

[CL 21927409 by jeanmichel dignard in ue5-main branch]
2022-09-09 16:27:22 -04:00
alexis matte
862785cc6e Interchange: Move files out of experimental
#jira none
#rb jeanmichel.dignard
#rnx
#preflight 631b7b3cec45fbf3d7807ee1

[CL 21927016 by alexis matte in ue5-main branch]
2022-09-09 16:13:32 -04:00
alexis matte
0047e0dcf4 Move all interchange code files under experimental folder.
#jira UE-133267
#rb Julien.StJean
[FYI] richard.talbotwatkin
#rnx

#ROBOMERGE-AUTHOR: alexis.matte
#ROBOMERGE-SOURCE: CL 18018188 in //UE5/Release-5.0/... via CL 18018406 via CL 18018624
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v885-17909292)

[CL 18018864 by alexis matte in ue5-main branch]
2021-11-02 10:31:06 -04:00