[FYI] matthew.booth
[REVIEW] [at]phil.popp [at]buzz.burrowes [at]charlie.huguenard [at]jake.burga
#tests AudioQA AQ_AudioBus_MetaSounds map, EngineTest test list "All Tests" group "Audio" search "audio bus"
[CL 27524115 by nicholas howe in ue5-main branch]
* Moved dllexport from type to methods/staticvar in all Engine runtime code. This improves compile times, memory and performance in dll builds
[CL 26082269 by henrik karlsson in ue5-main branch]
Audio Bus Reader Node more accurately calculates how many samples it needs before it can start popping.
Reader node has a CVar timeout on how long it'll wait for samples (whereas it used to calculate a huge timeout value that I suspect was erroneous). In theory the samples should always become available even with an infinite timeout.
The Metasound generator's BuilderTask's completion is ensured at the beginning of FMetasoundGenerator::OnGenerateAudio. This prevents the mixer, writer and reader nodes from getting out of sync in terms of samples output and input.
FMixerAudioBus::MixBuffer doesn't try to cache any samples and just uses PopAudio and PushAudio directly on its mixer and splitter.
FPatchOutput::WaitUntilNumSamplesAvailable no longer has a race condition and an attempt has been made to improve thread-safety in FPatchOutput.
#jira UE-170575
#rb phil.popp
#preflight 63fcbfe2a134e0b059c64c76
[CL 24427705 by nicholas howe in ue5-main branch]
Adds a metasound node that sends its audio input to an audio bus.
Modifies the audio mixer interface to support the node.
FMixerSourceManager::StartAudioBus no longer sets bIsPlaying to false on sources that use an audio bus when the audio bus starts.
FMixerAudioBus::MixBuffer mixes its patch inputs into its MixedSourceData buffer, so that the patch input data is available when CopyCurrentBuffer is used to retrieve the mix.
[REVIEW] [at]aaron.mcleran [at]buzz.burrowes [at]phil.popp
#preflight 6372639c5368a3230a4ed041
[CL 23123823 by nicholas howe in ue5-main branch]
- Add missing exponential factor to Modulation generator
- Fix bounds restriction calculation for expontential factor
- Add LFO ResetPhase implementation to override initial location in oscilator on rising edge where necessary (for modulation LFO, user range limited to unipolar but hardly ever wants to start at midpoint).
- Add bipolar option to avoid oneshot/bipolar conflation for certain types of LFOs
- Add back implementation for 5.1 deprecated function to avoid breaking licensees
#rb phil.popp
[REVIEW] phil.popp
#jira UE-127886
#preflight 6346eed9b757820b7ae99b76
[CL 22483928 by rob gay in ue5-main branch]
