Commit Graph

65 Commits

Author SHA1 Message Date
kerim borchaev
4051ea9313 [Solidworks] Fixed deletion of sub-component of a sub-assembly
#jira UE-185166
#preflight 6474bb4db310540a8dfe9c85
#rb JeanLuc.Corenthin

[CL 25671691 by kerim borchaev in ue5-main branch]
2023-05-30 01:02:49 -04:00
kerim borchaev
c263c34621 [Solidworks] Deleted sub-assemblies are removed from Datasmith scene on sync
#jira UE-180381
#preflight 6450f2ddee56ca4c24cd7bf1
#rb benoit.deschenes

[CL 25303928 by kerim borchaev in ue5-main branch]
2023-05-02 13:09:05 -04:00
ionut matasaru
3d7c0e8440 UBT: Removed deprecated TargetInfo::bUseMallocProfiler toggle in Source/Programs.
#jira UE-141779
#rb Joe.Kirchoff
#rb Johan.Berg
#preflight 64380aea7a00790bfd116430

[CL 25101875 by ionut matasaru in ue5-main branch]
2023-04-19 04:15:59 -04:00
kerim borchaev
149d0a4228 [Solidworks] Change naming of configurations in Variant Manager
#jira UE-181452
#preflight 64253e2ab72410fc17904769
#rb benoit.deschenes

[CL 24910882 by kerim borchaev in ue5-main branch]
2023-04-04 10:53:50 -04:00
kerim borchaev
6fc022519a [Solidworks] Fixed AutoSync MaterialUpdater crash and other issues
- replaced separate thread to check for material updates with iterative checkinbg in the main thread on idle

- this fixed random crashes due to race conditions

- slightly improved speed of registering material changes (e.g. from minute to under seconds for some real models)

#jira UE-177970
#preflight 641c1110ee0aed134706f644
#rb benoit.deschenes

[CL 24775286 by kerim borchaev in ue5-main branch]
2023-03-24 02:09:20 -04:00
kerim borchaev
3ffa29fab3 [Solidworks] Exploded Views exported for each of configurations as additional variants
#jira UE-179234
#preflight 641203b1924f0cb722306c03
#rb benoit.deschenes

[CL 24685421 by kerim borchaev in ue5-main branch]
2023-03-17 02:41:26 -04:00
kerim borchaev
d3eb45da3c [Solidworks] Fixed child components variant transforms
- relative transform was canculated incorrectly
- typesafety for converter trasform
- added log for transforms debugging

#jira UE-179234
#preflight 6408b8cdcf5fe1e28cdb3575
#rb benoit.deschenes

[CL 24609491 by kerim borchaev in ue5-main branch]
2023-03-13 01:18:41 -04:00
kerim borchaev
79aacf614f [Solidworks] Instancing for same part meshes
- identical meshes exported as the same Datasmith static mesh

#jira UE-171372
#preflight 64018575c13b7130d2b1dce4
#rb benoit.deschenes

[CL 24523174 by kerim borchaev in ue5-main branch]
2023-03-06 10:55:32 -05:00
kerim borchaev
d1edb0a0e1 [Solidworks] Fixed crash exporting empty Part component
#jira UE-177848
#preflight 63f3670761378b7ea0fb30c8
#rb JeanLuc.Corenthin

[CL 24333503 by kerim borchaev in ue5-main branch]
2023-02-20 23:32:28 -05:00
christopher waters
6a4206d490 Removing bad Launch include paths from programs.
[CL 24328631 by christopher waters in ue5-main branch]
2023-02-20 17:39:13 -05:00
kerim borchaev
de540d62e8 [Solidworks] Fixed Datasmith plugin preventing proper shutdown of Solidworks
- repro: run SW, make Datasmith addin enabled, open a model and Sync it, then exit SW. Expected: Solidwokrs process exits(check in TaskManager as it can have its window destroyed but not process itself).

#jira none
#preflight 63ee26b77d2ec3d2fda510e6
#rb JeanLuc.Corenthin

[CL 24277710 by kerim borchaev in ue5-main branch]
2023-02-16 23:27:46 -05:00
kerim borchaev
06a9e3796f [Solidworks] Unused materials not left in synced/exported scene
- fixed export of materials that are not present in the active configuration when exporting configuration

#jira UE-165103
#preflight 63ebc094205b5ccbc7e8277d
#rb JeanLuc.Corenthin

[CL 24230430 by kerim borchaev in ue5-main branch]
2023-02-15 10:23:01 -05:00
kerim borchaev
a9d395474e [Solidworks] Fixed The color of the component is being changed when pressing Datasmith sync
#jira UE-149553
#preflight 63e62500ce1e17960b0ddc59
#rb JeanLuc.Corenthin

[CL 24168957 by kerim borchaev in ue5-main branch]
2023-02-12 23:06:16 -05:00
kerim borchaev
cf7b93a9da [Solidworks] Fixed exporter not installing if only 2023 version is available
#jira UE-176111
#preflight 63e23bd6786751d1e0e673fc
#rb JeanLuc.Corenthin
#lockdown jeanmichel.dignard

[CL 24106198 by kerim borchaev in ue5-main branch]
2023-02-09 16:20:09 -05:00
kerim borchaev
22abd83ca1 [Solidworks] Infinite reimport after deleting a component auto sync is toggle
- fixed case when change in material was detected when no material were present
- also fixed not detecting material modifications

#jira UE-172414
#preflight 63e1427a797b029c0a67798d
#rb JeanLuc.Corenthin
#lockdown jeanmichel.dignard

[CL 24106191 by kerim borchaev in ue5-main branch]
2023-02-09 16:20:02 -05:00
kerim borchaev
5af38bdc3f [Solidworks] Remove the -1 on spot light scale
#jira UE-170046
#preflight 63e396e93c44c83044d8b021
#rb JeanLuc.Corenthin
#lockdown jeanmichel.dignard

[CL 24100234 by kerim borchaev in ue5-main branch]
2023-02-09 12:11:35 -05:00
kerim borchaev
f5de251336 [Solidworks] Make an actor invisible in the Datasmith scene tree on export if it's suppressed in the selected config
#jira UE-175176
#preflight 63dd3d4714326f9a403dd814
#rb JeanLuc.Corenthin
#lockdown jeanmichel.dignard

[CL 24049376 by kerim borchaev in ue5-main branch]
2023-02-07 10:49:40 -05:00
kerim borchaev
16baa2d2d6 [Solidworks] Fixed Part materials in multiple configurations
- searching for actual RenderMaterial for each Body/Feature of the part using entity's Appearance(somewhat alternale api to RenderMaterial). In order to deal with api flow which doesn't return corrent entities assigned to a RenderMaterial in active configuration

#jira UE-135616
#preflight 63da9718dd02983776fa37e3
#rb JeanLuc.Corenthin
#lockdown jeanmichel.dignard

[CL 23991071 by kerim borchaev in ue5-main branch]
2023-02-03 11:00:35 -05:00
kerim borchaev
f637bbeaa6 [Solidworks] Stability fixes
- Fixed Sync/Export when plugin enabled manually(not on Startup)
- Fixed(temporary) plugin crashing after being re-enabled
- DirectLink source not staying alive anymore when closing last document or disabling the plugin

#jira UE-160288
#preflight 63d77378ba4fadeef0dbfc8e
#rb JeanLuc.Corenthin
#lockdown jeanmichel.dignard

[CL 23929322 by kerim borchaev in ue5-main branch]
2023-01-31 12:07:45 -05:00
kerim borchaev
6d42af6b29 [Solidworks] display states for configurations
- added vast of material logging - it's a complicated in the api and currently in the code so should help with future debugging(and already helped)

- fixed another potential race condition that I've overlooked previously

#jira UE-171370
#preflight 63cffe0294644f3e8e28a4d3
#rb benoit.deschenes

[CL 23848150 by kerim borchaev in ue5-main branch]
2023-01-25 10:22:40 -05:00
kerim borchaev
06f70ac5c5 [Solidworks] Refactor - ComVisible removal
- made ComVisible false by default  - simplifies code and doesn't expose unneeded types

#jira none
#preflight 63c6eb350b358b97d1abb126
#rb benoit.deschenes

[CL 23826729 by kerim borchaev in ue5-main branch]
2023-01-23 23:01:56 -05:00
kerim borchaev
56979c1da6 [Solidworks] Fixed potential race condition exporting meshes; refactor
- In ExportMesh left to threaded execution only construction of DatatasmithMesh from extracted data and ExportDatasmithMesh itself

- refactored use of Mesh names all over to make more clear distintion between Datasmith names and names built from SW component names

#jira none
#preflight 63c56f1d7763631ba1b7ca57
#rb benoit.deschenes

[CL 23740158 by kerim borchaev in ue5-main branch]
2023-01-17 12:35:14 -05:00
kerim borchaev
3595766d13 [Solidworks] Assembly Part configurations
- Part component included into assembly with different own configurations creates different meshes for corresponding variants

- Reworked plugin to Separate DirectLink session from Export session


#jira UE-171368 UE-171369
#preflight 63bfad8af02e72c08c91be3a
#rb benoit.deschenes

[CL 23727081 by kerim borchaev in ue5-main branch]
2023-01-16 00:18:46 -05:00
kerim borchaev
feda8996be [Solidworks] Reworked plugin to avoid modyfing suppression state of components
- all configuration's meshes and materials collected and exported when the configuration is activated

- configurations are activated only once now(resulting ~x2 export speedup as configuration switch is among slowest operation)

- no component is being unsuppressed(and then suppressed) means another time saver

- components exported only when they are unsuppressed in any configuration, meaning no export of unused components.

- Elevation_test is from 78 seconds export down to 11(measured in Debug but anyways switching state configs/suppression was the main time waste)

#jira UE-171367
#preflight 63982ba72540a78d270675f0
#rb benoit.deschenes

[CL 23513940 by kerim borchaev in ue5-main branch]
2022-12-14 12:52:44 -05:00
kerim borchaev
5cc9aefb01 [Solidworks] fixed animation euler angles translation to Unreal
- Inverted X and Z rotations as conversion of handedness affected these(Y rotation not affected because that coordinate is negated itself)

#jira UE-159510
#preflight 6388aac1766a2aeed2d7b4a4
#lockdown jeanmichel.dignard
#rb benoit.deschenes

[CL 23356035 by kerim borchaev in ue5-main branch]
2022-12-01 13:24:12 -05:00