Why? These buttons have to behave differently when there are unresolved conflicts remaining.
Note that it isn't possible to add a build dependency from a module in /Engine to the Skein module in /Engine/Plugins, hence the cvar/ccmd approach.
#rb manuel.lang, marco.anastasi
#rnx
[CL 28220661 by wouter burgers in ue5-main branch]
Skein, the only provider that returns 'true' for 'UsesSnapshots()' requires the user to be at head when doing a check-in operation, or the check-in will fail.
This is enforced within the plugin, not the CLI, by performing an FSync prior to doing an FCheckIn. It's not easy to do the sync within the CLI as part of the check-in as the editor doesn't release its file locks when doing an FCheckIn, causing syncs to fail.
For this, a code path was introduced in SourceControlMenuHelpers that triggers a sync before triggering the check-in, when clicking the 'Check In Changes' button visible in the bottom right of the editor within UEFN.
However, this approach fails if other code paths in the editor call ChoosePackagesToCheckIn directly. This is known to happen for the MainFrame's "Submit Content" action, which was therefore disabled for Skein in #26272334, but the issue could be more widespread.
To provide a definitive fix for this issue, the sync is moved to within ChoosePackagesToCheckIn, triggered only when 'UsesSnapshots()' is true, which effectively means Skein only.
#rnx
[CL 27582511 by wouter burgers in ue5-main branch]
* Closed the suggestion box when using the keyboard shortcut (tilde key, usually) to switch between status bar console input to output log console input
* Auto-adjusted the editable text box size so that we better see the content for long console commands
#rb sebastian.arleryd
#preflight 647715d80848b7126daffd3f
[CL 25700377 by jonathan bard in ue5-main branch]
Fixed issue that prevented deleted objects from being restored on Revert All
As a collateral, fixed issue that caused not saving deleted files during Delete workflow to result in errors after sync
As a collateral, fixed issue that caused added and saved files to disappear after Sync Latest
#rb wouter.burgers, stuart.hill
[FYI] brooke.hubert, manuel.lang
#preflight 63ed15e5c9692d7c04ea4188
[CL 24251962 by marco anastasi in ue5-main branch]
- Side panel no longer compressed
- Name changed to "View Changes"
#jira UE-175840
#rb ronald.koppers
#preflight 63daeceb4965eb8c33d456e5
#lockdown jeanmichel.dignard
[CL 23961626 by zach rammell in ue5-main branch]
Added LLM tags for many allocations in Editor Framework components. Used best judgement for use of existing tags.
Added EngineMisc/MessageLog tag to capture allocations that the logger does since it is a well defined core system that all other modules tend to use. This will pull the disparate allocations within the logger attributed to a lot of other tags into it's own bespoke tag.
Added a LevelEditor tag since it is also a fairly large component. There isn't a generic 'Editor' tag, though I think this might be worthwhile to explore as there are other editors in UEd (PropertyEditor for example).
#jira UE-153282
#preflight 63d9872cba4fadeef0acc846
#rb booke.hubert ronald.koppers
[CL 23938402 by logan buchy in ue5-main branch]
A scoped class is added to retain and restore all camera views which is used when we reload or sync packages.
#preflight 63d2766de55deff624ed1b5a
[CL 23867883 by stuart hill in ue5-main branch]
* Sync Latest no longer listing and reloading all packages when the source control provider provides a sync preview functionality. When a Sync Preview is available, Sync Latest unloads only the files that are going to be overwritten by the sync operation, and then reloads them and the world
* Refactored Revert All operation to improve performance
* Revert All no longer lists and reloads all packages when the source control provider provides a sync preview functionality. Instead it unloads only the files that may be overwritten by the revert operation (i.e. submittable files), and then reloads them and the world
* Replaced RevertAndReloadAllPackages with RevertAndReloadWorld, no longer listing and reloading all packages (see https://p4-swarm.epicgames.net/reviews/23244245/)
This review is a combination of the two archived reviews https://p4-swarm.epicgames.net/reviews/23736137 and https://p4-swarm.epicgames.net/reviews/23736282
#rb wouter.burgers, stuart.hill, brooke.hubert, francis.hurteau
#preflight 63c9c7786a00f3cc8ead6779
[CL 23796067 by marco anastasi in ue5-main branch]
