Commit Graph

55 Commits

Author SHA1 Message Date
han chu
2c25f2c11e New feature:
Unsaved asset drag-and-drop handler: When unsaved assets are selected and then dropped onto a changelist entry, they are checked out, saved, and then moved to the target changelist.

#jira UE-181906
#rb @zach.rammell

[CL 26976967 by han chu in ue5-main branch]
2023-08-09 18:41:28 -04:00
aditya ravichandran
3c3813c55a SceneOutlinerTreeItemSCC: Fix a crash on shutdown when an item tried to unregister from the UncontrolledChangelists module in its destructor after the module was unloaded
#jira UE-188261
#rb JeanMichel.Dignard

[CL 25902866 by aditya ravichandran in ue5-main branch]
2023-06-09 16:10:15 -04:00
bryan sefcik
aa7d39355e [UncontrolledChangelists] Removed public dependency on UnrealEd to break circular dependency "UncontrolledChangelists -> UnrealEd -> UncontrolledChangelists"
#preflight 6436c3f20c4277fc0ba1c6a8

[CL 25009936 by bryan sefcik in ue5-main branch]
2023-04-12 13:02:47 -04:00
zach rammell
bc0e3c125e Fix FUncontrolledChangelistsModule::OnAssetAddedInternal()
PR #10272
#rb zach.rammell
#lockdown jeanmichel.dignard
#preflight 64223aaf973e609670cea4fc
#jira UE-180948

[CL 24821278 by zach rammell in ue5-main branch]
2023-03-28 12:38:53 -04:00
aditya ravichandran
92b43f0f43 Optimization for getting the uncontrolled file status in the Outliner
[CL 24708804 by aditya ravichandran in ue5-main branch]
2023-03-18 22:54:54 -04:00
bob tellez
f2dd06e65e #UE Disable expensive uncontrolled changelists asset registry OnAssetAdded function
[FYI] luc.eygasier

[CL 24667987 by bob tellez in ue5-main branch]
2023-03-16 01:40:40 -04:00
christopher waters
73c74eaf42 Removing redundant include paths:
- PublicIncludePaths.Add(ModuleDirectory + "/Public");
- PrivateIncludePaths.Add("<module name>/Private");

#preflight 63ef03623c1eb56f057db7de

[CL 24285283 by christopher waters in ue5-main branch]
2023-02-17 12:45:29 -05:00
marco anastasi
b29f599449 * Refactored Sync Latest operation to improve performance
* Sync Latest no longer listing and reloading all packages when the source control provider provides a sync preview functionality. When a Sync Preview is available, Sync Latest unloads only the files that are going to be overwritten by the sync operation, and then reloads them and the world

* Refactored Revert All operation to improve performance
* Revert All no longer lists and reloads all packages when the source control provider provides a sync preview functionality. Instead it unloads only the files that may be overwritten by the revert operation (i.e. submittable files), and then reloads them and the world
* Replaced RevertAndReloadAllPackages with RevertAndReloadWorld, no longer listing and reloading all packages (see https://p4-swarm.epicgames.net/reviews/23244245/)

This review is a combination of the two archived reviews https://p4-swarm.epicgames.net/reviews/23736137 and https://p4-swarm.epicgames.net/reviews/23736282

#rb wouter.burgers, stuart.hill, brooke.hubert, francis.hurteau
#preflight 63c9c7786a00f3cc8ead6779

[CL 23796067 by marco anastasi in ue5-main branch]
2023-01-20 15:31:16 -05:00
stuart hill
ecd02d133c For Source Control systems which don't support Uncontrolled Changelists, disable the entire Uncontrolled Changelists module, rather than just UI elements (as was done in CL 23490912).
This prevents uncontrolled icons being shown in the outliner when not supported by the current source control.

#rb brooke.hubert, Marco.Anastasi, wouter.burgers
#preflight 63c54df6b0652247509d67bb

[CL 23729713 by stuart hill in ue5-main branch]
2023-01-16 10:48:10 -05:00
marco anastasi
d28eb652fb Implemented Asset Revert functionality from Scene Outliner.
Fixed 'Cannot revert umaps with Skein' by reloading all assets when attempting to revert a map
Implemented 'Revert All' button

#rb patrick.enfedaque, wouter.burgers, stuart.hill, manuel.lang
[FYI] francis.hurteau, brooke.hubert
#preflight 6388f51d4c3ce8ae5dbfb18f

#preflight 639340545c5308d18c28b967

[CL 23475314 by marco anastasi in ue5-main branch]
2022-12-11 23:09:22 -05:00
aditya ravichandran
338fb4be16 Replace some remaining instances of "Source Control" with "Revision Control" in text
#rb JeanMichel.Dignard, Robb.Surridge

[CL 23251078 by aditya ravichandran in ue5-main branch]
2022-11-23 12:08:16 -05:00
aditya ravichandran
f8b7ee5555 Replace any instances of "Source Control" with "Revision Control" in text in the Editor
#rb JeanMichel.Dignard, Robb.Surridge
#preflight 637d180efa348e8480e8837e

[CL 23250808 by aditya ravichandran in ue5-main branch]
2022-11-23 11:57:50 -05:00
aditya ravichandran
7be93c5466 Outliner:
Add a filter and column to show Unsaved Assets.
Add a filter and modify the source control column to show uncontrolled assets
#jira UE-168231
#rb patrick.laflamme
#preflight 6361417a397c7af8966cec38

[CL 22890180 by aditya ravichandran in ue5-main branch]
2022-11-01 16:02:53 -04:00
patrick enfedaque
ff9b96647f Uncontrolled Changelist: Optimization
- OnStateChanged sets a dirty flag, SaveState is performed on End of frame if needed.

#rb luc.eygasier, richard.malo
#preflight 63457ad3e76c1171e7f1a5a3
#rnx

[CL 22467213 by patrick enfedaque in ue5-main branch]
2022-10-11 18:30:44 -04:00
rex hill
dde95823ae Add insights scope to a function that requires optimization
#preflight skip

[CL 22424987 by rex hill in ue5-main branch]
2022-10-09 23:37:46 -04:00
patrick enfedaque
377869bfc1 Uncontrolled Changelist: deleted files support
- Deleted files will show up in the Uncontrolled Changelists when a Source Control provider is selected
- Deleted files won't show up if SCC is disabled but will still be tracked in case SCC is renabled

#jira UE-164493
#rb luc.eygasier
#preflight 633af0bcba39998ce83121b4

[CL 22322389 by patrick enfedaque in ue5-main branch]
2022-10-03 20:43:35 -04:00
patrick enfedaque
4e1dff0b87 Fix unsaved writable files appearing in Uncontrolled Changelist
- Files are now added to the reconcile list when marked writable
- They are later on added to the UC when they are saved (if they still are not checked out)

#rb luc.eygasier
#preflight 6336cfa7c37844870a040e20

[CL 22272829 by patrick enfedaque in ue5-main branch]
2022-09-30 12:24:14 -04:00
patrick enfedaque
aa180f6f09 Fix not being able to revert Uncontrolled Changelist changes with files not at head revision. (files were forced synched to proper revision but would stay in the UC)
- Add flag to SourceControlOperation to test modified status against synched revision (p4 #have)
- Use this new flag when testing for modifications in UncontrolledChangelist

#jira UE-165558
#rb luc.eygasier
#preflight 633633b7936ff7e3dcda5f92

[CL 22271768 by patrick enfedaque in ue5-main branch]
2022-09-30 11:39:49 -04:00
rex hill
fd010712d1 Fix UncontrolledChangelists warnings seen for cooked assets
#preflight 6331c24e0d6a7155ba356e3b
#rb luc.eygasier

[CL 22203037 by rex hill in ue5-main branch]
2022-09-27 06:54:18 -04:00
luc eygasier
abfd119ea2 Enabled Uncontrolled Changelists by default.
Adds setting to disable uncontrolled changelists.

#rb Patrick.Laflamme
#jira UE-163064
#preflight 6328649b8c3def91aa6d9576
#changelist validated

[CL 22086935 by luc eygasier in ue5-main branch]
2022-09-19 21:54:38 -04:00
luc eygasier
96f1950f5a Adds new uncontrolled changelist option to "Move Files To..." dialog.
#preflight 63284d978131e92d659351bf
#rb Patrick.Laflamme

#changelist validated

[CL 22084693 by luc eygasier in ue5-main branch]
2022-09-19 19:50:22 -04:00
luc eygasier
92a1bc7f30 Adds support for multiple uncontrolled changelists
* Add creation of new uncontrolled changelists
* Add modification of uncontrolled changelists description
* Add uncontrolled changelists deletion

#preflight 6318ebec980179553e9254aa
#jira UE-163065
#rb Patrick.Laflamme

[CL 21892780 by luc eygasier in ue5-main branch]
2022-09-08 09:19:01 -04:00
luc eygasier
1dcadd2e97 Moves FUncontrolledChangelist::Name to FUncontrolledChangelistState::Description.
#rb Patrick.Laflamme
#preflight 6318ac73f448dc6e585d5fbd
#jira UE-163065

[CL 21864892 by luc eygasier in ue5-main branch]
2022-09-07 18:11:16 -04:00
luc eygasier
c4dec1008a Adds Source Control File Dialog.
Displays source control file dialog when checkouting files is impossible during conversion from Uncontrolled Changelist to Changelist.

#preflight 630f740ce352708d444276e0
#rb Patrick.Laflamme

[CL 21727336 by luc eygasier in ue5-main branch]
2022-08-31 16:14:08 -04:00
luc eygasier
0cda7fc8ed Modifies revert operations in source control window to also reload packages.
Adds Source Control Helper method to perform a modular source control operation and reload the concerned packages

#rb Patrick.Enfedaque
#preflight 62fd4e63e64b1a510937890b
#changelist validated

[CL 21444877 by luc eygasier in ue5-main branch]
2022-08-18 13:03:11 -04:00