Commit Graph

72 Commits

Author SHA1 Message Date
rob gay
ecb39b4592 Migrate MetaSound editor input/output creation to builder API in preparation of supporting paged input literals
#jira UE-194160
#rb helen.yang
#tests automated in-editor, asset editor addition/removal of inputs/outputs via misc means
#rnx
[FYI] sondra.moyls

[CL 34882307 by rob gay in ue5-main branch]
2024-07-17 15:46:56 -04:00
rob gay
f691eda44c Moving page mutable calls to builds loading editor-only data (pages initially will be a non-runtime mutable feature on serialized MetaSound assets only, so locking down accordingly)
#jira UE-193188
#rb helen.yang
#rnx

[CL 34817438 by rob gay in ue5-main branch]
2024-07-15 13:25:53 -04:00
rob gay
984e2e7b7d MetaSound Template API fix-ups to support pages
#rb helen.yang
#rnx
#jira UE-194160

[CL 34726390 by rob gay in ue5-main branch]
2024-06-27 18:32:11 -04:00
rob gay
d4cc41a680 ClearDocument clean/fix-ups & bind page delegate to doc cache to ensure node & edge caches don't stick around post page removal
#rb helen.yang
#jira UE-194160
#rnx

[CL 34717339 by rob gay in ue5-main branch]
2024-06-27 14:21:49 -04:00
rob gay
af33f140d3 More Page Doc Builder API updates
#rnx
#jira UE-194160
#rb helen.yang

[CL 34575178 by rob gay in ue5-main branch]
2024-06-21 16:42:38 -04:00
rob gay
92e413738d Fix for Clang compiler warning. Minor feedback for const declaration of default page ID.
#rnx
#rb rob.gay

[CL 34485679 by rob gay in ue5-main branch]
2024-06-18 19:17:25 -04:00
AdricEpic
0976464d97 #1 Pages Checkpoint: Update BuilderAPI, associated delegates to support providing Pages
#rb helen.yang, phil.popp
#rnx
#jira UE-194160

[CL 34477958 by AdricEpic in ue5-main branch]
2024-06-18 16:47:21 -04:00
miro salminen
5996025756 [MetaSound] 'hide unconnected pins' action to nodes
#rb Rob.Gay
#jira UE-171027
#rnx

[CL 34452339 by miro salminen in ue5-main branch]
2024-06-18 04:15:33 -04:00
rob gay
2086df4308 Add ability to cache multiple document edge/node subcaches by PageID
#rb phil.popp
#jira UE-194160
#rnx

[CL 34379296 by rob gay in ue5-main branch]
2024-06-14 14:41:30 -04:00
rob gay
62681fc2d2 Fix issue with returning false if Access/DataType is already the correct value when being swapped
#jira UE-216538
#rnx
#rb rob.gay
[FYI] sondra.moyls

[CL 34247955 by rob gay in ue5-main branch]
2024-06-10 15:00:26 -04:00
miro salminen
05bbe75827 UE-171622
MetaSound inputs and variables should have right click (or CTRL+D) duplicate option
#wip
#rb helen.yang
#jira UE-171622
#rnx

[CL 34230796 by miro salminen in ue5-main branch]
2024-06-10 03:17:20 -04:00
rob gay
fb352f462e [Backout] - CL34086276
[FYI] miro.salminen
Original CL Desc
-----------------------------------------------------------------
[MetaSound]  'hide unconnected pins' action to nodes
#rb helen.yang
#jira UE-171027
#rnx

[CL 34148343 by rob gay in ue5-main branch]
2024-06-06 00:17:28 -04:00
miro salminen
6c98d2511a [MetaSound] 'hide unconnected pins' action to nodes
#rb helen.yang
#jira UE-171027
#rnx

[CL 34086303 by miro salminen in ue5-main branch]
2024-06-04 01:47:34 -04:00
rob gay
064e244218 - Make Version call to generate MetaSound Builder async GC-safe
- Misc clean-up
#rb phil.popp
#rnx
[FYI] helen.yang
#jira UE-216029

[CL 34017798 by rob gay in ue5-main branch]
2024-05-30 18:56:24 -04:00
rob gay
69725d945e - Checkpoint for Initial MetaSound Pages document model support
- Fix-ups for MS AssetManager leaking asset names if not registered by moving to MultiMap
- Fix-up for ResetBuilder call passing off initial delegates properly
- Make builders map mutation thread safe when loading assets async
#rnx
#tests -game, AudioQA, Unit Tests, Automated Tests
#rb phil.popp
#jira UE-194160

[CL 33983705 by rob gay in ue5-main branch]
2024-05-29 15:33:29 -04:00
rob gay
3c216f31cf Fix copy pasta when swapping inputs via MetaSoundBuilder API
#rb helen.yang
#rnx

[CL 33810463 by rob gay in ue5-main branch]
2024-05-21 17:18:40 -04:00
rob gay
90ab53e16e Fix node offset bug introduced in prior submission when creating a new MetaSound causing them to overlap
#jira UE-212739
#rb helen.yang
#tests Repro as provided in bug
[FYI] sondra.moyls
#rnx

[CL 33774332 by rob gay in ue5-main branch]
2024-05-20 14:35:03 -04:00
rob gay
50cf3cd4d3 Fix for ensures due to invalid attempt to reconnect undesired vertices when removing a connected variable getter
#jira UE-214264
#rb phil.popp
#tests AudioQA Tests & MetaSound Asset Editor
[FYI] sondra.moyls
#rnx

[CL 33641718 by rob gay in ue5-main branch]
2024-05-14 20:16:37 -04:00
rob gay
8be40dbaf8 Fix duplicate/bad include path format (shame on you VAX)
#rb rob.gay
#rnx

[CL 33529830 by rob gay in ue5-main branch]
2024-05-08 17:37:14 -04:00
rob gay
711a973c73 - Move MetaSoundAssetSubsystem& BuilderSubsystem implementations to monolithics that are initialized at MetaSoundEngine module load for safety
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang

#tests EngineTest & AudioQA Automation PIE Packaged Build -game

[CL 33522338 by rob gay in ue5-main branch]
2024-05-08 14:53:53 -04:00
rob gay
e8e0c199a2 Remove dependency on MetaSound engine subsystems of any kind being required to register MetaSounds with frontend
#rb rob.gay
#rnx
[FYI] sondra.moyls, phil.popp, helen.yang

[CL 33199328 by rob gay in ue5-main branch]
2024-04-24 10:36:28 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
c8ee6d747a Don't ensure if location guid is invalid to fix automated build
#rb rob.gay
#tests local compile
#jira UE-194159

[CL 33088501 by rob gay in ue5-main branch]
2024-04-18 18:09:19 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00