Commit Graph

174 Commits

Author SHA1 Message Date
matt peters
64658cf6ae GetAssetRegistryTags deprecation: Make the old GetAssetRegistryTags and related functions deprecated.
Upgrade the overrides and callsites in all of Epic's code.
Every class that can be subclassed by licensees that has its override change needs to keep the old version of the function as deprecated. Otherwise subclasses that call Super::GetAssetRegistryTags will have a compile error instead of a deprecation warning.
Several classes had their own extension method for GetAssetRegistryTags being passed on to user data classes. Updated all of those to take FAssetRegistryTagsContext just like GetAssetRegistryTags does.
#rnx
#rb Francis.Hurteau

[CL 30224166 by matt peters in ue5-main branch]
2023-12-08 21:45:21 -05:00
martin wilson
20ac36fdce Stop editing of virtual bone transforms via details panel customization
#jira UE-174819
#rb Thomas.Sarkanen

[CL 26486355 by martin wilson in ue5-main branch]
2023-07-20 11:08:45 -04:00
kiaran ritchie
ba0066bce1 Removing URig from animation system (second try)
#rb halfdan.ingvarsson
[FYI] thomas.sarkanen, jurre.debaare

[CL 26330333 by kiaran ritchie in ue5-main branch]
2023-06-29 18:08:13 -04:00
kiaran ritchie
725d95a11b [Backout] - CL26275272
[FYI] kiaran.ritchie
Original CL Desc
-----------------------------------------------------------------
Removing URig from animation system.

#rb halfdan.ingvarsson
[FYI] thomas.sarkanen, jurre.debaare

[CL 26276275 by kiaran ritchie in ue5-main branch]
2023-06-27 20:11:04 -04:00
kiaran ritchie
b14a376bca Removing URig from animation system.
#rb halfdan.ingvarsson
#fyi thomas.sarkanen, jurre.debaare
#JIRA https://jira.it.epicgames.com/browse/UE-169103

[CL 26260694 by kiaran ritchie in ue5-main branch]
2023-06-27 12:20:55 -04:00
benoit gadreau
c0cba53399 Skeleton Editing Tool: editable skeleton tree
#jira UE-183073
#rb kiaran.ritchie

[CL 26117738 by benoit gadreau in ue5-main branch]
2023-06-20 07:17:57 -04:00
jaime cifuentes
872a08a7da Fix crash deleting sync marker at SyncMarkers Window, by changing a CastChecked by a Cast, so it does not crashes with AnimMontages (as GetCompatibleAnimSequences retuirns all UAnimSequenceBase assets)
#rb [at]thomas.sarkanen
#jira UE-187282

[CL 25841667 by jaime cifuentes in ue5-main branch]
2023-06-07 07:45:17 -04:00
Patrick Boutot
abd2be3706 Slate: Deprecate the SListView functions that managed the item in the STreeView. User should use the RootItem version instead.
#rb yohann.dossantos
#preflight 6463ce842d446eac965feb48

[CL 25505361 by Patrick Boutot in ue5-main branch]
2023-05-17 08:51:13 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
Thomas Sarkanen
44949a96a0 Sync markers can now be managed in the same way as notifies
Sync markers are now visible in the notifies tab
Added sync marker functionality to find/replace tab
Refactored find/replace tab to allow it to be extended via implementing new UAnimAssetFindReplaceProcessor classes
Fixed a few workflow edge cases
Optimized string handling while searching/replacing

#preflight 644a69110f12404fb793bc44
#jira UE-69308
#rb Jurre.deBaare,Roland.Munguia

[CL 25230083 by Thomas Sarkanen in ue5-main branch]
2023-04-28 06:05:42 -04:00
kirill zorin
a469aafd78 Update callsites to prepare for upcoming TArray/TArrayView<TObjectPtr<...>> restrictions
#rb zousar.shaker
#rb devin.doucette
#rb steve.robb
#rb robert.manuszewski
#rb saam.barati
#preflight 643f4c09a35280ed4f53ccb3

[CL 25100071 by kirill zorin in ue5-main branch]
2023-04-18 22:39:29 -04:00
jurre debaare
adf000b658 CIS Editor Error: SkeletonSelectionEditMode.h(45): error C4430: missing type specifier - int assumed
#rb none
#preflight 640f2cb9c41a0a2a77adc283

[CL 24613658 by jurre debaare in ue5-main branch]
2023-03-13 11:44:12 -04:00
joseph sozio
69c0a8222f [Backout] - CL24610412
[FYI] Jurre.deBaare
Original CL Desc
-----------------------------------------------------------------
Improved Skeleton reference pose drawing behaviour
- Allow for drawing sub-set of bones (through selection)
- Bone/socket details now pull correct data from reference skeleton
#preflight 6409dd42a450329d6c2d59b1
#rb Thomas.Sarkanen, Kiaran.Ritchie

[CL 24612076 by joseph sozio in ue5-main branch]
2023-03-13 09:59:51 -04:00
jurre debaare
cb45e0202d Improved Skeleton reference pose drawing behaviour
- Allow for drawing sub-set of bones (through selection)
- Bone/socket details now pull correct data from reference skeleton
#preflight 6409dd42a450329d6c2d59b1
#rb Thomas.Sarkanen, Kiaran.Ritchie

[CL 24610735 by jurre debaare in ue5-main branch]
2023-03-13 07:31:42 -04:00
lucas dower
2e1c38e5fc Fix for add virtual bone menu sometimes not showing
#rb thomas.sarkanen
#preflight 63ff42e130633435f80e2e55

[CL 24462174 by lucas dower in ue5-main branch]
2023-03-01 10:06:39 -05:00
jaime cifuentes
920d8d3e9e Fix for crash when showing Weighted Bones in Skeleletal Mesh Editor
#rb [at]thomas.sarkanen
#jira UE-178105
#preflight 63f7900dc35a141980254462
#lockdown Laurent.Delayen

[CL 24427011 by jaime cifuentes in ue5-main branch]
2023-02-27 12:59:57 -05:00
Thomas Sarkanen
502797ca50 Animation Curve Runtime & Editor Improvements
Runtime notes:
- Removes 'smart name' usage across the animation systems.
- Changed curve blending from a uniform array (sized per skeleton) to a sparse array of sorted named values. Blends and other combiners are performed using a dual iteration 'tape merge'.
- Skeleton curves are no longer guaranteed to cover all curve names that can be found at runtime.

Editor notes:
- Curve metadata (flags, bone links etc.) is still present on the skeleton, but can also now exist on a skeletal mesh
- Curve metadata (for morph targets) is still populated on import
- Curves can now be used arbitrarily at runtime

New features:
- New Find/Replace dialog that allows for batch-replacing curves and notifies across all of a project's assets
- New curve debugger tab in various Persona editors that allows for viewing curve values live. This also now allows viewing curves for specific pose watches.
- Pose watches now output curve tracks to the Rewind Debugger

#rb Jurre.deBaare,Nicholas.Frechette,Sara.Schvartzman,Helge.Mathee,Kiaran.Ritchie,Jaime.Cifuentes,Martin.Wilson,Keith.Yerex,Andrean.Franc (and more!)
#jira UE-167776
#jira UE-173716
#jira UE-110407
#preflight 63fc98c81206d91a2bc3ab90
#preflight 63f3ad4f81646f1f24c240c2

[CL 24421496 by Thomas Sarkanen in ue5-main branch]
2023-02-27 07:20:58 -05:00
kiaran ritchie
e815455ef7 Deprecate URig types in preparation for full removal in 5.4.
#rb halfdan.ingvarsson
#JIRA https://jira.it.epicgames.com/browse/UE-175090
#preflight https://horde.devtools.epicgames.com/job/63d1800d976daa618c701490

[CL 23863393 by kiaran ritchie in ue5-main branch]
2023-01-25 20:42:11 -05:00
Patrick Boutot
acff5d3a7d Slate: Deprecated protected access to SListView::ItemsSource. This will allow us to use other container type.
#jira UE-132673
#rb sebastian.nordgren
#preflight 6398beed2540a78d2730da51

[CL 23512016 by Patrick Boutot in ue5-main branch]
2022-12-14 10:22:25 -05:00
Jurre deBaare
31f1b097fd Animation Compression
- Added new compression and 'compiling' API/path
  * Relies on newer DDC API
  * Only fetches compressible data when data is not found in DDC
  * Fetching data happens off the GT now (including Additive animation)
- Deprecated and replace AnimSequence API around compression
** AnimStreamable still relies on old, synchronous, compression path **

IAnimationDataModel
- Removed bone track data being stored as FBoneAnimationTrack
- Bone animation can now only be referenced by Name (not track index anymore)
- Deprecated any API relying on FBoneAnimationTrack
- Added API to retrieve FTransform(s) for given frame(s) with provided bone name
- Added API to lock model against modifications during evaluation (required for non-racing off-GT evaluation)

Animation Sequence
- Frame-rate is now stored on a per-platform basis, allowing for future replacement of frame-stripping (editing property is disabled for now)
- Now allows for storing _transient_ per-platform compressed animation data (required for multi-platform cook)

PerPlatformProperties
- Added per-platform FFrameRate implementation

#preflight 63999f102540a78d2778adb7
#rb Thomas.Sarkanen, Nicholas.Frechette, Devin.Doucette
#fyi Zousar.Shaker

[CL 23510521 by Jurre deBaare in ue5-main branch]
2022-12-14 05:56:08 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
Thomas Sarkanen
d9c2b172f7 Skeleton compatibility improvements
Skeleton compatibility is now bi-directional. Specifying a compatible skeleton A -> B now implies B -> A.
Skeleton compatibility is now an editor-only concern. The runtime will attempt to do the 'best it can' via name -> name mappings. Only the editor will prevent assigning incompatible skeletons in (e.g.) asset pickers etc.
Skeleton compatibility checks in editor can now be disabled in the editor preferences (and each asset picker now has a checkbox option in its view settings that allows for quick access to this).

Moves FSkeletonRemapping to its own file (which is now private).
Skeleton remappings are now generated on demand on worker threads just before animation decompression and stored in a registry, guarded by FRWScopeLock for thread-safety.

Fixed some anim BP compiler edge cases where asset references on pins were not getting preloaded correctly, causing skeletons to be erroneously reported as missing.

Exposed the current asset registry filter in SAssetView so that menu extensions can access it (and use it to provide context)

#jira UE-166054
#jira UE-167355
#rb Jurre.deBaare,John.vanderBerg
#preflight 635902602e6690262afa86f9

[CL 22878911 by Thomas Sarkanen in ue5-main branch]
2022-11-01 06:25:59 -04:00
Thomas Sarkanen
0196c12d6c Added support for copy/paste for curve viewer
#jira UE-168242
#rb Keith.Yerex
#preflight 635a52369b2e9c76c7fc133f

[CL 22806858 by Thomas Sarkanen in ue5-main branch]
2022-10-27 05:56:15 -04:00
henrik karlsson
0da5962f86 Removed lots of includes in UE based on compile profiling
#preflight 6356cb02ae33b04ec1e358ac
#rb none

[CL 22786278 by henrik karlsson in ue5-main branch]
2022-10-26 15:02:30 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00