#rb Per.Larsson
#jira UE-169626
#rnx
#preflight 63bd670a71079a8d1c0e837b
- Since the API was forcing the caller to pass in a results structure to be filled in, we might as well make it the return value.
- Added a ::WasSuccessful method to the results structures that can be used instead of checking if the result had errors or not.
- Remove the reset method from FVirtualizationResult/FRehydrationResult as they no longer need it.
- The older deprecated methods still use the results enum, so we cannot easily deprecate those enums yet.
[CL 23626072 by paul chipchase in ue5-main branch]
#rb Per.Larsson
#jira UE-169626
#rnx
#preflight 639c4112012902cb8db43e13
- This allows us to provide the user with more ways to customize the virtualization and return more detailed info about it if the calling code wishes to log additional info. In both cases we can extend the options and the data returned without changing the API.
- Previously if we virtualized a package that was not checked out in revision control we would warn the user and then skip updating the package file on disk. This means the payloads would be uploaded but the user would be left with no local changes. Since sometimes we know we don't need to check out any package (virtualizing the packages in a change list for example) we don't want to always incur the cost of polling reivision control to see which packages do need checking out. This is why we now allow the caller to request package files be checked out via the new options enum EVirtualizationOptions.
-- If the EVirtualizationOptions::Checkout flag is provided we will poll the revision control status of all package files and then check out those which need it.
-- We still check if packages can be modified and warn the user if they can't, as package files could be locked in other ways.
- Added a new utility function to SourceControlUtilties to make it easier to check out packages. There is similar functionality elsewhere in the code base but the virtualization module is too low level to make use of it.
- Updated existing code that calls ::TryVirtualizePackages and add cases of ''using namespace UE::Virtualization' where required to improve readability.
- The UnrealVirtualizationTool now supports a new cmdline option "-checkout" that can be used when virtualizing packages. This will checkout any package that was actually virtualized so the result can be saved back out to the workspace domain. This means we no longer require the caller to have checked out the packages before running the tool.
[CL 23536832 by paul chipchase in ue5-main branch]
Fixed 'Cannot revert umaps with Skein' by reloading all assets when attempting to revert a map
Implemented 'Revert All' button
#rb patrick.enfedaque, wouter.burgers, stuart.hill, manuel.lang
[FYI] francis.hurteau, brooke.hubert
#preflight 6388f51d4c3ce8ae5dbfb18f
#preflight 639340545c5308d18c28b967
[CL 23475314 by marco anastasi in ue5-main branch]
- non-temp assets shouldn't be loaded with the LOAD_ForDiff flag.
#jira UE-160889
#rb dan.oconnor
#rb phillip.kavan
[FYI] julien.lheureux
#preflight 63911c8e255f07df8e817474
[CL 23439362 by jordan hoffmann in ue5-main branch]
Standardized changelist description single line to a helper function to ensure the changelist window and history window have consistency
#rb wouter.burgers
#preflight 638e09551776b8c21c18e716
[CL 23394656 by brooke hubert in ue5-main branch]
This introduces a MainFrame menu item under TOOLS -> SOURCE CONTROL called 'Sync Content', similar to the existing 'Submit Content' option. The new menu item is tied to the F5 hot key.
#preflight 63722efcb6636838285ea216
[CL 23129394 by wouter burgers in ue5-main branch]
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch
#preflight 63635997876630122adeab9f
#rb none
[CL 22958990 by henrik karlsson in ue5-main branch]
- Added function to the source control file status monitor to easily set the exact list of file to monitor efficiently
Fixed the source control changelist not monitoring all the files in view.
#rb Aditya.Ravichandran
#preflight 6362b9bf1a32af63a8f5b719
[CL 22937889 by patrick laflamme in ue5-main branch]
- Handling simple source control updates nofications, for example when user scroll the outliner which query source control status of the scrolled files, usually took 450ms with 15000 files to refresh in the changelist window now takes about 3ms.
- Cached UI item to reuse them when user change the filter.
- Detect and update only the item that changed.
- Preserved the item sort order from the previous update when possible.
- Lazily read the file modification timestamp only when the item is fist displayed.
- Updated files modification in background (triggred when when a package is saved).
- Only monitor source control file status for files that are visible (unless the view is sorted by status)
- Splitted Uncontrolled Changelist and Source Controlled Changelist update to update then independently and just update the one that was notified as updated.
- Converted the file view from a STreeView to a SListView.
Updated changelist UI to display (X out of Y files) when a filter is active and remove files from the view.
#rb Luc.Eygasier
#jira UE-139957 Changelists window refreshes excessively
#preflight 63615588ce68f7cbb695d54a
[CL 22890915 by patrick laflamme in ue5-main branch]
- The function GetSelectedFiles() copied the full pathname of each selected files (can be thoudands) several times when opening the context menu, making it non-responsive.
#rb Patrick.Enfedaque
#preflight 635a9154f1493f9786662587
[CL 22811459 by patrick laflamme in ue5-main branch]
- Removed conversion/creation of temporary strings when sorting.
- Removed several branching operations.
- Used Stricmp rather than operator<() as it tells if the string is <> or == in a single operation.
- Sorted the 'Last Modified' column using FDateTime rather that the FText/FString.
- Mesured before/after the change with Insight, in average, the sorting 15 now times faster. (avg 2.4 ms for 7600 items).
- Do not sort by default, waited until the user decide to sort to enable the feature.
#rb Patrick.Enfedaque
#jira UE-139957 - Changelists window refreshes excessively (Partially adressing this issue).
#preflight 63500e398176062ea7e3f6ed
[CL 22635606 by patrick laflamme in ue5-main branch]
