Joakim Lindqvist
611799154b
Wait up to 30 seconds before prompting users to finish the login - it can take a while if users need to enter their password and such, it is still quite short but on the other hand we do not want the editor to just sit around waiting for ever in case something has gone wrong.
...
#preflight 63bff0f2bf54fa7b3657f9c6
[CL 23660685 by Joakim Lindqvist in ue5-main branch]
2023-01-12 06:44:58 -05:00
devin doucette
14a2e7482d
Logging: Updated Windows and Linux feedback contexts to support structured logging
...
This sets up the base FFeedbackContext to do most of the work because there is very little behavioral difference between platforms, yet the majority of the code is duplicated for each platform.
#jira UE-152840
#preflight 63b45fe435203bc7aab23837
#rb Zousar.Shaker
#rnx
[CL 23567792 by devin doucette in ue5-main branch]
2023-01-03 13:07:24 -05:00
henrik karlsson
ce587eb612
Added markups for headers that can't be compiled standalone.. this is needed for both Header units and IWYU
...
#preflight 63789b0c170bc34a93a869e5
#rb none
[CL 23552160 by henrik karlsson in ue5-main branch]
2022-12-21 02:46:50 -05:00
MalikuMane
98b4ee0ea8
PR #9906 : Fix Linux duplicate engine association entries in Install.ini. (Contributed by MalikuMane)
...
#jira UE-172625
#rb Robert.Seiver
#preflight 639b653d43330e63e573c069
[CL 23531567 by MalikuMane in ue5-main branch]
2022-12-15 16:02:48 -05:00
Joakim Lindqvist
3fc55bdb05
OidcToken - If users answer no to waiting for interactive login, but the login has actually completed we now continue with the valid token we have.
...
#preflight 6391bb87c415e8dc78252ab9
#rb devin.doucette
[CL 23446527 by Joakim Lindqvist in ue5-main branch]
2022-12-08 10:22:21 -05:00
Joakim Lindqvist
9f8a7dfb32
OidcToken - Added error page when there is a problem logging in, polished the look of the success page. Also updated the text in the popup prompt for login to read a bit better.
...
#preflight none
[CL 23174150 by Joakim Lindqvist in ue5-main branch]
2022-11-17 06:39:30 -05:00
bryan sefcik
ca0d5de18d
Fixed a few issues where IsTargetInfoValid would return that all targets weren't found. This would result in a call to UBT to get the TargetInfo and sometimes took up to 22+secs to call.
...
#jira
[FYI] ben.marsh
#preflight 63641b64882365b859628e9a
[CL 22977347 by bryan sefcik in ue5-main branch]
2022-11-03 23:47:12 -04:00
devin doucette
41c5373ebd
DDC: Fixed parameter names related to OIDC to be compliant with the coding standard and simplified analytics formatting
...
#preflight 636403b3de2c4dbb5d3a5b11
#rb Zousar.Shaker
#rnx
[CL 22968397 by devin doucette in ue5-main branch]
2022-11-03 18:00:06 -04:00
mark lintott
5ae432fc55
Addeed specific Unreal Cloud DDC analytics for core.cooking and core.loading events ( Domain, Effective Domain, Cache Hit/MIss for Cache Puts & Gets, FailedOIDC login attempts )
...
#rb joakim.lindqvist
#jira none
#preflight 6363c123d308b70e66f4cf33
[CL 22951911 by mark lintott in ue5-main branch]
2022-11-03 09:39:24 -04:00
bryan sefcik
483f93dc1a
Fixed misc include paths
...
#jira
#preflight 634f491669246074dbb2719d
[CL 22633214 by bryan sefcik in ue5-main branch]
2022-10-19 14:38:31 -04:00
bryan sefcik
f58e75e476
Pass 2 on cleaning up build.cs files.
...
#jira
#preflight 631b7a79304480f8f8b48580
[CL 21931324 by bryan sefcik in ue5-main branch]
2022-09-09 19:41:38 -04:00
Joakim Lindqvist
efcac1bd0d
OidcToken - Changed exit code when determining if a token exists to a positive small number (10) which will avoid inconsistencies between desktop platform in how to handle a negative number.
...
#preflight 631600b3da1671f9972825c3
[CL 21794535 by Joakim Lindqvist in ue5-main branch]
2022-09-05 10:52:09 -04:00
Joakim Lindqvist
a1b55397d8
OidcToken - Fixed issue on linux were exit code was not correctly detected and thus the initial verification if a token exists fails.
...
#jira UE-162770
#preflight 6315d7c9da63cdf170d77a64
[CL 21790780 by Joakim Lindqvist in ue5-main branch]
2022-09-05 07:20:04 -04:00
Joakim Lindqvist
4e69a62587
OidcToken - Allow users to abort the oidc login in the prompt that warns we are about to spawn a browser
...
#jira UE-161365
#preflight https://horde.devtools.epicgames.com/job/630f1f60501b64ba33604fd2
[CL 21718887 by Joakim Lindqvist in ue5-main branch]
2022-08-31 07:22:25 -04:00
Marc Audy
1bb2a63925
Fix implicit conversion warnings
...
#rnx
#preflight 630e8ad3660db81edb9ea2d5
[CL 21711473 by Marc Audy in ue5-main branch]
2022-08-30 18:28:30 -04:00
jessica agee
403f029bd7
Set UnsafeTypeCastWarningLevel to Error for a few widely-used modules
...
#rb none
#preflight 630d013af92416fb926b3c7a
#preflight 630d0938e54ec9d5815ebb45
[CL 21696478 by jessica agee in ue5-main branch]
2022-08-30 02:22:04 -04:00
Devin Doucette
f5b40af3dc
Fixed unsafe type casts in Mac platform code
...
#preflight 630d013af92416fb926b3c7a
#rb Bryan.Sefcik
#rnx
[CL 21685328 by Devin Doucette in ue5-main branch]
2022-08-29 15:03:32 -04:00
Joakim Lindqvist
11ea6a68fc
OidcToken - Fixed issues specific to handle tokens on Mac, which handles cases where the token does not exist better.
...
Also improved logging when a unknown issue happens.
Lastly the error code returned from the mac process seems to be converted to a unsigned 32 bit so checking for that value as well when checking the exit code that means we should upgrade the process to a interactive login.
#preflight https://horde.devtools.epicgames.com/job/6308e65e2a02fecb6f3cadc5
[CL 21665549 by Joakim Lindqvist in ue5-main branch]
2022-08-29 04:05:26 -04:00
Joakim Lindqvist
767e76dbb0
OidcToken - Fixed issue running interactive login on mac and linux. Also fixed issue were asking to wait for login caused a crash as well as tweaking the error message when a user decided to not finish the interactive login.
...
#jira UE-161335, UE-161369
#preflight https://horde.devtools.epicgames.com/job/62ff679e3c4417dcec499e53
[CL 21455420 by Joakim Lindqvist in ue5-main branch]
2022-08-19 06:53:53 -04:00
Tim Smith
6441d21065
Removed duplicated code from a 5.0 patch fix.
...
#rb devin.doucette
#rnx
#preflight 62fd04183f75602b2fba9a03
[CL 21425650 by Tim Smith in ue5-main branch]
2022-08-17 11:18:31 -04:00
devin doucette
eb55a547d0
Fixed unsafe type casts in a few widely-used modules
...
#preflight 62f72b49185b21882ac5c366
#rb Steve.Robb
#rnx
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 21404445 via CL 21404453 via CL 21404464
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v975-21357124)
[CL 21407133 by devin doucette in ue5-main branch]
2022-08-16 12:35:53 -04:00
Joakim Lindqvist
a1c6e408bc
OidcToken - Fixed path passed for project to oidc token to always be the project directory (no matter if its a foreign project or not). This makes sure we are able to read the configuration from the project if a project is set.
...
Also updated the prompt asking user to login to make it clear who is asking and for what (assuming this is used by DDC - which is only the case now but may not be forever)
#preflight https://horde.devtools.epicgames.com/job/62f639b3153b17e74650f16e
[CL 21353268 by Joakim Lindqvist in ue5-main branch]
2022-08-12 07:40:29 -04:00
Joakim Lindqvist
99738a925d
Allow users to interactivly login if they are missing a token. Will present a dialog for users if not unattended so they are aware they need to login.
...
#preflight https://horde.devtools.epicgames.com/job/62f26d7723003b62a3f3b58f
[CL 21334992 by Joakim Lindqvist in ue5-main branch]
2022-08-11 09:17:03 -04:00
bryan sefcik
de1956f47b
Ran IWYU on Public headers under Engine/Source/Developer/...
...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted. Nothing is removed.
#ushell-cherrypick of 21064294 by bryan.sefcik
#jira
#preflight 62d5c2111062f2e63015e598
#ROBOMERGE-OWNER: bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21155249 via CL 21158121 via CL 21161259
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
[CL 21182053 by bryan sefcik in ue5-main branch]
2022-07-20 12:03:45 -04:00
bryan sefcik
b509beb314
Added a few IWYU pragma comments.
...
#preflight 62ce5231b90bf53969409839
[CL 21067982 by bryan sefcik in ue5-main branch]
2022-07-13 01:25:24 -04:00
