Commit Graph

706 Commits

Author SHA1 Message Date
Devin Doucette
292008ea35 Logging: Replaced GLog->PanicFlush() with GLog->Panic()
Panic allows only one thread to become the panic thread. In panic mode, logs are only sent to panic-safe output devices. Each call to Panic flushes buffered logs to panic-safe output devices, and flushes panic-safe output devices.

#jira UE-147152
#preflight 62424814292f228e09d8a612
#rb Zousar.Shaker
#fyi Brandon.Schaefer

[CL 19545093 by Devin Doucette in ue5-main branch]
2022-03-29 13:31:48 -04:00
Devin Doucette
c8d64e3c97 Logging: Added and migrated to GLog->PanicFlush() for crash handling
#preflight 623a433a10251d53d5796835
#rb Zousar.Shaker

[CL 19478551 by Devin Doucette in ue5-main branch]
2022-03-23 09:39:18 -04:00
steve robb
87fb605867 TCHAR array init fixes for UTF-8 mode.
#rb devin.doucette
#preflight 6231e536e2541b4ff3af6cd2

#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 19405353 via CL 19408955 via CL 19419621 via CL 19419706
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v930-19419903)

[CL 19420584 by steve robb in ue5-main branch]
2022-03-17 10:29:53 -04:00
jeannoe morissette
6d083e9aaf Fix driver version check for Windows on NVIDIA.
#jira UE-145362
#preflight 6228f4e41357c5e91307fa84
#lockdown Michal.Valient
#rnx

#ROBOMERGE-AUTHOR: jeannoe.morissette
#ROBOMERGE-SOURCE: CL 19337685 in //UE5/Release-5.0/... via CL 19348971
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19349177 by jeannoe morissette in ue5-main branch]
2022-03-10 23:55:58 -05:00
danny couture
4114b4b372 Add support for dynamic thread prioritization
- This restore proper prioritization support that was lost with the new task backend while keeping a sane number of threads
  - This helps to prevent latency sensitive tasks from going to efficient cores for Alder Lake
  - This fixes performance problems caused by high prio task getting picked up by background threads and being preempted under high-load, causing FPS hiccups.
  - SetThreadPriority takes ~20us on average on Windows System and is only paid for background work
  - Longer SetThreadPriority can be expected when lowering the priority of a task under heavy load, which might cause the caller to be preempted right away, this is expected.
  - Can be A/B tested from command-line with -TaskGraphUseDynamicPrioritization=1/0

#rb Andriy.Tylychko, Arne.Schober, Stefan.Boberg
#preflight 622786a7e83598518f3745a1

[CL 19314282 by danny couture in ue5-main branch]
2022-03-08 19:24:40 -05:00
steve robb
288f3de432 Fixes for the implicit conversion of ints and chars to TCHARs in UTF-8 mode.
#rb trivial
#preflight 621ed0b4e15c51d8c5e5d081

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 19219816 via CL 19220283 via CL 19220288 via CL 19223679
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19227684 by steve robb in ue5-main branch]
2022-03-02 15:30:50 -05:00
PJ Kack
23456e2db7 Add FGenericPlatformProcess::TerminateProcTreeWithPredicate() that enables killing a launched process tree while keeping some of the child processes alive.
#jira none
#rb carlmagnus.nordin
#rnx
#preflight 621df1fcf1206ae3ea3c23be

[CL 19196914 by PJ Kack in ue5-main branch]
2022-03-01 07:42:09 -05:00
steve robb
33c800a605 TEXT(""_SV) changed to TEXTVIEW("") for UTF-8 support.
#rb trivial

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 19135062 via CL 19136099 via CL 19136620 via CL 19138526
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19155676 by steve robb in ue5-main branch]
2022-02-25 15:48:16 -05:00
michael noland
28ee88b5e1 Added a Windows-specific version of FWindowsPlatformMisc::GetMaxRefreshRate
#jira UE-142825
#rb nick.darnell
#preflight 620c06cd4353dc61c7fd3b90
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 19058655 in //UE5/Release-5.0/... via CL 19074349
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19076494 by michael noland in ue5-main branch]
2022-02-22 13:48:19 -05:00
Wojciech Krywult
c2a62160ec Windows: Added an option to initialize COM in the MTA (multithreading) mode (it defaults to STA i.e. singlethreading mode as before)
#rb Rolando.Caloca, jeff.newquist
#preflight 620e82d8e55d9645848be5f4
#rnx

[CL 19037697 by Wojciech Krywult in ue5-main branch]
2022-02-17 13:24:20 -05:00
stefan boberg
05635692aa Added heuristic for detecting Windows 11 in WindowsPlatformMisc.cpp
#preflight https://horde.devtools.epicgames.com/job/620102296773a3612885d2fd
#lockdown mark.lintott
#jira UE-141492
#rb danny.couture,mihnea.balta,geoff.evans

#ROBOMERGE-AUTHOR: stefan.boberg
#ROBOMERGE-SOURCE: CL 18884144 in //UE5/Release-5.0/... via CL 18884157 via CL 18884194
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18884910 by stefan boberg in ue5-main branch]
2022-02-07 09:14:41 -05:00
ionut matasaru
9f38497358 [Insights] Fixed memory tracking for an FRunnableThread to emit a free event when the thread ends (this time without resetting Runnable to nullptr when thread ends).
#jira UE-140358
#rb Johan.Berg
#preflight 61f796c741414fb013b5b467

#ROBOMERGE-AUTHOR: ionut.matasaru
#ROBOMERGE-SOURCE: CL 18787315 in //UE5/Release-5.0/... via CL 18787321 via CL 18787340
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18787342 by ionut matasaru in ue5-main branch]
2022-01-31 03:13:35 -05:00
eric mcdaniel
361f6b69d1 [Backout] - CL18771801
- this change prevents gauntlet from running tasks on Xbox so I am backing it out
  - instance of Horde failure:  https://horde.devtools.epicgames.com/job/61f43b2f74510448a686da51?step=72cc

- the XboxConsoleInputReader thread is created and immediately terminates
  - this change introduced a null out of Runnable in the Xbox version of FRunnableThreadWin::Run()
    - this causes FRunnableThread::SetupCreatedThread() to assert on startup that a valid runnable thread was created but has no Runnable

#rb none
#preflight 61f47fb6801201ab389bb311
[FYI] ionut.matasaru

Original CL Desc
-----------------------------------------------------------------
[Insights]
  - Fixed memory tracking for an FRunnableThread to emit a free event when the thread ends.
  - Fixed memory tracking for "ProgramSize" of loaded modules (dlls), to emit a free event when dll is unloaded.

#jira UE-140358
#rb Johan.Berg
#preflight 61f40923f628752a568b292b

#ROBOMERGE-AUTHOR: eric.mcdaniel
#ROBOMERGE-SOURCE: CL 18781656 in //UE5/Release-5.0/... via CL 18781895 via CL 18781943
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18781953 by eric mcdaniel in ue5-main branch]
2022-01-28 20:10:09 -05:00
ionut matasaru
2df95139ab [Insights]
- Fixed memory tracking for an FRunnableThread to emit a free event when the thread ends.
  - Fixed memory tracking for "ProgramSize" of loaded modules (dlls), to emit a free event when dll is unloaded.

#jira UE-140358
#rb Johan.Berg
#preflight 61f40923f628752a568b292b

#ROBOMERGE-AUTHOR: ionut.matasaru
#ROBOMERGE-SOURCE: CL 18771801 in //UE5/Release-5.0/... via CL 18771806 via CL 18771881
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18771891 by ionut matasaru in ue5-main branch]
2022-01-28 10:54:49 -05:00
johan berg
e83f240b1e [Insights] Report ThreadStack size correctly.
#rb ionut.matasaru
#preflight 61f2b40f800734b52da7a7d4

#ROBOMERGE-AUTHOR: johan.berg
#ROBOMERGE-SOURCE: CL 18753812 in //UE5/Release-5.0/... via CL 18753843 via CL 18756968
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18757286 by johan berg in ue5-main branch]
2022-01-27 14:10:33 -05:00
justin marcus
35cde70727 Fix double path seperators in NotAllowedUnattendedBugReports path.
#preflight
#rb Rex.Hill

#ROBOMERGE-AUTHOR: justin.marcus
#ROBOMERGE-SOURCE: CL 18677948 via CL 18679133 via CL 18679189 via CL 18679245 via CL 18681199 via CL 18681228 via CL 18681276
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18681545 by justin marcus in ue5-main branch]
2022-01-20 16:32:12 -05:00
johan berg
f26d26c315 [Insights] Move UE_MEMORY_TAGS_TRACE_ENABLED to build file.
We need to set this define in other platform build files, and since some of them are included on windows (editor) builds as well, we can end up with warnings of redefinition of variable.
#preflight 61e025e11e7c2075bb218b0f

#ROBOMERGE-AUTHOR: johan.berg
#ROBOMERGE-SOURCE: CL 18595866 in //UE5/Release-5.0/... via CL 18595880 via CL 18595890
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18596773 by johan berg in ue5-main branch]
2022-01-13 10:14:29 -05:00
david harvey
0d1909cec7 Some derived Windows platforms can override Windows OS Version functionality.
- GetVersionEx WinAPI function does not work as expected on Manifested Applications.

#jira UE-136505
#rnx
#preflight 61dc8067aa3e6f269e9791db
#rb Eric.McDaniel

#ROBOMERGE-AUTHOR: david.harvey
#ROBOMERGE-SOURCE: CL 18569901 in //UE5/Release-5.0/... via CL 18569910
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18569914 by david harvey in ue5-release-engine-test branch]
2022-01-11 04:40:38 -05:00
andrew davidson
b98537f02b UNSAFE_TYPECAST_WARNING macros allow force enabling of warnings.
#[fyi] michael.noland
#preflight 61d86fa3c65e66487b36b5c0

#ushell-cherrypick of 18546856 by Andrew.Davidson

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18552595 via CL 18552601 via CL 18552604 via CL 18553016 via CL 18553035
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18553054 by andrew davidson in ue5-release-engine-test branch]
2022-01-07 20:09:18 -05:00
andrew davidson
83f6ea2c8a Undo //Fortnite/Dev-EngineMerge-Test2/Engine/... changelist 18551315
#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18552107 via CL 18552130 via CL 18552133 via CL 18552520 via CL 18552534
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18552539 by andrew davidson in ue5-release-engine-test branch]
2022-01-07 19:03:23 -05:00
andrew davidson
9dc047e01d UNSAFE_TYPECAST_WARNING macros allow force enabling of warnings.
[FYI] michael.noland
#preflight 61d86fa3c65e66487b36b5c0

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18546856 in //UE5/Release-5.0/... via CL 18546891
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18546909 by andrew davidson in ue5-release-engine-test branch]
2022-01-07 12:27:01 -05:00
jack porter
e7b6f0102c Add flag to FPlatformProcess::CreatePipe to indicate the pipe will be used for stdin redirection rather than stdout redirection.
Windows needs to set permissions accordingly.
#rb Brandon.Schaefer
[FYI] Josh.Adams
#preflight 61d79ed84c252480ca31e640

#ROBOMERGE-AUTHOR: jack.porter
#ROBOMERGE-SOURCE: CL 18539045 in //UE5/Release-5.0/... via CL 18539064
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18539081 by jack porter in ue5-release-engine-test branch]
2022-01-06 21:19:58 -05:00
johan berg
f7b0a35082 [Insights] Instrument core classes with memory tracing.
#preflight 61d56e4f411c1403a3c877f8

#ROBOMERGE-AUTHOR: johan.berg
#ROBOMERGE-SOURCE: CL 18517115 in //UE5/Release-5.0/... via CL 18517122
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18517127 by johan berg in ue5-release-engine-test branch]
2022-01-05 05:15:57 -05:00
matt peters
fe4121305e #jira UE-138033
Speculative fix for how a FFileHandleWindows might change from valid to invalid. The unwritten contract is that FFileHandleWindows instances returned from OpenRead are either null or are IsValid() == true.
Also fix FArchiveFileReaderGeneric::FlushCache from possibly dereferning a null handle to do the seek.
#rb Zousar.Shaker
#rnx
#preflight 61d3424e1f62d3ad4d492962

#ROBOMERGE-AUTHOR: matt.peters
#ROBOMERGE-SOURCE: CL 18503371 in //UE5/Release-5.0/... via CL 18503391
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18503412 by matt peters in ue5-release-engine-test branch]
2022-01-03 16:11:45 -05:00
martin ridgers
815997d363 Check there's a GWarn device before trying to dump stats to it.
RenderDoc and FTaskTagScope() do not play well together with the latter raising an ensure(). This ensure fires very early, earlier than all of the engine's machinery being reporting and logging are fully initialised, making it somewhat brittle.

#rb perl
#rnx
#jira ue-99840
#preflight 619e026ef70a9e92db5aa83f

#ROBOMERGE-AUTHOR: martin.ridgers
#ROBOMERGE-SOURCE: CL 18280839 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v895-18170469)
#ROBOMERGE[STARSHIP]: UE5-Release-Engine-Staging Release-5.0

[CL 18280857 by martin ridgers in ue5-release-engine-test branch]
2021-11-24 04:35:00 -05:00