Commit Graph

1075 Commits

Author SHA1 Message Date
christopher waters
99ec480304 Cleaning up dependencies with select heavy-hitter headers in MovieScene and addressing the fallout from that.
MovieScene was targeted as its headers were at the top of profiling ShooterGame builds.
Tested with -disableunity and -nopch. Current timings take ShooterGameEditor rebuild from 480s to 440s

#jira none
#rb josh.adams
#preflight 624c97a63661c8f04a191889

[CL 19634779 by christopher waters in ue5-main branch]
2022-04-05 18:58:45 -04:00
Mike Zyracki
2ced009770 Sequencer: New Transport Tool hotkeys, for toggle play, step frame and scrub frame.Also Game View in the Level Editor will hide all Controls in that viewport.
#jira UE-147014
#jira UE-147017.
#preflight 624b7af5c61d8a458f84a390
#rb matt.hoffman

[CL 19632490 by Mike Zyracki in ue5-main branch]
2022-04-05 17:49:23 -04:00
max chen
4fa0309007 Sequencer: Clamp to playback range before snapping to frames, otherwise the scrubbed to frame could be a subframe when snapping is on.
#jira UE-146757
#preflight 623a0ec904769ab49357f0a9
#rb matt.hoffman

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19471303 via CL 19488245 via CL 19488378
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v936-19480137)

[CL 19489504 by max chen in ue5-main branch]
2022-03-23 20:03:04 -04:00
max chen
cc3e5596bf Sequencer/Valkyrie: Properties are only keyable by Sequencer if they are allowed to be visible in the property editor
#preflight 6234ddd0da56b5683aca15fa
#rb matt.hoffman

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19453201 via CL 19459091 via CL 19463147 via CL 19475173 via CL 19475241
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v935-19464907)

[CL 19475931 by max chen in ue5-main branch]
2022-03-22 23:23:55 -04:00
Mike Zyracki
7d67dfa741 Sequencer: Curve Editor: Curve Editor Sync Isse with Filter
Since Selection ticks before any filter is applied and the curve editor tree is udpated in FSequencer::Tick we need to sync the curve editor on the next tick so the filter is applied first, otherwise the curve tree hierarchy won't be up to date and the curve may not be found.
#jira UE-145538
#preflight 6238b73fda56b5683ae7e337

[CL 19469375 by Mike Zyracki in ue5-main branch]
2022-03-22 14:08:59 -04:00
max chen
d76168f5cb Sequencer: Fix localization warning for Outliner Columns
#rb none

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19422395 via CL 19424158 via CL 19430195 via CL 19430254
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v930-19419903)

[CL 19432582 by max chen in ue5-main branch]
2022-03-18 02:34:58 -04:00
max chen
77a4a7bb15 Sequencer: Backout IsEnabled from 18954849 because if the sequence is locked, the button won't be enabled to unlock the sequence
#jira UE-142083
#preflight 6205ac310c64e1822f4b69a7
#rb max.chen

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19413769 via CL 19415295 via CL 19428047 via CL 19428166
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v930-19419903)

[CL 19432533 by max chen in ue5-main branch]
2022-03-18 02:29:59 -04:00
andy sonnenburg
beb33b0faf Add OptionalFwd.h for TOptional
#rb andrew.scheidecker
#rb markus.breyer
#rb michael.noland
#rb steve.robb

#preflight 622f75c1223365469e3b9a4f


#ROBOMERGE-AUTHOR: andy.sonnenburg
#ROBOMERGE-SOURCE: CL 19376614 via CL 19378292 via CL 19381215 via CL 19393896 via CL 19394130
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19402380 by andy sonnenburg in ue5-main branch]
2022-03-16 03:07:13 -04:00
max chen
41308c9606 Sequencer: Clamp hierarchy browser to display height / 2 for very deep sequence hierarchies
#rb matt.hoffman

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19374016 via CL 19376452 via CL 19391698 via CL 19391988
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19402246 by max chen in ue5-main branch]
2022-03-16 03:02:30 -04:00
max chen
bf7a7b71f5 Sequencer: Fix crash in GetSelectedKeyAreas on selection. No need to RemoveAtSwap
#jira UE-145567
#preflight 622b82bb0a614dcb0cfef564
#rb ludovic.chabant
#lockdown simon.tourangeou

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19356942 in //UE5/Release-5.0/... via CL 19358257
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19359439 by max chen in ue5-main branch]
2022-03-11 14:49:28 -05:00
max chen
a23ba8a00f Curve Editor: Improve multi paste operation by adding an IntentName to the channel editor data.
Previously, the intent for control rigs included the control node name, ie. Foot_L.Location.X. This means it could not match Foot_R.Location.X. With this change, the intent for control rigs are filled in with just Location.X.
The intent for non control rig transforms remains the same - it includes the group and the display name. For static mesh transforms, this is Location.X.

With this change, you can now copy one node's channels to multiple objects. For example, copy Node1's Location channels and pasting them onto one or more nodes results in all of those getting Node1's Location channels.

You can also now copy multiple nodes to multiple objects in order. For example, copying Node1's Location and Node2's Location channels onto Node3 and Node4 results in Node3 getting Node1's Location channel and Node4 getting Node2's Location channel.

#jira UE-144528
#preflight 6222965f0e2d25b12b3abd97
#rb mike.zyracki

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19344823 via CL 19346627 via CL 19351368 via CL 19351426
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19351987 by max chen in ue5-main branch]
2022-03-11 04:29:52 -05:00
chris kulla
23dba4db22 Invalidate path tracer when sequencer time changes
This also allows the path tracer to be used in the niagara editor (with constant invalidation, but avoiding blurring)

#rb Matt.Hoffman
#preflight 62269e11a71867308f42738a

[CL 19295821 by chris kulla in ue5-main branch]
2022-03-07 19:23:52 -05:00
leon huang
0193ffe8d3 Fix for CIS warnings for localization duplicate keys. Fixes simply involve changing one of the colliding localization keys.
#rnx
	#rb: Vincent.Gauthier
	#jira: UE-143620
	#preflight: 6222489d2f7d78332e121416
	#lockdown Mitchell.Wilson

#ROBOMERGE-AUTHOR: leon.huang
#ROBOMERGE-SOURCE: CL 19272838 in //UE5/Release-5.0/... via CL 19273134
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19275063 by leon huang in ue5-main branch]
2022-03-04 16:10:23 -05:00
max chen
1d2865048c Sequencer: Activate the default mode in case FEditorModeTools::Tick isn't run before here.
This fixes a bug where the mode is set to "No Active Mode" when reopening the editor because the Sequencer modes are added before the default mode.  This can be removed once a general fix for UE-143791 has been implemented.

#jira UE-144086
#preflight 621d0b75037be0078ca9f7ef
#rb christina.tempelaarl
#lockdown laurent.delayen

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19179266 in //UE5/Release-5.0/... via CL 19180484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19204151 by max chen in ue5-main branch]
2022-03-01 14:56:17 -05:00
max chen
2f554a1d49 Sequencer: Speculative fix for tooltip crash when adjusting ease in/out
[FYI] grayson.edge

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19074328 via CL 19086855 via CL 19087301 via CL 19088529
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19131440 by max chen in ue5-main branch]
2022-02-24 19:02:41 -05:00
max chen
a6988101fc Sequencer: Fix paste object bindings.
Pasted component bindings need to be remapped to their spawnables. Previously, a temp active spawn section would be injected so that the component bindings could find their parent spawnables. This isn't necessary though since MakeNewSpawnable would have already made the spawnable.

Also, attach sections and other sections that have bindings need to be remapped from the old copied binding to the new pasted binding.

#jira UE-143147
#preflight 620ffae6eb1ea1b2cce2d78a
#rb mike.zyracki

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19058724 via CL 19065467 via CL 19065545 via CL 19065777
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19066960 by max chen in ue5-main branch]
2022-02-21 02:55:13 -05:00
max chen
60443fa675 Sequencer: Fix missing use of DilationPixels which is used to expand the hit region when testing for the scrubber. This fixes an issue where sometimes the hit test would fall through to dragging the playback ranges instead of dragging the time scrubber. Also, don't display the left/right cursor if the drag type is none
#preflight 620ffb02cc18880e8bba32c7
#mike.zyracki

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19058696 via CL 19065459 via CL 19065541 via CL 19065773
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19066959 by max chen in ue5-main branch]
2022-02-21 02:55:04 -05:00
HertzDonut
ca03ff9bca PR #8888: Fixing Sequencer scrub bar to more fully respect the "ReadOnly" status of Sequencer (Contributed by HertzDonut)
Lock button shows blue/on when locked
Disable adding/moving marks when locked
Disable playback range and mark menu options when locked
Selection is still allowed

#jira UE-142083
#preflight 6205ac310c64e1822f4b69a7
#rb max.chen

#ROBOMERGE-OWNER: max.chen
#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 18954849 via CL 18954889 via CL 18954905 via CL 18955927 via CL 18956265
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18958367 by HertzDonut in ue5-main branch]
2022-02-11 14:43:42 -05:00
max chen
85a60982d3 Template Sequence: Fix import fbx onto template sequence
Import fbx onto template sequence works by creating a temporary template sequence player, spawns the necessary objects, and then matches the objects to the imported fbx data. The issue here was that the spawnables weren't spawning because the binding override is by default to not override the default. With template sequences, usually you have another object that takes the place of the binding. By setting this false in FindOrAddBinding, this allows the temporarily spawned objects to be found and mapped onto.

#jira UE-129635
#preflight 620443af724404041865387d
#rb mike.zyracki, ludovic.chabant
#lockdown simon.tourangeou

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 18938477 in //UE5/Release-5.0/... via CL 18938664 via CL 18938862
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18938868 by max chen in ue5-main branch]
2022-02-10 12:42:59 -05:00
max chen
d9c8be28de Sequencer: Enhance the display rate mismatch tooltip with the names of the level sequences that are not matching.
#preflight 6203fd1472440404185ba530
#rb none

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 18922933 via CL 18925174 via CL 18925297 via CL 18926920 via CL 18928734
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18929182 by max chen in ue5-main branch]
2022-02-09 19:25:21 -05:00
max chen
596791b17f Sequencer: Display the bound object class in tooltip
#preflight 61fc8a8a2839dd07cb841b76
#rb matt.hoffman, mike.zyracki
#jira UE-141236

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 18864717 via CL 18864723 via CL 18864743 via CL 18864978 via CL 18867674
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18867753 by max chen in ue5-main branch]
2022-02-04 13:31:39 -05:00
andrew davidson
3debbbd465 Fix FVector2D variant casts
Submitted on behalf of fred.kimberley
#rb andy.davidson
#preflight 61f8719ea6632a34f35e654b

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18801709 in //UE5/Release-5.0/... via CL 18802160 via CL 18821533
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18821619 by andrew davidson in ue5-main branch]
2022-02-02 01:45:23 -05:00
max chen
e8b516997d Sequencer: Console variable track
#jira UE-132512
[FYI] andrew.rodham
#rb max.chen, matt.hoffman
#preflight 61f2d3e6801201ab3861943e

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 18755112 in //UE5/Release-5.0/... via CL 18755119 via CL 18757588
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18758553 by max chen in ue5-main branch]
2022-01-27 14:37:04 -05:00
max chen
1631bfe236 Sequencer: Follow up to 18551247 - Assign Actor missing scene outliner chooser
#rb matt.hoffman
#preflight 61f073d8716bb9c66a378e98

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 18729032 in //UE5/Release-5.0/... via CL 18729041 via CL 18729132
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18729155 by max chen in ue5-main branch]
2022-01-25 17:25:42 -05:00
max chen
c326e6bf65 Sequencer: Add the ability to bind a possessable to a spawnable object
FMovieScenePossessable now has an FMovieSceneObjectBindingID which can be set to bind to a spawnable object. Calling sites should invoke BindSpawanbleObject which will establish the FMovieSceneObjectBindingID which is resolved in FMovieSceneObjectCache::UpdateBindings

#jira UE-120385
#preflight 61e204a84b4bd12cbeea3e2a
#rb andrew.rodham

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 18680446 in //UE5/Release-5.0/... via CL 18680469 via CL 18680842
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18681445 by max chen in ue5-main branch]
2022-01-20 16:28:08 -05:00