Commit Graph

1480 Commits

Author SHA1 Message Date
graeme thornton
78a8cdcea2 Edigration of an FLinkerLoad optimization from Dev-Core CL 5709116
Second optimization to a heavily hit function that uses an FArchiveFromStructuredArchive adapter. That class needs optimization, so temporarily use a straight FArchive path when text archive support is compiled out

fyi ben.woodhouse, gil.gribb, per.larsson


#ROBOMERGE-SOURCE: CL 5716883 via CL 5716884 via CL 5716885 via CL 5716886 via CL 5717811

[CL 5717889 by graeme thornton in Main branch]
2019-04-03 20:26:14 -04:00
bob tellez
4d0b37e95b #UE4 Improve logging when assets fail to load. Failing to get the package linker will now produce fewer redundant log messages and all failure messages will include the asset that failed to load as well as the asset that was requesting the linker where possible.
#rb Robert.Manuszewski


#ROBOMERGE-SOURCE: CL 5713888 via CL 5714486

[CL 5714487 by bob tellez in Main branch]
2019-04-03 17:25:42 -04:00
robert manuszewski
f97b1e4bc4 Fixing crashes in pkg info commandlet
#rb none


#ROBOMERGE-SOURCE: CL 5707932 via CL 5708541 via CL 5708552 via CL 5708563 via CL 5708976

[CL 5709035 by robert manuszewski in Main branch]
2019-04-03 10:00:26 -04:00
bob tellez
7396c91431 #UE4 Fix a bug that caused logs about missing assets to not show their referencer
#ROBOMERGE-SOURCE: CL 5641069 via CL 5641333

[CL 5648075 by bob tellez in Main branch]
2019-03-29 13:35:47 -04:00
bob tellez
0ae7f9c6dd Back out changelist 5533504. Crash at startup on forking linux servers. (Missing referencer information)
#ROBOMERGE-SOURCE: CL 5571078 via CL 5572105

[CL 5572109 by bob tellez in Main branch]
2019-03-26 20:30:52 -04:00
daniel lamb
a8961eae8e Fixed crash in diff cook commandlet.
#ROBOMERGE-OWNER: daniel.lamb
#ROBOMERGE-AUTHOR: daniel.lamb
#ROBOMERGE-SOURCE: CL 5558994 via CL 5559027 via CL 5560253
#rb Andrew.Grant

[CL 5561251 by daniel lamb in Main branch]
2019-03-26 16:15:43 -04:00
pj kack
5bde52e113 Copying task stream Dev-cook to Main
Integrate all cook -iterate optimizations from //UE4/Dev-core/...

Test Scenario:
1) BuildCookStageAndRun with these arguments: -platform=Win64 -configuration=Development
2) CookIterate with these arguments: -run=Cook -CookCultures=en -TargetPlatform=WindowsClient -unversioned -stdout -unattended -iterate

Wall Time Results (as an average of running step 2) two times):
Before: ~09:40 (580 seconds) cook commandlet time
After: ~02:30 (150 seconds) cook commandlet time
=> 07:10 (430 seconds ) faster, i.e. a ~ 3.9x speedup

Win32 FileSystem Results:
Before: 1.5 million GetFileAttribute calls and 1.2 million FindNextFile calls
After: 35 0000 GetFileAttribute calls and 1.6 million FindNextFile calls
=> ~400 000 calls to FindNextFile replaces ~1.5 million calls to GetFileAttribute

#rb none


#ROBOMERGE-SOURCE: CL 5533504 via CL 5533655

[CL 5536177 by pj kack in Main branch]
2019-03-25 14:18:15 -04:00
marc audy
fe5d6790eb Fix crash on shutdown depending on order of globals being destroyed
#jira
#rnx


#ROBOMERGE-SOURCE: CL 5494625 via CL 5494635 via CL 5494639 via CL 5497857

[CL 5497991 by marc audy in Main branch]
2019-03-21 20:06:38 -04:00
dan oconnor
fc7d779e10 Avoid resetting bExportLoadFailed when an object is destroyed, allows exports to stay invalidated after a GC call. Also we now invalidate exports for nodes replaced via ReplaceOldNodeWithNew
#rb Robert.Manuszewski
#jira UE-70904
#lockdown Cristina.Riveron

#ROBOMERGE-SOURCE: CL 5497598 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5497599 by dan oconnor in Main branch]
2019-03-21 18:39:31 -04:00
robert manuszewski
2de878076d Fixing crash when the engine tries to open content saved with a newer engine version
#jira UE-71880
#rb none
#lockdown cristina.riveron

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5496341 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5496403 by robert manuszewski in Main branch]
2019-03-21 16:52:46 -04:00
marc audy
acee091a8b Rework sparse delegate storage to not use uobject annotation and manage its own map and lock state. This eliminates unnnecessary annotation cache overhead and ensures entire operation on map is completed while the lock is in place rather than copying per-object map out of the annotation and then moving modified inner per-object map back in to the annotation as two separately locked actions.
#rnx


#ROBOMERGE-SOURCE: CL 5483896 via CL 5483909 via CL 5483913 via CL 5487278

[CL 5487454 by marc audy in Main branch]
2019-03-20 18:47:33 -04:00
steve robb
185fddd5c3 Fix for warnings about engine classes being hot reloaded when they haven't even changed.
#jira UE-71581
#rb none
[FYI] jamie.dale
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 5459196 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5459199 by steve robb in Main branch]
2019-03-19 15:56:12 -04:00
steve robb
336b8ef46a Fix to stop UClass CDOs trying to have their token streams reassembled on hot reload.
#rb robert.manuszewski
#jira UE-71566

#ROBOMERGE-SOURCE: CL 5415461 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5415463 by steve robb in Main branch]
2019-03-15 11:58:19 -04:00
bob tellez
918443f107 #UE4 Remove redundant call to DetachFromLinkers. It was causing a crash when using EDL
[FYI] Robert.Manuszewski


#ROBOMERGE-SOURCE: CL 5407194 via CL 5407308

[CL 5407320 by bob tellez in Main branch]
2019-03-14 22:46:35 -04:00
robert manuszewski
2a7ffe536c Restoring accidentally commented out code
#rb none


#ROBOMERGE-SOURCE: CL 5401325 via CL 5404234

[CL 5404237 by robert manuszewski in Main branch]
2019-03-14 18:29:15 -04:00
robert manuszewski
18af3fafa2 Fixing a crash when detaching linkers from serialize context
#rb none
#jira UE-69177

#ROBOMERGE-SOURCE: CL 5402557 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5402563 by robert manuszewski in Main branch]
2019-03-14 17:26:56 -04:00
robert manuszewski
1ec0b9cc86 Fixing issues with objects not being serialized before they are being ConditionallyPostLoaded by other objects and LoadContext related crashes
#rb none



#ROBOMERGE-SOURCE: CL 5399372 via CL 5400965

[CL 5401943 by robert manuszewski in Main branch]
2019-03-14 17:16:47 -04:00
robert manuszewski
ced336ef57 Fixing issues with objects not being serialized before they are being ConditionallyPostLoaded by other objects and LoadContext related crashes
#rb none
#jira UE-69177

#ROBOMERGE-SOURCE: CL 5401696 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5401697 by robert manuszewski in Main branch]
2019-03-14 17:10:18 -04:00
bob tellez
a1f4ba15a1 #UE4 Disabling an assert as a workaround until Core team can investigate
[FYI] Rob.Manuszewski


#ROBOMERGE-SOURCE: CL 5377088 via CL 5377214

[CL 5378944 by bob tellez in Main branch]
2019-03-12 23:33:01 -04:00
marc audy
c4199f8a71 Fix sparse multicast delegates operating on the wrong object when binding, removing, or clearing on an object from another object's blueprint.
#jira
#rnx


#ROBOMERGE-SOURCE: CL 5370086 via CL 5370286 via CL 5373422

[CL 5377685 by marc audy in Main branch]
2019-03-12 23:18:51 -04:00
jamie dale
9069eb815f Fixed containers failing to gather required instance overrides
If a container element is overridden on an instance, then the entire container is serialized into the instance with different keys than the archetype. This means that all elements of a container need to be gathered if any elements within the container have changed.

#jira UE-71447
#rb Francis.Hurteau
#rnx

#ROBOMERGE-SOURCE: CL 5371132 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5371133 by jamie dale in Main branch]
2019-03-12 16:19:05 -04:00
arciel rekman
45b507754b Fix clang builds.
#rb none
[FYI] Robert.Manuszewski
#jira none

#ROBOMERGE-SOURCE: CL 5369429 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5369431 by arciel rekman in Main branch]
2019-03-12 11:10:22 -04:00
robert manuszewski
a0a969bd9f Allow the deterministic cook commandlet to open cooked content in the editor regardless of the 'cook.AllowCookedDataInEditorBuilds' ini setting
#rb none
#jira UE-71333

#ROBOMERGE-SOURCE: CL 5368203 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5369004 by robert manuszewski in Main branch]
2019-03-12 10:39:16 -04:00
robert manuszewski
b0dd7668c0 Fixing a crash when the engine fails to open a package for comparison in the deterministic cooking commandlet
#rb none
#jira UE-71333

#ROBOMERGE-SOURCE: CL 5368036 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5369001 by robert manuszewski in Main branch]
2019-03-12 10:39:07 -04:00
ben marsh
17cfb7b724 Core: Fix pop-up dialogs when loading corrupt assets in unattended sessions, causing jobs to hang on build machines.
[FYI] Steve.Robb
#jira UE-71404
#rb none

#ROBOMERGE-SOURCE: CL 5365414 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5368510 by ben marsh in Main branch]
2019-03-12 10:10:08 -04:00