Commit Graph

10648 Commits

Author SHA1 Message Date
chris constantinescu
ae281656f2 Tests converted from 18848115 made to work multi-platform.
Not all were converted because they were designed for packaged applications whereas low level tests are designed to run as "native" non-packaged applications.
- reporting support for non-desktop platforms, for the moment Catch2 report type "console" is used that is sent to a .out file
- most number of tests possible running multi platform, slower tests excluded on incremental builds
- slow tests are moved to run on the monolithic build
- Catch2 report failure event listener such that Horde detects them as build errors. Must add new Horde matcher for Catch2 failures

#rb Mark.Lintott
#preflight 623c8de389625f0612dabd64

[CL 19498448 by chris constantinescu in ue5-main branch]
2022-03-24 13:28:25 -04:00
aditya ravichandran
80eb702b49 SSearchableComboBox: Partially revert change 19356303 (commit selection on Enter for keyboard navigation) due to potential fallout.
#rb trivial
#preflight 623c88f4bc1cf280388a0ae0

[CL 19496181 by aditya ravichandran in ue5-main branch]
2022-03-24 11:29:45 -04:00
CarlMagnus Nordin
07a8404c48 IoStoreShaderCodeLibrary: Fixed issue with library names containing dashes
#preflight 623c1b9cbc1cf2803885575e
#rb pj.kack

[CL 19495934 by CarlMagnus Nordin in ue5-main branch]
2022-03-24 11:16:24 -04:00
charles bloom
6dd0a22ef5 nop fix comments
#rb none
#preflight none

[CL 19495502 by charles bloom in ue5-main branch]
2022-03-24 10:45:24 -04:00
Catalin Dragoiu
0b81859aa7 [Insights] When all nodes are filtered out or the tree contains no nodes, show a warning banner.
#rb Ionut.Matasaru
#preflight 623c6126da56b5683a153866

[CL 19494928 by Catalin Dragoiu in ue5-main branch]
2022-03-24 09:58:24 -04:00
paul chipchase
b2be464942 Remove the check for FPackageTrailer::IsEnabled when virtualizing payloads. We don't care if the system is currently disabled, only what the package file itself contains.
#rb trivial
#rnx
#preflight 623c5912c3399da9533ffd30

- The package trailer will be on by default soon and the option to remove it disabled, so this check is a bit pointless anyway.

[CL 19493442 by paul chipchase in ue5-main branch]
2022-03-24 08:17:01 -04:00
ionut matasaru
2fcaed6908 [Insights]
- Tree Views: Further improved performance of sorting by FText columns and reduced memory cost while sorting. Added improved sorter for FText columns with available id (uint64).
  - Memory Insights: Improved performance of sorting by Function column by using the new sorter of FText values with id. Stress test (a tree with 3.5M allocs): speed improved from 4min to 27sec; memory usage improved from ~1 GiB to ~100 MiB.

#rb Catalin.Dragoiu
#preflight 623c3d748900c14eecdd0ef3

[CL 19493238 by ionut matasaru in ue5-main branch]
2022-03-24 07:09:32 -04:00
CarlMagnus Nordin
8984c81407 UnrealInsights: Improved callstack butterfly, recursive calls will now be merged instead of displayed as individual nodes in the tree
#preflight 623ad714c3399da9532bbf8a
#rb ionut.matasaru

[CL 19492566 by CarlMagnus Nordin in ue5-main branch]
2022-03-24 03:19:09 -04:00
Zousar Shaker
4b6d3f3a0a Fix bug where the Content-Type header had multiple conflicting entries when posting compact binary during Horde Storage communications:
+		[1]	L"Content-Type: application/x-ue-cb"	FString
+		[2]	L"Content-Type: application/x-www-form-urlencoded"	FString

#rb devin.doucette
#rnx
#preflight 623bfe051302f69e9a9b5e1e

[CL 19492306 by Zousar Shaker in ue5-main branch]
2022-03-24 01:28:28 -04:00
lauren barnes
9f8a8ea57b If dismissing a toast created by the message log, set the expire duration to 0.
#jira UE-127439
#rb Brooke.Hubert
#preflight 6239e5d9b3653cf6afda7ed1

#ROBOMERGE-OWNER: lauren.barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 19470291 via CL 19486226 via CL 19486233
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v936-19480137)

[CL 19487546 by lauren barnes in ue5-main branch]
2022-03-23 18:26:01 -04:00
Zousar Shaker
03207d24ea Allow OAuth access scope to be configurable for a Horde Storage DDC store. Supplied by partners.
#rb devin.doucette
#rnx
#preflight 623b9723c73745c600c264e6

[CL 19487258 by Zousar Shaker in ue5-main branch]
2022-03-23 18:05:53 -04:00
Devin Doucette
436b6a6461 DDC: Added IRequestOwner::LaunchTask
- Added IRequestOwner::LaunchTask to launch a task as a request in the request owner.
- Renamed ExecuteInCacheThreadPool to LaunchTaskInCacheThreadPool.
- Made GCacheThreadPool private to one source file.
- Changed task scheduling throughout DDC to use these functions where appropriate.

#preflight 623b846d8900c14eecd4daa4
#rb Zousar.Shaker

[CL 19485686 by Devin Doucette in ue5-main branch]
2022-03-23 16:56:39 -04:00
Johan Duparc
9d196ada09 Datasmith: New mesh serialization, MeshDescription based
#rb JeanLuc.Corenthin
#jira none
#preflight 623b758ab3653cf6aff79b97

[CL 19485120 by Johan Duparc in ue5-main branch]
2022-03-23 16:31:37 -04:00
avudnez
a8d559fbad PR #9001: Fix building LiveCodingConsole with clang-cl (Contributed by avudnez)
#rb self
#rnx
#jira UE-146904
#preflight 623b78e4ca34ffd7bf7f9874

[CL 19484226 by avudnez in ue5-main branch]
2022-03-23 15:59:49 -04:00
fabian giesen
2674aa70e9 TextureCompressorModule simplify and improve parallel mip encoding
Pixel count in mip maps is in a geometric progression: each 2D mip has 4x as many pixels as the one below it,
and 3x as many as the sum of all mips below it. Therefore, a parallel for over mip levels is not very useful:
the vast majority of work is in the base mip, and leaving the base mip (which is on our critical path) for a
worker to pick up adds whatever time it takes for a worker to get started on it to our expected total time.

Therefore, change the logic so the calling thread grabs the base mip itself, and spawns exactly one other
task before to process all the other mips. This should reduce the number of tiny, useless tasks we spawn,
and because this single async task is expected to take 1/3 of the time as the base mip task, we have a decent
amount of slack for queuing delays without it showing up as a real wait time.

#rb martins.mozeiko, devin.doucette
#preflight 623b749110251d53d58911cf

[CL 19483730 by fabian giesen in ue5-main branch]
2022-03-23 15:39:16 -04:00
zach bethel
840403dd99 Fixed data race and potential double delete in FCanvas deletion path.
#rb mihnea.balta
#preflight 623b70697b69b01ec16560b3
#jira UE-144044

[CL 19483611 by zach bethel in ue5-main branch]
2022-03-23 15:29:20 -04:00
Charles deRousiers
546f1b27c6 Add ROV type support for shader binding.
#rb mihnea.balta
#jira none
#preflight 623b31aaca34ffd7bf7ca796

[CL 19481254 by Charles deRousiers in ue5-main branch]
2022-03-23 13:02:24 -04:00
Catalin Dragoiu
07fa578bcd [Insights] Convert the LLM tag filter to use a Suggestion Text Box.
Suggestion text boxes in Insights filter will now display all options when the up or down arrow is pressed and the text box is empty.
#rb Ionut.Matasaru
#preflight 623b3809ca34ffd7bf7cc256

[CL 19479909 by Catalin Dragoiu in ue5-main branch]
2022-03-23 11:30:28 -04:00
paul chipchase
97fbde0880 Expose the package submission checks we run when submitting changelists from within the editor so that other systems can specifically invoke it in addition to running it when ever a source control module callback is invoked.
#rb PJ.Kack
#rnx
#preflight 623ae40e7b69b01ec15da75c
#robomerge FNNC

- We need to expose the code that checks a set of packages for non virtualized payloads and virtualizes them so that the stand alone submission tool can access it.
- Currently I am adding this to the IVirtualizationSystem interface to avoid adding additional interface, but we might want to consider moving this some day as it is not a great fit with the rest of the interface.

[CL 19479757 by paul chipchase in ue5-main branch]
2022-03-23 11:14:47 -04:00
ionut matasaru
b5a93425cc [Insights] Context Switches: Changed "Core Tracks" option name into "CPU Core Tracks".
#rb trivial
#preflight 623ade4cda56b5683a03b6d7

[CL 19477099 by ionut matasaru in ue5-main branch]
2022-03-23 05:05:29 -04:00
Maxwell Hayes
4d967c3450 Added missing ModularFeatureList lock/unlock
#jira UE-146734
#rb Aaron.McLeran, Phil.Popp
#preflight 623a53eb88538cd45eef0f33

[CL 19473764 by Maxwell Hayes in ue5-main branch]
2022-03-22 19:14:21 -04:00
Rob Gay
d5b2729860 Default to 'direct' ESelectInfo in SSearchableComboBox::SetSelectedItem
- Internal SelectedItem member was not getting set after last fix to avoid selection on key navigation while the menu was open
- Minor clean-up
#rb aditya.ravichandran
#rnx
#jira UE-146837
#preflight 623a0a68ec68595f3b88a242
#preflight 623a0a68ec68595f3b88a242

[CL 19469217 by Rob Gay in ue5-main branch]
2022-03-22 14:01:46 -04:00
zach bethel
50274e3050 Converted FIntPoint / FIntVector / FIntRect to a template type and added unsigned variants.
#rb luke.thatcher, andrew.davidson, steve.robb
#preflight 6239e9d204769ab49354a30f

[CL 19468937 by zach bethel in ue5-main branch]
2022-03-22 13:40:58 -04:00
rune stubbe
8292810479 Fixed potential streamer crash by fixing the non-determinism issues in the Nanite builder.
Because of assumptions in the DDC system about cooking being deterministic, we could under various circumstances end up in a situations where StaticMesh and the associated Nanite streaming data was coming from two different cooks.
This could easily cause a crash as the StaticMesh chunk contains explicit page and offset references into the streaming data.

Determinism fixes:
-Added sorting step during initial clustering in the case where an edge is shared by more than 2 triangles.
-Added sorting step to sort parent clusters after they have been generated.
-Changed cluster GUID from 32bit to 64bit. When cooking CitySample there was one case where two clusters that were compared ended up with the same GUID, resulting in undefined order.
-Initialized GUID in the cluster constructor that takes a list of clusters to merge. Before it would just be 0.
-Added missing initialization of vertex color on fallback meshes that don't use vertex color.

#jira UE-146347
#rb brian.karis, michal.valient
#preflight 6238817789625f06129f616f

#ushell-cherrypick of 19458684 by Rune.Stubbe
#lockdown Marc.Audy

#ROBOMERGE-AUTHOR: rune.stubbe
#ROBOMERGE-SOURCE: CL 19467008 in //UE5/Release-Engine-Staging/...
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v935-19464907)

[CL 19468567 by rune stubbe in ue5-main branch]
2022-03-22 13:10:29 -04:00
Catalin Dragoiu
e0475b1694 Screenshot tracing initial implementation
#rb Ionut.Matasaru Johan.Berg
#preflight 6239f65abc1cf2803864a90c

[CL 19467957 by Catalin Dragoiu in ue5-main branch]
2022-03-22 12:35:42 -04:00