#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3851142 by Robert.Manuszewski
When BP clustering is enabled, make sure to add the template to the BP cluster when replacing it.
Change 3853797 by Ben.Marsh
BuildGraph: Add a <Trace> element, which allows logging messages after the string is parsed (as opposed to the Log task, which logs them at runtime). Useful for debugging macro expansion, etc...
Also add a -showdiagnostics parameter, to have diagnostic messages output even when running with the -listonly option.
Change 3857540 by Graeme.Thornton
Properly process the uexp file for a umap asset when generating a pak patch. Stop those uexp files being included in the patch even when they haven't changed
Change 3860062 by Steve.Robb
Fix for FString::Reset()'s buffer not being an empty null-terminated string (affects FString::ParseIntoArray, for example).
Change 3860138 by Steve.Robb
Fix for FString::ParseIntoArray() for when string memory has been allocated but has no characters.
Change 3860273 by Steve.Robb
Tidy up of FHotReloadClassReinstancer::FCDOWriter to not do stuff in constructors.
Change 3863203 by Steve.Robb
Crash fix for UObjects whose constructors are defined as = default;, which would re-null the UObject state (ClassPrivate, OuterPrivate etc.).
See: https://udn.unrealengine.com/questions/412930/crash-due-to-default-constructor.html
Change 3864588 by Graeme.Thornton
Crypto Keys Improvements
- Removed UAT command line params for encryption. Centrally configured by the editor settings now.
- UAT staging now creates a small json file containing the keys and settings used for encryption and signing and stores it in the build metadata
- Minor refactoring of UAT encryption processing to use the new cryptokeys json file
- UnrealPak can be told to get its encryption settings from a json crypto file with the "-CryptoKeys=<filename>"
- UnrealPak can now accept a "PatchCryptoKeys=<filename" parameter which gives it a filename to a cryptokeys json file that it can use to unpack the patch reference paks
Change 3864691 by Robert.Manuszewski
Don't add objects that are in root set to GC clusters to prevent them from keeping the clusters alive forever.
Change 3864744 by Robert.Manuszewski
Added the ability to get the actual filename of the log file FOutputDeviceFile writes to.
Change 3864816 by Graeme.Thornton
TBA: Minor formatting improvements to textasset commandlet
Change 3868939 by Graeme.Thornton
TBA: If -outputPath isn't supplied to TextAsset commandlet, output converted files to the {ProjectSaved}/TextAssets directory
Change 3869031 by Graeme.Thornton
TBA: Changed timing logs in TextAsset commandlet to be Display so we can see them in the EC log
Change 3871802 by Steve.Robb
Class cast flags and property flags are now visible in the debugger.
Change 3871863 by Robert.Manuszewski
Serializing object will now be passed to GC so that it can be logged in case the referenced objects is garbage.
Change 3874413 by Steve.Robb
Algo::MinElement and Algo::MaxElement, for finding the minimum and maximum element in a range, and *By versions which take projections.
TRangePointerType moved to its own file and used in Algo::MinElement and Algo::MaxElement.
Change 3874457 by Ben.Marsh
When spawning child processes, only allow them to inherit the writable ends of the stderr and stdout pipe. Fixes an issue related to AutomationTool hanging when the editor closes after running automation tests.
The editor launches ADB.EXE (Android Debug Bridge) on editor startup, which forks itself to initialize a server. Even though the child process has its own stdout and stderr pipes, it also inherits the pipes for the editor. When run from C#, as we do for automation tests, Process.WaitForExit() waits for all pipes to be closed before returning. This can't happen if the forked ADB instance still has a reference to the editor's pipes.
Change 3876435 by Robert.Manuszewski
Don't add root set objects to level actor container to prevent situations where clusters are kept alive forever
Change 3878762 by Robert.Manuszewski
Fixing potential LinkerLoad leak when a package that still has a linker associated with it is being destroyed.
Change 3878850 by Robert.Manuszewski
SerializePreloadDependencies will now serialize raw data into the array instead of serializing one element at a time to speed up serialization performance.
Change 3881331 by Graeme.Thornton
TBA: SavePackage rejigged to write all header information in terms of FStructuredArchive, with all exports written through an FArchive adapter
Change 3886983 by Ben.Marsh
UGS: Fix notification window not expanding to fit long captions.
Change 3887006 by Ben.Marsh
UGS: Change modal dialog to regular window style to avoid weird alignment issues under Windows 10.
Change 3887500 by Ben.Marsh
UGS: Add support for grouping build badges by a prefix. Badges such as "Foo:Bar1", "Foo:Bar2" will be grouped together (with "Foo:" stripped from the displayed badge names).
Also add a separate column showing the type of each change, rather than including it in the CIS column, and change badges to a more angular Windows 10 style.
Change 3887513 by Ben.Marsh
UGS: Fix badge text drawing outside the clipping bounds.
Change 3888010 by Josh.Engebretson
Fix UVS logging to UnrealVersionSelector/Saved/Logs and instead use project's log path
#jira none
Change 3888418 by Ben.Marsh
UGS: Add a cache for computed badge layout information. Improves responsiveness when redrawing.
Change 3889457 by Steve.Robb
GitHub #4457 : Display abbreviations properly when converting FNames to display string
#jira UE-54611
Change 3889547 by Ben.Marsh
UGS: Add an extensible method for adding arbitrary badges to the right of the "description" column, by running a regular expression over the changelist description.
Epic uses a "#tag" style annotations in changelist descriptions and Perforce triggers to verify them. "#jira" is used to link a changelist to an issue tracked in Jira, for example. A matcher to add a badge next to every changelist with a #jira tag, and link to the corresponding issue in Jira, could be set up with an addition to the project's Build/UnrealGameSync.ini file like this:
[Badges]
+DescriptionBadges=(Pattern="(?i)#\\s*jira\\s*:?\\s+([A-Za-z]+-[0-9]+)", Name="$1", Group="Jira", Color="#c0c0c0", HoverColor="#e0e0e0", Url="https://jira.it.epicgames.net/browse/$1")
The "Pattern" attribute specifies the regex to match, and may capture portions of the matched text to be substituted later. "Label" specifies the label to appear on the badge. "Group" specifies an arbitrary identifier used to group related badges together rather than separating them with whitespace. "Color" and "HoverColor" specify hex RGB colors for the badges. "Url" specifies the path to open with a C# Process.Open call if the badge is clicked.
Change 3889726 by Ben.Marsh
UGS: Fix description badges that don't have any associated URL.
Change 3889995 by Ben.Marsh
UGS: Fix issue where popup menus can create top level windows in the taskbar. Seemlingly caused by capturing mouse before the window has been activated - removed capture code, and replaced with handling of OnMouseLeave() event instead.
Change 3890007 by Ben.Marsh
UGS: Add a caption underneath the project logo which shows the current stream, to make it more obvious.
Change 3890057 by Ben.Marsh
UGS: Fix repainting glitch when resizing window; bounds for status panel lines was not being reset correctly.
Change 3891069 by Robert.Manuszewski
Fixing a crash in MallocBinned2 when running with malloc profiler enabled.
Change 3891084 by Steve.Robb
Back out changelist 3881331 because it's causing cook errors.
Change 3891100 by Ben.Marsh
UGS: Add support for a per-branch "message of the day"-style feature. Messages can be specified in a project's config file in Perforce (eg. <ProjectDir>/Build/UnrealGameSync.ini) as follows:
[//UE4/Main/Samples/Games/ShooterGame.uproject]
Message=:alert: Lockdown for fixes is **5pm on Friday**. Only fixes for the 2.0 release should be submitted to this branch. [34 issues](https://jira.it.epicgames.net) are remaining as of 2/15.
A limited subset of Markdown is supported: [web links](http://www.google.com), *italic*, _italic_, **bold**, __bold__. Icons will be supported through :icon: syntax; the only icon currently available is :alert:
Change 3891346 by Steve.Robb
TSharedPtr::operator bool, and some usage of it.
Change 3891787 by Steve.Robb
Fix for buffer overflow in FDebug::LogFormattedMessageWithCallstack().
Change 3892379 by Ben.Marsh
UGS: Fix notification window containing the group fix for each build type.
Change 3892400 by Ben.Marsh
UGS: Shrink the size of the alert panel.
Change 3892496 by Ben.Marsh
UGS: Dim badges for changes which aren't eligable for syncing.
Change 3893932 by Steve.Robb
Re-removal of SetShouldHandleAsWeakRef, which was originally removed in CL# 3437205.
Change 3895872 by Ben.Marsh
UGS: Show the stream name in tab labels by default.
Change 3896366 by Ben.Marsh
UGS: Automatically resize columns when the main window is resized, and allow specifying desired column widths for projects that have a large number of CIS badges.
Columns are now resized proportionally, clamped to a minimum size. Columns will automatically expand up to a desired maximum size, though can be explicitly resized larger if necessary. Columns will not be resized if they are already larger than the window can show, or smaller than the window has space to show.
Change 3896367 by Ben.Marsh
UGS: UI tweaks - change and time columns are now centered, "Unknown" badge is displayed until a change's type has been determined, increase height of status panel.
Change 3896425 by Ben.Marsh
UGS: Speculative fix for race condition on clients displaying "under investigation" state. If the DB event is received before a change where an investigation is cancelled is polled from Perforce, we will exclude the resolve event from the list of active investigations.
Change 3896461 by Ben.Marsh
UGS: Add an option to allow setting a tint color to be applied to the status panel, to allow identifying streams more easily. To use, add a setting similar to the following to a project's Build/UnrealGameSync.ini file:
[//UE4/Main/Samples/Games/ShooterGame/ShooterGame.uproject]
StatusPanelColor=#dcdcf0
Change 3899530 by Ben.Marsh
Add unified syntax for overriding branch specific settings. Checks branch settings first, then [Default] section.
Change 3901164 by Ben.Marsh
UGS: Add a class to store all the resources for the status panel.
Change 3901165 by Graeme.Thornton
TBA: Attempt #2 at submitting the text asset saving code. SavePackage rejigged to write all header information in terms of FStructuredArchive, with all exports written through an FArchive adapter. Minimal amount of structured archive serialization functions added to allow this data to be written
Change 3901301 by Ben.Marsh
UGS: Add support for reading the latest version of the project config file from Perforce. Some settings should be read depending on the CL you are synced to (eg. build steps), whereas others (MOTD, branch status) should always use the latest version. Will read the local version if checked out, to allow testing local changes.
Change 3902454 by Ben.Marsh
UGS: Fix logo not being redrawn in the correct position when starting to sync.
Change 3903416 by Ben.Marsh
UGS: Group badges explicitly through INI file rather than by expecting name to contain ':'.
Change 3904154 by Josh.Engebretson
Adding Breakpad to ThirdParty sources (Git Commit: 49907e1c3457570f56d959ae26dec6c3a5edd417 https://chromium.googlesource.com/breakpad/breakpad)
#jira UE-55442
Change 3904648 by Ben.Marsh
UGS: Remove files from the workspace that are excluded by the sync filter.
The user's config file stores a hash of the last sync filter. During syncing, if this hash doesn not match the previous value, we enumerate all the files in the #have list and remove anything masked out by the filter.
#jira UE-47335
Change 3905442 by Steve.Robb
Change of the ConvertFromType() multi-bool return value to a more descriptive enum.
Some return values here do not make sense - this is because the existing logic is being preserved and will be fixed in a separate change.
Change 3905629 by Ben.Marsh
UGS: Fix race condition between two child processes starting on different threads, and inheriting the other's intended stdout/stderr pipes. This prevents pipes being closed when one of the child processes shuts down, and causes waits on the read ends of those pipes to continue indefinitely.
Change 3906447 by Steve.Robb
Rename EConvertFromTypeResult enumerators.
Change 3906574 by Steve.Robb
Crash fix for container conversion failure during tagged property import.
Change 3909255 by Daniel.Lamb
Fixed issue with DLCpackaging crashing on windows
#jira UE-42880
#test EngineTest windows
Change 3909270 by Steve.Robb
Seek instead of skipping bad properties byte-by-byte.
Change 3909324 by Steve.Robb
Use switch statement instead of repeated if/else.
Change 3909525 by Ben.Marsh
UGS: Use the StudioEditor target when syncing content-only Enterprise projects.
Change 3911754 by Daniel.Lamb
Fix for building pak patches.
#jira UE-55340
Change 3911942 by Robert.Manuszewski
Fixing an ensure when MediaPlayer is being constructed from any thread other than the main one.
Change 3913067 by Ben.Marsh
UGS: Allow workspace sync filter categories to re-enable categories that are disabled by the global filter.
Change 3913209 by Ben.Marsh
UGS: Fix incorrect target name when compiling Enterprise projects.
Change 3917358 by Steve.Robb
Fix for GetLen(FString).
Change 3919610 by Ben.Marsh
Put data for CrashReportClient in a PAK file of its own (under Engine/Programs/CrashReportClient/Content/Paks/CrashReportClient.pak). There are a large number of small files required for it to run with loose files, which takes a lot of space on disk (due to cluster sizes), and is unweildy to move around.
CrashReporter UFS files are tracked in a separate dictionary to regular UFS files to allow construction of the additional PAK file.
Change 3921002 by Ben.Marsh
UGS: Add option for syncing all projects in a branch. Off by default. Also add support for masking in additional paths to be synced (eg. one or two extra projects).
Change 3921008 by Ben.Marsh
UGS: Prevent pause waiting for mutual exclusivity when syncing precompiled binaries. We don't need to generate project files or build, so there's no need to wait in line.
Change 3921906 by Steve.Robb
New interpolation functions for quaternions.
https://udn.unrealengine.com/questions/419028/quaternion-interp-to-functions.html
Change 3921978 by Graeme.Thornton
TBA: Make "Loader" member of FLinkerLoad private to prevent use outside of FLinkerLoad. This archive could be something unexpected if the linker is for a text asset package, so we need to stop people accessing it.
Change 3924520 by Graeme.Thornton
UnrealPak: Improve encryption summary log messages
Change 3924522 by Graeme.Thornton
UAT: Add *Encryption.ini to the list of auto-blacklisted config filenames
Change 3924604 by Graeme.Thornton
UnrealPak: If encryption keys are parsed and fail the encrypt/decrypt test, throw a fatal error. The exectutable will have those same keys embedded so there is no point allowing the paks to be created with broken keys.
Change 3924638 by Graeme.Thornton
Crypto: Improvements to parsing of old fashioned encryption.ini settings:
- AES keys that are too long or short (need to be 32 bytes) will now emit a warning when being parsed, and be truncated or expanded before adding to the crypto settings.
- Signing keys will emit an error when they are too long (>64bytes)
- Unrealpak will still assert when invalid settings are passed via the other mechanisms (command line or -encryptionini mode). Settings via the crypto json file should now be sanitized and not cause issues
#jira UE-55080
Change 3924747 by Steve.Robb
Fix for degrees.
Change 3925459 by Chad.Garyet
Adding check to not to attempt to delete autosdk workspace if it doesn't already exist.
Change 3926703 by Ben.Marsh
BuildGraph: Include the path to the XML file when displaying an XML parse error.
Change 3926917 by Ben.Marsh
UBT: Allow overriding the name of the UE4 solution on a branch-specific basis. Useful for switching between multiple UE4 workspaces. Also add support to the editor and UGS for opening the correct solution (determined via a text file saved to Engine/Intermediate/ProjectFiles).
Set the solution name using an entry in BuildConfiguration.xml as follows:
<ProjectFileGenerator>
<MasterProjectName>UE4_Main</MasterProjectName>
</ProjectFileGenerator>
Change 3927683 by Graeme.Thornton
UAT: When building with chunk installs enabled, don't generate the master manifest from each pak creation thread. Just do it once after all pak files have been created. Avoids intermittent crash with multiple threads trying to write the same json file.
Change 3928111 by Ben.Marsh
UBT: Add an option <bMasterProjectNameFromFolder> which allows setting the solution name based on the folder that it's in.
Change 3928926 by Ben.Marsh
BuildGraph: Add support for enumerating content copied by the <CsCompile> task. Also add support for invoking methods on string properties.
Change 3931041 by Graeme.Thornton
TBA: Add option to textasset commandlet to also include engine content in a resave
Change 3931043 by Graeme.Thornton
TBA: Redirect some more FArchive members in FArchiveProxy
Change 3931913 by Ben.Marsh
UGS: Do not create a modal dialog if a scheduled sync is unable to run because the editor is open, and do not run the editor after a scheduled sync.
#jira UE-47368
Change 3932419 by Ben.Marsh
UGS: Allow selecting which projects to sync on schedule. Any projects not already opened at the time the schedule is triggered will be opened first.
#jira UE-33541
Change 3932483 by Ben.Marsh
PR #3949: UnrealGameSync: Add environment path field to custom BuildStep (Contributed by frankie-dipietro-epic)
Change 3932624 by Ben.Marsh
UGS: Add an error dialog when trying to clean the workspace before closing the editor.
#jira UE-42308
Change 3932679 by Ben.Marsh
UGS: Add the date/time to the end of the sync log.
#jira UE-33540
Change 3932705 by Ben.Marsh
UGS: Prompt to close the editor before allowing the user to enter a changelist to sync to, when syncing to a specific changelist.
#jira UE-53182
Change 3933318 by Ben.Marsh
UGS: Detect more programs running before allowing a sync to start, show a dialog listing them, and add an option to ignore if necessary.
#jira UE-33535, UE-53914
Change 3933840 by Graeme.Thornton
TBA: When loading assets, only use structured archive adapters for exports when loading text files.
Change 3936040 by Ben.Marsh
UGS: Rewrite application lifecycle to fix issues with scheduled syncs on background windows not activating, and window jumping to the front after auto-update.
Now uses a custom application context to allow creating separate 'main' windows (first the "opening projects" form, then the regular form), and does not require any forms to be shown in order to be updating in the background.
#jira UE-52870
Change 3940230 by Robert.Manuszewski
Fixes for FilenameToLongPackageName crashes when runnign commandlets
Change 3940240 by Graeme.Thornton
Automated cycling of encryption and signing keys
Change 3940243 by Graeme.Thornton
UAT: CryptoKeys automation script
Change 3940321 by Ben.Marsh
UGS: Add a "Bisect" mode for regressing bugs between a certain range of changes. To use, select a range of changes by holding down the shift key or individual changes by holidng the control key, then right click and select "Bisect these changes". Individual changes in the list can be marked as "Bisect: Pass" or "Bisect: Fail" from the context menu, and syncing will find the next change in the center of the range.
Change 3940538 by Ben.Marsh
UBT: Always determine whether a project is a foreign project or not from the valid .uprojectdirs entries, rather than relying on the user passing -game on the command line.
Change 3941285 by Gil.Gribb
UE4 - Removed PRAGMA_DISABLE_OPTIMIZATION from PlatformFileCommon.h. It was an oversight.
#jira none
Change 3942404 by Graeme.Thornton
Pak Signing:
- Unify naming of pak precacher and signedarchivereader signature check functions to make it easier to search for them in crash reporter
- Format the signedarchivereader output to match the pak precacher
- When signedarchivereader detects a signature check, do the same master signature hash check that the pak precacher does to confirm that the .sig file contents haven't been corrupted since load.
- Add PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL guarded exit to signedarchivereader signature failure
- Optimization for pakprecacher signature checks. Instead of locking the cached files mutex for every decoded signature, take a local copy in blocks of 16. Only re-lock if we need more. Grab the initial batch when setting up. In most cases, reduces the number of locks to 1 per signature check call.
Change 3942825 by Ben.Marsh
UAT: Allow passing -Project<N>=Foo.uproject arguments to the MegaXGE commandlet (eg. -Target1="ShooterGame Win64 Development" -Project1="D:\ShooterGame\ShooterGame.uproject") so it can be used from an installed engine build.
Change 3942839 by Ben.Marsh
UBT: Explicitly query the number of logical processors in the system, to fix Environment.ProcessorCount just returning the number available to the .NET framework. For machines with > 64 cores, processors in a different processor group will not be included in this number.
Change 3943153 by Ben.Marsh
Use the correct logical processor count in ParallelExecutor.
Change 3943210 by Ben.Marsh
UGS: Add an option to the editor arguments window that allows prompting before launching the editor.
Change 3943329 by Ben.Marsh
UGS: Tweak appearance of bisect mode; now shows slightly transparent version of pass/fail icons, and includes remaining CL range in status panel.
Change 3944294 by Ben.Marsh
UGS: Prompt for confirmation before removing any files from the workspace.
Change 3945283 by Ben.Marsh
UGS: Add support for project-specific connection settings, and detection of Perforce login tickets expiring.
Change 3945325 by Ben.Marsh
PR #4558: Changed incorrect obsolete message for ReceiptPropertyList in Modules.cs (Contributed by ryanjon2040)
Change 3947359 by Graeme.Thornton
TBA: Fixes to loading code to allow bulk data to get a pointer from its loader archive to an archive that it can load from at a later date. For binary archives, this is just a pointer back to the same archive, but for text assets it is a pointer to a "child reader" which maintains its own structured archive that is scoped to the current location in the file.
Change 3947360 by Graeme.Thornton
TBA: Added RoundTrip mode to text asset commandlet. Performs determinism tests in project assets to see whether they save deterministically to binary and text files, and also when they are ping-ponged between the two formats.
Change 3949431 by Graeme.Thornton
TBA: Refactored string escaping code in json output formatter FString serializer into a common function which is now used by FName and UObject path serialization too. Fixes some odd cases where an FName contained quotation marks
Change 3950843 by Ben.Marsh
UBT: Add a better error if an XML config file is corrupt.
Change 3952504 by Steve.Robb
GitHub #4545 : UE-55924: CaseSensitive token recognition
#jira UE-55961
#jira UE-55924
Change 3952707 by Graeme.Thornton
Make RandInit(...) log message verbose
Change 3954694 by Ben.Marsh
BuildGraph: Add support for user-defined macros, which can contain a list of buildgraph commands and be expanded within a node. Example script in Engine/Build/Graph/Examples/Macros.xml.
To define a Macro, use the syntax:
<Macro Name="MyTestMacro" Arguments="PrintFirstMessage;PrintSecondMessage" OptionalArguments="PrintThirdMessage">
<Log Message="First message" If="$(PrintFirstMessage)"/>
<Log Message="Second message" If="$(PrintSecondMessage)"/>
<Log Message="Third message" If="'$(PrintThirdMessage)' == 'true'"/>
</Macro>
To expand a macro, use the syntax:
<Expand Name="MyTestMacro" PrintFirstMessage="true" PrintSecondMessage="true"/>
An error will be thrown if any required arguments are missing. Optional arguments default to empty if not specified.
Tasks within a macro are validated by the schema at the point of definition using the same rules as apply to a <Node> element, but properties are not evaluated until the macro is expanded. This allows macros to get and set properties in scope at the point that it is expanded. Local properties that are introduced within a macro do not otherwise leak to the scope that they are expanded.
Change 3954695 by Ben.Marsh
PR #4582: Fixed incorrect condition in StagedFileSystemReference.cs (Contributed by moadib)
#jira UE-56283
Change 3954961 by Ben.Marsh
UBT: Fix issues caused by toolchain assuming that the editor target will be the name of the project with an "Editor" suffix. This is not necessarily the case; the launcher will allow you to instantiate a project with any name, and it will not rename the target files.
#jira UE-56040
Change 3955785 by Steve.Robb
GitHub #4546 : Don't discard errors from zlib inflate
#jira UE-55969
Change 3955940 by Steve.Robb
Redundant and confusing macro check removed.
Change 3956809 by Ben.Marsh
Guard against project paths passed on the command line to UBT being treated as project names. Previous code used to just take the first, which would mask this problem.
Change 3959590 by Steve.Robb
Useless IsIntrinsic constant and COMPILED_IN_INTRINSIC macro removed.
Change 3959864 by Robert.Manuszewski
Increasing the size of permanent object pool to fix warnings in cooked ShooterGame
#jira UE-56001
Change 3960956 by Steve.Robb
New ToCStr function which generically gets a TCHAR* from a 'string-like' argument.
Change 3963628 by Ben.Marsh
UBT: Fix intellisense issues caused by _API macros being defined as DLLIMPORT (imported symbols cause an error if they are defined). Generate intellisense macros with the -Monolithic argument to work around it.
Change 3964349 by Ben.Marsh
Move support for reading .modules files into FModuleManager, and always use it in modular builds. Pathway which discovers modules by filename only is no longer supported for simplicity, and due to platform-specific version checks being unreliable on any platforms other than Windows.
Change 3964821 by Ben.Marsh
Use a custom tool for deleting directories on Windows, to handle paths longer than MAX_PATH correctly.
Change 3965269 by Ben.Marsh
Add more [RequiresUniqueBuildEnvironment] attributes to target settings that modify the global environment.
Change 3966554 by James.Hopkin
#core Removed redundant cast
Change 3966558 by James.Hopkin
#core Removed redundant casts and changed some MakeShareables to MakeShared
#robomerge #fortnite
Change 3966754 by Ben.Marsh
Always use the compiled-in app name when looking for a module manifest. Fixes issues with XGEControlWorker.exe being a renamed copy of ShaderCompileWorker.exe.
Change 3967397 by Ben.Marsh
Fix "copy local" files not being included in build products enumerated from C# projects. Remove files with "Embed Interop Types" from the output list.
Change 3967664 by Ben.Marsh
Update UGS solution to use Visual Studio 2017.
Change 3967838 by Ben.Marsh
Couple of fixes to conform scripts.
Change 3968767 by Ben.Marsh
Compile the name of the module manifest into the executable via a define explicitly set by UBT, rather than guessing at runtime.
Change 3968771 by Ben.Marsh
Fix compiled-in engine path being subject to macro expansion.
#jira UE-56504
Change 3968886 by Robert.Manuszewski
Merging 3914301:
Remove any references we had added to the GGCObjectReferencer during Init
Change 3968978 by Steve.Robb
FString->FName fixes for module names in HotReload.
Change 3969019 by Steve.Robb
Minor refactor of property skipping logic in SerializeTaggedProperties().
Change 3969041 by Steve.Robb
Simplification of Build.version filename construction.
Change 3969049 by Steve.Robb
Always do rolling names when recompiling in editor, because an unloaded module may still actually by loaded-but-abandoned by the executable.
This also removes HotReload's dependence on FModuleManager::GetCleanModuleFilename().
#jira UE-52405
Change 3969120 by Ben.Marsh
Enable errors for using undefined identifiers in conditional expressions by default.
Change 3969161 by Ben.Marsh
Remove log line that should only be included in the log.
Change 3969216 by Steve.Robb
Dump a list of module names - rather than DLL filenames - when the editor detects modules which need recompiling.
This removes the only remaining use of FModuleManager::GetCleanModuleFilename(), which is also now removed.
#jira UE-52405
Change 3969346 by Steve.Robb
Missed some bad FScript(Map/Set)Helper usage from CL# 3698969.
Change 3969598 by Ben.Marsh
Fix warning from VS2017.
Change 3971101 by Graeme.Thornton
TBA: Added RoundTrip mode to TextAsset commandlet which does a sequence of saves and checks for determinism. It will do 3 binary saves, 3 text saves, then 3 alternate binary->text saves.
Change 3971407 by Ben.Marsh
UBT: Fix exception when enumerating toolchains if the directory does not exist yet.
Change 3971523 by Graeme.Thornton
Make compressed block offsets in a pak file store offsets relative to the file header, rather than absolute. Reduces the amount of entropy when data changes in the pak file, making it play nicely with patching
Change 3971613 by Ben.Marsh
Fix Lightmass non-unity compile errors.
Change 3971649 by Ben.Marsh
Disable optimization around FTickerObjectBase constructor on Win32 due to ICE.
Change 3971829 by Ben.Marsh
Fix deprecated header warning from PVS Studio.
Change 3972503 by Ben.Marsh
Changes to build failure notifications:
* Only people that submitted between builds with different error messages will be included on emails by default.
* Email subject line will be different for each failing build step, but will include the CL of the first failing step. This will result in one thread for each build failure (a success email is sent with the same subject line).
* Anyone that starts a build will be included on all failure emails.
Change 3972732 by Ben.Marsh
Changes to ensure notification messages are stable.
Change 3972810 by Ben.Marsh
Write debug information about the digest computed for a change, to assist with debugging it if it's not stable.
Change 3973331 by Ben.Marsh
Fix missing dependency on linker response file. Prevents target being relinked when build environment changes.
Change 3973343 by Ben.Marsh
PR #4612: Adding support for PVS-Studio settings file to PVS-Studio Unreal Build Tool toolchain. (Contributed by PaulEremeeff)
Change 3973820 by Ben.Marsh
Fix incorrect error message when unable to find Visual C++ install directory.
Change 3974295 by Robert.Manuszewski
Made sure that lazy object pointers are only fixed up for PIE in actual PIE worlds.
Change 3975336 by Robert.Manuszewski
CIS fix after the last merge from main
Change 3976999 by Ben.Marsh
Move the Windows stack size settings onto the WindowsTargetRules object, and add the [RequiresUniqueBuildEnvironment] attribute to ensure it's not overwritten incorrectly.
This should cause CIS to better errors for compiling Odin editor.
Change 3977934 by Ben.Marsh
UBT: Allow setting additional compiler/linker arguments through properties on the TargetRules object.
Change 3977953 by Ben.Marsh
UBT: Enumerate all Visual Studio 2017 install locations using the Visual Studio Setup interop SDK. Multiple simultaneous Visual Studio installations are now supported, and using registry keys to determine installation directories has been deprecated. Allows choosing toolchains from preview versions as well as full versions.
Change 3978544 by Ben.Marsh
UBT: Include verbose timing information from compiler frontend if using VS2017 15.7 preview 2 or later.
Change 3978780 by Ben.Marsh
Add Visual C++ 2017 redist files to AppLocalDependencies, and update the prereq installer to include 2017 support DLLs.
Change 3979313 by Ben.Marsh
UBT: Add the EngineDirectory property to ModuleRules. Makes it easier to find paths to files under the engine folder.
Change 3980499 by Ben.Marsh
UBT: Automatically enable /DEBUG:FASTLINK if we're using the VS2017 15.7 toolchain or newer and not doing a formal build. This contains fixes for debugger OOM issues present in older versions.
Change 3980890 by Ben.Marsh
UBT: Update project file generator to support VS2017 solution options file; fixes C# projects being opened by default when generating new project files.
Change 3981495 by Ben.Marsh
Do not include embedded interop assemblies in the list of references required by a C# project; they are not required build products.
#jira UE-54343
Change 3982157 by Ben.Marsh
Only output a warning message if BuildConfiguration.xml schema validation fails; we may have settings that only apply to code in another branch.
Change 3982239 by Ben.Marsh
Update tooltip directing users to install Visual Studio 2017 instead of 2015.
Change 3983395 by Graeme.Thornton
Fix reference to BUILD_VERSION in BootstrapPackagedGame RC file
Change 3983523 by Graeme.Thornton
Backwards compatibility for pak files with compressed chunk offsets
Change 3983769 by Ben.Marsh
UAT: Allow using PDBCOPY.EXE installed as part of the Windows 10 SDK to strip symbols, and add a better message if it can't be found.
Change 3984529 by Ben.Marsh
BuildGraph: When run with the -Preprocess=... argument, no steps will be executed.
Change 3984557 by Ben.Marsh
BuildGraph: Return the updated patterns from FilePattern.CreateMapping(), so we can print accurate messages when displaying the source and target directories for a copy or move task.
Change 3986520 by Ben.Marsh
Remove hacks to uniquify response file name on Android and Linux.
Change 3987166 by Steve.Robb
Allow overloading of functions which take TFunctions or TFunctionRefs with mutually exclusive signatures.
Change 3989061 by Graeme.Thornton
TBA: Text asset loading/saving work
- Start using FStructuredArchive flavours of UObject Serialize functions when loading and saving exports.
- Only use FStructuredArchive interface for text assets, and for classes that have the CLASS_MatchingSerializers which tells us that the class can serialize to both FStructuredArchives and FArchives.
- Add GetCacheableArchive to FArchive, which allows transient archives to return a pointer to another archive that will outlive it. Used by bulk data to get a pointer to an archive that can be held and used at a later time to lazy load things. For text assets where the bulk data might be held inside a base64 encoded FArchiveFromStructuredArchive block, we can't dynamically seek back to that location after the on-stack wrapper has been destroyed after the original serialize, so this will return null. For binary assets, we just return a pointer to the same binary archive which can be used freely.
Change 3989109 by Graeme.Thornton
TBA: TextAsset commandlet emits a warning when binary package determinism fails
Change 3990823 by Ben.Marsh
UGS: Allow project settings to specify a client path rather than a filesystem path. Not currently usable through UI.
Change 3990832 by Ben.Marsh
UGS: Make the schedule window resizable.
Change 3991569 by Steve.Robb
GitHub #4636 : Fixed typo in HeaderParser.cpp for "missed WithValidation keyword" error message
Change 3991970 by Steve.Robb
Fix for 4096 char limit on FParse::Value.
Change 3992222 by Steve.Robb
Advice added to the coding standard for using default member initializers.
Change 3993675 by Ben.Marsh
UGS: Add UI to allow creating new workspaces and selecting projects from existing workspaces that are not currently synced.
Change 3994199 by Ben.Marsh
UGS: Fix child processes being unable to spawn other child processes with the CREATE_BREAKAWAY_FROM_JOB flag, to add them to their own job objects.
In Windows 7 or earlier job objects cannot be nested, so child processes have to create separate job objects and spawn processes with CREATE_BREAKAWAY_FROM_JOB to be able to add them. This fails unless parent process' job object was created with JOB_OBJECT_LIMIT_BREAKAWAY_OK.
Discussed here: https://msdn.microsoft.com/en-us/library/windows/desktop/hh448388(v=vs.85).aspx
Change 3994243 by Ben.Marsh
UGS: Use the select stream dialog instead of displaying a drop list unless there's a stream filter specified. We have way too many streams for this to be useful in a menu unless it's filtered.
Change 3994260 by Ben.Marsh
UGS: Tweak the stream filter dialog to only use the previous selected node if the filter terms match. It may be a parent node of something that matches, even though it doesn't match itself.
Change 3994350 by Ben.Marsh
UGS: Automatically guess the correct root path for new workspaces based on the most common existing workspaces for the current user.
Change 3995159 by Ben.Marsh
UGS: Do not delete files which are outside the sync filter. People expect to be able to sync different projects within a stream without having to update sync filters.
Indend to re-introduce this functionality through the manual 'clean workspace' operation.
Change 3995169 by Ben.Marsh
UGS: Show options as dimmed in the open project dialog, if the radio button for those controls is not checked. Automatically set the radio button if the focus is given to one of those controls.
Change 3995228 by Ben.Marsh
UGS: Update recently opened projects list when editing project for an existing tab.
Change 3995312 by Ben.Marsh
UGS: Stop showing all dialogs in the taskbar.
Change 3995929 by Robert.Manuszewski
Completely rewritten FReferenceChainSearch class used by 'obj refs' command.
- 3+ times faster
- Uses the same code as GC to track all the references down
- Actually reports all reference chains properly
- Less code that is more readable than the previous version
Change 3995981 by Ben.Marsh
UGS: Clean workspace window will now force-sync files that have been deleted or which are writable.
Change 3996113 by Ben.Marsh
UGS: Fix crash upgrading config files from older versions.
Change 3997990 by Ben.Marsh
UGS: Prevent error when syncing an empty workspace.
Change 3998095 by Ben.Marsh
UGS: Change logic for dealing with job objects: rather than creating breakaway jobs (requires co-operation with spawning process), always try to use nested job objects (requires Windows 8.1+). If it fails, ignore the error if we're already part of a job.
Also forcibly terminate the process on dispose to handle cases where the job object wasn't created.
Change 3998264 by Ben.Marsh
UGS: Fix exception when switching projects in-place.
Change 3998643 by Ben.Marsh
Fix shared DDC not being used for installed engine builds.
#jira UE-57631
Change 4000266 by Ben.Marsh
UnrealPak: Add an option that allows rebuilding a set of PAK files with different settings. Usage is:
UnrealPak [PakFile] -Repack [-Output=FileOrDirectory] [Options]
The input pak file may be a single file or wildcard, and is overwritten unless the -Output parameter is specified.
Change 4000293 by Ben.Marsh
Add a compression flag that allows selecting compressor without using the default platform implementation.
Change 4000315 by Ben.Marsh
Add support for custom compressors implemented via modular features. Specify -compressor=<PathToDll> on the command line to UnrealPak to load a compressor from an external DLL.
Change 4000610 by Ben.Marsh
UnrealPak: Add a parameter for compression block size (-compressionblocksize=XXX). Accepts arguments with MB/KB suffixes, as well as byte counts.
Change 4000627 by Ben.Marsh
UBT: Include enabled plugin info in the UBT log.
Change 4000793 by Ben.Marsh
UBT: Remove some member variables from VCEnvironment that don't need to be stored.
Change 4000909 by Ben.Marsh
UBT: Add VS2017 installations to the list of paths checked for MSBuild installations.
Change 4001923 by Ben.Marsh
UBT: Allow any plugins which are enabled by default to be included in the enabled list, even if they don't have any modules for the current platform. This changes the build-time logic to match the runtime logic.
At some point in the future we may add a separate SupportedHostPlatforms list to each plugin to do this explicitly, rather than guessing via the per-module whitelist.
Change 4001927 by Ben.Marsh
Fixes for compiling against the Windows 10 SDK.
Change 4002439 by Robert.Manuszewski
Added TDefaultReferenceCollector and FSimpleReferenceProcessorBase to extract common code for clients of TFastReferenceCollector
Change 4003508 by Ben.Marsh
UGS: Fix new workspaces not having the correct owner and host set.
Change 4003622 by Ben.Marsh
UGS: Add support for "skipped" as a build result.
Change 4004049 by Robert.Manuszewski
Significantly improved performance of Reference Chain Search for objects that are nested deep in the object hierarchy
Change 4005077 by Ben.Marsh
UGS: Update version number.
Change 4005112 by Ben.Marsh
UBT: Reduce number of times a target has to be constructed while generating project files.
Change 4005513 by Ben.Marsh
UBT: Reduce number of checks for directories existing when adding include paths to a module. Accounted for 40% of runtime time when generating project files.
Change 4005516 by Ben.Marsh
UBT: Add warnings whenever a module adds an include path or library path that doesn't exist
Change 4006168 by Ben.Marsh
CIS fixes.
Change 4006236 by Ben.Marsh
UGS: Populate the workspace name/root directory text box with the cue banner when focus moves to the control.
Change 4006266 by Ben.Marsh
UGS: Swap around the new workspace/existing file boxes on the open project dialog.
Change 4006552 by Ben.Marsh
If staging fails because a restricted folder name is found, include a list of them in the error message.
Change 4007397 by Steve.Robb
Comments added to make it clear that GetAllocatedSize() only counts direct allocations made by the container.
Change 4007458 by Ben.Marsh
UBT: Change RPC utility to abort early, rather than continue to try to build even though SSH init failed.
Change 4009343 by Ben.Marsh
UGS: Set the rmdir option on new workspaces by default.
Change 4009501 by Ben.Marsh
UBT: Add Windows include paths to the compiler command line, rather than setting through environment variables. This ensures that incremental builds work correctly when SDK versions change.
Change 4009509 by Ben.Marsh
UBT: Check in a non-versioned directory under the Windows 10 SDK for the resource compiler.
Change 4010543 by Ben.Marsh
Remove the "Device" and "Simulator" platform groups, because they're unused and overly generic for folder names. Also remove source code for the HTML5 simulator (which is no longer supported).
Change 4010553 by Ben.Marsh
UAT: Include platform groups in restricted folder names when staging.
Change 4012030 by Ben.Marsh
UGS: Increase the size of the main window, and set the current stream as the default when creating a new workspace.
Change 4012204 by Chad.Garyet
- Cleanup to get the POSTs returning 400s the same way the GETs would (now no longer returns the exception text)
- Create directory for sqlite db if it doesn't exist
#jira none
Change 4014209 by Brandon.Schaefer
New changes in breakpad dump_syms to allow for producing a symbol file for elf files on windows
#review-3998840 @Arciel.Rekman, @Ben.Marsh, @Josh.Engebreston, @Anthony.Bills
Change 4015606 by Brandon.Schaefer
Missed a code project that needed updating for new Breakpad changes for Mac
Change 4017795 by Robert.Manuszewski
GC assumption verification should now be 3-4x faster.
- Refactored Disregard For GC to use TFastReferenceCollector
- Move both Disregard For GC and Cluster verification code to separate source files
Change 4020381 by Ben.Marsh
Add link to the new official doc page for UnrealGameSync.
Change 4020665 by Ben.Marsh
UBT: Prevent plugins being precompiled if they don't support the current target platform.
Change 4021829 by Ben.Marsh
Update message about downloading a new version of Visual Studio.
Change 4022063 by Ben.Marsh
UBT: Suppress toolchain output when generating project files.
Change 4023248 by Ben.Marsh
Install an unhandled exception filter to ensure we get crash reports from threads that are not spawned by the engine. At the moment, we only receive crashes that are routed through ReportCrash() via our structured exception handlers in WinMain() and FRunnableThreadWin::Run().
(Also fix an exception within the exception handler, if GError has not been created yet)
Change 4025759 by Ben.Marsh
Fix universal CRT include paths not being added to compile environment for VS2015.
Change 4026002 by Ben.Marsh
UBT: Check the old registry locations for the Windows SDK installation directory.
Change 4026068 by Ben.Marsh
UBT: Use the correct compiler version in the error message for not having the UCRT.
Change 4026181 by Ben.Marsh
Fix DebugGame editor configurations not enumerating modules correctly.
#jira UE-58153
Change 4026285 by Ben.Marsh
UBT: Add additional logging for enumerating Windows SDKs.
Change 4026708 by Ben.Marsh
UBT: Keep a separate list of installed Universal CRT versions to the list of Windows 10 SDK versions. It's possible to install C++ support without the Windows 10 SDK, which still includes UCRT files in Windows 10 SDK folders.
Change 4029404 by Ben.Marsh
Remove incorrect include paths to fix CIS warnings.
Change 4031517 by Steve.Robb
Fix for UHT errors not being clickable in the Message Log.
#jira UE-58173
Change 4031544 by Ben.Marsh
Fix errors building asset catalog for IOS due to modifying shared build environment.
#jira UE-58240
Change 4032227 by Ben.Marsh
BuildGraph: Print out a warning message when trying to submit without the -Submit argument in BuildGraph.
Change 4032262 by Ben.Marsh
BuildGraph: Remove the need to copy files to the staging directory in BuildEditorAndTools.xml.
Change 4032288 by Ben.Marsh
Remove UFE from the BuildEditorAndTools script.
Change 3833533 by Ben.Marsh
Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules.
Change 3838569 by Steve.Robb
Algo moved up a folder.
Change 3848581 by Robert.Manuszewski
Changing the UObjectArray to not be allocated up front but in 64K-FUObjectItem chunks. This is to fix strange OOM reports on editor startup where it's trying to allocate space for 1M+ FUObjectItems.
#jira UE-49446
Change 3864743 by Steve.Robb
Fix for buffer overrun when copying a context string.
Fix for being unable to link to MallocLeakDetection.
Fix to prefix for FMallocLeakDetection::ContextString.
New MALLOCLEAK_SCOPED_CONTEXT macro to push/pop a context string.
Overload for const TCHAR* added to FMallocLeakDetection::PushContext to save on redundant memory allocations.
#jira UE-54612
Change 3865020 by Graeme.Thornton
TBA: Changed FIELD_NAME macro to FIELD_NAME_TEXT so that FIELD_NAME can be used for non-literal name definitions
Change 3869550 by Josh.Engebretson
New SymGen and SymUpload tasks (ShooterGame usage example)
Example C# symbolicator (using saved crash and data router formats)
Updates for stack walking and crash runtime xml on Windows/Mac
Change 3905453 by Steve.Robb
USE_TUPLE_AUTO_RETURN_TYPES moved to PLATFORM_COMPILER_HAS_DECLTYPE_AUTO.
Change 3910012 by Ben.Marsh
UGS: Show an error window and allow setting default P4 server settings if syncing UGS fails.
Change 3920044 by Graeme.Thornton
TBA: Text asset loading
* Added a structured archive layer to FLinkerLoad
* Wrapped export loading in a ArchiveUObjectFromStructuredArchive
* Updated TextAssetCommandlet to have a "loadtext" mode which will try to load every text asset in the project content
* Changed text asset extensions to .utextasset and .utextmap. Couldn't go with the favourite .uasset.json because our various path functions (FPaths::GetCleanFilename etc.) will only strip one layer of extension, so leave a bogus filename.
* Relaxed a few checks in structured archive where it was checking for field reentrance, which isn't a problem for loading.
* Changed FArchiveFromStructuredArchive to not load all referenced objects at construction time. This introduced some changes to load order which don't work in the engine. Object names are resolved at the point that a reference to them is serialized from the main data block, same as with legacy archives.
Change 3921587 by Steve.Robb
Static asserts inside ensureMsgf() macros to prevent them being passed invalid arguments or non-literal formatting strings.
Fixes for various misuses.
#jira UE-55681
Change 3942873 by Ben.Marsh
UBT: Allow link time code generation on any configurations where bAllowLTCG is set to true. Microsoft platforms were previously only allowing this option in shipping; the target can decide when to enable it or not.
Change 3944629 by Graeme.Thornton
Merging back a couple of fixes from Fortnite
- Extra parenthesis around some calculations in the pakprecacher
- Changed FChunkCacheWorker::DoSignatureCheck() back to ::CheckSignature()
- Added documentation for build script crypto options
Change 3945381 by Ben.Marsh
Disable warning C4770 on Windows (partially validated enum 'xxx' used as index), which occurs when enabling LTCG. Can't find a reference online for this warning, but I suspect it's due to LTCG allowing the compiler to trace code paths where we don't validate that an enum is a known value.
Change 3968969 by Steve.Robb
Fixes to incorrect uses of FScriptMapHelper and FScriptSetHelper, which weren't accounting for gaps in the sparse array.
Change 3969417 by Ben.Marsh
Make Visual Studio 2017 the default compiler for UE4 projects, and add support using Visual C++ toolchains from an AutoSDKs.
Also add support for selecting a specific toolchain version to use through the WindowsPlatform.CompilerVersion property, which can be configured via a Target.cs files or BuildConfiguration.xml (eg. <WindowsPlatform><CompilerVersion>14.13.26128</CompilerVersion></WindowsPlatform). As well as allowing a specific version number, you can always use the latest toolchain by setting it to "Latest".
Change 3972443 by Ben.Marsh
Change build scripts to allow running any steps on non-compile workspaces. Setup Dev-Core to just use a non-compile Win64 workspace for everything.
Change 3977198 by Ben.Marsh
Remove INI file override for editor stack size on Windows. This is rarely valid since editor targets share build products with other games by deafult. Fix to add linker response file as prerequisite exposed targets overriding this as a bug.
Change 3979632 by Ben.Marsh
Consolidate codepaths for embedding versioning information in the engine. Engine/Build/Build.version is now the authoritative place to read version information; Engine/Source/Runtime/Launch/Resources/Version.h no longer includes macros for the current branch and changelist.
* Settings from Build.version are compiled into the (tiny) BuildSettings module via macros set in BuildSettings.build.cs, which is used to initialize version information inside the engine at runtime.
* The IsPromotedBuild value is now set to zero by default (but set to 1 by the UpdateLocalVersion UAT command).
* The -Licensee argument to the UpdateLocalVersion UAT command, and the IsLicenseeVersion setting for UnrealGameSync, is determined automatically by looking for the Engine/Build/NotForLicensees/EpicInternal.txt file. This path is not visible to licensees.
Change 3981738 by Ben.Marsh
Move utility classes for filtering files and matching wildcards into DotNETUtilities.
Change 3983888 by Steve.Robb
Warning C4868 disabled, about evaluation order of braced initializer lists.
https://udn.unrealengine.com/questions/426081/help-with-error-c4868-braced-initializers.html
Change 3984019 by Steve.Robb
FString::Printf formatting argument checking added.
Vararg support for FText::Format.
All remaining usage fixed.
Change 3985502 by Steve.Robb
Change to TFunction debugger visualization to allow right-clicking on the [Lambda] and selecting 'Go To Source Code'.
Change 3985999 by Graeme.Thornton
TBA: Serialize function generation for FArchive and FStructuredArchive overloads on a UObject, using UHT.
- Adds a restriction that UObject::Serialize() functions MUST be declared outside of any conditional compilation directives, except for WITH_EDITORONLY_DATA
Change 3986461 by Ben.Marsh
Fixup lots of platforms not adding response files as a prerequisite.
This can cause incremental builds to fail if input files/compile arguments change, because the action graph does not know that the response file being updated invalidates the build artifacts.
Change 3990081 by Ben.Marsh
Remove custom output formatters for errors and warnings. These are not well supported by different executors, and cause fences between actions with the same formatter with external executors like XGE.
Clang supports -fdiagnostics-format=msvc for all platforms, which should do a better job than our crude attempts at regexing errors (causing botched output in some cases).
Change 3996714 by Chad.Garyet
UGSRestAPI, conversion of UGS to use it.
#jira none
Change 4008287 by Ben.Marsh
UBT: Change the engine to use the Windows 10 SDK by default.
Also add support for switching between specific Windows SDK versions. The WindowsPlatform.WindowsSdkVersion property in the target rules can be used to select a desired version, which can also be configured by the <WindowsPlatform><WindowsSdkVersion>Foo</WindowsSdkVersion></WindowsPlatform> parameter in the BuildConfiguration.xml file.
The version of Windows to target (ie. the WINVER macro) can be modified by setting WindowsPlatform.TargetWindowsVersion. The default is 0x0601 (Windows 7).
Change 4008516 by Chad.Garyet
- Adding support for both SQLite and MsSql
- API now reads from only MsSql, but writes to both
- Added support for POST to CIS for badges
- PostBadgeStatus now writes out via API Url rather than a direct connection to the DB
#jira none
Change 4010296 by Chad.Garyet
Moving SQLite db initilization into Application_Start. An exception thrown creating or seeding the db will unload the entire AppDomain and all pages will return a 404.
#jira none
Change 4024045 by Ben.Marsh
Set the list of supported target platforms for OnlineSubsystemGameCircle.
#jira UE-57887
Change 4031014 by Ben.Marsh
UAT: Add a WhitelistDirectories list in DefaultEngine.ini, which allows specifying folders that can be staged despite having restricted folder names.
[CL 4034515 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3801826 by Max.Chen
PR #4304: Level Sequence crash fix - Guarded against dereferencing null componen. (Contributed by DSDambuster)
Change 3801828 by Max.Chen
PR #4302: Movie Scene Visibility Template unitialised variable, causing random . (Contributed by DSDambuster)
Change 3801837 by Max.Chen
Sequencer: Delay spawning/construction for convert to possessable. This fixes a bug where property values would be lost when
converting back and forth from possessable to spawnable.
#jira UE-52400
Change 3801841 by Max.Chen
Sequencer: Make spacer nodes not selectable.
PR #4194: Improvements to Sequencer (Contributed by projectgheist)
#jira UE-53117
#jira UE-52139
Change 3804183 by Max.Preussner
MediaAssets: Added missing lock in media sound component
Change 3805414 by Max.Preussner
MediaAssets: Setting valid GUID when initializing media texture resource
Change 3819578 by Max.Chen
PR #4370: When enabling the "MovieCapture", do not turn off the Stereo-3D display. (Contributed by yehaike)
#jira UE-53647
Change 3823414 by Max.Chen
Curve Editor: Lock down the first and last keys in the redundant keys removal range so that they're unaffected.
#jira UE-53591
Change 3826406 by Max.Chen
Sequencer: Move OnStartedPlaying() to within first update in UpdateTimeCursorPosition(). This fixes an issue where setting the
hud/player visibility was getting stomped on later.
#jira UE-52772
Change 3827044 by Max.Preussner
MediaAssets: Added sprite visualization to media sound component
#jira UE-53594
Change 3827988 by Max.Preussner
MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together
#jira UE-53532
Change 3828506 by Max.Preussner
MediaPlayerEditor: Added attenuation visualizer for media sound components
#jira UE-53594
Change 3832590 by andrew.porter
EngineTest: Added a keep state check in Property Animation sequencer test
Change 3833053 by andrew.porter
EngineTest: Adding Hierarchical Bias test
Change 3835683 by andrew.porter
EngineTest: Adding UMG Animation screenshot test
Change 3836076 by Max.Chen
Sequencer: Fix audio volume and pitch multiplier deprecation.
Change 3836230 by andrew.porter
EngineTest: Adding Sequence Bone Position automation test
Change 3836347 by Max.Chen
Sequencer: Fixes to shot name parsing.
When a shot doesn't contain a shot number, assume, [ShotName]_[TakeNumber].
When duplicating a shot, put the new shot in the same path of the original shot, so that the take numbers will increment
properly.
#jira UE-51868
Change 3836552 by Max.Chen
Sequencer: Sub section now has a takes menu
Change 3838094 by Max.Chen
UMG: Fix template finish not getting called on stop. This fixes a bug where sections aren't restored when finished.
#jira UE-52285
Change 3838708 by Max.Chen
Sequencer: Add notification when the blend type is changed.
#jira UE-54046
Change 3840295 by Max.Chen
Sequencer: Fix copy/paste crash for lights
#jira UE-54084
Change 3840957 by Mike.Zyracki
Added Show Only Keyable and Show Only Animated to the filter list in the property editor.
Added IsPropertyAnimated to IDetailKeyframe Interface which already had support for showing properties which are keyable (which
is used for the key icon next to the properties.). Could have created another interface but then would have had to mimic the sequencer
binding, releasing also, so this seemed best way.
One issue still left is that custom built detail items currently don't store associated properties(usually) and so certain
properties, in particulalry transforms, won't show up as keyable or animated. Note this also shows up with the keyable icon not showing
up next to transform tracks, and other filters like Show Only Modified not working with transforms/customs. Not sure best way to tackle
this.
#jira UESEQ-328
Change 3841756 by Max.Chen
Sequencer: Fix unbound possessable components when pasting spawnables.
#jira UE-54104
Change 3843950 by andrew.porter
EngineTest: Renaming LevelStreaming tests/content to LevelVisibility
Change 3844082 by Mike.Zyracki
Missing file for animated filter in property editor.
When finding if a track is animated we need to find it but we can't easily induce the MovieTrack class for any particular
property. So we don't set a class for it and just search by it's ID and name.
#jira UESEQ-328
Change 3846902 by Max.Preussner
ImgMedia: Fixed image media player never finished initialization if loading failed
#jira UE-54247
Change 3849820 by Mike.Zyracki
Reassigning deleted widgets didn't work since the menu extender mechanism needs a valid UObject in order to perform an operation
on it. So to fix we replaced GetObjectBindingContextMenuExtender in WidgetBlueprint with new delegate mechanism
(OnBuildCustomContextMenuForGuid) that supports FGuid in addition to UObjects which is needed to handle re-binding deleted widgets. Note
that the default sequencer hacks this for replacing deleted actors in SequencerObjectBindingNode to check to see if a LevelSequence is
active. We could move to this mechanism there also.
#jira UE-53163
Change 3852211 by Max.Chen
UMG: Indicate name of the property that is not bound.
#jira UE-54350
Change 3854120 by Max.Chen
Sequencer: Fix sibling folders being allowed to have the same folder name.
#jira UE-54363
Change 3854627 by Max.Chen
Sequencer: Step to next/previous key should work for all tracks if there aren't any selected.
#jira UESEQ-391
Change 3855825 by andrew.porter
EngineTest: Adding animation blending automation test
Change 3855950 by andrew.porter
EngineTest: Adding correct expected valuues to animation blending test
Change 3856237 by Matt.Hoffman
UESEQ-336 - Sequencer Track Reordering
Adds the ability to re-order Master Tracks, Folders and Object Bindings within sequencer hierarchies (including UMG). Adds the
ability to do a one-off sorting of the content under the old sorting behavior if the user wants to reset their layout to how it was
under legacy behavior.
Modifies SequencerTrackNodes, SequencerFolderNodes and SequencerObjectBindingNodes to handle CanDrop/OnDrop for above, below and
ontop of.
Fixes a Slate Issue that forcibly expanded a TreeviewRow if an item handled OnDrop. Slate will now only forcibly expand the row
if the item says the drop happened ontop of the item, and not above or below it like it previously did.
Change 3856503 by andrew.porter
EngineTest: Adding automation test for using animation blueprint with blend multi node in sequencer
Change 3857875 by Max.Chen
Sequencer: Assign the sequence id after the template is compiled.
#jira UE-54462
Change 3858344 by Max.Chen
Sequencer: Prevent Goto and Transform boxes from overlapping by allowing them to be visible at the same time in an autosized
horizontal box. Also, added close button to the goto box.
PR #4425: Prevent Goto and Transform boxes from overlapping in Sequencer ... (Contributed by projectgheist)
#jira UE-54210
Change 3860566 by andrew.porter
MediaFrameworkTest: Set the option to index 0 for the audio and video track list by default
Change 3860654 by andrew.porter
EngineTest: Enabling Camera Cut + FOV test
Change 3860981 by andrew.porter
EngineTest: Updating skeletal mesh tests with a delay after set playback position
Change 3861256 by Max.Chen
Sequencer: Add all bindings if none selected.
#jira-54440
Change 3862154 by Andrew.Rodham
Added TimeManagement module
Change 3862424 by andrew.porter
EngineTest: Turned on the test Bone Positions with Blend Multi Node
Change 3862573 by andrew.porter
EngineTest: Adding test to compare bone positions in a sequence that is blending an animation that is using an AnimBP
Change 3865117 by Max.Chen
Sequencer: Stop auto scroll on mouse release of movement.
#jira UE-31212
Change 3865303 by Max.Chen
Sequencer: Add drag and drop transactions
#jira UE-54662
Change 3865304 by Max.Chen
Sequencer: Fix crash when an actor factory is not found.
Change 3865361 by Max.Chen
Sequencer: Don't change the camera/shot lock button when popping out of a sequence.
#jira UE-54665
Change 3865412 by Max.Chen
Sequencer: Determine whether a transform track is for a camera by using the spawned object or template
#jira UE-54666
Change 3865685 by Max.Chen
Sequencer: Clear autoscrub offset when stopping autoscroll
#jira UE-31212
Change 3865886 by Max.Chen
Sequence Recorder: Log an error if the number of frames changes while recording. This can happen if the skeleton changes while
recording.
#jira UE-48715
Change 3866925 by Andrew.Porter
MediaFrameworkTest: Changing the current PNG test video image sequence to 1024 x 576
Change 3867705 by andrew.porter
QAGame: Adding Audio Sort Sequence to dev folder
Change 3867890 by andrew.porter
QAGame: Adding a sequence for testing a sorting crash to my dev folder
Change 3872628 by Max.Chen
Movie Scene Capture: Split delay before warmup into split delay before shot warmup so that there's separate controls for when
the movie scene capture warmups up vs. shot boundaries.
Change 3873131 by Matt.Hoffman
UE-54732 - Crash reordering a folder with a track.
This was caused by folders being the only type of track to check if someone was putting a parent track into a child track.
Object Binding tracks and Tracks now check as well so that you can't use the above/below drop targets to add parents as children.
This also fixed a typo in the localization keys.
#jira UE-54732
Change 3873301 by Mike.Zyracki
Added ability to support continous euler angle changes when changing rotations, in particularly with the rotation gizmo's. To do
this we effectively added a form an of 'euler filter'(https://en.wikipedia.org/wiki/Euler_filter) to find the closest euler angle to the
current euler angle.
Three functions were added to FRotator to make this possible, one to get the euler angle that's has the same rotation as it, one
to get the difference between two euler angles via Manhattan distance and a third using the previous two to choose a Rotator value
that's closest to it. We then use these functions before calling UComponent::SetRelativeRotation to make sure we use the correct Euler
after the Quat conversion. We also no longer limit(bound) the euler angles to -180,180, which is obviously necessary to avoid flips.
I also changed how we caluclate yaw and roll when pitch is -90 or 90 to make it the standard approach of zeroing out roll and
just setting yaw. Main reasons are the previous implementation had precision issues so things like 180, 90, -180 would show up due to
numbers being nearly zero but negative,(this would break any smooth interpolations), and this facilitates having a 'gimbal' rotation
mode (like Maya, Blender etc..) if we ever want that also. If needed we could keep the previous implementation but would need to add
some FMath::IsNearlyZero checks, with less performance.
Note we only do this special filtering when applying delta's to actors or components in the editors, which then call
UComponent::SetRelativeRotationExact, which is a new function to foces the RelativeRotation to be equal to the new rotation. This allows
us to store un-nomalized Rotators at the cost that the RotationCache may be broken. We didn't change any of the other UComponent
functions that set rotations (via Quats or Transforms) so they will still be bounded and unwound.
In SetInternalWorldLocationAndRotation we only set the rotation if the rotation has changed, which fixes the rotation getting
changed and re-normalized if just translate happens.
In TransformTrackEditor, we correclty use the bUndwing flag and in MovieScene3DTransformSection there was an un-needed winding
check there, it will be unwound earlier if needed, which happens if Sequence Recording is happening. Max we should talk about what to do
about this .
Note the euler angle drag via the widget is still bound to 0-360. I think we should just unbound that now since the rotations
value are now unbound.
This review now includes fixes suggested by Zak.
#jira UE-UE-22228
Change 3873483 by Matt.Hoffman
Sequencer Tracks can now be inserted above the spacer at the bottom of the tree.
#jira UE-54706
Change 3873899 by Max.Chen
Sequencer: Add section selection throbbing
Change 3873908 by Max.Chen
Movie Scene Capture: Added logging per frame
Change 3873924 by Matt.Hoffman
Adds the ability to store Sequence Recorder setups into profiles that stay with the map and can be re-loaded later. Profiles
store the Actor Recordings so the settings for each actor should carry with them.
#jira UESEQ-339
Change 3874726 by Matt.Hoffman
Disable drag-and-drop targets on spacers that come between rows in Sequencer. This prevents extra drag/drop targets showing up
between each row.
#jira UE-54706
Change 3874862 by Matt.Hoffman
Audio Track no longer gets reordered when adding sub-audio tracks, as sub-tracks are no longer counted towards the sorting order
index when normalizing indexes.
#jira UE-54727
Change 3875905 by Matt.Hoffman
Disable Fade Track UI if a fade track already exists in the sequence.
#jira UESEQ-393
Change 3876163 by Max.Chen
Sequencer: Swap the camera object to the camera component's owner if it's not the same.
#jira UE-54874
Change 3876971 by Andrew.Porter
EngineTest: Moved Media Player Seek test to new folder. Also enabled the test with new ground truth image.
Change 3877040 by Max.Chen
Cine Camera: Split camera properties to two groups, "Camera Options" and "Camera Settings". The cine camera now hides properties
in the "Camera Settings" group so that properties like bConstrainAspectRatio (in the "Camera Options" group) can be visible.
#jira UE-54192
Change 3877763 by Max.Chen
Curve Editor: Fix curve changed on end drag so that only curves that had keys/tangents that were changed receive notification,
otherwise all loaded curves were getting notified that they were changed.
#jira UE-54951
Change 3878234 by Matt.Hoffman
Disable "Drop Below" targets for Sequencer Tree nodes to prevent a confusing UX issue where dropping underneath a Object Binding
Node puts it after the object binding node but the UI looks like it's inserting it inside the Object Binding node.
#jira UE-54743
Change 3879359 by Mike.Zyracki
If a track is inactive we dim it a bit which seems to be the UE4 way to show inactive or disabled state. We changed the active
logic so that all subtracks need to be inactive for the track to also be inactive(instead of all active for active). This conforms to
how the active state actually works, e.g if you have two sections and only one is active the track is still active above it.
#jira UESEQ-388
Change 3879462 by Max.Chen
Sequencer: Allow dragging onto a particular row which would move out any overlapping sections to make space for the newly
created section. Newly created sections are now selected and throbbed to draw attention to themselves.
#jira UE-54664
Change 3879464 by Max.Chen
Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation
- The issue was that track segments that had been combined with adjacent segments (due to them being identical) would
potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field.
- The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed
that a supplied range could not entirely contain any other range in the field.
- The solution is to supply the insertion time along with the range to know exactly where the data should live in the field,
and crop the range to the maximum allowable space between adjacent ranges.
#jira UE-54922
Change 3879590 by Matt.Hoffman
Items that are now added to the Sequencer via the "+Track" menu will be selected after being added.
Items can now be added inside of folders instead of just to the root level.
#jira UE-27397
Change 3879612 by Mike.Zyracki
Display Nodes with no children are always active.
#jira UESEQ-388
Change 3879730 by Matt.Hoffman
Sequence Recorder's actor recording groups now remove items from the group when removed via the UI.
#jira UESEQ-339
Change 3880256 by Mike.Zyracki
Fix issue with inactive display with folders and other track nodes.
#jira UESEQ-388
Change 3883491 by Max.Chen
Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes.
Copy from Release-4.19
#jira UE-51323
Change 3883603 by Max.Chen
Movie Scene Capture: Add option toggle disable screen percentage. By default this is on (no change in current behavior).
#jira UE-51898
Change 3885074 by Max.Preussner
MediaCompositing: Resetting media texture & freeing resource on section end; removed dead code
Change 3887220 by Max.Preussner
MediaCompositing: Defaulted media section duration to 1 sec (since we do not know the actual duration in most cases)
Change 3887478 by Matt.Hoffman
Sequences now show [Inactive] in their title bars when they're disabled. This helps communicate why a sequence isn't being
evaluated.
#jira UE-51469
Change 3888985 by Max.Chen
Movie Scene Capture: Clamp HDR Compression Quality between 0 and 1.
#jira UE-55136
Change 3893519 by Max.Chen
Sequence Recorder: Clarified tooltip for bRecordNearbySpawnedActors - spawned actors will still be recorded if they match the
ActorFilter.
#jira UE-55238
Change 3893546 by Max.Chen
Sequence Recorder: If a selected actor already has a recording, add a blank recording.
#jira UE-55239
Change 3894044 by Max.Preussner
MediaCompositing: Added support for seeking into a media section
Change 3894310 by andrew.porter
MediaFrameworkTest: Adding Img media sources for 1080 and 2160 ravent test content
Change 3894426 by Max.Preussner
MediaAssets: Letting media textures with AutoClear retain their clear color when player is reset
Change 3895717 by Max.Chen
Sequencer: Null checks to prevent crash when saving the default state of a spawnable
#jira UE-55304
Change 3897388 by Max.Chen
Sequencer: Don't update current time to be within the view range when stepping into a sequence.
#jira UE-55322
Change 3897452 by Max.Chen
Audio: Fix crash when trying to record audio without any active capture devices. Log warning if the number of input channels is
not 1 or 2.
#jira UE-55223
Change 3897619 by Max.Preussner
MediaCompositing: Removed commented out code
Change 3898072 by Max.Chen
Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated.
#jira UE-55328
Change 3898272 by Max.Preussner
MediaPlayerEditor: Made slate brush constants static
Change 3898704 by Max.Chen
Sequencer: Skip if the binding id's sequence can't be found.
#jira UE-55337
Change 3899855 by Max.Preussner
MediaCompositingEditor: Added cache state visualization to media track
Change 3900300 by Max.Preussner
MediaCompositingEditor: Added loop indicators to media sections
Change 3900694 by Max.Preussner
ImfMedia: Looping cache only when player is looping
Change 3900892 by Max.Preussner
Stats: Added stats category for media framework
Change 3900954 by Max.Preussner
MediaCompositing: Don't evaluate at the end of media section
Change 3901348 by Max.Preussner
Core: Replaced TLruCache autos for better readability
Change 3901655 by Max.Preussner
ImgMedia: Added more perf stats to EXR reader
Change 3901972 by Max.Preussner
MediaAssets: Added getter for media player in media sound components
Change 3902233 by Max.Preussner
MediaAssets: Enabling media textures to receive samples right after player is assigned
Change 3902238 by Max.Preussner
MediaCompositing: Working around init/shutdown idiosyncracies in sequencer
Change 3904045 by Max.Chen
Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene
spawn register.
#jira UE-55314
Change 3905605 by Max.Chen
Sequencer: Restrict spawnables from being created if they have a ClassWithin that UMovieScene is not a child of.
#jira UE-55429
Change 3906550 by Max.Chen
Sequencer: Add media track icon
#jira UE-55480
Change 3907101 by Max.Chen
Sequence Recorder: Fix bugs related to not recording a level sequence. There were certain assumptions that creating a level
sequence meant that sequence recording was in progress. This is not always the case - the recorders can record animation assets and not
create a level sequence.
Changed the notion of IsRecording() to having at least one actor recording that is recording. Countdown timer, recording
displays, etc should function if IsRecording() and not based on whether a level sequence is created.
#jira UE-55485
Change 3907247 by Max.Chen
Sequence Recorder: Fix crash not removing PrepareToCleanseEditorObject delegate. Repros when opening sequence recorder, closing
it, and then opening or creating a level.
Change 3910343 by Max.Preussner
Core: Added async helper for executing functions on a given thread pool
Change 3910346 by Max.Preussner
ImgMedia: Added separate thread pools for loading/decoding and deleting image frames
Change 3910829 by Max.Preussner
Profiler: Increased visible range of profiler graph
Change 3910841 by Max.Preussner
MediaCompositing: Displaying asset name instead of full media source path in media section
Change 3910870 by Max.Preussner
ImgMedia: Using deallocation thread pool only in debug builds
Change 3919642 by Max.Chen
Sequence Recorder: Clarify active tooltip
#jira UE-55661
Change 3919660 by Max.Chen
Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved
but not modified
- The following sequence of events exposes this issue:
- Create a master sequence with a single shot that spawns a cube
- Add this sequence to a level and set it to auto-play
- Save everything and restart
- Resave just the inner shot asset without opening it
- PIE
- The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the
master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template.
#jira UE-55626
#jira UE-55490
Change 3921825 by Max.Chen
Sequencer: "Run Construction Script in Sequencer" is off by default for blueprints but on for Sequencer. This allows the content
author to switch it on for specific blueprints and sequencer will be default, run those with construction scripts enabled.
Change 3922232 by Max.Chen
Sequence Recorder: Reset countdelay on stop.
#jira UE-55755
Change 3922306 by Max.Chen
Sequence Recorder: Don't automatically mark transforms to be recorded by sequence recorder. Instead, log a warning if the user
toggled it off to warn that the resulting animation might not match gameplay.
#jira UE-55758
Change 3922912 by Max.Chen
Sequence Recorder: Fix refresh next sequence name
#jira UE-55757
Change 3927654 by Max.Chen
Movie Scene Capture: Added format mapping for the name of the current camera
#jira UE-55769
PR #4537
Change 3927658 by Max.Chen
Sequencer: Added fbx property mapping for "FocusDistance" to "FocusSettings.ManualFocusDistance"
#jira UE-55782
Change 3932022 by Max.Chen
Sequencer: Add import animation track section to next available row index.
#jira UE-55892
Change 3933919 by Max.Chen
Sequencer: Jump to playback start frame and not 0 to start playback for recording.
#jira UE-55933
Change 3934307 by Andrew.Rodham
Sequencer: Add template signature that is re-generated every time the base template is regenerated, which invalidates evaluation
fields
This fixes an issue where the same sequence is instantiated multiple times in a sequence.
If the source sequence was saved, its template would be wiped, which would invalidate the template ID
When an instance tries to evaluate the master template, it would only invalidate a range in the evaluation field that was the
hull of any invalid sub sequences overlapping the current time, potentially leaving invalid data in the evaluation field at positions
later (or earlier) on in the sequence
When the sub template was re-generated, it receives the same SequenceSignature as it had before (because the sequence hasn't
actually changed), which causes the stale evaluation field data to fail the IsDirty check (because the sequence is the same as it
thought, but the *template* has changed)
This has been addressed be adding a signature to templates themselves, and checking both the template signature and sequence
signature as a part of the IsDirty check. This ensures that we regenerate if either the template, or the sequence have changed.
#jira UE-55934
Change 3936327 by Andrew.Rodham
Sequencer: Removed increment when trimming right
UMovieSceneSection::TrimSection already explicity assigns an exclusive bound to the time passed in. The new behavior means we
can trim a section to the right, and insert another section without changing the time to create adjacent sections.
#jira UE-42652
Change 3936328 by Andrew.Rodham
Fixed KeyFrameManipulator assignment operators and copy/move constructors
- These types are potentially self-referential so cannot use default constructors/assignment
Change 3936330 by Andrew.Rodham
Converted UMGSequencePlayer to use frames internally
#jira UE-54878
Change 3936726 by Max.Chen
Sequencer: Set track node as the parent of the key area node. The key area switcher needs the object binding id from the parent
object binding node. Without this, the binding to the external value fails.
#jira UE-55931
Change 3936775 by Max.Chen
Sequencer: Should stop or loop should compare DurationFrames with Current Time from StartTime.
The bug is that if you set 30 warmup frames in movie rendering for a range of 0-100, the FrameRange will be starting at -30 and
have a duration of 130. Without this fix, the playback will continue until frame 130, rather than 100.
#jira UE-55933
Change 3936935 by Matt.Hoffman
Easing Curves are now represented in Play Rate resolution instead of internal resolution.
#jira UE-55937
Change 3937069 by Matt.Hoffman
Users can toggle if the is infinite on each side, limited by which tracks support infinite ranges.
#jira UE-55891
Change 3937516 by Max.Preussner
ImgMedia: Added support for single-threaded platforms
#jira UE-55986
Change 3937826 by Max.Preussner
MediaAssets: Disabling media sound components on HTML5 if AudioMixer is not enabled
Change 3937997 by Max.Chen
Curve Editor: Add Zoom to Fit Curves so that selected curves from Sequencer can be focused on. Tested that undo doesn't re-zoom.
#jira UE-55935
Change 3938000 by Max.Chen
Sequencer: Stop all sounds before generating audio waveforms.
#jira UE-55951
Change 3938376 by Max.Preussner
XGEController: Disabled XGE Controller in single-threaded apps to prevent crash
Change 3938444 by Max.Preussner
Core: Added async support for single-threaded applications
Change 3938445 by Max.Preussner
Networking: Added support for single-threaded applications in UDP socket sender/receiver
Change 3938447 by Max.Preussner
Messaging: Added support for single-threaded applications
Change 3939432 by Max.Chen
Sequence Recorder: Append command list to global level editor actions so that shortcuts are accessible in level editor.
#jira UE-55798
Change 3940229 by Andrew.Rodham
Added prospective display rate upgrade to UMovieScene::PostLoad
- There was previously some very odd behaviour that would assign the fixed frame interval only when a sub sequence was focused
in SSequencer. This meant that many sequences could have a frame interval of 0 set in the data.
- Under the old method of snap interval display this would have fallen back to getting the display interval from the sequencer
settings, but we no longer look at these.
- The USequencerSettings properties have been removed and in their place, a prospective data upgrade for sequences that have a
fixed frame interval old 0fps that sets the play rate to the previous defaults based off the old USequencerSettings defaults.
- This could end up 'changing' the display rate for sequences where the user has changed the snap interval in the settings for
a particular sequence editor, but there's not much we can do about that given we don't have access to the USequencerSettings classes in
UMovieScene
#jira UE-55919
Change 3940277 by Andrew.Rodham
Sequencer: Added ability to default frame resolutions and play rates for newly created actor sequences
Change 3940378 by Andrew.Rodham
Sequencer: Post move import dialog now defaults to the playback framerate of the sequence, and floors to frame numbers
Change 3940559 by Andrew.Rodham
Reinstated primed or recording sequence color
Change 3940642 by Max.Preussner
ImagePlate: Removed image plate media playback functionality
Change 3940843 by Max.Preussner
Core: Made TCircularQueue actually thread-safe; improved code comments
Change 3940860 by Max.Chen
Sequencer: Changed StructNameToKey to StructPathToKey
Previously, keying a PropertyPath of [RenderTransform][Shear][X] would get trimmed to X, which doesn't map to a channel name as
considered by Sequencer2dTransformTrackEditor. Instead, trim the resulting property path to [Shear][X] so that track editors can
determine the desired struct path and channels to key.
#jira UE-52966
Change 3941292 by Mike.Zyracki
Fix for trajectories out of range not showing up.
1) If we had no key data we would pop the time, so wouldn't get the section ranges.
2) Calculating of upper bound was wrong, checking against -1 and not key == num of keys when doing algo::lower_bound.
3) No need to do the Bck-- for the bakward iterators since we fixed#2. We start now from the upper bound correctly.
4) If we had no keys (at section start,end) we would incorrectly say we were any key type, so since we draw constant keys as
dashed we would do so incorrectly around section end points.
#jira UE-55929
Change 3941424 by Max.Chen
Curve Editor: Change Zoom to Fit to use TArrayView
Change 3941498 by Max.Preussner
Core: Added FMath::DivideAndRoundNearest function
Change 3942097 by Matt.Hoffman
Drop Frame Timecode Support for NTSC rates.
Change 3942104 by Matt.Hoffman
Sequence Recorder Group is no longer visible inside the World Outliner after using one.
#jira 55266
Change 3942107 by Max.Chen
Sequencer: Resurrect logic to find or extend an existing section when adding keys.
Change 3942330 by Max.Chen
Sequence Recorder: Better tooltip for default animation settings.
#jira UE-55636
Change 3942339 by Max.Chen
Sequence Recorder: Better tooltip for default animation settings.
#jira UE-55636
Change 3942507 by Andrew.Rodham
Sequencer: We no longer pad the time overlap threshold with a small number that is not scaled by the current zoom level
- The presence of this pad was causing keys that were far apart to be grouped when zoomed in a long way
Change 3942509 by Andrew.Rodham
Sequencer: Only pad total view range, rather than section range as well when retrieving keys to render
- This stops us from rendering keys that are within the view range, but outside the section range
Change 3942512 by Andrew.Rodham
Added transactions to some sequencer details customizations
Change 3942513 by Andrew.Rodham
Sequencer: Reinstated validation checks to UMovieSceneSection::SetStartFrame and SetEndFrame, changed erroneous uses to use
SetRange
Change 3942560 by Andrew.Rodham
Pass by rvalue reference to appease error C2719 on Win32
('InChannels': formal parameter with requested alignment of 8 won't be aligned)
Change 3942697 by Andrew.Rodham
Newly Created Level Sequences and Actor Sequences now default to 24000 fps frame resolution (+/- ~24hrs range, supporting all
integer rates + 23.976)
Change 3942700 by Andrew.Rodham
Sequencer: Added legacy out-of-bounds errors for times that are not supported by the current legacy upgrade frame resolution
Change 3942989 by Max.Preussner
Core: Fixed circular queue count calculation
Change 3943538 by Max.Preussner
MediaAssets: Reverted workaround for procedural audio log spam in HTML5
(Actor component initialization cannot be skipped if the component is used in a level)
Change 3944071 by Max.Preussner
QAGame: Fixed Media Texture keeps last frame of Media when PIE ends
#jira UE-53360
Change 3944292 by Max.Chen
Sequencer: Added extra flags to ensure that asset initialization does not occur on template actor sequences
#jira UE-56113
Change 3944364 by Max.Chen
Sequencer: Prevent circular shot/master tracks.
Tested adding master -> child -> master as drag and drop cinematic shot tracks and sub tracks as well as through the + button.
#jira UE-56091
Change 3944422 by Max.Chen
Sequence Recorder: Disable transform recording if off.
#jira UE-56061
Change 3944745 by Andrew.Rodham
Sequencer: Key rendering fixes
- Fixed assert that occured when keys happened to reside on some times due to KeyTime + TimeOverlapThreshold - KeyTime being
slightly larger TimeOverlapThreshold
- Fixed keys sometimes being clipped when zoomed right in due to lack of half-frame offset
- Added missing documentation to MovieSceneTimeHelpers.h
#jira UE-56107
Change 3945231 by Andrew.Rodham
Sequencer: Reconstruct channel proxy on Serialize to catch all cases of undo/redo, PostLoad and duplication
#jira UE-56089
Change 3945301 by Andrew.Rodham
Sequencer: Added safety checks during initial sequence recording to guard against applying negative or 0-sized sequence ranges
#jira UE-56125
Change 3946627 by Max.Preussner
Fortnite: Fixed game crashes closing editor while in PIE - Pure virtual function being called
#jira UE-56144
[CL 3946896 by Max Chen in Main branch]
============================
MAJOR FEATURES & CHANGES
============================
Change 3873906 by Dan.Oconnor
Revised fix for preventing delegate functions from appearing in context menu when using the compilation manager - needed to run after CallDelegateHandler changed statement type
#jira UE-51726
Change 3873614 by Dan.Oconnor
Prevent delegate functions from appearing in context menu when using the compilation manager and prevent crash if such a function is somehow compiled
#jira UE-51726
Change 3873428 by Ben.Zeigler
#jira UE-54753 Fix class pin on SpawnActorFromClass to correctly support browse. It was inherting from the wrong pin widget
Copy of 3873408
Change 3873083 by Ethan.Geller
[4.19]#jira UE-54865 fix seconds -> milliseconds conversion issue. #rb aaron.mcleran #lockdown cristina.riveron
Change 3872714 by Dan.Oconnor
Further revise fix for UE-53840, mistakenly reverted to old behavior when compiling synchronously
#jira UE-53840
Change 3872648 by Ben.Zeigler
#jira UE-54845 Fix crash in NextDebugTarget when there are no valid debug targets
Copy of CL #3872636
Change 3872500 by Arne.Schober
Back out changelist 3870283
#jira UE-54838
Change 3872412 by Mark.Satterthwaite
Remove now unnecessary r.Metal.ManualVertexFetch from the device profiles.
#jira UE-54853
Change 3872313 by Martin.Wilson
Add UI to Live Link Client to warn live link users about background performance throttling
#jira none
Change 3872272 by Martin.Wilson
Fix crash when clearing a skeletal mesh on a skeletal mesh component with an active Post Process Anim Instance
#jira none
Change 3872238 by Mark.Satterthwaite
Duplicate CL #3871025
Make Manual Vertex Fetch a property of the shader platform for Metal - only the desktop platforms (METAL SM5/SM5_NoTess/MRT) will use manual vertex fetch. The mobile platforms use vertex descriptors. Prevents problems with cooked versions of games not working properly on Metal due to a mismatch between the runtime's Manual-Vertex-Fetch state versus the state used by the cooker when compiling shaders.
#jira UE-54843
Change 3872087 by Yasiman.Ahsani
Adding Python, libdisasm, musl, and LSS licenses.
#JIRA n/a - adding licenses for new TPS
Change 3872037 by Ben.Marsh
BuildGraph: Add a task for compiling MSBuild projects.
#jira
Change 3871934 by Lina.Halper
#jira: UE-54703
Change 3871595 by Michael.Trepka
Fixed a problem with Mac editor not exiting with error code returned from GuardedMain function
#jira UE-54830
Change 3870829 by Joe.Barnes
Fix unintentional change to PhysX libs used in Debug builds.
#jira ue-54817
Change 3870820 by Nick.Atamas
Copying //Tasks/UE4/Dev-VR-4.19a@3870772 to Release-4.19 (//UE4/Release-4.19)
#jira UE-54816
Change 3870755 by Chance.Ivey
Min Android version set - should fix camera permissions issue found in #JIRA UE-54024 #rb none #fyi nick.atamas
Change 3870547 by Krzysztof.Narkowicz
Fixed FreezeRendering on non editor builds: ComputeAndMarkRelevanceForViewParallel was calling FrozenMatricesGuard on multiple threads, reading and writing view matrices state in parallel.
#jira UE-53640
Change 3870546 by Krzysztof.Narkowicz
Fixed tesselation shader tex/uniform initialization in OpenGL3/4 path
#jira UE-54471
Change 3870284 by Ben.Zeigler
#jira UE-54583 Fix issue where loading multiple already loaded assets via Async Load Asset node could return the wrong asset on the loaded pin. The assign variable node was happening at a slightly wrong time
Copy of CL #3870279
Change 3870283 by Arne.Schober
SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources)
Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary
#jira none
Change 3870098 by Ben.Marsh
Fix OptimizeCode = CodeOptimization.Always causing compile errors in Linux debug builds. bUseInlining was not set correctly on the global compile environment used to build shared PCHs. Also fixed other settings not being propogated down from the target correctly.
#jira UE-53855
Change 3870013 by Ben.Marsh
UBT: Add an error if a user attempts to clean a target through hot-reload, rather than just failing to delete DLLs because they are locked.
#jira UE-54179
Change 3870010 by Ben.Marsh
UBT: Add an option to format output messages in a form that can be parsed by MSBuild. Prevents errors showing as "EXEC: Error:", and displays them correctly in the error list window.
#jira
Change 3869814 by Ben.Marsh
UBT: Unify command line arguments to use -Name=Value syntax. -Module <Name>, -ModuleWithSuffix <Name> <Suffix>, -Plugin <Path> and -Receipt <Path> are no longer supported.
Also remove the RemoteRoot option, which was not used anywhere.
#jira
Change 3869786 by Martin.Wilson
Fix Live Link Remove Source button not working
#Jira UE-54652
Change 3869660 by Martin.Wilson
Fix missing message bus sources in the live link client (not repolling for new sources)
#Jira UE-54712
Change 3869659 by Guillaume.Abadie
Fixes SimpleComposure's BP_AdvancedCompositing keep allocating memory every frame.
Credits for fixing the issue to Ron Radeztsk.
#jira UE-54780
Change 3869401 by Lauren.Ridge
Adding to the conditional in FindAllAncestorNamedSlotHostWidgetsForContent
#jira UE-51470
Change 3869384 by Brandon.Schaefer
Open the project in the explorer when NullSourceCodeAccess is done creating the project
#jira UE-54630
Change 3869308 by Ben.Marsh
PR #4452: Fixed FindFilesRecursively in IPlatformFilePak (Contributed by user37337)
#jira UE-54568
Change 3869265 by Martin.Wilson
Fix crash and subsequently found issues with unloading/reloading Maya Live Link plugin
-Crash on reload due to core code getting reinitialize, made this a one time only thing (as Maya never gets rid of the module from memory)
-Added manual ticking of FTicker, allows message bus objects to be cleaned up properly (cannot do this as part of normal flow as it is in engine code which we dont have)
-rebuild binaries for Engine/Extras
#Jira UE-54643
Change 3869206 by Benn.Gallagher
Fixed crash updating clothing paint mode after tab spawners have been destroyed by the hosting application.
#jira UE-54116
Change 3869064 by Benn.Gallagher
Resolved skeletal mesh data changes and clothing section disable changes after collision. Re-added ability to disable sections at the mesh level and removed the ability to strip editor sections as these are required for a number of other features to correctly function.
#jira UE-52557
Change 3869062 by Guillaume.Abadie
Fixes "dynamic resolution is not supported on this platform" warning message being always visible.
#jira UE-54655
Change 3868202 by Lauren.Ridge
Fix for assert on expanding vector param in layered material
#jira UE-54737
Change 3868161 by zak.parrish
Replacing FaceARDebugUI with a blank UI until a new one can be created, due to a crash bug. #rb none #JIRA UE-54639
Change 3867750 by Ethan.Geller
[4.19] #jira UE-54725 Fix for Envelope attack and release values not being properly set on Synth Components #rb aaron.mcleran #lockdown cristina.riveron
Change 3867657 by Lauren.Ridge
Adding if with editor wrapper to new function
#jira cis fix
Change 3867646 by Aaron.McLeran
#jira UE-53867 Access violation on Switch when playing sound with specified time out of range
Change 3867340 by Lauren.Ridge
Fixes to Material Layers from 4.19 preview feedback
-Need to pass through base attributes better/have better default nodes in layer (optional Example Layers and Blends checkbox now enables this in Experimental Settings)
-Parent in function should be editable
-Enforce only two layers in a blend
-Mat layer should warn if it has incorrect output in the layer itself
-Enforce not being able to delete outputs
-Warn about creating a MAL node inside a function
#jira UETOOL-1312
Change 3867317 by Aaron.McLeran
#jira UE-53867 Access violation on Switch when playing sound with specified time out of range
Change 3867000 by Lauren.Ridge
Fix for folder favorites possibly becoming very large
#jira UE-54704
Change 3866892 by Martin.Wilson
Fix crash if clicking ok on message bus add source without having a source selected
#jira UE-54572
Change 3866391 by Matt.Kuhlenschmidt
Fix static analysis
#jira UE-53379
Change 3866241 by Ryan.Vance
#jira UE-54681
Fixed missing Vulkan texture GetNativeResource implementation that was lost in a bad merge.
Change 3866071 by Nick.Shin
UDN 412414
update HTMl5 readme file
#jira none
Change 3866005 by Max.Preussner
Messaging: Preventing dangling references when removing message subscribers
#jira UE-54680
Change 3865988 by Simon.Tourangeau
Fix static analysis warnings
#jira none
Change 3865895 by zachary.wilson
Renaming QA-PhysicalLightUnits to TM-PhysicalLightUnits in QAGame.
#JIRA UE-29618
Change 3865469 by Simon.Tourangeau
Support for DX11 quad buffer stereo rendering
#jira UEENT-704
Change 3865461 by Chris.Babcock
Add a wait for audio thread to pause audio on going to background
#jira UE-54301
#ue4
#android
Change 3865350 by Matt.Kuhlenschmidt
Fix issue where cascade emitter UI would disapper
#jira UE-53379
Change 3865336 by Arne.Schober
REL - Fix UE-52356 Bone Weight
#jira UE-52356
Change 3865257 by Ben.Marsh
Fix editor failing to load content-only projects when compiled in DebugGame.
#jira UE-54661
Change 3865238 by Simon.Tovey
Pulling Olaf's fix from 3832595 over to release
#tests EngineTests boots in vulkan
#JIRA UE-54394
Change 3865191 by Sorin.Gradinaru
UE-54317 DXT apps fail on first launch when 'For Distribution' enabled, Unsupported Texture Format
#jira UE-54317
#Android
#4.19
From //Dev-Mobile/3863322
Change 3865190 by Sorin.Gradinaru
UE-54175 Selecting For Distribution no longer sets configuration to Shipping
#UE4
#4.19
#jira UE-54175
From //Dev-Mobile/3863371
"For Distribution" enable-> reset "Build COnfiguration" to Shipping and force serialization to DefaultGame.ini (see UE-52845)
Change 3865056 by Jamie.Dale
Fixed culture being incorrect when added via the Localization Dashboard
#jira none
Change 3864826 by Max.Preussner
WmfMedia: Added missing scope lock
#jira UE-54365
Change 3864055 by Aaron.McLeran
#jira UE-54213
Crash fix for GC'd plugin settings objects. Adding to AddReferencedObjects.
Change 3863775 by Andrew.Porter
MediaFrameworkTest: Removing Platform Media Source TVOS test content
#jira UE-29618
Change 3863714 by Dan.Oconnor
Make array, set, and map nodes no longer switch object type when a pin is disconnected. Also, you can no longer attach unrelated map types to the MakeMap node if only the value pin has been inferred
#jira UE-54634
Change 3863696 by Max.Chen
Sequencer: Fix crash open a new sequence while another is still active.
#jira UE-54620
#jira UE-54624
Change 3863638 by Dan.Oconnor
Make sure all blueprints that are skeleton compiled get a BroadcastChanged notification, also run BroadcastChanged after reinstancing, matching pre compilation manager behavior
#jira UE-54193
Change 3863494 by Jamie.Dale
Ensure Py_SetPythonHome is set correctly before the embedded Python interpreter is initialized
#jira UE-54345
Change 3863433 by Max.Preussner
MediaPlayerEditor: Removed tvOS from list of available platforms in Platform Media Source assets
tvOS currently reports itself as iOS, so it cannot have its own setting.
#jira UE-54559
Change 3863406 by Lauren.Ridge
Fix for a crash when filtering a dropdown with no set value
#jira UE-54631
Change 3863238 by Michael.Kirzinger
#jira UE-52730: Fix mac voip crash
Change 3862586 by Marc.Audy
Clean up rendering thread heartbeat checks that got mangled in various integrations
#jira
Change 3862247 by Guillaume.Abadie
Fixes editor lines that were using a simple element blending mode that was generating an incorrect alpha channel.
#jira UE-53830
Change 3862120 by Guillaume.Abadie
Fixes USceneCaptureComponent::HiddenActors always staying gray out in world editor.
#jira UE-51458
Change 3861363 by Jamie.Dale
Static analysis fixes
#jira none
Change 3861150 by Matt.Kuhlenschmidt
Fix static mesh editor displaying 0 for all stats on LODs > 0
#jira UE-53776
Change 3860990 by Dan.Oconnor
Clear subobjects not recreated on load, e.g. because we're running with -game and the subobject was created using CreateEditorOnlySubobject
#jira UE-54551
Change 3860972 by Nick.Shin
HTML5 - detect "SyntaxError: " and do a forced reload
- an actual syntax error would be caught during compile time
- this is usually error condition is usually seen when browser is running "old/partial" cached data and it's fairly safe to just reload the page
#jira UE-54017 QAGame fails to launch properly on HTML5 Firefox 64 bit
Change 3860951 by Arne.Schober
Fix not releaseing SRV on render thread for FPositionVertexBuffer, FStaticMeshVertexBuffer, FColorVertexBuffer, FStaticMeshInstanceBuffer.
#jira UE-54587
Change 3860950 by tim.gautier
QAGame: Updating ML_Stone to include Texture Coordinate and Panner functions
#jira UE-29618
Change 3860833 by Michael.Dupuis
#jira UE-54181: Repopulate the foliage list when existing simulate mode
Let the GC know that internal struct hold UObject ptr
Change 3860762 by Jamie.Dale
Ensure we invoke the correct version of Python from UBT
#jira UE-54345
Change 3860676 by Simon.Tourangeau
Remove DirectoryWatcher warning in output log
#jira UEENT-846
Change 3860598 by Lauren.Ridge
Fix for crash on opening new material instance
#jira UE-54589
Change 3860338 by Michael.Lentine
Integrate changes for fixing MorphTargets.
#jira 54398
Change 3860215 by Ben.Marsh
UAT: Fix exception consturcting target rules assembly inside UAT, now that there's an abstract TargetRules class.
#jira UE-54578
Change 3860186 by Matt.Kuhlenschmidt
Fix crash top 10 with the font editor shutting down and then a dpi event occuring
#jira UE-54543
Change 3859854 by Graeme.Thornton
PR #4124: VSCode: Changed VisualStudioCodeSourceCodeAccessor to work with non-default VSCode install paths on Linux (Contributed by christopherreed)
#jira UE-51289
Change 3859848 by Graeme.Thornton
Fix crypto.cs reading the wrong ini setting names for uasset encryption settings
#jira UE-54566
Change 3859684 by Ben.Marsh
PR #4436: Fix compile error when building BlankProgram because incorrect directory path (Contributed by windkey)
#jira UE-54392
Change 3859657 by Ben.Marsh
Fix FTransform being passed by value, causing alignment error when compiling for Win32.
#jira
Change 3859312 by nick.bullard
Updating AEOverviewMan to remove reference to sub-level AEOverviewSWP which was deleted in 3859278
Still need to update menu to remove selection
#jira UE-50784
Change 3859278 by Nick.Bullard
Deleteing AEOverviewSWP.umap per request of Developer. Also updated TM-AnimPhys which refereneced this map as well.
"This test map is a custom C++ implementation of a "procedural sound wave". This code is super janky and not worth fixing up. I'm sure there's a legit thread safety problem in there but the code is in QAGame only.
We've since implemented "synth components" which do what this test does in a much safer/better way and maintaining/testing this old thing is *not* worth the time."
#jira UE-50784
Change 3859124 by Dan.Oconnor
Fix long standing crash when duplicating a blueprint that is missing its parent class. Entries in CrashReport go back to 4.16
#jira UE-54468
Change 3859086 by Ryan.Vance
#jira UE-54470
We need to set the viewport in both cases.
Change 3859006 by Dan.Oconnor
Revise fix for archetype lookup when reinstancing. During compilation we do not want to force use of the up to date class
#jira UE-54541
Change 3858990 by mason.seay
Cleaned up blueprints to remove compile errors
#jira UE-29618
Change 3858945 by Aaron.McLeran
#jira UE-54265
PR #4428: Fixing Envelope Bug in AudioMixer (Contributed by Chrispykins)
Change 3858719 by Aaron.McLeran
#jira UE-54552 Fix for sample buffer reader
Change 3858647 by Ethan.Geller
PR #4439: Removes ambiX -> FuMa conversion (Contributed by mgorzel)
#jira UE-54407
Change 3858364 by Michael.Dupuis
#jira UE-52049: There was a case where adding and removing multiple time would lead to reordering the instances and this would cause the regeneration of the random stream for all the reorded instances.
Change 3858268 by Dan.Oconnor
Prevent postload logic running on REINST and SKEL classes
#jira UE-54531
Change 3858205 by Mitchell.Wilson
Removed particle looping from some emitters to resolve anim notify warnings.
#jira UE-53823
Change 3858148 by Lauren.Ridge
Changes based on Material Layer Feedback from previews
- (Temporary) Disabled being able to create a layer or blend in the asset dropdown
- Sections of the stack that have been disabled now inactivate that part of the UI
- Create Function Instance now indicates if you are making a layer or a blend
- Parent dropdown has been removed from layers and blends. Where relevant, a filter button has been added instead.
#jira UETOOL-1328
Change 3857933 by Michael.Dupuis
#jira UE-45854: Properly unregister callback when replacing foliage type with another one
Change 3857898 by Michael.Dupuis
#jira UE-54396: Remove the Ensure as it could be possible that the Landscape Info is invalid during an undo operation
Change 3857878 by Max.Chen
Sequencer: Assign the sequence id after the template is compiled.
Copy from Dev-Sequencer
#jira UE-54462
Change 3857808 by Michael.Dupuis
#jira UE-54421: Prevent edition during Simulate when clicking on actor
Change 3857786 by Rolando.Caloca
UE4.19 - Fix recompute tangents and skin cache for OpenGL
#jira UE-42108
PR #3271
Change 3857549 by Lina.Halper
another jittering issue due to revision number change
clear the motion vector after compile
#jira: UE-53930
Change 3857439 by Lina.Halper
Clear motion vector when end of sequencer when in editor world
#jira:UE-54057
Change 3857384 by Graeme.Thornton
Restore fix for visual studio source code accessor not correctly determining that a content project has no solution and opening a fresh instance of visual studio
#jira UE-50020
Change 3856596 by Chris.Babcock
Fix ResonanceAudioApi Android library architecture filtering
#jira UE-54478
#ue4
#android
Change 3856449 by Michael.Dupuis
#jira UE-35097: Various cosmetic changes that were done in phase 2 that help improve clarity of the design.
Change 3856415 by Dan.Oconnor
Fix regression when loading instances that have had their class deleted. Issue detected by static analysis
#jira UE-54467
Change 3856332 by Ben.Marsh
Resaving TP_HandheldARBP assets to fix version again.
#jira
Change 3856319 by Ben.Marsh
Back out changelist 3855588
Causes build failure in UFE because it introduces a dependency on the Engine module. UFE compiles with WITH_ENGINE = 0.
#jira UE-54472
Change 3856292 by Ben.Marsh
Fix app-local dependencies not being included in binary builds, and only working for code projects in source builds.
#jira UE-54448
Change 3856190 by Martin.Wilson
Fix bone access mismatch between raw mesh bones and final bones (that include virtual bones too)
#jira UE-54266
Change 3856169 by Ben.Marsh
Tag XGEControlWorker.exe as a build product, so it's included in the binary distro.
#jira UE-54283
Change 3856123 by Chris.Babcock
Fix missing ARCore file
#jira UE-54453
#ue4
#android
Change 3856005 by Richard.Wallis
Clone of Dev-Rendering CL 3855993 - turn off FShaderCache.
#jira UE-52928
Change 3855961 by Jian.Ru
Copy 3855047 - fix DFAO Nan problem
#jira UE-54403
Change 3855811 by Martin.Wilson
Add build process for Maya Live Link plugin (standalone, manually triggered) + add built binaries to Engine/Extras (Maya 2016, Maya 2017, Maya 2018)
#jira none
Change 3855758 by Cosmin.Sulea
UE-53569 - tvOS does not package or launch-on
#jira UE-53569
Change 3855727 by Ben.Marsh
Resaving assets with a versioned build in the editor, to fix warnings building DDC.
#jira
Change 3855626 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-50979 (MP4 doesn't resume playback when iOS 11 device wakes from sleep)
#jira UE-50979
Change 3855588 by Graeme.Thornton
Fix visual studio solution path being incorrect for content projects
#jira UE-50020
Change 3855283 by Ben.Marsh
Fix race condition where stdout/stderr write handles could be inherited by multiple processes, resulting in them not being closed (and the process exit being detected) until all processes that inherited them had been closed. Improves performance of ParallelExecutor.
#jira
Change 3855009 by Chance.Ivey
Resaving with version number. #JIRA-54330 #rb none
Change 3854943 by Dan.Oconnor
Fix archetype lookup when searching hierarchy that has been partially reinstanced
#jira UE-53840
Change 3854882 by Ryan.Vance
#jira UE-54438
Removing vr related references to screen percentage.
Removing previously removed gvr screen percentage code that came back in an integration from google.
Change 3854806 by Mike.Beach
Mirroring part of CL 3802176 to fix a crash that can occur when users try to use the default 'DisplayModel' on MotionController components. Also provided users a better error message to explain why a model might not be showing up.
#jira UE-54214
Change 3854680 by Chance.Ivey
Saving assets with version number#JIRA UE-54330 #rb none
Change 3854652 by Uriel.Doyon
Added a tooltip to the EV100 slider in the exposure menu.
Using game settings now disables the slider.
#jira UE-53945
Change 3854605 by Dan.Oconnor
Make sure we don't create objects outered to a placeholder object, also make sure that archetypes that are reinstanced on load are relinked in to the linker table so that they are postload'd (and the old instance isn't)
#jira UE-53954
Change 3854274 by Brandon.Schaefer
Changes in CL 3842286 changed the function glslang::GlslangToSpv and requires a rebuild on Linux
#jira UE-54302
#codeview Arciel.Rekman
Change 3854255 by Phillip.Kavan
Fix a scoping issue for local instanced subobject references in nativized Blueprint C++ code. Also, don't emit redundant assignment statements for instanced subobject reference properties.
- Mirrored from //UE4/Dev-Framework (3853349).
#jira UE-53960
Change 3854177 by Ethan.Geller
#jira UE-54415 set EnabledByDefault to false for Resonance Audio
Change 3854123 by Ethan.Geller
#jira UE-54410 set AudioComponentID
Change 3853775 by Lauren.Ridge
Minor cleanup
#jira UE-54054
Change 3853772 by Lauren.Ridge
Don't create widgets when just testing if the selected widget is a replacement candidate
#jira UE-54054
Change 3853715 by Rolando.Caloca
UE4.19 - Fix for OpenGL overwriting texture units
#jira UE-54401
Change 3853655 by Ben.Marsh
Add a retry loop on creating the first directory before copying files. Attempt to work around problems copying to shared folders.
#jira
Change 3853535 by Ben.Marsh
Expose the engine compatible changelist to Perforce. If EnginePatchVersion > 0, this will be the changelist of the original .0 release.
#jira
Change 3852583 by Nick.Atamas
Resaved assets so they don't produce DDC warnings.
#jira none
Change 3852552 by Uriel.Doyon
Fixed Pre-Exposure shader compilation and Temporal AA issue.
#jira UE-54276
Change 3852354 by Nick.Atamas
Hopefully fixes the static analysis warning from jira issue.
#jira UE-54332
Change 3852281 by Nick.Atamas
Merging CL 3851690 from //Tasks/UE4/Dev-VR-4.19a/... to //UE4/Telease-4.19/...
#jira UE-54331
Change 3852274 by Simon.Tourangeau
Back out changelist 3851041 until Win7 issue is resolved.
#jira UE-54354
Change 3852208 by Jamie.Dale
Merging CL# 3821754 from //UE4/Dev-Enterprise
Class property conversion now goes through NativizeClass/PythonizeClass
This allows it to coerce from Python wrapped object types
#jira none
Change 3852202 by Jamie.Dale
More explicit handling of EngineDir for Python SDK
#jira UE-54345
Change 3851982 by Brandon.Schaefer
Workaround using a hardcoded path
#jira UE-54136
Change 3851748 by Michael.Dupuis
#jira UE-53904: Put the code back to what it was before, as we really only want to perform this code if bIsLayerThumbnail is true, it was changed to fix another issue complaining about a missing shader, that end up being added to the existing functions
Change 3851545 by Marc.Audy
Remove debugging code that slipped in
#jira none
Change 3851461 by Ben.Marsh
Fix #includes with backslashes from crashing UBT.
#jira UE-53996
Change 3851391 by Jamie.Dale
Updated Python to prefer our TPS SDK
#jira UE-54345
Change 3851372 by Jamie.Dale
Added bat file to copy the Python SDK into TPS
#jira UE-54345
Change 3851218 by Ben.Marsh
Add missing template to installed engine build.
#jira UE-54339
Change 3851117 by andrew.porter
QAGame: Removing duplicate map
#jira UE-29618
Change 3851041 by Simon.Tourangeau
Support for DX11 quad buffer stereo rendering
#jira UEENT-704
Change 3850548 by Ben.Marsh
Add TP_HandheldARBP to installed engine build.
#jira
Change 3850424 by Ben.Zeigler
Fix reported memory for asset registry to be correct, extracted from a larger change
#jira none
Change 3850324 by Ryan.Vance
#jira UEVR-1050
Hook up the Rift dynamic res to the new IDynamicResolutionState framework
Change 3849819 by JeanLuc.Corenthin
Unhide Datasmith plugins in "regular" projects to allow easy project conversion
#jira UEENT-795
Change 3849302 by Martin.Wilson
Live Link is no longer experimental in 4.19 (moved from experimental folder to Animation)
#jira none
Change 3849238 by Max.Chen
Sequencer: Remove bKeepStaleTracks so that stale tracks are now always purged.
#jira UE-54248
Change 3849211 by Michael.Dupuis
#jira UE-54181: Prevent foliage edition during PIE or simulate mode
#coderevire jack.porter
Change 3849123 by Benn.Gallagher
Fixed crash in clothing actor creation when the clothing simulation mesh has no simulated vertices
#jira UE-53741
Change 3849120 by Benn.Gallagher
Fixed crash adding empty materials to destructible meshes in the destructible mesh editor
#jira UE-53938
Change 3849047 by Jurre.deBaare
Move material baking out of experimental
#fix follow-up also remove the entry from experimental settings
#jira UE-52685
Change 3848808 by Michael.Dupuis
#jira UE-35097: Remove IncludeTessellationInShadowLOD & RestrictTessellationToShadowCascade from 4.19 as there is currently a bug regarding this in the dynamic rendering code path and would be too risky to fix for now.
Fixed dynamic shadow code path issue vs static code path
Change 3848659 by Lina.Halper
Fix issue with animation resetting in the sequencer
#jira: UE-54047
Change 3848635 by Rolando.Caloca
UE4.19 - Fix static analysis
#jira UE-50449
Change 3848515 by Sorin.Gradinaru
Unshelved from pending changelist '3843541':
WebBrowser Android crash on 4.4.3
#jira UE-53247
#Android
#4.19
Crash on Android 4.x.x caused by a call to a Api Level 21 method
Change 3848514 by Jurre.deBaare
Moving over:
CL 3832173
"Failed to import Alembic files
#jira UE-53941
#fix Change Alembic thirdparty library setup
- Removed old unused library files
- Updated batch files for building HDF5 ILMBase and Alembic libraries to use new AlembicDeploy path
- HDF5 is now build as a Dynamic library (which also enableds multi-threading)
- Added DLLs for HDF5 to build.cs file
CL 3838053
"Adding missing hdf5 dynamic libraries
Change 3848245 by Ben.Marsh
Downgrade warning about not using XGE shader compilation to a log message. Build machines do not have XGE.
#jira UE-54237
Change 3847300 by Phillip.Kavan
Fix shadowed local variable.
#jira UE-54141
Change 3846922 by Max.Preussner
ImgMedia: Fixed image media player never finished initialization if loading failed
Copied from Dev-Sequencer CL# 3846902
#jira UE-54247
Change 3846831 by Arciel.Rekman
Linux: only use lld for x86_64 (UE-54144).
- lld support for other architectures seems to not ready for prime time.
#jira UE-54144
Change 3846771 by Lauren.Ridge
Material window now uses the background color set in preview scene.
#jira UE-52215
Change 3846705 by Ben.Marsh
Fix batch file paths not being quoted correctly when run through XGE.
#jira
Change 3846550 by Lauren.Ridge
Toggling Show Background now updates the background as well
#jira UE-52250
Change 3846417 by Matt.Kuhlenschmidt
Fix crash resizing shootergame window
#jira UE-53137
Change 3846295 by Rolando.Caloca
UE4.19 - New Vulkan descriptor pooling mechanism (enabled on non-android)
#jira UE-50449
Change 3846273 by tim.gautier
QAGame: Updating Material Layer test assets to include more Params
- Added temp assets, quicker repros for bugs
#jira UE-54176, UE-54165
Change 3846255 by Lauren.Ridge
Parameter tab is the primary tab for material instances
#jira UE-54092
Change 3846086 by Chris.Babcock
Add missing SecureHash.h include
#jira UE-54026
#PR #4417
#ue4
#android
Change 3846049 by Martin.Wilson
Fix Set Root Motion Enabled Anim Data Modifier node (previously didn't set the enabled flag)
#jira UE-54220
Change 3846033 by Martin.Wilson
Fix root motion being repeatedly applied ( Clear() call only clears bHasRootMotion flag, not the transform itself )
#Jira UE-54219
Change 3845991 by andrew.porter
QAGame: Updating bindings on activechannels sequencer test content
#jira UE-29618
Change 3845933 by Lauren.Ridge
Check for original material being valid
#jira UE-54166
Change 3845920 by Martin.Wilson
Optimized redundant key removal
#jira UE-51303
Change 3845812 by Matt.Kuhlenschmidt
Fix not being able to change BSP brush shape
#jira UE-53738
Change 3845790 by Martin.Wilson
Fix for assert failure when accumulating root motion in debug.
#jira UE-53955
Change 3845730 by JeanLuc.Corenthin
Fix build breakage
warning: resaved disc.uasset with 4.19.0 preview #1
failure: set the correct default mesh for AreaLightStruct.uasset
#jira none
Change 3845693 by Lina.Halper
Fix issue with previewing pose asset with curve data
#jira: UE-53967
Change 3845533 by Andrew.Rodham
Sequencer: Fixed sub sequences potentially being loaded during AddReferencedObjects
#jira UE-54173
Change 3845472 by Thomas.Sarkanen
Prevented debug object selection dropdown from displaying objects with pending kill outers
#jira UE-54045 - Animation Blueprint Editor Crashes on Compile if the Debug Instance Selection is Other Than No Object or Preview Instance
Change 3845401 by Yannick.Lange
Reverting thumbnail capture from viewport.
#jira UE-53775
#jira UE-53701
Change 3844693 by JeanMichel.Dignard
Changed IES texture brightness to be the max candela value and set the texture multiplier to be 1. This fixes the IES lights intensity being too high.
#jira UEENT-632
Change 3844689 by JeanLuc.Corenthin
Update Datasmith content assets to latest
Copying fix from Dev-Enterprise by Jean-Luc Corenthin CL 3809803
Updated assets with correct release version
Cleanup some paths on static meshes and texture
#jira UEENT-759
#jira UEENT-657
Change 3844571 by Martin.Wilson
Fix motion controller motion source pin still showing when pin is connected to something
#Jira UE-53236
Change 3844564 by Martin.Wilson
Due to previously fixed bug some anim blueprint nodes could have duplicated guids, this fixes them
#Jira UE-54174
Change 3844545 by Jamie.Dale
No longer attempt to parse group separators for numeric inputs
This avoids some ambiguity when parsing numbers for languages such as German
#jira UE-54170
Change 3844221 by Nick.Shin
HTML5 - filter out "windows/super" keys - these are not used in UE4
- but, keycode are not the expected "91 or 92" values, SDL keys are "227 & 231" instead...
#jira UE-54056 HTML5 crashes inside browser upon pressing windows key
Change 3843937 by JeanMichel.Dignard
Fixed a crash when right clicking on a static mesh for which its AssetImportData class is currently unavailable (ie: in an unloaded plugin).
#jira UEENT-764
Change 3843929 by Peter.Sauerbrei
pull over fix for bad directory when copying launch images
#jira UE-53177
Change 3843658 by Thomas.Sarkanen
Text is red again in anim viewports
#jira UE-53224 - Colouring removed from "Animation is being edited" warning messages
Change 3843657 by Thomas.Sarkanen
Enable picking via Enter for details panel asset pickers
The previous (4.18) behavior was to only allow selection of the previous/next item in the list with arrow keys. A fix (CL 3783114) for pickers with many assets broke this. This change now allows for selection of any item by navigating with arrow keys and pressing Enter, as suggested in the Jira.
#jira UE-53440 - Unable to select assets within modal Asset Selection dropdowns after navigating with keyboard entry
Change 3843120 by Dan.Oconnor
Avoid fixing component template games outside the editor, this logic does not work for games that have been nativized
#jira UE-54009
Change 3842841 by Ben.Zeigler
#jira UE-50020
Switch visual studio module back to using absolute paths so go to definition works, broken in CL #3796157
Change 3842582 by Lauren.Ridge
Guards against the widget passed to scrollwidgetintoview being null
#jira UE-54037
Change 3842575 by Max.Chen
Sequence Recorder: Stop recording if the preview window is destroyed.
#jira UE-49778
Change 3842551 by Michael.Dupuis
#jira UE-35097: Minor bug fix, documentation, etc. to the landscape optim that was done in the phase 2 that have 0 risk.
Change 3842371 by Max.Preussner
Media: Merged 4.19 fixes from Dev-Sequencer
CL 3807293 WmfMedia: Fixed YUY2 video format strides
CL 3827988 MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together
CL 3805414 MediaAssets: Setting valid GUID when initializing media texture resource
CL 3804183 MediaAssets: Added missing lock in media sound component
CL 3831580 MfMedia: Media open events generated in same order as on other platforms
CL 3807193 WmfMedia: Fixed incorrect buffer stride for RGB32 video tracks
#jira UE-53532
#jira UE-53328
Change 3842356 by Max.Preussner
ImgMedia: Fixed ensure when cooking project that uses ImgMediaSource
#jira UE-51631
Change 3842335 by Aaron.McLeran
#jira UE-54087
PR #4419: Fixes a crash due to nullptr dereference (Contributed by mgorzel)
Change 3842286 by Rolando.Caloca
UE4.19 - Fix for static analysis
- Glslang 1.0.65.1
#jira UE-54128
Change 3842222 by andrew.porter
QAGame: Updating framerate of EXR_Sequence
#jira UE-29618
Change 3842211 by Ben.Marsh
Fix determination of Windows version string. The manifest for UE4 applications declares compatibility with Windows 10 nowadays, so we get accurate version numbers returned from GetOSVersionInfo().
#jira UE-54035
Change 3842163 by Cosmin.Sulea
UE-53303 - We do not check for remote connection before attempting remote shader compile, causing crashes when misconfigured
#jira UE-53303
Change 3841770 by Max.Chen
Sequencer: Fix to allow keying of an arbitrarily deep property path.
#jira UE-54095
Change 3841758 by Max.Chen
Sequencer: Fix unbound possessable components when pasting spawnables.
#jira UE-54104
Change 3841415 by Lauren.Ridge
Renaming a material layer or material layer blend will no longer cause the asset to appear removed from the stack
#jira UE-53942
Change 3841327 by Arciel.Rekman
Linux: fix Debug build (UE-53855)
- A workaround. UBT should be using proper PCH files instead.
#jira UE-53855
Change 3840975 by Rolando.Caloca
UE4.19 - Updated VulkanRHI
- Fixes for GPU frame time
- Fixes for CPU performance
#jira UE-50449
Change 3840838 by Michael.Dupuis
#jira UE-53944: Make sure the LOD generated is in the valid range to prevent the crash
Change 3840693 by Ben.Zeigler
#jira UE-53923 Fix regression in 4.19 where PrintScriptCallstack is not always safe to call from the immediate window. I narrowed down the issue to some confusing optimized code so I turned off optimization
Copy of CL #3840692
Change 3840680 by Aaron.McLeran
Bringing fixes from Dev-AnimPhys to 4.19.
#jira UE-53903 crash on load with oculus audio and old audio engine
#jira UE-52786, UE-53910 Fix for broken spatialization on xaudio2, old audio engine.
Change 3840663 by Rolando.Caloca
UE4.19 - Fix for layout ensure on HMD projects on Vulkan
#jira UE-50265
Change 3840577 by Rolando.Caloca
UE4.19 - Fix for CPUs with more than 16 cores
#jira UE-53434
Change 3840551 by andrew.porter
QAGame: Setting Allow Bindings from Asset to false
#jira UE-29618
Change 3840491 by Ben.Zeigler
#jira UE-31662 Fix regression with renaming parent inherited function. It was not correctly searching the parent's skeleton class during the child's recompile so it was erroneously detecting the parent function as missing
Copy of CL #3840489
Change 3840297 by Max.Chen
Sequencer: Fix copy/paste crash for lights
#jira UE-54084
Change 3840284 by Michael.Dupuis
#jira UE-53053: Was having a mismatch between the remove reorder and the actual remove
Change 3840215 by Sorin.Gradinaru
Unshelved from pending changelist '3812852':
UE-53550 Level doesn't render on Lenovo 939
UE-53592 Assertion right after rendering scene on Lenovo S939
#jira UE-53550
#jira UE-53592
#4.19
#Android
UE-53550
Removed force disabling texture2DLodEXT and textureCubeLodEXT on Mali-400 devices
The problem was that the shader compiler complains about code lines before the #extension directives.
Placeholder // end extensions in the original shader code - to be replaced with round() functions
UE-53592
Always use a new task for devices that have GIsThreadedRendering=false, even when the call is from the rendering thread
Change 3840048 by Michael.Dupuis
#jira UE-52975: Was always performing the equivalent of an Add, so now we use the Transform during the duplicate
Change 3840005 by Richard.Wallis
Clone of CL 3835252
Fix for shader library not working with iterative cooking, also fixes native Metal library not working with iterative cook. This works by saving a "backup" of the shader library file - this is reloaded only during iterative cook and adds back in shaders that are missing from the current cook.
Fix for extracting/searching .metal files in different directories so debug tgz archiving wasn't working correctly and also support iterative cook.
Includes first pass code review suggestions by Mark Sat and Dmitriy Dyomin.
#jira UE-53815
Change 3839968 by Michael.Dupuis
#jira UE-52289: When OnRegister is called on the component make sure our PerInstanceRenderData is up to date
Prevent a possible crash if ClearInstanceSelection was called on a component with no PerInstanceRenderData existing
##codereview jack.porter
Change 3839924 by Richard.Wallis
Clone of CL 3838093
Fix for rewind / seek bugs in AvfMediaPlayer.
- Don't initialise and send audio buffers that have a duration of Zero from the audio tap. This chokes the audio sink and adds overhead we don't need.
- Don't faff around with current play rates during loop operation - normal seek doesn't do this so loop seek shouldn't either.
- SetRate() should not required to be passed to media tracks - should be enough to do this on audio track select only.
#jira UE-54019, UE-53027
Change 3839321 by andrew.porter
QAGame: Adding missing bookmark to QA-Sequencer_Blending
#jira UE-29618
Change 3839286 by Marcus.Wassmer
Duplicate CL: 3823296
#jira UE-52784
Change 3839229 by Brandon.Schaefer
Fix audio clean up crash when exiting PIE
#jira UE-54050
#review-3839109 @Arciel.Rekman, @Aaron.McLeran
Change 3839223 by andrew.porter
QAGame: Rebinding pointlight actor to sequences
#jira UE-29618
Change 3839098 by andrew.porter
QAGame: Fixing missing sequencer blending test content
#jira UE-29618
Change 3838919 by Mike.Erwin
glTF: binary format's BIN chunk is not necessarily right after the JSON chunk.
Discussed this with glTF spec authors. See https://github.com/KhronosGroup/glTF/issues/1177
Rearranged how we read "chunks" from the file since they are not fixed in number or order, besides JSON always being first.
#jira UE-50695
Change 3838909 by Mike.Erwin
glTF: base64 decoding of data buffers and images
Data can be encoded inside the glTF JSON as a Base64 data URI. This CL addresses a known limitation of initial commit CL 3793018. I added this after because base64 is expected to be uncommon in the wild. Authoring software will typically use external BIN files (.gltf) or a BIN chunk (.glb) to store data.
#jira UE-50695
Change 3838812 by Uriel.Doyon
Integrated CL 3838576, 3838581 and 3831760 from DevRendering, fixing issues with texture streaming.
#jira none
Change 3838773 by Lauren.Ridge
Fixing material layer filters
#jira UE-54064
Change 3838748 by Michael.Trepka
Fixed EngineTest runtime warning caused by CL 3838626
#jira UE-53893
Change 3838730 by Max.Chen
Sequencer: Add notification when the blend type is changed.
#jira UE-54046
Change 3838626 by Michael.Trepka
Changed FMacMenu to store MultiBox and MenuEntryBox as weak pointers instead of shared pointers. This way we avoid a situation where FMacMenu would try to release them on the main Cocoa thread or where we'd try to execute a menu action for menu items that Slate considers released.
#jira UE-53893
Change 3838392 by Arciel.Rekman
Fix assert on a policy removal (UE-54042).
- Applying Gil's safe fix which just sweeps the problem under the rug.
#jira UE-54042
Change 3838162 by Arciel.Rekman
Linux: fix crash due to lambda lifetime issues (UE-54040).
- The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+).
#jira UE-54040
(Edigrating 3819174 to Release-4.19)
Change 3838156 by Rolando.Caloca
UE4.19 - Support for Vulkan devices that have no cached memory type
#jira UE-54039
Change 3838096 by Brandon.Schaefer
Set sound to unfocused volume multiplier if not focused
#jira UE-51327
#review-3835736 arciel.rekman
Change 3838087 by Brandon.Schaefer
Fix arm server building. A fix from CL 3617084 remove inheriting from IHeadMountedDisplayVulkanExtensions. Remove overrides
#jira UE-53901
#review-3838088 arciel.rekman
Change 3837072 by Phillip.Kavan
Fix for a build failure that could occur with Blueprint nativization enabled and EDL disabled. This was a regression introduced in 4.18.
- Mirrored from //UE4/Dev-Framework (3836768).
#jira UE-53908
Change 3837071 by Phillip.Kavan
Emit proper syntax for set/map fields containing converted assets to generated C++ Blueprint class headers when Blueprint nativization is enabled.
- Mirrored from //UE4/Dev-Framework (3835944, 3835965).
#jira UE-42614
Change 3837070 by Phillip.Kavan
#4202 - Blueprint nativization bug fixes (PR).
- Mirrored from //UE4/Dev-Framework (3830562, 3832292).
#jira UE-52188
Change 3836507 by Ryan.Vance
#jira UE-53992
Due to hijacking the depth target directly from the scene context, we can't support depth compositing if it's being scaled by screen percentage since it wont match our color render target dimensions.
Change 3836390 by Dan.Oconnor
Fix failure to resolve archetype when using the compilation manager
#jira UE-53840
Change 3836251 by Ryan.Vance
#jira UE-53992
Change 3835852 by Mark.Satterthwaite
Fix tessellation shaders in Metal with Manual Vertex Fetch enabled:
- The control points idnex buffer shouldn't collide with anything else.
- We can't use the optimisation of loading texture width & height from the buffer meta-table in tessellation shaders as the combined stages don't guarantee not to clobber unused buffer slots and screw it up when we use linear textures.
#jira UE-53851
Change 3835802 by JeanMichel.Dignard
UBT changes for Enterprise deployment
- Allow building enterprise against an installed engine version
- Added enterprise to the cleanup process if its not installed
#jira UEENT-748
Change 3835625 by Bogdan.Vasilache
UE-50257 --> (Skeletal meshes silently fail to render if they have more than 75 bones) --> changed logged error with a warning
#jira UE-50257
Change 3833649 by Mike.Beach
Enabling debug layer when multiview is enabled.
#jira UE-49954
Change 3833525 by Ethan.Geller
Fix copyright in ActiveSound.cpp #jira none #rb none
Change 3642649 by Stewart.Lynch
Renamed loctext key to stop it clashing with an existing entry
#jira UE-49432
Change 3644762 by Stewart.Lynch
LLM update: Added Total, Untracked and FMalloc Unused to LLMFULL stat page. Fixed occasionally missing allocs/frees. Removed platform csv.
* removed CheckSize arg from OnLowLevelFree
* show a warning in LLM Map when replacing existing value. This means that there has been an alloc/free mismatch.
* minor optimization in LLMMap::GetMaxIndex - cache Mask value
* added Total and Untracked stats to LLMFULL. LLMFULL now tracks almost all of the memory that LLMPlatform does, so there is no real need to use LLMPlatform. Removed the LLMPlatform csv.
* added FMalloc Unused stat to LLMFULL to account for memory Binned2 has allocated internally. This can be used to track Binned2 fragmentation over time.
* renamed Binned stats to FMemory to make it more general
* added Default tracking to CustomVirtualAlloc and disable it where necessary. This catches the few VirtualAlloc calls that were missed.
* added AllocType arg to all allocation tracking. This was needed in order to track the FMalloc total, and also to fix the pausing
* fixed a bug in pausing where alloc/frees were being missed. Now only pauses a specific allocation type.
* Trackers now maintain totals for each enum tag
* tracking of Texture and mesh allocation on Windows D3D11 & D3D12
Change 3651334 by Joe.Barnes
Fix misspelled function name.
#jira 39441
#3016
Change 3653857 by Ben.Woodhouse
Integrate from //UE4/Main/...@3653675 to //UE4/Dev-Console/...
Change 3656553 by Joe.Barnes
Add path for SCS_DeviceDepth.
Change 3662703 by Ben.Woodhouse
Merging CL 3659069 from //Fortnite/Main/... to to //ue4/dev-console/...:
[FORTNITE] [CONSOLE] [+] Improved frame syncing mechanism
- Improves input latency by allowing the game thread to sync to the swap chain flip of the previous frame.
- Added "r.GTSyncType" CVar to control how the game thread syncs with the rest of the pipe.
- r.GTSyncType 2 will sync the game thread with the flip of the swap chain, preventing the pipe from getting too long and causing excess input latency.
Platforms are required to implement RHIWaitForFlip and RHISignalFlipEvent, and call RHIInitializeFlipTracking on RHI startup.
A separate thread monitors the progress of frame flips and signals task graph events as they pass their corresponding frame index.
In r.GTSyncType 2 mode, the game thread is signaled by this flip tracking thread.
[~] Unified platform specific sync interval CVars into one: rhi.SyncInterval
- 1 == 60Hz
- 2 == 30Hz
- 3 == 20Hz
Change 3675239 by Keith.Judge
Fixed thread priorities for Windows so that BelowNormal and SlightlyBelowNormal are the same. Bumped Lowest down a notch so they all fit.
#jira UE-50626
Change 3676709 by Ben.Woodhouse
Integrate from //UE4/Main/...@3675008 to //UE4/Dev-Console/...
Change 3689712 by Ben.Woodhouse
Integrate from //UE4/Main/...@3687781 to //UE4/Dev-Console/...
Change 3701778 by Ben.Woodhouse
Integrate from //UE4/Main/...@3699491 to //UE4/Dev-Console/...
Change 3677043 by Ben.Woodhouse
From StewartL:
I also found that on Windows Fortnite is overflowing int32 values due to the number of allocations. I changed LLMArray and LLMMap to use uint32 and it seems to be Ok now. I didn't want to check this in at the last minute, so here's the shelf: 3645336
Change 3726532 by Luke.Thatcher
[CONSOLE] [~] Enable XGE shader compilation by default.
- Also set XGE mode to "force interception". With XGE on by default, we don't want people with an old Incredibuild version using the old system inadvertently.
Change 3726554 by Luke.Thatcher
[CONSOLE] [+] Improved Scoped Named Events
- Added SCOPED_NAMED_EVENT(_FSTRING/_TEXT/_F) macros to allow use of string literals, FString and printf in scoped named event strings.
- Replaced explicit use of FPlatformMisc::Begin/EndNamedEvent throughout the engine with macros, so the events can be compiled out.
- Fixed performance issues on various platforms with named events. SCOPED_NAMED_EVENT macros were not considering whether the platform uses wide or ansi char strings.
Change 3751378 by Ben.Woodhouse
Integrate from //UE4/Main/...@3748735 to //UE4/Dev-Console/...
Change 3751812 by Ben.Woodhouse
Integrate from //UE4/Main/...@3750870 to //UE4/Dev-Console/...
Change 3728571 by Luke.Thatcher
[CONSOLE] [!] Drop another XGE controller warning to log.
Change 3747150 by Joe.Barnes
Add AuthoringToolHelper.bat file to installed build copy list.
Change 3768585 by Ben.Woodhouse
Integrate from //UE4/Main/...@3767531 to //UE4/Dev-Console/...
Change 3772333 by Ben.Woodhouse
Integrate from //UE4/Main/...@3771573 to //UE4/Dev-Console/...
Change 3786872 by Ben.Woodhouse
Integrate from //UE4/Main/...@3786785 to //UE4/Dev-Console/...
Change 3787279 by Luke.Thatcher
[CONSOLE] [~] Unified present threshold CVars.
- CVars are now in RHIUtilities.cpp, and are renamed to rhi.PresentThreshold.Top and rhi.PresentThreshold.Bottom.
- Platform implementations will be checked in shortly.
Change 3787445 by Luke.Thatcher
[CONSOLE] [^] Merging (as edit) improvements to low-latency frame syncing from //Fortnite/Main to //UE4/Dev-Console
Original CLs
- 3708949 - Added rhi.SyncSlackMS cvar to allow an offset of the game thread sync time by a number of milliseconds.
- 3712693 - Fix for crash on startup in new frame syncing.
- 3735765 - Fix r.GTSyncType logic when vsync is disabled (falls back to old behaviour when vsync is off).
Change 3788417 by Ben.Woodhouse
Duplicate from FN CL 3712515
CSV profiler GPU and pre-declared stat support
- refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds
- add support for pre-declared CSV stats, using FNames (these are required for GPU stats)
- add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations
Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats
Change 3807818 by Ben.Woodhouse
Integrate from //UE4/Main/...@3803271 to //UE4/Dev-Console/...
Change 3818577 by Ben.Woodhouse
Integrate from //UE4/Main/...@3812936 to //UE4/Dev-Console/...
Change 3821198 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3820127 to //UE4/Dev-Console/...
Change 3821519 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3820753 to //UE4/Dev-Console/...
#robomerge none
Change 3813513 by Ben.Woodhouse
CSV profiler refactor+ bug fix
- Move the CSV profiler to core, so we can use it in modules other than engine
- Profiler no longer enqueues RT commands - this is handled by a new core delegate type
- Make begin/end requests more robust, enqueued via a command queue and processed in order
- Defer end capture requests by a frame. This ensures stats on threads other than the gamethread (e.g. renderthread etc) are complete, so the last frame is not truncated
- Fix long-standing bug with multiple captures where old/stale frames would appear in the first <128 frames of captures
- Move unit stats and dynamic resolution out of the profiler itself and into the engine. Only frametime is recorded in the profiler now
- Fix longstanding bug in first frame renderthread time in the engine
Change 3814039 by Ben.Woodhouse
More Csvprofiler improvements
- Event support (via CSV_EVENT macros). These appear in the "EVENTS" column of the CSV and can be used to add context to the stat data
- Reduced memory overhead for timestamps through bit-packing (now 16 bytes per marker instead of 24), and splitting stats into different types
Change 3814041 by Ben.Woodhouse
Integrate as edit CL 3796390 from Fortnite/Main:
Fix CsvProfiler not compiling in shipping for now
Change 3814229 by Ben.Woodhouse
Integrate + refactor of CL 3792591 to reduce complexity and fix bugs
Original changelist description:
CSV profiler improvements:
- The CSV profiler is now always compiled in on the server
- The CSV profiler can now handle both int32 and float stats
- In BeginCapture, the function can take additional arguments for some customization of filenames
Fixes to the above:
- Remove FCustomValue class
- Fixes bug where all timestamp values from CSV_SCOPED_STATs were garbage (due to issues resulting from FCustomValue type ambiguity when adding values together)
- FCsvCustomStat now just uses simple union + bitfield flag to reduce size and complexity (4 bytes instead of 8 per value)
- FCsvColumn class modified to use doubles, which can represent both ints and floats without loss of precision - this class is not memory or time critical
- Replace multiple overrides used by the server for filenameprefix/folder/postfix etc with a single FilenameOverride
Change 3814242 by Ben.Woodhouse
Disable CSV unit stats on the dedicated server
Change 3817339 by Ben.Woodhouse
Duplicate from 3816641: CSV profiler improvements
- Added a low-pri processing thread to compress raw timing data into a much more efficient format
- Reduces memory usage for 15 minute 30k frame capture with GPU stats enabled from 110MB to 3.4MB
- Processing time : 0.1ms per frame
- Improved name handling for char literal stats. We now use the string as the ID rather than the pointer so multiple stat uses of the same name string apply only to a single stat
- Reworked thread data access to eliminate locking for anything time-critical. Frame boundaries now handled via a lock-free helper class
- Fixed bug with queue implementation where 1 in 128 reads would duplicate the last block of stat data
- Reduced #include dependencies for CSVProfiler.h
- Removed AccumulateMax because it doesn't work, and implementing properly would add a lot of complexity
- Added a simple test harness
Change 3817582 by Ben.Woodhouse
Fix android compile warning
Change 3823242 by Ben.Woodhouse
Integrate as edit from Fortnite/Main 3820067:
Fix threading issue with D3D12 pipeline state caches for windows. This was caused by the usage of FRwScopeLock::RaiseLockToWrite. A pointer read before RaiseLockToWrite was called was invalidated because RaiseLockToWrite has to release the read lock before acquiring the write lock.
Rename FRwScopeLock::RaiseLockToWrite to ReleaseReadOnlyLockAndAcquireWriteLock_USE_WITH_CAUTION to make it more explicit what's happening. As the comment says:
// This function should be used with caution.
// It releases the read lock _before_ acquiring a new write lock. This is not an atomic operation and the caller should
// not treat it as such.
// E.g. Pointers read from protected data structures prior to this call may be invalid after the function is called.
Change 3823840 by Ben.Woodhouse
Edigrate from 3823816
Fix an issue where the csvprofile console commands would sometimes result in an empty CSV. The root cause was GFrameNumber incrementing between the console command being read and FCSVProfiler::EndFrame(). We now use our own frame counter which is updated in EndFrame, so this can't happen
Also fix an issue where calling csvprofile stop twice would cause all further commands to be ignored.
Change 3827787 by Ben.Woodhouse
Integrate-as-edit CL 3820678 from Fortnite/Main
Allow the CSV Profiler to be compiled in to shipping dedicated server builds
Change 3827842 by Ben.Woodhouse
Integrate-as-edit CL 3827079 from Fortnite/Main
CSV profiler category support
Change 3827918 by Luke.Thatcher
[CONSOLE] [!] Fix compile error in CSV custom stats.
Change 3827964 by Luke.Thatcher
[CONSOLE] [!] Fix inverted logic and spelling of boolean.
- Functionally, the boolean did the correct thing, but the logic was backwards inside the build tool.
Change 3831661 by Ben.Woodhouse
Integrate-as-edit CL 3830630 from Fortnite/Main
Fix CSVProfiler assert in dev builds on XB1
Change 3860300 by Joe.Barnes
Use same method for src and dest rect calculation as other post processing passes so rects match between passes. Prevents read of unprocessed pixels.
Change 3860347 by Joe.Barnes
Delete existing SourceConfigFile before allocating a new one to prevent them leaking.
Change 3860348 by Joe.Barnes
Completely encapsulate GetLLMAlloc() in #ifdef.
Change 3861772 by Ben.Woodhouse
Integrate-as-edit CL 3861688 from Fortnite/Main: Forward lighting GPU crash fixes
Change 3861774 by Ben.Woodhouse
Integrate as edit CL 3833918 from dev-rendering (courtesy of DanielW):
D3D12 RHI: only refcount uniform buffers if GRHINeedsExtraDeletionLatency is false, which is no longer the case for PC. The refcounting was heavy on performance as reported by a licensee because FRHIResource uses atomics for refcounting, which is only necessary when GRHINeedsExtraDeletionLatency is disabled.
Change 3862214 by Ben.Woodhouse
Integrate-as-edit CL 3859637 from Fortnite/Main
Dynamic resolution console tweaks
- Dynamic resolution high level switch driven by a cvar instead of code
- Disable user settings dynamic resolution handling on non-desktop platforms. DynamicRes as a user setting does not make sense on consoles/mobile - we'll drive it from device profiles/scalability
- Modify naming of GPUHeadRoom to make it clear that it's a percentage, not millseconds
Change 3863919 by Ben.Woodhouse
[Copy] Integrate console dynamic resolution interface changes from CL 3863354, 3862754, 3862639
Change 3864347 by Ben.Woodhouse
Fix the editor build. This will need a proper fix before 4.19 ships.
#lockdown Nick.Penwarden
#rb none
[CL 3913399 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3805828 by Gil.Gribb
UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works.
Change 3806784 by Ben.Marsh
UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT.
Change 3807549 by Graeme.Thornton
Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it.
Change 3807727 by Graeme.Thornton
Unhide the text asset format experimental editor option
Change 3807746 by Josh.Engebretson
Remove WER from iOS platform
Change 3807928 by Robert.Manuszewski
When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet
Change 3808221 by Steve.Robb
GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule()
^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway.
Change 3809233 by Graeme.Thornton
TBA: Misc changes to text asset commandlet
- Rename mode to "loadsave"
- Add -outputFormat option which can be assigned "text" or "binary"
- When saving binary, use a differentiated filename so that source assets aren't overwritten
Change 3809518 by Ben.Marsh
Remove the outdated UnrealSync automation script.
Change 3809643 by Steve.Robb
GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value
#jira UE-53037
Change 3809862 by Steve.Robb
GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately
#jira UE-42593
Change 3811190 by Graeme.Thornton
Add support for writing specific log channels to their own files
Change 3811197 by Graeme.Thornton
Minor updates to output formatting and timing for the text asset commandlet
Change 3811257 by Robert.Manuszewski
Cluster creation will now be time-sliced
Change 3811565 by Steve.Robb
Define out non-monolithic module functions.
Change 3812561 by Steve.Robb
GitHub #3886 : Enable Brace-Initialization for Declaring Variables
Incorrect semi-colon search removed after discussion with author.
Test added.
#jira UE-48242
Change 3812864 by Steve.Robb
Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins.
See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html
#jira UE-53089
Change 3820358 by Ben.Marsh
PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist)
Change 3822594 by Ben.Marsh
UAT: Improvements to log file handling.
- Always create log files in the final location, rather than writing to a temp directory and copying in later.
- Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX.
- Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is.
- Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location.
Change 3823695 by Ben.Marsh
UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk).
Now always queries changes up to the last change for which zipped binaries are available.
Change 3823845 by Ben.Marsh
UBT: Exclude C# projects for unsupported platforms when generating project files.
Change 3824180 by Ben.Marsh
UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes).
#jira
Change 3825777 by Steve.Robb
Fix to return value of StringToBytes.
Change 3825810 by Ben.Marsh
UBT: Reduce length of include paths for MSVC toolchain.
Change 3825822 by Robert.Manuszewski
Optimized PIE lazy pointer fixup. Should be up to 8x faster now.
Change 3826734 by Ben.Marsh
Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency.
Change 3827730 by Steve.Robb
Try to avoid decltype(auto) if it's not supported.
See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html
Change 3827745 by Steve.Robb
Initializer list support for TMap.
Change 3827770 by Steve.Robb
GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType()
#jira UE-53813
Change 3829189 by Ben.Marsh
UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off.
Change 3830444 by Steve.Robb
BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library.
This should be revisited when Core has its own JSON library.
Change 3830718 by Ben.Marsh
Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups.
The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip.
For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it.
When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk.
#jira UE-53845
Change 3831064 by Ben.Marsh
Fix log file contention when spawning UBT recursively.
Change 3832654 by Ben.Marsh
UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it.
Change 3832680 by Ben.Marsh
UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade.
Change 3832695 by Ben.Marsh
UGS: Invert the options in the 'Show Changes' submenu for simplicity.
Change 3833528 by Ben.Marsh
UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write].
Change 3833543 by Ben.Marsh
UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules.
Change 3834354 by Robert.Manuszewski
Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks.
#jira UE-52035
Change 3834400 by Robert.Manuszewski
Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup.
#jira UE-52035
Change 3834947 by Steve.Robb
USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal.
Change 3835004 by Ben.Marsh
Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL.
Change 3835340 by Ben.Marsh
Fix errors making installed build from directories with spaces in the name.
Change 3835972 by Ben.Marsh
UBT: Improved diagnostic message for targets which don't need a version file.
Change 3836019 by Ben.Marsh
UBT: Fix warnings caused by defining linkage macros for third party libraries.
Change 3836269 by Ben.Marsh
Fix message box larger than the screen height being created when a large number of modules are incompatible on startup.
Change 3836543 by Ben.Marsh
Enable SoundMod plugin on Linux, since it's already supported through the editor.
Change 3836546 by Ben.Marsh
PR #4412: fix type mismatch (Contributed by nakapon)
Change 3836805 by Ben.Marsh
Fix commandlet to compile marketplace plugins.
Change 3836829 by Ben.Marsh
UBT: Fix ability to precompile plugins from installed engine builds.
Change 3837036 by Ben.Marsh
UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds.
Change 3837037 by Ben.Marsh
UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro).
Change 3837040 by Ben.Marsh
UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed.
Change 3837247 by Ben.Marsh
UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files).
Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor.
Change 3837262 by Ben.Marsh
UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module.
Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets.
Change 3837343 by Ben.Marsh
UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead.
Change 3837356 by Ben.Marsh
Fix invalid character encodings.
Change 3837727 by Graeme.Thornton
UnrealPak: KeyGenerator: Only generate prime table when required, not all the time
Change 3837823 by Ben.Marsh
UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window.
Change 3837831 by Graeme.Thornton
UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives
Change 3837857 by Robert.Manuszewski
PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch)
Change 3837943 by Robert.Manuszewski
PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch)
Change 3838451 by Ben.Marsh
UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread.
#jira UE-53996
Change 3839519 by Ben.Marsh
UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data.
Change 3843790 by Graeme.Thornton
UnrealPak: Log the size of all encrypted data
Change 3844258 by Ben.Marsh
Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace.
Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure.
#jira UE-54157
Change 3845796 by Ben.Marsh
Workaround for slow performance of String.EndsWith() on Mono.
Change 3845823 by Ben.Marsh
Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun.
#jira UE-54123
Change 3845901 by Arciel.Rekman
Linux: fix crash due to lambda lifetime issues (UE-54040).
- The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+).
(Edigrating 3819174 to Dev-Core)
Change 3846439 by Ben.Marsh
Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates.
Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main.
Change 3816608 by Ben.Marsh
UBT: Use DirectoryReference objects for all include paths.
Change 3816954 by Ben.Marsh
UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere.
Change 3816986 by Ben.Marsh
UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly.
Change 3816991 by Ben.Marsh
UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules.
Change 3823090 by Ben.Marsh
UAT: Improve logging for child UAT instances.
- Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder.
- Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway.
- Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read.
- Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output.
Change 3826082 by Ben.Marsh
UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target.
Change 3827025 by Ben.Marsh
UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling.
Change 3829927 by James.Hopkin
Made HTTP interface const correct
Change 3833533 by Ben.Marsh
Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules.
Change 3835826 by Ben.Marsh
UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced.
Change 3835969 by Ben.Marsh
UBT: Fix cases where text is being written directly to the console rather than via logging functions.
Change 3837777 by Steve.Robb
Format string type checking added to FOutputDevice::Logf.
Fixes for those.
Change 3838569 by Steve.Robb
Algo moved up a folder.
[CL 3847482 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
#rnx
============================
MAJOR FEATURES & CHANGES
============================
Change 3783110 by Thomas.Sarkanen
Added support for logical negation when copying to array properties in the fast path
#jira UE-52043 - Anim fast path correctly doesn't handle copying to arrays of bools with logical negation
Change 3783112 by Thomas.Sarkanen
Fixed not being able to assign/unassign constraint and physical animation profiles from the context menu
#jira UE-50205 - Constraint cannot be assigned or unassigned from current profile when using "Unassign" from the context menu in the Skeleton Tree and Graph
Change 3783114 by Thomas.Sarkanen
Asset picker now only reports 'picks' on user interactions
In Ocean and other projects with lots of animation assets, the asset picker amortizes its filter queries over a number of frames. This causes the list to temporarily not include the currently selected item, which then gets reported to client code as a 'deselection'. To address this (and to maintain backwards compatibility) I've added a new delegate that gives more context for selections to the SAssetPicker, allowing us to not report selections that are 'Direct'.
#jira UE-46802 - Searching for an animation from the dropdown in persona causes it to instantly close
Change 3783118 by Thomas.Sarkanen
Added inline time/frame settings to notify context menu
#jira UE-45410 - Inline MontageSection/Notify Time Entry
Change 3783122 by Thomas.Sarkanen
Collision Response dropdown is now a checkbox
Added details customization to allow the enum to masquerate as a bool property
#jira UE-47916 - Drop down used for Collision Response enable/disable in Physics Asset Editor
Change 3783183 by Jurre.deBaare
Follow up fix for toggling post processing in the preview scene
Change 3783186 by Jurre.deBaare
Material Baking Options has two Mesh Settings sections
#fix Changed category names for to allow for two distinct categories (would have preferred to merge them, but am limited by the way detailsview handles multiple objects with containing same category)
#jira UE-52645
Change 3783188 by Jurre.deBaare
Duplicating:
"Simplygon Skelmesh "Regenerate" button remains for content that had Lods created in simplygon, even when it's not installed. On regenerating editor crashes - FPersonaMeshDetails::ApplyChanges()
#fix Ensure the regenerate button is disabled when there is no MeshReduction interface available
#jira UE-52641
Change 3783205 by Jurre.deBaare
Bounds are not shown correctly in Persona for imported alembic skeletal mesh
#fix Ensured that we do not add invalid of (0,0,0) bounds to outgoing mesh bounds
#jira UE-49338
Change 3783248 by Jurre.deBaare
Preview Scene Settings window is missing Search bar
#fix changed search bar flag on Details View
#jira UE-50063
Change 3783267 by Jurre.deBaare
Animation Modifiers: GetBonePosesForTime does not create valid data for GetBonePose
#fix changed the way we retrieve bone transforms, now take it directly from the raw data rather than from a pose
#jira UE-52057
Change 3783281 by Jurre.deBaare
Tool Tip issues in Animation Editor Preferences
#fix corrected typos in comments
#jira UE-51338
Change 3783373 by Thomas.Sarkanen
Added error-reporting to the profile name widgets
This means that the effect of renaming profiles the same as an existing one is clear (i.e. we deny it now).
#jira UE-48120 - Renaming Physics profiles the same as existing Physics profiles switches profiles and is confusing
Change 3783438 by Jurre.deBaare
Vertex paint fill tool fills all channels
#fix Ensure that the current channel fill selection in the Mesh Painter is also used for the fill tool, to allow the user masking out certain channels when using fill
#jira UE-49256
Change 3783583 by Thomas.Sarkanen
Correctly return whether a mesh section is shown or not when it has not been edited
This fixes skeletal->static mesh conversion
Change 3783598 by Thomas.Sarkanen
Fix multi-convex generastion for skeletal meshes
Some triangle indices were being missed out of the index buffer, so the mesh that the convex hull was generated from was corrupt. Removing an early-out fixes this.
#jira UE-52529 - Inaccurate Collision is Generated When Using Multi Convex Hull (PhysicsAsset Editor)
Change 3783615 by Jurre.deBaare
OpacityMask/Opacity bug in MeshUtilities
#fix ensured that material baking uses correct texture samples for Opacity Mask property
#misc deprecated all of this functionality as users should be using the MaterialBaking module
#jira UE-52382
Change 3783620 by Martin.Wilson
Fix crash due to oversampling animation during compression
#Jira UE-52713
Change 3783633 by Jurre.deBaare
Fix deprecation warnings on CIS
Change 3783636 by Benn.Gallagher
Fixed non-working tethers in clothing
Fixed clothing config not applying to active simulation after editing
Fixed and re-enabled accurate wind mode
#jira UE-50797, UE-43611
Change 3783637 by Benn.Gallagher
Github PR: Fix world to actor transform bug in anim dynamics
Fixed incorrect Actor-space calculations for simulation transforms and world vector transformations inside AnimDynamics highlighted when testing the above PR
#jira UE-48681
#3929
Change 3783638 by Benn.Gallagher
Fixed UBlendProfile properties not being correctly customized on anim nodes - and animation sequence references not being correctly filtered on anim nodes.
Change 3783660 by Danny.Bouimad
Fixing #UE-40686 Mass TranslatedMass Automated test, instead of decreasing tolrence I changed the content to preserve granularity.
Change 3783974 by Ori.Cohen
Refactor when sync components is called and how we pass the data into plugins. Simplifies how we handle physx data getting invalidated by UE4 during updates.
Also fixed crash when scene query returns a destructible component that's been destroyed, but final apex delete flush hasn't happened yet.
#jira UE-50215
Change 3784112 by Benn.Gallagher
Fixed subinstance nodes inside states failing to correctly create bridge variables on their skeleton class due to not correctly processing subgraphs in the anim blueprint compiler.
#jira UE-51000
Change 3784277 by Martin.Wilson
Fix socket name getting an appended _0
#jira UE-46625
Change 3785589 by Ori.Cohen
Fix cis
Change 3786336 by Martin.Wilson
Pushing skeleton to live link can now take source guid
-Message bus source pushes guid when sending skeleton
Change 3786778 by Martin.Wilson
Added ability for worker thread animation blueprint code to report to Message Log + added additive warning when playing an animation on an additive pose
#jira UE-49780
Change 3786847 by Martin.Wilson
Initialization and delta time for live link retargeter
#Jira UE-52112
Change 3786852 by Lina.Halper
Sequencer blending support
#jira: UE-52183
Change 3786924 by Lina.Halper
PR #4210: FIX: Incorrectly passing an unrelated bool rather than the expected pose ind. (Contributed by ruffenman)
Change 3787114 by Jurre.deBaare
Discrepancy in description of Preview Scene setting and keyboard shortcut
#fix Changed naming of the settings to match the Advanced Preview Scene panel
#jira UE-50060
Change 3787115 by Jurre.deBaare
Animation Editor Preferences do not update the preview scene
#fix Removed unused preference from PersonaOptions
#jira UE-51318
Change 3787117 by Jurre.deBaare
Off-by one error in frame time calculations
#fix Fixed up UAnimSequenceBase::GetTimeAtFrame and UAnimSequenceBase::GetFrameAtTime to return correct frame indices, similar to FAnimationRuntime::GetKeyIndicesFromTime
#jira UE-52037
Change 3787412 by Martin.Wilson
CIS Fix
Change 3787622 by Ethan.Geller
Include Google Resonance SDK.
Change 3787633 by Ethan.Geller
Promote AmibsonicsMixerPtr to FAudioDevice
Change 3788026 by Lina.Halper
Retarget source reference to soft object ptr
#jira: UE-48570
Change 3788252 by Ethan.Geller
Add blueprint functions for Resonance Global Reverb
Change 3788750 by Ethan.Geller
fix single file compile for Resonance plugin
Change 3788763 by Ethan.Geller
include IModularFeatures.h explicitly for incremental build
Change 3789108 by Martin.Wilson
Fix animations with scaled root bone generating incorrect root motion
#jira UE-52088
Change 3789642 by Martin.Wilson
Fix transition nodes from referencing the wrong state node due to non unique node guids being introduced by copy and paste
#jira UE-43891
Change 3790165 by Martin.Wilson
Fix marker sync position not being maintained across instant transitions
#jira UE-21355
Change 3790182 by Ethan.Geller
Final Resonance edits pass.
Change 3790184 by Lina.Halper
Fix issue with crash when montage is streamed out while event is queued.
https://udn.unrealengine.com/questions/404318/anim-montage-queued-montage-event-crash.html
Change 3790207 by dan.reynolds
#UE-50774 Updated AEOverviewReverb to not attempt to destroy Audio Component that has already been destroyed.
Change 3790215 by Martin.Wilson
CIS Fix
Change 3790953 by Ethan.Geller
#jira UE-53023 bypass filters when at max frequency for LPF, DC for HPF
Change 3791832 by Martin.Wilson
Don't load animations for preview tooltip in Persona
#jira UE-52118
Change 3792873 by David.Hill
Fix CIS. Remove timer from proxylod code.
Change 3793251 by David.Hill
ProxyLOD Thirdparty libs build cs files.
Update from ModuleRules.WindowsPlatform to ReadOnlyTargetRules.WindowsPlatform
-- The WindowsPlatform alias is deprecated in 4.18
Change 3793400 by Ethan.Geller
Update Resonance blueprint library to fit google naming conventions
Change 3794097 by Benn.Gallagher
Fixed clothing visualizations no longer functioning
#jira UE-52995
Change 3794250 by Danny.Bouimad
Regenerated ground truth on LODCurveLinkingTest1 and AnimatedCloth, expected change as a result of Ben fixing a bug.
Needed to update Owens cloth settings too.
Should resolve automation test CIS fails
Change 3794352 by David.Hill
ProxyLOD code:
Disable openvdb-centric warnings within the openvdb platform.h file.
C6326: Potential comparison of a constant with another constant
and add annotations
C28251: Inconsistent annotation for 'copysign'
also added a warning suppress for static analysis CA_SUPPRESS(6011) within the proxylod version of the simplifier.
Change 3794786 by Lina.Halper
Pose asset retarget source bug fix
#jira: UE-52429
Change 3794841 by Danny.Bouimad
Hopefully fixes the cloth automation CIS
Change 3795191 by Lina.Halper
Fix build issue
Change 3795486 by Ethan.Geller
re-enable android support for Oculus Audio
Change 3796162 by Danny.Bouimad
Third attempt to fix the cloth CIS error. Hopefuly this will solve it.
Change 3796311 by Martin.Wilson
Remove recompress animation from curve track actions. Allows smoother interaction on animations with slow recompress time.
#jira UE-51740
Change 3796321 by Thomas.Sarkanen
Duplicating CL 3770752 from 4.18:
Prevent crash when generating convex bodies fails
Note: speculative fix as the issue cannot be reproduced locally
#jira UE-52449 - [CrashReport] FPhysicsAssetUtils::CreateFromSkeletalMeshInternal()
Change 3797093 by Danny.Bouimad
Constrant node AnimBP Automated tests
Change 3797384 by Danny.Bouimad
Fixing CIS error caused by automated test lighting issue
Change 3800621 by Thomas.Sarkanen
Fix CIS: Shadowed variable warning
#jira UE-53253 - FMenuBuilder declaration shadows a local variable warning appears when building the editor on Linux
Change 3800690 by Danny.Bouimad
Checking in fix for CIS automation for ConstraintNode, set the screenshot tool to use BaseColor. This should fix the issue with the rendering fuzzyness
Change 3800874 by David.Hill
Clean up static analysis warnings
#jira: UE-53270
Change 3801227 by David.Hill
Allow proxylod to fail gracefully if the input mesh is way too big (e.g. sky sphere)
Added code to automatically compute the correct spatial sampling rate based on the geometry size, also allow the user to override.
#cl: UE-53155
Change 3801228 by David.Hill
UI: Mesh Proxy Dialog re-write. Make this more like MeshMerging, and share some code.
#cl UE-53155, UE-52787, UE-53106
Change 3801319 by Danny.Bouimad
Regenerated all the screen shots for the constraint tests.
Change 3801383 by Ethan.Geller
#jira UE-53311 fix additional #if PLATFORM_WINDOWS guards in Oculus Audio
Change 3801697 by Ethan.Geller
include AudioDevice.h directly to resolve FAudioDevice.
Change 3802180 by David.Hill
This should fix the Incremental UE4Editor Linux build.
Change 3802643 by David.Hill
ProxyLOD UI change. Add limits to the target screen size. They now reflect the values in the old version of the UI and the thirdparty tool.
#CL: UE-53313
Change 3802986 by Ethan.Geller
#jira UE-53330 Change vraudio to explicit library path
Change 3803448 by Danny.Bouimad
disabling constraint tests
Change 3803678 by Danny.Bouimad
#jira UE-53306 Fix
Change 3804333 by Ethan.Geller
#jira UE-53330 fix library paths for iOS on Resonance
Change 3804453 by David.Hill
Fix Shadow warning when compiling UE4Editor on linux:
FlattenedMaterials.
#CL: UE-53349
Change 3804510 by Lina.Halper
CIS warning on shadow vars
#jira: UE-53348, UE-53345
Change 3805451 by Lina.Halper
Fix build issue : Renamed variable -
https://ec-01.epicgames.net/commander/link/jobStepDetails/jobSteps/74095846?stepName=Incremental%20UnrealHeaderTool%20Win64&jobId=8173688&jobName=UE4%20Dev-AnimPhys%20-%20CL%203805429%20-%20Incremental%20Editor%20Win64&tabGroup=diagnosticHeader
Change 3805470 by Lina.Halper
Fix build issue
Change 3806524 by Martin.Wilson
Only use previous frame end position if it is valid for this frame
#jira UE-53414
Change 3792620 by David.Hill
Copying //UE4/Dev-ProxyLOD to Dev-AnimPhys-Minimal (//UE4/Dev-AnimPhys-Minimal)
Adding the ProxyLOD code to AnimPhys.
Change 3796059 by Thomas.Sarkanen
Persona viewport settings are now per-asset editor
This prevnets bone following (etc) being shared by all Persona asset editors
FOV & view type is no longer chared by all Persona asset editors
#jira UE-53005 - Viewport settings like bone following are shared between all animation sub-editors
[CL 3806814 by Marc Audy in Main branch]
#lockdown Nick.Penwarden
#rb JeanMichel.Dignard
============================
MAJOR FEATURES & CHANGES
============================
Change 3770717 by Simon.Tourangeau
Fix Blank Enterprise template project creation
Change 3773186 by Simon.Tourangeau
Fix asset migration to correctly handle the migration of content from Content Plugins
Change 3773230 by JeanLuc.Corenthin
Adding new material asset for CAD importer
Removing old material assets for CAD importer
Change 3774391 by JeanMichel.Dignard
Added support for IES asymmetrical light profile
- IES textures are now 2D (256*256) and the shader will use the light tangent to sample the texture.
- Point light tangent is now the Z axis to match the spot lights. Tube shaped point lights will be automatically rotated to compensate for this change. Dynamically generated point lights with a source length will need to have a 90 degrees pitch added to their orientation.
#jira UEENT-55
Change 3775668 by JeanMichel.Dignard
Fixed linux and mac editor builds. Use FVector::DotProduct instead of Dot3 since we're using FVectors.
Change 3781147 by Jamie.Dale
[Python] Prevent the Xcode version of Python being used by default
Change 3781991 by JeanMichel.Dignard
Send the IES texture profile to lightmass in a separate TArray to fix warning 6262 about using too much stack during static analysis.
Change 3783479 by Simon.Tourangeau
Fix NewProjectWizard crash if starter content was enabled
#jira UEENT-635
Change 3784279 by Jamie.Dale
[Python] Added ScopedEditorTransaction and an editor specific module
Change 3787566 by JeanLuc.Corenthin
Fixed issue with display of units which were not reflecting the project settings when enbling unit display.
Got Jamie Dale to help me find the correct solution to this problem: a lambda function.
Thanks, Jamie!
Change 3788178 by Martin.Sevigny
Make sure that FLightPropagationVolume is properly initialized before using it. Can currently trigger a check in FProjectedShadowInfo::SetupWholeSceneProjection because of an uninitialized BoundingBox if LPVIntensity is saved at 0.
Solves: https://udn.unrealengine.com/questions/354040/switching-gi-lpvs-at-runtime.html
Change 3788301 by JeanLuc.Corenthin
On behalf of Anousack:
UE assets necessary to properly handle Cropped procedural textures.
#jira UEENT-522
Change 3789146 by Martin.Sevigny
Bringing back the LPVIntensity test as per MarcusW review.
Change 3789467 by Patrick.Boutot
Add Analytics to PythonScriptPlugin.
Change 3789473 by Patrick.Boutot
Add a slow task dialog when executing a Python script.
Change 3790809 by Patrick.Boutot
Add GIsRunningUnattendedScript. If true, we are running an editor script that should not prompt any dialog modal. The default value of any model will be used. This is used when running a Blutility or script like Python and we don't want an OK dialog to pop while the script is running. Could be set for commandlet with -RUNNINGUNATTENDEDSCRIPT
Change 3790970 by Patrick.Boutot
Add SavePackages with Dialog version in EditorLoadingAndSavingUtils. Refactor some internal save & checkout function in FileHelpers to prevent dialogs from showing when it was not requested.
Change 3790976 by Patrick.Boutot
Add RenameAssetsWithDialog to AssetTools. All previous implementation now use the WithDialog version.
Allow DeleteObject & DuplicatedAsset to be completed without dialog.
Change 3791597 by Simon.Tourangeau
Fix custom window positions in "windowed mode"
#jira UE-52873
Change 3791633 by Patrick.Boutot
Expose to Blueprint the actor' label and folder path.
Change 3791634 by Patrick.Boutot
Change size of the OutputLog's SuggestionList box.
Change 3791637 by Patrick.Boutot
Make sure the suggestions panel is closed before executing the command. Some command wants to run dialog and the suggestions panel may prevent it from opening.
Change 3791661 by Jamie.Dale
[Python] Fixed a bug where we could return an object of the incorrect type from the cache
This could happen if the same instance pointer actually represented two different things, such as when a struct had a different struct as its first member as both of those have the same address, but reflect two different things.
We now treat the type as significant in the cache, and only return something if it matches both the instance and the type.
#jira UEENT-651
Change 3794968 by Patrick.Boutot
Extend File menu to include Python menu. Save the last 10 scripts executed in the user config.
Change 3795084 by Jamie.Dale
[Python] Added a way to purge all references to a given UObject (or set of UObjects) from any living Python objects
Change 3795324 by Jamie.Dale
[Python] Ensure that Python objects referencing the current world/level are purged when the active world/level is changed
This is needed to avoid a fatal assert about a GC leak
#jira UEENT-658
Change 3796248 by Jamie.Dale
FilterAssetDataWithNoTags no longer implicitly removes localized assets
Change 3773185 by Simon.Tourangeau
Move DatasmithImporter plugin content to a content-only plugin under Engine/Plugins/Enterprise/DatasmithContent
This makes it possible to load content created with the DatasmithImporter without having access to Enterprise plugins.
#jira UEENT-544
Change 3790982 by Patrick.Boutot
Set GIsRunningUnattendedScript to EditorScriptUtilities callable functions.
Load level without a prompt.
Change 3791539 by Jamie.Dale
[Python] Added ScriptName and ScriptNoExport meta-data to allow control over how things are exposed to scripts
ScriptName can be used to override the basic name we use when converting classes, structs, enums, properties, and functions to their Python names. It has been used here to remove all the K2_ and BP_ prefixes, and to remove Kismet and Blueprint from some library names.
ScriptNoExport can be used to prevent a property or function from exporting to Python. It has been used here to prevent exporting some deprecated functions that had names that would conflict if we stripped off the K2_ prefix of some newer functions (there were only a handful of these cases).
Change 3773163 by Patrick.Boutot
Improve ConvertActors implementation. Check if the StaticMesh path is valid and do not use dialog in the case we are converting a Brush to a StaticMesh.
Change 3776401 by Patrick.Boutot
Add function to spawn and destroy an actor in editor mode. Spawn use the Place functionality of the editor, you can spawn from an asset, class, archetype or factory.
Change 3778137 by Patrick.Boutot
Add 2 functions to EditorAssetLibrary. GetPathNameForLoadedAsset, wrapper for UObject.GetPathName(). FindPackageReferencersForAsset similar to AssetRegistry.FindPackageReferencer. It will load the assets and all the referencers to confirm the reference.
EditorAssetLibrary now support full path.
Change 3778139 by Patrick.Boutot
Update example data for EditorScriptingUtilities.
Change 3778768 by Patrick.Boutot
Update EditorScriptingUtilities py file with the new naming convention.
Change 3779291 by Patrick.Boutot
Remove const& on TSubLassOf because Blueprint do not show the Pick tool with it.
Update py script & blueprint to point to the new paths.
Change 3783246 by Patrick.Boutot
After review. Tech art prefer to have a filter that check the class and not have the class pass as argument for GetAllLevelActor.
Fix return type in Blueprint for SpawnActorFromClass.
Change 3789367 by Patrick.Boutot
Gets all TagValues associated with an asset as strings value.
Change 3789438 by Patrick.Boutot
Split EditorLevelLibrary into EditorFilterLibrary. All filter function are now in their own modules.
Change 3789489 by Patrick.Boutot
Update script examples with copyright and with the split from EditorFilterLibrary.
Change 3790980 by Patrick.Boutot
Prevent all dialog modal from showing up when running a Python script via command line.
Change 3790984 by Patrick.Boutot
Fix typo in content_browser.py. Delete asset with the loaded version. Fix double values initialized by float.
[CL 3797855 by Simon Tourangeau in Main branch]
#lockdown Nick.Penwarden
#rb none
#rnx
============================
MAJOR FEATURES & CHANGES
============================
Change 3760710 by Thomas.Sarkanen
Fix crash deleting primitives in PhAT
Crash in tooltip generation for shapes. Tree items still exist in the frame before the tree gets regenerated (as the widget defers their destruction a frame), so they can end up pointing at out of date data.
#jira UE-52404 - Crash deleting bodies
#tests deleted primitives in PhAT
Change 3760798 by Martin.Wilson
Initialize PosesToEvaluate so that we don't get stale data crashes after reinitializing
#Jira UE-52343
Change 3761312 by Martin.Wilson
Fix for infrequent crash on module start up
Change 3761333 by Danny.Bouimad
Fixed the Cable actor test correctly, shouldn't fail on cooked platforms any more!
Change 3761550 by Aaron.McLeran
Engine changes requested by oculus for spatializer interface
Change 3761728 by Martin.Wilson
Fix crash when undoing a change on a skeletal mesh that uses virtual bones
#Jira UE-52475
Change 3762032 by Ethan.Geller
#jira UE-49076 Implement PR for VOIP bug fix on Mac
Change 3762109 by Aaron.McLeran
Enabling bAllowAnyoneToDestroyMe on audio components
Change 3762125 by Aaron.McLeran
Checking in missing file
Change 3762568 by Aaron.McLeran
Fixing ogg vorbis 5.1 channel ordering channel maps in audio mixer
Fix is to create separate 5.1 channel maps for various output channel counts and pull those channel maps if the source file was decoded from vorbis. This pattern is copied from old xaudio2source code which handles 5.1 channel mapping seperately. Alternative solution would be to swizzle vorbis channels during cook, but this would break backward compatibility. We'll consider that solution in the future once we remove the old audio engine code.
Change 3762571 by Aaron.McLeran
Adding multichannel file support.
- Spoofing the multi-channel file importer tool by allowing a single multichannel file to generate data in the same way
- Moved the wave serializer code from audio capture plugin to audio.h/.cpp for general use
Change 3762626 by Aaron.McLeran
Adding ability to automatically tag ambisonics files.
Change 3762627 by Aaron.McLeran
Fixing up source buses to be more useful
- Added pre and post source effect bus sends types.
- Adjusted where in the source generation pipeline distance-based filtering is applied to a source. Source audio is sent to source buses immediately after source effect chain generation and before per-source distance-based filters are applied and distance attenuation.
Change 3762652 by Aaron.McLeran
Fix for device hot swap
Change 3762725 by Ethan.Geller
Fixing multichannel indices so that it matches the multichannel cook
Change 3762738 by Ethan.Geller
Add ambisonics plugin support
Change 3762739 by Ethan.Geller
Updating oculus audio plugin
- Base implementation by Peter Sterling at Oculus
- Ambisonics decoding using Oculus API implemented by Ethan
Change 3763687 by Martin.Wilson
Fix bug in GUID customization that leaves editor in an active transaction + Expose core property set code so other guid customizations can reuse it
#Jira UE-52510
Change 3764412 by Ethan.Geller
Fix the incremental build, pt 2
Change 3764721 by Ethan.Geller
Fix the build, take 3
Change 3764767 by Martin.Wilson
Rebuild array children properties when an item is added. Solves missing item crash if the user immediately tries to set the value of the new item
#Jira UE-52537
Change 3764845 by Aaron.McLeran
Making audio devices call flush after update and before endplay is called to ensure flush is called on audio devices.
Prevents hang on releasing sound wave procedural references in GC.
Change 3766047 by Thomas.Sarkanen
Pinnable command list widget
Added a new "pinnable command list" widget. Shift-clicking a menu option in either the skeleton tree filter or the viewport menus will 'pin' the command outside of the menu. This allows for easier access to commands that are frequently used.
Minor Slate change - added virtual(s) to FUICommandList so commands can be forwarded when executed.
#jira UE-51807 - Add 'quick filter' and visualization toggles UI to PhAT
Change 3766111 by Thomas.Sarkanen
CIS fix
Change 3766273 by Lina.Halper
Rename PostBlendPhysics to FinalizeAnimationUpdate
Change 3768507 by Thomas.Sarkanen
CIS fix
Change 3768637 by James.Golding
Add 'GetSectionFromProceduralMesh' util function
#jira UE-49262
Change 3768649 by Lina.Halper
Moved the automation test to tests folder
#jira:UE-46250
Change 3768675 by Benn.Gallagher
Fixed incorrect deprecated angular velocity accessor.
Change 3768776 by Benn.Gallagher
Fix for skeletal mesh editor crash importing more than 5 LODs
#jira UE-52263
Change 3768804 by Martin.Wilson
Live Link Virtual subjects
Virtuals subjects are created within the client and contain the bones of multiple real subjects
Change 3768874 by Martin.Wilson
UAnimSequenceBase is now entirely exported with ENGINE_API
#Jira UE-48020
Change 3769318 by Lina.Halper
- Animation system owns previous bone transform with revision number, so that it can send to renderer when render recreated.
- Framenumber still exists because clothing system uses it, and I'm planning to talk to Benn about it next week when he comes back
#jira: UEAP-272
Change 3769714 by Lina.Halper
Fix CIS
Change 3770672 by James.Golding
Expose API for changing 'Use CCD' flag at runtime
#jira UE-50332
Change 3770675 by James.Golding
Add test map for 'Set Use CCD' function
Change 3770711 by Thomas.Sarkanen
Multi viewports and bone-locked cameras in animation editor viewports
All animation-related editors now have the ability to open up to 4 seperate viewports onto the same scene, each with their own settings.
Fixed up bounds following to actually work correctly (now follows without lag).
Added the ability to follow (and orbit) a specified bone as well.
#jira UE-47127 - Add the Ability to Open Multiple Viewports on the Same Scene.
#jira UE-49690 - "Camera Follow" in Persona Editor cannot be enabled
Change 3770786 by Lina.Halper
Support curve in copy pose node
#jira: UE-50182
Change 3770943 by James.Golding
Fix 'NODEBUG' option for PVD CONNECT console command (should only send profile data)
Fix from Kier at NVIDIA
#jira UE-52444
Change 3771145 by Benn.Gallagher
Added ability to control whether or not a post process instance runs on a skeletal mesh component. Exposed both to blueprints and anim editor suite
#jira UE-49747
Change 3772262 by Benn.Gallagher
Defaulted the clothing create menu to use the skeletal mesh physics asset
#jira UE-51607
Change 3772389 by Thomas.Sarkanen
Added a keyboard shortcut to toggle between body and constraint selection
Shortcut is Ctrl+T by default.
#jira UE-51804 - Add a quick switch between selected constraints and bodies
Change 3772393 by Thomas.Sarkanen
Constraints are now displayed only once in the physics asset editor tree view
User constraints are still displayed twice, however.
#jira UE-51808 - Constraints in PhAT should only be displayed once in the tree
Change 3772404 by James.Golding
Fix Modify Curve AnimNode not calling CacheBones on source pose
#jira UE-52129
Change 3772418 by Benn.Gallagher
Allowed clothing visualizations to be enabled while clothing paint mode is active.
Fixed crash attempting to visualize backstops when the clothing data has no backstops.
#jira UE-47042
Change 3772964 by Thomas.Sarkanen
Expose sequence recording settings in Persona editors
Added layout extender to Persona module, so external tabs can now be added to all Persona-based editors easily.
Added a structure details view to edit the default animation settings.
Hooked default animation settings up to Persona animation recording.
#jira UE-48416 - Set Frame Rate and Length of Recordings in Persona in Editor
Change 3772967 by Martin.Wilson
Add NativeBeginPlay function to AnimInstance
#jira UE-51351
PR #4135: Add NativeBeginPlay to AnimInstance (Contributed by Vaei)
Change 3772986 by Thomas.Sarkanen
Added "Show Only Selected Constraints" to the physics asset editor
#jira UE-51805 - Add 'show only selected constraints' option to PhAT
Change 3773012 by Benn.Gallagher
Added facility to debug skel mesh component to extend the viewport text seen in skeletal mesh editor and added lines for current cloth value
#jira UE-42354
Change 3773132 by Martin.Wilson
Added Uncheck all unconnected pins for BreakStruct nodes
#jira UE-51136
PR #4110: Uncheck all unconnected pins from BreakStruct node... (Contributed by projectgheist)
Change 3773158 by Benn.Gallagher
Added auto-range feature to cloth view ranges, and a way for tools to extend those ranges when necessary
#jira UE-48109
Change 3773895 by Jurre.deBaare
Move material baking out of experimental
#fix Removed experimental settings gating around Material Baking functionality
#jira UE-52685
Change 3773898 by Jurre.deBaare
Change log message wording when Simplygon fails to initialise to ensure it does not block CIS (error triggers a CIS error and will halt the build)
Change 3773899 by Jurre.deBaare
Add keybind for switching between paint / erase color while mesh painting
#fix Added new command for switching fore and background colors in the mesh painter (defaults to X as shortcut)
#jira UE-52197
Change 3773900 by Jurre.deBaare
Hotkey to enable and disable post processing in the preview scene settings
#fix Added hotkey and command for toggling Post Processing in Preview Scenes
#jira UE-48111
Change 3773933 by Martin.Wilson
Add missing file (for live link monolithic build failure)
Change 3773949 by Jurre.deBaare
Right click add selected to HLOD cluster / create cluster
#fix Partially implemented the request, added context menu to HLOD level nodes in the HLOD outliner treeview to allow creating a new cluster from the current level viewport selection
#jira UE-48334
Change 3773950 by Jurre.deBaare
HLOD cluster drawing should not use AHLODSelectionActor but regular in-viewport drawing
#fix removed old behaviour using a spawned actor to represent a selected HLOD cluster, and replaced it will simple debug drawing (this is a lot less bug prone and much cleaner)
#jira UE-49094
Change 3773964 by James.Golding
Mark FBodyInstance::ResponseToChannels_DEPRECATED as 'WITH_EDITORONLY_DATA'
#jira UE-52545
Change 3773978 by Thomas.Sarkanen
Allow edits to physics sim options to be undone/redone
Added RF_Transactional to the object
#jira UE-48046 - Undo/redo does not work in Physics Asset Editor's Physics/Details menu
Change 3773982 by Martin.Wilson
Add pre and post conversion callbacks to root motion conversion in character movement component
#jira UE-51966
Change 3773988 by Thomas.Sarkanen
Duplicating CL 3773896 from Fortnite:
Push non-rendered anim updates back onto the worker thread
Now when meshes are set to EMeshComponentUpdateFlag::AlwaysTickPose, we optionally kick of a task to perform parallel update only (no evaluation).
#jira UE-46710 - Animation updates run on the main thread when Evaluation task doesnt run
Change 3773999 by Martin.Wilson
Fix incorrect merge
Change 3774030 by Thomas.Sarkanen
Renamed "Create Joints" to "Create Constraints"
#jira UE-50861 - New Physics Asset window reads "Joints" instead of "Constraint"
Change 3774031 by Thomas.Sarkanen
Fixed typo in comment
#jira UE-50841 - Typo in Vertex Weighting Type setting when creating new Physics Asset
Change 3774200 by Lina.Halper
Fix crash with empty element in the constraint setup
#jira: UE-52686
Change 3774236 by Ori.Cohen
Fix crash when destructible component doesn't mark its killed actors as IgnoreActiveActors
#jira UE-52320
Change 3774284 by James.Golding
Fix constructor order CIS error in AudioMicerSubmix.cpp
Change 3774511 by James.Golding
Fix up removed RevisionNumber param
Change 3774724 by Lina.Halper
Fix of motion blur change of previous bone transform
Change 3775493 by Thomas.Sarkanen
Duplicating CL 3775488 from Fortnite:
Prevented skeletal meshes that are not being ticked due to URO from dispatching tick tasks
#jira FORT-61157 - Run anim update on worker, even if not visible
Change 3775508 by James.Golding
Fix compilation without PhysX, move DeferredReleaseCallback outside WITH_PHYSX block
Change 3775538 by James.Golding
Fix Mac CIS due to missing virtual destructor in IDeferredReleaseCallback
Change 3775921 by Ori.Cohen
Better fix for destructible crash (also fix CIS)
#jira UE-52762
Change 3776054 by Benn.Gallagher
Fixed crash deleting max distance mask from a clothing data entry.
#jira UE-52723
Change 3776063 by Thomas.Sarkanen
Fix static analysis warning
Change 3776331 by Jurre.deBaare
Hierarchical LOD Outliner scrollbar doesn't appear
#fix removed AutoHeight from parent vertical box around HLOD outliner details view
#jira UE-52756
Change 3776704 by Martin.Wilson
Fix array properties not always refreshing when new items are added
#UE-52760
Change 3776755 by Thomas.Sarkanen
Duplicating CL 3776656 from Fortnite:
Fix notifies not getting fired in cases where AlwaysTickPose was set on skeletal mesh components
This was causing AIs to get stuck in montage playback in some circumstances
#jira FORT-61324, FORT-60558
Change 3777385 by Aaron.McLeran
#jira UE-52786 Fix for broken spatialization on xaudio2, old audio engine.
Change 3778233 by Lina.Halper
Removed android from oculus audio platform
Change 3778714 by Ethan.Geller
#jira UE-52818 remove Android from Oculus Audio platforms
Change 3779004 by Lina.Halper
Include "Features/IModularFeatures.h" to cpp
Fix build error
Change 3780324 by Thomas.Sarkanen
Duplicating CL 3778679 from Fortnite-Main:
Fix 100% Linux server crash - dont attempt to run threaded work in a single-threaded environment
We dont attempt to run animation update work multi-threaded in the same conditions that we didnt attempt to run animation eval work previously.
#jira FORT-61548
Change 3763999 by Ethan.Geller
remove space from ambisonics mixer name, fix build
Change 3774470 by James.Golding
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ 3774039
[CL 3780967 by Thomas Sarkanen in Main branch]
#lockdown Nick.Penwarden
#rb none
#rnx
============================
MAJOR FEATURES & CHANGES
============================
Change 3722141 by Aaron.McLeran
#jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager.
- Will allow for sequencer recorder to record multiple audio streams, one for each actor
Change 3726096 by Ori.Cohen
Fixed welded bodies with negative scale not using the mirrored convex hull
#jira UE-51647
Change 3726233 by Ori.Cohen
Make sure RT doesn't try to create a physics mesh when debug drawing
#jira UE-51721
Change 3726254 by Aaron.McLeran
Fixing typo in GetCustomSpatializationSettingsClass interface
Change 3728295 by Ori.Cohen
Fix incorrect lock upgrading
Change 3728516 by Benn.Gallagher
Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints.
#jira UE-51414
Change 3728522 by Benn.Gallagher
Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes.
#jira UE-50087
Change 3728853 by Benn.Gallagher
[NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat.
Change 3729031 by Ethan.Geller
#jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation.
Change 3729910 by Benn.Gallagher
Fix for crashes editing destructible meshes caused by stale render data
Change 3729921 by James.Golding
- Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead
- Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets
- Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well
- Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors
- Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors
- Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh
- Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport
#jira UEAP-167
Change 3730054 by Martin.Wilson
Live Link: Add ability for sources to define their own settings
Change 3730134 by Jurre.deBaare
Editor crashes when opening animcompression setting on an alembic file
#jira UE-51840
#fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import
#misc cleaned up comment
Change 3730428 by Thomas.Sarkanen
Fix copy/paste in the physics asset editor
When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations.
Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling.
Also allow multi-paste of constraints/bodies.
#jira UE-51803 - Copy/paste doesn't work correctly in PhAT
Change 3730464 by Thomas.Sarkanen
Fixed copy/paste not working when the skeleton tree has focus
The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected.
#jira UE-51803 - Copy/paste doesn't work correctly in PhAT
Change 3730511 by Jurre.deBaare
Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313]
#jira UE-48988
Change 3730685 by Benn.Gallagher
Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered.
#jira UE-51508
Change 3731560 by Aaron.McLeran
Removing gaurd on spatialization plugin settings and renaming enumerations
Change 3731714 by Ori.Cohen
Added the ability to profile scene query hitches.
Change 3731725 by Ori.Cohen
Change scene query hitch threshold to 50us by default
Change 3731770 by Ethan.Geller
Fix signed/unsigned comparison.
Change 3731777 by Ethan.Geller
Suppress static analysis warning.
Change 3732145 by Thomas.Sarkanen
[Duplicated from 4.18.1]
Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB
Also fixed a selection issue that was exposed when this crash was fixed,
#jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate
Change 3732176 by Thomas.Sarkanen
Fixed hang when selecting all bodies or constraints in a physics asset
Implements a better fix for CL 3721129
#jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset
Change 3732177 by Thomas.Sarkanen
Fix crash when pasting properties in Physics Asset Editor
Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range.
#jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies
Change 3732492 by Martin.Wilson
Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging
#Jira UE-51794
Change 3732672 by Thomas.Sarkanen
Refactor view menus in animation editors
Moves show menu and buffer visualizations into a new CommonMenuExtensions module.
Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name.
All character-specific stuff is now in a "Character" menu.
Original changes by Jonathan.Poncelet
#jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports
Change 3732860 by Thomas.Sarkanen
Fix CIS errors/warnings
Change 3732877 by Thomas.Sarkanen
Fix missing Physics menu
Merge error on my part
Change 3733113 by Ori.Cohen
Fix CIS
Change 3734859 by Thomas.Sarkanen
Fix crash when opening a physics asset that uses a preview mesh with no skeleton
#jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81]
Change 3736693 by Ethan.Geller
Added ability for submixes to define their own channel format. Written by aaron.mcleran
Change 3737943 by James.Golding
Fix crash when right-clicking during section selection in skel mesh tools
#jira UE-51873
Change 3738337 by Benn.Gallagher
Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices.
#jira UE-51921
Change 3738404 by Lina.Halper
Add comment for bImportBoneTrack option in FBX importer
Change 3738816 by Benn.Gallagher
Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren)
Change 3738960 by Ethan.Geller
Fix Linux compiler errors for implicit enum casting
Change 3739214 by Lina.Halper
- Removed unnecessary Initialize
- Make sure invalidate the other part if not used (socket->bone or bone->socket)
#jira: UE-51931
Change 3739215 by Lina.Halper
compile error
- added one more ) when pasted to the other line
Change 3739442 by Lina.Halper
pose asset crash when skeleton changes
#jira: UE-52036
Change 3739795 by Ethan.Geller
fix linux build with implicit enum class casts, pt 2
Change 3740553 by James.Golding
Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint
#jira UE-47566
Change 3740560 by James.Golding
- Don't rebuild render data on SkeletalMesh interactive property changes
- Remove unnecessary render resource release in SkeletalMesh PreEditChange
#jira UE-51652
Change 3740562 by James.Golding
Extensibility improvements to PhysicsAssets (from NVIDIA)
Change 3740563 by James.Golding
PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster)
#jira UE-50546
Change 3740564 by James.Golding
PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc)
#jira UE-51761
Change 3740587 by Benn.Gallagher
CIS fixes for non-cloth platforms and initialization order fix
Change 3740658 by Thomas.Sarkanen
Update cloth appropriately in the physics asset editor
When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation.
Reset simulation when making more 'major' potential changes (adding/removing collision etc.)
Optionally reset cloth when simulation starts/stops in the physics asset editor
#jira UE-50949 - Phat Editor with cloth collisions
#jira UE-48779 - Ability to reset clothing during physics simulation
#jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth
Change 3743354 by Benn.Gallagher
CIS Fix
Change 3743419 by Thomas.Sarkanen
Preview buttons are now present where applicable
Preview mesh button reordered to be consistent with other anim editors.
Preview animation re-instated where applicable.
Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout
#jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons
Change 3743529 by Thomas.Sarkanen
Moved constraint and physical anim profile indicators to the top of the details panel
Indicators now show assignment status.
#jira UE-50895 - Constraint Profiles requests
Change 3743604 by Jurre.deBaare
Duplicating from 4.18.1:
[CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951]
#fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well
#jira UE-51917
Change 3743757 by Lina.Halper
Adding more ensure to detect NaN
Change 3743791 by Ori.Cohen
Fix CIS and stack size issues
Change 3744008 by Benn.Gallagher
Gravity override support for clothing interactor.
#jira UE-51014
Change 3744439 by Michael.Karambelas
Updating and investigating CableActor automation tests
Change 3744566 by Martin.Wilson
Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded.
#jira UE-49335
Change 3745963 by Martin.Wilson
Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time
#Jira UE-52044
Change 3748585 by Aaron.McLeran
Fixing crash when loading editor with synth components.
Change 3749071 by Aaron.McLeran
Fixing ambisonics submix format
Change 3749969 by Danny.Bouimad
Updating TM-AnimPhys to be more performant on Switch
Change 3750103 by Danny.Bouimad
Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052)
Change 3754465 by Ethan.Geller
Fixing panning in audio mixer after submix format feature
Change 3755637 by Lina.Halper
Back out changelist 3739214
- still add back invalidation
#jira: UE-52159
Change 3756385 by Lina.Halper
- Adding ground truth for the cable component test map
- Disabled first test as it has BP none access warning
#jira: UE-52370
Change 3756707 by Ethan.Geller
fix potential mem leak in mixer source
Change 3757148 by Aaron.McLeran
Fixing surround sound bugs due to recent changes to submix format.
Change 3757583 by Aaron.McLeran
Fix cook with synth component
Change 3758477 by Danny.Bouimad
Fixing Disabled cable actor test, checking in screenshots for a disabled test.
Change 3758873 by Ethan.Geller
#jira UE-52389 Remove assert on getting a hash for a unique net id.
[CL 3759284 by Marc Audy in Main branch]
#lockdown Nick.Penwarden
#rb none
Change 3720210 on 2017/10/25 by Olaf.Piesche
Fixing dynamic material params for ribbons
#!codereview scott.kennedy
#!rb none
#!tests scott's test ribbon
Change 3720073 on 2017/10/25 by robomerge
#!ROBOMERGE-AUTHOR: frank.fella
Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it.
#!Tests Minion automated tests no longer crash randomly.
#!rb SimonT
#!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3719233 on 2017/10/25 by robomerge
#!ROBOMERGE-AUTHOR: philip.buuck
[OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead).
#!rb Matt.Schembari
#!tests PIE
[QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death
#!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3718474 on 2017/10/25 by Yannick.Lange
Niagara: Only show isolate menu items on track context menu if it is a system.
Rename "Isolate toggle" to "Isolated".
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3718095 on 2017/10/25 by Yannick.Lange
Niagara: Fix crash when not having dynamic parameter in material.
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3718069 on 2017/10/25 by Yannick.Lange
Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression.
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3717545 on 2017/10/24 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Removed read / write locks from PipelineStateCache.
#!rb Andrew.Grant, Gil.Gribb
#!test paragon ps4.
#!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3716928 on 2017/10/24 by Shaun.Kime
The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime.
#!rb olaf.piesche, simon.tovey
#!fyi olaf.piesche, simon.tovey, frank.fella
#!tests am now able to run Test_minionWave on PS4
Change 3715712 on 2017/10/24 by Yannick.Lange
Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf".
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3715430 on 2017/10/23 by Shaun.Kime
Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it.
#!rb none
#!fyi simon.tovey
#!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime
Change 3715368 on 2017/10/23 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main)
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3715226 on 2017/10/23 by Shaun.Kime
Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's.
#!rb none
#!fyi simon.tovey, olaf.piesche, frank.fella
#!tests ran in PIE
Change 3714645 on 2017/10/23 by Yannick.Lange
Niagara: Add ability to create particle system from this emitter in content browser.
#!rb Shaun.Kime
#!tests n/a
Change 3714200 on 2017/10/23 by Olaf.Piesche
Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target
#!codereview simon
#!rb none
#!tests Orion Niagara assets
Change 3713341 on 2017/10/23 by Yannick.Lange
Niagara: Fix NiagaraNodeIF output pins cannot be deleted.
Fix NiagaraNodeIF output pins cannot be renamed.
#!jira UE-50193
#!jira UE-50193
#!rb Shaun.Kime
#!tests n/a
Change 3713133 on 2017/10/23 by Yannick.Lange
Niagara: Isolate emitters in sequencer UI.
- Added being able to extend the sequencer track context menu with a delegate.
- Added entry in track context menu to toggle the selected emitters isolation state.
- Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters.
#!rb Shaun.Kime
#!tests n/a
Change 3712445 on 2017/10/22 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
UVScale, UniformAorBFloat, and LinearColorAlongVector added.
#!rb none
#!tests new autotest added
#!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3712420 on 2017/10/21 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1.
#!rb none
[CODEREVIEW] frank.fella
[FYI] simon.tovey, olaf.piesche, wyeth.johnson
#!tests created an emitter, disabled Acceleration Force.. still compiled.
#!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711602 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like:
LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData
#!jira UE-51511
#!rb Simon.Tovey
#!tests n/a
#!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711288 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: eric.ketchum
[Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work
#!rb: None
#!tests: PIE
[CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime
#!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711197 on 2017/10/20 by Olaf.Piesche
Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly
#!rb none
#!tests minion projectile ribbon trail
Change 3710634 on 2017/10/20 by Mic.Rooney
Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing.
#!RB: none
#!Test: tested/built locally ran preflight Editor/Monolithics build.
#!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen
Change 3709686 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Added some more timerguards for slow timer manager tick objects.
Commented out for now.
#!rb Trivial
#!test Paragon Cooked ps4.
#!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3708958 on 2017/10/19 by Shaun.Kime
Back out changelist 3708456 .. this was an unintentional change
#!rb none
#!tests n/a
Change 3708839 on 2017/10/19 by Shaun.Kime
Merging CL 3708835
Fixing Scott's common crash with adding an emitter with autocompile off
#!rb frank.fella
#!tests n/a
Change 3708784 on 2017/10/19 by Shaun.Kime
Merging CL 3708782
//Orion/Main/... to //Orion/DevGeneral/...
#!rb none
#!tests n/a
Change 3708600 on 2017/10/19 by robomerge
#!ROBOMERGE-AUTHOR: mieszko.zielinski
Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion
#!rb none
#!test golden path
#!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3708473 on 2017/10/19 by Shaun.Kime
Merging Frank's changes for team color support from Main to Dev-General
#!rb Frank.Fella
#!tests test_minionwave worked
Change 3708456 on 2017/10/19 by Shaun.Kime
Particles.Random set to 0.0
#!rb none
#!tests n/a
Change 3708455 on 2017/10/19 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests passed minion fx autotest
Change 3707648 on 2017/10/19 by Shaun.Kime
Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made.
Defer deletion of dataset to RT.
Ensure resets don't mess with data inflight RT commands are using.
Checkin on behalf of Simon Tovey
#!jira OR-45423
#!rb Simon.Tovey
#!tests ran through the LaneMinionFXTests successfully on PC
Change 3707096 on 2017/10/19 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago.
#!rb none
#!tests automated tests pass
#!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3706726 on 2017/10/19 by Rob.Cannaday
Merge XMPP resource version to use version 2 instead of version 3
#!rb trivial
#!tests compile
#!ROBOMERGE: Main, 44, Tencent
Change 3706349 on 2017/10/19 by Josh.Markiewicz
#!UE4 - Cross Voice code review feedback
- fixed up broken stack vs queue
- fixed GetRoomId returning int32 instead of uint64
- fixed switch room logic
- more/better logging
- more comments
#!jira TEN-301
#!review-3681404 @sam.zamani, @rob.cannaday
#!rb none
#!tests local cheat codes
Change 3705453 on 2017/10/18 by robomerge
#!ROBOMERGE-AUTHOR: arne.schober
Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array)
#!RB Daniel.Wright
#!Tests LaunchOnPs4
#!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3705399 on 2017/10/18 by robomerge
#!ROBOMERGE-AUTHOR: scott.kennedy
Default Niagara emitter changed color property to better default value.
Updated basic glow emitter
Added energy bubble base emitter
put a little more polish into siege minion impact FX.
#!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3704426 on 2017/10/18 by Shaun.Kime
Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423
#!rb simon.tovey
#!fyi hunter.kent
#!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure
Change 3703288 on 2017/10/18 by Olaf.Piesche
Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash
#!rb olaf.piesche, simon.tovey
#!tests minion test map PC and PS4
Change 3701373 on 2017/10/17 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader.
#!rb Olaf.Piesche
#!tests test_minionwave runs
#!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3701108 on 2017/10/17 by Hunter.Kent
Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily.
#!RNX
#!Test PS4
#!rb @tim.elek
#!review-3701110 @andrew.grant, @daniel.lamb
Change 3701044 on 2017/10/17 by robomerge
#!ROBOMERGE-AUTHOR: jon.lietz
- white space fixes
- added in more detail to logging
- fixed dragon GC to not hide when the mesh is hidden
#!rb none
#!tests complies and logging is updated
[FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen
#!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3700900 on 2017/10/17 by Shaun.Kime
Integrating possible crash fix from Dev-Niagara to Dev-Gen
#!rb none
#!tests n/a
#!fyi Olaf.Piesche
Change 3700492 on 2017/10/17 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests done in branch
Change 3700217 on 2017/10/17 by Olaf.Piesche
Fix for potential crash in sprite renderer
#!rb none
#!tests minion test map
Change 3700216 on 2017/10/17 by Benn.Gallagher
Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master.
#!rb Lina.Halper
#!jira OR-45226
#!tests PIE + Standalone games hitting Rampage with Ghosts E
Change 3699660 on 2017/10/17 by Jason.Bestimt
#!ORION_DG - Fixes to UnrealHitchParser edge cases
#!RB:none
#!Tests: Ran on Logs from QA
#!CodeReview: ben.salem
Change 3699462 on 2017/10/17 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!tests preflight ok
#!rb none
Change 3699010 on 2017/10/17 by Jeff.Williams
Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920
#!rb none
#!tests none
Change 3698519 on 2017/10/16 by Olaf.Piesche
Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts
#!rb none
#!tests minion wave test map
Change 3698380 on 2017/10/16 by Shaun.Kime
Updating logic to now support the autoattachment
#!rb none
#!tests autotests pass..
Change 3698263 on 2017/10/16 by Olaf.Piesche
Assume degrees for sprite rotation
#!rb none
#!codereview shaun.kime
#!tests test sprite emitter
Change 3697652 on 2017/10/16 by Olaf.Piesche
Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion
#!rb none
#!tests minion test map
Change 3696906 on 2017/10/15 by Shaun.Kime
Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers.
#!rb none
#!tests now no longer generates invalid errors
#!fyi frank.fella, olaf.piesche, simon.tovey
Change 3695456 on 2017/10/13 by Olaf.Piesche
Fix for potential ribbon crash and end-of-ribbon rendering artifacts
#!rb none
#!codereview scott.kennedy
#!tests minion wave test map
Change 3694545 on 2017/10/13 by Andrew.Grant
Fix for low frequency async loading crash (OR-42535)
#!rb gil.gribb
#!tests comppiled
Change 3694176 on 2017/10/13 by Jeff.Williams
Plugin manifest name changed to DLCFile name
#!rb none
#!tests compile, stage
Change 3693582 on 2017/10/12 by Don.Eubanks
Fixing PS4 Compile warning (constructor init order not matching member define order)
#!rb none
#!tests Compile Shipping Client PS4
#!fyi olaf.piesche
Change 3693516 on 2017/10/12 by Olaf.Piesche
Niagara: Remove mesh renderer assert, replace with early out
#!rb none
#!tests niagara mesh test asset
Merging
//Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp
to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp
Change 3693051 on 2017/10/12 by Ben.Salem
Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log.
#!rb Clayton.Langford
#!tests Parsed a 5mb log with dumphitches down to 23k of hitch data.
Change 3692912 on 2017/10/12 by Olaf.Piesche
Merging: Niagara ribbon tiling distance
#!rb none
#!tests ribbon test asset
Change 3692835 on 2017/10/12 by Shaun.Kime
Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags.
#!rb none
#!fyi scott.kennedy, wyeth.johnson
#!tests n/a
Change 3692751 on 2017/10/12 by Shaun.Kime
Removing script that shouldn't have come over.
#!rb none
#!tests n/a
Change 3692746 on 2017/10/12 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests opened test level and created new emitter/system
Change 3692616 on 2017/10/12 by Don.Eubanks
OR-45131
Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking.
#!rb dan.hertzka
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
#!codereview nick.darnell
Change 3691912 on 2017/10/12 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none
#!tests compile, editor
#!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3690944 on 2017/10/11 by Jeff.Williams
Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC.
#!rb Daniel.Lamb
#!tests Compile, build
Change 3688989 on 2017/10/10 by Lina.Halper
LOD sync of attached/parent
#!rb: Laurent.Delayen
#!tests: price with shotgun skin/PIE/editor
Change 3687592 on 2017/10/09 by Ben.Salem
Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test.
#!rb clayton.langford
#!tests Ran sparrow shallow tests.
Change 3686560 on 2017/10/09 by Shaun.Kime
Flipping the min/max values to be standard
#!rb none
#!tests n/a
Change 3686046 on 2017/10/09 by Shaun.Kime
Merging latest from Dev-Niagara in preparation for Effects team work on Monday
#!rb none
#!tests successful preflight
#!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek
Change 3685613 on 2017/10/07 by robomerge
#!ROBOMERGE-AUTHOR: simon.tovey
Implementing vector field matrix inverse fix from CL3675167 to 43.3.
#!rb none
#!tests none
#!lockdown andrew.grant
#!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685603 on 2017/10/07 by robomerge
#!ROBOMERGE-AUTHOR: thomas.ross
RotationalContent Improvements
- Fixed potential bug where tags could be updated when not intended on RotationalContentManager
- Fix for PIE assert
- Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option.
- Removing config tag from RotationalContentOverrides in OrionGlobals.
New Halloween Gauntlet Test
- Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box.
#!rb none
#!tests local builds / editor / PIE
#!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685408 on 2017/10/07 by ben.salem
Fixing robomerge error in DevGen
#!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams
Unresolved conflicts. ben.salem, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml
--------------------------------------
Merging using DevGen->Release43.3
Repairing mailer for nightly Perf tests, fixing email headers.
#!tests run in devgen
#!rb none
#!lockdown andrew.grant
#!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685073 on 2017/10/06 by Andrew.Grant
Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3684717 on 2017/10/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue where GT & RT times in profile info were reversed :(
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3684512 on 2017/10/06 by Laurent.Delayen
Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code.
#!rb lina.halper
#!tests minion AnimBP nativization
Change 3684059 on 2017/10/06 by Max.Preussner
Orion: Fixed ability videos not loading on PS4 and/or not looping
#!fyi stephan.jiang
#!jira OR-44682
#!rb none
#!rnx
#!tests none
Change 3683538 on 2017/10/06 by David.Ratti
batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions.
-Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players.
-Fixes case where killing minions with badass was not displaying pops (prediction key issue)
#!rb none
#!tests editor, pie
#!review-3683539 @Matt.Schembari
Change 3683364 on 2017/10/06 by Andrew.Grant
Changed warning to info
#!tests #!rb na
Change 3681999 on 2017/10/05 by Bart.Hawthorne
Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion.
#!rb cody.haskell
#!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore
#!jira OR-44111
#!tests Golden path, live spectated numerous matches.
Change 3681403 on 2017/10/04 by Josh.Markiewicz
#!UE4 - base pass for Tencent Cross SDK
- basic testing done with enter/exit/switch room
- basic testing of ShowUI
- checked in disabled
#!rb duck
#!tests see above
#!jira TEN-301
#!review-3681404 @sam.zamani, @rob.cannaday
Change 3680623 on 2017/10/04 by David.Ratti
Rework for how max movement speed is calculated.
The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow.
Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored.
Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow.
GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc).
Suggested methods for inspection:
AbilitySystem debug hud (Home/End)
p.VisualizeMovement (displays final calculated movement speed)
Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar)
Technical information:
1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool.
2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows.
3. Added a notification for attribute sets when an aggregator is created for one of their attributes.
4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod)
5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension.
#!tests pie
#!rb FrankG
#!codereview Fred.Kimberley, Billy.Bramer
#!fyi colin.fogle
#!QAReview
#!RN
#!designchange
Change 3680580 on 2017/10/04 by Ben.Salem
Repair email titles for various reports.
#!rb none
#!tests Reran tests.
Change 3680438 on 2017/10/04 by Dan.Hertzka
GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect
- Fixes the HUD status effect feed not showing sources for a lot of itemization abilities
Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip
#!rb Dave.Ratti
#!tests OrionEntry PIE - equipped Sand Speeder
#!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on
Change 3680344 on 2017/10/04 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Speculative disable of defragging on volumetric lightmap textures.
#!rb andrew.grant
#!test monolith2 ps4
#!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3680302 on 2017/10/04 by Shaun.Kime
Integration from DevNiagara.
Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array.
#!rb none
#!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek
#!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass.
Change 3679946 on 2017/10/04 by Laurent.Delayen
Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches.
#!rb lina.halper
#!FYI andrew.grant
#!tests monolith2 old minions
Change 3679938 on 2017/10/04 by Daniel.Lamb
Allowed foliage cullall option to be modified by scalability options.
#!rb Trivial
#!test Compile paragon editor
Change 3679563 on 2017/10/04 by Jon.Lietz
OR-43599
- added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it.
#!rb Dave.Ratti
#!review-3679564 @John.Nielson
#!tests added these waits to hot pursuit and they worked as expected
Change 3679006 on 2017/10/03 by Ben.Salem
Try to fix broken nightly mailer issues for FX tests.
#!rb none
#!tests Preflighted a shallow fx pass successfully in EC.
Change 3677845 on 2017/10/03 by Andrew.Grant
Added an ensure to guard against OR-44826 while further investigations occur
#!tests compiled
#!rb none
Change 3677443 on 2017/10/03 by John.Nielson
Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase.
Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify).
#!RB: None
#!Test: Pie, Uncooked
#!review-3677445: @David.Ratti
Change 3676748 on 2017/10/02 by Laurent.Delayen
Minions: split body layer is now done in mesh space, to maintain upper body orientation.
#!FYI ray.arnett, lina.halper
#!rb none
#!test lane minion test map
Change 3675950 on 2017/10/02 by Don.Eubanks
Added several new supported tags / status effects to the Floating Status Effect Text system.
Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player.
Added ScaleOverDistance curve support for floating numbers / text.
Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out.
#!rb matt.schembari
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4
Change 3675186 on 2017/10/02 by Mic.Rooney
Support for other anim curve driving audio types (right now specifically DialogueWave)
#!RB: none
#!Test: compiled editor/monolithics/withoutunity and tested locally.
#!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen
Change 3675167 on 2017/10/02 by Shaun.Kime
Changed unsafe InverseFast() to an Inverse()
#!jira OR-44671
#!rb Simon.Tovey
#!tests n/a
Change 3674888 on 2017/10/02 by David.Ratti
GGP V2
* Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration.
Item System:
* Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords.
* Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup).
Ability System:
* SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE)
#!rb none
#!tests editor pie cooked
#!review-3674889 @Jon.Lietz
Change 3674170 on 2017/09/30 by Mieszko.Zielinski
Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion
Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load.
#!rb none
#!test golden path
#!OR-44738
Change 3672937 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files
#!tests 3compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672867 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Restored previous behaviour of integer numbers being formatted as "1" and not "1.00"
#!tests ran game, checked playlist analytic
#!rb nikdel
#!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672575 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
Remove warning that can happens normally with backwards compat replays
#!rb none
#!tests compile
#!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672548 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned.
#!rb Andrew.Grant
#!test Editor building hlods
#!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672542 on 2017/09/29 by Andrew.Grant
Merging
#!rb #!tests na
Change 3672390 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed memreport settings for frontend tests
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672385 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Reworked and pretty much final PipelineState cache code
- various comments incorporated
- namespaced functions
- removed redundant class and replaced with ref pointer
#!tests soaked a lot
[at daniel.lamb,] [at arne.schober] #!rb none
#!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672281 on 2017/09/29 by Rob.Cannaday
Add user ID to OnNetworkCheatDetected
#!jira TEN-272
#!jira TEN-273
#!jira TEN-274
#!rb rob.cannaday
#!tests Win64 AI match, simulate cheat detected by cheat command
#!review-3672282 @ian.fox @sam.zamani
Change 3671688 on 2017/09/29 by Frank.Gigliotti
Added ability to set developer comment when adding native tags.
#!RB David.Ratti
#!Tests None
Change 3670409 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for dump type made while doing cleanup
#!tests compiled Win64, PS4, ran PS4
#!rb none
#!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3670399 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed race condition in pipeline state cache
Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon
(Couple of extra tweaks planned, but this should be GTG for a v43 release)
#!rb codereviewed
#!tests soaked locally, lots
#!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669802 on 2017/09/28 by Andrew.Grant
From Dev-Framework
#!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed
#!rb michael.noland
#!codereview andrew.grant
#!tests na
Change 3669709 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669177 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Reflection Captures support Lighting Scenarios without recapturing
* Reflection Captures are now part of the Map Build
* Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message)
* Reflection Capture build data moved to the BuildData package
* Building lighting / reflection captures no longer dirties ULevels
* Sky lights which capture the scene now work correctly with Lighting Scenarios
* Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded)
#!rb Marcus.Wassmer
#!TESTS Paragon editor Monolith02
#!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669124 on 2017/09/28 by Daniel.Lamb
Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush
to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush
Fix cook in devgeneral
Bumped shader version to invalidate stale uniform buffer name.
#!rb none
#!TESTS none
#!fyi Daniel.Wright
Change 3667906 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting.
#!rb none
#!TESTS QAGame
#!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667899 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Remove unused SM4 reflection capture cubemap
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667894 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy from Brian] SM4 fallback for reflection captures.
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667859 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy from Brian] Removed old rasterized deferred reflection env path.
Removed reflection compute shader. Replaced with PS. Small perf gain.
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667852 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Fixed missing include
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667807 on 2017/09/27 by Daniel.Lamb
Tencent DLC can now remap the plugin content to the game root directory.
#!rb Ben.Marsh
#!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test
Change 3667753 on 2017/09/27 by Clayton.Langford
Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer.
#!RB Ben.Salem, Adric.Worley
#!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat
Change 3667408 on 2017/09/27 by Jordan.Walker
Optimization to bakedNormal layer blend on Low end material quality
-uses simple multiply and add normal map blend
Change 3667388 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times.
#!rb none
#!TESTS QAGame on console
#!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667383 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame.
#!rb none
#!TESTS QAGame
#!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667265 on 2017/09/27 by Daniel.Lamb
Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned.
#!rb Uriel.Doyon
#!test Editor building hlods
Change 3667159 on 2017/09/27 by Mieszko.Zielinski
Added simple logging to BT loading allowing us to identify missing BB keys #!Orion
#!test golden path
#!rb Lukasz.Furman
Change 3665944 on 2017/09/26 by Dan.Hertzka
Fix PS4 compile
#!rb none
#!tests compile PS4
Change 3665590 on 2017/09/26 by Daniel.Lamb
Fix for DLC cooking everything when it should only cook the DLC.
#!rb None
#!test None
Change 3665569 on 2017/09/26 by Dan.Hertzka
New status effect feed for the new HUD:
- Now placed in the mid-upper-left side of the HUD
- Biggest difference from before is that there are now names associated with each effect
- If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet.
Cleaning:
- Deleted all of the old buff widget classes & codepaths
- Removed redundant properties from StatusEffectDisplayInfo
- Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData
Also:
- Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events
- Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed)
@todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.)
#!rb Don.Eubanks
#!tests OrionEntry PIE with some cards and hero abilities
#!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial.
#!lockdown Billy.Rivers
Change 3665555 on 2017/09/26 by Daniel.Lamb
AudioStreaming mpsc queue fix up.
#!rb Andrew.Grant
#!test Compile paragon client / editor.
Change 3665517 on 2017/09/26 by Daniel.Lamb
Suspect fix for OR-44619
#!jira OR-44619
#!test Paragon editor compile
#!rb Trivial
Change 3664346 on 2017/09/26 by Jon.Lietz
- making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out.
- Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired.
- Updated all GC's data to use the new decal class
- removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent
#!rb Dave.Ratti
#!reivew Dave.Ratti
#!tests used characters that had decal comps in the GC and they recylce as expected.
#!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed.
Change 3664099 on 2017/09/26 by Jon.Lietz
OR-44510
- bringing over engine fixes for the Enum Redirector from Dev-Framework
#!rb none
#!tests compiles and warnings are gone
Change 3663019 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Gil: fixed race condition in the PipelineStateCache
#!rb Daniel.Lamb
#!test paragon ps4 with higher repro modified build
#!lockdown Andrew.Grant
#!jira OR-44441
#!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3663014 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready.
#!tests ran locally
#!rb [at daniel.lamb] [at arne.schober]
#!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3663004 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed dev check for extra commandline args from /data to /temp0
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3662999 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - Fixed DateTime used for folders not being set
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3662255 on 2017/09/25 by Sam.Zamani
#!tencent
- fix for link error due to missing define of static OnNetworkCheatDetected delegate
#!rb none
#!tests none
Change 3662073 on 2017/09/25 by Sam.Zamani
#!tencent
Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server
Possible options
#!jira TEN-275 TSS detect and expose punish user callbacks
KickClient - User should be booted from the current game session via disconnect
KickMatch - User received info about being punished (eg. ban type etc)
PunishInfo - User received info about being punished (eg. ban type etc)
#!rb rob.cannaday
#!tests none
Change 3659487 on 2017/09/22 by Josh.Markiewicz
#!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin
#!review-3659190 john.barrett, ryan.gerleve
Change 3659485 on 2017/09/22 by Josh.Markiewicz
#!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins
#!fyi john.barrett, ryan.gerleve
Change 3659184 on 2017/09/22 by Josh.Markiewicz
#!UE4 - delete EpicSurvey module
#!fyi justin.sargent, nick.darnell
#!rb none
Change 3658697 on 2017/09/22 by Ryan.Gerleve
Fixes for server-side Tencent anti-cheat library integration:
-Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows
-Add getter for the TssSdkAntiInterf object
-Enable server anti-cheat in editor builds
#!codereview sam.zamani
#!rb none
#!tests enabled Tencent OSS, built & ran server
Change 3658200 on 2017/09/22 by Graeme.Thornton
Manual copy of CL 3587584 from Dev-Core
Logging improvements for pak signature check failures
- Added "PakCorrupt" console command which corrupts the master signature table
- Added some extra log information about which block failed
- Re-hash the master signature table and to make sure that it hasn't changed since startup
- Moved the ensure around so that some extra logging messages can make it out before the ensure is hit
- Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again
#!rb none
#!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General
Change 3657970 on 2017/09/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition.
We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game,
[at marcus.wassmer,] [at arne.schober] #!rb none
#!tests cycled 6-7 levels of Paragon
#!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657914 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing...
#!tests stepped through in non-pkg build
#!rb none
#!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657906 on 2017/09/21 by Andrew.Grant
Improved some logging
#!tests used locally
#!rb none
Change 3657891 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing
Fixed issue with -dev mode on PS4 not updating symbols
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657867 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Re-locked network CL to 3652780
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657857 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444
#!RB:arciel.rekman
#!Tests:Compiled
[CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf
#!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657852 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for case-insensitivity causing title.json not to be staged
#!rb daniel.lamb, bob.tellez
#!tests ran packaging script, verified contents match v42
#!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657831 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors
We can worry about a more permanent solution after we get this live.
#!RB:none
#!Tests: Compiled
[CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer
#!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657824 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe
//ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb
--------------------------------------
Built new UnrealCEFSubprocess client
Changed OrionBuild.xml to build the shipping version of the above.
The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this.
[at justin.sargent,[at benjamin.crocker,[at wes.fudala]]]
#!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657488 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: anton.migulko
LIGHTING AND assets update
#!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3656388 on 2017/09/21 by Laurent.Delayen
Added default GetAxisVector static function to EAxisOption
#!rb none
#!FYI thomas.sarkanen
#!tests lane minions test map
Change 3656387 on 2017/09/21 by Laurent.Delayen
Initialize FAnimInstanceProxy with default constructor.
#!rb none
#!fyi lina.halper, thomas.sarkanen
#!tests lane minion test map
Change 3656003 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3650578 for patching
benjamin.crocker
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3654403 on 2017/09/20 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Merge DevCore -> Orion Release-43 CL 3641450
UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers.
#!rb Daniel.Lamb
#!test Compile
#!lockdown Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3654356 on 2017/09/20 by Andrew.Grant
Merging 3653658 from Dev-Rendering
#!tests compiled, ran editor
#!rb marcus.wassmer
Change 3653914 on 2017/09/20 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access).
#!rb none
#!tests ran locally
#!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3652495 on 2017/09/19 by Andrew.Grant
Editgration of VR fix in 3643776 from Release-4.17
#!tests #!rb na
Change 3652244 on 2017/09/19 by Sam.Zamani
#!tencent
Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher
Added "-q" to whitelist of command line params for shipping builds
Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher
#!rb rob.cannaday
#!tests none
Change 3651493 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651490 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651489 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651445 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag
#!RB:none
#!Tests:none
[CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant
#!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3651059 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed code to archive load-order during tests
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3651043 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed error parsing from tests to put cause ahead of file info
#!tests ran self-test
#!rb none
#!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649683 on 2017/09/18 by Andrew.Grant
Bulk-merge of oustanding changes in Main to DG
#!tests #!rb na
Change 3649345 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Integrate fix for eidtor crash when switching between low and high scaleability options.
#!rb Olaf.Piesche
#!test Paragon editor
#!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649335 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - OR-44257 - Fix for hair not working
It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion.
#!RB:daniel.lamb
#!Tests:Re-tested in cooked build
[CODEREVIEW] daniel.lamb
#!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649231 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM
#!RB:none
#!Tests:none
[CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy
#!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649211 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix 'lowest' shadow settings (simple forward rendering)
#!rb arne.schober
[FYI] Daniel.Wright
#!tests monolith
#!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649141 on 2017/09/18 by Stephan.Jiang
Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source.
-- These are hacks for ability videos to work before we have the new Sequencer updates
-- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748
#!fyi Andrew.Grant, Max.Preussner
#!rb none
#!test compile
Change 3649087 on 2017/09/18 by Thomas.Ross
Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General
#!rb none
#!tests none
#!fyi Andrew.Grant,Jeff.Williams,dan.oconnor
Change 3649066 on 2017/09/18 by Max.Preussner
WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources
#!rb stephan.jiang
#!rnx
#!tests none
Change 3649049 on 2017/09/18 by Max.Preussner
Media: Changed audio sample rate warning to verbose log
#!fyi stephan.jiang
#!rb none
#!rnx
#!tests none
Change 3648752 on 2017/09/18 by Max.Preussner
WmfMedia: Fixed race condition in media sound wave
#!rb none
#!rnx
#!tests none
Change 3648748 on 2017/09/18 by Max.Preussner
WmfMedia: Hack for preventing flicker between media source switching
Do not merge to Dev-Main!
#!rb stephan.jiang
#!rnx
#!tests none
Change 3648596 on 2017/09/18 by Bart.Hawthorne
More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough.
Change 3648575 on 2017/09/18 by Sam.Zamani
#!tencent
Fix for missing library calls when initializing TSS anti cheat SDK
#!rb none
#!tests compiles win64 server
Change 3648556 on 2017/09/18 by Jeff.Williams
Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084
Clearing up robomerge
#!rb none
#!tests none
Change 3648533 on 2017/09/18 by clayton.langford
Unblocking RM.
#!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams
Unresolved conflicts. clayton.langford, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly.
#!RB Adric.Worley
#!tests none
#!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3648219 on 2017/09/18 by Sam.Zamani
#!tencent
fixed Tencent module thirdparty dll runtime dependency paths
fixed DLLHandle not being set
#!rb none
#!tests none
Change 3647998 on 2017/09/18 by Clayton.Langford
Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763.
#!tests compiled
#!rb Adric.Worley
Change 3647817 on 2017/09/18 by James.Golding
Mirror fix from 4.18 release stream (CL 3647799) to Dev-General
Fix out-of-bounds access of cloth mapping data during CPU skinning
#!rb benn.gallagher
#!jira UE-49628
#!fyi benn.gallagher
#!tests convert RiftMage to static mesh
Change 3647749 on 2017/09/18 by Benn.Gallagher
Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope.
This caused matrix transposition to fail after the data was copied in using memcpy
BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs.
#!rb none
#!tests Editor reimport of clothing assets
Change 3646242 on 2017/09/15 by Tyler.Cole
Revert shared engine LocalMCP scripts.
Change 3646153 on 2017/09/15 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds
#!RB:daniel.lamb
#!Tests: Ran cooked Client
[CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy
#!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3646125 on 2017/09/15 by robomerge
#!ROBOMERGE-AUTHOR: arne.schober
OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews.
#!RB Marcus.Wassmer
#!tests automated performance tests
#!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3645861 on 2017/09/15 by clayton.langford
#!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams
Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW.
Unresolved conflicts. clayton.langford, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added.
To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards
Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated.
#!tests ran local client/server, preflighted
#!rb Ben.Salem
#!rnx
[FYI] Sean.Tobin, Hunter.Kent, Edward.King
#!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3644062 on 2017/09/14 by Aaron.McLeran
#!jira OR-44171 Some looping sounds are extremely loud
#!rb Ethan.Geller
#!tests run paragon, run near water river, don't observe looping sound being very loud
Change 3643901 on 2017/09/14 by Laurent.Delayen
Integrated CL #!3604725 to fix bug with opening state machines from anim graph.
#!rb none
#!tests fixes bug
#!FYI lina.halper
Change 3643641 on 2017/09/14 by Rob.Cannaday
Fix unreachable code detected
#!rb rob.cannaday
#!tests Win64 compile
Change 3643326 on 2017/09/14 by Sam.Zamani
#!tencent
- temp disabled TerSafe.dll loading until staging issues can be resolved
#!rb none
#!tests none
Change 3643039 on 2017/09/14 by Sam.Zamani
#!tencent
- temp disabled TSS on servers due to linux build issues
#!rb none
#!tests none
Change 3642438 on 2017/09/13 by Rob.Cannaday
Handle new analytics param types (number, string, etc)
Stub implementation of FAnalyticsProviderETTencent DefaultAttrs
#!rb rob.cannaday
#!tests Win64 vs AI match
Change 3641655 on 2017/09/13 by Sam.Zamani
#!tencent
WIP added tss_sdk.dll (server) and TerSafe.dll (client)
JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client
JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers
#!rb none
#!tests PC run with RegionCN.pak enabling tencent mode
Change 3641559 on 2017/09/13 by Bart.Hawthorne
Fix up oodle dictionary generation scripts
#!rb none
#!jira none
Change 3641550 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43
#!rb: none
#!test: Pie
#!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3641393 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev.
Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled
- Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false)
- Added PGOInput option to TargetRules and passed through to compile environment
- Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for
- Updated PS4 toolchain to use both LTO and PGO depending on what was set
#!tests soaked locally, preflighted
#!rb codereviewed
FWIW here are before/after results for LTCG.
Orion Performance report from 3 games and 1441.51 seconds
MVP: 2.83 (Min: 2.05, Max: 3.22)
HPM: 4.29 (Min: 4.24, Max: 4.37)
AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms)
GT: 12.88ms (Min: 12.68ms, Max: 13.25ms)
RT: 13.71ms (Min: 13.48ms, Max: 14.08ms)
GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms)
Orion Performance report from 3 games and 1440.49 seconds
MVP: 1.42 (Min: 1.02, Max: 1.94)
HPM: 3.25 (Min: 2.75, Max: 3.62)
AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms)
GT: 11.93ms (Min: 11.64ms, Max: 12.47ms)
RT: 12.80ms (Min: 12.54ms, Max: 13.24ms)
GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms)
#!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640885 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Limited warning to once every 10 secs.
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640875 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed shipping config issue
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640870 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: mieszko.zielinski
Fixing CIS builds #!Orion
The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors.
[CODEREVIEW] John.Nielson
#!rb none
#!test compilation
#!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640783 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
More temporary logging for finding the missing FX issue.
#!rb: none
#!Test: Pie
#!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639910 on 2017/09/12 by Rob.Cannaday
Build fix for AnalyticsETTencent
#!rb rob.cannaday
#!tests compile Win64 DebugGame Editor
Change 3639565 on 2017/09/12 by Laurent.Delayen
SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0.
#!rb lina.halper
#!FYI lina.halper
#!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime.
Change 3639228 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Tools - Added ability to postmortem a PS4 devkit for last crash
#!rb run locally
#!tests none
#!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639075 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Specifically requesting 'all' configuration, to avoid missing manifest in jar.
#!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639022 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: dan.hertzka
Remove dependency on the editor style set in the WidgetReflector
- Fixes a crash when trying to use the reflector in a client cooked build
- Also updated Focusable column name to shared var
#!rb none
#!tests Widget Reflected in a cooked build
#!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638984 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43
#!rb: none
#!test: Pie
#!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638696 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Swapped problematic ensure to LogError, made draft obey notimeouts.
#!tests compiled
#!rb none
[at daniel.lamb]
#!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638644 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Third time's the charm
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638628 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed ensure in a PS4 friendly way
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638583 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed ensure to get a cook
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638545 on 2017/09/12 by Bart.Hawthorne
Add analytics for oodle compression percentages
#!rb ryan.gerleve, wes.hunt
#!tests ran a 2 person game with dedicated server and verified analytics were reported
#!jira OR-26386
Change 3638172 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Duplicate 3620803
Partial Fix for Dither Opacity Mask
#!rb none
#!tests PC monolith
#!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637643 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Fixing version stream to Main
#!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637524 on 2017/09/11 by Andrew.Grant
Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating
#!tests build Win64 editor, ran tests locally
#!rb none
Change 3637402 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - Restored logging of runoptions when not verbose
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637357 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Made 'none' test specify Attended
#!rb Daniel.Lamb
#!tests compiled
#!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637305 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added temporary debug logging cmd line option for finding Jira OrionOR-43600
#!RB: none
#!Test: Pie
[at David.Ratti]
#!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636549 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues
#!RB:none
#!Tests:none
[CODEREVIEW] uriel.doyon
#!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636507 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: dan.hertzka
[OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG.
Also:
- Added distance formatting type for simple ability description values (will automatically append u to the value)
- SimpleAbility description values can now go up to two decimal places
Engine:
- Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName
#!rb Matt.Schembari
#!tests PIE OrionEntry & FrontEndScene - various bug repros
#!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636372 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Implement fast particle pool memory.
Default is 2mb, automatically cleans up oldest used pool slots.
Estimated 1/4 time for STAT_PARTALLOC.
#!rb Jason.Bestimt
#!test paragon ps4 cooked
#!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636319 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue with fatal error message not being shown in reports.
Fixed issue where some cancelled tests reported as succeeded
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636264 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance
#!RB:none
#!Tests: Ran client cooked build
[CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon
[QAREVIEW]
#!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635288 on 2017/09/10 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices
Fixed missing - in SoloSmoke args that were causing trailing params to be lost
#!tests preflighted, ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635145 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Bumped script version to pick up SDK change for patch packages
#!rb none
#!tests none
#!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635097 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added cleardevices option to Gauntlet that removes all devices after running.
Added to Orion build scripts
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634985 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Cleaned up some logging around device failures
Attempt to handle "Too Many Connections" error at a lower level
Added removeall command to PS4DevkitUtil (not yet used)
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634897 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Checking in change to timeouts to test theory
#!tests ran test locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634765 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Scrape another .05ms out of GPU particle simulation.
#!rb none
#!tests ps4 monolith
#!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634422 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for Gauntlet shutdown issue on builders
Fix for BP editing crash from Dev-Framework
#!tests ran locally
#!rb none!
#!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634139 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running
#!tests ran locally with single and file-based devices
#!rb none
#!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633799 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only.
#!rb none
#!tests monolith02 turrets
[CODEREVIEW] lina.halper
#!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633647 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Possible fix for OR-43926 from Arne
#!tests ran locally, observed no ensures or negative side-effects in UI or HUD
#!rb none
#!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633637 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Upped timeout for editorbased tests
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632565 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed some test code...
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632385 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
More improvements to device handling.
Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems.
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632177 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: thomas.ross
Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43
#!rb none
#!test local commandlet
#!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632131 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix a bug with new local vector-field only project setting
#!rb none
#!tests ps4 monolith
#!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632034 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue where problem devices were reset each attempt
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631812 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
More improvements to device management in Gauntlet
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631787 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes.
#!rb none
[CODEREVIEW] martin.wilson
#!test bot game
#!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631251 on 2017/09/07 by Andrew.Grant
Additional device selection improvements
#!tests #!rb na
Change 3630861 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3630620 on 2017/09/07 by Laurent.Delayen
RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions.
#!rb Ori.Cohen
#!codereview benn.gallagher
#!tests lane minions test map
Change 3629990 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fix for gpu hang on ps4.
#!rb Marcus.Wassmer
#!test Paragon cooked ps4
#!jira OR-43835
#!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629980 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Moved some missed code to FDebug::HasAsserted()
#!tests na
#!rb none
#!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629975 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Project optimization to only support local vector fields.
separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost.
#!rb olaf.piesche
#!tests monolith ps4/pc
#!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629917 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix for sizebyspeed on ps4
#!rb Simon.Tovey
#!tests pc
#!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629620 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629554 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Restored screenshot support to gauntlet (now driven externally)
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629495 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: don.eubanks
Stat panel will only show stat changes or improvements that come from Item sources (cards / gems)
#!rb dan.hertzka
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
[RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base!
#!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629468 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring()
Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread.
#!tests ran locally
#!rb none
[at marcus.wassmer]
#!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629410 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs
--------------------------------------
Fix for generating project files
#!tests GPF
#!rb none
#!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629369 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests)
#!rb none
#!tests verified signing is disabled and game gets to main menu with -fileopenlog
[at graeme.thornton]
#!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629254 on 2017/09/06 by Laurent.Delayen
URO: ensure we don't skip more frames than desired when switching LODs.
#!rb lina.halper
#!codereview martin.wilson, benn.gallagher
#!test lane minions test map
Change 3629191 on 2017/09/06 by Laurent.Delayen
Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions.
#!rb lina.halper
#!codereview martin.wilson
#!test lane minions test map
Change 3629130 on 2017/09/06 by Laurent.Delayen
AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug.
#!rb none
#!tests lane minion test map
Change 3628300 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed exception that could occur during tests if all devices were in use
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627915 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Undoing Oodle check for the time being
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627875 on 2017/09/06 by Jason.Bestimt
#!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables)
#!RB:none
#!Tests:none
#!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker
#!ROBOMERGE: MAIN, 43
Change 3627694 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Improved warnings
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627642 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
More logging for OR-43892 and OR-43779
#!rb none
#!tests compile
#!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627247 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed check that turns out to be bogus
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627240 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures
#!tests compiled OrionClient
[at daniel.lamb] #!rb none
#!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627211 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added ensure for OR-43777
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626839 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added wait to PS4DevkitUtil before trying to postmortem crashdump
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626755 on 2017/09/05 by Rob.Cannaday
Merge //Orion/Release-Tencent to //Orion/Dev-General
Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT
TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded
#!rb sam.zamani
#!lockdown andrew.grant
#!tests Win64 vs AI match, QA smoke test
#!fyi sam.zamani
Change 3626285 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed BaseDir argument not being correctly applied in tests
Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626221 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame.
Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement
#!rb none
#!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz
[at Laurent.Delayen] [FYI] [at Andrew.Grant]
#!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3625925 on 2017/09/05 by Laurent.Delayen
If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want.
#!rb benn.gallagher
#!codereview martin.wilson, lina.halper
#!tests lane minion map
Change 3624051 on 2017/09/02 by Andrew.Grant
Fixed issue with test params not being set.
Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability.
#!tests preflighted
#!rb none
#!review-3624052 @ben.salem
Change 3623907 on 2017/09/02 by Andrew.Grant
Fixed usesyncedbuild option being broken in Gauntlet
#!codereview @daniel.lamb
#!tests compiled
#!rb none
Change 3623906 on 2017/09/02 by David.Ratti
Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides
#!rb none
#!test future wukong pie
Change 3623766 on 2017/09/01 by Daniel.Wright
[Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box
#!rb none
#!Tests PC QAGame
Change 3623518 on 2017/09/01 by Don.Eubanks
Fix for Shipping Client PS4
#!rb none
#!tests Compile Shipping Client PS4
#!fyi daniel.lamb andrew.grant
Change 3623515 on 2017/09/01 by Daniel.Wright
[Copy] Volume materials applied to static meshes operate on the object's bounding sphere
#!rb none
#!TESTS QAGame PC
Change 3623503 on 2017/09/01 by Daniel.Wright
[Copy] Fixed ObjectRadius in Volume domain materials
#!rb none
#!TESTS none
Change 3623102 on 2017/09/01 by Marcus.Wassmer
Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand
#!rb none
#!tests monolith on PS4
#!fyi olaf.piesche,tim.elek
Change 3623096 on 2017/09/01 by Marcus.Wassmer
checkslow -> check to find issues with ILC
#!rb none
#!tests ran monolith on ps4
Change 3622744 on 2017/09/01 by Laurent.Delayen
RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now).
Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies.
Take gravity from movement component if present, to inherit custom gravity scaling.
Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used.
If LOD enables new bodies, they are now initialized during simulation.
Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default.
Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change.
Added AnimStats for PreUpdate, Update and Eval.
#!rb ori.cohen
#!codereview ori.cohen, lina.halper, benn.ghallager
#!tests lane minion test map
Change 3622743 on 2017/09/01 by Laurent.Delayen
Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes.
#!rb lina.halper
#!tests lane minion test map
Change 3622742 on 2017/09/01 by Laurent.Delayen
'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings.
Renamed DisplayDebugCustom to DisplayDebugInstance.
#!rb lina.halper
#!tests lane minion test map
Change 3622738 on 2017/09/01 by Laurent.Delayen
Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams
#!rb lina.halper
#!tests lane minion test map
Change 3622666 on 2017/09/01 by Jian.Ru
Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements
#!jira UE-48972, OR-43455
#!rb Chris.Bunner
#!tests editor
Change 3622579 on 2017/09/01 by Andrew.Grant
Fixed shutdown issues with some tests being detected as errors
Simplied and cleanup some things in state management of tests.
#!tests ShortSOloGame test locally
#!rb none
Change 3622322 on 2017/09/01 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for OR-40366 from v43
#!tests compiled
#!rb Aaron.McLeran
#!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3621054 on 2017/08/31 by Andrew.Grant
Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating
#!tests preflighted
#!rb none
Change 3620755 on 2017/08/31 by Daniel.Lamb
Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations.
#!rb Jason.Bestimt
#!test Cooked paragon ps4
Change 3620541 on 2017/08/31 by Ben.Salem
Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting.
#!rb none
#!tests compiled.
Change 3620443 on 2017/08/31 by Mieszko.Zielinski
Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4
#!rb none
#!test golden path
Change 3620428 on 2017/08/31 by Aaron.McLeran
#!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General
#!rb Ethan.Geller
#!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports.
Change 3620411 on 2017/08/31 by Mieszko.Zielinski
Fix to removal of simuli sources from the AISense_Sight #!UE4
Made sure given source gets removed from ObservedTargets.
#!rb none
#!test golden path
Change 3620343 on 2017/08/31 by Ben.Salem
Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on.
#!rb clayton.langford
#!tests ran shallow and normal FX tests, generated hitches to display.
Change 3620050 on 2017/08/31 by Luke.Thatcher
[ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/...
- USE_DEFRAG_ALLOCATOR was not always defined in all cases.
#!rb Daniel.Lamb
#!tests none
Change 3619836 on 2017/08/31 by Andrew.Grant
Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team)
#!tests preflighted, ran locally
#!rb none
Change 3618597 on 2017/08/30 by Dan.Hertzka
Fixed Additive UI materials not being affected by the widget opacity
- We needed to multiply the sampled color by the alpha of the vertex color
Also added fade in anim for scoreboard when showing after the endgame cinematic
#!rb Nick.Darnell
#!tests Widget alpha affects additive materials
Change 3618441 on 2017/08/30 by Laurent.Delayen
Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display.
#!rb lina.halper
#!tests lane minions
Change 3618404 on 2017/08/30 by Paul.Moore
- Update to new MMS client API from Fortnite.
- Add MMS API plugin.
#!rb none
#!tests matchmaking, v2 MMS matchmaking, draft lobby.
#!lockdown andrew.grant
Change 3618167 on 2017/08/30 by Marcus.Wassmer
Fix fog on PS4, also volume texture clears.
#!rb luke.thatcher
#!fyi Jordan.Walker
#!tests ran monolith on ps4
Change 3617911 on 2017/08/30 by Andrew.Grant
Fix for OR-43401, lighting remaining unbuilt
#!tests ran cook, verified that lighting for bp components is now correctly found.
#!rb marc.audy
Change 3617765 on 2017/08/30 by Andrew.Grant
Fix for lighting always being unbuilt on some blueprints
#!tests cooked data and verified BP components have the correct transform and receive cached lighting data
#!rb marc.audy, bp-team
Change 3617757 on 2017/08/30 by Laurent.Delayen
clang fix
#!rb none
#!tests none
Change 3617700 on 2017/08/30 by Laurent.Delayen
Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated.
#!rb lina.halper
#!tests lane minions map
Change 3617695 on 2017/08/30 by Laurent.Delayen
Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays.
#!rb lina.halper
#!tests test lane minions map
Change 3616757 on 2017/08/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for OR-43459 from Laurent
#!tests na
#!rb Lina.Halper, Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3616745 on 2017/08/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3609966 in anticipation of patch
#!rb #!tests na
#!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3616551 on 2017/08/29 by Daniel.Lamb
Fix memory leak in paragon.
#!rb Andrew.Grant
#!test Paragon ps4
Change 3613700 on 2017/08/28 by Andrew.Grant
Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion
Renabled r.Cache.UpdatePrimsTaskEnabled
#!tests ran locally
#!rb none
Change 3613694 on 2017/08/28 by Andrew.Grant
Added -teamsize argument to Orion none test.
#!tests ran None test :)
#!rb none
Change 3613638 on 2017/08/28 by Ben.Salem
Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created.
#!rb clayton.langford
#!tests Ran shallow and deep test for multiple characters.
Change 3612731 on 2017/08/28 by Chris.Bunner
[DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook.
#!rb
#!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb
#!tests Cooking/running simple scene with grass foliage
#!jira UE-48698, OR-42612
Change 3612695 on 2017/08/28 by Andrew.Grant
Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading
Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things.
#!tests ran NoneTest with -nomcp
#!rb none
Change 3612002 on 2017/08/27 by Andrew.Grant
Fix for crash seen during nightly tests
#!tests baseline perf didn't crast 3/3
#!rb none
Change 3611980 on 2017/08/27 by Andrew.Grant
PS4DevkitUtil post-mortem improvements to logging
#!tests run ShortSoloGame
#!rb none
Change 3611758 on 2017/08/26 by Andrew.Grant
Fix for warning
#!tests #!rb na
Change 3611737 on 2017/08/26 by Andrew.Grant
Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering
3517039 -
GitHub #!2655: Optimization for shadow map resolution selection for spot lights
* Use the radius of the inscribed sphere at the cone end as the spot light's screen radius
Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly
3545241 -
Fixed spotlight whole scene shadows using a radius 2x too long
3545347 -
Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame.
#!rb none
#!tests compiled
Change 3611718 on 2017/08/26 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs
--------------------------------------
Improved parsing of callstacks and errors in test logs
Added unit test for error parsing
#!tests ran locally, unit tests
#!rb none
#!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3611704 on 2017/08/26 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Test fixes - addresses issue with memory report failing
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3611683 on 2017/08/26 by Andrew.Grant
Upgraded PS4 SDK to 4.508.111
#!tests SoloGames locally
#!rb none
Change 3611466 on 2017/08/25 by Andrew.Grant
Changed none test to use monolith02 by default
#!tests compiled
#!rb none
Change 3611167 on 2017/08/25 by Laurent.Delayen
Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated.
#!rb none
#!tests lane minions
#!codereview martin.wilson
Change 3610850 on 2017/08/25 by dan.hertzka
Unclog Robomerge
#!rb none
#!tests none
Change 3610325 on 2017/08/25 by Andrew.Grant
Compile fix for PS4
#!tests compiled
#!rb none
Change 3610018 on 2017/08/25 by Laurent.Delayen
UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later.
#!rb lina.halper
#!tests venus ult on minion lane test map
Change 3609967 on 2017/08/25 by Daniel.Lamb
Merging using //Fortnite/Main/->//Orion/Dev-General/
Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4.
CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping.
- The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out.
- Added an extra flag to reset mip bias values when texture memory budget is increased.
#!rb Uriel.Doyon
#!jira FORT-45385
#!jira FORT-47739
CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4.
- Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled.
- Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted.
- Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps.
#!jira FORT-45229
#!rb Ben.Woodhouse
CL 3564368
LLM Changes
Summary:
LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead.
Changes where LLM hooks into the various allocation functions and pools.
Added more LLM tracking scopes.
Changed the way LLM gets its internal memory.
Writing stats out to csv
Fixed a few bugs with the tracker code
Details:
* re-enabled LLM by default in Dev builds for XB1 and PS4
* Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update)
* track allocations made from the defrag pool (PS4)
* track non-drfrag pool garlic allocations (PS4)
* track allocations made from PS4 malloc
* combined the RHI and Malloc trackers into the Default tracker
* changed stat groups to LLM, LLMPlatform and LLMOverhead
* OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set
* XMemAlloc now uses AllocationType if no LLM scope has been set
* renamed VirtualMap to LLMMap
* added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled.
* support for tracking allocations that move in memory (for the PS4 defrag allocator)
* support for tracking explicit memory without pausing the tracker
* LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg
* fixed check in FNameToTag. It was checking the wrong value when verifying the name index
* show a warning on screen if LLM has been enabled without debug memory enabled (on consoles)
* fixed program size tracking
* fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope.
* optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times)
* fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them.
* fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled
* changed default alloc size for LLMMap to 16K
* Added lots more LLM scopes renamed some of the existing ones
* made FMemBlock::Allocators private and added accessor functions, which include LLM tracking.
* fixed LLM alignment tracking in CustomVirtualAlloc
* implemented LLM on XB1 so that it properly tracks D3D12Allocations
* added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator
* tracking of render targets
* fixed LLM pool total column value.
#!rb luke.thatcher
CL 3565905
[ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/...
3458941 - Initial submission of new PS4 memory allocator.
3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible.
3498440 - Flexible and framebuffer memory fallbacks
3515704 - Add stats to new PS4 memory system.
UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly.
#!rb Ben.Woodhouse
CL 3580934
[FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo.
- Neo has 512 MB more direct memory than a base kit.
- Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB.
#!rb Marcus.Wassmer
#!jira FORT-50206
CL 3590180
[FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted.
- Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB.
- Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool.
- Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails.
#!jira FORT-49700
#!rb Aaron.McLeran
CL 3593920
[FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system.
- Incorrect bitmask usage was truncating the available memory value to 32 bits.
- Also includes some minor refactoring to make parts more readable.
- Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile.
#!rb Jonathan.Fitzpatrick
#!jira FORT-50918
CL 3597577
[FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU.
- Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack.
- With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is.
#!rb Stewart.Lynch
#!jira FORT-50825
#!jira FORT-49688
#!jira FORT-49695
#!jira FORT-50054
CL 3601951
[FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system
- Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0.
- Added garlic, onion and defrag stats to the platform memory stats struct.
- Added fixed pool sizes to platform memory stats.
- Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools.
#!rb Stewart.Lynch
#!jira FORT-52910
#!test preflight with baseline performance memory report tests, local tests on neo
#!rb Luke.Thatcher
Change 3608480 on 2017/08/24 by Uriel.Doyon
Instanced static mesh lightmaps are now updated correctly after lighting scenario changes
#!jira UE-48522
#!tests Build lighting, loaded maps
#!rb michel.dupuis
Change 3608407 on 2017/08/24 by Andrew.Grant
Reintegrated ROlando's cloth optimizations
#!tests #!rb none
Change 3608349 on 2017/08/24 by Rolando.Caloca
O - Cloth vertex buffers no longer generate dummy vertices
#!rb Lina.Halper
#!fyi James.Golding
#!tests Check obj list memory with multiple characters, tested animations
Change 3607815 on 2017/08/24 by Laurent.Delayen
Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha.
https://jira.it.epicgames.net/browse/OR-43186
#!rb none
#!tests Price hand two bone IK
#!codereview lina.halper, thomas.sarkanen
Change 3607770 on 2017/08/24 by Andrew.Grant
Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong
#!tests ran locally, updated parser test
#!rb none
Change 3607546 on 2017/08/24 by Jian.Ru
Add more control to chromatic aberration effect
#!jira UE-47138
#!rb Brian.Karis
#!tests editor
Change 3607270 on 2017/08/24 by Andrew.Grant
Mirroring 3605735 from FN to address bug with MIC deduplication
#!tests compiled
#!rb none
Change 3607082 on 2017/08/24 by Laurent.Delayen
Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands.
List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph).
Current debug Target is highlighted in a green bounding box.
Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player.
Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors.
Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation.
#!rb dave.ratti
#!tests lane minion test map, debugging individual minions
#!codereview jon.lietz
Change 3606772 on 2017/08/24 by David.Ratti
Spot edigrate CL 3606417 for accurate CurveTable memory tracking
#!rb none
#!tests none
[CL 3748735 by Andrew Grant in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3624599 by Thomas.Sarkanen
Added the ability to rename shapes in the Physics Asset Editor
Added "CanRenameItem" to skeleton tree item API so we are not limited to hard-coded bones/sockets
Tweaked physics shape item widget to use editable text in the same vein as virtual bones etc.
#jira UEAP-341 - Ability to name collision shapes
Change 3624765 by Benn.Gallagher
Fixed bad blend profile references
#jira UE-46227
Change 3624773 by Danny.Bouimad
Content fix for #Jira UE-49191
Change 3625007 by Thomas.Sarkanen
Fixed monolithinc game builds
Moved new Name member to WITH_EDITORONLY_DATA, as the generated code still picks it up using WITH_EDITOR
Change 3625659 by Ori.Cohen
Make sure that components being unwelded are always unwelded even if they are about to be deleted. This is needed for fixing dangling pointers.
Change 3625850 by Thomas.Sarkanen
Fix for crash in physics asset editor after garbage collection
Move bone proxies from rooting to FGCObject
Change 3625966 by Lina.Halper
Instead of PinShownByDefault, changed to PinHiddenByDefault
https://github.com/EpicGames/UnrealEngine/pull/3964#3964
#jira: UE-49168
Change 3626020 by Martin.Wilson
Protect against checkSlow when using post process instance without a main instance
#jira UE-49275
Change 3627178 by Aaron.McLeran
#jira UE-49322 Fixing background muting and preview sound
Change 3627179 by Aaron.McLeran
Optimizing active sound by not processing active sounds if they are out of range.
Allowing virtualized sounds to be exempt.
Licensee says they saw a 6x improvement on active sound calculations in audio thread with this change.
Change 3627187 by Aaron.McLeran
Allowing overriding the sample rate of synth components in C++.
Useful for cases where synth component is being used to output media auido or VOIP.
Change 3627563 by Thomas.Sarkanen
Tweaked tooltip so it isnt the same as other menus
#jira UE-47817 - Two Viewport tooltips are the same in Physics Asset Editor
Change 3627580 by James.Golding
PR #3974: UE-49200: Fixed typo in Physics Handle (Contributed by carloshellin)
#jira UE-49264
Change 3627581 by James.Golding
Reduce output verbosity during cooking
#jira UE-47126
Change 3627584 by James.Golding
PR #3954: Upgrade to V-HACD version 2.3 (Contributed by jratcliff63367)
Auto-convex generation now exposes more useful 'max hulls' instead of 'accuracy'
Auto-generation of convex collision is now done async in StaticMesh Editor
#jira UE-49027
Change 3627599 by Martin.Wilson
Make sure raw data debug bone rendering in the animation editors actually shows raw data in the case of additive track layers (used to show source instead)
Change 3627605 by James.Golding
Forgot to remove Box2D from TargetRules.cs (see CL 3555437)
Change 3627627 by Martin.Wilson
Change raw data evaluation so that virtual bone positions are built before interpolation is carried out
#jira UE-42659
Change 3627663 by Martin.Wilson
Fix typo
Change 3627730 by Martin.Wilson
Allow notifies to be trigger on follower animations in a sync group
#jira UE-46770
Change 3627852 by Thomas.Sarkanen
Add warning to "Use Async Scene" property when shown in the physics asset editor, if the project doesn't currently use an async scene.
#jira UE-47964 User is not told to Enable Async Scene in Project Settings when enabling it on a physics asset
Change 3627864 by Lina.Halper
Fix issue where "reset to default" on search box for bone doesn't work
#jira: UE-48874
Change 3627946 by Thomas.Sarkanen
Prevent undo/redo breaking when moving both a constraint and a body at the same time
#jira UE-49344 - Physics Asset Editor: Moving both a body and a constraint causes undo.redo to break for the whole editor
Change 3628091 by Thomas.Sarkanen
Fix dangling lines, poor search focus and graph not refreshing when making new constraints
Found by Nick D in Main.
#jira UE-47812 - Physics Asset Graph wires sometimes get stuck to the window not attached to a node
Change 3628107 by Lina.Halper
Fixed issue where Blendspace 1D can't scale due to the property not exposed
https://udn.unrealengine.com/questions/389958/input-interpolationaxis-to-scale-in-1d-blendspace.html
Change 3628108 by Arciel.Rekman
Update Linux VHACD.
- Also removed arm 32-bit version (the library is editor-only).
Change 3628437 by Michael.Trepka
Updated Mac VHACD libraries and Xcode project
Change 3628667 by Lina.Halper
- Fixed issue of showing combo box multiple times
- Fixed issue of inconsistent combo box width
- Fixed text of pick bone to "select" for more general instruction
- Fixed issue with struct displaying children when pin is enabled
#jira: UE-49295, UE-46496, UE-47427
Change 3629744 by Aaron.McLeran
#jira UE-49383 Fix for source bus loading in sound waves and playing without audio mixer
Change 3629846 by Aaron.McLeran
#jira UE-49390 Required API change to spatialization interface for google
Change 3630322 by Thomas.Sarkanen
Fix right-click not displaying context menu for constraints correctly
Selection logic was lightly broken
#jira UE-49399 - Physics Asset Editor: Right-clicking constraints in the viewport does not bring up the context menu
Change 3630463 by Martin.Wilson
Remove accidently submitted debug code
Change 3630523 by Jurre.deBaare
Paint threshold and fill value and can be set to negative numbers
#fix Added metadata and default values for cloth fill tool
#jira UE-48352
Change 3632009 by Aaron.McLeran
#jira UE-49470 Fix for iOS master volume not getting set
Recent changes to master volume resulted in platforms which don't have a headroom value defined will not get their master volume updated. IOS doesn't have a headroom value set so the master volume is never set and the fade in is never triggered.
Change 3632699 by Thomas.Sarkanen
Fix crash undo-ing primitive regeneration while simullation is in progress & stopping simulation
#jira UE-49283 - Editor crashes if you regenerate and manipulate a phys body, simulate, undo and then exit simulation
Change 3633336 by James.Golding
PR #3978: effect is the noun. affect is the verb (Contributed by cdietschrun)
#jira UE-49324
Change 3634665 by Aaron.McLeran
#jira UE-49538 Fixing param interpolation
Change 3634922 by James.Golding
Static analysis fix (PhysXCookHelper.cpp)
Change 3634926 by James.Golding
Fix HTML5 build (which builds with PhysX, but without APEX)
Change 3636005 by Thomas.Sarkanen
Constraint setup shortcuts are now undo-able
Also fixed body-body collision as you couldnt undo this either.
Added transaction and calls to Modify().
#jira UE-49484 - Shortcut for Swing1Motion (2, and 3) do not change physics asset state dirty.
Change 3636018 by Thomas.Sarkanen
Added back constraint shortcut to PhAT toolbar
#jira UE-48859 - Constraint quick set buttons are missing in the new Physics Asset tool
Change 3636086 by Martin.Wilson
Fix for enabling Live Link plugin in Orion
Change 3638367 by Thomas.Sarkanen
Connection reporting is now more user-freindly in the physics asset editor graph view
Expanded UEdGraphSchema API to allow for more specific feedback when dragging over a graph.
Implemented node & pin feedback for physics asset graphs.
Also fixed alignment of icon for drag feedback as it stretches with multi-line text.
#jira UE-47984 - No node created when dragging off of Constraint node in Physics Asset Graph
Change 3640144 by Aaron.McLeran
#jira UE-49409 Attenuation focus audio tests on TM-AnimPhys on Cooked mac doesn't play any audio
Fixing the recent optimization to not play active sounds in range. Code attempts to check if there's any possibility for a sound to have it's distance affected before trying to prune by max distance.
Change 3640276 by Aaron.McLeran
#jira UE-49606 Project does not cook with actors containing ModularSynth component
Change 3640313 by Aaron.McLeran
#jira UE-49675 Fixing shutdown of audio mixer
- Final queued commands aren't getting pumped during audio mixer shutdown, added a new interface to get a final shutdown callback back to audio mixer device. We can do any cleanup or final shutdown tasks in this callback. Added a call to pump the source manager one last time. For cases of audio mixer running without audio plugins, this won't have much of an effect, but is a good thing to do anyway. For the case of audio plugins, who are depending on paired init and release calls, this is valueable to avoid memory leaks between subsequent PIE sessions.
Change 3640941 by Martin.Wilson
Add editor only animation loading debug data in the hope of diagnosing rare loading crash
#jira UE-49335
Change 3641976 by Ethan.Geller
#jira UE-49675 ensure that we pump both command queues
Change 3642613 by James.Golding
Add NoPhysX sample, for CIS testing compilation without PhysX
Change 3644001 by Aaron.McLeran
#jira UE-49805 looping sounds are, in rare cases, extremely loud
Change 3644124 by Aaron.McLeran
#jira UE-49787 [CrashReport] Mac crash - UE4Editor-AudioEditor.dylib!FSoundCueEditor::DeleteInput()
Adding ensure on returned ptr to avoid crash but keep getting some logging.
Change 3644157 by Aaron.McLeran
Fixing build error
Change 3644163 by Aaron.McLeran
Fixing build error (for real)
Change 3650331 by Aaron.McLeran
#jira UE-49994 SoundMix Fade Time not fading audio properly
Making sure we properly set passive mix modifier states.
Change 3652648 by Aaron.McLeran
#jira UE-49994 SoundMix Fade Time not fading audio properly
Change 3652995 by Aaron.McLeran
#jira UE-50053 Reduce log level of audio mixer debug category
Turning down the log spam level of the underrun category by switching to debug category and reducing level of the debug category.
Change 3653461 by James.Golding
V-HACD updates from JohnR @ NVIDIA (adding new functions for future use)
Change 3654056 by Aaron.McLeran
Fixing an issue with caching node states for editor builds and adding optimization to cache if we should apply interior volumes.
Change 3654579 by Aaron.McLeran
Allow sound submixes and sound classes to be a blueprint type
Made all properties of sound classes BlueprintReadOnly.
Change 3662519 by James.Golding
Merge CL 3575543 from //Fortnite/Main to Dev-AnimPhys
Don't call into UpdateKinematicBones if there are no physx bodies
Change 3664976 by Aaron.McLeran
#jira UE-50175 New Tap Delay Submix Pan parameter does not work in Surround Sound
Change 3665751 by Aaron.McLeran
Adding a simple panner effect
Change 3665851 by Aaron.McLeran
Fixing naming convention for new panner source effect
Change 3666894 by Thomas.Sarkanen
Bone modifications via transform type-in can now be undone
Added RF_Transactional & called Modify()
#jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work
Change 3666919 by Lina.Halper
Fixed equal operator for bonereference to work when not initialized
Change 3668850 by Thomas.Sarkanen
Skeleton tree now no longer allows selection of filtered items
This fixes an issue where filtered-out constraints were being deselected after a select all operation because the tree thought it had no selection (all constraints were filtered).
#jira UE-50200 - Constraint Details do not populate in the Details Panel if the Skeleton tree does not include Constraints
Change 3669028 by James.Golding
Fix CIS error after merge-down
Change 3669053 by James.Golding
Fix bad merge in SynthComponent.cpp
Change 3669273 by Lina.Halper
- delete all tracks option
- allow to opt out on bone track importing
- fixed pose preview for fullbody to select weights that has pose from asset.
Change 3671396 by James.Golding
Fix FSkelMeshComponentLODInfo cleaning up all override resources when it should only have been cleaning up one of them
Change 3671701 by Martin.Wilson
Maya Live Link plugin
- Added UI to Maya
- Display currently streamed subjects
- Allow add and removal of streamed subjects
- Display connection status to editor
- Stream active camera as EditorActiveCamera
- Refactored entire plugin so that streaming has a manager and streaming objects / interfaces
- Reworked editor update hook so that streaming is more robust and facial rigs / leaf bones now correctly update.
Change 3672170 by Lina.Halper
Remove track support for Animation Blueprint Library
Change 3675921 by Ethan.Geller
Rollback invalidated check from copy down
Change 3677606 by Martin.Wilson
Add live link driven component - allows an actor to take its rotation and translation from a live link subject
Change 3678594 by Lina.Halper
Changed API name for clarification
Change 3680913 by Ethan.Geller
#jira UE-50750 fix stuttering on AudioMixer on MacOS
Change 3681127 by Ethan.Geller
#jira UE-50720 Fix invalidated audio clock time when audio device is unplugged on legacy audio engine
Change 3682729 by Ethan.Geller
#jira UE-50832 Fix for null concurrency settings when removing active sounds from a concurrency group. [Dev-AnimPhys]
Change 3633185 by James.Golding
Fix engine not compiling when WITH_PHYSX == 0
PR #3691: 4.16_WITH_PHYSX_optional (Contributed by JacobNelsonGames)
PR #3695: 4.16_PhysXVehicles_WITH_PHYSX_optional (Contributed by JacobNelsonGames)
Change 3637031 by Ethan.Geller
#jira UE-49605 Platform Headroom fix for non-float devices.
Change 3642598 by James.Golding
Change bCompileNvCloth to use same pattern as bCompileAPEX (on by default, disabled on some platforms). This allows game projects to disable it.
Change 3645224 by Martin.Wilson
Fix for rare notify crash.
For speed purposes Notify Queue caches a pointer to the notify, this is memory that is owned by the animation and if it gets garbage collected we have a pointer to invalid memory.
This change caches a pointer to the owner of the notify memory to so we can track its validity.
#jira UE-44869
Change 3668926 by James.Golding
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ 3668712
Change 3674824 by James.Golding
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ 3674368
[CL 3683447 by Thomas Sarkanen in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3536809 by Ben.Marsh
Fixing case of files in "iOS" directory, pt 1.
Change 3536814 by Ben.Marsh
Fixing case of files in "iOS" directory, pt 2.
Change 3596207 by Thomas.Sarkanen
Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250
PhAT Upgrade
#jira UEAP-29 - New PhysicsAsset editor
Changelists from task stream:
Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working.
This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added.
Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Renaming PhAT files to PhysicsAssetEditor
Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Rename PhAT -> PhysicsAssetEditor
Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed up PhAT to Physics Asset Editor
Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Reverted some over-zealous renaming
Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it
Added the ability to hide filter menus to skeleton tree
Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added new physics asset skeleton tree builder
Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Skeleton tree extensions to support physics assets
Only started this work - still much to do
Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Rearranged persona viewport menus
Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed body/constraint modes.
Added graph editor
Added edit mode - moved viewport client code over
Got PhAT skel mesh rendering in viewport
Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Increased hit proxy priority to improve selection
Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Skeleton tree gets bodies & shapes back.
Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport.
Added multi-select to bone proxy customization
Re-tweaked editor layout
Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Selection sync work.
Customization of anim viewport menus.
Context menus for physics asset items, as well as masking of various context menu items via settings.
Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next!
Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
More viewport menu fixups (plus deleting duplicate functionality).
Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early).
Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion.
Cleaned up unused files & code
Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Allow extensibility of viewport menu bars
Slate changes:
Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points.
Allow menu bars to optionally invert-on-hover.
Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used.
Adjusted core styling of menu bar elements.
Other changes:
Adjusted padding for various UI elements to preserve previoud behavior.
Adjusted SAnimViewportToolbar to use the new menu bar builder.
Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar.
Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added extension point to viewport menu bar
Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Getting sim working again
Moved over to using preview instance so we share functionality with Persona editors.
Added time dilation options to persona preview scene.
Removed PhAT specific recording functionality (it is in the viewport now).
Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Recreate physics state on edit, not sim start
This allows velocity to be inherited when simulation is started
Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moving viewport to continually-invalidated one like animation editors
Fixed crash in non-extended viewport toolbars
Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Bodies start off non-expanded
Selection now synced between viewport and graph
Constraint selection in graph not works on the first try
Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added missing icon
Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed shape listing from graph nodes
Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Double click on body node recenters graph
Fixed graph disappearing on right-click
Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Prevented cursor getting swallowed in sim mode
Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed overlapping text
Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Node layout now takes dimensions into account
Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed crash opening Persona editors
Renamed file
Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Tweaks to profiles menu
Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Profiles can now be edited in their own details panel
Existing customizations folded into the new panel
Tweaks to toolbar
Added the ability for the persona details panel to have extra top/bottom content added
Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Add profile control to context menus
Also delete old unused code
Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Toolbar trimmed down & re-ordered
Body/constraint ops moved to context menus
Apply physmat now a context-menu option with an asset picker
Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed extra warning dialog when auto-creating bodies
Changed title of new asset dialog to "auto-create bodies"
Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix "simulate selected"
As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor.
Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type
Fixed up selection so body selection works & tree seleciton is properly synced with viewport
Added recursion guard to selection delegate handlers.
Removed vestigial instance property editing support (no longer needed).
Removed unused old tree support code
Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added constraints to tree
Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix bone proxiies stopping updating after initial viewport selection
Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed up selection issues when creating new bodies
Added constraint context menu
Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moved icons to central location
Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Customized filtering of the skeleton tree
Hide constraints by defualt
Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved).
BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool.
Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen
Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303
Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moved physics sim options to viewport menu (so seleciton changing is not required to change them)
Moved physics-related rendering options to show menu
We no longer switch to sim options when nothing is selected.
During simulation we now disable the details panel
Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered)
Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Small fixes based on feedback:
Exposed Mirror tool to menus
Exposed constraint quick actions to menus
Added edit condition to Position & Velocity strength for physical animation
Fixed up some tooltips & display names
Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Defaulted to constraints as points
Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Request from Nick D:
Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes.
Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets.
Slightly increased point-constraint rendering size and added crosshair cursor to constraints
Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead)
Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed duplicate time dilation (can just use viewport menu!)
Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixup post-merge
Prevent crash by attaching to root component in the correct place
Add IWYU include for TArrayView
Remove more unused code
Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix constraint/body selection one final time
Move constraint drawing to SDPG_World (apart from point mode)
Remove depth offset in material
Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Enabling/disabling collision between bodies is now clearer
Menu items are now enabled and disabled correctly depending on collision state
Tooltip reflects what actually gets done when the operation is enacted
Also corrected a few functions that still reference constraint & body mode
Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added enable/disable collision with all
Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Color code graph items based on current profile
Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Color code tree items too
Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Bone selection & manipulation now possible - allows for pose setup before simulation
Item expansion now expands leaf nodes when selecting - helps with constraint selection etc.
Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix compile error
Color code according to simulated/kinematic status
Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
File i missed
Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added physics asset factory so physics assets can be created form the "new asset" menu.
Skeletal mesh is picked then a defualt asset is generated
Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Improve interactions with bones & bodies
Clear bone selection when selecting bodies/constraints
Always hide gizmo in simulate
Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed unused selection lock feature
Fixed selection working incorrectly with details panel closed
Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Selection improvements
Multiselect in tree now only selects non-collapsed tree elements
Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent).
Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen
Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994
Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixup post-merge issues
Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Simulation now works in a simlar way to the level editor
Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown.
Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed selection color of wireframe drawing (this broke ages ago!)
Fixed initialized environment color/intensity
Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently)
Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix crash when simulating selected new bodies
Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time)
Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Select all is now a menu option
Context menu pops when right-clicking nothing now too
Menu no longer grows enormous when multiple types of objects are selected
Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Enlarged constraint rendering size
Show constraints (rather than points) by default
Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Physics Assets now appear in the asset family shortcut bar
Physics Assets now render thumbnails
Skeleton tree can now work in 'picker' mode
Constraints can now be created manually in the graph, tree and viewport
Fixed double-click and mousewheel not working right sometimes
Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed clicks incorrectly selecting bones in simulate mode
Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Physics Asset config is now loaded/saved
Fixed antoher corner case with viewport clicks in sim
Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moved body creation params over to a details panel & settings object
Moved initial creation dialog over to use the new system too
Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Renamed shapes and constraints in the tree view
Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Constraints are now not filtered by default
Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Selecting constraints now shows them (and the bodies involved) in the graph
Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed "Show Kinematic Bodies"
We now always show kinematic status in simulate mode
Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
PhAT rendering settings are now persisted across sessions.
Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available.
Added editable opacity to collision rendering.
Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
New materials with opacity parameter
Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Re-saved materials
Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added ability to only show selected bodies as solid
Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix focus 'F' shortcut sometimes not working
Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix a bunch of selection issues with the graph not keeping in sync
Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen
Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853
Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed disappearing convex meshes on simulate
Also fixes crash in thumbnail rendering
Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Disabled selection on mesh. Fixes selection issues.
Also made the hit proxy use a crosshair when over bodies, for easier selection
Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added body/body collision buttons back to the main toolbar
Fixed solid body drawing using the wrong material when no bodies are selected
Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix delete shortcut not working when tree is focused
Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Integrated per-bone primitive generation with the new tab method
Removed context menu item for bones (fixes duplicate popup)
Fixed undo/redo not working for regenerating all bodies
Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Disabled body regeneration when simulation is running
Fixed up tab icons
Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings)
Animation picker removed from toolbar (we use the preview scene settings for this now)
Fixed profiles tab icon
Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Show attached assets in tree
Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix broken multi-selection of bone proxies
Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed code that prevented parts of the UI (like simulation) from working in PIE
Removed graph overlays & added "PHYSICS" label
Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed arrows from graph
Fixed dragging off constraints/input pins/bodies in constraint-created graphs
Constraint names now include both bodies
Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Switched from colors to icons in the skeleton tree
Removed bold fonts
Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Layout fixes
Added border around generate button in tools panel
Removed skeleton tree header in contexts where it is not needed
Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added slow task dialog for body generation
Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Rearranged context menus to be not so huge
Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Rearranged menus some more
Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Colorized details customization of swing/twist items
Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Auto-open assets when creating from skeletal mesh
Tweaked tooltip on suggestion from Nick D
Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed mirroring changes not showing up straight away
Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moved over to Persona-style floor adjustment
Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Tweaked tooltips for filtering items
Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added "deselect all" option (Esc)
Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Graph selection tweaks
Selected bodies in the viewport/tree are now also selected in the graph.
Selection outline is now matched to the graph outline instead of using default outline.
Pin allocation no longer happens twice
Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Switched simulate shortcut to Alt+Enter
Avoids conflict with clobal PIS/SIE shortcuts
Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Minor body regeneration refactor
Label for tools tab button is dynamic depending on selection context
Generation setttings are now re-used by creation dialog too
Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting
Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Resetting animation to default now correctly applies the animation
Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed up physics asset editor's use of debug skel mesh component
This broke post-merge from Dev-AnimPhys.
Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics).
This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor).
Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Moved code to add/remove/assign/unassign profiles to details customization
Also allowed dupication again (via the menu)
Allows correct naming of new profiles as before (as this is handled in PostEdit)
#jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile
#jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor
#jira UE-47384 - New profiles in Physics Asset Editor are all named the same
#jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available
#jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long
#jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save
Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Prevented ctrl+selection of constraints from re-selecting
Avoided defered broadcast of seleciton event from the graph
#jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor
Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed bodies incorrectly simulating outside of 'simulate' mode
Forced all bodies to be non-simulated when simulation is disabled.
Also removed non-functioning motor menu options & disabled more menu options when simulating
#jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor
Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed crash when failing to create a physics asset with multi convex hull
#jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created
Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed typo that disabled editability of profile names incorrectly
#jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save
Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed crash when opening a physics asset with a deleted preview skeletal mesh
Now assigns default mesh as before
If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it.
#jira UE-47918 - Crash when opening certain Physics Assets
Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Prevent "set bodies below" from improperly enabling simulation on bodies
#jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor
Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Physics assets with simulated bodies no longer simulate when first opened
#jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened
Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix excessive gravity crash when actors pop out of the world
Also restrict gravity to non NaN-causing levels.
#jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor
Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen
Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581
Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix merge issues
Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed delegate for skeleton tree context menu extension, now uses an empty section
Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Added comments to bone proxy & physics asset editor shared data
Removed unused variables
Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixed constraint 'all positions' rendering
Removed empty override of unregister tab spawners
Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fix crash when setting skeletal mesh
Toast is not displayed when the skeleton is changed as well as the skeletal mesh.
Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor
#jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying
Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Physics asset selection color now uses editor settings
Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed unused functions
Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Commented SetBodiesBelowPhysicsType as per code review
Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Disabled physical material menu in simulate
Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Removed unused code
Commented a few functions
Re-instated preview mesh selection
Removed delegate allowing viewport client class creation
Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Remove unused code
Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen
Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965
Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen
Fixup merge errors
Change 3596227 by Jonathan.Poncelet
Fixed physics substepping interpolation using the wrong starting value.
#jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16
Change 3596241 by Jonathan.Poncelet
Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately.
#jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin
Change 3596247 by Thomas.Sarkanen
Fixup CIS errors post PhAT Upgrade merge
Change 3596250 by Thomas.Sarkanen
More CIS fixes
Change 3596255 by Benn.Gallagher
Fixed compilation errors when nativizing animation blueprints that use subinstances
#jira UE-46522
Change 3596256 by Benn.Gallagher
Fixed orphaned sub anim instance pins hanging around
#jira UE-46545
Change 3596257 by Benn.Gallagher
Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections.
#jira UE-48045
Change 3596258 by Benn.Gallagher
Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible
#jira UE-47755
Change 3596259 by Benn.Gallagher
Fixed mismatch between paint values and view values for clothing tools
#jira UE-48110
Change 3596260 by Benn.Gallagher
Stopped property context menus killing the whole window stack when an item is clicked
#jira UE-48158
Change 3596261 by Thomas.Sarkanen
One last Mac CIS fix (hopefully)
Change 3596308 by Benn.Gallagher
Removed outdated references to APEX in clothing example map.
Change 3596360 by Martin.Wilson
Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded
#jira UE-48452
Change 3596459 by Benn.Gallagher
Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances.
#jira UE-47567
Change 3596967 by Aaron.McLeran
Adding setting default reverb send level in audio settings.
Change 3596974 by Ethan.Geller
Merge in fix from Christopher Oliver
Change 3597243 by Aaron.McLeran
Checking in missing files.
Change 3597686 by Ethan.Geller
Fix warnings/errors from CL 3597452
Change 3597846 by Ethan.Geller
Fix errors, take 2
Change 3598290 by Ethan.Geller
Panning Angle Issue
Change 3598412 by Ethan.Geller
Change Core.h header to CoreMinimal.h, fix warnings
Change 3599797 by Jurre.deBaare
LODs from Merge Actor tool have bad normals
#jira UE-47129
#fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to:
1) Summing all lightmap pixel counts for each mesh component being merged
2) Calculating fitting texture dimension by taking square root of the total pixels
Change 3599863 by Lina.Halper
PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot)
Change 3599883 by Jurre.deBaare
HLOD: update outliner tooltip when UE docs arrive
#jira UE-20352
Change 3599944 by Martin.Wilson
Smart name refactor
- Remove guids entirely
- Remove automatic fix up
- Simplify smart name mapping container
- Make animations deterministic for cooking
#jira UEAP-264
Change 3600133 by Benn.Gallagher
Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely.
#jira UE-48612
Change 3600166 by Benn.Gallagher
Fixed cloth paint gradient allowing invalid values
#jira UE-48114
Change 3600719 by Lina.Halper
PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus)
Change 3601668 by Jurre.deBaare
Improve BlendSpace preview pin dragging controls
#fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable
#misc Also added tooltips on the grid to make the functionality more discoverable
#jira UE-43011
Change 3601669 by Jurre.deBaare
No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel
#fix I've added the SampleIndex to the names to make it easier recognizing which one is which
#jira UE-46892
Change 3601731 by Benn.Gallagher
Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account.
#jira UE-48329
Change 3601897 by Lina.Halper
fixing issue with sequencer reinitialization
#jira: UE-48556
Change 3602339 by Benn.Gallagher
Fixed comment/tooltip typo
Change 3602502 by Benn.Gallagher
Fixed clothing gradient tool renderer not showing selected points when camera was moving
#jira UE-48331
Change 3602664 by Ethan.Geller
Unshelved fixes from Dev-VR
Change 3602726 by Lina.Halper
Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject
#jira: UE-48700
Change 3603011 by Lina.Halper
Fix build error
Change 3604139 by Benn.Gallagher
Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode.
#jira UE-47960
Change 3604284 by Benn.Gallagher
Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running
#jira UE-48687
Change 3604612 by Lina.Halper
Fix curve issue from automation test
- It was actual bug.
Change 3604614 by Lina.Halper
- Fix crash with macro anim notify
- Make sure macro anim notify doesn't show up in the menu
#jira: UE-45036
Change 3604725 by Lina.Halper
fixed issue with opening state machine from anim graph
#jira: UE-48726
Change 3604971 by Aaron.McLeran
#jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift.
Bringing fix from 4.17 to Dev-AnimPhys
Change 3605787 by Aaron.McLeran
Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls
- This is necessary in order to use the sound concurrency "limit by owner" feature
Change 3606851 by Jurre.deBaare
UE4Editor Static Analysis Win64 - Warning fix
Change 3607022 by Lina.Halper
Fix static analysis warning
Change 3607229 by Jurre.deBaare
RemoveAllCurveData should not allow removing data from the Skeleton
#jira UE-48107
Change 3607660 by Martin.Wilson
Live link client can run in cooked builds too
#jira UEAP-306
Change 3607668 by Ethan.Geller
#jira UE-48792 fix null dereference case in audiodevice.cpp
Change 3607734 by Lina.Halper
LOD linking to curve
- consolidated to one param - curve eval option
- for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :(
- fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap
- flipped meaning to align with bAllowCurveEvaluation
- also fixed issue with orion cooking - where transform curves are added as normal curves
#jira: UE-37996, UE-48782
Change 3607859 by Martin.Wilson
Missed files from live link editor checkin
Change 3607958 by Martin.Wilson
Redo Jurre's changes from CL 3607229 (were removed by CL 3607734)
Change 3608566 by Ethan.Geller
change include to avoid header conflicts on Linux
Change 3609074 by Ethan.Geller
Take 2: Fix capitalization on include, fix Linux build.
Change 3610024 by Lina.Halper
Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene
- we used to load advanced preview setting by persona module
- this has been moved to persona tool kit, and now all other modules are crashing
- If we want to do it for tool kit, we have to make sure all other editor's loading should change also.
#jira: UE-48809
Change 3610081 by Jurre.deBaare
Animations can't be set on blend samples from the dropdown
#fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains
#jira UE-48746
Change 3610088 by Jurre.deBaare
Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace
#fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead
#misc found out of sync widget values due to incorrect encapsulation inside of lambdas
#jira UE-48741
Change 3610862 by Ethan.Geller
Fix submix effects for situations where number of input channels does not equal output channels
Change 3611346 by Aaron.McLeran
Using audio thread platform affinity mask for audio render thread.
Change 3613297 by Ethan.Geller
Simple delay submix
Change 3614435 by Martin.Wilson
CIS fix
Change 3614482 by Martin.Wilson
Store root motion on anim instance instead of proxy to avoid thread safety stalls
#jira UE-46896
Change 3614483 by Martin.Wilson
Evaluate curves in anim offsets
#jira UE-47119
Change 3614495 by Jurre.deBaare
Reimport alembic file with new source option does not automatically tick any tracks
#fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either)
#jira UE-46141
Change 3614645 by Thomas.Sarkanen
Fixed physics assets not simulating when BlockAll was globally overridden
Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT
#jira UE-48591 - Physics assets not simulating correctly in Orion
Change 3614683 by Lina.Halper
Fixed crash when modifying default physicsasset
#jira: UE-48844
Change 3614721 by Jurre.deBaare
Vertex painting on skeletal meshes bound by physics asset
#fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies
#jira UE-48004
Change 3614730 by Thomas.Sarkanen
Fixed crash when regenerating multi convex hulls from zero-vert bones
We handled this in the single convex hull case, but multi did not.
#jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body
Change 3614763 by Jurre.deBaare
Moving over:
HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor
#jira UE-48249
#fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh
Change 3615029 by Lina.Halper
Fix issue with highlight
#jira: UE-48855
Change 3617593 by Thomas.Sarkanen
Fixed crash when regenerating large amounts of bodies
We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems
#jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies
Change 3617609 by Jonathan.Poncelet
Fixed crash that could occur when opening a physics asset and deleting bones.
#jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it
Change 3617723 by Thomas.Sarkanen
Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down
Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting.
Moved AddToRoot pattern used for anim preview scene to FGCObject
#jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794]
#jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed
Change 3617818 by Benn.Gallagher
Final v1 UX changes for clothing tool, and removed experimental flag
Change 3617937 by Jurre.deBaare
Default bounds for Alembic skel-mesh are too large
#fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds
#jira UE-47139
Change 3618187 by Ethan.Geller
Implement Audiomixer in HTML5
Change 3618188 by Lina.Halper
Fix issue with highlight in persona
#jira: UE-49020
Change 3618229 by Lina.Halper
Fix crash on exit when modify is causing it to serialize again in the middle of tear down
#jira: UE-48025
Change 3618248 by Lina.Halper
fix issue by workaround where clamp is not happening with allowspin is false
#jira: UE-47001
Change 3618289 by Aaron.McLeran
Removing audio format types we're not using for simplicity
Change 3618291 by Martin.Wilson
Fix duplicate of curve name appearing in list when renaming
#jira UE-49041
Change 3618390 by Aaron.McLeran
Removing a case for DTYPE_Xenon since this is never used.
Change 3618425 by Martin.Wilson
Keep notify UI up to data across multiple editors when adding notifies to an animation
#jira UE-48104
Change 3619023 by Aaron.McLeran
Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used
Change 3619129 by Aaron.McLeran
Source bus feature.
- New architectural feature for audio mixer that allows audio sources to route to other audio sources.
- Buses can be routed to each other
- Buses have a duration which can be set in bus asset
- Buses can choose between mono and stereo channels
- Sources can send to buses and also toggle to *only* output to buses (and bypass submixing)
- Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc.
- Some engine changes and optimizations:
- Format conversion to float is done in async workers for decode vs the render callback
- Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer)
- Apply master attenuation at the final output vs per-source
- Fixed code that performs fade in/fade out for smooth startup and shutdown.
- Moved FSourceParam to FParam into DSP utility so others can use it.
- Some engine fixes:
- Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc.
- Fixed an issue with pause
- Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties
- Fixed an issue with WorldID not getting set for listeners
TODO:
- fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses
Change 3619159 by Ethan.Geller
#jira UE-48950 fix steam audio crash on editor exit
Change 3619555 by Jonathan.Poncelet
Fixed constraint debug drawing arrows in the physics asset editor being too large.
#jira UE-48863 Limited constraints and free constraints are much larger on screen
Change 3619574 by Thomas.Sarkanen
Fixed debug link for animation blueprints not persisting when changing preview mesh
Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes.
#jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session
Change 3619586 by Thomas.Sarkanen
Fixed physics asset shortcut not working correctly in certain circumstances
FBox was using uninitialized memory
#jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body
Change 3619640 by Thomas.Sarkanen
Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars
Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically).
#jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar
Change 3619644 by James.Golding
Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances)
#jira UE-47652
Change 3619654 by Martin.Wilson
Fix removing a curve when it isn't used on any animations
#jira UE-49048
Change 3619771 by Thomas.Sarkanen
Make sure the physics asset editor floor has collision, regardless of what BlockAll does
#jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config
Change 3619803 by Jonathan.Poncelet
Fixed localization warnings caused by duplicate keys.
#jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings
Change 3619813 by Jurre.deBaare
Baked bones using a pose animation are rotated in the wrong direction
#fix root bone transform wasn't being taken into account while generating final bone transforms
#misc added debug logging for future work
#jira UE-47362
Change 3619830 by Jurre.deBaare
Biased Texture Size option is not functioning when Merging Actors
#fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow
#misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake
#jira UE-48108
Change 3619859 by Thomas.Sarkanen
Fixed HLOD selection sphere persisting on undo/redo
Removed HLOD selection actors when the outliner is refreshed
#jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement.
Change 3619871 by Martin.Wilson
Calculate root motion over the correct segment times, not the track times
#jira UE-43719
Change 3619898 by Thomas.Sarkanen
Improve UI feedback around bounds/in-game bounds in animation editor viewports
Tooltip for in-game bounds is now more detailed
In-game bounds cannot be selected if bounds is not also selected
#jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing
Change 3619908 by Thomas.Sarkanen
Fixed tooltip for PhysicsType
#jira UE-48421 - Incorrect tooltip for Physics Type
Change 3620014 by Jurre.deBaare
Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements
#fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<>
#misc Also added more delegates to ensure the restriction is up to date
#jira UE-46980
Change 3620104 by Jurre.deBaare
HLOD doesn't support renaming in levels
#fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer
#jira UE-48072
Change 3620151 by Thomas.Sarkanen
Undo/redo now correctly affects animation preview scene settings
Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc
#jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI
Change 3620152 by Thomas.Sarkanen
Exposed LOD menu in PhAT
This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior.
#jira UE-47970 - LODs not working in Physics Asset Editor
Change 3620177 by Benn.Gallagher
PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz)
Change 3620250 by Jurre.deBaare
HLOD assets left in HLOD folder when clusters are deleted
#fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed
#jira UE-47450
Change 3620273 by James.Golding
PR #3908: Removing duplicated forward declation (Contributed by celsodantas)
#jira UE-48530
Change 3620274 by James.Golding
PR #3909: Removing unnecessary conditional (Contributed by celsodantas)
#jira UE-48531
Change 3620275 by James.Golding
Add icon for destruction plugin
Change 3620401 by Ethan.Geller
#jira UE-47684 Remove SDL dependencies from Win64
Change 3620586 by Jurre.deBaare
Linux CIS fix
Change 3620660 by Martin.Wilson
Fixes for state machines getting reinitialized in situations that users don't want them to.
-Added option to state machine to allow it to skip reinitialization when it becomes relevant
-Added option to slot nodes to keep source pose relevant while montage slot is playing.
#jira UE-43578
Change 3620665 by Aaron.McLeran
Making source buses only show relevant source bus data.
- hiding sound wave categories that aren't relevant to source buses
Change 3621087 by Ethan.Geller
#jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled.
Change 3621144 by Aaron.McLeran
#jira UE-49147
#jira UE-49145
Fixing concurrency and volume stats
Change 3621148 by Aaron.McLeran
Fixing typo
Change 3621180 by Ethan.Geller
#jira UE-49151 Fix for browser preview on bus only sounds
Change 3621421 by Ethan.Geller
#jira UE-49165 Fix real time audio slider.
Change 3621604 by Ethan.Geller
#jira UE-44847 fix iOS panning algorithm on non-audio mixer
Change 3621626 by Lina.Halper
Fix issue with anim montage displaying when selecting animation
#jira: UE-48749
Change 3621813 by Thomas.Sarkanen
Fixing undo/redo of bone modifications in Physics Asset Editor (and others)
Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique.
Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again)
We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway).
#jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work
Change 3621831 by Jurre.deBaare
Crash fix for Material baking when trying to analyse a MP_MAX material property
#jira UE-49172
Change 3621936 by Thomas.Sarkanen
Fixed CIS error from merge
Change 3621937 by Thomas.Sarkanen
Fix merge issue with API change in USynthComponent
Change 3622173 by Thomas.Sarkanen
Fixed ortho viewports being bright white in sub-editors
Preview scenes in general are responsible by default for the background color.
Advanced preview scenes now use background color from settings. Previously only te animation editors did this.
#jira UE-48841 - The background of the orthographic viewports is bright white
Change 3622730 by Ethan.Geller
#jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran
Change 3622759 by Ethan.Geller
#jira 49170 reduce static analysis warnings for audiodevice.cpp
Change 3622901 by Benn.Gallagher
Bumped PhysX DDC key after change in Orion caused verify failures
Change 3623458 by Aaron.McLeran
#jira UE-49204 Delores monologue cut short in Odin elevator
Change 3623667 by Aaron.McLeran
#jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator
Change 3623752 by Aaron.McLeran
#jira UE-49247 Sound Source Bus Properties Are Inappropriate
Fixing issues with new source bus uobject so properties show up appropriately.
Change 3624058 by Ben.Marsh
Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests.
Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path.
Change 3624193 by Ethan.Geller
#jira UE-49170 Static analysis fix, take 2
Change 3354003 by Thomas.Sarkanen
Back out changelist 3353914
Change 3355932 by Thomas.Sarkanen
Back out changelist 3354003
Reinstating merge from Main:
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839
Change 3477632 by Jurre.deBaare
Automated test content and ground truths for Actor Merging and Material baking functionality
Change 3491464 by Jurre.deBaare
Updated automation content for MergeActor behaviour
Change 3587878 by Thomas.Sarkanen
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489
Change 3597452 by Ethan.Geller
#jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin.
Change 3602935 by Lina.Halper
Allow curve evaluation to be controlled by users
#jira: UE-46446
Change 3606120 by Ethan.Geller
Move Tap Delay Submix to Synthesis library, modify tap delay API
Change 3621830 by Thomas.Sarkanen
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691
Change 3622807 by Ethan.Geller
#jira UE-49201 Fixing volume issues
Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains.
[CL 3624383 by Thomas Sarkanen in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3363699 by Mike.Fricker
VR Editor: Improved extensibility (for mesh editor)
- This was merged from CL 3352612 and re-opened for edit before commit
- All mesh editor changes were stripped before merging
Change 3499858 by Matt.Kuhlenschmidt
PR #3673: Fixed UE-36416 (Contributed by DarkSlot)
Change 3499872 by Matt.Kuhlenschmidt
PR #3682: Details view - matrix button visibility toggle and crash fix (Contributed by kamrann)
Change 3499873 by Matt.Kuhlenschmidt
Hide property matrix button from settings editor. For the combined settings objects view this produces nonsensical results and the property matrix is for bulk editing which settings are not designed for.
Change 3501154 by Arciel.Rekman
Fix incorrect RPATH.
- Fixed LinuxToolChain to use FileItem instead of strings.
- Fixed string-based Utils.MakePathRelativeTo - workaround for an old Mono bug was causing invalid "correction" of the relative path, triggered by the fact that path "Foo/Bar/../Baz" was not considered equal to "Foo/Baz". Instead of removing the workaround altogether, added a better comparison.
Change 3501337 by Arciel.Rekman
Better fix for RPATH.
- Ben Marsh's suggestion.
Change 3502572 by Matt.Kuhlenschmidt
PR #3693: Because "becuase" is spelled because (Contributed by getnamo)
Change 3502731 by Matt.Kuhlenschmidt
Guard against empty warning toasts
#jira UE-46285
Change 3502788 by Matt.Kuhlenschmidt
Avoid shutting down the editor during loads and slow tasks if a windows close message comes in during this time
Change 3503027 by Michael.Dupuis
Optimized UpdateLayerUsageInformation
Change 3503299 by Michael.Dupuis
Fixed crash when having no layer info object
Change 3504529 by Yannick.Lange
Use UWorld instead of FWorldContext for EditorWorldExtensions, since we don't use it.
Change 3504550 by Jamie.Dale
Fixed/Improved DnD validation between Content Browsers
Dragging assets between Content Browsers now goes through the same common DnD code (DragDropHandler) as dragging assets between the SPathView and SAssetView, and between items within an SAssetView. This also improves the validation of asset/file drops to prevent you dropping assets/files into class paths.
#jira UE-45857
Change 3505369 by Alexis.Matte
Make sure undo/redo transactions works for all fbx dialog options.
#jira UE-43465
#jira UE-43569
Change 3505500 by Matt.Kuhlenschmidt
Fix child usd meshes not importing properly.
Change 3505645 by Arciel.Rekman
Add USD support on Linux (UE-45383).
#jira UE-45383
Change 3505658 by Arciel.Rekman
USD: add CMake toolchain file I missed.
Change 3506796 by Yannick.Lange
Fix EditorWorldExtensionCollection using TWeakObjectPtr for UWorlds instead of UPROPERTY
Change 3508082 by Alexis.Matte
Make sure the fbx re-import editor preference "show option dialog at reimport" is working when re-importing an animation sequence.
Change 3508855 by Max.Chen
Add CanFindInContentBrowser to AssetEditorToolkit.
False for LevelSequenceEditorToolkit so that sequencer doesn't take over Find In Content Browser and show only the sequencer asset.
#jira UE-46241
Change 3509282 by Bradut.Palas
#jira UE-45337
Removed check for Actor->GetWorld() against GWorld because the latter would switch between editor world and PIE world during a tick, causing the widget to not update properly.
Since the Actor would always point to the PIE world, the check was no longer needed.
Change 3509298 by Nick.Darnell
Slate - Now has better support for analog navigation, the NavigationConfig is now created per user, and has the ability to deal with repeats and can handle navigation better by waiting until the user has moved enough to intend a direction to move.
Change 3509313 by Bradut.Palas
#jira UE-44630
As the bug description says, the Undo History was not refreshing correctly because an undo coupled with an action would result in the same number of transactions as the previous tick. Now we also check the variation of undo actions count in order to refresh the list.
Change 3509318 by Bradut.Palas
#jira UE-1406
To fix the issue we simply close the Consolidate window if ListViewItems is empty.
Change 3509402 by Nick.Darnell
PR #3703: UE-46362: Fixing typo in EUMGSequencePlayMode.PingPong comment (Contributed by gsfreema)
Change 3510447 by Arciel.Rekman
ReplayProxy: changed protected to private.
Change 3510467 by Max.Chen
Property Editor: Disable color widget when editing is disabled.
#jira UE-46331
Change 3511249 by Matt.Kuhlenschmidt
PR #3715: Turn off the automatic expiration of the restore assets notification (Contributed by IHappyDayI)
Change 3511286 by Matt.Kuhlenschmidt
Added ability to set properties from USD attributes when using scene import to import USD files. See
UsdPropTestScene.usda for an example file of how this works
Change 3511528 by Cody.Albert
Updated FMoviePlayerWidgetRenderer to use Slate time instea of application time
Change 3512149 by Matt.Kuhlenschmidt
Dont save non-dirty built data when playing PIE in a standalone process
#jira UE-46422
Change 3512259 by Matt.Kuhlenschmidt
Fix static analysis
Change 3512291 by Matt.Kuhlenschmidt
PR #3719: Updating UEditorEngine::ReplaceActors to not copy array of actors (Contributed by gsfreema)
Change 3512911 by Matt.Kuhlenschmidt
Fixed USD property setting crashing if the usd file contained an array with 0 elements.
Fixed USD property setting creating invalid tmaps if the usd file contained a key that already existed
Change 3513725 by Matt.Kuhlenschmidt
PR #3726: Copy/paste fix for SAdvancedDropdownRow::Construct() (Contributed by jovisgCL)
Change 3514453 by Jamie.Dale
Added a way to set the UEnum used by a UEnumProperty after using the default constructor
This will assert if called on an instance that has already been initialized
Change 3514858 by Alexis.Matte
Fix crash when importing animation and choosing a different value for option "Import Meshes In Bone Hierarchy" then the value use to import the skeletal mesh. In some case there is no skinned mesh.
Change 3514875 by Matt.Kuhlenschmidt
PR #3721: Fixed. Screen Message was showed always when screenshot is captured(F9) (Contributed by shuaiharry)
Change 3515859 by Bradut.Palas
#jira UE-46516
The RenameTextBox didn't handle the OnTextCommitted event (which can be triggered when pressing Enter in the box). Now it does.
Change 3515998 by Jamie.Dale
Adding missing ) to some log messages
Change 3517681 by Matt.Kuhlenschmidt
Fix automated import not applying any texure settings to imported textures
Change 3517703 by Nick.Darnell
Slate - Marking SWidget's destructor as virtual (it always has been because of the parent), but this makes it more obvious.
Change 3517737 by Nick.Darnell
Slate - The retainer widget now only knows how to store the images in gamma space, rather than rendering in linear and storing using sRGB writes. If you do it that way - you end up in a state of having premultiplied linear space stored in sRGB, and getting that back into a state that looks correct when you finally render it with the rest of Slate becomes very difficult, so to make things simpler
Change 3517758 by Nick.Darnell
UMG - Updating the retainer box categories and visibility.
Change 3517795 by Nick.Darnell
Slate - We now don't do inherited volatility if we're also caching.
Change 3517861 by Matt.Kuhlenschmidt
Update windows USD to .75
Change 3517867 by Matt.Kuhlenschmidt
Delete OpenEXR from USD dependencies. It is no longer used
Change 3517873 by Matt.Kuhlenschmidt
Updated USD windows binaries
Change 3517896 by Max.Chen
Sequencer: Call SkyLightComponent's SetLightColor() directly, similar to LightComponent
#jira UE-46669
Change 3518240 by Max.Chen
Sequencer: Set needs update when binding.
#jira UE-46619
Change 3518492 by Max.Chen
Sequencer: If already at the correct play position, don't jump to it. This fixes a bug where if you play to a position and pause, resuming play will playforward and not keep pausing.
#jira UE-45996, UE-45997
Change 3518997 by Max.Chen
Fbx: Fix aperture width, height, focal length and field of view calculations.
#jira UE-46754
Change 3520190 by Jamie.Dale
Cleaned up SCC log spam when finding out-of-date dependencies
Change 3520237 by Yannick.Lange
VR Editor: cleanup auto entry. Removed TimeSinceHMDChecked and added extra check for if there is currently a vr mode active.
Change 3520923 by Max.Chen
Sequencer: Refactor displaying sequencer settings in editor so that they're always available and not only when the sequencer type is instantiated.
#jira UE-46301
Change 3521212 by Matt.Kuhlenschmidt
PR #3757: MAX_NAME_LENGHT -> MAX_NAME_LENGTH (Contributed by Josef-CL)
#jira UE-46821
Change 3521216 by Matt.Kuhlenschmidt
PR #3751: Spelling fix for ESlateVisibility comment (Contributed by Triplelexx)
#jira UE-46810
Change 3521221 by Matt.Kuhlenschmidt
PR #3733: UE-46683: Don't increment MovieIndex when playing next movie (Contributed by projectgheist)
#jira UE-46683,UE-46714
Change 3521344 by Yannick.Lange
Fix selection tools in the Levels editor window. After selecting all levels SWorldHierarchyImpl::OnUpdateSelection used GetSelectedTreeItems(). At that point the tree items were not updated yet and it would return the 'previous' items. Making it look like nothing happened. Instead WorldModel->GetSelectedLevels() had to be used to get the new list of selected levels (this was used in 4.16) and then convert the list of FLevelModel to the new system that uses WorldHierarchy::FWorldTreeItemID.
#jira UE-46741
Change 3521825 by Joe.Graf
#Xb1
Added missing VectorSetFloat1 by copying the one in UnrealMathSSE.h
#CodeReview: ben.woodhouse
Change 3522114 by Joe.Graf
#Xb1
Changed the missing VectorSetFloat1 to use MakeRegisterVector to be more consistent with other Xbox defines per Ben's code review
#CodeReview: ben.woodhouse
Change 3524202 by Matt.Kuhlenschmidt
Prevent resizing when a context menu is open. This prevents a number of rare crashes when a window is resized when a child menu is open causing the child to lose connection to the parent (happens when the parent widgets are clipped and no longer processed). This is consistent with behavior on windows and mac.
#jira UE-46653
Change 3524263 by Bradut.Palas
#jira UE-46671
The issue happened because a parent callback of OnAssetRenameCommitted would allow an implicit sync and it would reset the search. Solved by blocking the parent callback if the user is searching.
Change 3524265 by Bradut.Palas
#jira UE-46261
Console command was doing something illegal. Opening a map from editor when multiprocess and client mode were enabled is prohibited by code in Playlevel.cpp (( !CanRunUnderOneProcess && PlayNetMode == EPlayNetMode::PIE_Client ))
Solved by banning that specific use of the command.
Change 3524266 by Bradut.Palas
#jira UE-45592
The bug was caused by an iteration in EndPlayMap() that re-selected all previous actors but without the notify flag (hence, not triggering the code that validated showing the transform widget). Fixed by notifying just once per group, for performance reasons.
Change 3524585 by Bradut.Palas
Back out changelist 3524265 until I can figure out why the build system doesn't like it.
Change 3525921 by Bradut.Palas
Resubmitting revision 3524265 with properly guarded editor code (#if WITH_EDITOR)
Change 3526124 by Matt.Kuhlenschmidt
Remvoe debug canvas proxy
Change 3526139 by Matt.Kuhlenschmidt
Force low quality fallback mode on ES2 devices for slate blur widgets. This feature does not work on es2
Change 3526663 by Cody.Albert
Fixed sequencer bindings to correctly work on streamed level in standalone preview mode
Change 3527028 by Cody.Albert
Back out changelist 3526663
Change 3527241 by Cody.Albert
Fixed sequencer bindings to correctly work on streamed level in standalone preview mode
Change 3527829 by Max.Chen
Fbx: Add static transform values to curve data import.
#jira UE-46888
Change 3527830 by Max.Chen
Sequencer: Import static/default transforms and camera focal lengths from fbx.
#jira UE-46888
Change 3528768 by Matt.Kuhlenschmidt
Refactor of GetDetailsView method on IDetalLayoutBuilder for some upcoming changes. There is no longer a guarantee that a physical details panel is present wwhen customizing a property so GetDetailsView now returns a pointer and will be null if no details view exists. This refactor is necessary for a change to allow us to make loose property widgets for use outside of a details view.
Change 3528776 by Yannick.Lange
Allow thumbnails to be captured from a viewport always.
#jira UE-45392
Change 3530675 by Michael.Dupuis
#jira UE-46913 : Added extra validation to prevent possible crash
Change 3530991 by Matt.Kuhlenschmidt
Added ability for users to specifiy usd plugins for the USD importer
Change 3531110 by Matt.Kuhlenschmidt
Added automated import support for USD.
Automated import now also supports loading a level per import group so that factories may spawn actors and manipulate the level
Change 3531119 by Matt.Kuhlenschmidt
USD Scene import now uses actor factories to determine the correct actor type to spawn for an asset specified in USD
Change 3531220 by Jamie.Dale
Fixed some places that were iterating over sets/maps using their element indices as if they were the sparse indices
Change 3531831 by Cody.Albert
BP nodes can no longer be renamed on read-only graphs.
Change 3531938 by Yannick.Lange
Enable setting justification at runtime for multi-line text boxes.
#jira UE-44801
Change 3533011 by Matt.Kuhlenschmidt
Exporting render targets now chooses PNG if the render target format is an LDR format
Change 3533370 by Arciel.Rekman
Fix comparison of the RT format.
Change 3533717 by Nick.Darnell
Slate - Adding justification to SEditableText and SpinBox, also adding the field for UMG.
Change 3534756 by Arciel.Rekman
Linux: add path to bundled GL headers.
- Seems like we have been implicitly relying on it being added someplace else or simply present in the system.
- Change by Cengiz.Terzibas
Change 3535421 by Arciel.Rekman
Reduce SCW logspam on Linux (UE-46634)
#jira UE-46634
Change 3537520 by Matt.Kuhlenschmidt
PR #3780: Fix typo steam to stream (Contributed by YuchenMei)
Change 3537539 by Nick.Darnell
UMG - Fixing a bug with aspect ratio locking cameras when in HDPI mode, the spaces were slightly different. Moving over the code that calculates the offsets to function in normalized space, so that it's trivial to combine with the existing normalized viewport dimensions and offset information, without space confusion.
Change 3537542 by Nick.Darnell
UMG - Fixing some bugs with the retainer widget which was not properly resetting or registering the hit testing information when rendered every frame. This should fix some issues that have been seen with clicks locking the viewport rendering, or not being clickable.
Change 3537596 by Alexis.Matte
Fbx SDK 2018.1.1 Integration
#jira UE-45070
Change 3537672 by Matt.Kuhlenschmidt
Simple fix for seconds of time being spent refreshing the settings editor if commands are registered while it is open. The request to refresh is deferred until next tick, meaning that each command list registered in a frame is not refreshing the details panel.
Change 3537796 by Alexis.Matte
Make sure all general settings are persist when we re-import a staticmesh from fbx file.
#jira UE-46829
Change 3537961 by Michael.Dupuis
#jira UE-47222: Prevent possible crash in some bad drag & drop case
Change 3538149 by Alexis.Matte
Make sure we export NTB information instead of just the normal when exporting to fbx
#jira UE-46785
Change 3538237 by Alexis.Matte
Fix import of large fbx scene (over 2 Gb) pr #3784
#jira UE-47124
Change 3538270 by Lauren.Ridge
Epic Friday: Preview scenes in material editors
Change 3539707 by Yannick.Lange
Optimize viewport interactor hitresult for laser. Store the first hitresult and use that when calling UViewportInteractor::GetHitResultFromLaserPointer multiple times a frame.
Change 3539964 by Lauren.Ridge
Fix for cubemap not persisting between loads
Change 3540321 by Arciel.Rekman
Linux: CEF rebuilt with fewer dependencies (UE-46433).
- Removed source-only binary to save size (we can link to the runtime one, this also allows RPATH to be generated automatically).
- Change by Cengiz.Terzibas, polished by RCL.
Change 3540458 by Alexis.Matte
Fix the HDR pixel inspector. The HDR value is now RGBA in editor viewport and RGB in Game mode.
#jira UE-47199
Change 3540681 by Arciel.Rekman
Linux: fix flickering (UE-46351) - redoing fix from 4.17
- Slate rendering policy can set a scissor rect equal to a (smaller) window, which would get inherited by the scene renderer later.
#jira UE-46351
(Redoing the fix from CL 3538578 in 4.17).
Change 3540838 by Matt.Kuhlenschmidt
Fix locked actors still being moved by piloting them
Change 3542212 by Nick.Darnell
Slate - Fixing a crash with per character wrapping. When used in rich text fields, it can cause a crash due to negative lengths for measurements, due to the way we calculate start and end indexes. New code now ensures the End is always >= to the Start.
Change 3544033 by Arciel.Rekman
Drop and deprecate /-prefixed commandline switches.
- Dropped on all platforms except Windows, where it will produce a warning. Complete drop is expected in 4.19.
Change 3544213 by Nick.Darnell
Slate - Fixing another potential crash with the slate loading thread. The default movie player was listening for map load finishing using the AddSP callaback, which means the weakptr would be accessed, switching these over to AddRaws to be safer.
Change 3546113 by Nick.Darnell
Slate - Resurecting the slate visualizer support in the slate renderer for batch visualization, and overdraw.
Change 3547129 by Michael.Trepka
Few small changes that make UnrealBuildTool faster when running on Mono
Change 3547454 by Jamie.Dale
Added search to editable texts
Change 3547460 by Jamie.Dale
The output log now applies a search to its editable text when filtering
This highlights the term matches on each line
Change 3548177 by Jamie.Dale
Optimized PO entry look-up
Change 3548287 by Matt.Kuhlenschmidt
Fix one off speedtree crash
#jira UE-47538
Change 3548377 by Lauren.Ridge
Checking that the Environment Map Path is set before trying to load it.
#jira UE-47365
Change 3548628 by Matt.Kuhlenschmidt
Fix focus graphic for tabs not pointing to the correct image
Change 3549289 by Max.Chen
Movie Scene Capture: Move window to within the desktop bounds when resizing.
#jira UE-37330
Change 3549290 by Arciel.Rekman
Fix hlslcc not working properly with newer clangs.
- Both the clang 3.8+ problem and UB reported by UBSan.
Change 3550573 by Max.Chen
Sequencer: Track drag drop.
Implement drag and drop onto a camera track, subscene track, and cinematic shot track.
#jira UE-45773
#jira UE-45387
Change 3550729 by Max.Chen
Sequence Recorder: Add interpolation and tangent settings for animation recording keys
#jira UE-46146
Change 3551558 by Nick.Darnell
UMG - Tweaking some designer elements, playing around with a 'real-time' mode. Also fixing a bug with decendant widgets in named slots not triggering design effects like updating the widget switcher.
#jira UE-39404
Change 3551671 by Joe.Graf
Merged over the change to expose more of dormancy to Blueprints (UE-46240)
Change 3551684 by Cody.Albert
Removing some unused code from map check
Change 3552673 by Yannick.Lange
Fix crash select all levels with folders in the treewidget.
Change 3552960 by Yannick.Lange
Frontend filter for files referenced by any level in the project and a filter for not referenced by any level.
#jira UE-22153
Change 3553727 by Max.Chen
Sequencer: Capture thumbnail before pre save so that the thumbnail isn't captured with the evaluation in a reset state.
#jira UE-47693
Change 3553778 by Arciel.Rekman
Cache check for compiler availability (UE-47699).
- Fixes performance drop in the blueprint editor. Better than caching in a particular source accessors because affects all accessors (incl. Mac which isn't cached either) and reduces calls.
Change 3554128 by Matt.Kuhlenschmidt
Null out GEditor after it has been destoyed. Any modules that access GEditor can now properly check for a null geditor instead of blindly accessing it
Change 3554266 by Max.Chen
Movie Scene Capture: Override cinematic mode in the movie scene capture.
#jira UE-33473
Change 3555563 by Alexis.Matte
Fix static mesh screensize lost when converting from an old version. The conversion require valid extended bounds which was converted after the LOD screensize.
#jira UE-47697
Change 3555755 by Yannick.Lange
VR Editor: Add exit button inside new menu called "system" on radial menu. Still needs correct icons.
Change 3556334 by Matt.Kuhlenschmidt
Added a new type of property editor called a property row generator. This is essentially a details panel that can generate each unique row but adds no visual styling around the property editors and does not generate a master tree widget for the properties. This is useful for creating proper widgets for properties and displaying them in a UI that is not the details panel
Change 3558100 by Matt.Kuhlenschmidt
PR #3823: Incorrect comment syntax in ini files (Contributed by projectgheist)
Change 3558240 by Lauren.Ridge
Move floor in material editor preview scene based on preview mesh
Change 3558242 by Matt.Kuhlenschmidt
Fix console variables help page showing only rendering cvars by default
Change 3558243 by Matt.Kuhlenschmidt
Fix static analysis
Change 3558342 by Alexis.Matte
Make the code to find the best sample rate to import fbx animation more simple and more robust. The code need to be able to support all the possible case.
Add a lot of animation sample rate automation tests
#jira UE-47342
Change 3558515 by Yannick.Lange
VR Editor: Changed icon for system and exit button on radial menu.
Change 3558973 by Matt.Kuhlenschmidt
Fix camera placement of the default map
Change 3559230 by Arciel.Rekman
Do not link CEF3 for servers (UE-47721).
Change 3559572 by Arciel.Rekman
Linux: make sure the engine is rebuilt during the updates.
Change 3560197 by Arciel.Rekman
Linux: cosmetic cleanup of an old code.
Change 3560904 by Max.Chen
Movie Scene Capture: Expose "Open Folder" hyperlink while capturing.
Change 3561213 by Matt.Kuhlenschmidt
Enable USD by default in QA game for testing
Change 3561928 by Matt.Kuhlenschmidt
Fix green glowing in the mateiral editor
#jira UE-47826
Change 3562259 by Arciel.Rekman
Made FPlatformMisc::DebugBreak() not inlined on Linux.
- Saves a great deal of binary size without really impacting a performance.
Change 3562630 by Arciel.Rekman
Make Linux editor compilable with clang 5.0-rc1.
Change 3563564 by Yannick.Lange
Fix Cube Static Mesh Thumbnail renders black. Cleared out the thumbnail, causing it to create the correct new one.
#jira UE-47777
Change 3564529 by Jamie.Dale
Const-correct UScriptStruct::ExportText
Change 3564972 by Alexis.Matte
Fix staticmesh merge applying build scale multiple time Git PR #3807
#jira UE-47645
Change 3565253 by Arciel.Rekman
Fix "Anim to Play" being inaccessible after import (UE-47885).
- The variable was not initialized and could remain false on Linux.
#jira UE-47885
Change 3565293 by Jamie.Dale
Merged "Categories" into the main Output Log filter list
Change 3565939 by Alexis.Matte
Back out revision 3 from //UE4/Dev-Editor/Engine/Source/Developer/MeshMergeUtilities/Private/MeshMergeHelpers.cpp
Change 3566081 by Alexis.Matte
Fix staticmesh merge applying scale twice PR #3807
#jira UE-47645
Change 3566232 by Matt.Kuhlenschmidt
Fix edit inline properties not clipping properly
#jira UE-47775
[CL 3567077 by Matt Kuhlenschmidt in Main branch]
#lockdown Nick.Penwarden
#rb none
#rnx
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3343905 by Dan.Oconnor
ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches
Change 3346637 by Ben.Zeigler
Actually fix in non editor builds
Change 3355484 by Dan.Oconnor
Back out FMemberReference Optimization
Change 3425833 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3510091 by Marc.Audy
Expose on Spawn functional test
#rnx
Change 3510100 by Marc.Audy
Fix spelling error
#rnx
Change 3510132 by Marc.Audy
Fix issues with marking a widget blueprint class as abstract
Change 3510133 by Marc.Audy
Minor code cleanup
#rnx
Change 3510178 by Ben.Zeigler
#jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build
Change 3510466 by Ben.Zeigler
Start adding basic ability system tests to enginetest, very minimal so far
Change 3511295 by Marc.Audy
Fix wasted work going weak -> object -> weak -> object
#rnx
Change 3511824 by Marc.Audy
Fix spelling error in tooltip
#jira UE-46515
#rnx
Change 3514446 by Ben.Zeigler
Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode.
Change 3514578 by Marc.Audy
Move clearing of the actor component need end of frame update mark to base class instead of just primitive component
Change 3514583 by Ben.Zeigler
Better fix to last delegate checkin that also handles moving functions between modules but not renaming
Change 3515325 by Dan.Oconnor
Fix for rare orphan pin false positive, rare exposed on spawn false positive
#rnx
Change 3515761 by Marc.Audy
fix shipping configuration
#rnx
Change 3515772 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3516287 by Marc.Audy
Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
#rnx
Change 3516303 by Marc.Audy
Back out CL# 3516287 while an oddity is investigated
#rnx
Change 3516563 by Marc.Audy
(4.17) Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
Change 3516637 by Phillip.Kavan
#jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script.
Change summary:
- Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name.
Change 3517735 by Marc.Audy
Avoid unnecessary string copy
#rnx
Change 3517931 by Marc.Audy
Small optimization to CleanupActors
Change 3518221 by Dan.Oconnor
Fix rare crash when running ConformImplementedEvents when async loading
#jira UE-45348
Change 3518270 by Ben.Zeigler
#jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection
Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection
Change 3518271 by Marc.Audy
Get rid of unnecessary construction differentiation if custom reset is being used
Change 3518310 by Ben.Marsh
Re-adding IOS files with correct case.
Change 3518423 by Ben.Zeigler
#jira UE-46574 Initial support for chunk installation in Asset Manager.
Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access
Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally
Change 3518480 by Marc.Audy
Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class
#jira UE-46737
Change 3518498 by Ben.Zeigler
Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load
Update test map to catch this
Change 3518526 by Ben.Zeigler
IOS Fix
Change 3518619 by Ben.Zeigler
#jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set
Change 3518747 by Phillip.Kavan
#jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy.
Change summary:
- Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API.
- Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time.
- Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent.
- Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log.
Change 3518756 by Michael.Noland
(4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points
Change 3518760 by Michael.Noland
Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning
Change 3518771 by Michael.Noland
AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset
Change 3518818 by Michael.Noland
Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas()
#rnx
Change 3518822 by Michael.Noland
Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set
Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set
Change 3518824 by Michael.Noland
Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time
Change 3519073 by Michael.Noland
QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method
Change 3519076 by Michael.Noland
Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world)
#rnx
Change 3519079 by Michael.Noland
Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index
Change 3519081 by Michael.Noland
Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet)
Change 3519082 by Michael.Noland
VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor
Change 3519084 by Michael.Noland
Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set
Change 3521889 by Michael.Noland
Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above)
#rnx
Change 3521987 by Michael.Noland
Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig
Change 3522101 by Michael.Noland
Physics: Improved the comment on UPhysicalMaterial::Friction
#rn
Change 3522105 by Michael.Noland
Physics: Fixed a few crashes in UVehicleWheel when spawned directly
Change 3522106 by Michael.Noland
Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time
Change 3522109 by Michael.Noland
Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places
Change 3522121 by Michael.Noland
Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest)
Change 3522783 by Zak.Middleton
#ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before).
Change 3525477 by Dan.Oconnor
Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared
Change 3526538 by Ben.Zeigler
Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks
Copy of CL #3526501
Change 3526817 by Ben.Zeigler
#jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed
Change 3526873 by Ben.Zeigler
#jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is
Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector
Change 3526958 by Marc.Audy
(4.17) Don't copy and then break pin links when reconstructing. Instead simply move.
#jira UE-46935
Change 3528916 by Marc.Audy
PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes)
#jira UE-45347
Change 3529080 by mason.seay
BP asset for undetermined type bug
Change 3529381 by Marc.Audy
Fix ability to insert duplicates in to a set or map
Change 3529471 by Dan.Oconnor
Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc()
Change 3530876 by Marc.Audy
Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist)
Also refactored MakeArray/Set to share a base MakeContainer class
Cleaned up some dead code from MakeArray
Added icon for MakeSet
Added Functional Test for MakeSet
#jira UE-43717
Change 3531070 by Phillip.Kavan
#jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded.
Change summary:
- Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP.
Change 3531081 by Marc.Audy
Remove deprecated CustomMapParamValue code
Change 3531094 by Phillip.Kavan
#jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty.
Change summary:
- Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer.
Change 3531186 by Phillip.Kavan
Back out changelist 3531094 (temp CIS fix).
#rnx
Change 3532082 by Marc.Audy
Move garbage collection timers and other management to UEngine instead of UWorld
Fixes CollectGarbage blueprint node not working in shipping
#jira UE-46566
Change 3532134 by Phillip.Kavan
Restored changelist 3531094 w/ fix for non-unity.
- Mirrored from //UE4/Release-4.17 (CL# 3531232).
#rnx
Change 3533009 by Marc.Audy
Fixup missing function and deprecation warnings
Change 3534056 by Marc.Audy
(4.17) Fix expose on spawn of map and sets to work
#jira UE-47140
Change 3534761 by Marc.Audy
(4.17) Apply code review changes to Dev-Framework as well
#rnx
Change 3535147 by Dan.Oconnor
Build fix, already made in 4.17
#rnx
Change 3535530 by mason.seay
Resaving to remove error when opening level blueprint
Change 3535581 by Marc.Audy
Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does.
#jira UE-46533
Change 3535583 by Marc.Audy
When properties are imported in to a child actor component the cached instance data is invalidated, so clear it.
#jira UE-46533
Change 3535617 by Marc.Audy
PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist)
#jira UE-47188
#jira UE-39237
Change 3535671 by Marc.Audy
Change NodeFactory to look at interface to use sequence node instead of each node having to add itself
Change 3535955 by Marc.Audy
Prevent MakeSet from removing split pins
Change 3536114 by Michael.Noland
Paper2D: Removing deprecated code from 4.3/4.4 era
#rnx
Change 3536120 by Michael.Noland
Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header
Change 3536124 by Michael.Noland
Physics: Removed deprecated methods that were replaced by _AssumesLocked variations
Change 3536131 by Michael.Noland
Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it
Change 3536138 by Michael.Noland
Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536167 by Dan.Oconnor
When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager
#jira UE-46904
Change 3536221 by Michael.Noland
Editor: Removing deprecated code from 4.9 or earlier
Change 3536240 by Michael.Noland
Blueprints: Removed long-deprecated TypeToString method from the K2 schema
#rnx
Change 3536243 by Michael.Noland
AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method
Change 3536244 by Michael.Noland
Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now
Change 3536250 by Michael.Noland
CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536253 by Michael.Noland
Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536310 by Michael.Noland
Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536397 by Mieszko.Zielinski
Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4
#jira UE-46860
Change 3536404 by Michael.Noland
Platform: Added a warning for others when they try to remove this 'deprecated' method
Change 3536639 by Michael.Noland
CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent
#rnx
Change 3536893 by Michael.Noland
Blueprints: Clear the stale value on the value pin when a map find node fails to find an item
#jira UE-47233
Change 3536902 by Michael.Noland
Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints
#rnx
Change 3537038 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537039 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538246 by Michael.Noland
UnrealTournament: Fixing issues with renamed enum
#rnx
Change 3538618 by Ben.Zeigler
Fix ensure when closing sequencer transform UI
Change 3540213 by Ben.Zeigler
#jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0.
Change 3540253 by Marc.Audy
Only copy default values for input pins as output pins do not have them
#rnx
Change 3540376 by Marc.Audy
Add utility FromPinType for FEdGraphTerminalType
#rnx
Change 3540433 by Marc.Audy
Add MakeMap
#jira UE-47093
Unify IsConnectionDisallowed for containers and fix static analysis warning
#jira UE-47291
Change 3540585 by Phillip.Kavan
#jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject.
Change 3541147 by Dan.Oconnor
Fix for not being able to override custom events when using the compilation manager post 3536167
#jira UE-47292
#rnx
Change 3541177 by Ben.Zeigler
#jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package
Copy of CL #3541027
Change 3541325 by Dan.Oconnor
K2node data table data needs to preload data before the compilation queue is flushed
#rnx
#jira UE-47319
Change 3541409 by Michael.Noland
Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager
#jira UE-47322
[reimplementing CL# 3541404 in Dev-Framework]
Change 3541418 by Dan.Oconnor
Fix for bad SKEL_ CDO reference in blueprint bytecode
#jira UE-47265
#rnx
Change 3541482 by Dan.Oconnor
Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints
#rnx
#jira UE-47319
Change 3541817 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3542299 by Michael.Noland
Blueprints: Speculative fix for static analysis warning
#rnx
Change 3542406 by Marc.Audy
Use a check slow to avoid any cost
#rnx
Change 3542486 by Michael.Noland
Asset Manager: Removing an unnecessary ensure (it's a potentially expected case)
#jira UE-47380
Change 3542659 by Michael.Noland
Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place
#jira UE-47385
Change 3543620 by Dan.Oconnor
Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile
#jira UE-47415
#rnx
Change 3518415 by Ben.Zeigler
#jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure
Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases
Change 3534339 by Michael.Noland
Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code
[CL 3544050 by Marc Audy in Main branch]
Jack Porter
Ben Marsh
Lina Halper
Max Chen
Marc Audy
Simon Tourangeau
Thomas Sarkanen
Andrew Grant
Matt Kuhlenschmidt
Ben Zeigler
Ori Cohen