Commit Graph

197 Commits

Author SHA1 Message Date
zahra nikbakht
cd424c4e53 Prevent activating context when HWND is destroyed.
bug: we call activate context immediately after the window is destroyed, and the window pointer is stilll not null. We have also destroyed HWND at this point through the microsoft function ::DestroyWindow, so we check ::IsWindowEnabled as a way to confirm the validity of HWND.
#jira UE-186416
#rb vincent.gauthier

[CL 25954162 by zahra nikbakht in ue5-main branch]
2023-06-13 12:02:34 -04:00
nicolas mercier
d0256f9166 Fix shutdown crash when using AddressSanitizer. The crash happens in AtExit deep in external DLLs, so instead disable TextInput altogether.
#rb [at]daniele.vettorel
#rnx

[CL 25647144 by nicolas mercier in ue5-main branch]
2023-05-26 12:49:52 -04:00
yuriy odonnell
5e26ac175f Only update stored console window width/size in SIZE_RESTORED and SIZE_MAXIMIZED
* Fixes a bug where invalid window dimensions would be stored in the .ini file if application is closed while the console is minimized

#rb Devin.Doucette
#preflight 646542554404e3cdd241a3fc

[CL 25518737 by yuriy odonnell in ue5-main branch]
2023-05-17 19:12:15 -04:00
bernard lambert
be2b61c941 Added a console variable to control if we should use an invisible cursor instead of setting the HCursor to NULL when the cursor type is set to None.
#RB [at]Camille.Gendreau [at]Ghislain.Theriault [at]Fourat.Jellouli [at]Bob.Tellez

[CL 24913211 by bernard lambert in ue5-main branch]
2023-04-04 12:56:18 -04:00
henrik karlsson
d3c4095c18 [Engine]
* WindowsConsoleOutputDevice2 - Fixed clang compile error by renaming parameter (shadowing variable)

#preflight skipped
#rb none

[CL 24873621 by henrik karlsson in ue5-main branch]
2023-03-31 12:29:47 -04:00
William Belcher
7591296349 Add a null platform for use when rendering off screen.
#rb
#jira UE-169493, UE-180546
#preflight https://horde.devtools.epicgames.com/job/6424d325710ec8400f989208
#fyi

[CL 24849011 by William Belcher in ue5-main branch]
2023-03-29 20:46:03 -04:00
Jeff Fisher
64403c6f95 UE-181471 Delete SteamVR plugin.
-Deprecated in 5.1.  OpenXR should be used instead.
-A few instances of the string "SteamVR" remain.  In some case we are comparing to the OpenXR Runtime name, which remains correct.  In some we are searching input profile paths for SteamVR, which also remains correct.  VRScouting is doing the input profile path and then overriding VREditor's view of the xr plugin name, so at first glance VREditor still seems to be using SteamVR, but it actually does not depend on that (That code will likely be further refactored as time goes on).
#jira UE-181471
#preflight 64233be9803cb466e86ad33c
#review
#rb Arciel.Rekman

[CL 24825198 by Jeff Fisher in ue5-main branch]
2023-03-28 15:55:51 -04:00
scott nelson
dbecf2ef2d Update WindowsPlatformSplash to allow setting custom text before calling Show()
#rb Dave.Belanger
#preflight 63f3d9d71d71bcd2624b51df

[CL 24327592 by scott nelson in ue5-main branch]
2023-02-20 17:10:12 -05:00
devin doucette
14a2e7482d Logging: Updated Windows and Linux feedback contexts to support structured logging
This sets up the base FFeedbackContext to do most of the work because there is very little behavioral difference between platforms, yet the majority of the code is duplicated for each platform.

#jira UE-152840
#preflight 63b45fe435203bc7aab23837
#rb Zousar.Shaker
#rnx

[CL 23567792 by devin doucette in ue5-main branch]
2023-01-03 13:07:24 -05:00
danny couture
3ef112d160 Prefer using Windows functions to get user32.dll to follow best practices and avoid a LoadLibrary with an absolute path
#rnx
#jira UE-170763
#rb Francis.Hurteau
#preflight 6380109418176c67c230c0cb

[CL 23287243 by danny couture in ue5-main branch]
2022-11-28 07:30:42 -05:00
danny couture
624b970cdb Add more info to the log when the createwindow function fails and remove unlocalized messagebox that was highly likely to fail to show a window anyway
#rnx
#jira UE-168160
#rb Martin.Sevigny
#preflight 6374e8e1232e3d12cb2a5c25

[CL 23153330 by danny couture in ue5-main branch]
2022-11-16 09:09:41 -05:00
joe pribele
1d8537f20b changed PRAGMA_DISABLE_OPTIMIZATION to UE_DISABLE_OPTIMIZATION_SHIP
#preflight 6372ba60ee4d25f90ae3d207

[CL 23128414 by joe pribele in ue5-main branch]
2022-11-14 17:31:05 -05:00
pj kack
7a12aa6728 TSet & TMap: Make sure any dynamic hash allocation is released when Empty() is called without additional slack.
Memory improvements on top of performance improvements in 11535961.
Allow the hash allocation to shrink for calls to Empty(), Shrink(), Compact() and CompactStable().
Let TSparseArray::Compact() shrink the data array just as for Shrink() and CompactStable().
Note: The private function TSet::ShouldRehash() is only called from Empty() and ConditionalRehash(), and ConditionalRehash() with bAllowShrinking=true is only called from Relax() via Shrink(), so there should be no impact on other/growth scenarios.
Modify GetAllocatedSize() for TSet, TMap and TSparseArray to only return any dynamically allocated size from the underlying allocators and change return type from uint32 to SIZE_T (just as for TArray and FContainerAllocatorInterface).

#rb johan.torp,steve.robb
#preflight 634952f4ce524ed356dafde7, 63496f80f622f6c4bb1c0321, 634d65df9c29024c982ecf26

[CL 22595144 by pj kack in ue5-main branch]
2022-10-18 04:03:13 -04:00
patrick laflamme
aae0e9dd6a Fixed CIS non-unity ShaderCompileWorker errors reported in WindowsPlatformSplash.cpp.
#jira none
#rb trivial
#preflight trivial

[CL 22145756 by patrick laflamme in ue5-main branch]
2022-09-22 17:35:23 -04:00
patrick laflamme
9fc1447777 Fixed deadlock in the splash screen happening when the main thread goes faster than the splash screen and try to hide the splash before the splash screen thread even created the window.
#jira UE-161578 - Game stuck on splash screen
#rb Vincent.Gauthier
#preflight 632b651a7b582f58abe53440

[CL 22140481 by patrick laflamme in ue5-main branch]
2022-09-22 14:07:38 -04:00
rex hill
737c7c6832 Fix DebugConsole.ini so it is placed in /Engine/Saved/Config instead of /Engine/Config
#preflight skip

[CL 22067866 by rex hill in ue5-main branch]
2022-09-17 15:27:55 -04:00
henrik karlsson
ec949d0e71 [ApplicationCore]
* WindowsConsoleOutputDevice2 - Changed ::SetThreadDescription to use wrapped function that does not depend on new versions of windows runtime

#rb Mitchell.Fisher

[CL 21998832 by henrik karlsson in ue5-main branch]
2022-09-13 22:43:48 -04:00
rex hill
f6a8d68d78 Moved DebugConsole.ini to EngineUserDir's /Config/DebugConsole.ini
#preflight 63209b46e93a80888c4490d5

[CL 21997832 by rex hill in ue5-main branch]
2022-09-13 21:50:16 -04:00
bryan sefcik
07894f4a07 Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631a717cec45fbf3d74d4ba7

[CL 21916033 by bryan sefcik in ue5-main branch]
2022-09-09 00:53:22 -04:00
henrik karlsson
1437dc5521 [Core Runtime - WindowsConsoleOutputDevice2]
* Fixed buggy datetime output.
* Added so shell execute can be done from activity texts. Just add [<command>] to the activity and the command(s) will execute the command when clicking on the activity. Example [https://someurl] will trigger the browser to open the linik

#rb self
#preflight 63191935980179553e9ba3ac

[CL 21907370 by henrik karlsson in ue5-main branch]
2022-09-08 19:30:45 -04:00
Marc Audy
1bb2a63925 Fix implicit conversion warnings
#rnx
#preflight 630e8ad3660db81edb9ea2d5

[CL 21711473 by Marc Audy in ue5-main branch]
2022-08-30 18:28:30 -04:00
henrik karlsson
7f83b2ea47 [Core Runtime]
* WindowsConsoleOutputDevice2.cpp - Fixed bug where activities added before output device itself didn't align Info types to the right

#preflight skipped
#rb self

[CL 21511709 by henrik karlsson in ue5-main branch]
2022-08-23 12:57:26 -04:00
henrik karlsson
e7eb15f0b9 [Runtime]
* TrackedActivity - Added sort value parameter when creating tracked activities
* WindowsConsoleOutputDevice2 - Added sorting of activities based on sort value.
* WindowsConsoleOutputDevice2 - Added show/hide timedate options to log context menu

#preflight 62fbbda3ad3bd8ad64558579
#rb self

#ROBOMERGE-AUTHOR: henrik.karlsson
#ROBOMERGE-SOURCE: CL 21409829 via CL 21416523 via CL 21416533 via CL 21416553
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v975-21357124)

[CL 21418243 by henrik karlsson in ue5-main branch]
2022-08-16 20:22:38 -04:00
devin doucette
eb55a547d0 Fixed unsafe type casts in a few widely-used modules
#preflight 62f72b49185b21882ac5c366
#rb Steve.Robb
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 21404445 via CL 21404453 via CL 21404464
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v975-21357124)

[CL 21407133 by devin doucette in ue5-main branch]
2022-08-16 12:35:53 -04:00
andrew scheidecker
17063a9ca3 Fix static analysis error in FWindowsConsoleOutputDevice2::FConsoleWindow::Start: CreateThread can return null, and SetThreadDescription should not be passed a null thread, so the result of CreateThread must be checked for null before calling SetThreadDescription.
#rb Henrik.Karlsson
#preflight 62f25a363b773d041625dc36

#ROBOMERGE-AUTHOR: andrew.scheidecker
#ROBOMERGE-SOURCE: CL 21286684 via CL 21293019 via CL 21293280 via CL 21293393
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21296406 by andrew scheidecker in ue5-main branch]
2022-08-09 15:44:26 -04:00