Commit Graph

312 Commits

Author SHA1 Message Date
patrick boutot
50aed20739 Revert properties or functions compile time test introdued with CL 24208984
[CL 24215611 by patrick boutot in ue5-main branch]
2023-02-14 13:03:02 -05:00
patrick boutot
7dd604438f MVVM: Test if the properties or functions are allowed at compile time.
#jira UE-164316
#preflight 63eaf47eb91ae11c1cf4ded7

[CL 24213905 by patrick boutot in ue5-main branch]
2023-02-14 12:07:02 -05:00
patrick boutot
b07e5d8af0 MVVM: Do not reset viewmodel pointer when not needed.
[REVIEW] byron.cornejo

[CL 24197533 by patrick boutot in ue5-main branch]
2023-02-13 20:10:30 -05:00
patrick boutot
e5eba78f6f MVVM: Delayed bindnig were ticked by a world. If the widget changed world, the binding might not be ticked anymore.
#preflight 63e9864da24b861df931ff76

[CL 24175223 by patrick boutot in ue5-main branch]
2023-02-13 10:38:22 -05:00
patrick boutot
e8291c18bd MVVM: Veriry the allowed list when picking a property/function from the field selector.
#jira
#preflight 63e6975bf8244e55a4bab8ed

[CL 24173369 by patrick boutot in ue5-main branch]
2023-02-13 08:39:55 -05:00
patrick boutot
f366a0769c MVVM: Fix bad else case when the allowed and disallowed list is used.
#jira UE-164316

[CL 24137186 by patrick boutot in ue5-main branch]
2023-02-11 12:41:40 -05:00
patrick boutot
2758a900b9 MVVM: Rename ViewModelResolver to ViewModelContextResolver
#jira UE-171160
#preflight 63e67449bd38b4c5cbe7374e

[CL 24136977 by patrick boutot in ue5-main branch]
2023-02-11 12:38:02 -05:00
patrick boutot
0d838c4210 MVVM: Filter Viewmodel context creation type per class. Use MVVMAllowedContextCreationType or MVVMDisallowedContextCreationType to allow or disallow types.
UCLASS(meta=(MVVMAllowedContextCreationType="Manual|CreateInstance"))
#jira UE-164316
#preflight 63e5ad91f15c83b793edc3c3

[CL 24119664 by patrick boutot in ue5-main branch]
2023-02-10 10:45:24 -05:00
patrick boutot
136813f938 UMG: Add setting to disable UMG binding.
#jira UE-164316
#preflight 63e455505c0ce8f11b0acb51

[CL 24106280 by patrick boutot in ue5-main branch]
2023-02-09 16:22:43 -05:00
patrick boutot
213eb80530 MVVM: Allow picking selecting an abstract class in as the viewmodal in UMG View but you are not able to create an instance.
Add a new way to select the viewmodel uses by the UMG View. User can extend the Resolver and can implement their own logic.
#jira UE-171160
#rb devan.england, sebatian.nordgren
#preflight 63e412003c44c83044e73fe4

[CL 24100372 by patrick boutot in ue5-main branch]
2023-02-09 12:14:47 -05:00
patrick boutot
f2cfd4e83f MVVM: Add setting to find conversion functions.
#jira UE-164316
#preflight 63e3a287e042058d698ba8b4

[CL 24074931 by patrick boutot in ue5-main branch]
2023-02-08 12:16:32 -05:00
patrick boutot
aa9a64a17f MVVM: Add customization for Viewmodel context. Add picker for the propertypath.
#rb sebastian.nordgren
#preflight 63e2a6ae9910415ae2016818

[CL 24061758 by patrick boutot in ue5-main branch]
2023-02-07 17:51:50 -05:00
patrick boutot
98102a7ef3 MVVM: Test the function as regular conversion function and complex to get the property type.
#jira UE-175677

[CL 24044260 by patrick boutot in ue5-main branch]
2023-02-06 21:44:10 -05:00
patrick boutot
6fa51a1ac3 MVVM: Remove the viewmodel editor from the build.
#rb yohan.dossantos
#preflight 63db87323f475e061ff89ede

[CL 24029419 by patrick boutot in ue5-main branch]
2023-02-06 09:20:10 -05:00
patrick boutot
f9a847ada3 MVVM: Remove old and unused widgets.
#preflight 63da5dc58505ea6b1ff9b8af

[CL 23948415 by patrick boutot in ue5-main branch]
2023-02-01 10:34:45 -05:00
patrick boutot
aa96bf075e MVVM: Move GlobalCollection to GameInstance subsystem.
#preflight 63d94e8b31334253e597fec0

[CL 23938784 by patrick boutot in ue5-main branch]
2023-01-31 17:03:58 -05:00
patrick boutot
02810ce5c5 Revert //Fortnite/Release-23.40/Engine/Plugins/Runtime/ModelViewViewModel/Source/... changelist 23926202
[CL 23927498 by patrick boutot in ue5-main branch]
2023-01-31 10:40:05 -05:00
patrick boutot
eeb3c16fca MVVM: Add a allowed ExecutionMode list.
Move GlobalCollection to GameInstance subsystem.
Rename category from MVVM to Viewmodel.
#preflight 63d5e0bcba4fadeef09bdfc2

[CL 23927160 by patrick boutot in ue5-main branch]
2023-01-31 10:21:03 -05:00
jordan hoffmann
31b04b24ba [Feature/Bugfix] Support for diffing against nullptr (treated as an empty or nonexistent file)
#rb dan.oconnor
#preflight 63d83f963656ea96dc2a0a4c

#jira UE-173747
"Crash occurs when scrolling down through files in Review Changelist window upon loading of asset"
  - certain widget blueprints were crashing the review tool because we were working around the inability to diff against nullptr by constructing temprorary empty objects. This approach circumvents that problem entirely

#jira UE-173231
"Changelist Review tool allows diffing against previous revision for Deletion changes"
  - while this jira suggests that the ability to diff deletion changes is a bug, it was actually an intended feature. The real bug was that it would crash or fail to work in many cases. This has been fixed by either asset diffing against nullptr or text diffing against an empty file (depending on circumstance)

#jira UE-174610
"Reviewing Changelist with Deletion Changes results in LogLinker warnings & LoadErrors"
 - deletion changes were trying to load the new revision of files but obviously it doesn't exist because it's a deletion. Fixed by only loading the previous revision


note: since the review tool is going to be "Production Ready"  in 5.2, these changes are neccesary for stability

[CL 23924072 by jordan hoffmann in ue5-main branch]
2023-01-31 01:28:46 -05:00
henrik karlsson
9a1d5b1ad4 [Engine/Plugins]
* Ran IWYU on ~170 plugins to remove includes not needed. Public api still keep old includes inside #if UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2

#preflight 63d09351574ab9cae4670216
#rb none

[CL 23844750 by henrik karlsson in ue5-main branch]
2023-01-25 02:42:36 -05:00
patrick boutot
b54ff37589 MVVM: Use the class display name in the select viewmodel menu.
[REVIEW] sebastian.nordgren

[CL 23814940 by patrick boutot in ue5-main branch]
2023-01-23 12:20:36 -05:00
sebastian nordgren
eccc28e691 Fixed static analysis warning about null Pin in SMVVMFunctionParameter.cpp.
#rb trivial
#preflight 63ce752ed83c1837b1182cc0

[CL 23809665 by sebastian nordgren in ue5-main branch]
2023-01-23 07:08:46 -05:00
patrick boutot
588d345112 MVVM: Always include the viewmodel macro when including the base class.
#rnx

[CL 23798566 by patrick boutot in ue5-main branch]
2023-01-20 17:43:36 -05:00
patrick boutot
8b0766ff17 MVVM: Fix bad access to raw pointer.
#rb sebastian.nordgren

[CL 23774542 by patrick boutot in ue5-main branch]
2023-01-19 11:26:11 -05:00
henrik karlsson
9183978e29 [Engine/Plugins]
* Removed includes (using IWYU) in private files

#preflight 63c79978ac35a0e9dabbe408
#rb none

[CL 23770038 by henrik karlsson in ue5-main branch]
2023-01-19 00:48:07 -05:00