Commit Graph

2972 Commits

Author SHA1 Message Date
brandon schaefer
e9e793edd3 Add custom delete operator to match the allocating new operator, so that FField objects get properly deleted when delete is called on them. Otherwise, if building with FORCE_ANSI_MALLOC, which does not define custom global new or delete operators, they will use the system global delete operator, which is not the same as calling FMalloc::Free, causing ASan to report an allocator mismatch error.
Cherry pick CL 11115703

#jira UE-82504
#rb none
[FYI] halfdan.ingvarsson


#ROBOMERGE-SOURCE: CL 11522981 via CL 11522990 via CL 11523002
#ROBOMERGE-BOT: (v654-11333218)

[CL 11525199 by brandon schaefer in Main branch]
2020-02-18 17:22:12 -05:00
dan oconnor
98628be41e ExpandEnumAsExecs now works with bool parameters, added ExpandBoolAsExecs synonym
#rb Phllip.Kavan
#jira UE-89057


#ROBOMERGE-SOURCE: CL 11522401 via CL 11522407 via CL 11522423
#ROBOMERGE-BOT: (v654-11333218)

[CL 11525131 by dan oconnor in Main branch]
2020-02-18 17:21:46 -05:00
sebastien lussier
e145d4fb60 Integrate CL 11418990 from Dev-Editor
PostEditChange should not be called on unchanged archetype instances
#jira UE-87829
#rb marc.audy

#ROBOMERGE-SOURCE: CL 11458955 in //UE4/Release-4.25/... via CL 11458957
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v654-11333218)

[CL 11462218 by sebastien lussier in Main branch]
2020-02-17 14:20:40 -05:00
dan oconnor
4302382842 Add missing property wrapper type for blueprint event dispatcher's details customizations
#rb Phillip.Kavan
#jira UE-88800


#ROBOMERGE-SOURCE: CL 11461555 via CL 11461556 via CL 11461559
#ROBOMERGE-BOT: (v654-11333218)

[CL 11461631 by dan oconnor in Main branch]
2020-02-17 13:39:36 -05:00
sebastien lussier
1dcdb05a0e Integrate CL 11418990 from Dev-Editor
PostEditChange should not be called on unchanged archetype instances
#jira UE-87829
#rb marc.audy

#ROBOMERGE-SOURCE: CL 11458955 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11458957 by sebastien lussier in 4.25-Plus branch]
2020-02-17 07:05:43 -05:00
arciel rekman
2ce92e463c Fix async loading weirdness causing crashes (FORT-247120).
- RobManuszewski's change, reverting CLs 7799323 and 8224969
#rb Robert.Manuszewski (authored)


#ROBOMERGE-SOURCE: CL 11458363 via CL 11458497 via CL 11458505 via CL 11458513
#ROBOMERGE-BOT: (v654-11333218)

[CL 11458525 by arciel rekman in Main branch]
2020-02-17 01:29:00 -05:00
dan oconnor
fb6d6ce510 Mirror 11452607
Fix crash when compiling blueprints when other blueprints reference the properties of that blueprint
#rb Ethan.Geller, Joe.Conley
#rnx
#jira UE-88820

#ROBOMERGE-SOURCE: CL 11452936 in //UE4/Release-4.25/... via CL 11452948
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v654-11333218)

[CL 11452974 by dan oconnor in Main branch]
2020-02-14 19:31:23 -05:00
dan oconnor
f2ff5520cb Mirror 11452607
Fix crash when compiling blueprints when other blueprints reference the properties of that blueprint
#rb Ethan.Geller, Joe.Conley
#rnx
#jira UE-88820

#ROBOMERGE-SOURCE: CL 11452936 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11452948 by dan oconnor in 4.25-Plus branch]
2020-02-14 19:30:52 -05:00
Matt Peters
40f55732ba #jira FORT-236167
[REVIEW]
#rb Graeme.Thornton
Optimize Pak file indices by computing the PathHashIndex in unrealpak rather than using strings at runtime.
This also removes the need to shrink the string indices for performance, which was triggering a bug due to unsynchronized multithreaded access.

#ROBOMERGE-SOURCE: CL 11442058 in //Fortnite/Release-12.00/... via CL 11442063 via CL 11442073 via CL 11442081

[CL 11443295 by Matt Peters in Main branch]
2020-02-14 09:53:05 -05:00
robert manuszewski
1054a0ab1e Significantly improving MarkObjectsAsUnreachable phase of GC in scenarios where there's many root objects (like in the editor).
Before:
LogGarbage: Verbose: 24.557600 ms for Mark Phase (22485 Objects To Serialize)

After:
LogGarbage: Verbose: 0.290700 ms for Mark Phase (22485 Objects To Serialize)

#rb Steve.Robb


#ROBOMERGE-SOURCE: CL 11439833 via CL 11439841 via CL 11439845
#ROBOMERGE-BOT: (v654-11333218)

[CL 11439847 by robert manuszewski in Main branch]
2020-02-14 04:18:14 -05:00
dan oconnor
39d7e3030a Correct bad TMap related logic in ResolvePlaceholderValues - this could cause a crash when resolving placeholders in a TMap
#rb Marc.Audy
#jira


#ROBOMERGE-SOURCE: CL 11431610 via CL 11431614 via CL 11431616
#ROBOMERGE-BOT: (v654-11333218)

[CL 11431619 by dan oconnor in Main branch]
2020-02-13 19:49:39 -05:00
Rolando Caloca
5b82f15def Copying //UE4/Dev-RenderPlat-Staging@11388153 to //UE4/Main
#rb none
#rnx

[CL 11388545 by Rolando Caloca in Main branch]
2020-02-12 13:27:19 -05:00
robert manuszewski
a3d79a6bb5 Workaround for Static Analysis false warnings
#rb none


#ROBOMERGE-SOURCE: CL 11374486 via CL 11374498
#ROBOMERGE-BOT: (v654-11333218)

[CL 11374506 by robert manuszewski in Main branch]
2020-02-12 03:59:34 -05:00
carlmagnus nordin
0f242a77c2 Guard against recursive calls to FTaskGraphInterface::ProcessThreadUntilIdle during async loading
#rb per.larsson
#ushell-cherrypick of 11327342 by CarlMagnus.Nordin


#ROBOMERGE-SOURCE: CL 11373304 via CL 11373313 via CL 11373318
#ROBOMERGE-BOT: (v654-11333218)

[CL 11373323 by carlmagnus nordin in Main branch]
2020-02-12 02:28:06 -05:00
zousar shaker
a51516d88a Avoid calling FixPackageNameCase in GetPackageLinker if the package already exists. This causes FixPackageNameCase to go from 5m8s total time in a large dataset cook to 22s total time for a total time savings of 4m46s.
#rb devin.doucette


#ROBOMERGE-OWNER: zousar.shaker
#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 11358823 via CL 11358846 via CL 11358863
#ROBOMERGE-BOT: (v654-11333218)

[CL 11358970 by zousar shaker in Main branch]
2020-02-11 16:51:55 -05:00
nick darnell
cdd3165da9 Editor - Giving the details panel the ability to filter the values as well (before we only filtered based on the name of properties and any custom filter strings coming from the customization. Now the values themselves are considered when filtering so that if you've referenced an asset or have some text property, you can search for specific text, or the asset name to see where it has been set.
#rb Matt.Kuhlenschmidt
[FYI] Matt.Kuhlenschmidt


#ROBOMERGE-OWNER: nick.darnell
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 11358089 via CL 11358143 via CL 11358189
#ROBOMERGE-BOT: (v654-11333218)

[CL 11358651 by nick darnell in Main branch]
2020-02-11 16:46:12 -05:00
graeme thornton
bccff5663b Allowing nested struct properties to be resolved with FProperties in linker placeholder classes (required for cooked bluerprints in the editor)
[FYI] robert.manuszewski
#rnx


#ROBOMERGE-SOURCE: CL 11341706 via CL 11350710 via CL 11350968
#ROBOMERGE-BOT: (v654-11333218)

[CL 11351181 by graeme thornton in Main branch]
2020-02-11 14:40:21 -05:00
Stefan Boberg
e42662ddbe Fixed some SA annotations
#jira UE-88514
#rb robert.manuszewski

#ushell-cherrypick of 11341708 by Stefan.Boberg

[CL 11341718 by Stefan Boberg in Main branch]
2020-02-11 12:28:56 -05:00
Robert Manuszewski
b3162ad373 Reimplementing CL #11341031
Fixing TFieldPaths resolving themselves against the provided struct too aggresively (the behavior changed in CL #11315165)

#rb Steve.Robb
#jira UE-88519

[CL 11341318 by Robert Manuszewski in Main branch]
2020-02-11 11:15:34 -05:00
robert manuszewski
1d98180074 Making sure FFieldPath is reset before generating a path from a string
#rb none


#ROBOMERGE-SOURCE: CL 11315642 via CL 11316722 via CL 11317038
#ROBOMERGE-BOT: (v653-11302973)

[CL 11317919 by robert manuszewski in Main branch]
2020-02-10 19:37:18 -05:00
bob tellez
34ca31b23a Merging CL#11315165
Making sure UAnimBlueprintGeneratedClass::EvaluateGraphExposedInputs' ValueHandlerNodeProperties are properly resolved against their class which can be in a renamed package when loading.

+ TFieldPaths will now always try and use the provided struct when resolving themselves and update its path with the resolved package if it's different to the existting (serialized) value so that when they are re-resolved next time they will still point to the class in renamed package

#rb Dan.OConnor


#ROBOMERGE-AUTHOR: Robert.Manuszewski
#ROBOMERGE-SOURCE: CL 11315207 via CL 11316246
#ROBOMERGE-BOT: (v653-11302973)

[CL 11316418 by bob tellez in Main branch]
2020-02-10 19:21:35 -05:00
jon nabozny
51ec2bd5e8 Don't add multiple entries for the same c-style array property in the Class Net Cache.
[at]Ryan.Gerleve, [at]Brian.Bekich
#rb Brian.Bekich


#ROBOMERGE-SOURCE: CL 11314025 via CL 11316181
#ROBOMERGE-BOT: (v653-11302973)

[CL 11316330 by jon nabozny in Main branch]
2020-02-10 19:20:30 -05:00
Ben Marsh
ac9404784c Fix for warning after upgrading to PVS-Studio 7.0.4:
V501: There are identical sub-expressions 'TPointerIsConvertibleFromTo < T, TOther >::Value' to the left and to the right of the '||' operator.

#codereview Robert.Manuszewski
#rb none
#rnx

[CL 11311592 by Ben Marsh in Main branch]
2020-02-10 16:19:26 -05:00
Ben Marsh
0d1505957f Fix for warning after upgrading to PVS-Studio 7.0.4:
V501: There are identical sub-expressions 'TPointerIsConvertibleFromTo < PropertyType, OtherPropertyType >::Value' to the left and to the right of the '||' operator.

#codereview Robert.Manuszewski
#rb none
#rnx

[CL 11311580 by Ben Marsh in Main branch]
2020-02-10 16:17:28 -05:00
robert manuszewski
b938e59c9b Reimplementing FProperty changes from //UE4/Main
+ Reimplemented FProperty related fixed from //UE4/Main:
CL#10791312, 10804850, 10851666, 10855122, 10855198, 10942138, 11030611, 11030639, 11032261, 11061515, 11136964,11138881, 11214238, 11214865

#rb none (previously reviewed in Dev-Core)
[FYI] Chris.Bunnner, Daniel.Lamb


#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 11302985 via CL 11303011 via CL 11303019
#ROBOMERGE-BOT: (v0-11244347)

[CL 11303183 by robert manuszewski in Main branch]
2020-02-10 08:06:56 -05:00