Commit Graph

10325 Commits

Author SHA1 Message Date
devin doucette
c2a46c2242 DDC: Fixed a test failure for small values in the file system cache
#jira UE-141632
#preflight 6202b6c9bf28c072cbf308ce
#lockdown Mark.Lintott
#rb Matt.Peters
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18909346 in //UE5/Release-5.0/... via CL 18909604 via CL 18909733
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v915-18905420)

[CL 18909753 by devin doucette in ue5-main branch]
2022-02-08 16:07:34 -05:00
devin doucette
2ae070347f DDC: Fixed a memory leak in the cache
#jira UE-141335
#preflight 620294f5bd4f846436e5f4c6
#lockdown Mark.Lintott
#rb Matt.Peters
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18903655 in //UE5/Release-5.0/... via CL 18903892 via CL 18904098
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v912-18901109)

[CL 18904146 by devin doucette in ue5-main branch]
2022-02-08 12:17:15 -05:00
patrick boutot
68d0f9cf48 Slate: Fix VerifyWidgetLayerId to only use the invalidation test when we painted in fast path. Add the VerifyOutgoingLayerId to the Widget Reflection test list.
#jira UE-136046
#rb none
#preflight 62017574384d6a94e8dc65bf

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18897351 via CL 18897352 via CL 18897354 via CL 18903428 via CL 18903856
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v912-18901109)

[CL 18903906 by patrick boutot in ue5-main branch]
2022-02-08 12:08:49 -05:00
benoit deschenes
20f7cc7d8c Datasmith Import - Fixing master material serialization error.
The EDatasmithMasterMaterialType::Emissive value was not added at the end of the enum, this caused the rest of the underlying values to shift in the enum, breaking existing .udatasmith file. To fix this, the "Emissive" value was moved to the end of the enum.

#jira UE-141684
#rb emil.kirichev
#preflight 6201907ce85c7a08bbc54f1c
#lockdown JeanMichel.Dignard

#ROBOMERGE-AUTHOR: benoit.deschenes
#ROBOMERGE-SOURCE: CL 18903268 in //UE5/Release-5.0/... via CL 18903336 via CL 18903535
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v912-18901109)

[CL 18903590 by benoit deschenes in ue5-main branch]
2022-02-08 11:55:43 -05:00
helge mathee
aa0046a09a Control Rig: Traverse sub pins of select nodes correctly when compiling
Fixed the case of float vs double for arrays - this was never working before apparently.

Also improved the warning message from the VM's memory backend:
Failed to copy uValuesWings (TArray<double>) to Rig_ArrayReset_Array__IO (TArray<float>) in package ...

#rb sara.schvartzman
#jira UE-141662
#preflight https://horde.devtools.epicgames.com/job/620264aabd4f846436da20fb
#lockdown juan.canada

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18901271 in //UE5/Release-5.0/... via CL 18901305 via CL 18901351
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v912-18901109)

[CL 18901353 by helge mathee in ue5-main branch]
2022-02-08 08:49:46 -05:00
ionut matasaru
3b4555fa96 [Insights]
- Changed CallstackId to 32 bits also for CallstacksProvider API.
  - Also fixed static analysis warning (false positive).

#rb Johan.Berg
#preflight 62023f0be85c7a08bbde4499

[CL 18900490 by ionut matasaru in ue5-main branch]
2022-02-08 05:54:58 -05:00
Martin Ridgers
33432ea349 No-unity compile fix.
#rb trivial
#rnx
#jira ue-141616
#preflight none

[CL 18899943 by Martin Ridgers in ue5-main branch]
2022-02-08 02:53:01 -05:00
zousar shaker
df06aa0d18 Allow for region pinning when connecting to Jupiter. Fix value printing error. Increase concurrent PUT operations from 2 to 4 when batching is enabled.
#preflight 6201d9c7384d6a94e8fc20d7
#jira UE-141733
#rb devin.doucette

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 18899614 in //UE5/Release-5.0/... via CL 18899644 via CL 18899680
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18899684 by zousar shaker in ue5-main branch]
2022-02-08 01:56:17 -05:00
devin doucette
c03d680063 DDC: Fixed propagation of cache values when a value policy contains SkipData
#jira UE-141576
#preflight 61fe001fdb3d0b17a933391c
#lockdown Mark.Lintott
#rb Zousar.Shaker
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18896581 in //UE5/Release-5.0/... via CL 18896633 via CL 18896789
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18897023 by devin doucette in ue5-main branch]
2022-02-07 20:06:56 -05:00
keith yerex
de7d1cb8ca make insights view toolbar extensible, and add a button for trace source filtering
#jira UE-137969
#rb ionut.matasaru
#preflight 2015e6f384d6a94e8d377bf

#ROBOMERGE-AUTHOR: keith.yerex
#ROBOMERGE-SOURCE: CL 18891733 in //UE5/Release-5.0/... via CL 18892094 via CL 18892519
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18892581 by keith yerex in ue5-main branch]
2022-02-07 15:50:30 -05:00
danny couture
dcff1b48cb Fix infinite wait on async compilation when in pause mode by using an unpausable priority when forced compilation is required to wait
#rb Francis.Hurteau
#jira ue-141319
#preflight 62010b324346561cadf30657
#lockdown mark.lintott

#ROBOMERGE-AUTHOR: danny.couture
#ROBOMERGE-SOURCE: CL 18886756 in //UE5/Release-5.0/... via CL 18886809 via CL 18887172
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18887216 by danny couture in ue5-main branch]
2022-02-07 12:22:00 -05:00
ionut matasaru
1502e84e56 Disabled Profiler if STATS is not enabled (so Editor can compile also when ENABLE_STATNAMEDEVENTS is on).
#jira UE-140874
#fyi Brandon.Schaefer
#preflight 6201451e6773a3612898bddb
#rb none

[CL 18886574 by ionut matasaru in ue5-main branch]
2022-02-07 11:35:37 -05:00
ionut matasaru
d2f594bb15 [Insights]
- Memory Insights: Added analysis support for "free callstack" for an allocation (i.e. callstack when an allocation if freed).
  - Memory Insights: Switched CallstackId to 32 bit and moved the resolving of "id to pointer" outside of mem queries. This allows us to add the second callstack id and also ids for future metadata without increasing the size of FAllocationItem struct (from AllocationProvider).
  - Memory Insights: Refactored code re ThreadId and Tracker passed from AllocationAnalysis to AllocationProvider.
  - Memory Insights: Refactored code re CallstackProvider to map a CallstackId directly as an index into array of callstacks.

#rb Johan.Berg
#preflight 6201460a6773a3612898c4de

[CL 18886419 by ionut matasaru in ue5-main branch]
2022-02-07 11:28:45 -05:00
Martin Ridgers
a14893efb5 Implementation of the set side of Zen's NamedEvent for Linux and Mac.
#rnx
#rb zs
#preflight 6201155b6f05911039b7a56b

[CL 18884380 by Martin Ridgers in ue5-main branch]
2022-02-07 07:56:00 -05:00
Martin Ridgers
6ed0f035cf Incorrect variable name in POSIX #if/def block.
#rb trivial
#preflight none
#rnx
#rb zs

[CL 18884365 by Martin Ridgers in ue5-main branch]
2022-02-07 07:53:22 -05:00
Michael Sartain
e63b3f3e86 Fix crash dereferencing garbage WritePtr in Linux
Running with:

   Engine/Binaries/Linux/UnrealEditor-Linux-Debug -logcmds="LogAnalytics VeryVerbose" -AnalyticsDisableCaching

Crashed on GetHandle() of invalid write pointer. Code introduced in CL 18846806.

#jira none
#fyi Josh.Adams
#rb none
#preflight trivial

[CL 18881507 by Michael Sartain in ue5-main branch]
2022-02-05 22:12:38 -05:00
chris babcock
c3b7dd3ac1 Add check for ro.soc.model for configrules chipset matching
#android
[REVIEW] [at]allan.Bentham
#rb Allan.Bentham


#ROBOMERGE-AUTHOR: chris.babcock
#ROBOMERGE-SOURCE: CL 18873658 via CL 18873743 via CL 18873954 via CL 18874009 via CL 18874051 via CL 18875184 via CL 18875889
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18875920 by chris babcock in ue5-main branch]
2022-02-04 18:00:13 -05:00
devin doucette
0818b14470 DDC: Fixed incorrect callbacks in put batches with failures
Also adds the intended inline allocators for arrays that were missing them.

#jira UE-134381
#lockdown Mark.Lintott
#preflight 61fd998ff370b0d3111fad17
#rb Matt.Peters
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18874174 in //UE5/Release-5.0/... via CL 18874208 via CL 18874924
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18874951 by devin doucette in ue5-main branch]
2022-02-04 17:24:08 -05:00
lukas hermanns
b0ab21cd71 Improve stability for out of bounds buffer slots in Metal backend.
#rb Will.Damon, Mihnea.Balta, Rolando.Caloca
#jira UE-138002
#preflight none
#rnx

#ROBOMERGE-AUTHOR: lukas.hermanns
#ROBOMERGE-SOURCE: CL 18865633 in //UE5/Release-5.0/... via CL 18865641 via CL 18868946
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18869017 by lukas hermanns in ue5-main branch]
2022-02-04 14:01:55 -05:00
dave jones2
ed1b4ed6a5 UE-140327 - Remove ENABLE_BLUEPRINT_REAL_NUMBERS usage
The original ENABLE_BLUEPRINT_REAL_NUMBERS macro was strictly meant for AB testing in the Dev-LWC. Currently, disabling it won't work, and would likely lead to broken behavior. Its presence might incorrectly indicate to licensees that this is an option that can be toggled safely.

#rb marc.audy
#jira UE-140327
#preflight 61fc6449dc0b3ecbecb6f381
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18864654 in //UE5/Release-5.0/... via CL 18864683 via CL 18864993
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18865002 by dave jones2 in ue5-main branch]
2022-02-04 11:54:52 -05:00
dave belanger
f49a9666a2 Hide some more C++ creation/editing menus when !GUnrealEd->GetUnrealEdOptions()->IsCPPAllowed() (follow up on 18815523)
#rb Rex.Hill
#preflight 61fbfcdee058822bda9ab04b

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 18863343 via CL 18863389 via CL 18863403 via CL 18863429 via CL 18863995 via CL 18864392
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18864406 by dave belanger in ue5-main branch]
2022-02-04 11:19:37 -05:00
paul chipchase
1a5466f3d4 Virtualization backends no longer falsely report that payloads failed to push if the default code path for batched pushing is used.
#rb Per.Larsson
#jira UE-141304
#rnx
#lockdown Mark.Lintott
#preflight 61fd3cccb5092d45ad18c953

- Not all backends gain from pushing payloads in batches. In this case the backend can opt not to override the default implementation which will just iterate over the batch of payloads and then push each one individually.
- However when the default path was used, FPushRequest::Status was not updated after the push was performed, which resulted in each request returning the default (failed) status.
-- The backends that use the default path are not enabled in any of our internal projects so this was not noticed.
- So even though the payloads were pushed, the virtualization process would log and error and block any submit being performed.
-- Subsequent submits of the same packages would work because we would note much earlier that the payloads are already stored in the backend and the broken code path would never run.
- Added fall through comment as required by the coding standards

#ROBOMERGE-AUTHOR: paul.chipchase
#ROBOMERGE-SOURCE: CL 18863318 in //UE5/Release-5.0/... via CL 18863334 via CL 18863548
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18863566 by paul chipchase in ue5-main branch]
2022-02-04 10:30:52 -05:00
thomas sarkanen
01c02d74ee Fixed crash opening a child anim blueprint of a template anim blueprint
Ensure that template flag is propagated in the regular factory use case

#jira UE-140017 Editor crashes when opening Child Blueprint Class
#rb Jurre.deBaare
#lockdown laurent.delayen
#preflight 61fd24f40a43b689e172ddb2

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18863199 in //UE5/Release-5.0/... via CL 18863205 via CL 18863370
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18863374 by thomas sarkanen in ue5-main branch]
2022-02-04 10:21:33 -05:00
Martin Ridgers
6bee1a2eb6 Be explicit about the character size we're expecting.
If TCHAR happens to change to something other than a 16bit integer (e.g. because wchar_t is four bytes on a platform, or because the engine changes to UTF8), the analysis engine will no longer be able to read traces with char16_t-type strings.

#rb jb
#rnx
#preflight 61fd3091ed26b9fd9c7fcc0e

[CL 18862539 by Martin Ridgers in ue5-main branch]
2022-02-04 09:16:04 -05:00
Martin Ridgers
e50b917312 - Changed deleter of Buffer to be the class that allocated it
- Implemented move-constructor/assignment operator. Transport keeps an array threads, each of which of owns a FStreamBuffer instance. When Transport resizes this array, it copies items about. Because there are no move constructors, the compiler ends up cloning FStreamBuffers (via copy-constructing) and incorrectly deleting Buffer pointers still in use.
#rb jb
#rnx
#preflight 61fd3044e17efe76d1b6174c

[CL 18862467 by Martin Ridgers in ue5-main branch]
2022-02-04 09:07:30 -05:00