Commit Graph

532 Commits

Author SHA1 Message Date
catalin dragoiu
9dc1b51824 Disable launching of UnrealTraceServer from the Editor on Mac.
#rb Ionut.Matasaru
#jira UE-191107

[CL 26607864 by catalin dragoiu in ue5-main branch]
2023-07-26 11:08:22 -04:00
logan buchy
00b725427a Pause StallDetector when SlowTask is present
* A SlowTask is created when there is delibrately going to be a stall-like condition but the developer wants to retain some limited interactivity.  This is traditionally not considered a stall.
* This change will pause stall detectors when slow tasks are created and resume them when the slow task ends.
* Implementation uses a TLS variable to store SlowTask specific pause contexts so as to not put a dependency of SlowTasks on the StallDetector.  Thread local stack is used since SlowTasks can be created from any thread context and can also be recursively created - therefore the Start/Finalize SlowTask events can be fired from any thread and the number of pause contexts need to match the created slow tasks.

#rb Brooke.Hubert, Rex.Hill
#jira UE-179567

[CL 26583138 by logan buchy in ue5-main branch]
2023-07-25 14:33:43 -04:00
logan buchy
eac21cc8cd Add debug commands for SlowTask and StallDetector
* StallDetector gets StallDetector.ForceLogOnStall which will cause the editor to emit a log from the LogStall category at verbosity Log even if the StallDetector scope is set to disable reporting
* Editor.Debug.SlowTask.Simulate will cause the FEngineLoop::Tick to enter a SlowTask for the given number of seconds.
* Together, these can be used to validate that the StallDetector scope in FEngineLoop::Tick is triggered when a SlowTask runs past the detector's stall threshold time (2 seconds at time of writing)

#jira UE-179567
#rb Rex.Hill

[CL 26559492 by logan buchy in ue5-main branch]
2023-07-24 19:40:28 -04:00
logan buchy
490033eaff Revert commented out ensure in StallDetector
* Commented out during backout of previous change.  Should have still been intact.

#rb trivial
#jira UE-179567

[CL 26558878 by logan buchy in ue5-main branch]
2023-07-24 18:57:12 -04:00
logan buchy
3a79e1c6f7 Backout StallDetector pause on SlowTask
* Some unknown cases are causing ensure() to fire - backout until sorted

#jira UE-179567
#rb trivial

[CL 26548536 by logan buchy in ue5-main branch]
2023-07-24 13:12:22 -04:00
logan buchy
23b649234d Backout StallDetector pause on SlowTask
* Some unknown cases are causing ensure() to fire - backout until sorted

#jira UE-179567
#rb trivial

[CL 26449831 by logan buchy in ue5-main branch]
2023-07-18 18:11:34 -04:00
christopher waters
2b78bbaa2b Fixing remaining IWYU errors
[CL 26358328 by christopher waters in ue5-main branch]
2023-06-30 18:31:26 -04:00
christopher waters
1c99959e3e Fixing IWYU compiles
[CL 26353592 by christopher waters in ue5-main branch]
2023-06-30 16:11:56 -04:00
johan berg
658bbe890f Rework command line parsing for memory trace
On some platforms and configurations all command line arguments are sent as one string rather than one string per argument. We need to parse each argument in the vector for sub arguments to be sure to catch any memory trace channel.

#rb martin.ridgers
#jira UE-188908

[CL 26255677 by johan berg in ue5-main branch]
2023-06-27 09:16:05 -04:00
johan berg
cd9418aea4 [Backout] - CL26252786
[FYI] Johan.Berg
Original CL Desc
-----------------------------------------------------------------
Rework command line parsing for memory trace

On some platforms and configurations all command line arguments are sent as one string rather than one string per argument. We need to parse each argument in the vector for sub arguments to be sure to catch any memory trace channel.

#rb martin.ridgers
#jira UE-188908

[CL 26253342 by johan berg in ue5-main branch]
2023-06-27 05:16:05 -04:00
johan berg
79db24e840 Rework command line parsing for memory trace
On some platforms and configurations all command line arguments are sent as one string rather than one string per argument. We need to parse each argument in the vector for sub arguments to be sure to catch any memory trace channel.

#rb martin.ridgers
#jira UE-188908

[CL 26252800 by johan berg in ue5-main branch]
2023-06-27 03:35:22 -04:00
ben woodhouse
dca84705e3 Make csv named events switchable at runtime via cvars csv.NamedEventsExclusive and csv.NamedEventsTiming
#rb gwennael.arbona

[CL 26231977 by ben woodhouse in ue5-main branch]
2023-06-26 09:04:53 -04:00
matt harris
870afab991 Adding flags to CSV metadata for LTO and PG_Instrumentation so we can show them in PRS
#reviewer joe.bestrotheray

[CL 26229564 by matt harris in ue5-main branch]
2023-06-26 04:10:24 -04:00
Matt Peters
011a78ece9 LLM AssetTags: Fix the missing stats for AssetTags; they were accidentally disabled by CL 23599453.
#rnx
#rb Simon.Orr
#jira UE-188961

[CL 26185861 by Matt Peters in ue5-main branch]
2023-06-22 12:47:56 -04:00
ben woodhouse
8e1f799a6e CSV Profiler: insights support for -csvNamedEvents
Also add a CSV_  prefix to csv named events so they can be distinguished from ordinary named events
#rb robert.millar

[CL 26144673 by ben woodhouse in ue5-main branch]
2023-06-21 07:07:24 -04:00
Johan Berg
502297c83b Fix for trace but no logging configurations
#rb none

[CL 26144558 by Johan Berg in ue5-main branch]
2023-06-21 06:50:09 -04:00
Johan Berg
9447e39552 Fix for configurations where trace is disabled.
#rb none

[CL 26103159 by Johan Berg in ue5-main branch]
2023-06-19 16:10:57 -04:00
Johan Berg
ecdbadca4d Add listener to TraceLog messages
Implement a listener for TraceLog messages and log any events.

#rb martin.ridgers

[CL 26087010 by Johan Berg in ue5-main branch]
2023-06-19 07:37:52 -04:00
danny couture
02f2d2a3b0 Skip unreal trace server start when running under TSAN to prevent immediate crash on fork
#rnx
#rb Johan.Berg

[CL 25974260 by danny couture in ue5-main branch]
2023-06-14 06:51:43 -04:00
johan berg
5e70369faf Return allocator result in the case of zero sized allocations.
Remove checks for zero sized allocations in Trace's allocation wrappers leaving it to the allocator implementation to decide. Analysis already supports zero sized allocations (as long as they have unique addresses).

#rb ionut.matasaru

[CL 25947983 by johan berg in ue5-main branch]
2023-06-13 07:06:13 -04:00
Johan Berg
baf0112f93 Add LLM tracing for TraceLog memory usage
#rb none

[CL 25947171 by Johan Berg in ue5-main branch]
2023-06-13 05:29:27 -04:00
martin ridgers
6217ad3be3 Trace counter Get() on atomic ints would return reference to local due to implicit cast.
When fixing the Get() I also discovered a couple of counters where the storage template type was incorrectly the same as the value template type. Fixed to use the atomic counter type given in counters header.

#jira
#rb jb
#rnx

[CL 25910796 by martin ridgers in ue5-main branch]
2023-06-10 09:56:10 -04:00
anton dunchev
d4d9104fe9 Unix MemoryTrace implementation
#rb [at]Brandon.Schaefer, [at]Johan.Berg
#tests DS

[CL 25879889 by anton dunchev in ue5-main branch]
2023-06-08 15:46:12 -04:00
logan buchy
f89b73a3ff Add missing include for StallDetector.cpp which fails to compile when not in unity build
#rb none

[CL 25874866 by logan buchy in ue5-main branch]
2023-06-08 12:41:14 -04:00
logan buchy
32cd2a9b12 Pause StallDetectors on thread when SlowTask with dialog is started
* SlowTask with dialog is the only case slowtask will broadcast the delegates
* Specific handling for case where StallDetector is added to scope while slowtask is present

#jira UE-179567
#rb brooke.hubert

[CL 25873878 by logan buchy in ue5-main branch]
2023-06-08 12:11:28 -04:00