- Remove the condition causing SCW to automatically exit after a single job if HLSLcc was used. This doesn't appear to be beneficial; HLSLcc uses a lot of memory but does not appear to leak it, so we're wasting time spinning up new processes unnecessarily here. This allows us to deprecated the associated field in the compiler output and function in IShaderFormat.
- Strip out compiler invocations stats; this was not accurate in some cases and it was decided after discussion that at this point the effort to fix the problems was not worth the utility we get from it.
#rb Jason.Nadro
#rb Laura.Hermanns
[CL 26256933 by dan elksnitis in ue5-main branch]
if (Condition)
{
Foo = Bar; // this would have been replaced with: branch_flattened_temp0 = Bar;
Foo2 = Foo; // this would have been replaced with: branch_flattened_temp1 = Foo; this should have been replaced by:
branch_flattened_temp1 = branch_flattened_temp0;
}
#jira UE-164327
#rb simon.tovey
#preflight 632ddb75e23e50651b95cca4
[CL 22164425 by rob krajcarski in ue5-main branch]
A = GetFirstValue();
B = A;
A = GetSecondValue();
C = A; // <-- this would get GetSecondValue() assigned to C instead of GetFirstValue()
Adds an SSA pass to help reduce overwriting registers, adds logic to remove self assignments, and adds logic to stop propagating when values are dirtied
From a sampling of scripts, about 2% are changed (where 1-3 unnecessary ops have been deleted).
#rb simon.tovey
#preflight 62b0d63c8e03312ad83a0c51
#jira UE-148892
[CL 20756957 by rob krajcarski in ue5-main branch]
The default threshold for loop unrolling was 32, so the compiler tried to make a dynamic loop when we had more iterations. The vector VM doesn't support that, so the codegen was never designed to understand dynamic loops, leading to an assertion failure. Increased the threshold to a large value, so we never hit this problem in practice.
#rnx
#jira none
#rb none
#ROBOMERGE-SOURCE: CL 12422302 in //UE4/Release-4.25/... via CL 12422324
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v671-12333473)
[CL 12426823 by mihnea balta in Release-Engine-Staging branch]
The default threshold for loop unrolling was 32, so the compiler tried to make a dynamic loop when we had more iterations. The vector VM doesn't support that, so the codegen was never designed to understand dynamic loops, leading to an assertion failure. Increased the threshold to a large value, so we never hit this problem in practice.
#rnx
#jira none
#rb none
[CL 12422302 by mihnea balta in 4.25 branch]
The branch flattening code assumed the function will always have a return value. Also, it never advanced the current parameter pointer when going through the function arguments, so it was trying to dereference the first parameter for all the arguments.
#rnx
#jira none
#rb Simon.Tovey
#ROBOMERGE-SOURCE: CL 12387646 in //UE4/Release-4.25/... via CL 12387649
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v671-12333473)
[CL 12387651 by mihnea balta in Main branch]
The branch flattening code assumed the function will always have a return value. Also, it never advanced the current parameter pointer when going through the function arguments, so it was trying to dereference the first parameter for all the arguments.
#rnx
#jira none
#rb Simon.Tovey
[CL 12387646 by mihnea balta in 4.25 branch]
