Commit Graph

75 Commits

Author SHA1 Message Date
christopher waters
5d5fa707fb Adding logging of failed fallback paths to ScreenShot tests
#rb mihnea.balta, jeannoe.morissette

[CL 26291568 by christopher waters in ue5-main branch]
2023-06-28 13:55:26 -04:00
christopher waters
72568f28c9 Fixing EngineTest screenshot fallbacks for non-D3D platforms where the fallback paths aren't of the form RHI_FeatureLevel.
#jira UE-187354
#rb jeannoe.morissette

[CL 26196059 by christopher waters in ue5-main branch]
2023-06-22 18:05:58 -04:00
Jerome Delattre
06389d5027 Support Confidential platforms in Screenshot fallback settings
#jira UE-163243
#preflight 646e5f421417daba1e01a8eb
#rnx
#rb Brian.White

[CL 25643793 by Jerome Delattre in ue5-main branch]
2023-05-26 11:41:50 -04:00
mikalai sukhikh
43d4e1ea52 Fix: UnrealFrontend - Screenshot reference can't be found in Session frontend
#jira UE-183924
#rb adam.miezianko, chris.constantinescu, jerome.delattre
#preflight 646282fcb87b09aadd2b32a6
#preflight 646282c35b775f11fb08be45

[CL 25503473 by mikalai sukhikh in ue5-main branch]
2023-05-17 03:03:29 -04:00
bryan sefcik
da92084a12 Optimized out more private modules includes and dependencies.
#preflight 64627c382965f6ea8ea83bd6

[CL 25479683 by bryan sefcik in ue5-main branch]
2023-05-15 16:26:12 -04:00
oleg krasnov
3f55ae9120 Fix for not found screenshot reference while running automated tests in UFE
#jira UE-176679
#rb adam.miezianko, chris.constantinescu, jerome.delattre
#preflight 6414204e345ab08524c422ad
#preflight 6414205c3f3d31c94a634e45

[CL 24746909 by oleg krasnov in ue5-main branch]
2023-03-22 10:01:30 -04:00
Joe Kirchoff
109addf6a3 Cpp20 doesn't allow implicit capture of 'this' via '[=]'
#rb Francis.Hurteau
#preflight 64068c936e1dadfcda41bb82

[CL 24548358 by Joe Kirchoff in ue5-main branch]
2023-03-07 16:49:18 -05:00
jerome delattre
80b32adb45 Prevent approved reference images to be copied to html test report for successful test
#jira UE-176364
#preflight 63e3d66d8374ef68dffe3565
#rb Chris.Constantinescu

[CL 24085750 by jerome delattre in ue5-main branch]
2023-02-08 18:20:35 -05:00
aidin abedi
88e9765627 Improve ImageComparer by extending FComparableImage to be more straightforward when comparing images that are only in-memory.
#jira UE-173166
#preflight 63c502d70225f00e14f28aff
#review @yuriy.odonnell

[CL 23776626 by aidin abedi in ue5-main branch]
2023-01-19 12:51:53 -05:00
cae-pdaigle
387f4f68fb Fix screenshots path names in test reports (standalone/no editor mode) (Contributed by cae-pdaigle)
PR #9680

#preflight 6357eff043784dae7f04fb62
#jira UE-167613
#rb Chris.Constantinescu

[CL 22782535 by cae-pdaigle in ue5-main branch]
2022-10-26 12:24:58 -04:00
bryan sefcik
0beee50b45 Updated ../Engine/Source/Developer/... to inline gen.cpp files
Before:
Total CPU Time: 53783.640625 s
Total time in Parallel executor: 558.66 seconds
After:
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds

#jira

[CL 22173145 by bryan sefcik in ue5-main branch]
2022-09-24 13:31:25 -04:00
bryan sefcik
f58e75e476 Pass 2 on cleaning up build.cs files.
#jira
#preflight 631b7a79304480f8f8b48580

[CL 21931324 by bryan sefcik in ue5-main branch]
2022-09-09 19:41:38 -04:00
Zak Middleton
84fb0737e0 #ue5 - Fix type conversion warnings in modules: AutomationController, AutomationTest, AVEncoder, AVIWriter.
#jira UE-160830
#rb Andrew.Davidson
#preflight 630d2147556fc14dce527da5

[CL 21690862 by Zak Middleton in ue5-main branch]
2022-08-29 18:32:03 -04:00
bryan sefcik
de1956f47b Ran IWYU on Public headers under Engine/Source/Developer/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21064294 by bryan.sefcik
#jira
#preflight 62d5c2111062f2e63015e598

#ROBOMERGE-OWNER: bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21155249 via CL 21158121 via CL 21161259
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21182053 by bryan sefcik in ue5-main branch]
2022-07-20 12:03:45 -04:00
Jerome Delattre
b14815ede7 Tag allocations related to Automation Test components
#jira UE-153882
#rb Ionut.Matasaru, Matt.Peters

#preflight 62c44591c438da7f091bb3b9

[CL 20942097 by Jerome Delattre in ue5-main branch]
2022-07-05 10:45:22 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Jerome Delattre
f8c58dfd2c Avoid duplicates of Screenshot comparison artifacts when producing automated test html/json report
#jira UE-144056
#preflight 621e630f3e14f0c7e5497b07
#rb Chris.Constantinescu

[CL 19271563 by Jerome Delattre in ue5-main branch]
2022-03-04 14:04:40 -05:00
Matt Hoffman
46e568c199 Automation: Exposed "GetIdealApprovedFolderForImage" to IScreenShotManager so that external modules can reuse the same code to correctly calculate where to store a ground truth image.
#jira UE-105318
#rb Jerome.Delattre
#preflight 61f2ee611f12674afbbe9f6d

[CL 18762242 by Matt Hoffman in ue5-main branch]
2022-01-27 16:30:09 -05:00
jerome delattre
6490e355e2 Properly initiate FImageComparisonResult::CreationTime member
Fix originaly proposed through PR #8632. But the fix is not to exclude the class member to be tested but to properly intiate it.

#jira UE-135340
#rb Julien.StJean

#ROBOMERGE-AUTHOR: jerome.delattre
#ROBOMERGE-SOURCE: CL 18286341 in //UE5/Release-5.0/... via CL 18286368
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18286382 by jerome delattre in ue5-release-engine-test branch]
2021-11-24 13:36:04 -05:00
yuriy odonnell
9b78219a4f Remove FComparableImage::Process() and its outputs (Total/Average values).
The outputs were computed incorrectly (due to data races in ParallelFor body) and inefficiently (looping over pixel columns). Luckily, outputs were not referenced by any subsequent code.

Saves ~0.3 seconds of processing time (~30%, ~1.0s sec -> ~0.7s) per screenshot test on AMD TR 3970X.

#rb Arciel.Rekman

#ROBOMERGE-AUTHOR: yuriy.odonnell
#ROBOMERGE-SOURCE: CL 18195320 in //UE5/Release-5.0/... via CL 18195381
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18195392 by yuriy odonnell in ue5-release-engine-test branch]
2021-11-15 15:00:48 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
jerome delattre
5ce6ba8080 Test Autoamtion - fix incoming screenshot image saved as JPEG instead of PNG since jpg format was enabled for thumbnail
* Isolate code for compressing in PNG and use this code for screenshot image compression
* Mark screenshot as not similar when error message is not empty when considering comparison result

#rnx
#jira UE-121446
#rb Julien.StJean, Chris.Contantinescu

#ROBOMERGE-SOURCE: CL 17138306 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17138314 by jerome delattre in ue5-release-engine-test branch]
2021-08-11 13:39:11 -04:00
aurel cordonnier
02c0f425e8 Copy up from Release-Engine-Staging @ 16738359
This represents UE4/Main @ 16738161 and Dev-PerfTest @ 16737719

[CL 16738582 by aurel cordonnier in ue5-release-engine-test branch]
2021-06-22 00:27:54 -04:00
Marc Audy
e80ea6b959 Merge from Release-Engine-Staging @ 16444985
This represents UE4/Main @ 16445039 and Dev-PerfTest @ 16444526

[CL 16445122 by Marc Audy in ue5-release-engine-test branch]
2021-05-25 02:43:26 -04:00
ionut matasaru
74bf2e67b9 Fixed errors re format string / parameter list for various UE_LOGs:
- number of supplied parameters less or more than the number of specifiers used in format string
  - invalid format string specifiers used

#rb Matt.Peters

#ROBOMERGE-SOURCE: CL 16315056 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v804-16311228)

[CL 16315068 by ionut matasaru in ue5-release-engine-test branch]
2021-05-13 13:22:48 -04:00