Commit Graph

14 Commits

Author SHA1 Message Date
patrick boutot
2043ca9bff MVVM: Fix order when adding a delegate and removing delegate while a delegate is executing.
#prefligth 647947ac6f48a706660482d4

[CL 25758381 by patrick boutot in ue5-main branch]
2023-06-02 08:29:35 -04:00
patrick boutot
2e9b9d33a1 MVVM: Add test to test removing an element from the FieldNotificationDelegate in a broadcast of the same delegate.
#jira UE-180226
#rb yohann.dossantos
#preflight 646411ff063e77985c437bd5

[CL 25507065 by patrick boutot in ue5-main branch]
2023-05-17 10:33:25 -04:00
patrick boutot
2602940722 MVVM: Add unittest for FieldNotificationDelegate. Fix bug with Remove that didn't return the correct state of the bindings.
#jira UE-180226
#preflight 644be4b5877716c87807d94e
#preflight 645222a8de5765212276ffec

[CL 25318858 by patrick boutot in ue5-main branch]
2023-05-03 12:28:04 -04:00
patrick boutot
733a813436 MVVM: Add the Broadcast field to the INotifyFieldValudChanged. Previously the viewmodel or widget implemented the functionality. The functionality was protected just because. Since we move it to a more engine wide feature and that it will be integrated with the Blueprint compiler it needs to be visible by Blueprint.
#jira UE-130880
#rb zahra.nikbakht
#preflight 643417d8b4329f6f1aded60b, 643693d04c0cdaea093962a7

[CL 25018215 by patrick boutot in ue5-main branch]
2023-04-12 19:00:11 -04:00
patrick boutot
33b88e8374 MVVM: Fix false positive V758 error in MVVM code base. Fix bad variable initialization.
#jira UE-181105
#rnx
#rb none

[CL 24771433 by patrick boutot in ue5-main branch]
2023-03-23 20:47:14 -04:00
patrick boutot
427ba04371 MVVM: Remove needs to have a SourcePath for ComplexConversionFunction. The source data is inside the function itself and the fieldnotify name is already saved in the class binding.
Update GetBindingInfoFromFieldPath to support viewmodel inside another viewmodel. Add unittest for the function.
Add DoesInitializeAtConstruction on the view class. That is to support manual initialization. When the flag is false, the user is responsible for initializing the view.
Add ReevaluateSourceCreator. A source that was discovered at compile time and added to the list of SourceCreator may need to be evaluated if the path contains notify. That function is similar to SetViewModel but finds the new value from the SourceCreator.
Fix issue when a binding destination can't be evaluated at initialization. Since we only reactivate the bindings link to a source in SetViewModel, some bindings were never registered and never executed after the SetViewModel properly set the binding destination.
Update the view class ToString functions with the new flags.
Prevent adding a new binding when the editor data contains a conversion function and a regular function. That may occur when the user started with a regular binding and changed it afterward for a conversion function. We may not want to reset the binding to be non destructive.
#prefligth 6419e837bb1320be412d274d, 641b068aee0aed13479e6ea3

[CL 24750233 by patrick boutot in ue5-main branch]
2023-03-22 13:07:37 -04:00
henrik karlsson
2f78497e67 [Engine/Plugins]
* Updated private files with IWYU for all plugins which had 3 or less changes made in ue5 main since last integration to fn

#preflight 63bf8d8b577437afe607dc72
#rb none

[CL 23659643 by henrik karlsson in ue5-main branch]
2023-01-12 01:48:34 -05:00
sebastian nordgren
3fdafe9997 MVVM - Replaced all user-facing FStrings with FText. This includes all compiler error messages.
Binding display names now take into account complex conversion functions.

Complex conversion functions now compile correctly.

#rb patrick.boutot
#rnx
#preflight 633ebda6d910a076839e3ddf
#preflight 633ec514a712a61df1354aec

[CL 22388782 by sebastian nordgren in ue5-main branch]
2022-10-06 20:08:12 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
Patrick Boutot
deb4338cda MVVM: Compile complex conversion functon and execute them as a regular binding.
#rb sebastian.nordgren
#prefligh 63062f5c5366f61a42bced80

[CL 21544671 by Patrick Boutot in ue5-main branch]
2022-08-24 13:14:51 -04:00
Patrick Boutot
010f9c505e MVVM: Fix binding unit test
#rb none
#preflight none

[CL 21184644 by Patrick Boutot in ue5-main branch]
2022-07-20 13:38:40 -04:00
Patrick Boutot
39f24fb616 MVVM: Fix some static Analysis
#jira UE-148379
#rnx
#rb none
#preflight none

[CL 19651133 by Patrick Boutot in ue5-main branch]
2022-04-06 13:44:22 -04:00
Patrick Boutot
a991e53c7e MVVM: Fix missing copyright notice
#preflight none

[CL 19593417 by Patrick Boutot in ue5-main branch]
2022-04-01 15:04:35 -04:00
Patrick Boutot
5cc291be88 MVVM: Move the ModelViewViewModel plugin to //UE5/Main/
#preflight 62471b2edc6183e3f51a8a07
#preflight 62473c85f73c316f680acef9

[CL 19592606 by Patrick Boutot in ue5-main branch]
2022-04-01 14:21:11 -04:00