Commit Graph

56 Commits

Author SHA1 Message Date
helen yang
fa585989cf Fix ensures when migrating MetaSound assets
- Create new class names for temporary packages created during migration to avoid duplicate node registration
- Change duplicate node registration ensure to if check with better logging of asset causing collision

#jira UE-161039
#jira UE-175059
#jira UE-188854
#rb rob.gay

[CL 26299244 by helen yang in ue5-main branch]
2023-06-28 17:08:29 -04:00
rob gay
586618a007 - Added test for binding interfaces & fixed following fallout
Major:
- Added missing input MetaSound audio interfaces
- Fixed interface bindings not working with referenced transient, non-asset MetaSounds

Minor:
- Fix builder name not being propagated to transient builders
- Fix not defaulting to success enum when creating patch builder
- Generalized pool of named/registered builders on Builder Subsystem instead of having them per type (to support future types without having to update the subystem for each additional future type.)
#rb helen.yang

[CL 26189673 by rob gay in ue5-main branch]
2023-06-22 14:51:42 -04:00
kirill zorin
b6ee3a6c64 Fix UE_LOG callsites that have format string-related UB
#rb trivial
#preflight 647107780a6634dbb236a0a6

[CL 25651638 by kirill zorin in ue5-main branch]
2023-05-26 15:52:39 -04:00
rob gay
18e887e937 [MetaSounds] Fix/add missing new MetaSound type icons/thumbnails as well as play/stop overlays. Support for showing/filtering presets in ContentBrowser
#rb helen.yang julien.stjean
[REVIEW] helen.yang
#jira UE-168050
#preflight 635314707261e565c497645f

[CL 22786984 by rob gay in ue5-main branch]
2022-10-26 15:28:04 -04:00
rob gay
7c89cca430 Fix missing rerouted implicit accessor behavior causing various bugs with constructor pins
#rb helen.yang
#rnx
#jira UE-163090
#preflight 6320d96829254beccb80dc36

[CL 21997851 by rob gay in ue5-main branch]
2022-09-13 21:51:22 -04:00
robert millar
aa6e458004 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for Metasound.

#jira UE-161932
#rb none
#preflight https://horde.devtools.epicgames.com/job/631f7da6a9331c69c3aa4ac5

[CL 21976387 by robert millar in ue5-main branch]
2022-09-12 19:52:49 -04:00
Rob Gay
d759aee3d7 MetaSound Reroute Nodes
- Minor play button/transport bar updates using new icons from RobbieK
- Validation Clean-up to better report final message severity state & accomidate template node validation (i.e. reroute validation & visual reporting/user feedback)
#rb helen.yang
#jira UE-150599
#rnx
#preflight 62f6949acf7afa018ba94144

[CL 21359529 by Rob Gay in ue5-main branch]
2022-08-12 14:22:05 -04:00
Rob Gay
b11e9b2c7c Minor error text fix-up (missed in prior CL)
#fyi helen.yang
#rb helen.yang
#jira none
#rnx
#preflight skip

[CL 21323383 by Rob Gay in ue5-main branch]
2022-08-10 14:52:01 -04:00
Rob Gay
87f810eadf MetaSound Template nodes
#rb phil.popp
#jira UE-160476
#preflight 62f3f49df75a2a539c8b4973

[CL 21322540 by Rob Gay in ue5-main branch]
2022-08-10 14:18:10 -04:00
helen yang
abcf114f57 MetaSound Constructor pin editor-frontend integration checkpoint
- Both inputs and outputs can be constructor vertices, not just inputs
- Enforce connection and data type constraints for access types
- Prevent default value constructor value from being changed while playing
- Added cvar (default disabled) for enabling constructor pin option in editor

#jira UE-151661
#rb phil.popp
#preflight 62d59f4bf156340c79cfcbf5

[CL 21152841 by helen yang in ue5-main branch]
2022-07-18 17:14:25 -04:00
phil popp
bf3f2a50f1 [Metasound] Swapping transaction history for transaction stream
#jira UE-147632
#rb Rob.Gay, Helen.Yang
#preflight 62791ab5066ebb49109cfaea

[CL 20102001 by phil popp in ue5-main branch]
2022-05-09 09:50:28 -04:00
eric mcdaniel
9d29cc2818 Remove LLM tag from FMetaSoundFrontendRegistryContainer creation to unblock Xbox
#rb none
#jira none, CIS encountered
#preflight none, trivial

[CL 20019193 by eric mcdaniel in ue5-main branch]
2022-05-02 21:27:35 -04:00
phil popp
6eae6a1e3f [Metasound] Move various members to WITH_EDITORONLY_DATA to save on non-editor memory.
#jira UE-147633
#rb Rob.Gay
#preflight 6270074aad00dced62d0f685

[CL 20010513 by phil popp in ue5-main branch]
2022-05-02 12:35:54 -04:00
phil popp
c842fc31f8 MetaSound Frontend Memory Improvements
- Reduces baseline metasound plugin memory usage from 6.0 -> 3.5 mb
- Use a TSharedRef for storing node and data type registry entries to avoid storing multiple copies.
- Rework the runtime search engine query "FindHighestMinorVersion" to use less memory.
#jira UE-147632
#preflight 6269713fcd0dacbe0e7e41de

[CL 19942597 by phil popp in ue5-main branch]
2022-04-27 13:19:55 -04:00
maxwell hayes
74a0a3cd9f Add specific metasound LLM tags
#rnx
#rb Ryan.Mangin, Maxwell.Hayes

#ROBOMERGE-OWNER: maxwell.hayes
#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 19466276 via CL 19466297 via CL 19466320 via CL 19481856 via CL 19481881
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v936-19480137)

[CL 19484079 by maxwell hayes in ue5-main branch]
2022-03-23 15:56:20 -04:00
rob gay
350e70d3e3 AssetClassID generation fix-up (collab fixes w/Helen)
0 Guid MetaSound AssetRegistry entry fix-up
#rb helen.yang
#rb rob.gay
#rnx
#jira UE-144864
#preflight 6226ab981938e4deaa7f4276

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19307367 in //UE5/Release-5.0/... via CL 19308413
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19347405 by rob gay in ue5-main branch]
2022-03-10 21:19:13 -05:00
phil popp
9cc3375c64 Fix metasound presets not updating correctly.
#jira UE-137838
#rb Rob.Gay
#preflight 61e03f55250b9537f7736939

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18596760 in //UE5/Release-5.0/... via CL 18596806 via CL 18596977
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18597027 by phil popp in ue5-main branch]
2022-01-13 10:27:49 -05:00
phil popp
a70bef2673 Keep metasound search engine warm
- Adds a "Prime" call to the MetasoundSearchEngine so we can precache a bunch of queries.
- Adds more metasound traces
- Encapsulates queries into structs to avoid a bunch of boilerplate code everywhere.
#rb Rob.Gay
#jira UE-132803
#preflight 61afe61ae01bc44973df5e30

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18401520 in //UE5/Release-5.0/... via CL 18401531
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18401537 by phil popp in ue5-release-engine-test branch]
2021-12-07 18:37:04 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
phil popp
d5bd663e40 Implement MetasoundGraphCore Variable
#rb Rob.Gay
#jira UE-123940
#preflight 6137af632d09b9000130e10e

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 17450011 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17450040 by phil popp in ue5-release-engine-test branch]
2021-09-07 17:07:54 -04:00
phil popp
9d254b5828 Factor out metasound data type registration
#rb Rob.Gay
#jira UEAU-834
#preflight 611d834c9db7df000138d786

#ROBOMERGE-SOURCE: CL 17233442 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17233468 by phil popp in ue5-release-engine-test branch]
2021-08-19 09:59:27 -04:00
phil popp
49231c9dd1 Fix ensure on metasound enum promoted to input
Enabled metasound enum update via BP and editor
#jira UE-120704
#rb Rob.Gay
#preflight 611bbc52e7a3070001f2504c

#ROBOMERGE-SOURCE: CL 17192121 via CL 17192166
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17192190 by phil popp in ue5-release-engine-test branch]
2021-08-17 10:14:07 -04:00
rob gay
175341d764 Stop-gap fix for duplicated MetaSound assets sharing registration node guid/class name.
Static Analysis warning fix
#rb phil.popp
#preflight none

#ROBOMERGE-SOURCE: CL 16977324 via CL 16977328
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16977329 by rob gay in ue5-release-engine-test branch]
2021-07-27 20:30:14 -04:00