Commit Graph

15 Commits

Author SHA1 Message Date
rob gay
1de499ef8e More MetaSound Interface registry clean-up
- Move bIsDefault/bCanEdit(renamed bIsModifiable) from InterfaceRegistryEntry to Interface data definition
- Add checks in builder to disallow mutation of interfaces that shouldn't be via editor or document builder (ex. SourceInterface which is default and then never changed)
- Optimize SearchEngine query for finding default interfaces
- Tweak MetaSoundUObjectRegistry to support non MetasoundAssetBase classes and add UMetaSoundBuilderDocument. Update iterator w/optional param to only return asset types (true by default for back compat)
- Move FName class name comparitors to use new TopLevelAssetPath
#rb phil.popp
#jira UE-181360
#rnx
#p4v-preflight-copy 24658328
#preflight 642b10834d26bcd1eb0e566c

[CL 24920763 by rob gay in ue5-main branch]
2023-04-04 19:14:26 -04:00
henrik karlsson
4a36cfe8ff Moved operator== to be hidden friend instead of put directly in global namespace
Moved GetTypeHash function to be hidden friend instead of put directly in global namespace.

Note that the function/operator needs to be fully inlined in the type or placed in the cpp. If the function is added as friend but then implemented outside the type then hidden friend optimization won't work.

This should improve compile time somewhat according to msvc devs.

#rb Steve.Robb
#preflight 6360b7052b5338aceb26471b

[CL 22889837 by henrik karlsson in ue5-main branch]
2022-11-01 15:50:27 -04:00
phil popp
f85b44bcce Reducing internal container sizes in Metasound Frontend Query
#jira UE-147632
#rb Aaron.McLeran
#preflight 627977865b16ddee36c1d8c7

[CL 20110519 by phil popp in ue5-main branch]
2022-05-09 16:32:28 -04:00
phil popp
c842fc31f8 MetaSound Frontend Memory Improvements
- Reduces baseline metasound plugin memory usage from 6.0 -> 3.5 mb
- Use a TSharedRef for storing node and data type registry entries to avoid storing multiple copies.
- Rework the runtime search engine query "FindHighestMinorVersion" to use less memory.
#jira UE-147632
#preflight 6269713fcd0dacbe0e7e41de

[CL 19942597 by phil popp in ue5-main branch]
2022-04-27 13:19:55 -04:00
phil popp
39239bef3a Updates to Metasound Frontend Query system.
- Simplified and removed a bunch of code.
- Reworked queries to include the concept of a "Partition" mapped to a Key
- Added more unit tests to ensure it works correctly.
- Fixed some bugs around incremental updates.

#rb Rob.Gay
#jira UE-132803
#preflight 61af81f4b12ed605818b24c3

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18400273 in //UE5/Release-5.0/... via CL 18400298
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18400305 by phil popp in ue5-release-engine-test branch]
2021-12-07 16:32:38 -05:00
phil popp
1a008f007f perf improvements to metasound node searching
#rb rob.gay
#preflight 611d43145e73720001d96b0b

#ROBOMERGE-SOURCE: CL 17219283 via CL 17219293
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17219311 by phil popp in ue5-release-engine-test branch]
2021-08-18 14:34:27 -04:00
rob gay
96fb1fb5ce Fix for MetaSound registry incremental unregister throwing a check.
Check hit was in FTransformRegistrationEventsToClasses::Transform and was due to prior reduce step not being applied on the merged result from the previous step.

#rb phil.popp
#rnx
#preflight 60fee2c56a02b1000169a67f

#ROBOMERGE-SOURCE: CL 16969984 via CL 16972215
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16972391 by rob gay in ue5-release-engine-test branch]
2021-07-27 15:35:56 -04:00
phil popp
2d07d3f583 CIS fix for GetTypeHash scope
#rb none
#rnx

#ROBOMERGE-SOURCE: CL 16642853 via CL 16642871
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v833-16641396)

[CL 16642881 by phil popp in ue5-release-engine-test branch]
2021-06-11 12:24:02 -04:00
phil popp
af1eedcecd CIS fix for unintended recursive function call when GetTypeHash(int32) not visible to translation unit.
#rb none
#rnx
#preflight 60c208919e139d000103abca

#ROBOMERGE-SOURCE: CL 16622715 via CL 16622728
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v830-16605563)

[CL 16622732 by phil popp in ue5-release-engine-test branch]
2021-06-10 10:03:24 -04:00
phil popp
93b828681c Adding dedup logic for subgraph node registration
#rb Rob.Gay
#preflight 60c122be44f42400015599c9

#ROBOMERGE-SOURCE: CL 16612856 via CL 16614296
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16614385 by phil popp in ue5-release-engine-test branch]
2021-06-09 18:20:38 -04:00
phil popp
d71686bbee Add ability to incrementally update frontend queries.
#jira UEAU-792
#rb Rob.Gay
#preflight 60afc6b7493080000171898d

#ROBOMERGE-SOURCE: CL 16489196 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v823-16466674)

[CL 16489254 by phil popp in ue5-main branch]
2021-05-27 14:45:41 -04:00
Rob Gay
12abad8cfb Metasound Class Validation & Versioning First Pass
#rb phil.popp
#jira UE-113416
#jira UE-113417
#jira UE-113419
#jira UEAU-781
#preflight 609065b7c4babe0001086600

[CL 16187219 by Rob Gay in ue5-main branch]
2021-05-03 17:52:04 -04:00
phil popp
d4af456a9c Metasound Frontend Perf Tuneup
- Added frontend search engine to cache frontend queries
- Allowing frontend queries to be updated in place.
- Tracking node registration transactions to allow incremental runtime checks of newly registered nodes.
- Create public RegistryContainer interface and hide implementation to allow for further optimizations without changing public headers
#jira UEAU-749
#rb Max.Hayes, Jimmy.Smith
#preflight 606399a6e05c4e0001a0d173

#ROBOMERGE-SOURCE: CL 15868737 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15868744 by phil popp in ue5-main branch]
2021-03-30 18:22:10 -04:00
phil popp
4cdd926b68 Metasound Frontend Revamp
- New node name {namespace.name.variant}
- PointIDs for exact pin-to-pin connections
- TAccessPtr updates
- Controller/Handle interface
- Document Handle
- Frontend Transforms
- Input/Output node external registration
- Revamped document model

#rb Max.Hayes, Rob.Gay
#jira UEAU-626

[CL 15066822 by phil popp in ue5-main branch]
2021-01-13 10:48:59 -04:00
phil popp
763a094e5c Metasound Frontent Query
#rb Rob.Gay
#jira UEAU-487

[CL 14724079 by phil popp in ue5-main branch]
2020-11-11 16:51:59 -04:00