Commit Graph

406 Commits

Author SHA1 Message Date
rob gay
42fd61fc37 - Add ability to set node position explicitly via MetaSound Editor Subsystem
- Fix bug introduced recently with BuildToAsset not applying a clean class name/guid
- Fix case where builder was added to root and not freed
- MetaSoundEditorSubsystem minor clean-up
#rb helen.yang
#jira UE-191435 UE-191505
#rnx

[CL 26715091 by rob gay in ue5-main branch]
2023-07-31 14:25:14 -04:00
rob gay
48e0c4350d - Make Connect... MetaSoundBuilderSubsystem API calls replace edges as needed to parallel editor behavior more
- Update MetaSoundFrontendDocumentBuilder AddEdge... API calls to support both replacement and ignoring invalid requests where applicable
#rb phil.popp
#jira UE-190989

[CL 26661505 by rob gay in ue5-main branch]
2023-07-27 19:43:47 -04:00
nicholas howe
656c8b7aea Metasound FDataTypeRegistry::IsValidUObjectForDataType uses GetSuperClass instead of GetOwnerClass when traversing class hierarchy and checks bIsExplicit.
#rb @rob.gay
#jira FORT-633885

[CL 26618921 by nicholas howe in ue5-main branch]
2023-07-26 16:02:00 -04:00
rob gay
0b331aaf72 Fix for MetaSound transaction stack manipulation not updating builder caches if builder is associated with edited object/asset & edge cache not initializing properly
#rb phil.popp
#jira UE-190358

[CL 26556901 by rob gay in ue5-main branch]
2023-07-24 17:38:26 -04:00
helen yang
f3f3bdc16d Fix ensures with empty MetaSound object literals
#jira UE-189035
#jira UE-189600
#rb rob.gay

[CL 26553864 by helen yang in ue5-main branch]
2023-07-24 16:12:33 -04:00
helen yang
3ddcc821aa Enable MetaSound deterministic id generation at runtime
#rb phil.popp
#jira UE-189686
#rnx

[CL 26547630 by helen yang in ue5-main branch]
2023-07-24 12:45:51 -04:00
phil popp
a550e6a4c6 Fix MetaSound binding issues on oscillator and noise nodes
Fix crash in array random get node during automated stress tests for metasounds.
#jira UE-187400, UE-187402, UE-189191, UE-189190
#rnx
#rb Jimmy.Smith

[CL 26513863 by phil popp in ue5-main branch]
2023-07-21 11:39:50 -04:00
Rob Gay
96a893aa52 Enable nulling out object parameters/proxies from BP/game thread transmitter requests.
#rb phil.popp
#rnx
#fyi buzz.burrows

[CL 26490829 by Rob Gay in ue5-main branch]
2023-07-20 14:02:15 -04:00
Matt Peters
0bb88db6de Metasound: Logging: Downgrade log message to verbose to make cookcommandlet logs easier to read.
#nrx
#rb Aaron.McLeran

[CL 26474510 by Matt Peters in ue5-main branch]
2023-07-19 19:03:46 -04:00
Rob Gay
267e801aa9 Fix for nametable/MetaSound Search Engine entry leaks due to new class name being generated on every builder build/audition call associated with a given target object
#rb todo
#jira UE-190590
#rnx

[CL 26471782 by Rob Gay in ue5-main branch]
2023-07-19 17:25:21 -04:00
Rob Gay
3b5f9c1e39 Add missing forward of early return value causing false negative when attempting to add MetaSound Interface via Builder API
#rb trivial
#jira UE-190478
#fyi sondra.moyls

[CL 26443241 by Rob Gay in ue5-main branch]
2023-07-18 15:24:34 -04:00
helen yang
fa585989cf Fix ensures when migrating MetaSound assets
- Create new class names for temporary packages created during migration to avoid duplicate node registration
- Change duplicate node registration ensure to if check with better logging of asset causing collision

#jira UE-161039
#jira UE-175059
#jira UE-188854
#rb rob.gay

[CL 26299244 by helen yang in ue5-main branch]
2023-06-28 17:08:29 -04:00
rob gay
a0f0ea02ea - Fix for inconsistent delegate implementation for MetaSound input/output removal
- Add tests for matching node/graph inputs & outputs
#rb trivial
#jira UE-189613
#rnx

[CL 26274854 by rob gay in ue5-main branch]
2023-06-27 19:07:35 -04:00
rob gay
651b8cf112 Fix for reducing channel count to output interface other than mono (and other ways in which interfaces were potentially swapping related API members)
#rb trivial
#jira UE-189613
#rnx

[CL 26248843 by rob gay in ue5-main branch]
2023-06-26 19:29:25 -04:00
rob gay
c7294b1a4c Missing part of earlier MetaSound builder cache corruption fix
#rb trivial
#rnx
#jira UE-189434

[CL 26242707 by rob gay in ue5-main branch]
2023-06-26 15:49:18 -04:00
rob gay
4858ab4ec4 Fix ConnectNode<In/Out>sToMatchingGraphInterface<In/Out>puts
- Add tests for connecting & disconnecting nodes that match graph interfaces
- Rename test accordingly
#rnx
#jira UE-186188
#rb helen.yang

[CL 26242483 by rob gay in ue5-main branch]
2023-06-26 15:42:30 -04:00
phil popp
4e9a2f49c6 Fix dynamic transactor missing node.
#jira UE-189289
#rnx
#rb Rob.Gay

[CL 26215215 by phil popp in ue5-main branch]
2023-06-23 14:53:34 -04:00
rob gay
586618a007 - Added test for binding interfaces & fixed following fallout
Major:
- Added missing input MetaSound audio interfaces
- Fixed interface bindings not working with referenced transient, non-asset MetaSounds

Minor:
- Fix builder name not being propagated to transient builders
- Fix not defaulting to success enum when creating patch builder
- Generalized pool of named/registered builders on Builder Subsystem instead of having them per type (to support future types without having to update the subystem for each additional future type.)
#rb helen.yang

[CL 26189673 by rob gay in ue5-main branch]
2023-06-22 14:51:42 -04:00
rob gay
205f276e20 Fix for cache corruption when removing inputs/outputs using document builder
#rnx
#rb trivial
[FYI] chris.zuko

[CL 26185908 by rob gay in ue5-main branch]
2023-06-22 12:49:12 -04:00
rob gay
efe5d3931c Add missing BPReadWrite mark-up to MetaSoundClassName so nodes can be added via builder in BP & LexToString for better error logging of MetaSound types to be used in subsequent CL for BP debugging. Minor formatting fix-ups.
#rnx
#rb trivial
#rnx

[CL 26158067 by rob gay in ue5-main branch]
2023-06-21 15:14:33 -04:00
maxwell hayes
ebf6e4caf7 [Metasound Bind] Fixup for bind issues caught by new automated tests.
#jira UE-187406, UE-187390, UE-187404, UE-187403, UE-187405, UE-187392, UE-187391, UE-187395, UE-187399, UE-187398, UE-187389, UE-187393, UE-187394, UE-187396, UE-187397, UE-187401
#rb phil.popp

[CL 26130674 by maxwell hayes in ue5-main branch]
2023-06-20 15:08:54 -04:00
helen yang
07268d51d2 MetaSound deterministic id generation
- Deterministic generation of ids for various FGuids used in MetaSound documents so that Autoupdate can be moved from runtime to cook in the future while maintaining cook determinism
- cvar for enabling in editor au.MetaSound.EnableDeterministicIDGenerationInEditorCVar

#jira UE-176939
#jira UE-176940
#rb phil.popp

[CL 26126897 by helen yang in ue5-main branch]
2023-06-20 13:12:39 -04:00
Rob Gay
df490de7a8 Initial work to pipe builder updates to dynamic graph
- Add delegates to respond to builder changes to document
- Add delegate handlers to source builder to forward requests to audition sound if live update enabled
- Misc piping for live updating
#jira UE-186952
#ok forgithub public
#rb phil.popp

[CL 26072389 by Rob Gay in ue5-main branch]
2023-06-16 17:48:20 -04:00
phil popp
059f9918ba Fix setting array parameters on metasound source
#rb Rob.Gay
#jira UE-188414

[CL 26071427 by phil popp in ue5-main branch]
2023-06-16 17:31:32 -04:00
phil popp
c05b7d4397 Fix build for editoronly data in program using metasound fronend.
#jira UE-187855
#rnx
#rb Rob.Gay

[CL 26028177 by phil popp in ue5-main branch]
2023-06-15 17:57:06 -04:00