Commit Graph

331 Commits

Author SHA1 Message Date
rob gay
42fd61fc37 - Add ability to set node position explicitly via MetaSound Editor Subsystem
- Fix bug introduced recently with BuildToAsset not applying a clean class name/guid
- Fix case where builder was added to root and not freed
- MetaSoundEditorSubsystem minor clean-up
#rb helen.yang
#jira UE-191435 UE-191505
#rnx

[CL 26715091 by rob gay in ue5-main branch]
2023-07-31 14:25:14 -04:00
rob gay
eb936ae1d0 Only audition literal update if no edge is already set.
#rb phil.popp
#jira UE-191434
#rnx

[CL 26686435 by rob gay in ue5-main branch]
2023-07-28 16:23:27 -04:00
rob gay
48e0c4350d - Make Connect... MetaSoundBuilderSubsystem API calls replace edges as needed to parallel editor behavior more
- Update MetaSoundFrontendDocumentBuilder AddEdge... API calls to support both replacement and ignoring invalid requests where applicable
#rb phil.popp
#jira UE-190989

[CL 26661505 by rob gay in ue5-main branch]
2023-07-27 19:43:47 -04:00
nicholas howe
656c8b7aea Metasound FDataTypeRegistry::IsValidUObjectForDataType uses GetSuperClass instead of GetOwnerClass when traversing class hierarchy and checks bIsExplicit.
#rb @rob.gay
#jira FORT-633885

[CL 26618921 by nicholas howe in ue5-main branch]
2023-07-26 16:02:00 -04:00
rob gay
dd6ede5f18 Nuke temporary cvar for disabling MetaSound Builder audition live updates
#rb trivial
#rnx
[FYI] phil.popp
[FYI] buzz.burrows

[CL 26559743 by rob gay in ue5-main branch]
2023-07-24 19:52:06 -04:00
rob gay
91e98b7846 Fix for incorrect element type being used from earlier change to support null object ptr passing to MetaSound parameter system
#rb trivial
#jira UE-190979
#rnx

[CL 26559355 by rob gay in ue5-main branch]
2023-07-24 19:35:46 -04:00
rob gay
0b331aaf72 Fix for MetaSound transaction stack manipulation not updating builder caches if builder is associated with edited object/asset & edge cache not initializing properly
#rb phil.popp
#jira UE-190358

[CL 26556901 by rob gay in ue5-main branch]
2023-07-24 17:38:26 -04:00
Rob Gay
96a893aa52 Enable nulling out object parameters/proxies from BP/game thread transmitter requests.
#rb phil.popp
#rnx
#fyi buzz.burrows

[CL 26490829 by Rob Gay in ue5-main branch]
2023-07-20 14:02:15 -04:00
Rob Gay
267e801aa9 Fix for nametable/MetaSound Search Engine entry leaks due to new class name being generated on every builder build/audition call associated with a given target object
#rb todo
#jira UE-190590
#rnx

[CL 26471782 by Rob Gay in ue5-main branch]
2023-07-19 17:25:21 -04:00
phil popp
c382cf4cfb Fix for disconnecting MetaSound node using builder API does not update output
#jira UE-189292
#rb Rob.Gay

[CL 26446133 by phil popp in ue5-main branch]
2023-07-18 16:24:42 -04:00
charlie huguenard
29ebd6a621 [Metasound] Remove unnecessary lambda capture when a generator is destroyed
#rb phil.popp

[CL 26433505 by charlie huguenard in ue5-main branch]
2023-07-18 10:18:41 -04:00
helen yang
fa585989cf Fix ensures when migrating MetaSound assets
- Create new class names for temporary packages created during migration to avoid duplicate node registration
- Change duplicate node registration ensure to if check with better logging of asset causing collision

#jira UE-161039
#jira UE-175059
#jira UE-188854
#rb rob.gay

[CL 26299244 by helen yang in ue5-main branch]
2023-06-28 17:08:29 -04:00
maxwell hayes
fd1b2ffae8 [Metasounds] Bind Inputs / Outputs follow up (Automated Test Fixes)
#jira UE-187393, UE-187390, UE-189226, UE-187397
#rb Phil.Popp

[CL 26274886 by maxwell hayes in ue5-main branch]
2023-06-27 19:07:52 -04:00
rob gay
4858ab4ec4 Fix ConnectNode<In/Out>sToMatchingGraphInterface<In/Out>puts
- Add tests for connecting & disconnecting nodes that match graph interfaces
- Rename test accordingly
#rnx
#jira UE-186188
#rb helen.yang

[CL 26242483 by rob gay in ue5-main branch]
2023-06-26 15:42:30 -04:00
phil popp
4e9a2f49c6 Fix dynamic transactor missing node.
#jira UE-189289
#rnx
#rb Rob.Gay

[CL 26215215 by phil popp in ue5-main branch]
2023-06-23 14:53:34 -04:00
rob gay
586618a007 - Added test for binding interfaces & fixed following fallout
Major:
- Added missing input MetaSound audio interfaces
- Fixed interface bindings not working with referenced transient, non-asset MetaSounds

Minor:
- Fix builder name not being propagated to transient builders
- Fix not defaulting to success enum when creating patch builder
- Generalized pool of named/registered builders on Builder Subsystem instead of having them per type (to support future types without having to update the subystem for each additional future type.)
#rb helen.yang

[CL 26189673 by rob gay in ue5-main branch]
2023-06-22 14:51:42 -04:00
maxwell hayes
ca28732c72 [Metasounds] Follow up fixes for new BindInputs/ BindOutputs API.
#jira UE-189241
#rb none
[FYI] Chris.Ritter

[CL 26158495 by maxwell hayes in ue5-main branch]
2023-06-21 15:22:13 -04:00
rob gay
efe5d3931c Add missing BPReadWrite mark-up to MetaSoundClassName so nodes can be added via builder in BP & LexToString for better error logging of MetaSound types to be used in subsequent CL for BP debugging. Minor formatting fix-ups.
#rnx
#rb trivial
#rnx

[CL 26158067 by rob gay in ue5-main branch]
2023-06-21 15:14:33 -04:00
maxwell hayes
ebf6e4caf7 [Metasound Bind] Fixup for bind issues caught by new automated tests.
#jira UE-187406, UE-187390, UE-187404, UE-187403, UE-187405, UE-187392, UE-187391, UE-187395, UE-187399, UE-187398, UE-187389, UE-187393, UE-187394, UE-187396, UE-187397, UE-187401
#rb phil.popp

[CL 26130674 by maxwell hayes in ue5-main branch]
2023-06-20 15:08:54 -04:00
rob gay
19c88744d9 - Fix-up MetaSound dynamic builder engine tests
- Add missing move of transactor to generator init params

#rb Phil.Popp
#jira UE-181889
#rnx

[CL 26128742 by rob gay in ue5-main branch]
2023-06-20 14:03:55 -04:00
Rob Gay
df490de7a8 Initial work to pipe builder updates to dynamic graph
- Add delegates to respond to builder changes to document
- Add delegate handlers to source builder to forward requests to audition sound if live update enabled
- Misc piping for live updating
#jira UE-186952
#ok forgithub public
#rb phil.popp

[CL 26072389 by Rob Gay in ue5-main branch]
2023-06-16 17:48:20 -04:00
helen yang
9962c8f51a Copy soundbase/soundwave settings from referenced MetaSound source to new preset
- Add option to BuildToAsset to copy settings from a given template SoundWave
- Update CreatePreset right click asset action to use builder instead of factory

#jira UE-170991
#rb rob.gay

[CL 26019769 by helen yang in ue5-main branch]
2023-06-15 13:50:27 -04:00
phil popp
7053908920 MetaSound Dynamic Operator and Dynamic Transactor
#jira UE-181887, UE-184051
#rb Rob.Gay

[CL 25995669 by phil popp in ue5-main branch]
2023-06-14 17:01:59 -04:00
miles flanagan
34fe243092 Allow Metasound Bus Reader and Writer nodes to set up patch inputs after construction if their busses are set later
#jira UE-187408
#rb phil.popp

[CL 25848966 by miles flanagan in ue5-main branch]
2023-06-07 12:51:55 -04:00
Rob Gay
8e0ffe62c4 Nuke incorrect, redundant comment for self-documenting call
#rb trivial
#jira none
#rnx

[CL 25828927 by Rob Gay in ue5-main branch]
2023-06-06 17:21:38 -04:00