Commit Graph

27 Commits

Author SHA1 Message Date
rob gay
9dbc0c6693 [MetaSounds] Editor Graph Syncronization Upgrade
- Move synchronize/details panel flag to more generic ModifyContext
- Do not use MarkAsGarbage as means of enforcing not to show object in details panel to avoid leaving objects in invalid state if undo called. Check ed graph membership instead
- Get rid of leaky namechanged delegates
    - Allows for migration to isolated synchronization in the future
    - Removes conflation of having to synchronize and update views when modifying frontend document
    - Decouples concept of a specific view to update from generic frontend graph modifications
#rb helen.yang
#jira UE-151448
#preflight 632b7afdc7791417aa44126f

[CL 22142063 by rob gay in ue5-main branch]
2022-09-22 15:02:24 -04:00
sebastian nordgren
c4b81d8b75 Multi-line editable text boxes no longer call IPropertyUtilities::RequestRefresh() when adding or removing lines, which caused textboxes created in property row generators to fail to accept input past a single line.
This was a bug exposed because FPropertyRowGenerator previously ignored RequestRefresh() calls entirely, but now does a deferred refresh.

Since this was the only use of it, IEditableTextProperty and all its implementations have also had their RequestRefresh() methods removed.

[REVIEW] [at]jamie.dale, [at]vincent.gauthier
#preflight 632432a2cb23fcbbd8ef5dd2

[CL 22050354 by sebastian nordgren in ue5-main branch]
2022-09-16 11:35:06 -04:00
helen yang
abcf114f57 MetaSound Constructor pin editor-frontend integration checkpoint
- Both inputs and outputs can be constructor vertices, not just inputs
- Enforce connection and data type constraints for access types
- Prevent default value constructor value from being changed while playing
- Added cvar (default disabled) for enabling constructor pin option in editor

#jira UE-151661
#rb phil.popp
#preflight 62d59f4bf156340c79cfcbf5

[CL 21152841 by helen yang in ue5-main branch]
2022-07-18 17:14:25 -04:00
helen yang
8795e3fedb Add type colors + icons to Metasound member list and stub in editor side for constructor pins
- Fix color for Time:Array type

#jira UE-148269
#jira UE-148862
#rb rob.gay
#preflight 62631545006fa20b683e7a91

[CL 19905171 by helen yang in ue5-main branch]
2022-04-25 13:29:29 -04:00
helen yang
fb818a60dc Fix rename delegate not added to MetaSound members that do not have literals
#jira UE-147807
#rb rob.gay
#preflight 624dda99837c93f1a3f5889f

[CL 19652846 by helen yang in ue5-main branch]
2022-04-06 14:52:43 -04:00
Rob Gay
d5b2729860 Default to 'direct' ESelectInfo in SSearchableComboBox::SetSelectedItem
- Internal SelectedItem member was not getting set after last fix to avoid selection on key navigation while the menu was open
- Minor clean-up
#rb aditya.ravichandran
#rnx
#jira UE-146837
#preflight 623a0a68ec68595f3b88a242
#preflight 623a0a68ec68595f3b88a242

[CL 19469217 by Rob Gay in ue5-main branch]
2022-03-22 14:01:46 -04:00
rob gay
db2f61d3ec Hide default value if MetaSound member is hooked up.
- Clean-up some MetaSoundMember edgraphnode members
- Minor fix for hover when drag/dropping members not onto graph showing no error state
#rb helen.yang
#rnx
#jira UE-144433
#jira UE-144358
#preflight 62203018f134125ae0bc7078

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19253632 in //UE5/Release-5.0/... via CL 19257927
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263531 by rob gay in ue5-main branch]
2022-03-04 03:48:32 -05:00
rob gay
41a2a172dc Fix missing ability to order graph members
- Remove base template for node customizations now that it isn't required to be a template to enable intra-engine versioning (allows moving implementation of category customization to .cpp)
- Move redundant "Literal" property to parent UMetasoundEditorGraphMember
#rb helen.yang
#jira UE-121749
#rnx
#preflight 621d2e869a5676d19a3d50e9

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19181623 in //UE5/Release-5.0/... via CL 19183646
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19206681 by rob gay in ue5-main branch]
2022-03-01 16:31:55 -05:00
rob gay
4ffce9e549 MetaSound Member localization options menu support for DisplayName & Tooltip
[REVIEW] helen.yang
#jira UE-142556
#preflight 620acc9d4d320dbf4c29ac0e
#lockdown nick.whiting

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19058366 in //UE5/Release-5.0/... via CL 19066031
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19067166 by rob gay in ue5-main branch]
2022-02-21 03:09:54 -05:00
rob gay
f2973c965f - Fix propagation issues with Preset input defaults
- Add UX for overriding preset inputs (allowing auto-update to pass through referenced value if not managed)
- Clarify code by moving bAutoUpdateManagestInterface to bIsPreset in new FMetasoundFrontendGraphClassPresetOptions struct
#rb phil.popp
#jira UE-136242
#preflight 6202b1bfae203853a85c6366
#rnx

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18911247 in //UE5/Release-5.0/... via CL 18919315 via CL 18920513
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18920762 by rob gay in ue5-main branch]
2022-02-09 12:52:07 -05:00
helen yang
a421fe4d4d Fixes for MetaSound rename and delete editor commands
- Change delete command to only use delete key instead of backspace
- Allow rename action on interface menu items
- Fix crash caused by invalid rename request handle

#jira UE-135967
#rb rob.gay
#preflight 61efab0ca5126b4d3e833747

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18725047 in //UE5/Release-5.0/... via CL 18725247 via CL 18725393
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18725412 by helen yang in ue5-main branch]
2022-01-25 13:25:11 -05:00
rob gay
f15e92afd2 Fix static analysis warning
#rb trivial
#jira none
#rnx
#preflight 61d51eb8c73b7e46b2631f0a

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18516239 in //UE5/Release-5.0/... via CL 18516248
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18516253 by rob gay in ue5-release-engine-test branch]
2022-01-04 23:44:51 -05:00
rob gay
14ae84810f - Add support for MetaSound Editor UObject array drag/drop
- Checkpoint: Clean-up MetaSound Editor Graph Literal Customization Factory Code
#rb phil.popp
#rnx
#jira UE-112876
#jira UE-137578
#preflight 61d397605d522c9b407a6e29

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18512006 in //UE5/Release-5.0/... via CL 18512018
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18512066 by rob gay in ue5-release-engine-test branch]
2022-01-04 15:17:54 -05:00
helen yang
e692a370b4 Enable F2 for renaming MetaSound member and comment nodes
- Also add rename to action menu when right clicking on node

#jira UE-116872
#rb rob.gay
#preflight 61ba5c8c08091d99edcc6cac


#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18476783 in //UE5/Release-5.0/... via CL 18481369
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18481462 by helen yang in ue5-release-engine-test branch]
2021-12-16 19:29:43 -05:00
rob gay
3e9eab6da9 - Rename & redirect MetaSoundEditorGraph<Input>Literals to MetaSoundEditorGraph<DefaultMember>Literals
- First pass at consolidating editor code for API members/vertices where possible
- Make Variables & Output now use default literal for input value (so user doesn't have to hunt down literal box in graph)

Various bug fixes:
- Fixes crash in post undo after updating a variable default
- Fixes ':Array' flavor showing up in new SearchableComboBox when selecting `Is Array` for literal type
- Synchronize variable setter default literal with variable interface default literal
- Provide default literal field for outputs & variables for consistency
    - Added win is widget support for single input/output types (i.e. floats for now)
- Don't show trigger simulate option on non-transmissible inputs (ex. OnPlay)
- Set simulate button visibility to only show when parameter transmission is supported by input
- Make simulate buttons in graph only visible when sound plays
- Start sounds automatically when clicking simulate in inspector
- Fixed initial condition "holding" trigger state for trigger routing now that Transmission System is only used inter-MetaSound (not intra-MetaSound) and we are deprecating Send/Receives

#rb phil.popp
#rnx
#jira UE-135813
#jira UE-132900
#jira UE-135844
#jira UE-116867
#jira UE-135366
#jira UE-137310
#preflight 61b7afe4fc570891338fea08

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18450046 in //UE5/Release-5.0/... via CL 18450065
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18450072 by rob gay in ue5-release-engine-test branch]
2021-12-13 18:15:01 -05:00
rob gay
ff8b5954ac MetaSounds Interface Checkpoint
- Archetype to Interface rename & support for multiple interface versions stored on MetaSoundBase
- Added ability to register interfaces
- Added spatialization/attenuation interfaces
- Added UX to add/remove Interfaces
- Fix ensure when deleting UMetaSound asset
#rb phil.popp
#jira UE-135000
#jira UE-120656
#rnx
#preflight 619bd9e33a7219926732337c

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18262648 in //UE5/Release-5.0/... via CL 18262703
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18262725 by rob gay in ue5-release-engine-test branch]
2021-11-22 15:55:50 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
rob gay
38332680ea Move FString/FText VertexName identifers to FNames. Convention is as follows:
- FGuid IDs are used to identify unique verticies within an entire graph (currently may be duplicated if graph is duplicated).
- FNames are used to be readible vertex identifiers that are only unique within a node's API.
- FText is only for ***OPTIONAL*** DisplayNames that can be provided as a more descriptive, readible descriptor of a given vertex (But are not necessarily unique). Currently disabled until loc tool on FText property in MetaSoundDetailsCustomization is properly displayed.
#rb phil.popp
#jira UE-123982
#preflight 613f6ff892b32b00016cf188

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 17494445 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17494469 by rob gay in ue5-release-engine-test branch]
2021-09-13 14:14:37 -04:00
rob gay
ab8b6faad9 First pass on MetaSound Composition/Preset Support
- Stubbed in logic & assets for MetaSound Editor UX node type differentiation
#rb phil.popp
#preflight 60ff8c19d8303000018f29fb

#ROBOMERGE-SOURCE: CL 16969987 via CL 16972219
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16972392 by rob gay in ue5-release-engine-test branch]
2021-07-27 15:36:03 -04:00
rob gay
0e4f7a7c51 MetaSound UI/UX Composition/Preset Scaffolding
- Revive UMetaSound Asset type
- Revive MS Output generation
- Fix copy pasta'ed type name so MetaSound Source shows up properly in editor
- Clean-up to dynamic doc version reporting if required (show the new version number in log)
- Add versioning to update the RootGraphClass name & add DisplayName

MetaSound Registry Scaffolding Part 1 (From Phil Popp)

#rb phil.popp
#jira UE-117108
#jira UE-117109
#jira UE-117110
#preflight 60bf11780c76f90001db5f5f


#ROBOMERGE-SOURCE: CL 16587155
#ROBOMERGE-BOT: (v828-16531559)

[CL 16587204 by rob gay in ue5-main branch]
2021-06-08 10:52:31 -04:00
Rob Gay
fb2b94be59 - Disallow renaming Required MetaSound Inputs/Outputs (ex. 'On Finished') from GraphActionView name selector
- Remove dead customization code
#rb trivial
#fyi Sondra.Moyles
#jira none
#preflight https://horde.devtools.epicgames.com/job/6099b9540fb8f20001375b2f

[CL 16262997 by Rob Gay in ue5-main branch]
2021-05-10 23:17:10 -04:00
rob gay
080ec409b3 More MetaSound UX Clean-up
- LogTemp & LogMetasound to LogMetaSound
- Hide Import/Export UI options (to/from Json) for EA from editor as its halfbaked
- Reorder node right-click context menu entries to follow suit with BP
- Add new dedicated metasound icon
#rb trivial
#jira none
#preflight 6066b882e0e94d0001afa196

#ROBOMERGE-SOURCE: CL 15899641 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15899642 by rob gay in ue5-main branch]
2021-04-02 03:03:27 -04:00