Commit Graph

355 Commits

Author SHA1 Message Date
rob gay
dd9a5f1904 Fix comment missed in last CL review
#rb trivial
#rnx

[CL 26715632 by rob gay in ue5-main branch]
2023-07-31 14:37:22 -04:00
rob gay
42fd61fc37 - Add ability to set node position explicitly via MetaSound Editor Subsystem
- Fix bug introduced recently with BuildToAsset not applying a clean class name/guid
- Fix case where builder was added to root and not freed
- MetaSoundEditorSubsystem minor clean-up
#rb helen.yang
#jira UE-191435 UE-191505
#rnx

[CL 26715091 by rob gay in ue5-main branch]
2023-07-31 14:25:14 -04:00
helen yang
94619674a8 Fix crash when closing the MetaSound asset editor while dragging an input widget
#rb rob.gay
#jira UE-180002

[CL 26685540 by helen yang in ue5-main branch]
2023-07-28 16:04:46 -04:00
helen yang
f4a60f218c Fix MetaSound reroute nodes not retaining connections when copy pasted
#jira UE-187355
#rb rob.gay

[CL 26680883 by helen yang in ue5-main branch]
2023-07-28 14:20:27 -04:00
rob gay
25d8a69d81 Fix for new asset not getting registered until opened in MetaSound editor
#rb helen.yang
#rnx
#jira UE-191038

[CL 26559474 by rob gay in ue5-main branch]
2023-07-24 19:39:47 -04:00
helen yang
f3f3bdc16d Fix ensures with empty MetaSound object literals
#jira UE-189035
#jira UE-189600
#rb rob.gay

[CL 26553864 by helen yang in ue5-main branch]
2023-07-24 16:12:33 -04:00
helen yang
fa585989cf Fix ensures when migrating MetaSound assets
- Create new class names for temporary packages created during migration to avoid duplicate node registration
- Change duplicate node registration ensure to if check with better logging of asset causing collision

#jira UE-161039
#jira UE-175059
#jira UE-188854
#rb rob.gay

[CL 26299244 by helen yang in ue5-main branch]
2023-06-28 17:08:29 -04:00
helen yang
b5786147db Add missing soundwave/soundbase properties when copying over properties from template MetaSounds
#jira UE-188868
#rb rob.gay
#rnx

[CL 26261041 by helen yang in ue5-main branch]
2023-06-27 12:29:39 -04:00
rob gay
e8b188037d Forbid naming MetaSound members as that of existing namespace members on the given document
#rb helen.yang
#jira UE-187081
#rnx

[CL 26186719 by rob gay in ue5-main branch]
2023-06-22 13:23:47 -04:00
rob gay
87d79313d5 Forbid naming MetaSound members as that of existing namespace members on the given document
#rb helen.yang
#jira UE-187081

[CL 26158009 by rob gay in ue5-main branch]
2023-06-21 15:12:58 -04:00
joe kirchoff
fc49b3b34f Fix C4855: implicit capture of 'this' via '[=]' is deprecated in '/std:c++20'
#rnx

[CL 26110412 by joe kirchoff in ue5-main branch]
2023-06-19 19:55:34 -04:00
rob gay
fff5e641ae Fix for editor crash when using BuildToAsset over a pre-existing asset due to GC nuking the referenced builder that is in use
#rb helen.yang
#jira UE-187644
#rnx

[CL 26024990 by rob gay in ue5-main branch]
2023-06-15 16:33:37 -04:00
helen yang
b96bfc6b97 Nonunity fix for copying over Sound Wave properties for MetaSound presets
#rb trivial

#rnx

[CL 26020402 by helen yang in ue5-main branch]
2023-06-15 14:01:47 -04:00
helen yang
9962c8f51a Copy soundbase/soundwave settings from referenced MetaSound source to new preset
- Add option to BuildToAsset to copy settings from a given template SoundWave
- Update CreatePreset right click asset action to use builder instead of factory

#jira UE-170991
#rb rob.gay

[CL 26019769 by helen yang in ue5-main branch]
2023-06-15 13:50:27 -04:00
bryan sefcik
83a1278b44 Broke circular dependencies:
AutomationController -> UnrealEd -> AutomationController
SubobjectEditor -> UnrealEd -> SubobjectEditor

#preflight 6478a225c26e3b2449f13c0f
#jira

[CL 25730973 by bryan sefcik in ue5-main branch]
2023-06-01 13:04:00 -04:00
helen yang
cc09fda972 Expand and consolidate MetaSound builder preset asset functionality
- Added document builder and BP functions for SetGraphInputDefault, ConvertFromPreset, ConvertToPreset, CreatePatch/SourcePresetBuilder, IsPreset
- Refactor MetaSound asset and preset initialization to use builder architecture more

#jira UE-185391
#rb rob.gay
#preflight 64710f423b73ebeef4c295bb

[CL 25683338 by helen yang in ue5-main branch]
2023-05-30 14:39:48 -04:00
nicholas howe
1cff9d7ff8 MetaSound Frontend allows derived classes to attach to base class pins at runtime.
FDataTypeRegistry::GetDataTypeInfo walks up the class hierarchy searching for a registered class.
Adds FDataTypeRegistryInfo::bIsExplicit to replace the editor's IsExplicitProxyClass and enable the same functionality of requiring exact types at runtime.

#rb rob.gay
[REVIEW] [at]phil.popp
#preflight 6470afe55d3ca2dfd99ab6a1

[CL 25649438 by nicholas howe in ue5-main branch]
2023-05-26 13:55:21 -04:00
helen yang
b6f8ab6963 Fix reset to default arrows appearing on MetaSound object inputs and reroute nodes when copy/pasted
#jira UE-178478
#jira UE-185588
#rb rob.gay
#preflight 645e9b93ea1c7ba4d6353974

[CL 25644616 by helen yang in ue5-main branch]
2023-05-26 12:08:50 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
bryan sefcik
91c57d395e Removed redundant module includes.
#preflight 645d4bf3aa3c584c0b5b3a67

[CL 25435653 by bryan sefcik in ue5-main branch]
2023-05-11 16:48:21 -04:00
rob gay
d3e70524dc - Migrate and deprecate modify interfaces transform to frontend document builder with broken up, useful functionality available now to the API (ex. SwapInput/Output)
- New version no longer uses expensive controller system
- Fix-up & condense asset/builder initialization logic that utilizes modify interface transform functionality
- Misc clean-up
#rb helen.yang
#jira UE-120184
#rnx
#preflight 645bfd468e01daf0e5b92c30

[CL 25420172 by rob gay in ue5-main branch]
2023-05-10 20:28:39 -04:00
Steve Robb
6e70eb4dc4 Added TCallTraits::ConstPointerType overrides for common smart pointer types so that they you can look up a TSmartPtr<const T> in a map or set with a TSmartPtr<T> key.
Fixed some const incorrectness caused as a fallout.

#rb robert.manuszewski
#jira none
#preflight 645bb07be81da34de94c3e08

[CL 25405828 by Steve Robb in ue5-main branch]
2023-05-10 11:12:33 -04:00
miles flanagan
3ab7304bd6 Make PlayOrder of most recently played sound accessible from Audio Component, fix editor graph analyzers
#jira UE-185275
#preflight 645993da386cf3c2732af69f
#rb rob.gay, charlie.huguenard

[CL 25390291 by miles flanagan in ue5-main branch]
2023-05-09 12:59:07 -04:00
Rob Gay
49c739169c Fix class references misguided towards transient MetaSound class instead of MetaSound Builder class causing failures to add/remove interfaces in certain contexts
#rb phil.popp
#jira UE-181360
#preflight 642f15426d46f6b1bfac1f59
#rnx

[CL 24955760 by Rob Gay in ue5-main branch]
2023-04-06 16:32:00 -04:00
rob gay
1de499ef8e More MetaSound Interface registry clean-up
- Move bIsDefault/bCanEdit(renamed bIsModifiable) from InterfaceRegistryEntry to Interface data definition
- Add checks in builder to disallow mutation of interfaces that shouldn't be via editor or document builder (ex. SourceInterface which is default and then never changed)
- Optimize SearchEngine query for finding default interfaces
- Tweak MetaSoundUObjectRegistry to support non MetasoundAssetBase classes and add UMetaSoundBuilderDocument. Update iterator w/optional param to only return asset types (true by default for back compat)
- Move FName class name comparitors to use new TopLevelAssetPath
#rb phil.popp
#jira UE-181360
#rnx
#p4v-preflight-copy 24658328
#preflight 642b10834d26bcd1eb0e566c

[CL 24920763 by rob gay in ue5-main branch]
2023-04-04 19:14:26 -04:00