Commit Graph

6 Commits

Author SHA1 Message Date
robert millar
3d9c7360f7 Update stall log subsystem for stall detector changes
#rb none
#jira UE-179587

[CL 24920979 by robert millar in ue5-main branch]
2023-04-04 19:20:38 -04:00
logan buchy
ab568b48c0 Defer symbolification of BackTrace captured by Stall Logger
* Further mitigation to avoid Asset Validation errors. Another issue that came up was that if symbols are not found, then a warning is generated by the platform layer which Asset Validation picks up and assumes is a failure of the asset.
* Mitigation strategy is that Asset Validation is a SlowTask and blocks the user from interfacing with the editor anyways.  Stall log should be able to do a backtrace without upsetting the Asset Validator.
* This is technically safer to do on Windows and also doesn't pull in large PDBs unnecessarily.
* Symbol resolving is off by default, but can be enabled with a CVar.

#rb Ronald.Koppers

[CL 24756409 by logan buchy in ue5-main branch]
2023-03-22 19:43:50 -04:00
logan buchy
29346d4a9a Remove logging from EditorPerformanceModule
* Appears to conflict with Asset Validation - Asset Validation picks up the warning that the stall detector generates and causes false failures.

#rb Ronald.Koppers
#preflight 6419dad2691c5ebc15e1ca64

[CL 24737152 by logan buchy in ue5-main branch]
2023-03-21 15:05:47 -04:00
logan buchy
921c0394f8 Fix mac editor compile
* StallLogSubsystem depends on StallDetector, StallDetector does not define anything on mac
#preflight 6418e626691c5ebc15a0af69

[CL 24726332 by logan buchy in ue5-main branch]
2023-03-20 19:34:08 -04:00
logan buchy
37835619f3 Fix Non-Unity build errors in EditorPerformanceModule
[CL 24724618 by logan buchy in ue5-main branch]
2023-03-20 17:39:15 -04:00
logan buchy
3d7aaddad3 A subsystem to bubble up notifications from the StallDetector
* The subsystem adds a new toolbar widget in the level editor which changes to a notified state when a stall is detected.
* Clicking the widget brings up a tab with a table of the detected stall history.  Each stall has some information that can be copied to a clipboard for users to dump the data into a issue ticket or chat message.
* NOTE: Currently iconography is all placeholders. Need UX pass to improve.

#jira UE-174529
#rb Brooke.Hubert
#preflight 6414f70632723d4a2081491c
#preflight 64189fb032723d4a204d20ac

[CL 24724541 by logan buchy in ue5-main branch]
2023-03-20 17:36:50 -04:00